[request for review] 4877954: RFE: Special syntax for core interfaces

Re'mi Forax forax at univ-mlv.fr
Mon Nov 19 05:39:00 PST 2007

Dmytro Sheyko a e'crit :
> Hi,
> I've made some changes to patch:
> 1. big*Type in Symtab were removed and Lower.visitBinary() was 
> rewritten using Types.unboxedType() (as Remi Forax suggested)
> 2. 'genuine comparable method' is choosen rather than its bridge 
> (Lower.visitBinary).
> 3. bug fixed: following code was mistakenly rejected by compiler:
> static <B, A extends Comparable<? super B>> boolean lt1(A a, B b) {
> return a < b;
> }
> I have attached new svn diff and jtreg tests I used. 
Hi Dmytro, sorry for the delay,
great, job, i have just a small remark
In Lower.visitBinary(), acmp is used two times with different meanings,
import static and local variable, i think the local variable could be 
Futhermore, unboxedComparison can be inlined in visiBinary() because
it is used only once and the if/else will be more balanced.


More information about the compiler-dev mailing list