hg: jdk7/tl/langtools: 6574134: Allow for alternative implementation of Name Table with garbage collection of name bytes

[Jonathan Gibbons]

Neal,

No. Do you have reason to believe there might have been any significant 
impact?
Standard (batch mode) javac uses basically the same impl of NameTable as 
it always
did. The primary use of Name is to check for reference equality, which 
will not be
affected; so the only impact would be to use methods rather than direct 
access
to fields when working with the content of a Name, and Hotspot should 
optimize
those method calls.

-- Jon


Neal Gafter wrote:
> Jon-
>
> Just curious: did you do any measurements of the performance impact of 
> this change?
>
> Regards,
> Neal
>
> On Tue, Sep 16, 2008 at 5:36 PM, <jonathan.gibbons at sun.com 
> <mailto:jonathan.gibbons at sun.com>> wrote:
>
>     Changeset: eff38cc97183
>     Author:    jjg
>     Date:      2008-09-16 18:35 -0700
>     URL:      
>     http://hg.openjdk.java.net/jdk7/tl/langtools/rev/eff38cc97183
>
>     6574134: Allow for alternative implementation of Name Table with
>     garbage collection of name bytes
>     Reviewed-by: darcy, mcimadamore
>
>     ! src/share/classes/com/sun/tools/apt/mirror/AptEnv.java
>     ! src/share/classes/com/sun/tools/javac/code/Attribute.java
>     ! src/share/classes/com/sun/tools/javac/code/Scope.java
>     ! src/share/classes/com/sun/tools/javac/code/Symbol.java
>     ! src/share/classes/com/sun/tools/javac/code/Symtab.java
>     ! src/share/classes/com/sun/tools/javac/code/Type.java
>     ! src/share/classes/com/sun/tools/javac/code/Types.java
>     ! src/share/classes/com/sun/tools/javac/comp/Annotate.java
>     ! src/share/classes/com/sun/tools/javac/comp/Attr.java
>     ! src/share/classes/com/sun/tools/javac/comp/Check.java
>     ! src/share/classes/com/sun/tools/javac/comp/Enter.java
>     ! src/share/classes/com/sun/tools/javac/comp/Flow.java
>     ! src/share/classes/com/sun/tools/javac/comp/Lower.java
>     ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java
>     ! src/share/classes/com/sun/tools/javac/comp/Resolve.java
>     ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java
>     ! src/share/classes/com/sun/tools/javac/jvm/ClassFile.java
>     ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java
>     ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java
>     ! src/share/classes/com/sun/tools/javac/jvm/Code.java
>     ! src/share/classes/com/sun/tools/javac/jvm/Gen.java
>     ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java
>     !
>     src/share/classes/com/sun/tools/javac/model/AnnotationProxyMaker.java
>     ! src/share/classes/com/sun/tools/javac/model/JavacElements.java
>     ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java
>     ! src/share/classes/com/sun/tools/javac/parser/Keywords.java
>     ! src/share/classes/com/sun/tools/javac/parser/ParserFactory.java
>     ! src/share/classes/com/sun/tools/javac/parser/Scanner.java
>     !
>     src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java
>     ! src/share/classes/com/sun/tools/javac/tree/Pretty.java
>     ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java
>     ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java
>     ! src/share/classes/com/sun/tools/javac/util/ByteBuffer.java
>     ! src/share/classes/com/sun/tools/javac/util/Convert.java
>     ! src/share/classes/com/sun/tools/javac/util/Name.java
>     + src/share/classes/com/sun/tools/javac/util/Names.java
>     + src/share/classes/com/sun/tools/javac/util/SharedNameTable.java
>     + src/share/classes/com/sun/tools/javac/util/UnsharedNameTable.java
>     ! src/share/classes/com/sun/tools/javadoc/AnnotationTypeDocImpl.java
>     ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java
>     ! src/share/classes/com/sun/tools/javadoc/DocEnv.java
>     ! src/share/classes/com/sun/tools/javadoc/SerializedForm.java
>     ! src/share/classes/com/sun/tools/javadoc/TypeVariableImpl.java
>     ! test/tools/javac/unit/util/convert/EnclosingCandidates.java
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20081204/b86444fa/attachment.html