[PATCH FOR REVIEW]: Make source/target options explicit for def-pcompile
Andrew John Hughes
gnu_andrew at member.fsf.org
Wed Aug 19 14:28:54 PDT 2009
2009/8/18 Jonathan Gibbons <Jonathan.Gibbons at sun.com>:
> Andrew John Hughes wrote:
>>
>> The def-pcompile Ant target in the langtools build does not explicitly
>> set the source and target options for javac. As a result, the class
>> files will be built using the default versions of the javac forked by
>> Ant. If this is < 1.5, the build will fail (this is the case with
>> ecj, for example).
>>
>> The webrev:
>>
>> http://cr.openjdk.java.net/~andrew/ecj/01/webrev.01/
>>
>> fixes this by making the values explicit (using the boot source and
>> target values, currently 1.6).
>>
>> Ok to push to tl?
>>
>
> Yes, and please push the same fix to jdk6 as well, to keep the two build
> files in
> alignment.
>
>> Thanks,
>>
>
> -- Jon
>
Done:
http://hg.openjdk.java.net/jdk7/tl/langtools/rev/2aa3a1cdb094
http://hg.openjdk.java.net/jdk6/jdk6/langtools/rev/248be347417b
Thanks,
--
Andrew :-)
Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)
Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8
More information about the compiler-dev
mailing list