From jonathan.gibbons at sun.com Mon Feb 1 17:06:50 2010 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Tue, 02 Feb 2010 01:06:50 +0000 Subject: hg: jdk7/tl/langtools: 6919986: [308] change size of type_index (of CLASS_EXTENDS and THROWS) from byte to short Message-ID: <20100202010653.333D441A1A@hg.openjdk.java.net> Changeset: 732510cc3538 Author: jjg Date: 2010-02-01 17:05 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/732510cc3538 6919986: [308] change size of type_index (of CLASS_EXTENDS and THROWS) from byte to short Reviewed-by: darcy, jjg Contributed-by: mali at csail.mit.edu, mernst at cs.washington.edu ! src/share/classes/com/sun/tools/classfile/ExtendedAnnotation.java ! src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java From ahughes at redhat.com Tue Feb 2 02:55:58 2010 From: ahughes at redhat.com (ahughes at redhat.com) Date: Tue, 02 Feb 2010 10:55:58 +0000 Subject: hg: jdk7/tl/jdk: 6921740: Eliminate warnings from sun.io converters and allow compiling with JAVAC_MAX_WARNINGS=true Message-ID: <20100202105654.49BC641ABA@hg.openjdk.java.net> Changeset: 7dadd2951a8b Author: andrew Date: 2010-02-02 10:55 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7dadd2951a8b 6921740: Eliminate warnings from sun.io converters and allow compiling with JAVAC_MAX_WARNINGS=true Summary: Fix sun.io converters unchecked and cast warnings produced by -Xlint:all Reviewed-by: alanb, sherman ! make/java/sun_nio/Makefile ! src/share/classes/sun/io/ByteToCharUTF8.java ! src/share/classes/sun/io/CharToByteUnicode.java ! src/share/classes/sun/io/CharacterEncoding.java ! src/share/classes/sun/io/Converters.java ! src/share/classes/sun/nio/cs/AbstractCharsetProvider.java From Ulf.Zibis at gmx.de Tue Feb 2 05:09:35 2010 From: Ulf.Zibis at gmx.de (Ulf Zibis) Date: Tue, 02 Feb 2010 14:09:35 +0100 Subject: hg: jdk7/tl/jdk: 6921740: Eliminate warnings from sun.io converters and allow compiling with JAVAC_MAX_WARNINGS=true In-Reply-To: <20100202105654.49BC641ABA@hg.openjdk.java.net> References: <20100202105654.49BC641ABA@hg.openjdk.java.net> Message-ID: <4B68240F.3080904@gmx.de> Hi, in most cases you use the empty diamond operator '<>' on instantiation, but not for SoftReference: "new SoftReference(cs)" in AbstractCharsetProvider.java Why? I don't see a big advantage for casting to (Class) against (Class) for the cache of Converters.java. Wouldn't you better use a small helper class: class CacheEntry { String encoding; Class converter; } Maybe you would like my more general approach, which eliminates the need of any XxxxToYyyyZzzz converters: https://java-nio-charset-enhanced.dev.java.net/source/browse/java-nio-charset-enhanced/tags/milestone3/src/sun/io/Converters.java?rev=530&view=markup https://java-nio-charset-enhanced.dev.java.net/source/browse/java-nio-charset-enhanced/tags/milestone3/src/sun/io/?rev=530 in AbstractCharsetProvider.java you could simply code: Charset cs = (Charset)Class.forName(packagePrefix+'.'+cln, true, this.getClass().getClassLoader()).newInstance(); -Ulf Am 02.02.2010 11:55, schrieb ahughes at redhat.com: > Changeset: 7dadd2951a8b > Author: andrew > Date: 2010-02-02 10:55 +0000 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7dadd2951a8b > > 6921740: Eliminate warnings from sun.io converters and allow compiling with JAVAC_MAX_WARNINGS=true > Summary: Fix sun.io converters unchecked and cast warnings produced by -Xlint:all > Reviewed-by: alanb, sherman > > ! make/java/sun_nio/Makefile > ! src/share/classes/sun/io/ByteToCharUTF8.java > ! src/share/classes/sun/io/CharToByteUnicode.java > ! src/share/classes/sun/io/CharacterEncoding.java > ! src/share/classes/sun/io/Converters.java > ! src/share/classes/sun/nio/cs/AbstractCharsetProvider.java > > > From Ulf.Zibis at gmx.de Tue Feb 2 08:26:14 2010 From: Ulf.Zibis at gmx.de (Ulf Zibis) Date: Tue, 02 Feb 2010 17:26:14 +0100 Subject: hg: jdk7/tl/jdk: 6921740: Eliminate warnings from sun.io converters and allow compiling with JAVAC_MAX_WARNINGS=true In-Reply-To: <4B682901.90302@univ-mlv.fr> References: <20100202105654.49BC641ABA@hg.openjdk.java.net> <4B68240F.3080904@gmx.de> <4B682901.90302@univ-mlv.fr> Message-ID: <4B685226.6020003@gmx.de> Am 02.02.2010 14:30, schrieb R?mi Forax: > Le 02/02/2010 14:09, Ulf Zibis a ?crit : >> Hi, >> >> in most cases you use the empty diamond operator '<>' on >> instantiation, but not for SoftReference: "new >> SoftReference(cs)" in AbstractCharsetProvider.java >> Why? > > SoftReference constructor is SoftReference(T), so there is two ways to > infer the type argument. > > With this code: > SoftReference ref = new SoftReference<>(cs); > the type argument can be infered from the lhs of the assignation or > by the declared type of the parameter (here cs). > So you agree with me, that new SoftReference<>(cs) would suffice ??? >> >> I don't see a big advantage for casting to (Class) against (Class) >> for the cache of Converters.java. > > Rules for Class and Class are not the same. > Class should be only used when dealing with legacy code. One of the advantages of generics is the avoidability of casts. So I wanted to say, if a code becomes reengineerd in generic way, then it should be done in "full way". -Ulf P.S.: Additionally note: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6853699 From forax at univ-mlv.fr Tue Feb 2 09:47:56 2010 From: forax at univ-mlv.fr (=?ISO-8859-15?Q?R=E9mi_Forax?=) Date: Tue, 02 Feb 2010 18:47:56 +0100 Subject: hg: jdk7/tl/jdk: 6921740: Eliminate warnings from sun.io converters and allow compiling with JAVAC_MAX_WARNINGS=true In-Reply-To: <4B685226.6020003@gmx.de> References: <20100202105654.49BC641ABA@hg.openjdk.java.net> <4B68240F.3080904@gmx.de> <4B682901.90302@univ-mlv.fr> <4B685226.6020003@gmx.de> Message-ID: <4B68654C.2050503@univ-mlv.fr> Le 02/02/2010 17:26, Ulf Zibis a ?crit : > Am 02.02.2010 14:30, schrieb R?mi Forax: >> Le 02/02/2010 14:09, Ulf Zibis a ?crit : >>> Hi, >>> >>> in most cases you use the empty diamond operator '<>' on >>> instantiation, but not for SoftReference: "new >>> SoftReference(cs)" in AbstractCharsetProvider.java >>> Why? >> >> SoftReference constructor is SoftReference(T), so there is two ways >> to infer the type argument. >> >> With this code: >> SoftReference ref = new SoftReference<>(cs); >> the type argument can be infered from the lhs of the assignation or >> by the declared type of the parameter (here cs). >> > > So you agree with me, that new SoftReference<>(cs) would suffice ??? No. The code is: cache.put(csn, new SoftReference(cs)); It will not compile, because Object will be infered. Diamond doesn't take care about method's parameter types (Maurizio correct me if I'm wrong) > > -Ulf > R?mi From jonathan.gibbons at sun.com Tue Feb 2 10:56:51 2010 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Tue, 02 Feb 2010 18:56:51 +0000 Subject: hg: jdk7/tl/langtools: 6918625: handle annotations on array class literals Message-ID: <20100202185657.D68DA41B3E@hg.openjdk.java.net> Changeset: b0a68258360a Author: jjg Date: 2010-02-02 10:56 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/b0a68258360a 6918625: handle annotations on array class literals Reviewed-by: jjg, darcy Contributed-by: mali at csail.mit.edu, mernst at cs.washington.edu ! src/share/classes/com/sun/tools/classfile/ClassWriter.java ! src/share/classes/com/sun/tools/javac/code/TypeAnnotationPosition.java ! src/share/classes/com/sun/tools/javap/AnnotationWriter.java + test/tools/javap/typeAnnotations/ArrayClassLiterals2.java From weijun.wang at sun.com Wed Feb 3 01:05:38 2010 From: weijun.wang at sun.com (weijun.wang at sun.com) Date: Wed, 03 Feb 2010 09:05:38 +0000 Subject: hg: jdk7/tl/jdk: 6922482: keytool's help on -file always shows 'output file' Message-ID: <20100203090557.EA89A41C0D@hg.openjdk.java.net> Changeset: e6ab5fabaf7e Author: weijun Date: 2010-02-03 17:04 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e6ab5fabaf7e 6922482: keytool's help on -file always shows 'output file' Reviewed-by: wetmore ! src/share/classes/sun/security/tools/KeyTool.java + test/sun/security/tools/keytool/file-in-help.sh From jonathan.gibbons at sun.com Wed Feb 3 11:30:03 2010 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Wed, 03 Feb 2010 19:30:03 +0000 Subject: hg: jdk7/tl/langtools: 6922429: extend tree position test waiver Message-ID: <20100203193007.89B9541CA0@hg.openjdk.java.net> Changeset: 41ed86f86585 Author: jjg Date: 2010-02-03 11:28 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/41ed86f86585 6922429: extend tree position test waiver Reviewed-by: darcy ! test/tools/javac/treepostests/TreePosTest.java From jonathan.gibbons at sun.com Wed Feb 3 11:34:44 2010 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Wed, 03 Feb 2010 19:34:44 +0000 Subject: hg: jdk7/tl/langtools: 6922300: [308] populate the reference_info for type annotations targeting primitive class literals Message-ID: <20100203193447.15D9E41CA3@hg.openjdk.java.net> Changeset: f65d652cb6af Author: jjg Date: 2010-02-03 11:33 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/f65d652cb6af 6922300: [308] populate the reference_info for type annotations targeting primitive class literals Reviewed-by: darcy, jjg Contributed-by: mali at csail.mit.edu, mernst at cs.washington.edu ! src/share/classes/com/sun/tools/javac/jvm/Gen.java From jonathan.gibbons at sun.com Wed Feb 3 17:00:01 2010 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Thu, 04 Feb 2010 01:00:01 +0000 Subject: hg: jdk7/tl/langtools: 6921979: add test program to verify annotations are attached to nodes as expected Message-ID: <20100204010005.8EB9C41CF3@hg.openjdk.java.net> Changeset: 4c844e609d81 Author: jjg Date: 2010-02-03 16:58 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/4c844e609d81 6921979: add test program to verify annotations are attached to nodes as expected Reviewed-by: darcy + test/tools/javac/treeannotests/AnnoTreeTests.java + test/tools/javac/treeannotests/DA.java + test/tools/javac/treeannotests/TA.java + test/tools/javac/treeannotests/Test.java + test/tools/javac/treeannotests/TestProcessor.java From jonathan.gibbons at sun.com Thu Feb 4 10:16:14 2010 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Thu, 04 Feb 2010 18:16:14 +0000 Subject: hg: jdk7/tl/langtools: 6923080: TreeScanner.visitNewClass should scan tree.typeargs Message-ID: <20100204181622.B36DC41DF7@hg.openjdk.java.net> Changeset: 4b4e282a3146 Author: jjg Date: 2010-02-04 10:14 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/4b4e282a3146 6923080: TreeScanner.visitNewClass should scan tree.typeargs Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/tree/TreeScanner.java + test/tools/javac/tree/T6923080.java + test/tools/javac/tree/TreeScannerTest.java From Ulf.Zibis at gmx.de Thu Feb 4 16:15:02 2010 From: Ulf.Zibis at gmx.de (Ulf Zibis) Date: Fri, 05 Feb 2010 01:15:02 +0100 Subject: hg: jdk7/tl/jdk: 6921740: Eliminate warnings from sun.io converters and allow compiling with JAVAC_MAX_WARNINGS=true In-Reply-To: <4B68654C.2050503@univ-mlv.fr> References: <20100202105654.49BC641ABA@hg.openjdk.java.net> <4B68240F.3080904@gmx.de> <4B682901.90302@univ-mlv.fr> <4B685226.6020003@gmx.de> <4B68654C.2050503@univ-mlv.fr> Message-ID: <4B6B6306.8040404@gmx.de> Am 02.02.2010 18:47, schrieb R?mi Forax: > Le 02/02/2010 17:26, Ulf Zibis a ?crit : >> Am 02.02.2010 14:30, schrieb R?mi Forax: >>> Le 02/02/2010 14:09, Ulf Zibis a ?crit : >>>> Hi, >>>> >>>> in most cases you use the empty diamond operator '<>' on >>>> instantiation, but not for SoftReference: "new >>>> SoftReference(cs)" in AbstractCharsetProvider.java >>>> Why? >>> >>> SoftReference constructor is SoftReference(T), so there is two ways >>> to infer the type argument. >>> >>> With this code: >>> SoftReference ref = new SoftReference<>(cs); >>> the type argument can be infered from the lhs of the assignation or >>> by the declared type of the parameter (here cs). >>> >> >> So you agree with me, that new SoftReference<>(cs) would suffice ??? > > No. > The code is: > > cache.put(csn, new SoftReference(cs)); > > > It will not compile, because Object will be infered. > Diamond doesn't take care about method's parameter types Hm? 1. Why ? (IMO would be resonable) 2. Didn't you say, type argument can be infered by the declared type of the parameter (here cs) ? -Ulf From kelly.ohair at sun.com Thu Feb 4 18:36:24 2010 From: kelly.ohair at sun.com (kelly.ohair at sun.com) Date: Fri, 05 Feb 2010 02:36:24 +0000 Subject: hg: jdk7/tl/jaxp: 6923146: Upgrade to JAXP 1.4.3 Message-ID: <20100205023624.C05DF41E6F@hg.openjdk.java.net> Changeset: df2e196a5f01 Author: ohair Date: 2010-02-03 16:44 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/df2e196a5f01 6923146: Upgrade to JAXP 1.4.3 Reviewed-by: darcy ! jaxp.properties From xueming.shen at sun.com Fri Feb 5 00:13:48 2010 From: xueming.shen at sun.com (xueming.shen at sun.com) Date: Fri, 05 Feb 2010 08:13:48 +0000 Subject: hg: jdk7/tl/jdk: 6919132: Regex \P{Lu} selects half of a surrogate pari Message-ID: <20100205081442.6ED3E41EC1@hg.openjdk.java.net> Changeset: a39e899aa5dc Author: sherman Date: 2010-02-05 00:10 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a39e899aa5dc 6919132: Regex \P{Lu} selects half of a surrogate pari Summary: To use StartS for complement category/block class Reviewed-by: martin, okutsu ! src/share/classes/java/util/regex/Pattern.java ! test/java/util/regex/RegExTest.java From forax at univ-mlv.fr Fri Feb 5 02:20:47 2010 From: forax at univ-mlv.fr (=?ISO-8859-15?Q?R=E9mi_Forax?=) Date: Fri, 05 Feb 2010 11:20:47 +0100 Subject: hg: jdk7/tl/jdk: 6921740: Eliminate warnings from sun.io converters and allow compiling with JAVAC_MAX_WARNINGS=true In-Reply-To: <4B6B6306.8040404@gmx.de> References: <20100202105654.49BC641ABA@hg.openjdk.java.net> <4B68240F.3080904@gmx.de> <4B682901.90302@univ-mlv.fr> <4B685226.6020003@gmx.de> <4B68654C.2050503@univ-mlv.fr> <4B6B6306.8040404@gmx.de> Message-ID: <4B6BF0FF.7000009@univ-mlv.fr> Le 05/02/2010 01:15, Ulf Zibis a ?crit : > Am 02.02.2010 18:47, schrieb R?mi Forax: >> Le 02/02/2010 17:26, Ulf Zibis a ?crit : >>> Am 02.02.2010 14:30, schrieb R?mi Forax: >>>> Le 02/02/2010 14:09, Ulf Zibis a ?crit : >>>>> Hi, >>>>> >>>>> in most cases you use the empty diamond operator '<>' on >>>>> instantiation, but not for SoftReference: "new >>>>> SoftReference(cs)" in AbstractCharsetProvider.java >>>>> Why? >>>> >>>> SoftReference constructor is SoftReference(T), so there is two ways >>>> to infer the type argument. >>>> >>>> With this code: >>>> SoftReference ref = new SoftReference<>(cs); >>>> the type argument can be infered from the lhs of the assignation or >>>> by the declared type of the parameter (here cs). >>>> >>> >>> So you agree with me, that new SoftReference<>(cs) would suffice ??? >> >> No. >> The code is: >> >> cache.put(csn, new SoftReference(cs)); >> >> >> It will not compile, because Object will be infered. >> Diamond doesn't take care about method's parameter types > > Hm? > 1. Why ? (IMO would be resonable) > 2. Didn't you say, type argument can be infered by the declared type > of the parameter (here cs) ? > > -Ulf > For the whole story see: http://mail.openjdk.java.net/pipermail/coin-dev/2009-November/002393.html R?mi From bradford.wetmore at sun.com Fri Feb 5 17:07:13 2010 From: bradford.wetmore at sun.com (bradford.wetmore at sun.com) Date: Sat, 06 Feb 2010 01:07:13 +0000 Subject: hg: jdk7/tl/jdk: 6923976: TestProviderLeak.java is using too small of an initial heap under newer Hotspot (b79+) Message-ID: <20100206010751.E300441FBF@hg.openjdk.java.net> Changeset: 7136683a33d2 Author: wetmore Date: 2010-02-05 17:05 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7136683a33d2 6923976: TestProviderLeak.java is using too small of an initial heap under newer Hotspot (b79+) Reviewed-by: ohair ! test/com/sun/crypto/provider/KeyFactory/TestProviderLeak.java From xueming.shen at sun.com Sat Feb 6 09:31:17 2010 From: xueming.shen at sun.com (xueming.shen at sun.com) Date: Sat, 06 Feb 2010 17:31:17 +0000 Subject: hg: jdk7/tl/jdk: 6923692: java/classes_util TEST_BUG:ReadZip.java fails when Message-ID: <20100206173207.B11DE4144C@hg.openjdk.java.net> Changeset: 445b9928fb70 Author: sherman Date: 2010-02-06 09:26 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/445b9928fb70 6923692: java/classes_util TEST_BUG:ReadZip.java fails when Summary: to create the test file at test.dir Reviewed-by: alanb ! test/java/util/zip/ZipFile/ReadZip.java From david.lloyd at redhat.com Mon Feb 8 18:46:47 2010 From: david.lloyd at redhat.com (David M. Lloyd) Date: Mon, 08 Feb 2010 20:46:47 -0600 Subject: 6908259: Covariance bug for multiple interface inheritence Message-ID: <4B70CC97.7080906@redhat.com> I've produced a patch for javac bug #6908259 which appears to fix the issue, at first blush. Before engaging in more rigorous testing and figuring out how to do this jtreg thing, can someone in the know have a glance over this patch and see if it makes any sense? See http://bugs.sun.com/view_bug.do?bug_id=6908259 for a detailed description of the problem. My attached patch tries to work around the issue by detecting when two incompatible methods are both overridden, and if so, it does an extra check to see if the overriding method is a valid covariation (?) of both methods. - DML -------------- next part -------------- A non-text attachment was scrubbed... Name: bug-6908259-v1.patch Type: text/x-patch Size: 1566 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20100208/2712c0d5/bug-6908259-v1.patch From Maurizio.Cimadamore at Sun.COM Tue Feb 9 02:10:19 2010 From: Maurizio.Cimadamore at Sun.COM (Maurizio Cimadamore) Date: Tue, 09 Feb 2010 10:10:19 +0000 Subject: 6908259: Covariance bug for multiple interface inheritence In-Reply-To: <4B70CC97.7080906@redhat.com> References: <4B70CC97.7080906@redhat.com> Message-ID: <4B71348B.8000409@sun.com> David M. Lloyd wrote: > I've produced a patch for javac bug #6908259 which appears to fix the > issue, at first blush. Before engaging in more rigorous testing and > figuring out how to do this jtreg thing, can someone in the know have > a glance over this patch and see if it makes any sense? > > See http://bugs.sun.com/view_bug.do?bug_id=6908259 for a detailed > description of the problem. > > My attached patch tries to work around the issue by detecting when two > incompatible methods are both overridden, and if so, it does an extra > check to see if the overriding method is a valid covariation (?) of > both methods. We also have a patch that is currently applied to JDK 7: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/4a3b9801f7a0 The fix looks a bit more complex than yours (it adds a new method in check that finds the common covariant overrider in the superclass hiererachy) - in fact there could be situations in which the last method in the hierarchy does NOT define the common overrider, as in one of the regression tests attached above: class T6294779b { interface I1 { List m(); } interface I2 { Queue m(); } interface I3 { LinkedList m(); } interface I4 extends I1, I2, I3 {} } In this case, I4 is well-formed as one of the implementing interfaces --- namely I3 --- is defining a method which is compatible with all other signatures from I1,I2. Maurizio > > - DML > From neal at gafter.com Tue Feb 9 07:29:30 2010 From: neal at gafter.com (Neal Gafter) Date: Tue, 9 Feb 2010 07:29:30 -0800 Subject: 6908259: Covariance bug for multiple interface inheritence In-Reply-To: <4B71348B.8000409@sun.com> References: <4B70CC97.7080906@redhat.com> <4B71348B.8000409@sun.com> Message-ID: <15e8b9d21002090729p577d9b16t9d26e438722bcec0@mail.gmail.com> Maurizio- Can you please tell me what JLS3 rule justifies failing to compile T6294779c.java? I was not able to find anything. Cheers, Neal On Tue, Feb 9, 2010 at 2:10 AM, Maurizio Cimadamore wrote: > David M. Lloyd wrote: >> >> I've produced a patch for javac bug #6908259 which appears to fix the >> issue, at first blush. ?Before engaging in more rigorous testing and >> figuring out how to do this jtreg thing, can someone in the know have a >> glance over this patch and see if it makes any sense? >> >> See http://bugs.sun.com/view_bug.do?bug_id=6908259 for a detailed >> description of the problem. >> >> My attached patch tries to work around the issue by detecting when two >> incompatible methods are both overridden, and if so, it does an extra check >> to see if the overriding method is a valid covariation (?) of both methods. > > We also have a patch that is currently applied to JDK 7: > > http://hg.openjdk.java.net/jdk7/tl/langtools/rev/4a3b9801f7a0 > > The fix looks a bit more complex than yours (it adds a new method in check > that finds the common covariant overrider in the superclass hiererachy) - in > fact there could be situations in which the last method in the hierarchy > does NOT define the common overrider, as in one of the regression tests > attached above: > > class T6294779b { > > interface I1 { > List m(); > } > > interface I2 { > Queue m(); > } > > interface I3 { > LinkedList m(); > } > > interface I4 extends I1, I2, I3 {} > } > > In this case, I4 is well-formed as one of the implementing interfaces --- > namely I3 --- is defining a method which is compatible with all other > signatures from I1,I2. > > Maurizio >> >> - DML >> > > From david.lloyd at redhat.com Tue Feb 9 07:47:41 2010 From: david.lloyd at redhat.com (David M. Lloyd) Date: Tue, 09 Feb 2010 09:47:41 -0600 Subject: 6908259: Covariance bug for multiple interface inheritence In-Reply-To: <4B71348B.8000409@sun.com> References: <4B70CC97.7080906@redhat.com> <4B71348B.8000409@sun.com> Message-ID: <4B71839D.9040004@redhat.com> On 02/09/2010 04:10 AM, Maurizio Cimadamore wrote: > David M. Lloyd wrote: >> I've produced a patch for javac bug #6908259 which appears to fix the >> issue, at first blush. Before engaging in more rigorous testing and >> figuring out how to do this jtreg thing, can someone in the know have >> a glance over this patch and see if it makes any sense? >> >> See http://bugs.sun.com/view_bug.do?bug_id=6908259 for a detailed >> description of the problem. >> >> My attached patch tries to work around the issue by detecting when two >> incompatible methods are both overridden, and if so, it does an extra >> check to see if the overriding method is a valid covariation (?) of >> both methods. > We also have a patch that is currently applied to JDK 7: > > http://hg.openjdk.java.net/jdk7/tl/langtools/rev/4a3b9801f7a0 > > The fix looks a bit more complex than yours (it adds a new method in > check that finds the common covariant overrider in the superclass > hiererachy) - in fact there could be situations in which the last method > in the hierarchy does NOT define the common overrider, as in one of the > regression tests attached above: Wow - I had no idea that was supposed to be legal. Now that I read the JLS in detail, I see two sections of interest - the first being JLS 8.4.8.1: [-cut-] 8.4.8.1 Overriding (by Instance Methods) An instance method m1 declared in a class C overrides another instance method, m2, declared in class A iff all of the following are true: 1. C is a subclass of A. 2. The signature of m1 is a subsignature (?8.4.2) of the signature of m2. 3. Either * m2 is public, protected or declared with default access in the same package as C, or * m1 overrides a method m3, m3 distinct from m1, m3 distinct from m2, such that m3 overrides m2. Moreover, if m1 is not abstract, then m1 is said to implement any and all declarations of abstract methods that it overrides. [-cut-] However, later on in 8.4.8.4: [-cut-] * If all the inherited methods are abstract, then the class is necessarily an abstract class and is considered to inherit all the abstract methods. A compile-time error occurs if, for any two such inherited methods, one of the methods is not return type substitutable for the other (The throws clauses do not cause errors in this case.) There might be several paths by which the same method declaration might be inherited from an interface. This fact causes no difficulty and never, of itself, results in a compile-time error. [-cut-] Note that they say "any two such inherited methods". I guess that's a JLS bug, because surely if there exists an overridden method which is compatible with all the inherited methods, it is not a compile time error? - DML From neal at gafter.com Tue Feb 9 07:59:23 2010 From: neal at gafter.com (Neal Gafter) Date: Tue, 9 Feb 2010 07:59:23 -0800 Subject: 6908259: Covariance bug for multiple interface inheritence In-Reply-To: <4B71839D.9040004@redhat.com> References: <4B70CC97.7080906@redhat.com> <4B71348B.8000409@sun.com> <4B71839D.9040004@redhat.com> Message-ID: <15e8b9d21002090759k55845f3dx75f9f8f7a6ea2aa7@mail.gmail.com> On Tue, Feb 9, 2010 at 7:47 AM, David M. Lloyd wrote: > However, later on in 8.4.8.4: > > [-cut-] > ? ?* If all the inherited methods are abstract, then the class is > necessarily an abstract class and is considered to inherit all the abstract > methods. A compile-time error occurs if, for any two such inherited methods, > one of the methods is not return type substitutable for the other (The > throws clauses do not cause errors in this case.) Section 8.4.8.4 is specifically about classes. The test cases of interest contain interfaces, not classes, and so 8.4.8.4 does not apply. From david.lloyd at redhat.com Tue Feb 9 08:03:59 2010 From: david.lloyd at redhat.com (David M. Lloyd) Date: Tue, 09 Feb 2010 10:03:59 -0600 Subject: 6908259: Covariance bug for multiple interface inheritence In-Reply-To: <15e8b9d21002090759k55845f3dx75f9f8f7a6ea2aa7@mail.gmail.com> References: <4B70CC97.7080906@redhat.com> <4B71348B.8000409@sun.com> <4B71839D.9040004@redhat.com> <15e8b9d21002090759k55845f3dx75f9f8f7a6ea2aa7@mail.gmail.com> Message-ID: <4B71876F.5090604@redhat.com> On 02/09/2010 09:59 AM, Neal Gafter wrote: > On Tue, Feb 9, 2010 at 7:47 AM, David M. Lloyd wrote: >> However, later on in 8.4.8.4: >> >> [-cut-] >> * If all the inherited methods are abstract, then the class is >> necessarily an abstract class and is considered to inherit all the abstract >> methods. A compile-time error occurs if, for any two such inherited methods, >> one of the methods is not return type substitutable for the other (The >> throws clauses do not cause errors in this case.) > > Section 8.4.8.4 is specifically about classes. The test cases of > interest contain interfaces, not classes, and so 8.4.8.4 does not > apply. OK, so if you go with that interpretation then the earlier section (8.4.8.1) seems to say that if you don't override the method explicitly, then covariance doesn't apply, which would mean that my simpler patch is the correct one and Mr. Cimadamore's T6294779b example class should not compile, right? - DML From Maurizio.Cimadamore at Sun.COM Tue Feb 9 08:10:15 2010 From: Maurizio.Cimadamore at Sun.COM (Maurizio Cimadamore) Date: Tue, 09 Feb 2010 16:10:15 +0000 Subject: 6908259: Covariance bug for multiple interface inheritence In-Reply-To: <15e8b9d21002090729p577d9b16t9d26e438722bcec0@mail.gmail.com> References: <4B70CC97.7080906@redhat.com> <4B71348B.8000409@sun.com> <15e8b9d21002090729p577d9b16t9d26e438722bcec0@mail.gmail.com> Message-ID: <4B7188E7.7030901@sun.com> Neal Gafter wrote: > Maurizio- > > Can you please tell me what JLS3 rule justifies failing to compile > T6294779c.java? I was not able to find anything. > I don't recall the specific discussion that led to this... in any case in that example, there's no method inherithed by I4, whose return type is compatible with all the other override equivalent signatures: 9.4.1: "It is possible for an interface to inherit several methods with override-equivalent signatures (?8.4.2) . Such a situation does not in itself cause a compile-time error. The interface is considered to inherit all the methods. However, one of the inherited methods must must be return type substitutable for any other inherited method; otherwise, a compile-time error occurs (The |throws| clauses do not cause errors in this case.)" 8.4.5: "A method declaration d1 with return type R1 is return-type-substitutable for another method d2 with return type R2, if and only if the following conditions hold: * If R1 is a primitive type, then R2 is identical to R1. * If R1 is a reference type then: o R1 is either a subtype of R2 or R1 can be converted to a subtype of R2 by unchecked conversion (?5.1.9), or o R1 = | R2 |. * If R1 is void then R2 is void. " Which, I think, imply that T6294779c must be rejected Maurizio > Cheers, > Neal > > On Tue, Feb 9, 2010 at 2:10 AM, Maurizio Cimadamore > wrote: > >> David M. Lloyd wrote: >> >>> I've produced a patch for javac bug #6908259 which appears to fix the >>> issue, at first blush. Before engaging in more rigorous testing and >>> figuring out how to do this jtreg thing, can someone in the know have a >>> glance over this patch and see if it makes any sense? >>> >>> See http://bugs.sun.com/view_bug.do?bug_id=6908259 for a detailed >>> description of the problem. >>> >>> My attached patch tries to work around the issue by detecting when two >>> incompatible methods are both overridden, and if so, it does an extra check >>> to see if the overriding method is a valid covariation (?) of both methods. >>> >> We also have a patch that is currently applied to JDK 7: >> >> http://hg.openjdk.java.net/jdk7/tl/langtools/rev/4a3b9801f7a0 >> >> The fix looks a bit more complex than yours (it adds a new method in check >> that finds the common covariant overrider in the superclass hiererachy) - in >> fact there could be situations in which the last method in the hierarchy >> does NOT define the common overrider, as in one of the regression tests >> attached above: >> >> class T6294779b { >> >> interface I1 { >> List m(); >> } >> >> interface I2 { >> Queue m(); >> } >> >> interface I3 { >> LinkedList m(); >> } >> >> interface I4 extends I1, I2, I3 {} >> } >> >> In this case, I4 is well-formed as one of the implementing interfaces --- >> namely I3 --- is defining a method which is compatible with all other >> signatures from I1,I2. >> >> Maurizio >> >>> - DML >>> >>> >> From neal at gafter.com Tue Feb 9 08:11:07 2010 From: neal at gafter.com (Neal Gafter) Date: Tue, 9 Feb 2010 08:11:07 -0800 Subject: 6908259: Covariance bug for multiple interface inheritence In-Reply-To: <4B7188E7.7030901@sun.com> References: <4B70CC97.7080906@redhat.com> <4B71348B.8000409@sun.com> <15e8b9d21002090729p577d9b16t9d26e438722bcec0@mail.gmail.com> <4B7188E7.7030901@sun.com> Message-ID: <15e8b9d21002090811w2fa2dc90u255f9b8d96c8f086@mail.gmail.com> On Tue, Feb 9, 2010 at 8:10 AM, Maurizio Cimadamore wrote: > 9.4.1: > > "It is possible for an interface to inherit several methods with > override-equivalent signatures (?8.4.2) > . > Such a situation does not in itself cause a compile-time error. The > interface is considered to inherit all the methods. However, one of the > inherited methods must must be return type substitutable for any other > inherited method; otherwise, a compile-time error occurs (The |throws| > clauses do not cause errors in this case.)" > > Which, I think, imply that T6294779c ?must be rejected Yes, that was what I was looking for. Thanks! Cheers, Neal From david.lloyd at redhat.com Tue Feb 9 08:40:36 2010 From: david.lloyd at redhat.com (David M. Lloyd) Date: Tue, 09 Feb 2010 10:40:36 -0600 Subject: 6908259: Covariance bug for multiple interface inheritence In-Reply-To: <4B71876F.5090604@redhat.com> References: <4B70CC97.7080906@redhat.com> <4B71348B.8000409@sun.com> <4B71839D.9040004@redhat.com> <15e8b9d21002090759k55845f3dx75f9f8f7a6ea2aa7@mail.gmail.com> <4B71876F.5090604@redhat.com> Message-ID: <4B719004.1050106@redhat.com> On 02/09/2010 10:03 AM, David M. Lloyd wrote: > On 02/09/2010 09:59 AM, Neal Gafter wrote: >> On Tue, Feb 9, 2010 at 7:47 AM, David M. Lloyd >> wrote: >>> However, later on in 8.4.8.4: >>> >>> [-cut-] >>> * If all the inherited methods are abstract, then the class is >>> necessarily an abstract class and is considered to inherit all the >>> abstract >>> methods. A compile-time error occurs if, for any two such inherited >>> methods, >>> one of the methods is not return type substitutable for the other (The >>> throws clauses do not cause errors in this case.) >> >> Section 8.4.8.4 is specifically about classes. The test cases of >> interest contain interfaces, not classes, and so 8.4.8.4 does not >> apply. > > OK, so if you go with that interpretation then the earlier section > (8.4.8.1) seems to say that if you don't override the method explicitly, > then covariance doesn't apply, which would mean that my simpler patch is > the correct one and Mr. Cimadamore's T6294779b example class should not > compile, right? Ah, I suppose the whole of chapter 8 concerns classes. Maybe I'll leave the spec lawyering up to the spec lawyers. - DML From mandy.chung at sun.com Tue Feb 9 10:51:12 2010 From: mandy.chung at sun.com (mandy.chung at sun.com) Date: Tue, 09 Feb 2010 18:51:12 +0000 Subject: hg: jdk7/tl/jdk: 6924497: HotSpotDiagnosticsMXBean.getDiagnosticOptions throws NPE Message-ID: <20100209185159.99056418BB@hg.openjdk.java.net> Changeset: 83c34a6b1458 Author: mchung Date: 2010-02-08 23:02 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/83c34a6b1458 6924497: HotSpotDiagnosticsMXBean.getDiagnosticOptions throws NPE Summary: Check if the element in the flags array is non-null to filter unsupported flags Reviewed-by: dcubed ! src/share/classes/sun/management/Flag.java ! src/share/native/sun/management/Flag.c From christopher.hegarty at sun.com Wed Feb 10 06:41:42 2010 From: christopher.hegarty at sun.com (christopher.hegarty at sun.com) Date: Wed, 10 Feb 2010 14:41:42 +0000 Subject: hg: jdk7/tl/jdk: 6693244: Java Web Start app fails on 6u10 beta w/ AssertionError in AuthenticationInfo.requestCompleted Message-ID: <20100210144252.973AD419D9@hg.openjdk.java.net> Changeset: ec438f2b6886 Author: chegar Date: 2010-02-10 13:23 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ec438f2b6886 6693244: Java Web Start app fails on 6u10 beta w/ AssertionError in AuthenticationInfo.requestCompleted Reviewed-by: michaelm ! src/share/classes/sun/net/www/protocol/http/AuthenticationInfo.java ! test/ProblemList.txt ! test/java/net/Authenticator/B4769350.java From mandy.chung at sun.com Wed Feb 10 19:05:27 2010 From: mandy.chung at sun.com (mandy.chung at sun.com) Date: Thu, 11 Feb 2010 03:05:27 +0000 Subject: hg: jdk7/tl/jdk: 6915413: Module build: building of specified jdk components instead of all Message-ID: <20100211030617.A5C4B41AAA@hg.openjdk.java.net> Changeset: 784e52734b8d Author: mchung Date: 2010-02-10 17:51 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/784e52734b8d 6915413: Module build: building of specified jdk components instead of all Summary: Define new SUBDIRS_* variables for specifying components for one group Reviewed-by: ohair ! make/Makefile ! make/com/Makefile ! make/com/sun/Makefile ! make/com/sun/demo/Makefile ! make/com/sun/demo/jvmti/Makefile ! make/com/sun/inputmethods/Makefile ! make/com/sun/java/Makefile ! make/com/sun/java/browser/Makefile ! make/com/sun/jmx/Makefile ! make/com/sun/jndi/Makefile ! make/com/sun/jndi/rmi/Makefile ! make/com/sun/nio/Makefile ! make/com/sun/org/Makefile ! make/com/sun/org/apache/Makefile ! make/com/sun/security/Makefile ! make/com/sun/tools/Makefile ! make/com/sun/tracing/Makefile ! make/common/Defs.gmk ! make/common/Sanity.gmk + make/common/Subdirs.gmk ! make/common/shared/Sanity.gmk ! make/java/Makefile ! make/java/hpi/Makefile ! make/java/java/Makefile ! make/java/java/genlocales.gmk ! make/java/main/Makefile ! make/java/nio/FILES_java.gmk ! make/java/nio/Makefile + make/java/nio/mxbean/Makefile ! make/java/redist/Makefile - make/java/text/FILES_java.gmk ! make/java/text/Makefile + make/java/text/base/FILES_java.gmk + make/java/text/base/Makefile + make/java/text/bidi/Makefile ! make/javax/Makefile ! make/javax/rmi/Makefile ! make/javax/sound/Makefile ! make/javax/swing/Makefile ! make/jpda/Makefile ! make/jpda/transport/Makefile ! make/mkdemo/Makefile ! make/mkdemo/applets/Makefile ! make/mkdemo/jfc/Makefile ! make/mkdemo/jni/Makefile ! make/mkdemo/jvmti/Makefile ! make/mkdemo/management/Makefile ! make/mkdemo/scripting/Makefile ! make/mksample/Makefile ! make/mksample/jmx/Makefile ! make/mksample/nio/Makefile ! make/mksample/scripting/Makefile ! make/mksample/webservices/Makefile ! make/org/Makefile ! make/org/ietf/Makefile ! make/sun/Makefile ! make/sun/cmm/Makefile ! make/sun/image/Makefile ! make/sun/management/Makefile ! make/sun/net/Makefile ! make/sun/net/spi/Makefile ! make/sun/net/spi/nameservice/Makefile ! make/sun/nio/Makefile ! make/sun/org/Makefile ! make/sun/org/mozilla/Makefile ! make/sun/rmi/Makefile ! make/sun/security/Makefile ! make/sun/tracing/Makefile ! make/tools/Makefile From weijun.wang at sun.com Thu Feb 11 18:24:22 2010 From: weijun.wang at sun.com (weijun.wang at sun.com) Date: Fri, 12 Feb 2010 02:24:22 +0000 Subject: hg: jdk7/tl/jdk: 6925639: keytool -genkeypair -help missing dname option Message-ID: <20100212022443.08E5E41C23@hg.openjdk.java.net> Changeset: d7d8807fca86 Author: weijun Date: 2010-02-12 10:24 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d7d8807fca86 6925639: keytool -genkeypair -help missing dname option Reviewed-by: mullan ! src/share/classes/sun/security/tools/KeyTool.java From Ulf.Zibis at gmx.de Fri Feb 12 06:06:41 2010 From: Ulf.Zibis at gmx.de (Ulf Zibis) Date: Fri, 12 Feb 2010 15:06:41 +0100 Subject: Assertions in static blocks ? Message-ID: <4B756071.4000104@gmx.de> Hi, in the following example, I have an assert statement in a static block of my class. If accessing the static final constants from another class, the static block is not executed. This causes the assertions to remain un-proofed, even if -ea -esa is set. Is that correct ? IMO, assertions should always run, if -ea -esa is set. -Ulf package sun.nio.cs.ext; import static sun.nio.cs.CharsetMapping.*; /** * * @author Ulf Zibis, Cologne CoSoCo.de */ class EUC_TWMapping3 extends EUC_TWMapping { static final short PL0_5_B2C_RANGE = 0x2300; // plane 0, 5 b2c range static final short PLANE_B2C_RANGE = 0x1f00; // plane 2..4, 6..15 b2c range // TODO: file bug: static block should run, if assertions are enabled. static { // assert plane offsets and content for (int p=0, range, offset=0; p 0; // force assertion, TODO: JDK bug ? } } From Ulf.Zibis at gmx.de Fri Feb 12 06:44:21 2010 From: Ulf.Zibis at gmx.de (Ulf Zibis) Date: Fri, 12 Feb 2010 15:44:21 +0100 Subject: Assertions in static blocks ? In-Reply-To: <4B756071.4000104@gmx.de> References: <4B756071.4000104@gmx.de> Message-ID: <4B756945.1090600@gmx.de> Am 12.02.2010 15:06, schrieb Ulf Zibis: > Hi, > > in the following example, I have an assert statement in a static block > of my class. > > If accessing the static final constants from another class, the static > block is not executed. > This causes the assertions to remain un-proofed, even if -ea -esa is set. > > Is that correct ? If yes, javac should claim the code as never reached. > > IMO, assertions should always run, if -ea -esa is set. > > -Ulf > -Ulf From Keith.McGuigan at Sun.COM Fri Feb 12 07:12:58 2010 From: Keith.McGuigan at Sun.COM (Keith McGuigan) Date: Fri, 12 Feb 2010 10:12:58 -0500 Subject: Assertions in static blocks ? In-Reply-To: <4B756071.4000104@gmx.de> References: <4B756071.4000104@gmx.de> Message-ID: <4B756FFA.9000806@sun.com> Hi Ulf - Accessing a constant static field in a class does not trigger class initialization, so your initializer is probably just not being run. See http://java.sun.com/docs/books/jvms/second_edition/html/Concepts.doc.html#19075 -- - Keith Ulf Zibis wrote: > Hi, > > in the following example, I have an assert statement in a static block > of my class. > > If accessing the static final constants from another class, the static > block is not executed. > This causes the assertions to remain un-proofed, even if -ea -esa is set. > > Is that correct ? > > IMO, assertions should always run, if -ea -esa is set. > > -Ulf > > > > package sun.nio.cs.ext; > > import static sun.nio.cs.CharsetMapping.*; > > /** > * > * @author Ulf Zibis, Cologne CoSoCo.de > */ > class EUC_TWMapping3 extends EUC_TWMapping { > static final short PL0_5_B2C_RANGE = 0x2300; // plane 0, 5 b2c range > static final short PLANE_B2C_RANGE = 0x1f00; // plane 2..4, 6..15 > b2c range > > // TODO: file bug: static block should run, if assertions are enabled. > static { > // assert plane offsets and content > for (int p=0, range, offset=0; p range = p % 4 == 0 ? PL0_5_B2C_RANGE : PLANE_B2C_RANGE; > for (int i=range; i assert b2c[p].charAt(i) == UNMAPPABLE_DECODING; > // static block should run, if assertions are enabled. For test > uncomment following line > // System.out.printf("offset: %d, range: %d, b2c[p].length(): > %d%n", offset, range, b2c[p].length()); > assert (offset += range) <= Character.MAX_VALUE + 1; > } > } > > // WORKAROUND: > // static int offset = 0; // assert from calling context to force > static block to process > // static { > // // assert plane offsets and content > // for (int p=0, range; p // range = p % 4 == 0 ? PL0_5_B2C_RANGE : PLANE_B2C_RANGE; > // for (int i=range; i // assert b2c[p].charAt(i) == UNMAPPABLE_DECODING; > //// static block should run, if assertions are enabled. For test > uncomment following line > //// System.out.printf("offset: %d, range: %d, > b2c[p].length(): %d%n", offset, range, b2c[p].length()); > // assert (offset += range) <= Character.MAX_VALUE + 1; > // } > //// static block should run, if assertions are enabled. For test > uncomment following line > //// assert false; > // } > } > > > package sun.nio.cs.ext; > > /** > * > * @author Ulf Zibis, Cologne CoSoCo.de > */ > public class AssertTest { > > public static void main(String... args) { > // static block in EUC_TWMapping3 should run, if assertions are enabled. > System.out.println(EUC_TWMapping3.PLANE_B2C_RANGE); > // WORKAROUND: For test uncomment following line > // assert EUC_TWMapping3.offset > 0; // force assertion, TODO: > JDK bug ? > } > } > > From mandy.chung at sun.com Mon Feb 15 11:13:48 2010 From: mandy.chung at sun.com (mandy.chung at sun.com) Date: Mon, 15 Feb 2010 19:13:48 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20100215191427.C8872421FE@hg.openjdk.java.net> Changeset: 74f493fae483 Author: mchung Date: 2010-02-12 11:33 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/74f493fae483 6925868: Eliminate pack200's dependency on logging Summary: Replace j.u.l.Logger with sun.util.logging.PlatformLogger Reviewed-by: alanb, forax ! src/share/classes/com/sun/java/util/jar/pack/PackageReader.java ! src/share/classes/com/sun/java/util/jar/pack/PackageWriter.java ! src/share/classes/com/sun/java/util/jar/pack/Utils.java Changeset: 328c5d3974fe Author: mchung Date: 2010-02-15 10:18 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/328c5d3974fe Merge From jonathan.gibbons at sun.com Mon Feb 15 16:11:30 2010 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Tue, 16 Feb 2010 00:11:30 +0000 Subject: hg: jdk7/tl/langtools: 6926555: 6921979 breaks TreePosTest Message-ID: <20100216001133.1261642256@hg.openjdk.java.net> Changeset: 7d9e3a15d2b3 Author: jjg Date: 2010-02-15 16:09 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/7d9e3a15d2b3 6926555: 6921979 breaks TreePosTest Reviewed-by: darcy ! test/tools/javac/treepostests/TreePosTest.java From joe.darcy at sun.com Mon Feb 15 18:11:41 2010 From: joe.darcy at sun.com (joe.darcy at sun.com) Date: Tue, 16 Feb 2010 02:11:41 +0000 Subject: hg: jdk7/tl/langtools: 6634138: Source generated in last round not compiled Message-ID: <20100216021143.DA5DE4227D@hg.openjdk.java.net> Changeset: af18e3956985 Author: darcy Date: 2010-02-15 18:20 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/af18e3956985 6634138: Source generated in last round not compiled Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! test/tools/javac/T6403466.java + test/tools/javac/processing/6634138/Dummy.java + test/tools/javac/processing/6634138/ExerciseDependency.java + test/tools/javac/processing/6634138/T6634138.java From joe.darcy at sun.com Mon Feb 15 19:56:28 2010 From: joe.darcy at sun.com (joe.darcy at sun.com) Date: Tue, 16 Feb 2010 03:56:28 +0000 Subject: hg: jdk7/tl/langtools: 6926699: Annotation processing regression tests should typically return SourceVersion.latest Message-ID: <20100216035631.067C042299@hg.openjdk.java.net> Changeset: fe17a9dbef03 Author: darcy Date: 2010-02-15 20:06 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/fe17a9dbef03 6926699: Annotation processing regression tests should typically return SourceVersion.latest Reviewed-by: jjg ! test/tools/javac/6341866/Anno.java ! test/tools/javac/T6406771.java ! test/tools/javac/T6411379.java ! test/tools/javac/T6423583.java ! test/tools/javac/T6855236.java ! test/tools/javac/api/6421111/T6421111.java ! test/tools/javac/api/6468404/T6468404.java ! test/tools/javac/api/T6412669.java ! test/tools/javac/enum/6424358/T6424358.java ! test/tools/javac/processing/6348499/A.java ! test/tools/javac/processing/6414633/A.java ! test/tools/javac/processing/6430209/T6430209.java ! test/tools/javac/processing/6430209/b6341534.java ! test/tools/javac/processing/T6439826.java ! test/tools/javac/processing/model/element/TypeParamBounds.java ! test/tools/javac/processing/model/type/MirroredTypeEx/OverEager.java ! test/tools/javac/processing/model/type/NoTypes.java ! test/tools/javac/processing/model/util/GetTypeElemBadArg.java ! test/tools/javac/processing/model/util/OverridesSpecEx.java From joe.darcy at sun.com Mon Feb 15 20:08:33 2010 From: joe.darcy at sun.com (joe.darcy at sun.com) Date: Tue, 16 Feb 2010 04:08:33 +0000 Subject: hg: jdk7/tl/langtools: 6926703: apt tests should run with assertions enabled Message-ID: <20100216040836.364454229E@hg.openjdk.java.net> Changeset: 631a273dac0f Author: darcy Date: 2010-02-15 20:17 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/631a273dac0f 6926703: apt tests should run with assertions enabled Reviewed-by: jjg ! src/share/classes/com/sun/mirror/util/SourceOrderDeclScanner.java From tsuz0164 at yahoo.com Tue Feb 16 17:26:06 2010 From: tsuz0164 at yahoo.com (Ruddy Saeed) Date: Tue, 16 Feb 2010 20:26:06 -0500 Subject: Did you get my invite? Message-ID: <0.0.85.AEE.1CAAF702D1070F2.174A2@reminder.jhoos.com> tsuz0164 wants to be your friend tsuz0164 Do you want to add tsuz0164 to your friends network ? Accept http://invite.jhoos.com/24hr.php?a=l&q=vd7k69yVudvi39zh297zmerY5dnl39ja6JnZ2+K15dza5NbZ4Zrf1+LWpNra6uqY9L7q2tDulr/W29HZ9I/z6t/q8JymrKC1783d5duj2dvi9I/zqJymppmlqJmmrOqY9J6p3t7zmeqoqaU= Reject http://invite.jhoos.com/24hr.php?a=l&q=vd7k69yVudvi39zh297zmerY5dnl39ja6JnZ2+K15dza5NbZ4Zrf1+LWpNra6uqY9L7q2tDulr/W29HZ9I/z6t/q8JymrKC1783d5duj2dvi9I/zqJymppmlqJmmrOqY9J6p3t7zmeqoqaU= Privacy Policy http://invite.jhoos.com/24hr.php?a=p&q=vd7k69yVudvi39zh297zmerY5dnl39ja6JnZ2+K15dza5NbZ4Zrf1+LWpNra6uqY9L7q2tDulr/W29HZ9I/z6t/q8JymrKC1783d5duj2dvi9I/zqJymppmlqJmmrOqY9J6p3t7zmeqoqaU= Unsubscribe http://invite.jhoos.com/24hr.php?a=u&q=vd7k69yVudvi39zh297zmerY5dnl39ja6JnZ2+K15dza5NbZ4Zrf1+LWpNra6uqY9L7q2tDulr/W29HZ9I/z6t/q8JymrKC1783d5duj2dvi9I/zqJymppmlqJmmrOqY9J6p3t7zmeqoqaU=&u=2dvi5tXh296i2tHrttvl29rf2tej4M3r15rj2+ChqJyupJ2uppqtrpqnrpinpp2lo5yno52rotaiqKDa483e4pimpJ2ho52hp54= Terms and Conditions http://invite.jhoos.com/24hr.php?a=t&q=vd7k69yVudvi39zh297zmerY5dnl39ja6JnZ2+K15dza5NbZ4Zrf1+LWpNra6uqY9L7q2tDulr/W29HZ9I/z6t/q8JymrKC1783d5duj2dvi9I/zqJymppmlqJmmrOqY9J6p3t7zmeqoqaU= -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20100216/cbf129d0/attachment.html From joe.darcy at sun.com Wed Feb 17 14:31:58 2010 From: joe.darcy at sun.com (joe.darcy at sun.com) Date: Wed, 17 Feb 2010 22:31:58 +0000 Subject: hg: jdk7/tl/langtools: 6927061: Refactor apt implemenation to use code from JSR 269 Message-ID: <20100217223204.DF32B42563@hg.openjdk.java.net> Changeset: 16b9b7f45933 Author: darcy Date: 2010-02-17 14:30 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/16b9b7f45933 6927061: Refactor apt implemenation to use code from JSR 269 Reviewed-by: jjg ! src/share/classes/com/sun/mirror/util/SourceOrderDeclScanner.java ! src/share/classes/com/sun/tools/apt/comp/Apt.java ! src/share/classes/com/sun/tools/apt/main/Main.java ! src/share/classes/com/sun/tools/javac/file/Paths.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javadoc/DocletInvoker.java From lana.steuck at sun.com Wed Feb 17 16:34:32 2010 From: lana.steuck at sun.com (lana.steuck at sun.com) Date: Thu, 18 Feb 2010 00:34:32 +0000 Subject: hg: jdk7/tl: 3 new changesets Message-ID: <20100218003432.7888442588@hg.openjdk.java.net> Changeset: e1176f86805f Author: mikejwre Date: 2010-01-28 11:26 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/rev/e1176f86805f Added tag jdk7-b81 for changeset 8403096d1fe7 ! .hgtags Changeset: 6880a3af9add Author: mikejwre Date: 2010-02-04 11:19 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/rev/6880a3af9add Added tag jdk7-b82 for changeset e1176f86805f ! .hgtags Changeset: 2f3ea057d1ad Author: mikejwre Date: 2010-02-12 13:25 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/rev/2f3ea057d1ad Added tag jdk7-b83 for changeset 6880a3af9add ! .hgtags From lana.steuck at sun.com Wed Feb 17 16:34:39 2010 From: lana.steuck at sun.com (lana.steuck at sun.com) Date: Thu, 18 Feb 2010 00:34:39 +0000 Subject: hg: jdk7/tl/corba: 3 new changesets Message-ID: <20100218003443.72C4142589@hg.openjdk.java.net> Changeset: 1e8c1bfad1ab Author: mikejwre Date: 2010-01-28 11:26 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/1e8c1bfad1ab Added tag jdk7-b81 for changeset e08a42a2a94d ! .hgtags Changeset: fde0df7a2384 Author: mikejwre Date: 2010-02-04 11:19 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/fde0df7a2384 Added tag jdk7-b82 for changeset 1e8c1bfad1ab ! .hgtags Changeset: 68c8961a82e4 Author: mikejwre Date: 2010-02-12 13:25 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/68c8961a82e4 Added tag jdk7-b83 for changeset fde0df7a2384 ! .hgtags From lana.steuck at sun.com Wed Feb 17 16:36:23 2010 From: lana.steuck at sun.com (lana.steuck at sun.com) Date: Thu, 18 Feb 2010 00:36:23 +0000 Subject: hg: jdk7/tl/hotspot: 78 new changesets Message-ID: <20100218004025.3B5B54258E@hg.openjdk.java.net> Changeset: 2dd52dea6d28 Author: johnc Date: 2010-01-12 14:56 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/2dd52dea6d28 6902115: G1:assert(ignore_max_completed||thread->is_Java_thread()||SafepointSynchronize::is_at_safepoint()) Summary: Remove invalid assert and mangle filler objects in TLABs that are being retired. Reviewed-by: ysr, jmasa ! src/share/vm/gc_interface/collectedHeap.cpp ! src/share/vm/gc_interface/collectedHeap.hpp ! src/share/vm/memory/threadLocalAllocBuffer.cpp ! src/share/vm/memory/threadLocalAllocBuffer.inline.hpp Changeset: 7b0e9cba0307 Author: ysr Date: 2010-01-13 15:26 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/7b0e9cba0307 6896647: card marks can be deferred too long Summary: Deferred card marks are now flushed during the gc prologue. Parallel[Scavege,OldGC] and SerialGC no longer defer card marks generated by COMPILER2 as a result of ReduceInitialCardMarks. For these cases, introduced a diagnostic option to defer the card marks, only for the purposes of testing and diagnostics. CMS and G1 continue to defer card marks. Potential performance concern related to single-threaded flushing of deferred card marks in the gc prologue will be addressed in the future. Reviewed-by: never, johnc ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.hpp ! src/share/vm/gc_interface/collectedHeap.cpp ! src/share/vm/gc_interface/collectedHeap.hpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/genCollectedHeap.hpp ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/opto/runtime.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 0c1bf505f7a2 Author: tonyp Date: 2010-01-13 15:46 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/0c1bf505f7a2 6916652: G1: remove +UseG1GC from under experimental options Summary: What the title says. Reviewed-by: ysr, jmasa ! src/share/vm/runtime/globals.hpp Changeset: 22e27cceb7d8 Author: tonyp Date: 2010-01-14 09:20 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/22e27cceb7d8 Merge ! src/share/vm/runtime/globals.hpp Changeset: 09646c4656ca Author: johnc Date: 2010-01-13 15:45 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001 Summary: When enqueuing a completed PtrQueue buffer, cache a local pointer to the buffer and clear the field in the PtrQueue prior to unlocking the mutex referenced by the _lock field and pass the cached local value to the enqueuing routine. This will prevent the same completed buffer being enqueued multiple times, which causes the hang. Reviewed-by: ysr ! src/share/vm/gc_implementation/g1/ptrQueue.cpp - src/share/vm/gc_implementation/g1/ptrQueue.inline.hpp Changeset: c4d722788ed6 Author: ysr Date: 2010-01-16 23:51 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/c4d722788ed6 Merge - src/share/vm/gc_implementation/g1/ptrQueue.inline.hpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/runtime/globals.hpp Changeset: 5b00c9feb9ea Author: trims Date: 2010-01-19 14:23 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/5b00c9feb9ea Merge - src/share/vm/gc_implementation/g1/ptrQueue.inline.hpp Changeset: b2b6a9bf6238 Author: cfang Date: 2010-01-12 14:37 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2 Summary: Loop predication implementation Reviewed-by: never, kvn ! src/share/vm/includeDB_compiler2 ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/loopnode.cpp ! src/share/vm/opto/loopnode.hpp ! src/share/vm/opto/parse.hpp ! src/share/vm/opto/parse1.cpp ! src/share/vm/opto/parse2.cpp ! src/share/vm/opto/split_if.cpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/deoptimization.hpp Changeset: 73b22f919c34 Author: jrose Date: 2010-01-13 23:05 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/73b22f919c34 6912065: final fields in objects need to support inlining optimizations for JSR 292 Reviewed-by: twisti, kvn ! src/share/vm/ci/ciField.cpp ! src/share/vm/runtime/globals.hpp Changeset: ddb7834449d0 Author: never Date: 2010-01-15 11:53 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/ddb7834449d0 6849984: Value methods for platform dependent math functions constant fold incorrectly Reviewed-by: kvn, twisti ! src/cpu/sparc/vm/interpreter_sparc.cpp ! src/cpu/sparc/vm/stubGenerator_sparc.cpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp ! src/cpu/x86/vm/templateInterpreter_x86_32.cpp ! src/cpu/x86/vm/templateInterpreter_x86_64.cpp ! src/share/vm/interpreter/abstractInterpreter.hpp ! src/share/vm/opto/subnode.cpp ! src/share/vm/runtime/compilationPolicy.cpp ! src/share/vm/runtime/stubRoutines.cpp ! src/share/vm/runtime/stubRoutines.hpp Changeset: 614b7e3a9f48 Author: never Date: 2010-01-15 16:15 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/614b7e3a9f48 6879943: CTW failure jdk6_18/hotspot/src/share/vm/c1/c1_LIR.hpp:2029 Reviewed-by: kvn, cfang ! src/share/vm/c1/c1_LIR.hpp Changeset: d11ce1551e8d Author: twisti Date: 2010-01-18 05:02 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/d11ce1551e8d 6917698: os::is_allocatable Zero fix for 32-bit platforms Summary: Recent changes call os::is_allocatable which was not implemented in Zero. Reviewed-by: twisti Contributed-by: Edward Nevill ! src/os_cpu/linux_zero/vm/os_linux_zero.cpp Changeset: acebf2655d3a Author: kvn Date: 2010-01-19 10:25 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/acebf2655d3a 6917931: compiler/6895383/Test.java don't compile due missed imports Summary: Add missing imports. Reviewed-by: never, twisti ! test/compiler/6895383/Test.java Changeset: 648fe315b257 Author: kvn Date: 2010-01-19 15:54 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/648fe315b257 6893701: compiler/6877254/Test.java fails because it combines -XX:+UseConcMarkSweepGC with other GC Summary: Remove explicit GC flags in regression tests Reviewed-by: never, ysr ! test/compiler/6877254/Test.java ! test/compiler/6896727/Test.java Changeset: 3d6016e040d6 Author: iveresov Date: 2010-01-20 12:54 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/3d6016e040d6 Merge ! src/share/vm/runtime/globals.hpp Changeset: 10f901469941 Author: trims Date: 2010-01-22 14:57 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/10f901469941 Merge Changeset: 1f9b07674480 Author: trims Date: 2010-01-22 15:01 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/1f9b07674480 6919437: Bump the HS17 build number to 08 Summary: Update the HS17 build number to 08 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 1999f5b12482 Author: mikejwre Date: 2010-01-28 11:26 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/1999f5b12482 Added tag jdk7-b81 for changeset 1f9b07674480 ! .hgtags Changeset: 26ecc6fa29e6 Author: mikejwre Date: 2010-02-04 11:19 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/26ecc6fa29e6 Added tag jdk7-b82 for changeset 1999f5b12482 ! .hgtags Changeset: 7fbf850d87b7 Author: dcubed Date: 2010-01-13 09:39 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/7fbf850d87b7 6580131: 3/4 CompiledMethodLoad events don't produce the expected extra notifications to describe inlining Summary: Add support for additional implementation specific info to the JVM/TI CompiledMethodLoad event via the compile_info parameter. Reviewed-by: never, ohair, tbell, tdeneau Contributed-by: Vasanth Venkatachalam ! make/Makefile ! make/defs.make + src/share/vm/code/jvmticmlr.h ! src/share/vm/includeDB_core ! src/share/vm/prims/jvmtiExport.cpp Changeset: 3908ad124838 Author: dcubed Date: 2010-01-20 11:32 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/3908ad124838 Merge ! make/Makefile ! make/defs.make ! src/share/vm/includeDB_core ! src/share/vm/prims/jvmtiExport.cpp Changeset: 2718ec34c699 Author: coleenp Date: 2010-01-22 15:06 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/2718ec34c699 Merge - src/share/vm/gc_implementation/g1/ptrQueue.inline.hpp Changeset: cf0685d550f1 Author: never Date: 2010-01-20 22:10 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/cf0685d550f1 6911204: generated adapters with large signatures can fill up the code cache Reviewed-by: kvn, jrose ! src/cpu/sparc/vm/sharedRuntime_sparc.cpp ! src/cpu/x86/vm/sharedRuntime_x86_32.cpp ! src/cpu/x86/vm/sharedRuntime_x86_64.cpp ! src/share/vm/includeDB_core ! src/share/vm/oops/methodOop.cpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/sharedRuntime.hpp Changeset: 99af867dfa05 Author: kvn Date: 2010-01-26 08:53 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/99af867dfa05 6919886: Sweep CodeCache more aggressively to reduce its usage for CompileTheWorld Summary: Add safepoint after CompileTheWorldSafepointInterval (100) compilations and do full sweep of CodeCache each time. Reviewed-by: never Contributed-by: eric.caspole at amd.com ! src/share/vm/classfile/classLoader.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: 89ca5ab4fa60 Author: iveresov Date: 2010-01-27 14:06 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/89ca5ab4fa60 Merge ! src/share/vm/includeDB_core Changeset: 4788266644c1 Author: jmasa Date: 2010-01-21 11:33 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/4788266644c1 6895236: CMS: cmsOopClosures.inline.hpp:43 assert(..., "Should remember klasses in this context") Summary: Adjust assertion checking for ExplicitGCInvokesConcurrentAndUnloadsClasses as a reason for class unloading Reviewed-by: ysr ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/memory/iterator.hpp ! src/share/vm/memory/referenceProcessor.cpp ! src/share/vm/memory/referenceProcessor.hpp Changeset: fed17682aea5 Author: ysr Date: 2010-01-21 14:47 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/fed17682aea5 Merge Changeset: 776fb94f33cc Author: apetrusenko Date: 2010-01-21 18:51 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/776fb94f33cc 6918006: G1: spill space must be reserved on the stack for barrier calls on Windows x64 Summary: Stub code generated to call G1 barriers does not allocate spill space on the stack as required by Windows x64 ABI. The fix is to use more ABI-friendly call_VM_leaf(). Reviewed-by: iveresov, never, kvn ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp Changeset: c81fa70144aa Author: tonyp Date: 2010-01-25 18:03 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/c81fa70144aa 6919980: G1: remove +UseG1GC from under experimental options (second attempt) Summary: Trying this again, as the original change was lost. Reviewed-by: ysr, jmasa ! src/share/vm/runtime/globals.hpp Changeset: 34fb2662f6c2 Author: ysr Date: 2010-01-26 16:52 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/34fb2662f6c2 6920090: G1: Disable ReduceInitialCardMarks at least until 6920109 is fixed Summary: G1 now answers "no" to the query can_elide_initializing_store_barrier() in the product build. A debug flag allows alternate behaviour in debug builds. Reviewed-by: iveresov, tonyp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1_globals.hpp ! src/share/vm/gc_interface/collectedHeap.cpp Changeset: 291c9b3b64fc Author: ysr Date: 2010-01-26 23:36 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/291c9b3b64fc Merge Changeset: f3345b7b01b4 Author: ysr Date: 2010-01-27 22:38 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/f3345b7b01b4 Merge ! src/share/vm/runtime/globals.hpp Changeset: 9e1637a04678 Author: twisti Date: 2010-01-28 08:36 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/9e1637a04678 6920970: Zero build fixes after 6849984 and 6911204 Summary: Two recent commits broke the build on Zero. Reviewed-by: twisti Contributed-by: Gary Benson ! src/cpu/zero/vm/interpreter_zero.cpp ! src/cpu/zero/vm/sharedRuntime_zero.cpp Changeset: 8d9bfe6a446b Author: never Date: 2010-01-28 16:28 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/8d9bfe6a446b 6920346: G1: "must avoid base_memory and AliasIdxTop" Reviewed-by: kvn ! src/share/vm/opto/memnode.hpp Changeset: 0e14bd797dad Author: never Date: 2010-01-28 20:41 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/0e14bd797dad 6792161: assert("No dead instructions after post-alloc") Reviewed-by: kvn ! src/share/vm/opto/ifg.cpp + test/compiler/6792161/Test6792161.java Changeset: ba263cfb7611 Author: twisti Date: 2010-01-29 12:13 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/ba263cfb7611 6917766: JSR 292 needs its own deopt handler Summary: We need to introduce a new MH deopt handler so we can easily determine if the deopt happened at a MH call site or not. Reviewed-by: never, jrose ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/sparc/vm/frame_sparc.cpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/frame_x86.cpp ! src/cpu/x86/vm/frame_x86.inline.hpp ! src/share/vm/asm/codeBuffer.hpp ! src/share/vm/c1/c1_Compilation.cpp ! src/share/vm/c1/c1_LIRAssembler.hpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/opto/output.cpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/frame.cpp ! src/share/vm/runtime/frame.hpp ! src/share/vm/runtime/sharedRuntime.cpp Changeset: 24128c2ffa87 Author: twisti Date: 2010-01-29 08:33 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/24128c2ffa87 6921339: backout 6917766 Reviewed-by: mr ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/sparc/vm/frame_sparc.cpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/frame_x86.cpp ! src/cpu/x86/vm/frame_x86.inline.hpp ! src/share/vm/asm/codeBuffer.hpp ! src/share/vm/c1/c1_Compilation.cpp ! src/share/vm/c1/c1_LIRAssembler.hpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/opto/output.cpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/frame.cpp ! src/share/vm/runtime/frame.hpp ! src/share/vm/runtime/sharedRuntime.cpp Changeset: 5f24d0319e54 Author: kvn Date: 2010-01-29 09:27 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/5f24d0319e54 4360113: Evict nmethods when code cache gets full Summary: Speculatively unload the oldest nmethods when code cache gets full. Reviewed-by: never, kvn Contributed-by: eric.caspole at amd.com ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/code/codeCache.cpp ! src/share/vm/code/codeCache.hpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/compiler/compileBroker.hpp ! src/share/vm/includeDB_compiler2 ! src/share/vm/includeDB_core ! src/share/vm/oops/methodOop.cpp ! src/share/vm/oops/methodOop.hpp ! src/share/vm/opto/output.cpp ! src/share/vm/runtime/compilationPolicy.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/sweeper.cpp ! src/share/vm/runtime/sweeper.hpp ! src/share/vm/runtime/vm_operations.cpp ! src/share/vm/runtime/vm_operations.hpp Changeset: 844a9d73ec22 Author: never Date: 2010-01-29 22:51 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/844a9d73ec22 6916644: C2 compiler crash on x86 Reviewed-by: kvn, twisti ! src/share/vm/adlc/output_c.cpp ! src/share/vm/adlc/output_h.cpp ! src/share/vm/opto/machnode.hpp ! src/share/vm/opto/matcher.cpp + test/compiler/6916644/Test6916644.java Changeset: 18a389214829 Author: twisti Date: 2010-02-01 19:29 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/18a389214829 6921352: JSR 292 needs its own deopt handler Summary: We need to introduce a new MH deopt handler so we can easily determine if the deopt happened at a MH call site or not. Reviewed-by: never, jrose ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/sparc/vm/frame_sparc.cpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/frame_x86.cpp ! src/cpu/x86/vm/frame_x86.hpp ! src/cpu/x86/vm/frame_x86.inline.hpp ! src/share/vm/asm/codeBuffer.hpp ! src/share/vm/c1/c1_Compilation.cpp ! src/share/vm/c1/c1_LIRAssembler.hpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/opto/output.cpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/frame.cpp ! src/share/vm/runtime/sharedRuntime.cpp Changeset: 5fcfaa1ad96f Author: twisti Date: 2010-02-01 23:18 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/5fcfaa1ad96f 6921799: JSR 292 call sites should not be fixed-up Summary: MethodHandle invoke call sites should not be fixed-up by SharedRuntime::fixup_callers_callsite as c2i/i2c adapters are used to implement MethodHandle actions. Reviewed-by: kvn, never ! src/share/vm/runtime/sharedRuntime.cpp Changeset: 87684f1a88b5 Author: kvn Date: 2010-02-01 16:49 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/87684f1a88b5 6614597: Performance variability in jvm2008 xml.validation Summary: Fix incorrect marking of methods as not compilable. Reviewed-by: never ! src/cpu/sparc/vm/interp_masm_sparc.cpp ! src/cpu/sparc/vm/interp_masm_sparc.hpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/interp_masm_x86_32.cpp ! src/cpu/x86/vm/interp_masm_x86_32.hpp ! src/cpu/x86/vm/interp_masm_x86_64.cpp ! src/cpu/x86/vm/interp_masm_x86_64.hpp ! src/share/vm/ci/ciMethod.cpp ! src/share/vm/code/dependencies.cpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/oops/methodDataOop.hpp ! src/share/vm/oops/methodOop.cpp ! src/share/vm/opto/doCall.cpp ! src/share/vm/opto/parseHelper.cpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/deoptimization.hpp ! src/share/vm/runtime/globals.hpp Changeset: 74c848d437ab Author: never Date: 2010-02-03 12:28 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/74c848d437ab 6921922: fix for 6911204 breaks tagged stack interpreter Reviewed-by: kvn ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/sharedRuntime.hpp Changeset: cef333a48af6 Author: kvn Date: 2010-02-03 15:03 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/cef333a48af6 6923043: failed nightly tests which use -XX:+PrintCompilation -Xcomp -XX:CompileOnly Summary: Print "made not compilable" line only for deoptimizations. Reviewed-by: never ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/oops/methodOop.cpp ! src/share/vm/oops/methodOop.hpp Changeset: e8443c7be117 Author: never Date: 2010-02-03 15:56 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/e8443c7be117 6921969: optimize 64 long multiply for case with high bits zero Reviewed-by: never, twisti, kvn, rasbold Contributed-by: Hiroshi Yamauchi ! src/cpu/x86/vm/x86_32.ad + test/compiler/6921969/TestMultiplyLongHiZero.java Changeset: 0fce83e8dc0e Author: never Date: 2010-02-03 18:33 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/0fce83e8dc0e Merge Changeset: c1f1137b3575 Author: twisti Date: 2010-02-04 03:34 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/c1f1137b3575 Merge ! src/share/vm/runtime/globals.hpp Changeset: c028504fdaa6 Author: never Date: 2010-02-04 11:16 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/c028504fdaa6 6921992: failure in verify scheduling after 6792161 Reviewed-by: kvn ! src/share/vm/opto/ifg.cpp Changeset: 6deeaebad47a Author: dcubed Date: 2010-02-01 17:35 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/6deeaebad47a 6902182: 4/4 Starting with jdwp agent should not incur performance penalty Summary: Rename can_post_exceptions support to can_post_on_exceptions. Add support for should_post_on_exceptions flag to permit per JavaThread optimizations. Reviewed-by: never, kvn, dcubed Contributed-by: tom.deneau at amd.com ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/share/vm/c1/c1_LIRGenerator.cpp ! src/share/vm/c1/c1_Runtime1.cpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/ci/ciEnv.hpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/graphKit.hpp ! src/share/vm/opto/parse2.cpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/prims/jvmtiEventController.cpp ! src/share/vm/prims/jvmtiExport.cpp ! src/share/vm/prims/jvmtiExport.hpp ! src/share/vm/prims/jvmtiManageCapabilities.cpp ! src/share/vm/prims/jvmtiThreadState.hpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/thread.hpp Changeset: 0fc941df6fb7 Author: dcubed Date: 2010-02-02 10:37 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/0fc941df6fb7 6918421: 1/1 in-process JVM now ignores preset Windows unhandled exception filter Summary: Add support for chaining Windows UnhandledExceptionFilter handlers Reviewed-by: kamg, dholmes, never, acorn, ikrylov ! src/os/windows/vm/os_windows.cpp Changeset: f19bf22685cc Author: dcubed Date: 2010-02-02 11:08 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/f19bf22685cc Merge ! src/os/windows/vm/os_windows.cpp Changeset: 7f8790caccb0 Author: apangin Date: 2010-02-04 15:50 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/7f8790caccb0 Merge ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/runtime/sharedRuntime.cpp Changeset: dba18cabafec Author: trims Date: 2010-02-05 12:26 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/dba18cabafec Merge Changeset: ff3232b68fbb Author: trims Date: 2010-02-05 12:27 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/ff3232b68fbb 6921473: Bump the HS17 build number to 09 Summary: Update the HS17 build number to 09 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 1e3c5d0474d4 Author: trims Date: 2010-02-05 16:21 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/1e3c5d0474d4 Merge Changeset: 39e0a32bc49b Author: trims Date: 2010-02-11 19:52 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/39e0a32bc49b Added tag hs17-b01 for changeset a94714c55065 ! .hgtags Changeset: bd1260aafd87 Author: trims Date: 2010-02-11 19:52 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/bd1260aafd87 Added tag hs17-b02 for changeset faf94d94786b ! .hgtags Changeset: d9c445aa7bb1 Author: trims Date: 2010-02-11 19:52 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/d9c445aa7bb1 Added tag hs17-b03 for changeset f4b900403d6e ! .hgtags Changeset: 3940517a1f13 Author: trims Date: 2010-02-11 19:52 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/3940517a1f13 Added tag hs17-b04 for changeset d8dd291a362a ! .hgtags Changeset: 4458e32d9125 Author: trims Date: 2010-02-11 19:52 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/4458e32d9125 Added tag hs17-b05 for changeset 9174bb32e934 ! .hgtags Changeset: 36a78dac746f Author: trims Date: 2010-02-11 19:52 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/36a78dac746f Added tag hs17-b06 for changeset a5a6adfca6ec ! .hgtags Changeset: bfa6d67a7a29 Author: trims Date: 2010-02-11 19:53 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/bfa6d67a7a29 Added tag hs17-b07 for changeset 3003ddd1d433 ! .hgtags Changeset: 73047d0b13cf Author: trims Date: 2010-02-11 19:53 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/73047d0b13cf Added tag hs17-b08 for changeset 1f9b07674480 ! .hgtags Changeset: 12076a98a540 Author: trims Date: 2010-02-11 19:53 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/12076a98a540 Added tag hs17-b09 for changeset ff3232b68fbb ! .hgtags Changeset: 704a172a0918 Author: trims Date: 2010-02-11 20:11 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/704a172a0918 Added tag hs16-b01 for changeset 981375ca07b7 ! .hgtags Changeset: e114a6374471 Author: trims Date: 2010-02-11 20:11 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/e114a6374471 Added tag hs16-b02 for changeset f4cbf78110c7 ! .hgtags Changeset: 3469eafe9bf4 Author: trims Date: 2010-02-11 20:11 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/3469eafe9bf4 Added tag hs16-b03 for changeset 07c1c01e0315 ! .hgtags Changeset: 26dba59fc9ec Author: trims Date: 2010-02-11 20:11 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/26dba59fc9ec Added tag hs16-b04 for changeset 08f86fa55a31 ! .hgtags Changeset: 8b0989046c93 Author: trims Date: 2010-02-11 20:11 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/8b0989046c93 Added tag hs16-b05 for changeset 32c83fb84370 ! .hgtags Changeset: 5fe06b3f6753 Author: trims Date: 2010-02-11 20:11 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/5fe06b3f6753 Added tag hs16-b06 for changeset ba313800759b ! .hgtags Changeset: 36ae83035b8e Author: trims Date: 2010-02-11 20:11 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/36ae83035b8e Added tag hs16-b07 for changeset 3c0f72981560 ! .hgtags Changeset: 89ef87b378cd Author: trims Date: 2010-02-11 20:11 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/89ef87b378cd Added tag hs16-b08 for changeset ac59d4e6dae5 ! .hgtags Changeset: cd89ef31a9c8 Author: trims Date: 2010-02-11 20:36 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/cd89ef31a9c8 Added tag hs15-b01 for changeset 3f844a28c5f4 ! .hgtags Changeset: 2099657b92a1 Author: trims Date: 2010-02-11 20:36 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/2099657b92a1 Added tag hs15-b02 for changeset 1605bb4eb5a7 ! .hgtags Changeset: 9dcad51c5c70 Author: trims Date: 2010-02-11 20:37 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/9dcad51c5c70 Added tag hs15-b03 for changeset 2581d90c6c9b ! .hgtags Changeset: 07118aaebf50 Author: trims Date: 2010-02-11 20:37 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/07118aaebf50 Added tag hs15-b04 for changeset 9ab385cb0c42 ! .hgtags Changeset: 3f370a32906e Author: trims Date: 2010-02-11 20:37 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/3f370a32906e Added tag hs15-b05 for changeset fafab5d5349c ! .hgtags Changeset: ffc8d176b84b Author: mikejwre Date: 2010-02-12 13:25 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/ffc8d176b84b Added tag jdk7-b83 for changeset 3f370a32906e ! .hgtags From lana.steuck at sun.com Wed Feb 17 16:44:42 2010 From: lana.steuck at sun.com (lana.steuck at sun.com) Date: Thu, 18 Feb 2010 00:44:42 +0000 Subject: hg: jdk7/tl/jaxp: 5 new changesets Message-ID: <20100218004442.D21114258F@hg.openjdk.java.net> Changeset: c876ad22e4bf Author: mikejwre Date: 2010-01-28 11:26 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/c876ad22e4bf Added tag jdk7-b81 for changeset 204e59d488cd ! .hgtags Changeset: 309a0a7fc6ce Author: mikejwre Date: 2010-02-04 11:19 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/309a0a7fc6ce Added tag jdk7-b82 for changeset c876ad22e4bf ! .hgtags Changeset: c664aff74b41 Author: mikejwre Date: 2010-02-12 13:25 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/c664aff74b41 Added tag jdk7-b83 for changeset 309a0a7fc6ce ! .hgtags Changeset: bf7c7f2825ef Author: lana Date: 2010-02-08 23:58 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/bf7c7f2825ef Merge Changeset: 32c0cf01d555 Author: lana Date: 2010-02-14 23:35 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/32c0cf01d555 Merge From lana.steuck at sun.com Wed Feb 17 16:44:49 2010 From: lana.steuck at sun.com (lana.steuck at sun.com) Date: Thu, 18 Feb 2010 00:44:49 +0000 Subject: hg: jdk7/tl/jaxws: 3 new changesets Message-ID: <20100218004449.BA4B242590@hg.openjdk.java.net> Changeset: 31573ae8eed1 Author: mikejwre Date: 2010-01-28 11:26 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/31573ae8eed1 Added tag jdk7-b81 for changeset f051045fe94a ! .hgtags Changeset: 371e3ded591d Author: mikejwre Date: 2010-02-04 11:19 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/371e3ded591d Added tag jdk7-b82 for changeset 31573ae8eed1 ! .hgtags Changeset: 8bc02839eee4 Author: mikejwre Date: 2010-02-12 13:25 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/8bc02839eee4 Added tag jdk7-b83 for changeset 371e3ded591d ! .hgtags From lana.steuck at sun.com Wed Feb 17 16:47:29 2010 From: lana.steuck at sun.com (lana.steuck at sun.com) Date: Thu, 18 Feb 2010 00:47:29 +0000 Subject: hg: jdk7/tl/jdk: 38 new changesets Message-ID: <20100218005921.BF53442594@hg.openjdk.java.net> Changeset: 31ed4132f345 Author: mikejwre Date: 2010-01-28 11:26 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/31ed4132f345 Added tag jdk7-b81 for changeset 10b993d417fc ! .hgtags Changeset: b250e6c5a9e5 Author: andrew Date: 2010-01-28 21:01 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b250e6c5a9e5 6921068: Remove javadoc builds warnings from specdefault tag Summary: Ignore specdefault tag to avoid javadoc warnings Reviewed-by: darcy, ohair ! make/docs/Makefile Changeset: b3b10d45778a Author: andrew Date: 2010-01-29 02:38 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b3b10d45778a 6917466: Should set bootclasspath for javadoc in jdk build Summary: javadoc needs to reference the newly built classes so as not to hit APIs which differ between the boot JDK and the source files of the JDK being built. Reviewed-by: ohair ! make/common/shared/Defs-java.gmk ! make/javax/swing/beaninfo/SwingBeans.gmk Changeset: 69ef657320ad Author: ohair Date: 2010-01-29 09:05 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/69ef657320ad Merge Changeset: 9027c6b9d7e2 Author: mikejwre Date: 2010-02-04 11:19 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9027c6b9d7e2 Added tag jdk7-b82 for changeset 69ef657320ad ! .hgtags Changeset: 9b82fa0505bc Author: mikejwre Date: 2010-02-12 13:25 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9b82fa0505bc Added tag jdk7-b83 for changeset 9027c6b9d7e2 ! .hgtags Changeset: e79d95ea2e81 Author: lana Date: 2010-02-08 23:59 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e79d95ea2e81 Merge Changeset: 7e8c77ae401a Author: rkennke Date: 2010-02-02 16:38 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7e8c77ae401a 6888734: PIT: regression test fails when java.security.manager is enabled Summary: Load FontManager instance in privileged block to avoid AccessControlException Reviewed-by: igor, tdv ! src/share/classes/sun/font/FontManagerFactory.java + test/java/awt/PrintJob/Security/SecurityDialogTest.java + test/java/awt/PrintJob/Security/policy Changeset: cedd0cdd5b9a Author: rkennke Date: 2010-02-03 10:02 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/cedd0cdd5b9a 6896335: GraphicsEnvironment.getDefaultScreenDevice() throws UnsatisfiedLinkError in headless mode Summary: Use local ge variable instead of localEnv field in GE. Reviewed-by: igor, prr ! src/share/classes/java/awt/GraphicsEnvironment.java + test/java/awt/GraphicsEnvironment/TestGetDefScreenDevice.java Changeset: 58d014485a29 Author: rkennke Date: 2010-02-07 11:07 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/58d014485a29 6904882: java.awt.Font.createFont() causes AccessControlException if executed with "-Djava.security.manager" Summary: Perform FontUtilities initialization in privileged block Reviewed-by: igor, prr ! src/share/classes/sun/font/FontUtilities.java + test/java/awt/FontClass/FontPrivilege.java Changeset: 89b0235188b5 Author: lana Date: 2010-02-09 00:00 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/89b0235188b5 Merge Changeset: 31a3f28f3326 Author: dcherepanov Date: 2009-12-23 01:22 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/31a3f28f3326 6908299: Missed changes for 6664512 during the merge with 6879044 Reviewed-by: mchung, art ! src/share/classes/sun/util/logging/PlatformLogger.java Changeset: 7b65af04d43c Author: dav Date: 2009-12-22 17:28 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7b65af04d43c 6893325: JComboBox and dragging to an item outside the bounds of the containing JFrame is not selecting that Reviewed-by: art, dcherepanov ! src/solaris/classes/sun/awt/X11/XWindowPeer.java Changeset: 26280d1705b2 Author: dcherepanov Date: 2009-12-28 20:35 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/26280d1705b2 6857363: deadlock caused by sun.awt.X11.XTrayIconPeer$Tooltip.display Reviewed-by: ant, art ! src/solaris/classes/sun/awt/X11/InfoWindow.java Changeset: fd5bf5955e37 Author: uta Date: 2009-12-24 17:19 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/fd5bf5955e37 4874070: invoking DragSource's startDrag with an Image renders no image on drag Reviewed-by: art, denis, alexp ! make/sun/awt/FILES_c_windows.gmk ! make/sun/awt/Makefile ! make/sun/awt/make.depend ! src/share/classes/javax/swing/TransferHandler.java ! src/share/classes/sun/awt/dnd/SunDragSourceContextPeer.java ! src/windows/classes/sun/awt/windows/WDataTransferer.java ! src/windows/classes/sun/awt/windows/WDragSourceContextPeer.java ! src/windows/classes/sun/awt/windows/WToolkit.java ! src/windows/lib/flavormap.properties ! src/windows/native/sun/windows/awt.h + src/windows/native/sun/windows/awt_DCHolder.cpp + src/windows/native/sun/windows/awt_DCHolder.h ! src/windows/native/sun/windows/awt_DnDDS.cpp ! src/windows/native/sun/windows/awt_DnDDS.h ! src/windows/native/sun/windows/awt_DnDDT.cpp ! src/windows/native/sun/windows/awt_DnDDT.h ! src/windows/native/sun/windows/awt_Toolkit.cpp ! src/windows/native/sun/windows/awt_Toolkit.h + src/windows/native/sun/windows/awt_ole.cpp + src/windows/native/sun/windows/awt_ole.h + test/java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor.html + test/java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor.java + test/java/awt/dnd/DnDFileGroupDescriptor/DnDTarget.java + test/java/awt/dnd/ImageDecoratedDnD/DnDSource.java + test/java/awt/dnd/ImageDecoratedDnD/DnDTarget.java + test/java/awt/dnd/ImageDecoratedDnD/ImageDecoratedDnD.html + test/java/awt/dnd/ImageDecoratedDnD/ImageDecoratedDnD.java + test/java/awt/dnd/ImageDecoratedDnD/ImageGenerator.java + test/java/awt/dnd/ImageDecoratedDnD/MyCursor.java + test/java/awt/dnd/ImageDecoratedDnDInOut/DnDSource.java + test/java/awt/dnd/ImageDecoratedDnDInOut/DnDTarget.java + test/java/awt/dnd/ImageDecoratedDnDInOut/ImageDecoratedDnDInOut.html + test/java/awt/dnd/ImageDecoratedDnDInOut/ImageDecoratedDnDInOut.java + test/java/awt/dnd/ImageDecoratedDnDInOut/ImageGenerator.java + test/java/awt/dnd/ImageDecoratedDnDInOut/MyCursor.java + test/java/awt/dnd/ImageDecoratedDnDNegative/DnDSource.java + test/java/awt/dnd/ImageDecoratedDnDNegative/DnDTarget.java + test/java/awt/dnd/ImageDecoratedDnDNegative/ImageDecoratedDnDNegative.html + test/java/awt/dnd/ImageDecoratedDnDNegative/ImageDecoratedDnDNegative.java + test/java/awt/dnd/ImageDecoratedDnDNegative/ImageGenerator.java + test/java/awt/dnd/ImageDecoratedDnDNegative/MyCursor.java Changeset: 4799006d0171 Author: uta Date: 2010-01-13 17:10 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4799006d0171 Merge Changeset: f154d4943a1a Author: uta Date: 2010-01-14 17:56 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f154d4943a1a 6916867: Fastdebug build failed after CR 4874070 fix putback. Reviewed-by: art, dcherepanov ! src/windows/native/sun/windows/awt_DnDDS.cpp Changeset: 3cc5eff94552 Author: dcherepanov Date: 2010-01-20 01:33 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3cc5eff94552 6660258: Java application stops Windows logout/shutdown (regression in 1.5.0_14) Reviewed-by: anthony, art, uta ! src/windows/native/sun/windows/awt_Component.cpp ! src/windows/native/sun/windows/awtmsg.h Changeset: 0f92194cd798 Author: dcherepanov Date: 2010-01-22 19:47 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0f92194cd798 6756774: fstdebug jvm fails with assertion (result != deleted_handle(),"Used a deleted global handle.") Reviewed-by: art, anthony ! src/windows/native/sun/windows/awt_MenuItem.cpp Changeset: d7c4baff3f96 Author: lana Date: 2010-01-28 18:24 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d7c4baff3f96 Merge - make/java/redist/FILES.gmk ! make/sun/awt/Makefile - make/sun/nio/FILES_java.gmk - src/share/classes/sun/dyn/util/BytecodeSignature.java - src/solaris/classes/sun/nio/ch/SctpSocketDispatcher.java Changeset: 66c193082586 Author: yan Date: 2010-02-08 17:02 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/66c193082586 6882912: Strange behaviours when typing @ or ' Summary: Eliminate stray lines without a proper unicode->regularKeyID pair (e.g. as there is no "arrow left" unicode, should be no pair) Reviewed-by: rupashka ! src/share/classes/sun/awt/ExtendedKeyCodes.java Changeset: b51982678191 Author: lana Date: 2010-02-09 00:02 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b51982678191 Merge Changeset: de7807599a9b Author: peytoia Date: 2009-12-15 14:50 +0900 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/de7807599a9b 5047314: [Col] Collator.compare() runs indefinitely for a certain set of Thai strings Reviewed-by: okutsu ! src/share/classes/java/text/CollationElementIterator.java + test/java/text/Collator/Bug5047314.java Changeset: 3efbbc00ac5f Author: lana Date: 2009-12-16 16:25 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3efbbc00ac5f Merge - make/tools/CharsetMapping/DoubleByte-X.java - make/tools/CharsetMapping/SingleByte-X.java - src/share/classes/sun/awt/ComponentAccessor.java - src/share/classes/sun/awt/WindowAccessor.java - src/share/classes/sun/security/provider/IdentityDatabase.java - src/share/classes/sun/security/provider/SystemIdentity.java - src/share/classes/sun/security/provider/SystemSigner.java - src/share/classes/sun/security/x509/X500Signer.java - src/share/classes/sun/security/x509/X509Cert.java - src/share/classes/sun/tools/jar/JarVerifierStream.java - src/share/classes/sun/util/CoreResourceBundleControl-XLocales.java - src/share/classes/sun/util/LocaleDataMetaInfo-XLocales.java - test/java/util/Formatter/Basic-X.java - test/sun/tools/native2ascii/test2 - test/tools/launcher/SolarisDataModel.sh - test/tools/launcher/SolarisRunpath.sh - test/tools/launcher/libraryCaller.c - test/tools/launcher/libraryCaller.h - test/tools/launcher/libraryCaller.java Changeset: e2f7e92c30f1 Author: peterz Date: 2009-12-21 19:26 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e2f7e92c30f1 6860433: [Nimbus] Code to set a single slider's thumb background doesn't work as specified Reviewed-by: rupashka ! src/share/classes/javax/swing/plaf/nimbus/Defaults.template ! src/share/classes/javax/swing/plaf/nimbus/NimbusLookAndFeel.java + test/javax/swing/plaf/nimbus/ColorCustomizationTest.java Changeset: fffd21bc5657 Author: peterz Date: 2009-12-25 17:47 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/fffd21bc5657 6860438: [Nimbus] Code to globally set slider's thumb background doesn't work as specified Reviewed-by: rupashka ! src/share/classes/javax/swing/MultiUIDefaults.java + test/javax/swing/MultiUIDefaults/4300666/bug4300666.html + test/javax/swing/MultiUIDefaults/4300666/bug4300666.java + test/javax/swing/MultiUIDefaults/4331767/bug4331767.java + test/javax/swing/MultiUIDefaults/Test6860438.java Changeset: e9ccd1dd6923 Author: andrew Date: 2010-01-08 12:51 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e9ccd1dd6923 6584033: (tz) wrong buffer length in TimeZone_md.c Summary: Add testcase for this bug Reviewed-by: darcy, okutsu + test/java/util/TimeZone/TimeZoneDatePermissionCheck.java + test/java/util/TimeZone/TimeZoneDatePermissionCheck.sh Changeset: b129d0f7be40 Author: peytoia Date: 2010-01-13 15:40 +0900 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b129d0f7be40 6868503: RuleBasedBreakIterator is inefficient Reviewed-by: okutsu ! src/share/classes/java/text/RuleBasedBreakIterator.java Changeset: 9c5a24050392 Author: malenkov Date: 2010-01-21 21:45 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9c5a24050392 4922835: DOC: Statement javadoc should indicate that target and methodName cannot be null Reviewed-by: peterz ! src/share/classes/java/beans/Expression.java ! src/share/classes/java/beans/Statement.java Changeset: eba0ff97a252 Author: malenkov Date: 2010-01-21 21:53 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/eba0ff97a252 4968536: DOC: Javadoc for java.beans.Encoder.getPersistenceDelegate is incomplete Reviewed-by: peterz ! src/share/classes/java/beans/Encoder.java Changeset: 3c61edecf44f Author: okutsu Date: 2010-01-26 15:42 +0900 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3c61edecf44f 6912866: (date) java.util.Date.before / after may be expensive Reviewed-by: peytoia ! src/share/classes/java/util/Date.java Changeset: e7127f3fa2f4 Author: peterz Date: 2010-01-28 17:06 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e7127f3fa2f4 6912118: Incosistency in several SynthUI classes between inherited specs ofupdate() and paint() methods Reviewed-by: rupashka ! src/share/classes/javax/swing/plaf/synth/SynthButtonUI.java ! src/share/classes/javax/swing/plaf/synth/SynthColorChooserUI.java ! src/share/classes/javax/swing/plaf/synth/SynthComboBoxUI.java ! src/share/classes/javax/swing/plaf/synth/SynthDesktopIconUI.java ! src/share/classes/javax/swing/plaf/synth/SynthDesktopPaneUI.java ! src/share/classes/javax/swing/plaf/synth/SynthEditorPaneUI.java ! src/share/classes/javax/swing/plaf/synth/SynthInternalFrameUI.java ! src/share/classes/javax/swing/plaf/synth/SynthLabelUI.java ! src/share/classes/javax/swing/plaf/synth/SynthListUI.java ! src/share/classes/javax/swing/plaf/synth/SynthMenuBarUI.java ! src/share/classes/javax/swing/plaf/synth/SynthMenuItemUI.java ! src/share/classes/javax/swing/plaf/synth/SynthMenuUI.java ! src/share/classes/javax/swing/plaf/synth/SynthOptionPaneUI.java ! src/share/classes/javax/swing/plaf/synth/SynthPanelUI.java ! src/share/classes/javax/swing/plaf/synth/SynthPopupMenuUI.java ! src/share/classes/javax/swing/plaf/synth/SynthProgressBarUI.java ! src/share/classes/javax/swing/plaf/synth/SynthRootPaneUI.java ! src/share/classes/javax/swing/plaf/synth/SynthScrollBarUI.java ! src/share/classes/javax/swing/plaf/synth/SynthScrollPaneUI.java ! src/share/classes/javax/swing/plaf/synth/SynthSeparatorUI.java ! src/share/classes/javax/swing/plaf/synth/SynthSliderUI.java ! src/share/classes/javax/swing/plaf/synth/SynthSpinnerUI.java ! src/share/classes/javax/swing/plaf/synth/SynthSplitPaneUI.java ! src/share/classes/javax/swing/plaf/synth/SynthTabbedPaneUI.java ! src/share/classes/javax/swing/plaf/synth/SynthTableHeaderUI.java ! src/share/classes/javax/swing/plaf/synth/SynthTableUI.java ! src/share/classes/javax/swing/plaf/synth/SynthTextAreaUI.java ! src/share/classes/javax/swing/plaf/synth/SynthTextFieldUI.java ! src/share/classes/javax/swing/plaf/synth/SynthToolBarUI.java ! src/share/classes/javax/swing/plaf/synth/SynthToolTipUI.java ! src/share/classes/javax/swing/plaf/synth/SynthTreeUI.java ! src/share/classes/javax/swing/plaf/synth/SynthViewportUI.java Changeset: 4eb3a8c95c24 Author: malenkov Date: 2010-01-28 20:49 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4eb3a8c95c24 6412286: DOC: LTP: Unspecified NPE in java.beans.DefaultPersistenceDelegate.instantiate method Reviewed-by: peterz ! src/share/classes/java/beans/DefaultPersistenceDelegate.java ! src/share/classes/java/beans/PersistenceDelegate.java Changeset: 3283bb8c1bcb Author: lana Date: 2010-01-28 16:12 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3283bb8c1bcb Merge - make/java/redist/FILES.gmk - make/sun/nio/FILES_java.gmk - src/share/classes/sun/dyn/util/BytecodeSignature.java - src/solaris/classes/sun/nio/ch/SctpSocketDispatcher.java Changeset: 3913691b3021 Author: malenkov Date: 2010-02-05 10:36 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3913691b3021 6921057: REGRESSION: persistence delegate issue on Windows and Linux against 5.u23b03/6u17b11 Reviewed-by: peterz, art ! src/share/classes/java/beans/Introspector.java ! test/java/beans/Introspector/6380849/TestBeanInfo.java ! test/java/beans/Introspector/Test5102804.java ! test/java/beans/XMLEncoder/Test4646747.java Changeset: 5c0c2882eed2 Author: lana Date: 2010-02-09 00:05 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5c0c2882eed2 Merge Changeset: 7cb9388bb1a1 Author: lana Date: 2010-02-14 23:38 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7cb9388bb1a1 Merge Changeset: 84792500750c Author: lana Date: 2010-02-17 10:24 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/84792500750c Merge From lana.steuck at sun.com Wed Feb 17 17:03:05 2010 From: lana.steuck at sun.com (lana.steuck at sun.com) Date: Thu, 18 Feb 2010 01:03:05 +0000 Subject: hg: jdk7/tl/langtools: 7 new changesets Message-ID: <20100218010324.1DA7942596@hg.openjdk.java.net> Changeset: 47003a3622f6 Author: mikejwre Date: 2010-01-28 11:27 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/47003a3622f6 Added tag jdk7-b81 for changeset cfabfcf9f110 ! .hgtags Changeset: c9f4ae1f1480 Author: mikejwre Date: 2010-02-04 11:19 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/c9f4ae1f1480 Added tag jdk7-b82 for changeset 47003a3622f6 ! .hgtags Changeset: 2edcb5dc642d Author: mikejwre Date: 2010-02-12 13:25 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/2edcb5dc642d Added tag jdk7-b83 for changeset c9f4ae1f1480 ! .hgtags Changeset: 56a46d079264 Author: lana Date: 2010-02-08 23:59 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/56a46d079264 Merge Changeset: d9cd5b8286e4 Author: lana Date: 2010-02-14 23:39 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/d9cd5b8286e4 Merge Changeset: 67f0e05098fa Author: lana Date: 2010-02-17 10:25 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/67f0e05098fa Merge Changeset: 0fce6b64c258 Author: lana Date: 2010-02-17 16:29 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/0fce6b64c258 Merge From erik.van.zijst at gmail.com Wed Feb 17 22:50:13 2010 From: erik.van.zijst at gmail.com (Erik van Zijst) Date: Thu, 18 Feb 2010 17:50:13 +1100 Subject: Using the com/sun/tools/javac APIs Message-ID: <4B7CE325.4080802@gmail.com> Hi folks, Not sure if tis is the appropriate mailinglist, but I'm trying to get my head around the various javac API's and I'm having trouble understanding what I can or can not do. I'm parsing and traversing a set of source files using the unsupported com.sun.tools.javac.tree API and for every method invocation and type reference, I want to resolve the exact (source) location where that method of type is declared, so that I can render the sources with hyperlinks for full navigation (IDE-style). I'm having limited success. Traversing the JCTree.JCCompilationUnit list after the JavacTask.parse() step does not seems to offer name and type resolving (presumably because the attribution step hasn't run yet?). Traversing the javax.lang.model.element.Elements list from JavacTask.analyze() gives me class and method declarations with the name of the respective java source file (but not their character offset positions). Using the javac APIs, how do I go about matching these sets? Am I overlooking some functionality, or is this a non trivial task? Correct resolution is crucial. For instance, it's important that a call to SubType.finalMethodOnSuperClass() properly links to the declartion of finalMethodOnSuperClass() in the BaseType file (assuming SubType extends BaseType). Cheers, Erik From java.net at twistedprotein.com Wed Feb 17 23:57:56 2010 From: java.net at twistedprotein.com (Brendon McLean) Date: Thu, 18 Feb 2010 09:57:56 +0200 Subject: Using the com/sun/tools/javac APIs In-Reply-To: <4B7CE325.4080802@gmail.com> References: <4B7CE325.4080802@gmail.com> Message-ID: <75552219-3B24-44B1-A531-3C8C8637A504@twistedprotein.com> Hi Erik, I've dabbled in those APIs as well, and it is some the most impenetrable code I've looked at. You'll obviously need the source code as the documentation is almost completely unhelpful, and you'll probably need to look at it in a good IDE to hyperlink back and forward as you untangle the labyrinth. But I would strongly suggest checking out Kohsuke Kawaguchi's sourcerer project at https://sorcerer.dev.java.net/ (or for the blog that mentions it: http://weblogs.java.net/blog/kohsuke/archive/2006/09/sorcerer_a_bett.html). It seems like he's managed to accomplish exactly what you want to do, so it would be well worth checking it out. Regards, Brendon McLean. On 18 Feb 2010, at 8:50 , Erik van Zijst wrote: > Hi folks, > > Not sure if tis is the appropriate mailinglist, but I'm trying to get my head around the various javac API's and I'm having trouble understanding what I can or can not do. > > I'm parsing and traversing a set of source files using the unsupported com.sun.tools.javac.tree API and for every method invocation and type reference, I want to resolve the exact (source) location where that method of type is declared, so that I can render the sources with hyperlinks for full navigation (IDE-style). > > I'm having limited success. Traversing the JCTree.JCCompilationUnit list after the JavacTask.parse() step does not seems to offer name and type resolving (presumably because the attribution step hasn't run yet?). > > Traversing the javax.lang.model.element.Elements list from JavacTask.analyze() gives me class and method declarations with the name of the respective java source file (but not their character offset positions). > > Using the javac APIs, how do I go about matching these sets? Am I overlooking some functionality, or is this a non trivial task? > > Correct resolution is crucial. For instance, it's important that a call to SubType.finalMethodOnSuperClass() properly links to the declartion of finalMethodOnSuperClass() in the BaseType file (assuming SubType extends BaseType). > > Cheers, > Erik From erik.van.zijst at gmail.com Thu Feb 18 00:13:42 2010 From: erik.van.zijst at gmail.com (Erik van Zijst) Date: Thu, 18 Feb 2010 19:13:42 +1100 Subject: Using the com/sun/tools/javac APIs In-Reply-To: <75552219-3B24-44B1-A531-3C8C8637A504@twistedprotein.com> References: <4B7CE325.4080802@gmail.com> <75552219-3B24-44B1-A531-3C8C8637A504@twistedprotein.com> Message-ID: <4B7CF6B6.2080003@gmail.com> Hi Brendon, I have the full source code and I've been step-through debugging the various api implementations for a day now, but I just can't fully grok it. I'm glad to hear I'm not the only one :) I hadn't heard about Sourcerer before, but it is indeed doing exactly what I'm after (and those icons look familiar!). I'm not rendering HTML, but maybe I can use it as a starting point. Cheers, Erik Brendon McLean wrote: > Hi Erik, > > I've dabbled in those APIs as well, and it is some the most > impenetrable code I've looked at. You'll obviously need the source > code as the documentation is almost completely unhelpful, and you'll > probably need to look at it in a good IDE to hyperlink back and > forward as you untangle the labyrinth. > > But I would strongly suggest checking out Kohsuke Kawaguchi's > sourcerer project at https://sorcerer.dev.java.net/ (or for the blog > that mentions it: > http://weblogs.java.net/blog/kohsuke/archive/2006/09/sorcerer_a_bett.html). > It seems like he's managed to accomplish exactly what you want to do, > so it would be well worth checking it out. > > Regards, Brendon McLean. > > On 18 Feb 2010, at 8:50 , Erik van Zijst wrote: > >> Hi folks, >> >> Not sure if tis is the appropriate mailinglist, but I'm trying to >> get my head around the various javac API's and I'm having trouble >> understanding what I can or can not do. >> >> I'm parsing and traversing a set of source files using the >> unsupported com.sun.tools.javac.tree API and for every method >> invocation and type reference, I want to resolve the exact (source) >> location where that method of type is declared, so that I can >> render the sources with hyperlinks for full navigation (IDE-style). >> >> >> I'm having limited success. Traversing the JCTree.JCCompilationUnit >> list after the JavacTask.parse() step does not seems to offer name >> and type resolving (presumably because the attribution step hasn't >> run yet?). >> >> Traversing the javax.lang.model.element.Elements list from >> JavacTask.analyze() gives me class and method declarations with the >> name of the respective java source file (but not their character >> offset positions). >> >> Using the javac APIs, how do I go about matching these sets? Am I >> overlooking some functionality, or is this a non trivial task? >> >> Correct resolution is crucial. For instance, it's important that a >> call to SubType.finalMethodOnSuperClass() properly links to the >> declartion of finalMethodOnSuperClass() in the BaseType file >> (assuming SubType extends BaseType). >> >> Cheers, Erik > > From Jonathan.Gibbons at Sun.COM Thu Feb 18 09:16:50 2010 From: Jonathan.Gibbons at Sun.COM (Jonathan Gibbons) Date: Thu, 18 Feb 2010 09:16:50 -0800 Subject: Using the com/sun/tools/javac APIs In-Reply-To: <4B7CF6B6.2080003@gmail.com> References: <4B7CE325.4080802@gmail.com> <75552219-3B24-44B1-A531-3C8C8637A504@twistedprotein.com> <4B7CF6B6.2080003@gmail.com> Message-ID: <4B7D7602.6070309@sun.com> Erik, You should look at the combination of the javax.lang.model API and the com.sun.source API. The com.sun.source API should give you the hooks you need to get at the source positions (if any) for the elements found by the javax.lang.model API. -- Jon Erik van Zijst wrote: > Hi Brendon, > > I have the full source code and I've been step-through debugging the > various api implementations for a day now, but I just can't fully grok > it. I'm glad to hear I'm not the only one :) > > I hadn't heard about Sourcerer before, but it is indeed doing exactly > what I'm after (and those icons look familiar!). I'm not rendering > HTML, but maybe I can use it as a starting point. > > Cheers, > Erik > > > Brendon McLean wrote: >> Hi Erik, >> >> I've dabbled in those APIs as well, and it is some the most >> impenetrable code I've looked at. You'll obviously need the source >> code as the documentation is almost completely unhelpful, and you'll >> probably need to look at it in a good IDE to hyperlink back and >> forward as you untangle the labyrinth. >> >> But I would strongly suggest checking out Kohsuke Kawaguchi's >> sourcerer project at https://sorcerer.dev.java.net/ (or for the blog >> that mentions it: >> http://weblogs.java.net/blog/kohsuke/archive/2006/09/sorcerer_a_bett.html). >> >> It seems like he's managed to accomplish exactly what you want to do, >> so it would be well worth checking it out. >> >> Regards, Brendon McLean. >> >> On 18 Feb 2010, at 8:50 , Erik van Zijst wrote: >> >>> Hi folks, >>> >>> Not sure if tis is the appropriate mailinglist, but I'm trying to >>> get my head around the various javac API's and I'm having trouble >>> understanding what I can or can not do. >>> >>> I'm parsing and traversing a set of source files using the >>> unsupported com.sun.tools.javac.tree API and for every method >>> invocation and type reference, I want to resolve the exact (source) >>> location where that method of type is declared, so that I can >>> render the sources with hyperlinks for full navigation (IDE-style). >>> >>> >>> I'm having limited success. Traversing the JCTree.JCCompilationUnit >>> list after the JavacTask.parse() step does not seems to offer name >>> and type resolving (presumably because the attribution step hasn't >>> run yet?). >>> >>> Traversing the javax.lang.model.element.Elements list from >>> JavacTask.analyze() gives me class and method declarations with the >>> name of the respective java source file (but not their character >>> offset positions). >>> >>> Using the javac APIs, how do I go about matching these sets? Am I >>> overlooking some functionality, or is this a non trivial task? >>> >>> Correct resolution is crucial. For instance, it's important that a >>> call to SubType.finalMethodOnSuperClass() properly links to the >>> declartion of finalMethodOnSuperClass() in the BaseType file >>> (assuming SubType extends BaseType). >>> >>> Cheers, Erik >> >> > From jonathan.gibbons at sun.com Thu Feb 18 15:43:11 2010 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Thu, 18 Feb 2010 23:43:11 +0000 Subject: hg: jdk7/tl/langtools: 6927797: langtools/test/tools/javac/EarlyAssert.java fails when run with assertions enabled (-ea) Message-ID: <20100218234319.C38B04270B@hg.openjdk.java.net> Changeset: a3be81d385ee Author: jjg Date: 2010-02-18 15:41 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/a3be81d385ee 6927797: langtools/test/tools/javac/EarlyAssert.java fails when run with assertions enabled (-ea) Reviewed-by: darcy ! test/tools/javac/EarlyAssert.java + test/tools/javac/EarlyAssertWrapper.java From christopher.hegarty at sun.com Mon Feb 22 08:03:14 2010 From: christopher.hegarty at sun.com (christopher.hegarty at sun.com) Date: Mon, 22 Feb 2010 16:03:14 +0000 Subject: hg: jdk7/tl/jdk: 6912868: "java.net.useSystemProxies" behavior fails to check "use_same_proxy" in GNOME Message-ID: <20100222160419.D0C0842CC8@hg.openjdk.java.net> Changeset: e83d9c0d5e95 Author: chegar Date: 2010-02-22 15:27 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e83d9c0d5e95 6912868: "java.net.useSystemProxies" behavior fails to check "use_same_proxy" in GNOME Reviewed-by: alanb, chegar Contributed-by: damjan.jov at gmail.com ! src/solaris/native/sun/net/spi/DefaultProxySelector.c + test/java/net/ProxySelector/SystemProxies.java From gnu_andrew at member.fsf.org Mon Feb 22 12:12:59 2010 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Mon, 22 Feb 2010 20:12:59 +0000 Subject: Behaviour of VERBOSE=true on langtools build Message-ID: <17c6771e1002221212ra7f19absd43feade74fcca5d@mail.gmail.com> Enabling VERBOSE=true (presumably) should cause the build to produce more verbose build output. However, on langtools it just causes Ant to print the diagnostics (which have already been logged beforehand anyway) and not build langtools at all. I'd suggest the following change: diff -r bab75805f846 make/Makefile --- a/make/Makefile Fri Feb 19 17:14:22 2010 +0000 +++ b/make/Makefile Mon Feb 22 20:10:44 2010 +0000 @@ -70,7 +70,7 @@ endif ifdef VERBOSE - ANT_OPTIONS += -verbose -diagnostics + ANT_OPTIONS += -verbose -debug endif ifdef JDK_VERSION or just -verbose. If this looks ok, can I have a bug ID to push it? Thanks, -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From Jonathan.Gibbons at Sun.COM Mon Feb 22 12:39:30 2010 From: Jonathan.Gibbons at Sun.COM (Jonathan Gibbons) Date: Mon, 22 Feb 2010 12:39:30 -0800 Subject: Behaviour of VERBOSE=true on langtools build In-Reply-To: <17c6771e1002221212ra7f19absd43feade74fcca5d@mail.gmail.com> References: <17c6771e1002221212ra7f19absd43feade74fcca5d@mail.gmail.com> Message-ID: <4B82EB82.3060705@sun.com> Andrew John Hughes wrote: > Enabling VERBOSE=true (presumably) should cause the build to produce > more verbose build output. > > However, on langtools it just causes Ant to print the diagnostics > (which have already been logged beforehand anyway) and not build > langtools at all. > > I'd suggest the following change: > > diff -r bab75805f846 make/Makefile > --- a/make/Makefile Fri Feb 19 17:14:22 2010 +0000 > +++ b/make/Makefile Mon Feb 22 20:10:44 2010 +0000 > @@ -70,7 +70,7 @@ > endif > > ifdef VERBOSE > - ANT_OPTIONS += -verbose -diagnostics > + ANT_OPTIONS += -verbose -debug > endif > > ifdef JDK_VERSION > > or just -verbose. > > If this looks ok, can I have a bug ID to push it? > > Thanks, > 6928623: Behaviour of VERBOSE=true on langtools build From ahughes at redhat.com Mon Feb 22 13:37:25 2010 From: ahughes at redhat.com (ahughes at redhat.com) Date: Mon, 22 Feb 2010 21:37:25 +0000 Subject: hg: jdk7/tl/langtools: 6928623: Behaviour of VERBOSE=true on langtools build Message-ID: <20100222213732.57AD342D21@hg.openjdk.java.net> Changeset: f25efdb55c99 Author: andrew Date: 2010-02-22 21:37 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/f25efdb55c99 6928623: Behaviour of VERBOSE=true on langtools build Summary: VERBOSE=true causes -diagnostics to be passed to ant rather than -debug Reviewed-by: jjg ! make/Makefile From gnu_andrew at member.fsf.org Tue Feb 23 01:13:15 2010 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Tue, 23 Feb 2010 09:13:15 +0000 Subject: Behaviour of VERBOSE=true on langtools build In-Reply-To: <4B82EB82.3060705@sun.com> References: <17c6771e1002221212ra7f19absd43feade74fcca5d@mail.gmail.com> <4B82EB82.3060705@sun.com> Message-ID: <17c6771e1002230113sdb828b3j82ec514a1ec7e535@mail.gmail.com> On 22 February 2010 20:39, Jonathan Gibbons wrote: > Andrew John Hughes wrote: >> >> Enabling VERBOSE=true (presumably) should cause the build to produce >> more verbose build output. >> >> However, on langtools it just causes Ant to print the diagnostics >> (which have already been logged beforehand anyway) and not build >> langtools at all. >> >> I'd suggest the following change: >> >> diff -r bab75805f846 make/Makefile >> --- a/make/Makefile ? ? Fri Feb 19 17:14:22 2010 +0000 >> +++ b/make/Makefile ? ? Mon Feb 22 20:10:44 2010 +0000 >> @@ -70,7 +70,7 @@ >> ?endif >> >> ?ifdef VERBOSE >> - ?ANT_OPTIONS += -verbose -diagnostics >> + ?ANT_OPTIONS += -verbose -debug >> ?endif >> >> ?ifdef JDK_VERSION >> >> or just -verbose. >> >> If this looks ok, can I have a bug ID to push it? >> >> Thanks, >> > > 6928623: Behaviour of VERBOSE=true on langtools build > Thanks. Pushed to tl: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/f25efdb55c99 -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From christopher.hegarty at sun.com Tue Feb 23 09:08:59 2010 From: christopher.hegarty at sun.com (christopher.hegarty at sun.com) Date: Tue, 23 Feb 2010 17:08:59 +0000 Subject: hg: jdk7/tl/jdk: 6365587: Proxy-Connection header sent through tunnel Message-ID: <20100223170941.5292F41403@hg.openjdk.java.net> Changeset: c96d6cb31723 Author: chegar Date: 2010-02-23 17:08 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c96d6cb31723 6365587: Proxy-Connection header sent through tunnel Reviewed-by: michaelm ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java From jonathan.gibbons at sun.com Tue Feb 23 18:44:12 2010 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Wed, 24 Feb 2010 02:44:12 +0000 Subject: hg: jdk7/tl/langtools: 6511613: javac unexpectedly doesn't fail in some cases if an annotation processor specified Message-ID: <20100224024415.AA53C414A3@hg.openjdk.java.net> Changeset: 6eca0895a644 Author: jjg Date: 2010-02-23 18:43 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/6eca0895a644 6511613: javac unexpectedly doesn't fail in some cases if an annotation processor specified Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/util/Log.java + test/tools/javac/processing/6511613/DummyProcessor.java + test/tools/javac/processing/6511613/clss41701.java From alan.bateman at sun.com Wed Feb 24 01:57:56 2010 From: alan.bateman at sun.com (alan.bateman at sun.com) Date: Wed, 24 Feb 2010 09:57:56 +0000 Subject: hg: jdk7/tl/jdk: 4 new changesets Message-ID: <20100224095911.499924152A@hg.openjdk.java.net> Changeset: 38fbb2353a6a Author: alanb Date: 2010-02-23 17:56 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/38fbb2353a6a 6925977: (file) test/java/nio/file/Path/CheckPermissions.java fails if test.src on read-only file system Reviewed-by: chegar ! test/java/nio/file/Path/CheckPermissions.java Changeset: 00abf8c232be Author: alanb Date: 2010-02-23 17:58 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/00abf8c232be 6925932: (file) Path.endsWith can throw ArrayIndexOutOfBoundsException (unx) Reviewed-by: chegar ! src/solaris/classes/sun/nio/fs/UnixPath.java ! test/java/nio/file/Path/PathOps.java Changeset: be5db597f3be Author: alanb Date: 2010-02-23 18:19 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/be5db597f3be 6928960: make modules fails to build class analyzer Reviewed-by: mchung ! make/modules/tools/Makefile Changeset: e94b296b53b4 Author: alanb Date: 2010-02-23 18:21 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e94b296b53b4 6926800: TEST_BUG: java/nio/file/Files/walk_file_tree.sh fails with newer versions of find(1) Reviewed-by: forax ! test/java/nio/file/Files/PrintFileTree.java ! test/java/nio/file/Files/walk_file_tree.sh From breamoreboy at yahoo.co.uk Wed Feb 24 07:02:09 2010 From: breamoreboy at yahoo.co.uk (Mark Lawrence) Date: Wed, 24 Feb 2010 15:02:09 +0000 Subject: Using the com/sun/tools/javac APIs In-Reply-To: <4B7CF6B6.2080003@gmail.com> References: <4B7CE325.4080802@gmail.com> <75552219-3B24-44B1-A531-3C8C8637A504@twistedprotein.com> <4B7CF6B6.2080003@gmail.com> Message-ID: Sorry to butt in, but I'm looking at using these APIs and have just come across this and thought it might give us all some pointers. http://code.google.com/p/smart-codegen/ Regards. Mark Lawrence Erik van Zijst wrote: > Hi Brendon, > > I have the full source code and I've been step-through debugging the > various api implementations for a day now, but I just can't fully grok > it. I'm glad to hear I'm not the only one :) > > I hadn't heard about Sourcerer before, but it is indeed doing exactly > what I'm after (and those icons look familiar!). I'm not rendering HTML, > but maybe I can use it as a starting point. > > Cheers, > Erik > > > Brendon McLean wrote: >> Hi Erik, >> >> I've dabbled in those APIs as well, and it is some the most >> impenetrable code I've looked at. You'll obviously need the source >> code as the documentation is almost completely unhelpful, and you'll >> probably need to look at it in a good IDE to hyperlink back and >> forward as you untangle the labyrinth. >> >> But I would strongly suggest checking out Kohsuke Kawaguchi's >> sourcerer project at https://sorcerer.dev.java.net/ (or for the blog >> that mentions it: >> http://weblogs.java.net/blog/kohsuke/archive/2006/09/sorcerer_a_bett.html). >> >> It seems like he's managed to accomplish exactly what you want to do, >> so it would be well worth checking it out. >> >> Regards, Brendon McLean. >> >> On 18 Feb 2010, at 8:50 , Erik van Zijst wrote: >> >>> Hi folks, >>> >>> Not sure if tis is the appropriate mailinglist, but I'm trying to >>> get my head around the various javac API's and I'm having trouble >>> understanding what I can or can not do. >>> >>> I'm parsing and traversing a set of source files using the >>> unsupported com.sun.tools.javac.tree API and for every method >>> invocation and type reference, I want to resolve the exact (source) >>> location where that method of type is declared, so that I can >>> render the sources with hyperlinks for full navigation (IDE-style). >>> >>> >>> I'm having limited success. Traversing the JCTree.JCCompilationUnit >>> list after the JavacTask.parse() step does not seems to offer name >>> and type resolving (presumably because the attribution step hasn't >>> run yet?). >>> >>> Traversing the javax.lang.model.element.Elements list from >>> JavacTask.analyze() gives me class and method declarations with the >>> name of the respective java source file (but not their character >>> offset positions). >>> >>> Using the javac APIs, how do I go about matching these sets? Am I >>> overlooking some functionality, or is this a non trivial task? >>> >>> Correct resolution is crucial. For instance, it's important that a >>> call to SubType.finalMethodOnSuperClass() properly links to the >>> declartion of finalMethodOnSuperClass() in the BaseType file >>> (assuming SubType extends BaseType). >>> >>> Cheers, Erik >> >> > > From joe.darcy at sun.com Wed Feb 24 10:49:13 2010 From: joe.darcy at sun.com (joe.darcy at sun.com) Date: Wed, 24 Feb 2010 18:49:13 +0000 Subject: hg: jdk7/tl/jdk: 6929382: Various core classes in util and elsewhere are missing @param tags Message-ID: <20100224184932.478AE415E8@hg.openjdk.java.net> Changeset: e842e99b514a Author: darcy Date: 2010-02-24 10:48 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e842e99b514a 6929382: Various core classes in util and elsewhere are missing @param tags Reviewed-by: dholmes, martin ! src/share/classes/java/lang/Iterable.java ! src/share/classes/java/util/Collection.java ! src/share/classes/java/util/Iterator.java ! src/share/classes/java/util/List.java From xuelei.fan at sun.com Wed Feb 24 22:13:28 2010 From: xuelei.fan at sun.com (xuelei.fan at sun.com) Date: Thu, 25 Feb 2010 06:13:28 +0000 Subject: hg: jdk7/tl/jdk: 6916202: More cases of invalid ldap filters accepted and processed Message-ID: <20100225061347.A1F03416C0@hg.openjdk.java.net> Changeset: 9929203a8b98 Author: xuelei Date: 2010-02-25 13:32 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9929203a8b98 6916202: More cases of invalid ldap filters accepted and processed Reviewed-by: vinnie, weijun ! src/share/classes/com/sun/jndi/ldap/Filter.java + test/com/sun/jndi/ldap/InvalidLdapFilters.java From jonathan.gibbons at sun.com Thu Feb 25 09:44:27 2010 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Thu, 25 Feb 2010 17:44:27 +0000 Subject: hg: jdk7/tl/langtools: 4880220: Add a warning when accessing a static method via an reference Message-ID: <20100225174430.2B9114177B@hg.openjdk.java.net> Changeset: 87eb6edd4f21 Author: jjg Date: 2010-02-25 09:42 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/87eb6edd4f21 4880220: Add a warning when accessing a static method via an reference Reviewed-by: darcy ! make/build.properties ! src/share/classes/com/sun/tools/javac/code/Lint.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties + test/tools/javac/4880220/T4880220.empty.out + test/tools/javac/4880220/T4880220.error.out + test/tools/javac/4880220/T4880220.java + test/tools/javac/4880220/T4880220.warn.out From joe.darcy at sun.com Thu Feb 25 11:04:54 2010 From: joe.darcy at sun.com (joe.darcy at sun.com) Date: Thu, 25 Feb 2010 19:04:54 +0000 Subject: hg: jdk7/tl/langtools: 6929645: Address various findbugs warnings in langtools Message-ID: <20100225190457.3A42541793@hg.openjdk.java.net> Changeset: 85242c273d31 Author: darcy Date: 2010-02-25 11:04 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/85242c273d31 6929645: Address various findbugs warnings in langtools Reviewed-by: jjg ! src/share/classes/com/sun/tools/apt/comp/Apt.java ! src/share/classes/com/sun/tools/apt/mirror/declaration/AnnotationProxyMaker.java ! src/share/classes/com/sun/tools/apt/mirror/declaration/DeclarationImpl.java ! src/share/classes/com/sun/tools/javac/model/AnnotationProxyMaker.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java From jonathan.gibbons at sun.com Thu Feb 25 12:27:45 2010 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Thu, 25 Feb 2010 20:27:45 +0000 Subject: hg: jdk7/tl/langtools: 6929544: langtools source code uses statics qualified by instance variables Message-ID: <20100225202748.28FA1417AB@hg.openjdk.java.net> Changeset: dbcba45123cd Author: jjg Date: 2010-02-25 12:26 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/dbcba45123cd 6929544: langtools source code uses statics qualified by instance variables Reviewed-by: darcy ! make/build.properties ! src/share/classes/com/sun/tools/apt/main/CommandLine.java ! src/share/classes/com/sun/tools/apt/mirror/type/TypeMirrorImpl.java ! src/share/classes/com/sun/tools/doclets/standard/Standard.java ! src/share/classes/com/sun/tools/javac/Launcher.java ! src/share/classes/com/sun/tools/javac/api/JavacTool.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/jvm/Items.java ! src/share/classes/com/sun/tools/javac/main/CommandLine.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java From jonathan.gibbons at sun.com Thu Feb 25 13:33:31 2010 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Thu, 25 Feb 2010 21:33:31 +0000 Subject: hg: jdk7/tl/langtools: 6893943: exit code from javah with no args is 0 Message-ID: <20100225213334.1F0A4417BD@hg.openjdk.java.net> Changeset: af75fd6155de Author: jjg Date: 2010-02-25 13:32 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/af75fd6155de 6893943: exit code from javah with no args is 0 Reviewed-by: darcy ! src/share/classes/com/sun/tools/javah/JavahTask.java + test/tools/javah/T6893943.java From jonathan.gibbons at sun.com Fri Feb 26 08:43:27 2010 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Fri, 26 Feb 2010 16:43:27 +0000 Subject: hg: jdk7/tl/langtools: 6881645: Unchecked method call on a method declared inside anonymous inner causes javac to crash Message-ID: <20100226164330.8BF3041902@hg.openjdk.java.net> Changeset: b030706da5b4 Author: jjg Date: 2010-02-26 08:42 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/b030706da5b4 6881645: Unchecked method call on a method declared inside anonymous inner causes javac to crash Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/code/Symbol.java + test/tools/javac/T6881645.java From jonathan.gibbons at sun.com Fri Feb 26 15:28:02 2010 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Fri, 26 Feb 2010 23:28:02 +0000 Subject: hg: jdk7/tl/langtools: 6930076: "null" can incorrectly appear in error message compiler.err.error.reading.file Message-ID: <20100226232805.0F9D641976@hg.openjdk.java.net> Changeset: 72833a8a6086 Author: jjg Date: 2010-02-26 15:26 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/72833a8a6086 6930076: "null" can incorrectly appear in error message compiler.err.error.reading.file Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/file/JavacFileManager.java ! src/share/classes/com/sun/tools/javac/file/Paths.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java From jonathan.gibbons at sun.com Fri Feb 26 15:31:24 2010 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Fri, 26 Feb 2010 23:31:24 +0000 Subject: hg: jdk7/tl/langtools: 6930032: fix findbugs errors in com.sun.tools.javac.comp Message-ID: <20100226233127.44DF241978@hg.openjdk.java.net> Changeset: 7b69c7083a97 Author: jjg Date: 2010-02-26 15:30 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/7b69c7083a97 6930032: fix findbugs errors in com.sun.tools.javac.comp Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/comp/Enter.java ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java From alan.bateman at sun.com Sat Feb 27 10:19:24 2010 From: alan.bateman at sun.com (alan.bateman at sun.com) Date: Sat, 27 Feb 2010 18:19:24 +0000 Subject: hg: jdk7/tl/jdk: 6929532: (file) WatchService should avoid queuing new modify events when lots of files are changing Message-ID: <20100227182017.5B7DE41AB3@hg.openjdk.java.net> Changeset: 77beb60b39c6 Author: alanb Date: 2010-02-27 18:18 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/77beb60b39c6 6929532: (file) WatchService should avoid queuing new modify events when lots of files are changing Reviewed-by: alanb Contributed-by: sebastian.sickelmann at gmx.de ! src/share/classes/sun/nio/fs/AbstractWatchKey.java + test/java/nio/file/WatchService/LotsOfEvents.java - test/java/nio/file/WatchService/OverflowEventIsLoner.java From alan.bateman at sun.com Sat Feb 27 11:17:31 2010 From: alan.bateman at sun.com (alan.bateman at sun.com) Date: Sat, 27 Feb 2010 19:17:31 +0000 Subject: hg: jdk7/tl/jdk: 6929259: Remove double spaces from Dual-pivot quicksort Message-ID: <20100227191749.BB57441AC3@hg.openjdk.java.net> Changeset: b77e94f5a601 Author: alanb Date: 2010-02-27 19:15 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b77e94f5a601 6929259: Remove double spaces from Dual-pivot quicksort Reviewed-by: alanb Contributed-by: vladimir.yaroslavskiy at sun.com ! src/share/classes/java/util/DualPivotQuicksort.java From alan.bateman at sun.com Sun Feb 28 04:14:23 2010 From: alan.bateman at sun.com (alan.bateman at sun.com) Date: Sun, 28 Feb 2010 12:14:23 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20100228121503.D34B441BD2@hg.openjdk.java.net> Changeset: 529d2da0aee2 Author: alanb Date: 2010-02-27 19:26 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/529d2da0aee2 6815768: File.getxxxSpace() methods fail for very large file systems under 32bit Java Reviewed-by: ohair ! src/solaris/native/java/io/UnixFileSystem_md.c Changeset: f7a6eae6e1eb Author: alanb Date: 2010-02-27 19:29 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f7a6eae6e1eb 6921374: java.lang.String::hashCode() should check for count == 0 to avoid repeated stores hash = 0 Reviewed-by: darcy, ohair ! src/share/classes/java/lang/String.java From jim.andreou at gmail.com Wed Feb 17 07:37:06 2010 From: jim.andreou at gmail.com (Dimitris Andreou) Date: Wed, 17 Feb 2010 15:37:06 -0000 Subject: Probable enum-related compiler bug Message-ID: <7d7138c11002170737n20efd3d7j34feeb972183cd67@mail.gmail.com> Hi all, I have this: public enum MyEnum implements Runnable { X() { public void run() { } }, } and in another file: public class Test { public static void main(String[] args) { MyEnum.X.run(); } } Starting from a clean state, compiling it (using jdk 1.6.0_14) produces this error: Test.java:3: cannot find symbol symbol : method run() location: class MyEnum MyEnum.X.run(); 1 error If I first compile MyEnum.java, and in a second step Test.java, no error is produced. The workaround I did to have a stable compilation is this: public enum MyEnum implements Runnable { X() { public void run() { } }, public abstract void run(); } Is this a known bug? Regards, Dimitris -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20100217/f04b4cdb/attachment.html