hg: jdk7/tl/langtools: 6917130: should test that annotations that have been optimized away are not emitted to classfile

Joseph D. Darcy Joe.Darcy at Sun.COM
Tue Jan 26 12:46:24 PST 2010

Jonathan Gibbons wrote:
> Neal Gafter wrote:
>> On Tue, Jan 26, 2010 at 12:24 PM, Joseph D. Darcy <Joe.Darcy at sun.com> wrote:
>>> Neal Gafter wrote:
>>>> Note that this is testing for "optional" behavior, which is a
>>>> quality-of-implementation issue and not a correctness issue.
>>> ...which is perfectly appropriate for JDK-specific regression tests :-)
>> Agreed.  However, it would be a good idea to put a note in the test,
>> just in case someone ends up confused over why some other compiler
>> doesn't pass it.
> Well, there is no precedent for making any such notes in the many 
> other tests for
> javac-specific tests. Look at all the tests that directly use internal 
> javac API.

All the tests in the langtools repository come with the implicit 
requirement of being run against the matching javac.

I think putting explicit notes on this point in particular tests is 
generally unnecessary and would be undesirable.

There are other compiler and language test suites explicitly designed 
and intended to be compiler agnostic.


More information about the compiler-dev mailing list