Code review for 7086595: Error message bug: name of initializer is 'null'

[Rémi Forax]

On 12/04/2011 04:03 PM, Weijun Wang wrote:
> If the fix is identical, no code review is necessary. You only need to write to jdk7u-dev@ for a backport approval.
>
> -Max
>
>
>
> On Dec 4, 2011, at 2:24 AM, Dmeetry Degrave<Dmitry.Degrave at oracle.com>  wrote:
>
>> Hi,
>>
>> I'm looking for a code review for 7086595. This is a port from jdk8 to 7u4 with identical fix.
>>
>> bug: http://bugs.sun.com/view_bug.do?bug_id=7086595
>> webrev: http://cr.openjdk.java.net/~dmeetry/7086595/webrev.0/
>> jdk8: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ed338593b0b6
>>
>> thanks,
>> dmeetry

BTW, the jdk8 fix (already approved) has a method which is coded weirdly.
Symbol.isStaticOrInstanceInit should be written

   public boolean isStaticOrInstanceInit() {
     return (flags() & BLOCK) != 0 || name == name.table.names.clinit;
   }

instead of calling getKind() twice.

Rémi