Code review for 7086595: Error message bug: name of initializer is 'null'

[Dalibor Topic]

On 12/6/11 2:18 PM, Dmeetry Degrave wrote:
> On 12/06/2011 04:21 PM, Dalibor Topic wrote:
>> On 12/6/11 11:09 AM, Dmeetry Degrave wrote:
>>> On 12/05/2011 11:08 PM, Dalibor Topic wrote:
>>>> On 12/4/11 5:09 PM, Dmeetry Degrave wrote:
>>>>> I see some uncertainties if fixes are pushed to previous releases without a review,
>>>>>
>>>>> - every push to repo needs a reviewer. It's mandatory, isn't ?
>>>> Yes, but jdk7u has a shortcut, so to speak - since we share many, if not all, reviewers with jdk8,
>>>> and in general want changes to go into jdk8, you don't need to have a separate review of an identical
>>>> fix for jdk7u that has gone into jdk8 already.
>>> to be crystal clear here, whose openjdk name is supposed to be used in "Reviewed-by:" field ?
>> The same as in the push to the jdk8 forest.
> 
> it looks strange to make "Reviewed-by" statement with name of a person who hasn't seen actual changes that are going to be pushed.

Of course, if you want to have your changes reviewed again for jdk7u, you can - in that case
you'd need to list the reviewers who did the jdk7u specific review.

cheers,
dalibor topic
-- 
Oracle <http://www.oracle.com>
Dalibor Topic | Java F/OSS Ambassador
Phone: +494023646738 <tel:+494023646738> | Mobile: +491772664192 <tel:+491772664192>
Oracle Java Platform Group

ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg

ORACLE Deutschland B.V. & Co. KG
Hauptverwaltung: Riesstr. 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603
Geschäftsführer: Jürgen Kunz

Komplementärin: ORACLE Deutschland Verwaltung B.V.
Hertogswetering 163/167, 3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Astrid Kepper, Val Maher

Green Oracle <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment