Proposed javac argument processing performance improvement

[Rémi Forax]

Jon,
I think that processArgs should return a Collection instead of an Iterable
to avoid to call iterator().hasNext() when you want isEmpty().

Rémi

On 06/30/2011 09:51 PM, Jonathan Gibbons wrote:
> On 06/24/2011 02:09 PM, Jonathan Gibbons wrote:
>> On 06/24/2011 01:04 PM, David Schlosnagle wrote:
>>> On Fri, Jun 24, 2011 at 3:54 PM, Jonathan Gibbons
>>> <jonathan.gibbons at oracle.com>  wrote:
>>>> David,
>>>>
>>>> Thank you for your updated patch.  I agree with concern that the revised
>>>> code
>>>> in JavacTaskImpl.java is somewhat messier than before, so I've attached an
>>>> alternate way of doing it for your consideration.  This keeps the code
>>>> closer
>>>> to what it was before, at the expense of a couple of trivial utility
>>>> methods.
>>>>
>>>> If you agree with this alternate impl for JavacTaskImpl.java, we can proceed
>>>> by using that with the rest of your patch.
>>> Jon,
>>>
>>> That looks good to me.
>>>
>>> - Dave
>>
>>
>> Dave,
>>
>> Thanks for the speedy response. We'll work on getting this overall 
>> patch integrated.
>>
>> -- Jon
>
> The webrev for the change is available at 
> http://cr.openjdk.java.net/~jjg/7061125-cmdlineperf/
>
> -- Jon

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20110702/3efe4b03/attachment.html