From chris.hegarty at oracle.com Tue Oct 4 08:12:21 2011 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Tue, 04 Oct 2011 15:12:21 +0000 Subject: hg: jdk8/tl/jdk: 6953455: CookieStore.add() cannot handle null URI parameter, contrary to the API Message-ID: <20111004151240.D32BB47BC1@hg.openjdk.java.net> Changeset: 74f5fef1d961 Author: chegar Date: 2011-10-04 13:48 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/74f5fef1d961 6953455: CookieStore.add() cannot handle null URI parameter, contrary to the API Reviewed-by: chegar, mduigou Contributed-by: kurchi.subhra.hazra at oracle.com ! src/share/classes/java/net/InMemoryCookieStore.java + test/java/net/CookieHandler/NullUriCookieTest.java From chris.hegarty at oracle.com Tue Oct 4 09:52:58 2011 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Tue, 04 Oct 2011 16:52:58 +0000 Subject: hg: jdk8/tl/jdk: 7095949: java/net/URLConnection/RedirectLimit.java and Redirect307Test fail intermittently Message-ID: <20111004165316.BF71647BC6@hg.openjdk.java.net> Changeset: 24741fe639a8 Author: chegar Date: 2011-10-04 16:37 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/24741fe639a8 7095949: java/net/URLConnection/RedirectLimit.java and Redirect307Test fail intermittently Reviewed-by: alanb ! test/java/net/URLConnection/Redirect307Test.java ! test/java/net/URLConnection/RedirectLimit.java From masayoshi.okutsu at oracle.com Tue Oct 4 23:23:52 2011 From: masayoshi.okutsu at oracle.com (masayoshi.okutsu at oracle.com) Date: Wed, 05 Oct 2011 06:23:52 +0000 Subject: hg: jdk8/tl/jdk: 7092679: (tz) Java getting wrong timezone/DST info on Solaris 11; ... Message-ID: <20111005062411.EF7E847BEC@hg.openjdk.java.net> Changeset: 2bc80ba6f4a4 Author: okutsu Date: 2011-10-05 15:13 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2bc80ba6f4a4 7092679: (tz) Java getting wrong timezone/DST info on Solaris 11 6984762: Invalid close of file descriptor '-1' in findZoneinfoFile Reviewed-by: coffeys, ohair, naoto, peytoia ! make/common/Defs-linux.gmk ! make/common/Defs-solaris.gmk ! make/java/java/Makefile ! src/solaris/native/java/util/TimeZone_md.c From lana.steuck at oracle.com Wed Oct 5 10:15:56 2011 From: lana.steuck at oracle.com (Lana Steuck) Date: Wed, 05 Oct 2011 10:15:56 -0700 Subject: jdk8/jdk8: 5 new changesets In-Reply-To: <002701cc836c$e733cca0$b59b65e0$@bcs.org.uk> References: <20111004174448.289F447BCA@hg.openjdk.java.net> <002701cc836c$e733cca0$b59b65e0$@bcs.org.uk> Message-ID: <4E8C90CC.4030304@oracle.com> Hi Somay, > what is the best way to suggest an improvement to the Java language constructs In Jdk7, we had Project Coin - this is where people would proposal small language changes to be considered for 7: http://openjdk.java.net/projects/coin/ The proposals were discussed here: coin-dev at openjdk.java.net . You may want to check the mail archive (http://mail.openjdk.java.net/pipermail/coin-dev/) to see if anybody else has already proposed anything similar to what you have in mind. The project was sponsored by the Compiler Group (aka Langtools Group) This is their mailing list: compiler-dev at openjdk.java.net Feel free to contact the Compiler team with your proposal for Jdk8. Thank you, Lana On 10/05/2011 07:41 AM, Somay Nakhal wrote: > Hi Lana, > > I have a question I'm not sure if you will be able to help me with or point > me in the right direction. The question is: what is the best way to suggest > an improvement to the Java language constructs (to be considered for version > 8)? > > Thanks, > > Somay Nakhal > +44 (0)77 860 860 65 > somay.nakhal at bcs.org.uk > > -----Original Message----- > From: jdk8-dev-bounces at openjdk.java.net > [mailto:jdk8-dev-bounces at openjdk.java.net] On Behalf Of > lana.steuck at oracle.com > Sent: 04 October 2011 18:45 > To: jdk8-changes at openjdk.java.net; jdk8-dev at openjdk.java.net > Subject: hg: jdk8/jdk8: 5 new changesets > > Changeset: b1d357ebf0cb > Author: weijun > Date: 2011-09-08 09:06 +0800 > URL: http://hg.openjdk.java.net/jdk8/jdk8/rev/b1d357ebf0cb > > 7087428: move client tests out of jdk_misc > Reviewed-by: ohair, alanb > > ! make/jprt.properties > > Changeset: 123873564c23 > Author: lana > Date: 2011-09-13 08:37 -0700 > URL: http://hg.openjdk.java.net/jdk8/jdk8/rev/123873564c23 > > Merge > > > Changeset: 39edfd9d8ff0 > Author: lana > Date: 2011-09-23 23:25 -0700 > URL: http://hg.openjdk.java.net/jdk8/jdk8/rev/39edfd9d8ff0 > > Merge > > > Changeset: 2f1af0e3e8f7 > Author: lana > Date: 2011-09-26 14:31 -0700 > URL: http://hg.openjdk.java.net/jdk8/jdk8/rev/2f1af0e3e8f7 > > Merge > > > Changeset: fb1bc13260d7 > Author: lana > Date: 2011-10-03 18:22 -0700 > URL: http://hg.openjdk.java.net/jdk8/jdk8/rev/fb1bc13260d7 > > Merge > > > > > ----- > No virus found in this message. > Checked by AVG - www.avg.com > Version: 10.0.1410 / Virus Database: 1520/3937 - Release Date: 10/04/11 > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20111005/7bda128f/attachment.html From joe.darcy at oracle.com Wed Oct 5 20:48:32 2011 From: joe.darcy at oracle.com (Joe Darcy) Date: Wed, 05 Oct 2011 20:48:32 -0700 Subject: jdk8/jdk8: 5 new changesets In-Reply-To: <4E8C90CC.4030304@oracle.com> References: <20111004174448.289F447BCA@hg.openjdk.java.net> <002701cc836c$e733cca0$b59b65e0$@bcs.org.uk> <4E8C90CC.4030304@oracle.com> Message-ID: <4E8D2510.7050604@oracle.com> Hello, The proper forum to subject a request for a language improvement is http://bugreport.sun.com/bugreport/ Cheers, -Joe Lana Steuck wrote: > Hi Somay, > > what is the best way to suggest an improvement to the Java language constructs > In Jdk7, we had Project Coin - this is where people would proposal > small language changes to be considered for 7: > http://openjdk.java.net/projects/coin/ > The proposals were discussed here: coin-dev at openjdk.java.net > . > You may want to check the mail archive > (http://mail.openjdk.java.net/pipermail/coin-dev/) > to see if anybody else has already proposed anything similar to what > you have in mind. > > The project was sponsored by the Compiler Group (aka Langtools Group) > This is their mailing list: compiler-dev at openjdk.java.net > > Feel free to contact the Compiler team with your proposal for Jdk8. > > Thank you, > Lana > > > On 10/05/2011 07:41 AM, Somay Nakhal wrote: >> Hi Lana, >> >> I have a question I'm not sure if you will be able to help me with or point >> me in the right direction. The question is: what is the best way to suggest >> an improvement to the Java language constructs (to be considered for version >> 8)? >> >> Thanks, >> >> Somay Nakhal >> +44 (0)77 860 860 65 >> somay.nakhal at bcs.org.uk >> >> -----Original Message----- >> From: jdk8-dev-bounces at openjdk.java.net >> [mailto:jdk8-dev-bounces at openjdk.java.net] On Behalf Of >> lana.steuck at oracle.com >> Sent: 04 October 2011 18:45 >> To: jdk8-changes at openjdk.java.net; jdk8-dev at openjdk.java.net >> Subject: hg: jdk8/jdk8: 5 new changesets >> >> Changeset: b1d357ebf0cb >> Author: weijun >> Date: 2011-09-08 09:06 +0800 >> URL: http://hg.openjdk.java.net/jdk8/jdk8/rev/b1d357ebf0cb >> >> 7087428: move client tests out of jdk_misc >> Reviewed-by: ohair, alanb >> >> ! make/jprt.properties >> >> Changeset: 123873564c23 >> Author: lana >> Date: 2011-09-13 08:37 -0700 >> URL: http://hg.openjdk.java.net/jdk8/jdk8/rev/123873564c23 >> >> Merge >> >> >> Changeset: 39edfd9d8ff0 >> Author: lana >> Date: 2011-09-23 23:25 -0700 >> URL: http://hg.openjdk.java.net/jdk8/jdk8/rev/39edfd9d8ff0 >> >> Merge >> >> >> Changeset: 2f1af0e3e8f7 >> Author: lana >> Date: 2011-09-26 14:31 -0700 >> URL: http://hg.openjdk.java.net/jdk8/jdk8/rev/2f1af0e3e8f7 >> >> Merge >> >> >> Changeset: fb1bc13260d7 >> Author: lana >> Date: 2011-10-03 18:22 -0700 >> URL: http://hg.openjdk.java.net/jdk8/jdk8/rev/fb1bc13260d7 >> >> Merge >> >> >> >> >> ----- >> No virus found in this message. >> Checked by AVG - www.avg.com >> Version: 10.0.1410 / Virus Database: 1520/3937 - Release Date: 10/04/11 >> >> > From Dmitry.Degrave at oracle.com Thu Oct 6 02:38:48 2011 From: Dmitry.Degrave at oracle.com (Dmeetry Degrave) Date: Thu, 06 Oct 2011 13:38:48 +0400 Subject: Code review request: 7086586 Inference producing null type argument Message-ID: <4E8D7728.3000007@oracle.com> hi, i'm looking for a code review for 7086586 fix for 7u4. It implements fix suggested by Maurizio for problem 2 from evaluation. bug description: http://bugs.sun.com/view_bug.do?bug_id=7086586 jdk7 evaluation: http://bugs.sun.com/view_bug.do?bug_id=2213800 webrev: http://cr.openjdk.java.net/~dmeetry/7086586/webrev.00/ thanks, dmeetry From maurizio.cimadamore at oracle.com Thu Oct 6 02:47:04 2011 From: maurizio.cimadamore at oracle.com (Maurizio Cimadamore) Date: Thu, 06 Oct 2011 10:47:04 +0100 Subject: Code review request: 7086586 Inference producing null type argument In-Reply-To: <4E8D7728.3000007@oracle.com> References: <4E8D7728.3000007@oracle.com> Message-ID: <4E8D7918.20407@oracle.com> On 06/10/11 10:38, Dmeetry Degrave wrote: > > hi, > > i'm looking for a code review for 7086586 fix for 7u4. It implements > fix suggested by Maurizio for problem 2 from evaluation. > > bug description: http://bugs.sun.com/view_bug.do?bug_id=7086586 > jdk7 evaluation: http://bugs.sun.com/view_bug.do?bug_id=2213800 > > webrev: http://cr.openjdk.java.net/~dmeetry/7086586/webrev.00/ > > thanks, > dmeetry Approved Maurizio From maurizio.cimadamore at oracle.com Thu Oct 6 02:47:58 2011 From: maurizio.cimadamore at oracle.com (Maurizio Cimadamore) Date: Thu, 06 Oct 2011 10:47:58 +0100 Subject: Code review request: 7085024 internal error; cannot instantiate Foo In-Reply-To: <4E83B6AB.6020307@oracle.com> References: <4E83B6AB.6020307@oracle.com> Message-ID: <4E8D794E.4020500@oracle.com> On 29/09/11 01:07, Dmeetry Degrave wrote: > http://bugs.sun.com/view_bug.do?bug_id=7085024 > > fix is identical to jdk8, this is a back port to jdk7u. > > webrev : http://cr.openjdk.java.net/~dmeetry/7085024/webrev.00/ > jdk8: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b86277584776 > > thanks, > dmeetry Approved Maurizio From forax at univ-mlv.fr Thu Oct 6 03:01:36 2011 From: forax at univ-mlv.fr (=?ISO-8859-1?Q?R=E9mi_Forax?=) Date: Thu, 06 Oct 2011 12:01:36 +0200 Subject: Code review request: 7085024 internal error; cannot instantiate Foo In-Reply-To: <4E8D794E.4020500@oracle.com> References: <4E83B6AB.6020307@oracle.com> <4E8D794E.4020500@oracle.com> Message-ID: <4E8D7C80.3030307@univ-mlv.fr> On 10/06/2011 11:47 AM, Maurizio Cimadamore wrote: > On 29/09/11 01:07, Dmeetry Degrave wrote: >> http://bugs.sun.com/view_bug.do?bug_id=7085024 >> >> fix is identical to jdk8, this is a back port to jdk7u. >> >> webrev : http://cr.openjdk.java.net/~dmeetry/7085024/webrev.00/ >> jdk8: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b86277584776 >> >> thanks, >> dmeetry > Approved > > Maurizio if botFilter is declared static final, the patch is Ok for me. cheers, R?mi From maurizio.cimadamore at oracle.com Thu Oct 6 03:50:07 2011 From: maurizio.cimadamore at oracle.com (Maurizio Cimadamore) Date: Thu, 06 Oct 2011 11:50:07 +0100 Subject: Code review request: 7085024 internal error; cannot instantiate Foo In-Reply-To: <4E8D7C80.3030307@univ-mlv.fr> References: <4E83B6AB.6020307@oracle.com> <4E8D794E.4020500@oracle.com> <4E8D7C80.3030307@univ-mlv.fr> Message-ID: <4E8D87DF.4040008@oracle.com> On 06/10/11 11:01, R?mi Forax wrote: > On 10/06/2011 11:47 AM, Maurizio Cimadamore wrote: >> On 29/09/11 01:07, Dmeetry Degrave wrote: >>> http://bugs.sun.com/view_bug.do?bug_id=7085024 >>> >>> fix is identical to jdk8, this is a back port to jdk7u. >>> >>> webrev : http://cr.openjdk.java.net/~dmeetry/7085024/webrev.00/ >>> jdk8: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b86277584776 >>> >>> thanks, >>> dmeetry >> Approved >> >> Maurizio > > if botFilter is declared static final, > the patch is Ok for me. final yes static no :-) it is supposed to be used if you have an instance of Types around [and the context instantiation protocol will already ensure there's only _one_ instance of Types] Maurizio > > cheers, > R?mi From forax at univ-mlv.fr Thu Oct 6 05:01:15 2011 From: forax at univ-mlv.fr (=?ISO-8859-1?Q?R=E9mi_Forax?=) Date: Thu, 06 Oct 2011 14:01:15 +0200 Subject: Code review request: 7085024 internal error; cannot instantiate Foo In-Reply-To: <4E8D87DF.4040008@oracle.com> References: <4E83B6AB.6020307@oracle.com> <4E8D794E.4020500@oracle.com> <4E8D7C80.3030307@univ-mlv.fr> <4E8D87DF.4040008@oracle.com> Message-ID: <4E8D988B.2080302@univ-mlv.fr> On 10/06/2011 12:50 PM, Maurizio Cimadamore wrote: > On 06/10/11 11:01, R?mi Forax wrote: >> On 10/06/2011 11:47 AM, Maurizio Cimadamore wrote: >>> On 29/09/11 01:07, Dmeetry Degrave wrote: >>>> http://bugs.sun.com/view_bug.do?bug_id=7085024 >>>> >>>> fix is identical to jdk8, this is a back port to jdk7u. >>>> >>>> webrev : http://cr.openjdk.java.net/~dmeetry/7085024/webrev.00/ >>>> jdk8: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b86277584776 >>>> >>>> thanks, >>>> dmeetry >>> Approved >>> >>> Maurizio >> >> if botFilter is declared static final, >> the patch is Ok for me. > final yes > static no :-) > > it is supposed to be used if you have an instance of Types around [and > the context instantiation protocol will already ensure there's only > _one_ instance of Types] > > Maurizio That's true for javac, not for any tools that will use javac classes but not its kind of dependency manager. Anyway, this code will be transformed into a lambda at the start of JDK9 timeframe :) >> >> cheers, >> R?mi > R?mi From maurizio.cimadamore at oracle.com Thu Oct 6 05:23:54 2011 From: maurizio.cimadamore at oracle.com (Maurizio Cimadamore) Date: Thu, 06 Oct 2011 13:23:54 +0100 Subject: Code review request: 7085024 internal error; cannot instantiate Foo In-Reply-To: <4E8D988B.2080302@univ-mlv.fr> References: <4E83B6AB.6020307@oracle.com> <4E8D794E.4020500@oracle.com> <4E8D7C80.3030307@univ-mlv.fr> <4E8D87DF.4040008@oracle.com> <4E8D988B.2080302@univ-mlv.fr> Message-ID: <4E8D9DDA.9030108@oracle.com> On 06/10/11 13:01, R?mi Forax wrote: > That's true for javac, not for any tools that will use javac classes but > not its kind of dependency manager. It's extremely hard to use javac classes w/o going through the context management. The most common use case for javac classes clients is to register subclasses of javac classes in the context so that they will be indirectly used by javac. Anyway - I realized that the bug we should be discussing is 7086586 - we are on the wrong thread ;-) Maurizio From maurizio.cimadamore at oracle.com Thu Oct 6 05:34:26 2011 From: maurizio.cimadamore at oracle.com (Maurizio Cimadamore) Date: Thu, 06 Oct 2011 13:34:26 +0100 Subject: Code review request: 7086586 Inference producing null type argument In-Reply-To: <4E8D7918.20407@oracle.com> References: <4E8D7728.3000007@oracle.com> <4E8D7918.20407@oracle.com> Message-ID: <4E8DA052.5080501@oracle.com> On 06/10/11 10:47, Maurizio Cimadamore wrote: > On 06/10/11 10:38, Dmeetry Degrave wrote: >> >> hi, >> >> i'm looking for a code review for 7086586 fix for 7u4. It implements >> fix suggested by Maurizio for problem 2 from evaluation. >> >> bug description: http://bugs.sun.com/view_bug.do?bug_id=7086586 >> jdk7 evaluation: http://bugs.sun.com/view_bug.do?bug_id=2213800 >> >> webrev: http://cr.openjdk.java.net/~dmeetry/7086586/webrev.00/ >> >> thanks, >> dmeetry > Approved > > Maurizio Remi has suggested to use 'static final' on botFilter. I'd be ok with final, less ok with 'static' if no other reason than for consistencies with similar declarations in Infer.java. Remi what do you think? Maurizio From chris.hegarty at oracle.com Thu Oct 6 06:24:28 2011 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Thu, 06 Oct 2011 13:24:28 +0000 Subject: hg: jdk8/tl/jdk: 7090499: missing rawtypes warnings in anonymous inner class Message-ID: <20111006132450.30F6947C40@hg.openjdk.java.net> Changeset: ff5e57dc1fb3 Author: chegar Date: 2011-10-06 12:15 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ff5e57dc1fb3 7090499: missing rawtypes warnings in anonymous inner class Summary: Fix anonymous inner classes with raw types currently being built in the jdk with -Werror Reviewed-by: mcimadamore, alanb ! src/share/classes/java/net/DatagramSocket.java ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java ! src/share/classes/sun/security/pkcs11/SunPKCS11.java From jonathan.gibbons at oracle.com Thu Oct 6 06:25:48 2011 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Thu, 06 Oct 2011 06:25:48 -0700 Subject: Code review request: 7085024 internal error; cannot instantiate Foo In-Reply-To: <4E8D988B.2080302@univ-mlv.fr> References: <4E83B6AB.6020307@oracle.com> <4E8D794E.4020500@oracle.com> <4E8D7C80.3030307@univ-mlv.fr> <4E8D87DF.4040008@oracle.com> <4E8D988B.2080302@univ-mlv.fr> Message-ID: <4E8DAC5C.4060102@oracle.com> On 10/06/2011 05:01 AM, R?mi Forax wrote: > On 10/06/2011 12:50 PM, Maurizio Cimadamore wrote: >> On 06/10/11 11:01, R?mi Forax wrote: >>> On 10/06/2011 11:47 AM, Maurizio Cimadamore wrote: >>>> On 29/09/11 01:07, Dmeetry Degrave wrote: >>>>> http://bugs.sun.com/view_bug.do?bug_id=7085024 >>>>> >>>>> fix is identical to jdk8, this is a back port to jdk7u. >>>>> >>>>> webrev : http://cr.openjdk.java.net/~dmeetry/7085024/webrev.00/ >>>>> jdk8: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b86277584776 >>>>> >>>>> thanks, >>>>> dmeetry >>>> Approved >>>> >>>> Maurizio >>> >>> if botFilter is declared static final, >>> the patch is Ok for me. >> final yes >> static no :-) >> >> it is supposed to be used if you have an instance of Types around >> [and the context instantiation protocol will already ensure there's >> only _one_ instance of Types] >> >> Maurizio > > That's true for javac, not for any tools that will use javac classes but > not its kind of dependency manager. See the comment at the head of most javac source files. > > Anyway, this code will be transformed into a lambda at the start of > JDK9 timeframe :) Maybe, but don't hold your breath. javac is deliberately conservative in the language features it uses. > >>> >>> cheers, >>> R?mi >> > > R?mi > From jonathan.gibbons at oracle.com Thu Oct 6 06:28:29 2011 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Thu, 06 Oct 2011 06:28:29 -0700 Subject: Code review request: 7086586 Inference producing null type argument In-Reply-To: <4E8DA052.5080501@oracle.com> References: <4E8D7728.3000007@oracle.com> <4E8D7918.20407@oracle.com> <4E8DA052.5080501@oracle.com> Message-ID: <4E8DACFD.9040208@oracle.com> On 10/06/2011 05:34 AM, Maurizio Cimadamore wrote: > On 06/10/11 10:47, Maurizio Cimadamore wrote: >> On 06/10/11 10:38, Dmeetry Degrave wrote: >>> >>> hi, >>> >>> i'm looking for a code review for 7086586 fix for 7u4. It implements >>> fix suggested by Maurizio for problem 2 from evaluation. >>> >>> bug description: http://bugs.sun.com/view_bug.do?bug_id=7086586 >>> jdk7 evaluation: http://bugs.sun.com/view_bug.do?bug_id=2213800 >>> >>> webrev: http://cr.openjdk.java.net/~dmeetry/7086586/webrev.00/ >>> >>> thanks, >>> dmeetry >> Approved >> >> Maurizio > Remi has suggested to use 'static final' on botFilter. I'd be ok with > final, less ok with 'static' if no other reason than for consistencies > with similar declarations in Infer.java. Remi what do you think? > > Maurizio Since botFilter is a private member of a javac internal class, we should not be optimizing the code for external use. -- Jon From forax at univ-mlv.fr Thu Oct 6 06:31:07 2011 From: forax at univ-mlv.fr (=?ISO-8859-1?Q?R=E9mi_Forax?=) Date: Thu, 06 Oct 2011 15:31:07 +0200 Subject: Code review request: 7086586 Inference producing null type argument In-Reply-To: <4E8DA052.5080501@oracle.com> References: <4E8D7728.3000007@oracle.com> <4E8D7918.20407@oracle.com> <4E8DA052.5080501@oracle.com> Message-ID: <4E8DAD9B.4000206@univ-mlv.fr> On 10/06/2011 02:34 PM, Maurizio Cimadamore wrote: > On 06/10/11 10:47, Maurizio Cimadamore wrote: >> On 06/10/11 10:38, Dmeetry Degrave wrote: >>> >>> hi, >>> >>> i'm looking for a code review for 7086586 fix for 7u4. It implements >>> fix suggested by Maurizio for problem 2 from evaluation. >>> >>> bug description: http://bugs.sun.com/view_bug.do?bug_id=7086586 >>> jdk7 evaluation: http://bugs.sun.com/view_bug.do?bug_id=2213800 >>> >>> webrev: http://cr.openjdk.java.net/~dmeetry/7086586/webrev.00/ >>> >>> thanks, >>> dmeetry >> Approved >> >> Maurizio > Remi has suggested to use 'static final' on botFilter. I'd be ok with > final, less ok with 'static' if no other reason than for consistencies > with similar declarations in Infer.java. Remi what do you think? > > Maurizio I think that all closures that doesn't capture any states should be declared static. Also a VM may be able to better optimize a static field if Type.filter is inlined. R?mi From jonathan.gibbons at oracle.com Thu Oct 6 06:36:34 2011 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Thu, 06 Oct 2011 06:36:34 -0700 Subject: Code review request: 7086586 Inference producing null type argument In-Reply-To: <4E8DAD9B.4000206@univ-mlv.fr> References: <4E8D7728.3000007@oracle.com> <4E8D7918.20407@oracle.com> <4E8DA052.5080501@oracle.com> <4E8DAD9B.4000206@univ-mlv.fr> Message-ID: <4E8DAEE2.9080404@oracle.com> On 10/06/2011 06:31 AM, R?mi Forax wrote: > On 10/06/2011 02:34 PM, Maurizio Cimadamore wrote: >> On 06/10/11 10:47, Maurizio Cimadamore wrote: >>> On 06/10/11 10:38, Dmeetry Degrave wrote: >>>> >>>> hi, >>>> >>>> i'm looking for a code review for 7086586 fix for 7u4. It >>>> implements fix suggested by Maurizio for problem 2 from evaluation. >>>> >>>> bug description: http://bugs.sun.com/view_bug.do?bug_id=7086586 >>>> jdk7 evaluation: http://bugs.sun.com/view_bug.do?bug_id=2213800 >>>> >>>> webrev: http://cr.openjdk.java.net/~dmeetry/7086586/webrev.00/ >>>> >>>> thanks, >>>> dmeetry >>> Approved >>> >>> Maurizio >> Remi has suggested to use 'static final' on botFilter. I'd be ok with >> final, less ok with 'static' if no other reason than for >> consistencies with similar declarations in Infer.java. Remi what do >> you think? >> >> Maurizio > > I think that all closures that doesn't capture any states should be > declared static. > Also a VM may be able to better optimize a static field if Type.filter > is inlined. > > R?mi > > > > It would be an interesting annotation processor for someone to write to analyze code to see which non-static members could plausibly be made static. -- Jon From Dmitry.Degrave at oracle.com Thu Oct 6 06:40:46 2011 From: Dmitry.Degrave at oracle.com (Dmeetry Degrave) Date: Thu, 06 Oct 2011 17:40:46 +0400 Subject: Code review request: 7086586 Inference producing null type argument In-Reply-To: <4E8DA052.5080501@oracle.com> References: <4E8D7728.3000007@oracle.com> <4E8D7918.20407@oracle.com> <4E8DA052.5080501@oracle.com> Message-ID: <4E8DAFDE.9060200@oracle.com> On 10/06/2011 04:01 PM, R?mi Forax wrote: > Anyway, this code will be transformed into a lambda at the start of > JDK9 timeframe :) R?mi, just a clarification. This fix is only for jdk7 updates and won't be propagated further. It has been fixed differently in jdk 8: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c0835c8489b0 thanks, dmeetry From forax at univ-mlv.fr Thu Oct 6 06:52:09 2011 From: forax at univ-mlv.fr (=?ISO-8859-1?Q?R=E9mi_Forax?=) Date: Thu, 06 Oct 2011 15:52:09 +0200 Subject: Code review request: 7086586 Inference producing null type argument In-Reply-To: <4E8DAFDE.9060200@oracle.com> References: <4E8D7728.3000007@oracle.com> <4E8D7918.20407@oracle.com> <4E8DA052.5080501@oracle.com> <4E8DAFDE.9060200@oracle.com> Message-ID: <4E8DB289.5040303@univ-mlv.fr> On 10/06/2011 03:40 PM, Dmeetry Degrave wrote: > On 10/06/2011 04:01 PM, R?mi Forax wrote: >> Anyway, this code will be transformed into a lambda at the start of >> JDK9 timeframe :) > > R?mi, > > just a clarification. This fix is only for jdk7 updates and won't be > propagated further. > > It has been fixed differently in jdk 8: > > http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c0835c8489b0 > > thanks, > dmeetry > Ok, good to know. final is in that case enough. regards, R?mi From forax at univ-mlv.fr Thu Oct 6 06:52:47 2011 From: forax at univ-mlv.fr (=?ISO-8859-1?Q?R=E9mi_Forax?=) Date: Thu, 06 Oct 2011 15:52:47 +0200 Subject: Code review request: 7085024 internal error; cannot instantiate Foo In-Reply-To: <4E8DAC5C.4060102@oracle.com> References: <4E83B6AB.6020307@oracle.com> <4E8D794E.4020500@oracle.com> <4E8D7C80.3030307@univ-mlv.fr> <4E8D87DF.4040008@oracle.com> <4E8D988B.2080302@univ-mlv.fr> <4E8DAC5C.4060102@oracle.com> Message-ID: <4E8DB2AF.80500@univ-mlv.fr> On 10/06/2011 03:25 PM, Jonathan Gibbons wrote: > On 10/06/2011 05:01 AM, R?mi Forax wrote: >> On 10/06/2011 12:50 PM, Maurizio Cimadamore wrote: >>> On 06/10/11 11:01, R?mi Forax wrote: >>>> On 10/06/2011 11:47 AM, Maurizio Cimadamore wrote: >>>>> On 29/09/11 01:07, Dmeetry Degrave wrote: >>>>>> http://bugs.sun.com/view_bug.do?bug_id=7085024 >>>>>> >>>>>> fix is identical to jdk8, this is a back port to jdk7u. >>>>>> >>>>>> webrev : http://cr.openjdk.java.net/~dmeetry/7085024/webrev.00/ >>>>>> jdk8: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b86277584776 >>>>>> >>>>>> thanks, >>>>>> dmeetry >>>>> Approved >>>>> >>>>> Maurizio >>>> >>>> if botFilter is declared static final, >>>> the patch is Ok for me. >>> final yes >>> static no :-) >>> >>> it is supposed to be used if you have an instance of Types around >>> [and the context instantiation protocol will already ensure there's >>> only _one_ instance of Types] >>> >>> Maurizio >> >> That's true for javac, not for any tools that will use javac classes but >> not its kind of dependency manager. > > See the comment at the head of most javac source files. I know, I know. > >> >> Anyway, this code will be transformed into a lambda at the start of >> JDK9 timeframe :) > > Maybe, but don't hold your breath. javac is deliberately conservative > in the language features it uses. It depends on the seasons. At some point in the past, javac was the only program that was using generics. R?mi From jonathan.gibbons at oracle.com Thu Oct 6 07:12:54 2011 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Thu, 06 Oct 2011 07:12:54 -0700 Subject: Code review request: 7085024 internal error; cannot instantiate Foo In-Reply-To: <4E8DB2AF.80500@univ-mlv.fr> References: <4E83B6AB.6020307@oracle.com> <4E8D794E.4020500@oracle.com> <4E8D7C80.3030307@univ-mlv.fr> <4E8D87DF.4040008@oracle.com> <4E8D988B.2080302@univ-mlv.fr> <4E8DAC5C.4060102@oracle.com> <4E8DB2AF.80500@univ-mlv.fr> Message-ID: <4E8DB766.60808@oracle.com> On 10/06/2011 06:52 AM, R?mi Forax wrote: > On 10/06/2011 03:25 PM, Jonathan Gibbons wrote: >> On 10/06/2011 05:01 AM, R?mi Forax wrote: >>> On 10/06/2011 12:50 PM, Maurizio Cimadamore wrote: >>>> On 06/10/11 11:01, R?mi Forax wrote: >>>>> On 10/06/2011 11:47 AM, Maurizio Cimadamore wrote: >>>>>> On 29/09/11 01:07, Dmeetry Degrave wrote: >>>>>>> http://bugs.sun.com/view_bug.do?bug_id=7085024 >>>>>>> >>>>>>> fix is identical to jdk8, this is a back port to jdk7u. >>>>>>> >>>>>>> webrev : http://cr.openjdk.java.net/~dmeetry/7085024/webrev.00/ >>>>>>> jdk8: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b86277584776 >>>>>>> >>>>>>> thanks, >>>>>>> dmeetry >>>>>> Approved >>>>>> >>>>>> Maurizio >>>>> >>>>> if botFilter is declared static final, >>>>> the patch is Ok for me. >>>> final yes >>>> static no :-) >>>> >>>> it is supposed to be used if you have an instance of Types around >>>> [and the context instantiation protocol will already ensure there's >>>> only _one_ instance of Types] >>>> >>>> Maurizio >>> >>> That's true for javac, not for any tools that will use javac classes >>> but >>> not its kind of dependency manager. >> >> See the comment at the head of most javac source files. > > I know, I know. > >> >>> >>> Anyway, this code will be transformed into a lambda at the start of >>> JDK9 timeframe :) >> >> Maybe, but don't hold your breath. javac is deliberately conservative >> in the language features it uses. > > It depends on the seasons. At some point in the past, javac was the > only program > that was using generics. > > R?mi > That was before open-source, when we could take some short cuts in the bootstrap process. Nowadays, we need to be able to build javac from source without using any bootstrap .jar files. -- Jon From maurizio.cimadamore at oracle.com Thu Oct 6 10:46:10 2011 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 06 Oct 2011 17:46:10 +0000 Subject: hg: jdk8/tl/langtools: 7090499: missing rawtypes warnings in anonymous inner class Message-ID: <20111006174614.CE47A47C4A@hg.openjdk.java.net> Changeset: 47147081d5b4 Author: mcimadamore Date: 2011-10-06 18:39 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/47147081d5b4 7090499: missing rawtypes warnings in anonymous inner class Summary: javac does not detect raw types inside anonymous inner classes Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/warnings/7090499/T7090499.java + test/tools/javac/warnings/7090499/T7090499.out From naoto.sato at oracle.com Thu Oct 6 19:45:19 2011 From: naoto.sato at oracle.com (naoto.sato at oracle.com) Date: Fri, 07 Oct 2011 02:45:19 +0000 Subject: hg: jdk8/tl/jdk: 7098394: JDK8 TL repo build fails in src/solaris/native/java/util/TimeZone_md.c Message-ID: <20111007024537.1905447C70@hg.openjdk.java.net> Changeset: b8a1d30d6c65 Author: naoto Date: 2011-10-06 17:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b8a1d30d6c65 7098394: JDK8 TL repo build fails in src/solaris/native/java/util/TimeZone_md.c Reviewed-by: chegar ! src/solaris/native/java/util/TimeZone_md.c From vincent.x.ryan at oracle.com Fri Oct 7 06:11:07 2011 From: vincent.x.ryan at oracle.com (vincent.x.ryan at oracle.com) Date: Fri, 07 Oct 2011 13:11:07 +0000 Subject: hg: jdk8/tl/jdk: 7094377: Com.sun.jndi.ldap.read.timeout doesn't work with ldaps. Message-ID: <20111007131128.B236947CAB@hg.openjdk.java.net> Changeset: 2edaef22de23 Author: vinnie Date: 2011-10-07 14:09 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2edaef22de23 7094377: Com.sun.jndi.ldap.read.timeout doesn't work with ldaps. Reviewed-by: chegar ! src/share/classes/com/sun/jndi/ldap/Connection.java + test/com/sun/jndi/ldap/LdapsReadTimeoutTest.java From peter.levart at gmail.com Fri Oct 7 12:29:38 2011 From: peter.levart at gmail.com (Peter Levart) Date: Fri, 7 Oct 2011 21:29:38 +0200 Subject: Acces to private field from nested class when the type of reference is a generic type variable with upper bound of outer class Message-ID: <201110072129.38451.peter.levart@gmail.com> This code compiles with latest JDK 6 javac: package test; public class Outer { private int outerField; public Outer(int outerField) { this.outerField = outerField; } public static class Inner { public int getOuterField(O outer) { return outer.outerField; } } public static void main(String[] args) { Outer outer = new Outer(12); Inner inner = new Inner(); System.out.println(inner.getOuterField(outer)); } } ... but refuses to compile with JDK 7 javac (release or latest 7u2-b08 prerelease), giving the following compilation failure: src/test/Outer.java:16: error: outerField has private access in Outer return outer.outerField; ^ even if tried with -source 1.6 -target 1.6 options. Is this intentional or a bug? Regards, Peter From maurizio.cimadamore at oracle.com Fri Oct 7 12:43:59 2011 From: maurizio.cimadamore at oracle.com (maurizio cimadamore) Date: Fri, 07 Oct 2011 20:43:59 +0100 Subject: Acces to private field from nested class when the type of reference is a generic type variable with upper bound of outer class In-Reply-To: <201110072129.38451.peter.levart@gmail.com> References: <201110072129.38451.peter.levart@gmail.com> Message-ID: <4E8F567F.8070100@oracle.com> Yep - that's intentional - it's listed in the compatibility notes of the JDK 7 release [1]. In general accessing private members of a type-variable is not sound (note that O could be instantiate by a subclass of Outer in which the field would not be accessible). [1] - http://www.oracle.com/technetwork/java/javase/compatibility-417013.html#source Maurizio On 07/10/2011 20:29, Peter Levart wrote: > This code compiles with latest JDK 6 javac: > > package test; > > public class Outer > { > private int outerField; > > public Outer(int outerField) > { > this.outerField = outerField; > } > > public static class Inner > { > public int getOuterField(O outer) > { > return outer.outerField; > } > } > > public static void main(String[] args) > { > Outer outer = new Outer(12); > Inner inner = new Inner(); > System.out.println(inner.getOuterField(outer)); > } > } > > > ... but refuses to compile with JDK 7 javac (release or latest 7u2-b08 prerelease), giving the > following compilation failure: > > src/test/Outer.java:16: error: outerField has private access in Outer > return outer.outerField; > ^ > > even if tried with -source 1.6 -target 1.6 options. > > Is this intentional or a bug? > > > Regards, Peter From david.lloyd at redhat.com Fri Oct 7 12:57:25 2011 From: david.lloyd at redhat.com (David M. Lloyd) Date: Fri, 07 Oct 2011 14:57:25 -0500 Subject: Acces to private field from nested class when the type of reference is a generic type variable with upper bound of outer class In-Reply-To: <201110072129.38451.peter.levart@gmail.com> References: <201110072129.38451.peter.levart@gmail.com> Message-ID: <4E8F59A5.4010009@redhat.com> On 10/07/2011 02:29 PM, Peter Levart wrote: > This code compiles with latest JDK 6 javac: > > package test; > > public class Outer > { > private int outerField; > > public Outer(int outerField) > { > this.outerField = outerField; > } > > public static class Inner > { > public int getOuterField(O outer) > { > return outer.outerField; > } > } > > public static void main(String[] args) > { > Outer outer = new Outer(12); > Inner inner = new Inner(); > System.out.println(inner.getOuterField(outer)); > } > } > > > ... but refuses to compile with JDK 7 javac (release or latest 7u2-b08 prerelease), giving the > following compilation failure: > > src/test/Outer.java:16: error: outerField has private access in Outer > return outer.outerField; > ^ > > even if tried with -source 1.6 -target 1.6 options. > > Is this intentional or a bug? I'd say it's a bug, according to JLS ?6.6.1 access to a private member is "permitted if and only if it occurs within the body of the top level class (?7.6) that encloses the declaration of the member or constructor." Looks to me like the access on line 16 occurs within the body of the top-level class (Outer) that encloses the declaration. -- - DML From david.lloyd at redhat.com Fri Oct 7 13:13:10 2011 From: david.lloyd at redhat.com (David M. Lloyd) Date: Fri, 07 Oct 2011 15:13:10 -0500 Subject: Acces to private field from nested class when the type of reference is a generic type variable with upper bound of outer class In-Reply-To: <4E8F567F.8070100@oracle.com> References: <201110072129.38451.peter.levart@gmail.com> <4E8F567F.8070100@oracle.com> Message-ID: <4E8F5D56.4040308@redhat.com> But the field _would_ be accessible according to JLS ?6.6.1 regardless of whether the object was of a subtype. It seems pretty clear to me, but maybe I'm just being dense? On 10/07/2011 02:43 PM, maurizio cimadamore wrote: > Yep - that's intentional - it's listed in the compatibility notes of the > JDK 7 release [1]. > In general accessing private members of a type-variable is not sound > (note that O could be instantiate by a subclass of Outer in which the > field would not be accessible). > > [1] - > http://www.oracle.com/technetwork/java/javase/compatibility-417013.html#source > > > Maurizio > > > On 07/10/2011 20:29, Peter Levart wrote: >> This code compiles with latest JDK 6 javac: >> >> package test; >> >> public class Outer >> { >> private int outerField; >> >> public Outer(int outerField) >> { >> this.outerField = outerField; >> } >> >> public static class Inner >> { >> public int getOuterField(O outer) >> { >> return outer.outerField; >> } >> } >> >> public static void main(String[] args) >> { >> Outer outer = new Outer(12); >> Inner inner = new Inner(); >> System.out.println(inner.getOuterField(outer)); >> } >> } >> >> >> ... but refuses to compile with JDK 7 javac (release or latest 7u2-b08 >> prerelease), giving the >> following compilation failure: >> >> src/test/Outer.java:16: error: outerField has private access in Outer >> return outer.outerField; >> ^ >> >> even if tried with -source 1.6 -target 1.6 options. >> >> Is this intentional or a bug? >> >> >> Regards, Peter > -- - DML From peter.levart at gmail.com Fri Oct 7 13:45:38 2011 From: peter.levart at gmail.com (Peter Levart) Date: Fri, 7 Oct 2011 22:45:38 +0200 Subject: Acces to private field from nested class when the type of reference is a generic type variable with upper bound of outer class In-Reply-To: <4E8F5D56.4040308@redhat.com> References: <201110072129.38451.peter.levart@gmail.com> <4E8F567F.8070100@oracle.com> <4E8F5D56.4040308@redhat.com> Message-ID: <201110072245.38427.peter.levart@gmail.com> On Friday, October 07, 2011 10:13:10 PM David M. Lloyd wrote: > But the field _would_ be accessible according to JLS ?6.6.1 regardless > of whether the object was of a subtype. It seems pretty clear to me, > but maybe I'm just being dense? It's not the type of object that matters, but the type of variable. For example: public class A { private int x = 1; void m() { B b = new B(); System.out.println(b.x); // no go A a = b; System.out.println(a.x); // prints 1 } } public class B extends A { private int x = 2; } ... you see, the same object, but different types of variables A vs. B! The same goes for types that are expressed as type-variables. They are a conjunction of all possible types that match the bounds (if any). The language is sound if it does not "prefer" just one of them. Peter > > On 10/07/2011 02:43 PM, maurizio cimadamore wrote: > > Yep - that's intentional - it's listed in the compatibility notes of the > > JDK 7 release [1]. > > In general accessing private members of a type-variable is not sound > > (note that O could be instantiate by a subclass of Outer in which the > > field would not be accessible). > > > > [1] - > > http://www.oracle.com/technetwork/java/javase/compatibility-417013.html#s > > ource > > > > > > Maurizio > > > > On 07/10/2011 20:29, Peter Levart wrote: > >> This code compiles with latest JDK 6 javac: > >> > >> package test; > >> > >> public class Outer > >> { > >> private int outerField; > >> > >> public Outer(int outerField) > >> { > >> this.outerField = outerField; > >> } > >> > >> public static class Inner > >> { > >> public int getOuterField(O outer) > >> { > >> return outer.outerField; > >> } > >> } > >> > >> public static void main(String[] args) > >> { > >> Outer outer = new Outer(12); > >> Inner inner = new Inner(); > >> System.out.println(inner.getOuterField(outer)); > >> } > >> } > >> > >> > >> ... but refuses to compile with JDK 7 javac (release or latest 7u2-b08 > >> prerelease), giving the > >> following compilation failure: > >> > >> src/test/Outer.java:16: error: outerField has private access in Outer > >> return outer.outerField; > >> ^ > >> > >> even if tried with -source 1.6 -target 1.6 options. > >> > >> Is this intentional or a bug? > >> > >> > >> Regards, Peter From peter.levart at gmail.com Fri Oct 7 13:57:12 2011 From: peter.levart at gmail.com (Peter Levart) Date: Fri, 7 Oct 2011 22:57:12 +0200 Subject: Acces to private field from nested class when the type of reference is a generic type variable with upper bound of outer class In-Reply-To: <201110072245.38427.peter.levart@gmail.com> References: <201110072129.38451.peter.levart@gmail.com> <4E8F5D56.4040308@redhat.com> <201110072245.38427.peter.levart@gmail.com> Message-ID: <201110072257.12555.peter.levart@gmail.com> On Friday, October 07, 2011 10:45:38 PM Peter Levart wrote: > The same goes for types that are expressed as type-variables. They are a > conjunction of all possible types that match the bounds (if any). The > language is sound if it does not "prefer" just one of them. Pardom my ignorance. I'm no expert in type systems, but if the type is defined as a set containing members (possible values) then a type-variable is a "disjunction" of all possible types that match is't bounds (not "conjunction"). Correct me if I'm wrong. Peter From david.lloyd at redhat.com Fri Oct 7 14:03:39 2011 From: david.lloyd at redhat.com (David M. Lloyd) Date: Fri, 07 Oct 2011 16:03:39 -0500 Subject: Acces to private field from nested class when the type of reference is a generic type variable with upper bound of outer class In-Reply-To: <201110072245.38427.peter.levart@gmail.com> References: <201110072129.38451.peter.levart@gmail.com> <4E8F567F.8070100@oracle.com> <4E8F5D56.4040308@redhat.com> <201110072245.38427.peter.levart@gmail.com> Message-ID: <4E8F692B.3000803@redhat.com> On 10/07/2011 03:45 PM, Peter Levart wrote: > On Friday, October 07, 2011 10:13:10 PM David M. Lloyd wrote: >> But the field _would_ be accessible according to JLS ?6.6.1 regardless >> of whether the object was of a subtype. It seems pretty clear to me, >> but maybe I'm just being dense? > > It's not the type of object that matters, but the type of variable. > > For example: > > public class A { > private int x = 1; > > void m() { > B b = new B(); > System.out.println(b.x); // no go > A a = b; > System.out.println(a.x); // prints 1 > } > } > > public class B extends A { > private int x = 2; > } > > > ... you see, the same object, but different types of variables A vs. B! > > The same goes for types that are expressed as type-variables. They are a conjunction of all > possible types that match the bounds (if any). The language is sound if it does not "prefer" > just one of them. I see, so you'd have to add in the cast like this: package test; public class Outer { private int outerField; public Outer(int outerField) { this.outerField = outerField; } public static class Inner { public int getOuterField(O outer) { return ((Outer)outer).outerField; // <- RIGHT HERE } } public static void main(String[] args) { Outer outer = new Outer(12); Inner inner = new Inner(); System.out.println(inner.getOuterField(outer)); } } I suppose that makes sense, though it rankles a bit since a widening cast is a pretty unusual thing to have to do in Java. -- - DML From maurizio.cimadamore at oracle.com Fri Oct 7 14:15:13 2011 From: maurizio.cimadamore at oracle.com (maurizio cimadamore) Date: Fri, 07 Oct 2011 22:15:13 +0100 Subject: Acces to private field from nested class when the type of reference is a generic type variable with upper bound of outer class In-Reply-To: <201110072257.12555.peter.levart@gmail.com> References: <201110072129.38451.peter.levart@gmail.com> <4E8F5D56.4040308@redhat.com> <201110072245.38427.peter.levart@gmail.com> <201110072257.12555.peter.levart@gmail.com> Message-ID: <4E8F6BE1.4010001@oracle.com> On 07/10/2011 21:57, Peter Levart wrote: > On Friday, October 07, 2011 10:45:38 PM Peter Levart wrote: >> The same goes for types that are expressed as type-variables. They are a >> conjunction of all possible types that match the bounds (if any). The >> language is sound if it does not "prefer" just one of them. > Pardom my ignorance. I'm no expert in type systems, but if the type is defined as a set > containing members (possible values) then a type-variable is a "disjunction" of all possible > types that match is't bounds (not "conjunction"). An intersection type A1, A2 ... An is defined as the most general type that is a subtype of both A1, A2 ... An. Since it is a subtype of all its components, it follows it should contain the members of the 'union' of the components. However, since it's a subtype, private members in supertypes are not inherithed. Maurizio > Correct me if I'm wrong. > > Peter > From peter.levart at gmail.com Fri Oct 7 14:54:00 2011 From: peter.levart at gmail.com (Peter Levart) Date: Fri, 7 Oct 2011 23:54:00 +0200 Subject: Acces to private field from nested class when the type of reference is a generic type variable with upper bound of outer class In-Reply-To: <4E8F6BE1.4010001@oracle.com> References: <201110072129.38451.peter.levart@gmail.com> <201110072257.12555.peter.levart@gmail.com> <4E8F6BE1.4010001@oracle.com> Message-ID: <201110072354.00747.peter.levart@gmail.com> On Friday, October 07, 2011 11:15:13 PM maurizio cimadamore wrote: > An intersection type A1, A2 ... An is defined as the most general type > that is a subtype of both A1, A2 ... An. > Since it is a subtype of all its components, it follows it should > contain the members of the 'union' of the components. However, since > it's a subtype, private members in supertypes are not inherithed. > > Maurizio Quite true. And that's understandable for private field access. And now for some puzzlers. Let's take that definition and a look at the following program: package test; public class Test { public static class A { public int field = 1; } public static class B extends A { public int field = 2; } public static class FieldGetter { public int getField(T obj) { return obj.field; } } public static void main(String[] args) { A a = new A(); B b = new B(); FieldGetter aFieldGetter = new FieldGetter(); FieldGetter bFieldGetter = new FieldGetter(); System.out.println(a.field); // 1 System.out.println(b.field); // 2 System.out.println(aFieldGetter.getField(a)); // 1 System.out.println(aFieldGetter.getField(b)); // 1 System.out.println(bFieldGetter.getField(b)); // 1 !!! } } ... in FieldGetter the T is the most general type that is a subtype of A and any subtypes of A (which includes B). Now A.field is inherited by any subtypes of A, but it can also be hidden by fields of the same name in any of the subtypes of A (as is in the example by B.field). The question is: How can compiler decide which field to access in T.getField method? Would it be right to disallow "any" field access via the type-variable typed variables? The joys of erasure! Peter From daniel.smith at oracle.com Fri Oct 7 15:22:20 2011 From: daniel.smith at oracle.com (Dan Smith) Date: Fri, 7 Oct 2011 15:22:20 -0700 Subject: Acces to private field from nested class when the type of reference is a generic type variable with upper bound of outer class In-Reply-To: <4E8F59A5.4010009@redhat.com> References: <201110072129.38451.peter.levart@gmail.com> <4E8F59A5.4010009@redhat.com> Message-ID: On Oct 7, 2011, at 12:57 PM, David M. Lloyd wrote: > On 10/07/2011 02:29 PM, Peter Levart wrote: >> This code compiles with latest JDK 6 javac: >> >> package test; >> >> public class Outer >> { >> private int outerField; >> >> public Outer(int outerField) >> { >> this.outerField = outerField; >> } >> >> public static class Inner >> { >> public int getOuterField(O outer) >> { >> return outer.outerField; >> } >> } >> >> public static void main(String[] args) >> { >> Outer outer = new Outer(12); >> Inner inner = new Inner(); >> System.out.println(inner.getOuterField(outer)); >> } >> } >> >> >> ... but refuses to compile with JDK 7 javac (release or latest 7u2-b08 prerelease), giving the >> following compilation failure: >> >> src/test/Outer.java:16: error: outerField has private access in Outer >> return outer.outerField; >> ^ >> >> even if tried with -source 1.6 -target 1.6 options. >> >> Is this intentional or a bug? > > I'd say it's a bug, according to JLS ?6.6.1 access to a private member is "permitted if and only if it occurs within the body of the top level class (?7.6) that encloses the declaration of the member or constructor." Looks to me like the access on line 16 occurs within the body of the top-level class (Outer) that encloses the declaration. Yes, the field is accessible, per 6.6.1. But this is irrelevant, because it's not a member of the type O at all! See 4.4, 4.9, and 6.5.6.2. The same problem would come up if O were a class rather than a type variable: public static class Inner { public static class O extends Outer {} public int getOuterField(O outer) { return outer.outerField; } } ?Dan From daniel.smith at oracle.com Fri Oct 7 15:37:48 2011 From: daniel.smith at oracle.com (Dan Smith) Date: Fri, 7 Oct 2011 15:37:48 -0700 Subject: Acces to private field from nested class when the type of reference is a generic type variable with upper bound of outer class In-Reply-To: <201110072354.00747.peter.levart@gmail.com> References: <201110072129.38451.peter.levart@gmail.com> <201110072257.12555.peter.levart@gmail.com> <4E8F6BE1.4010001@oracle.com> <201110072354.00747.peter.levart@gmail.com> Message-ID: On Oct 7, 2011, at 2:54 PM, Peter Levart wrote: > And now for some puzzlers. Let's take that definition and a look at the following program: > > > package test; > > public class Test > { > public static class A > { > public int field = 1; > } > > public static class B extends A > { > public int field = 2; > } > > public static class FieldGetter > { > public int getField(T obj) > { > return obj.field; > } > } > > public static void main(String[] args) > { > A a = new A(); > B b = new B(); > > FieldGetter aFieldGetter = new FieldGetter(); > FieldGetter bFieldGetter = new FieldGetter(); > > System.out.println(a.field); // 1 > System.out.println(b.field); // 2 > > System.out.println(aFieldGetter.getField(a)); // 1 > System.out.println(aFieldGetter.getField(b)); // 1 > > System.out.println(bFieldGetter.getField(b)); // 1 !!! > } > } > > > ... in FieldGetter the T is the most general type that is a subtype of A and any subtypes of A > (which includes B). Now A.field is inherited by any subtypes of A, but it can also be hidden by > fields of the same name in any of the subtypes of A (as is in the example by B.field). > > The question is: How can compiler decide which field to access in T.getField method? > > Would it be right to disallow "any" field access via the type-variable typed variables? > > The joys of erasure! This isn't a consequence of erasure. It's a consequence of static field resolution (in contrast to dynamic resolution of methods). The class referenced by a field name is determined at compile time. Wouldn't matter if T were reified -- we'd still have to pick a field at compile time, and the only sound choice would be 'A.field'. The fact that T is a type variable is, in a sense, irrelevant. Given class T extends A and class B extends T, the same problem arises -- when the receiver is "really" a B (at runtime), a user might wish that a reference to 'field' in type T resolve to 'B.field', but that's not the way field references work. ?Dan From peter.levart at gmail.com Sat Oct 8 03:25:02 2011 From: peter.levart at gmail.com (Peter Levart) Date: Sat, 8 Oct 2011 12:25:02 +0200 Subject: Acces to private field from nested class when the type of reference is a generic type variable with upper bound of outer class In-Reply-To: References: <201110072129.38451.peter.levart@gmail.com> <201110072354.00747.peter.levart@gmail.com> Message-ID: <201110081225.02914.peter.levart@gmail.com> On Saturday, October 08, 2011 12:37:48 AM Dan Smith wrote: > On Oct 7, 2011, at 2:54 PM, Peter Levart wrote: > > And now for some puzzlers. Let's take that definition and a look at the > > following program: > > > > > > package test; > > > > public class Test > > { > > > > public static class A > > { > > > > public int field = 1; > > > > } > > > > public static class B extends A > > { > > > > public int field = 2; > > > > } > > > > public static class FieldGetter > > { > > > > public int getField(T obj) > > { > > > > return obj.field; > > > > } > > > > } > > > > public static void main(String[] args) > > { > > > > A a = new A(); > > B b = new B(); > > > > FieldGetter aFieldGetter = new FieldGetter(); > > FieldGetter bFieldGetter = new FieldGetter(); > > > > System.out.println(a.field); // 1 > > System.out.println(b.field); // 2 > > > > System.out.println(aFieldGetter.getField(a)); // 1 > > System.out.println(aFieldGetter.getField(b)); // 1 > > > > System.out.println(bFieldGetter.getField(b)); // 1 !!! > > > > } > > > > } > > > > > > ... in FieldGetter the T is the most general type that is a subtype of A > > and any subtypes of A (which includes B). Now A.field is inherited by > > any subtypes of A, but it can also be hidden by fields of the same name > > in any of the subtypes of A (as is in the example by B.field). > > > > The question is: How can compiler decide which field to access in > > T.getField method? > > > > Would it be right to disallow "any" field access via the type-variable > > typed variables? > > > > The joys of erasure! > > This isn't a consequence of erasure. It's a consequence of static field > resolution (in contrast to dynamic resolution of methods). The class > referenced by a field name is determined at compile time. Wouldn't matter > if T were reified -- we'd still have to pick a field at compile time, and > the only sound choice would be 'A.field'. Ok I understand that now. To resolve this, field access would have to be dynamic at runtime (similar to virtual methods dispatch) and that is not an option for Java. > > The fact that T is a type variable is, in a sense, irrelevant. Given class > T extends A and class B extends T, the same problem arises -- when the > receiver is "really" a B (at runtime), a user might wish that a reference > to 'field' in type T resolve to 'B.field', but that's not the way field > references work. Ok, that's clear now too. I misinterpreted the type-variables. Now that I have read the chapters 4.4 and 4.9 in JLS once more, I see that type-variable in our situation has the following analogue situation without using type variables: public class A { public int field; } public class T extends A {} public class B extends A { public int field; } Therefore T.field resolves to A.field. And using this analogue (and knowing that by definition T is in the same package as A) it's now more clear which fields are accessible and which not via type-variable typed variables. Thanks, Peter > > ?Dan From chris.hegarty at oracle.com Mon Oct 10 03:04:11 2011 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Mon, 10 Oct 2011 10:04:11 +0000 Subject: hg: jdk8/tl/jdk: 7098719: -Dsun.net.maxDatagramSockets and Socket constructor does not work correctly with System.gc() Message-ID: <20111010100435.6866047E2C@hg.openjdk.java.net> Changeset: 1e89a13d9d8f Author: chegar Date: 2011-10-10 10:38 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1e89a13d9d8f 7098719: -Dsun.net.maxDatagramSockets and Socket constructor does not work correctly with System.gc() Reviewed-by: michaelm ! src/share/classes/java/net/AbstractPlainSocketImpl.java ! src/windows/classes/java/net/TwoStacksPlainDatagramSocketImpl.java ! src/windows/classes/java/net/TwoStacksPlainSocketImpl.java From chris.hegarty at oracle.com Mon Oct 10 07:30:27 2011 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Mon, 10 Oct 2011 14:30:27 +0000 Subject: hg: jdk8/tl/jdk: 7098755: test/sun/misc/JarIndex/metaInfFilenames/Basic.java should use supported compiler interface Message-ID: <20111010143049.3EF0047E51@hg.openjdk.java.net> Changeset: 2a36b8741363 Author: chegar Date: 2011-10-10 15:29 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2a36b8741363 7098755: test/sun/misc/JarIndex/metaInfFilenames/Basic.java should use supported compiler interface Reviewed-by: mcimadamore ! test/sun/misc/JarIndex/metaInfFilenames/Basic.java From neil.richards at ngmr.net Mon Oct 10 08:21:32 2011 From: neil.richards at ngmr.net (neil.richards at ngmr.net) Date: Mon, 10 Oct 2011 15:21:32 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20111010152152.97C3B47E5A@hg.openjdk.java.net> Changeset: dd55467dd1f2 Author: ngmr Date: 2011-10-10 14:50 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dd55467dd1f2 7099119: Remove unused dlinfo local variable in launcher code Reviewed-by: ohair, chegar, ngmr Contributed-by: Steve Poole ! src/solaris/bin/java_md.c Changeset: 5f336e0d4d97 Author: ngmr Date: 2011-10-10 16:13 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5f336e0d4d97 Merge From Dmitry.Degrave at oracle.com Tue Oct 11 03:38:54 2011 From: Dmitry.Degrave at oracle.com (Dmeetry Degrave) Date: Tue, 11 Oct 2011 14:38:54 +0400 Subject: Code review request: 7086586 Inference producing null type argument In-Reply-To: <4E8DB289.5040303@univ-mlv.fr> References: <4E8D7728.3000007@oracle.com> <4E8D7918.20407@oracle.com> <4E8DA052.5080501@oracle.com> <4E8DAFDE.9060200@oracle.com> <4E8DB289.5040303@univ-mlv.fr> Message-ID: <4E941CBE.6080107@oracle.com> On 10/06/2011 05:52 PM, R?mi Forax wrote: > On 10/06/2011 03:40 PM, Dmeetry Degrave wrote: >> On 10/06/2011 04:01 PM, R?mi Forax wrote: >>> Anyway, this code will be transformed into a lambda at the start of >>> JDK9 timeframe :) >> >> R?mi, >> >> just a clarification. This fix is only for jdk7 updates and won't be >> propagated further. >> >> It has been fixed differently in jdk 8: >> >> http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c0835c8489b0 >> >> thanks, >> dmeetry >> > > Ok, good to know. > final is in that case enough. > > regards, > R?mi this is corrected webrev with final, looking for a final approve for jdk7u. http://cr.openjdk.java.net/~dmeetry/7086586/webrev.01/ thanks, dmeetry From maurizio.cimadamore at oracle.com Tue Oct 11 04:14:01 2011 From: maurizio.cimadamore at oracle.com (Maurizio Cimadamore) Date: Tue, 11 Oct 2011 12:14:01 +0100 Subject: Code review request: 7086586 Inference producing null type argument In-Reply-To: <4E941CBE.6080107@oracle.com> References: <4E8D7728.3000007@oracle.com> <4E8D7918.20407@oracle.com> <4E8DA052.5080501@oracle.com> <4E8DAFDE.9060200@oracle.com> <4E8DB289.5040303@univ-mlv.fr> <4E941CBE.6080107@oracle.com> Message-ID: <4E9424F9.2040503@oracle.com> Approved Maurizio On 11/10/11 11:38, Dmeetry Degrave wrote: > On 10/06/2011 05:52 PM, R?mi Forax wrote: >> On 10/06/2011 03:40 PM, Dmeetry Degrave wrote: >>> On 10/06/2011 04:01 PM, R?mi Forax wrote: >>>> Anyway, this code will be transformed into a lambda at the start of >>>> JDK9 timeframe :) >>> >>> R?mi, >>> >>> just a clarification. This fix is only for jdk7 updates and won't be >>> propagated further. >>> >>> It has been fixed differently in jdk 8: >>> >>> http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c0835c8489b0 >>> >>> thanks, >>> dmeetry >>> >> >> Ok, good to know. >> final is in that case enough. >> >> regards, >> R?mi > > this is corrected webrev with final, looking for a final approve for > jdk7u. > > http://cr.openjdk.java.net/~dmeetry/7086586/webrev.01/ > > thanks, > dmeetry From chris.hegarty at oracle.com Tue Oct 11 06:34:35 2011 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Tue, 11 Oct 2011 13:34:35 +0000 Subject: hg: jdk8/tl/jdk: 7099488: TwoStacksPlainSocketImpl should invoke super.create(stream), typo in fix for 7098719 Message-ID: <20111011133453.E7ECA47F0C@hg.openjdk.java.net> Changeset: 5bfe2de1157b Author: chegar Date: 2011-10-11 12:06 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5bfe2de1157b 7099488: TwoStacksPlainSocketImpl should invoke super.create(stream), typo in fix for 7098719 Reviewed-by: coffeys ! src/share/classes/java/net/AbstractPlainSocketImpl.java ! src/windows/classes/java/net/TwoStacksPlainSocketImpl.java From xuelei.fan at oracle.com Wed Oct 12 02:11:48 2011 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Wed, 12 Oct 2011 09:11:48 +0000 Subject: hg: jdk8/tl/jdk: 7092375: Security Libraries don't build with javac -Werror Message-ID: <20111012091207.D105347F6C@hg.openjdk.java.net> Changeset: ffa762153af4 Author: xuelei Date: 2011-09-28 15:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ffa762153af4 7092375: Security Libraries don't build with javac -Werror Summary: Changes to security related java and make files to remove warnings Reviewed-by: xuelei Contributed-by: kurchi.subhra.hazra at oracle.com ! make/java/security/Makefile ! make/javax/Makefile ! make/javax/others/Makefile + make/javax/security/Makefile ! make/org/ietf/jgss/Makefile ! make/sun/security/other/Makefile ! src/share/classes/java/security/Signature.java ! src/share/classes/javax/security/auth/PrivateCredentialPermission.java ! src/share/classes/javax/security/auth/Subject.java ! src/share/classes/javax/security/auth/SubjectDomainCombiner.java ! src/share/classes/javax/security/auth/kerberos/DelegationPermission.java ! src/share/classes/javax/security/auth/kerberos/ServicePermission.java ! src/share/classes/javax/security/auth/login/LoginContext.java ! src/share/classes/javax/security/auth/x500/X500Principal.java ! src/share/classes/javax/security/cert/CertificateEncodingException.java ! src/share/classes/javax/security/cert/CertificateException.java ! src/share/classes/javax/security/cert/CertificateExpiredException.java ! src/share/classes/javax/security/cert/CertificateNotYetValidException.java ! src/share/classes/javax/security/cert/CertificateParsingException.java ! src/share/classes/javax/security/cert/X509Certificate.java ! src/share/classes/javax/security/sasl/Sasl.java ! src/share/classes/javax/smartcardio/TerminalFactory.java ! src/share/classes/sun/security/ec/ECPublicKeyImpl.java ! src/share/classes/sun/security/validator/PKIXValidator.java ! src/share/classes/sun/security/validator/SimpleValidator.java ! src/share/classes/sun/security/x509/X509CertImpl.java From naoto.sato at oracle.com Wed Oct 12 12:13:38 2011 From: naoto.sato at oracle.com (naoto.sato at oracle.com) Date: Wed, 12 Oct 2011 19:13:38 +0000 Subject: hg: jdk8/tl/jdk: 7027061: Testcase failure: java/util/Locale/Bug6989440.java - java.util.ConcurrentModificationException Message-ID: <20111012191400.22A9A47FAA@hg.openjdk.java.net> Changeset: 829c3a8d23fa Author: naoto Date: 2011-10-12 12:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/829c3a8d23fa 7027061: Testcase failure: java/util/Locale/Bug6989440.java - java.util.ConcurrentModificationException Reviewed-by: dholmes, chegar ! src/share/classes/sun/util/LocaleServiceProviderPool.java ! test/java/util/Locale/Bug6989440.java From vincent.x.ryan at oracle.com Thu Oct 13 07:58:51 2011 From: vincent.x.ryan at oracle.com (vincent.x.ryan at oracle.com) Date: Thu, 13 Oct 2011 14:58:51 +0000 Subject: hg: jdk8/tl/jdk: 7099228: Use a PKCS11 config attribute to control encoding of an EC point Message-ID: <20111013145917.0FB9A47FDE@hg.openjdk.java.net> Changeset: 2b27e14a4c82 Author: vinnie Date: 2011-10-13 12:00 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2b27e14a4c82 7099228: Use a PKCS11 config attribute to control encoding of an EC point Reviewed-by: valeriep, mullan ! src/share/classes/sun/security/pkcs11/Config.java ! src/share/classes/sun/security/pkcs11/P11ECKeyFactory.java ! src/share/classes/sun/security/pkcs11/P11Key.java ! src/share/lib/security/sunpkcs11-solaris.cfg ! test/ProblemList.txt From sean.mullan at oracle.com Thu Oct 13 11:14:19 2011 From: sean.mullan at oracle.com (sean.mullan at oracle.com) Date: Thu, 13 Oct 2011 18:14:19 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20111013181458.B1A5147FE2@hg.openjdk.java.net> Changeset: 01615d3e74ed Author: mullan Date: 2011-10-13 13:50 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/01615d3e74ed 6953295: Move few sun.security.{util, x509, pkcs} classes used by keytool/jarsigner to another package Reviewed-by: mchung ! make/sun/security/other/Makefile - src/share/classes/sun/security/pkcs/EncodingException.java - src/share/classes/sun/security/pkcs/PKCS10.java - src/share/classes/sun/security/pkcs/PKCS10Attribute.java - src/share/classes/sun/security/pkcs/PKCS10Attributes.java + src/share/classes/sun/security/pkcs10/PKCS10.java + src/share/classes/sun/security/pkcs10/PKCS10Attribute.java + src/share/classes/sun/security/pkcs10/PKCS10Attributes.java ! src/share/classes/sun/security/provider/certpath/CertStoreHelper.java ! src/share/classes/sun/security/provider/certpath/URICertStore.java ! src/share/classes/sun/security/provider/certpath/ldap/LDAPCertStore.java ! src/share/classes/sun/security/provider/certpath/ldap/LDAPCertStoreHelper.java + src/share/classes/sun/security/provider/certpath/ssl/SSLServerCertStore.java + src/share/classes/sun/security/provider/certpath/ssl/SSLServerCertStoreHelper.java + src/share/classes/sun/security/tools/CertAndKeyGen.java ! src/share/classes/sun/security/tools/KeyTool.java + src/share/classes/sun/security/tools/PathList.java - src/share/classes/sun/security/util/BigInt.java - src/share/classes/sun/security/util/PathList.java - src/share/classes/sun/security/x509/CertAndKeyGen.java - test/sun/security/util/BigInt/BigIntEqualsHashCode.java Changeset: 04ecbd2bcf5a Author: mullan Date: 2011-10-13 13:53 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/04ecbd2bcf5a Merge From weijun.wang at oracle.com Mon Oct 17 02:12:16 2011 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Mon, 17 Oct 2011 09:12:16 +0000 Subject: hg: jdk8/tl/jdk: 7099399: cannot deal with CRL file larger than 16MB Message-ID: <20111017091244.41C8347017@hg.openjdk.java.net> Changeset: 6cb07b35acf5 Author: weijun Date: 2011-10-17 17:11 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6cb07b35acf5 7099399: cannot deal with CRL file larger than 16MB Reviewed-by: xuelei, mullan ! src/share/classes/sun/security/provider/X509Factory.java + test/sun/security/provider/X509Factory/BigCRL.java From maurizio.cimadamore at oracle.com Mon Oct 17 04:59:44 2011 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Mon, 17 Oct 2011 11:59:44 +0000 Subject: hg: jdk8/tl/langtools: 2 new changesets Message-ID: <20111017115950.696AA4701E@hg.openjdk.java.net> Changeset: b5d0b8effc85 Author: mcimadamore Date: 2011-10-17 12:54 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b5d0b8effc85 7097436: Project Coin: duplicate varargs warnings on method annotated with @SafeVarargs Summary: Duplicate aliasing check during subtyping leads to spurious varargs diagnostic Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Types.java + test/tools/javac/varargs/7097436/T7097436.java + test/tools/javac/varargs/7097436/T7097436.out ! test/tools/javac/varargs/warning/Warn5.java Changeset: 3cdfa97e1be9 Author: mcimadamore Date: 2011-10-17 12:57 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3cdfa97e1be9 7093325: Redundant entry in bytecode exception table Summary: Inlining of finalizers does not update gaps list accordingly Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java + test/tools/javac/T7093325.java From sean.mullan at oracle.com Tue Oct 18 07:35:48 2011 From: sean.mullan at oracle.com (sean.mullan at oracle.com) Date: Tue, 18 Oct 2011 14:35:48 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20111018143617.B1F554703C@hg.openjdk.java.net> Changeset: 9bf526cc4046 Author: mullan Date: 2011-10-18 10:12 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9bf526cc4046 7092897: sun.security.util.Cache should be generified Reviewed-by: xuelei ! src/share/classes/sun/security/pkcs11/KeyCache.java ! src/share/classes/sun/security/provider/X509Factory.java ! src/share/classes/sun/security/provider/certpath/CertStoreHelper.java ! src/share/classes/sun/security/provider/certpath/URICertStore.java ! src/share/classes/sun/security/provider/certpath/X509CertificatePair.java ! src/share/classes/sun/security/provider/certpath/ldap/LDAPCertStore.java ! src/share/classes/sun/security/ssl/SSLSessionContextImpl.java ! src/share/classes/sun/security/util/Cache.java Changeset: f566cd364a90 Author: mullan Date: 2011-10-18 10:15 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f566cd364a90 Merge ! src/share/classes/sun/security/provider/X509Factory.java From bradford.wetmore at oracle.com Tue Oct 18 12:03:49 2011 From: bradford.wetmore at oracle.com (bradford.wetmore at oracle.com) Date: Tue, 18 Oct 2011 19:03:49 +0000 Subject: hg: jdk8/tl/jdk: 7031830: bad_record_mac failure on TLSv1.2 enabled connection with SSLEngine Message-ID: <20111018190407.093524703E@hg.openjdk.java.net> Changeset: 8640b7185be1 Author: wetmore Date: 2011-10-18 11:58 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8640b7185be1 7031830: bad_record_mac failure on TLSv1.2 enabled connection with SSLEngine Reviewed-by: xuelei, weijun, asaha ! src/share/classes/sun/security/ssl/CipherBox.java + test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLEngineImpl/SSLEngineBadBufferArrayAccess.java From sean.mullan at oracle.com Wed Oct 19 07:29:53 2011 From: sean.mullan at oracle.com (sean.mullan at oracle.com) Date: Wed, 19 Oct 2011 14:29:53 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20111019143023.0F3A94707E@hg.openjdk.java.net> Changeset: 57eb9136b73b Author: mullan Date: 2011-10-19 10:15 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/57eb9136b73b 7102686: Restructure timestamp code so that jars and modules can more easily share the same code Reviewed-by: mchung ! src/share/classes/sun/security/pkcs/PKCS7.java ! src/share/classes/sun/security/pkcs/SignerInfo.java ! src/share/classes/sun/security/timestamp/HttpTimestamper.java ! src/share/classes/sun/security/timestamp/TSRequest.java ! src/share/classes/sun/security/timestamp/TSResponse.java ! src/share/classes/sun/security/tools/JarSigner.java ! src/share/classes/sun/security/tools/TimestampedSigner.java ! src/share/classes/sun/security/util/Debug.java ! src/share/classes/sun/security/util/SignatureFileVerifier.java Changeset: 15078025eed9 Author: mullan Date: 2011-10-19 10:16 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/15078025eed9 Merge From maurizio.cimadamore at oracle.com Wed Oct 19 08:57:10 2011 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Wed, 19 Oct 2011 15:57:10 +0000 Subject: hg: jdk8/tl/langtools: 7102515: javac running very very long and not returning Message-ID: <20111019155714.7885247085@hg.openjdk.java.net> Changeset: 366c233eb838 Author: mcimadamore Date: 2011-10-19 16:56 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/366c233eb838 7102515: javac running very very long and not returning Summary: Verbose resolution diagnostics slow down with operator resolution Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Resolve.java + test/tools/javac/7102515/T7102515.java + test/tools/javac/7102515/T7102515.out From mike.duigou at oracle.com Wed Oct 19 15:23:44 2011 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Wed, 19 Oct 2011 22:23:44 +0000 Subject: hg: jdk8/tl/jdk: 5029031: Add Collections.checkedQueue() Message-ID: <20111019222354.E00AF47099@hg.openjdk.java.net> Changeset: c5c91589b126 Author: mduigou Date: 2011-10-19 14:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c5c91589b126 5029031: Add Collections.checkedQueue() Reviewed-by: mduigou Contributed-by: darryl.mocek at oracle.com ! src/share/classes/java/util/Collections.java + test/java/util/Collections/CheckedQueue.java From jonathan.gibbons at oracle.com Wed Oct 19 15:30:02 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Wed, 19 Oct 2011 22:30:02 +0000 Subject: hg: jdk8/tl/langtools: 7101146: Paths should more directly managed by BaseFileManager Message-ID: <20111019223004.5AD124709A@hg.openjdk.java.net> Changeset: d2cbb77469ed Author: jjg Date: 2011-10-19 15:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d2cbb77469ed 7101146: Paths should more directly managed by BaseFileManager Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/file/JavacFileManager.java ! src/share/classes/com/sun/tools/javac/file/Paths.java ! src/share/classes/com/sun/tools/javac/nio/JavacPathFileManager.java ! src/share/classes/com/sun/tools/javac/util/BaseFileManager.java From chris.hegarty at oracle.com Thu Oct 20 01:09:09 2011 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Thu, 20 Oct 2011 08:09:09 +0000 Subject: hg: jdk8/tl/jdk: 7102704: test/java/net/DatagramSocket/ChangingAddress.java failing Message-ID: <20111020080928.DE1124709B@hg.openjdk.java.net> Changeset: 634cd6f050ba Author: chegar Date: 2011-10-20 09:08 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/634cd6f050ba 7102704: test/java/net/DatagramSocket/ChangingAddress.java failing Reviewed-by: chegar Contributed-by: kurchi.subhra.hazra at oracle.com - test/java/net/DatagramSocket/ChangingAddress.java From michael.x.mcmahon at oracle.com Thu Oct 20 01:27:19 2011 From: michael.x.mcmahon at oracle.com (michael.x.mcmahon at oracle.com) Date: Thu, 20 Oct 2011 08:27:19 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20111020082739.7BD904709D@hg.openjdk.java.net> Changeset: 2d89c3f74aa5 Author: michaelm Date: 2011-10-20 09:21 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2d89c3f74aa5 7102665: Move tests to Problemlist Reviewed-by: chegar, alanb ! test/ProblemList.txt Changeset: 52c2dd336207 Author: michaelm Date: 2011-10-20 09:26 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/52c2dd336207 Merge - test/java/net/DatagramSocket/ChangingAddress.java From neil.richards at ngmr.net Thu Oct 20 06:56:22 2011 From: neil.richards at ngmr.net (neil.richards at ngmr.net) Date: Thu, 20 Oct 2011 13:56:22 +0000 Subject: hg: jdk8/tl/jdk: 7100054: (porting) Native code should include fcntl.h and unistd.h rather than sys/fcntl.h and sys/unistd.h Message-ID: <20111020135641.19E52470A4@hg.openjdk.java.net> Changeset: c3da0672a882 Author: ngmr Date: 2011-10-13 12:30 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c3da0672a882 7100054: (porting) Native code should include fcntl.h and unistd.h rather than sys/fcntl.h and sys/unistd.h Summary: Use POSIX defined includes for unistd.h and fcntl.h Reviewed-by: dholmes, alanb, chegar, ngmr Contributed-by: Charles Lee ! src/solaris/native/sun/nio/fs/genSolarisConstants.c ! src/solaris/native/sun/nio/fs/genUnixConstants.c From yuka.kamiya at oracle.com Thu Oct 20 23:58:42 2011 From: yuka.kamiya at oracle.com (yuka.kamiya at oracle.com) Date: Fri, 21 Oct 2011 06:58:42 +0000 Subject: hg: jdk8/tl/jdk: 7103108: (tz) Support tzdata2011l Message-ID: <20111021065900.1404D470BC@hg.openjdk.java.net> Changeset: d979afceb792 Author: peytoia Date: 2011-10-21 15:56 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d979afceb792 7103108: (tz) Support tzdata2011l Reviewed-by: okutsu ! make/sun/javazic/tzdata/VERSION ! make/sun/javazic/tzdata/asia ! make/sun/javazic/tzdata/australasia ! make/sun/javazic/tzdata/europe ! make/sun/javazic/tzdata/northamerica ! make/sun/javazic/tzdata/southamerica ! make/sun/javazic/tzdata/zone.tab ! src/share/classes/sun/util/resources/TimeZoneNames.java ! src/share/classes/sun/util/resources/TimeZoneNames_de.java ! src/share/classes/sun/util/resources/TimeZoneNames_es.java ! src/share/classes/sun/util/resources/TimeZoneNames_fr.java ! src/share/classes/sun/util/resources/TimeZoneNames_it.java ! src/share/classes/sun/util/resources/TimeZoneNames_ja.java ! src/share/classes/sun/util/resources/TimeZoneNames_ko.java ! src/share/classes/sun/util/resources/TimeZoneNames_pt_BR.java ! src/share/classes/sun/util/resources/TimeZoneNames_sv.java ! src/share/classes/sun/util/resources/TimeZoneNames_zh_CN.java ! src/share/classes/sun/util/resources/TimeZoneNames_zh_TW.java From yuka.kamiya at oracle.com Fri Oct 21 02:03:07 2011 From: yuka.kamiya at oracle.com (yuka.kamiya at oracle.com) Date: Fri, 21 Oct 2011 09:03:07 +0000 Subject: hg: jdk8/tl/jdk: 7103405: Correct display names for Pacific/Apia timezone Message-ID: <20111021090324.B86FD470BE@hg.openjdk.java.net> Changeset: db9e246c651e Author: peytoia Date: 2011-10-21 18:01 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/db9e246c651e 7103405: Correct display names for Pacific/Apia timezone Reviewed-by: okutsu ! src/share/classes/sun/util/resources/TimeZoneNames.java ! src/share/classes/sun/util/resources/TimeZoneNames_de.java ! src/share/classes/sun/util/resources/TimeZoneNames_es.java ! src/share/classes/sun/util/resources/TimeZoneNames_fr.java ! src/share/classes/sun/util/resources/TimeZoneNames_it.java ! src/share/classes/sun/util/resources/TimeZoneNames_ja.java ! src/share/classes/sun/util/resources/TimeZoneNames_ko.java ! src/share/classes/sun/util/resources/TimeZoneNames_pt_BR.java ! src/share/classes/sun/util/resources/TimeZoneNames_sv.java ! src/share/classes/sun/util/resources/TimeZoneNames_zh_CN.java ! src/share/classes/sun/util/resources/TimeZoneNames_zh_TW.java From jim.holmlund at sun.com Fri Oct 21 14:17:46 2011 From: jim.holmlund at sun.com (jim.holmlund at sun.com) Date: Fri, 21 Oct 2011 21:17:46 +0000 Subject: hg: jdk8/tl/langtools: 7098530: tools/javac/javazip/Test.sh can fail on Windows Message-ID: <20111021211751.BDCCB470CB@hg.openjdk.java.net> Changeset: b4021c520e40 Author: jjh Date: 2011-10-21 14:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b4021c520e40 7098530: tools/javac/javazip/Test.sh can fail on Windows Summary: Fix cygpath command to properly convert path Reviewed-by: jjg ! test/tools/javac/javazip/Test.sh From jonathan.gibbons at oracle.com Sun Oct 23 22:25:47 2011 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Sun, 23 Oct 2011 22:25:47 -0700 Subject: Proposed patch for review Message-ID: <4EA4F6DB.7040204@oracle.com> I've posted a patch from our newest contributor, Vicente Zaldivar. The patch is a cleanup to the JCTree.tag values, to use enums instead of small integers. You can see the patch here: http://cr.openjdk.java.net/~jjg/6921494/webrev.00/ Thanks to Vicente for the contribution. Review feedback here or to Vicente, please. -- Jon From maurizio.cimadamore at oracle.com Mon Oct 24 02:39:53 2011 From: maurizio.cimadamore at oracle.com (Maurizio Cimadamore) Date: Mon, 24 Oct 2011 10:39:53 +0100 Subject: Proposed patch for review In-Reply-To: <4EA4F6DB.7040204@oracle.com> References: <4EA4F6DB.7040204@oracle.com> Message-ID: <4EA53269.1030508@oracle.com> On 24/10/11 06:25, Jonathan Gibbons wrote: > I've posted a patch from our newest contributor, Vicente Zaldivar. > The patch is a cleanup to the JCTree.tag values, to use enums > instead of small integers. > > You can see the patch here: > http://cr.openjdk.java.net/~jjg/6921494/webrev.00/ > > Thanks to Vicente for the contribution. Review feedback here or > to Vicente, please. > > -- Jon Great work - couple of comments below: *) JCTree - I would add an import static as follows: import static com.sun.tools.javac.tree.JCTree.Tag.* This way you will get rid of all the qualified identifier (i.e. most of the code in JCTree should go back to its original form). The same applies to all files (I listed the files where there is at least more than a single qualified ident): -) Annotate.java -) Attr.java -) Check.java -) Flow.java -) Lower.java -) MemberEnter.java -) Resolve.java (a non-static import of JCTree.Tag would do fine) -) Gen.java -) JavacElements.java -) JavacParser.java -) Pretty.java -) TreeInfo.java -) TreeMaker.java (a non-static import of JCTree.Tag would do fine) -) ClassDocImpl.java Maurizio From maurizio.cimadamore at oracle.com Mon Oct 24 05:01:45 2011 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Mon, 24 Oct 2011 12:01:45 +0000 Subject: hg: jdk8/tl/langtools: 2 new changesets Message-ID: <20111024120150.23AE5470F5@hg.openjdk.java.net> Changeset: d346ab55031b Author: mcimadamore Date: 2011-10-24 13:00 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d346ab55031b 7096014: Javac tokens should retain state Summary: Refactor javac tokens from enum constants to stateful instances (to keep track of position, comments, etc.) Reviewed-by: jjg ! src/share/classes/com/sun/tools/apt/main/AptJavaCompiler.java - src/share/classes/com/sun/tools/javac/parser/DocCommentScanner.java ! src/share/classes/com/sun/tools/javac/parser/EndPosParser.java + src/share/classes/com/sun/tools/javac/parser/JavaTokenizer.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java + src/share/classes/com/sun/tools/javac/parser/JavadocTokenizer.java - src/share/classes/com/sun/tools/javac/parser/Keywords.java ! src/share/classes/com/sun/tools/javac/parser/Lexer.java ! src/share/classes/com/sun/tools/javac/parser/ParserFactory.java ! src/share/classes/com/sun/tools/javac/parser/Scanner.java ! src/share/classes/com/sun/tools/javac/parser/ScannerFactory.java - src/share/classes/com/sun/tools/javac/parser/Token.java + src/share/classes/com/sun/tools/javac/parser/Tokens.java + src/share/classes/com/sun/tools/javac/parser/UnicodeReader.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javadoc/JavadocTool.java ! test/tools/javac/api/TestJavacTaskScanner.java + test/tools/javac/depDocComment/DeprecatedDocComment3.java + test/tools/javac/tree/DocCommentToplevelTest.java Changeset: 05814303a056 Author: mcimadamore Date: 2011-10-24 13:00 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/05814303a056 7098660: Write better overload resolution/inference tests Summary: Add overload/inference debug diagnostics - added test harness using annotations to check outcome of overload resolution/inference Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Printer.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties + test/tools/javac/diags/examples/ApplicableMethodFound.java + test/tools/javac/diags/examples/ApplicableMethodFound1.java + test/tools/javac/diags/examples/DeferredMethodInst.java + test/tools/javac/diags/examples/FullInstSig.java + test/tools/javac/diags/examples/NotApplicableMethodFound.java + test/tools/javac/diags/examples/PartialInstSig.java + test/tools/javac/diags/examples/VerboseResolveMulti.java + test/tools/javac/diags/examples/VerboseResolveMulti1.java + test/tools/javac/resolve/Candidate.java + test/tools/javac/resolve/Pos.java + test/tools/javac/resolve/ResolveHarness.java + test/tools/javac/resolve/TraceResolve.java + test/tools/javac/resolve/tests/BoxedReturnTypeInference.java + test/tools/javac/resolve/tests/PrimitiveOverReferenceOverInferred.java + test/tools/javac/resolve/tests/PrimitiveOverReferenceOverVarargs.java + test/tools/javac/resolve/tests/PrimitiveOverReferenceVarargsAmbiguous.java + test/tools/javac/resolve/tests/PrimitiveOverload.java + test/tools/javac/resolve/tests/PrimitiveReturnTypeInference.java + test/tools/javac/resolve/tests/ReferenceOverInferred.java + test/tools/javac/resolve/tests/ReferenceOverVarargs.java + test/tools/javac/resolve/tests/ReferenceOverload.java From jonathan.gibbons at oracle.com Mon Oct 24 09:49:12 2011 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Mon, 24 Oct 2011 09:49:12 -0700 Subject: Proposed patch for review In-Reply-To: <4EA4F6DB.7040204@oracle.com> References: <4EA4F6DB.7040204@oracle.com> Message-ID: <4EA59708.8050202@oracle.com> My apologies to Vicente for abbreviating his name incorrectly. I should have said, Vicente Romero. -- Jon On 10/23/2011 10:25 PM, Jonathan Gibbons wrote: > I've posted a patch from our newest contributor, Vicente Zaldivar. > The patch is a cleanup to the JCTree.tag values, to use enums > instead of small integers. > > You can see the patch here: > http://cr.openjdk.java.net/~jjg/6921494/webrev.00/ > > Thanks to Vicente for the contribution. Review feedback here or > to Vicente, please. > > -- Jon From chris.hegarty at oracle.com Mon Oct 24 12:56:24 2011 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Mon, 24 Oct 2011 19:56:24 +0000 Subject: hg: jdk8/tl/jdk: 7104209: Cleanup and remove librmi (native library) Message-ID: <20111024195647.20EB547103@hg.openjdk.java.net> Changeset: 3f391e649ccb Author: chegar Date: 2011-10-24 20:55 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3f391e649ccb 7104209: Cleanup and remove librmi (native library) Reviewed-by: mduigou, alanb ! make/java/java/mapfile-vers ! make/sun/rmi/rmi/Makefile - make/sun/rmi/rmi/mapfile-vers ! src/share/classes/java/io/ObjectInputStream.java ! src/share/classes/sun/misc/VM.java ! src/share/classes/sun/rmi/server/MarshalInputStream.java ! src/share/native/java/io/ObjectInputStream.c ! src/share/native/sun/misc/VM.c - src/share/native/sun/rmi/server/MarshalInputStream.c From chris.hegarty at oracle.com Mon Oct 24 13:05:15 2011 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Mon, 24 Oct 2011 20:05:15 +0000 Subject: hg: jdk8/tl/jdk: 7103549: Remove dependencies on libjava and libjvm from security libraries Message-ID: <20111024200525.F3B6B47104@hg.openjdk.java.net> Changeset: b375523d6037 Author: chegar Date: 2011-10-24 21:03 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b375523d6037 7103549: Remove dependencies on libjava and libjvm from security libraries Reviewed-by: vinnie, ohair, alanb, dholmes ! make/com/sun/security/auth/module/Makefile ! make/common/Defs.gmk ! make/common/Library.gmk ! make/sun/security/ec/Makefile ! make/sun/security/jgss/wrapper/Makefile ! make/sun/security/krb5/Makefile ! make/sun/security/mscapi/Makefile ! make/sun/security/pkcs11/Makefile ! make/sun/security/smartcardio/Makefile ! src/share/native/sun/security/pkcs11/wrapper/p11_convert.c ! src/share/native/sun/security/pkcs11/wrapper/p11_digest.c ! src/share/native/sun/security/pkcs11/wrapper/p11_dual.c ! src/share/native/sun/security/pkcs11/wrapper/p11_general.c ! src/share/native/sun/security/pkcs11/wrapper/p11_keymgmt.c ! src/share/native/sun/security/pkcs11/wrapper/p11_mutex.c ! src/share/native/sun/security/pkcs11/wrapper/p11_objmgmt.c ! src/share/native/sun/security/pkcs11/wrapper/p11_sessmgmt.c ! src/share/native/sun/security/pkcs11/wrapper/p11_sign.c ! src/share/native/sun/security/pkcs11/wrapper/p11_util.c ! src/share/native/sun/security/pkcs11/wrapper/pkcs11wrapper.h ! src/solaris/native/sun/security/pkcs11/j2secmod_md.c ! src/solaris/native/sun/security/smartcardio/pcsc_md.c ! src/windows/native/sun/security/pkcs11/j2secmod_md.c From alan.bateman at oracle.com Tue Oct 25 01:28:38 2011 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Tue, 25 Oct 2011 08:28:38 +0000 Subject: hg: jdk8/tl/jdk: 7104577: Changes for 7104209 cause many RMI tests to fail Message-ID: <20111025082859.73ED547109@hg.openjdk.java.net> Changeset: 72666cd49ac3 Author: alanb Date: 2011-10-25 09:27 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/72666cd49ac3 7104577: Changes for 7104209 cause many RMI tests to fail Reviewed-by: chegar ! src/share/classes/sun/rmi/server/MarshalInputStream.java From maurizio.cimadamore at oracle.com Tue Oct 25 07:41:55 2011 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Tue, 25 Oct 2011 14:41:55 +0000 Subject: hg: jdk8/tl/langtools: 7104618: MessageInfo.java is failing after lexer changes Message-ID: <20111025144200.CE2C647112@hg.openjdk.java.net> Changeset: b73a9be0b993 Author: mcimadamore Date: 2011-10-25 15:40 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b73a9be0b993 7104618: MessageInfo.java is failing after lexer changes Summary: Two langtools regression tests cannot be built due to a bad import statement Reviewed-by: jjg ! test/tools/javac/diags/ArgTypeCompilerFactory.java From jonathan.gibbons at oracle.com Tue Oct 25 10:48:46 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 25 Oct 2011 17:48:46 +0000 Subject: hg: jdk8/tl/langtools: 7104039: refactor/cleanup javac Paths class Message-ID: <20111025174848.C198547115@hg.openjdk.java.net> Changeset: d830d28fc72e Author: jjg Date: 2011-10-25 10:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d830d28fc72e 7104039: refactor/cleanup javac Paths class Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/apt/main/Main.java ! src/share/classes/com/sun/tools/javac/file/JavacFileManager.java + src/share/classes/com/sun/tools/javac/file/Locations.java - src/share/classes/com/sun/tools/javac/file/Paths.java ! src/share/classes/com/sun/tools/javac/nio/JavacPathFileManager.java ! src/share/classes/com/sun/tools/javac/util/BaseFileManager.java ! src/share/classes/com/sun/tools/javadoc/DocletInvoker.java From jim.holmlund at sun.com Tue Oct 25 19:19:45 2011 From: jim.holmlund at sun.com (jim.holmlund at sun.com) Date: Wed, 26 Oct 2011 02:19:45 +0000 Subject: hg: jdk8/tl/langtools: 7104905: Java SE build fails on call to CreateSymbols Message-ID: <20111026021948.C5E5447123@hg.openjdk.java.net> Changeset: a1eaf78ababb Author: jjh Date: 2011-10-25 19:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a1eaf78ababb 7104905: Java SE build fails on call to CreateSymbols Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/file/Locations.java From chris.hegarty at oracle.com Wed Oct 26 05:59:30 2011 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Wed, 26 Oct 2011 12:59:30 +0000 Subject: hg: jdk8/tl/jdk: 7104650: rawtype warnings in several net, nio and security source files Message-ID: <20111026125941.92FCD47129@hg.openjdk.java.net> Changeset: 88a260444e4d Author: chegar Date: 2011-10-26 13:58 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/88a260444e4d 7104650: rawtype warnings in several net, nio and security source files Summary: Also reviewed by Ulf.Zibis at gmx.de Reviewed-by: mcimadamore, alanb, dholmes ! make/sun/net/Makefile ! src/share/classes/java/net/InetAddress.java ! src/share/classes/java/net/ServerSocket.java ! src/share/classes/java/nio/charset/Charset.java ! src/share/classes/java/security/Security.java ! src/share/classes/sun/nio/ch/Util.java From yuka.kamiya at oracle.com Wed Oct 26 06:18:19 2011 From: yuka.kamiya at oracle.com (yuka.kamiya at oracle.com) Date: Wed, 26 Oct 2011 13:18:19 +0000 Subject: hg: jdk8/tl/jdk: 7090046: Lots of invalid link in java.text.BreakIterator comments Message-ID: <20111026131829.155024712C@hg.openjdk.java.net> Changeset: 0d371f2911a1 Author: peytoia Date: 2011-10-26 22:16 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0d371f2911a1 7090046: Lots of invalid link in java.text.BreakIterator comments Reviewed-by: okutsu ! src/share/classes/java/text/BreakIterator.java From lana.steuck at oracle.com Wed Oct 26 12:52:54 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 26 Oct 2011 19:52:54 +0000 Subject: hg: jdk8/tl: 7 new changesets Message-ID: <20111026195254.8B64547139@hg.openjdk.java.net> Changeset: 0db7ae9f2b10 Author: katleman Date: 2011-09-22 16:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/0db7ae9f2b10 Added tag jdk8-b06 for changeset 28cf2aec4dd7 ! .hgtags Changeset: cf76aa4189e4 Author: katleman Date: 2011-09-29 18:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/cf76aa4189e4 Added tag jdk8-b07 for changeset 0db7ae9f2b10 ! .hgtags Changeset: 2f1af0e3e8f7 Author: lana Date: 2011-09-26 14:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/2f1af0e3e8f7 Merge Changeset: fb1bc13260d7 Author: lana Date: 2011-10-03 18:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/fb1bc13260d7 Merge Changeset: 8adb70647b5a Author: katleman Date: 2011-10-06 14:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/8adb70647b5a Added tag jdk8-b08 for changeset fb1bc13260d7 ! .hgtags Changeset: a6c4c248e8fa Author: katleman Date: 2011-10-13 10:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/a6c4c248e8fa Added tag jdk8-b09 for changeset 8adb70647b5a ! .hgtags Changeset: 1defbc57940a Author: katleman Date: 2011-10-20 10:32 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/1defbc57940a Added tag jdk8-b10 for changeset a6c4c248e8fa ! .hgtags From lana.steuck at oracle.com Wed Oct 26 12:52:57 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 26 Oct 2011 19:52:57 +0000 Subject: hg: jdk8/tl/jaxp: 5 new changesets Message-ID: <20111026195257.9C6754713A@hg.openjdk.java.net> Changeset: c114306576dc Author: katleman Date: 2011-09-22 16:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/c114306576dc Added tag jdk8-b06 for changeset d7b8192e7277 ! .hgtags Changeset: de4794dd69c4 Author: katleman Date: 2011-09-29 18:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/de4794dd69c4 Added tag jdk8-b07 for changeset c114306576dc ! .hgtags Changeset: 93554324c014 Author: katleman Date: 2011-10-06 14:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/93554324c014 Added tag jdk8-b08 for changeset de4794dd69c4 ! .hgtags Changeset: d21a4d5141c0 Author: katleman Date: 2011-10-13 10:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/d21a4d5141c0 Added tag jdk8-b09 for changeset 93554324c014 ! .hgtags Changeset: d1b7a4f6dd20 Author: katleman Date: 2011-10-20 10:32 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/d1b7a4f6dd20 Added tag jdk8-b10 for changeset d21a4d5141c0 ! .hgtags From lana.steuck at oracle.com Wed Oct 26 12:53:03 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 26 Oct 2011 19:53:03 +0000 Subject: hg: jdk8/tl/jaxws: 5 new changesets Message-ID: <20111026195303.DD0074713B@hg.openjdk.java.net> Changeset: 134b0debf7b0 Author: katleman Date: 2011-09-22 16:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/134b0debf7b0 Added tag jdk8-b06 for changeset acffff22a946 ! .hgtags Changeset: 1c9d4f59acf8 Author: katleman Date: 2011-09-29 18:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/1c9d4f59acf8 Added tag jdk8-b07 for changeset 134b0debf7b0 ! .hgtags Changeset: 70172e57cf29 Author: katleman Date: 2011-10-06 14:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/70172e57cf29 Added tag jdk8-b08 for changeset 1c9d4f59acf8 ! .hgtags Changeset: 8e7fdc8e3c75 Author: katleman Date: 2011-10-13 10:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/8e7fdc8e3c75 Added tag jdk8-b09 for changeset 70172e57cf29 ! .hgtags Changeset: a12ab897a249 Author: katleman Date: 2011-10-20 10:32 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/a12ab897a249 Added tag jdk8-b10 for changeset 8e7fdc8e3c75 ! .hgtags From lana.steuck at oracle.com Wed Oct 26 12:52:54 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 26 Oct 2011 19:52:54 +0000 Subject: hg: jdk8/tl/corba: 5 new changesets Message-ID: <20111026195304.B18FC4713C@hg.openjdk.java.net> Changeset: 3d61f0856f34 Author: katleman Date: 2011-09-22 16:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/3d61f0856f34 Added tag jdk8-b06 for changeset 45c43dde7ba7 ! .hgtags Changeset: 0d52b1c87aa8 Author: katleman Date: 2011-09-29 18:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/0d52b1c87aa8 Added tag jdk8-b07 for changeset 3d61f0856f34 ! .hgtags Changeset: a891732c1a83 Author: katleman Date: 2011-10-06 14:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/a891732c1a83 Added tag jdk8-b08 for changeset 0d52b1c87aa8 ! .hgtags Changeset: cda87f7fefce Author: katleman Date: 2011-10-13 10:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/cda87f7fefce Added tag jdk8-b09 for changeset a891732c1a83 ! .hgtags Changeset: 0199e4fef5cc Author: katleman Date: 2011-10-20 10:32 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/0199e4fef5cc Added tag jdk8-b10 for changeset cda87f7fefce ! .hgtags From lana.steuck at oracle.com Wed Oct 26 12:53:19 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 26 Oct 2011 19:53:19 +0000 Subject: hg: jdk8/tl/langtools: 11 new changesets Message-ID: <20111026195345.28F894713D@hg.openjdk.java.net> Changeset: 116980ecec5c Author: katleman Date: 2011-09-22 16:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/116980ecec5c Added tag jdk8-b06 for changeset d2422276f9da ! .hgtags Changeset: 9268bd271c6f Author: katleman Date: 2011-09-29 18:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9268bd271c6f Added tag jdk8-b07 for changeset 116980ecec5c ! .hgtags Changeset: 28573d605b01 Author: lana Date: 2011-09-26 14:33 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/28573d605b01 Merge - src/share/classes/com/sun/tools/javac/Launcher.java Changeset: e8acc2d6c32f Author: lana Date: 2011-10-03 18:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e8acc2d6c32f Merge - src/share/classes/com/sun/tools/javac/Launcher.java Changeset: b7a7e47c8d3d Author: katleman Date: 2011-10-06 14:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b7a7e47c8d3d Added tag jdk8-b08 for changeset e8acc2d6c32f ! .hgtags Changeset: 510d09ddc861 Author: katleman Date: 2011-10-13 10:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/510d09ddc861 Added tag jdk8-b09 for changeset b7a7e47c8d3d ! .hgtags Changeset: 5010ffc61eda Author: lana Date: 2011-10-12 12:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/5010ffc61eda Merge Changeset: f6c783e18bdf Author: lana Date: 2011-10-17 19:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f6c783e18bdf Merge Changeset: 4bf01f1c4e34 Author: katleman Date: 2011-10-20 10:32 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4bf01f1c4e34 Added tag jdk8-b10 for changeset f6c783e18bdf ! .hgtags Changeset: e52159ff8d0c Author: lana Date: 2011-10-25 10:52 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e52159ff8d0c Merge Changeset: 897b72b2751b Author: lana Date: 2011-10-26 12:28 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/897b72b2751b Merge - src/share/classes/com/sun/tools/javac/file/Paths.java From lana.steuck at oracle.com Wed Oct 26 12:53:43 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 26 Oct 2011 19:53:43 +0000 Subject: hg: jdk8/tl/hotspot: 114 new changesets Message-ID: <20111026195720.E89684713E@hg.openjdk.java.net> Changeset: 3f0cf875af83 Author: katleman Date: 2011-09-22 16:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3f0cf875af83 Added tag jdk8-b06 for changeset 0db80d8e77fc ! .hgtags Changeset: 0663e7617095 Author: katleman Date: 2011-09-29 18:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0663e7617095 Added tag jdk8-b07 for changeset 3f0cf875af83 ! .hgtags Changeset: 5755e84e970f Author: jcoomes Date: 2011-09-02 15:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5755e84e970f Added tag hs22-b01 for changeset 0cc8a70952c3 ! .hgtags Changeset: 40c5e268d399 Author: jcoomes Date: 2011-09-02 15:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/40c5e268d399 Added tag hs22-b02 for changeset 7c29742c41b4 ! .hgtags Changeset: 52220701f19f Author: jcoomes Date: 2011-09-02 15:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/52220701f19f Added tag hs22-b03 for changeset 3a2fb61165df ! .hgtags Changeset: ce9bde819dcb Author: jcoomes Date: 2011-09-02 03:49 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ce9bde819dcb 7086589: bump the hs22 build number to 04 Reviewed-by: johnc Contributed-by: alejandro.murillo at oracle.com ! make/hotspot_version Changeset: 5c123cbeebbe Author: jcoomes Date: 2011-09-02 15:52 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5c123cbeebbe Added tag hs22-b04 for changeset ce9bde819dcb ! .hgtags Changeset: 3cd0157e1d4d Author: iveresov Date: 2011-08-25 02:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3cd0157e1d4d 7082969: NUMA interleaving Summary: Support interleaving on NUMA systems for collectors that don't have NUMA-awareness. Reviewed-by: iveresov, ysr Contributed-by: Tom Deneau ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/windows/vm/os_windows.cpp ! src/os/windows/vm/os_windows.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: eeae91c9baba Author: johnc Date: 2011-08-29 10:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/eeae91c9baba 7080389: G1: refactor marking code in evacuation pause copy closures Summary: Refactor code marking code in the evacuation pause copy closures so that an evacuated object is only marked by the thread that successfully copies it. Reviewed-by: stefank, brutisso, tonyp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1OopClosures.hpp ! src/share/vm/gc_implementation/g1/g1_specialized_oop_closures.hpp Changeset: 9447b2fb6fcf Author: iveresov Date: 2011-08-29 17:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9447b2fb6fcf 7082645: Hotspot doesn't compile on old linuxes after 7060836 Summary: Move syscall ids definitions into os_linux.cpp Reviewed-by: johnc ! src/os/linux/vm/os_linux.cpp Changeset: 4fe626cbf0bf Author: johnc Date: 2011-08-31 10:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/4fe626cbf0bf 7066841: remove MacroAssembler::br_on_reg_cond() on sparc Summary: Remove the macro assembler routine br_on_reg_cond() and replace the remaining calls to that routine with an equivalent. Reviewed-by: kvn, iveresov ! src/cpu/sparc/vm/assembler_sparc.cpp ! src/cpu/sparc/vm/assembler_sparc.hpp ! src/cpu/sparc/vm/c1_CodeStubs_sparc.cpp ! src/cpu/sparc/vm/c1_Runtime1_sparc.cpp ! src/share/vm/gc_implementation/g1/g1_globals.hpp Changeset: ae1b1788f63f Author: ysr Date: 2011-08-31 23:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ae1b1788f63f Merge Changeset: 4668545121b8 Author: jcoomes Date: 2011-09-02 21:33 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/4668545121b8 Merge Changeset: ac8738449b6f Author: never Date: 2011-08-25 20:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ac8738449b6f 7082949: JSR 292: missing ResourceMark in methodOopDesc::make_invoke_method Reviewed-by: kvn, twisti ! src/share/vm/oops/methodOop.cpp + test/compiler/7082949/Test7082949.java Changeset: baf763f388e6 Author: kvn Date: 2011-08-26 08:52 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/baf763f388e6 7059037: Use BIS for zeroing on T4 Summary: Use BIS for zeroing new allocated big (2Kb and more) objects and arrays. Reviewed-by: never, twisti, ysr ! src/cpu/sparc/vm/assembler_sparc.cpp ! src/cpu/sparc/vm/assembler_sparc.hpp ! src/cpu/sparc/vm/copy_sparc.hpp ! src/cpu/sparc/vm/sparc.ad ! src/cpu/sparc/vm/stubGenerator_sparc.cpp ! src/cpu/sparc/vm/templateTable_sparc.cpp ! src/cpu/sparc/vm/vm_version_sparc.cpp ! src/cpu/sparc/vm/vm_version_sparc.hpp ! src/share/vm/gc_interface/collectedHeap.cpp ! src/share/vm/gc_interface/collectedHeap.inline.hpp ! src/share/vm/oops/cpCacheKlass.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/stubRoutines.cpp ! src/share/vm/runtime/stubRoutines.hpp Changeset: 8805f8c1e23e Author: iveresov Date: 2011-08-27 00:23 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8805f8c1e23e 6591247: C2 cleans up the merge point too early during SplitIf Summary: Remove region self reference last Reviewed-by: kvn, never ! src/share/vm/opto/split_if.cpp Changeset: b27c72d69fd1 Author: twisti Date: 2011-08-29 05:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b27c72d69fd1 7083184: JSR 292: don't store context class argument with call site dependencies Reviewed-by: jrose, never ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/ci/ciEnv.hpp ! src/share/vm/code/dependencies.cpp ! src/share/vm/code/dependencies.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/opto/callGenerator.cpp Changeset: 19241ae0d839 Author: never Date: 2011-08-30 00:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/19241ae0d839 7082263: Reflection::resolve_field/field_get/field_set are broken Reviewed-by: kvn, dholmes, stefank, coleenp ! make/linux/makefiles/mapfile-vers-debug ! make/linux/makefiles/mapfile-vers-product ! make/solaris/makefiles/debug.make ! make/solaris/makefiles/fastdebug.make ! make/solaris/makefiles/jvmg.make - make/solaris/makefiles/mapfile-vers-nonproduct ! make/solaris/makefiles/optimized.make ! make/solaris/makefiles/product.make ! src/share/vm/precompiled.hpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvm.h ! src/share/vm/prims/unsafe.cpp ! src/share/vm/runtime/reflection.cpp ! src/share/vm/runtime/reflection.hpp - src/share/vm/runtime/reflectionCompat.hpp Changeset: b346f13112d8 Author: iveresov Date: 2011-08-30 19:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b346f13112d8 7085279: C1 overflows code buffer with VerifyOops and CompressedOops Summary: Increase the limit of code emitted per LIR instruction, increase the max size of the nmethod generated by C1 Reviewed-by: never, kvn, johnc ! src/share/vm/c1/c1_LIRAssembler.cpp ! src/share/vm/c1/c1_globals.hpp Changeset: de847cac9235 Author: twisti Date: 2011-08-31 01:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/de847cac9235 7078382: JSR 292: don't count method handle adapters against inlining budgets Reviewed-by: kvn, never ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/ci/ciMethod.cpp ! src/share/vm/ci/ciMethod.hpp ! src/share/vm/ci/ciStreams.hpp ! src/share/vm/interpreter/bytecodes.hpp ! src/share/vm/opto/bytecodeInfo.cpp Changeset: a64d352d1118 Author: kvn Date: 2011-08-31 09:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a64d352d1118 7085137: -XX:+VerifyOops is broken Summary: Replace set() with patchable_set() to generate 8 instructions always. Reviewed-by: iveresov, never, roland ! src/cpu/sparc/vm/assembler_sparc.cpp ! src/cpu/sparc/vm/sparc.ad Changeset: c124e2e7463e Author: never Date: 2011-08-31 16:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c124e2e7463e 7083786: dead various dead chunks of code Reviewed-by: iveresov, kvn ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/sparc/vm/c1_Runtime1_sparc.cpp ! src/cpu/sparc/vm/frame_sparc.hpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.hpp ! src/cpu/x86/vm/c1_Runtime1_x86.cpp ! src/share/vm/c1/c1_Compilation.cpp ! src/share/vm/c1/c1_LIRAssembler.hpp ! src/share/vm/c1/c1_Runtime1.cpp ! src/share/vm/c1/c1_Runtime1.hpp ! src/share/vm/ci/ciConstant.hpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/ci/ciEnv.hpp ! src/share/vm/ci/ciField.hpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/oops/constMethodKlass.cpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/connode.hpp ! src/share/vm/opto/parse2.cpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/prims/forte.cpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/thread.hpp Changeset: a32de5085326 Author: twisti Date: 2011-09-01 01:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a32de5085326 7079673: JSR 292: C1 should inline bytecoded method handle adapters Reviewed-by: never ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/c1/c1_GraphBuilder.hpp ! src/share/vm/c1/c1_Instruction.cpp ! src/share/vm/c1/c1_Instruction.hpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/opto/callGenerator.cpp ! src/share/vm/opto/parse.hpp Changeset: aa67216400d3 Author: twisti Date: 2011-09-02 00:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/aa67216400d3 7085404: JSR 292: VolatileCallSites should have push notification too Reviewed-by: never, kvn ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/ci/ciField.hpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/opto/callGenerator.cpp ! src/share/vm/opto/doCall.cpp ! src/share/vm/opto/parse3.cpp ! src/share/vm/prims/unsafe.cpp Changeset: 11a4af030e4b Author: twisti Date: 2011-09-02 04:28 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/11a4af030e4b 7071709: JSR 292: switchpoint invalidation should be pushed not pulled Reviewed-by: never ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/parse3.cpp Changeset: 2f9b79ddb05c Author: kvn Date: 2011-09-02 12:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2f9b79ddb05c 7039731: arraycopy could use prefetch on SPARC Summary: Use BIS and prefetch in arraycopy stubs for Sparc (BIS for T4 only). Reviewed-by: never, iveresov ! src/cpu/sparc/vm/stubGenerator_sparc.cpp ! src/cpu/sparc/vm/vm_version_sparc.cpp ! src/share/vm/runtime/globals.hpp Changeset: 2090c623107e Author: never Date: 2011-09-02 22:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2090c623107e 7016881: JSR 292: JDI: sun.jvm.hotspot.utilities.AssertionFailure: index out of bounds Reviewed-by: kvn, twisti ! agent/src/share/classes/sun/jvm/hotspot/interpreter/BytecodeLoadConstant.java Changeset: c26de9aef2ed Author: never Date: 2011-09-02 20:58 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c26de9aef2ed 7071307: MethodHandle bimorphic inlining should consider the frequency Reviewed-by: twisti, roland, kvn, iveresov ! src/cpu/sparc/vm/methodHandles_sparc.cpp ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/share/vm/ci/ciCallProfile.hpp ! src/share/vm/ci/ciMethodHandle.cpp ! src/share/vm/ci/ciMethodHandle.hpp ! src/share/vm/ci/ciObject.cpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/oops/methodDataOop.hpp ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/opto/callGenerator.cpp ! src/share/vm/opto/idealGraphPrinter.cpp ! src/share/vm/opto/idealGraphPrinter.hpp ! src/share/vm/opto/matcher.cpp ! src/share/vm/prims/methodHandleWalk.cpp ! src/share/vm/prims/methodHandleWalk.hpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/prims/methodHandles.hpp Changeset: 7ffacbb338d4 Author: never Date: 2011-09-03 09:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7ffacbb338d4 Merge Changeset: 7b5c767f229c Author: kvn Date: 2011-09-03 14:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7b5c767f229c 7086560: 7085404 changes broke VM with -XX:-EnableInvokeDynamic Summary: Add check that ciEnv::_CallSite_klass is initialized. Reviewed-by: jrose ! src/share/vm/ci/ciField.hpp Changeset: 7588156f5cf9 Author: never Date: 2011-09-05 17:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7588156f5cf9 7051798: SA-JDI: NPE in Frame.addressOfStackSlot(Frame.java:244) Reviewed-by: kvn ! agent/src/share/classes/sun/jvm/hotspot/HSDB.java ! agent/src/share/classes/sun/jvm/hotspot/code/CodeBlob.java ! agent/src/share/classes/sun/jvm/hotspot/code/CodeCache.java + agent/src/share/classes/sun/jvm/hotspot/code/MethodHandlesAdapterBlob.java ! agent/src/share/classes/sun/jvm/hotspot/code/NMethod.java ! agent/src/share/classes/sun/jvm/hotspot/code/PCDesc.java ! agent/src/share/classes/sun/jvm/hotspot/code/RicochetBlob.java ! agent/src/share/classes/sun/jvm/hotspot/code/RuntimeStub.java ! agent/src/share/classes/sun/jvm/hotspot/compiler/OopMapSet.java ! agent/src/share/classes/sun/jvm/hotspot/jdi/ReferenceTypeImpl.java ! agent/src/share/classes/sun/jvm/hotspot/jdi/StackFrameImpl.java ! agent/src/share/classes/sun/jvm/hotspot/memory/SystemDictionary.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/CompiledVFrame.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/Frame.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/JavaVFrame.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/StackValue.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/VFrame.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/amd64/AMD64CurrentFrameGuess.java - agent/src/share/classes/sun/jvm/hotspot/runtime/amd64/AMD64Frame.java - agent/src/share/classes/sun/jvm/hotspot/runtime/amd64/AMD64RegisterMap.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/linux_amd64/LinuxAMD64JavaThreadPDAccess.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/solaris_amd64/SolarisAMD64JavaThreadPDAccess.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/sparc/SPARCFrame.java + agent/src/share/classes/sun/jvm/hotspot/runtime/sparc/SPARCRicochetFrame.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/win32_amd64/Win32AMD64JavaThreadPDAccess.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/x86/X86Frame.java + agent/src/share/classes/sun/jvm/hotspot/runtime/x86/X86RicochetFrame.java ! src/cpu/x86/vm/methodHandles_x86.hpp ! src/share/vm/c1/c1_LinearScan.cpp ! src/share/vm/c1/c1_LinearScan.hpp ! src/share/vm/code/pcDesc.cpp ! src/share/vm/code/pcDesc.hpp ! src/share/vm/runtime/sharedRuntime.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/thread.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: c2d3caa64b3e Author: roland Date: 2011-09-07 09:35 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c2d3caa64b3e 7086394: c2/arm: enable UseFPUForSpilling Summary: ARM has instructions to move data directly between the fpu and integer registers. Reviewed-by: kvn, never ! src/share/vm/opto/matcher.cpp Changeset: d968f546734e Author: iveresov Date: 2011-09-07 11:52 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d968f546734e Merge - agent/src/share/classes/sun/jvm/hotspot/runtime/amd64/AMD64Frame.java - agent/src/share/classes/sun/jvm/hotspot/runtime/amd64/AMD64RegisterMap.java - make/solaris/makefiles/mapfile-vers-nonproduct ! src/cpu/sparc/vm/assembler_sparc.cpp ! src/cpu/sparc/vm/assembler_sparc.hpp ! src/cpu/sparc/vm/c1_Runtime1_sparc.cpp ! src/share/vm/gc_interface/collectedHeap.cpp ! src/share/vm/runtime/globals.hpp - src/share/vm/runtime/reflectionCompat.hpp Changeset: 2fecca53a2c6 Author: roland Date: 2011-09-07 14:15 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2fecca53a2c6 7085012: ARM: com/sun/jdi/PopSynchronousTest.java still fails Summary: InterpreterRuntime::popframe_move_outgoing_args() is required for the ARM interpreter. Reviewed-by: kvn, twisti ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/interpreter/interpreterRuntime.hpp Changeset: 5596e125fe4f Author: rottenha Date: 2011-09-08 06:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5596e125fe4f Merge ! src/share/vm/interpreter/interpreterRuntime.cpp Changeset: 27702f012017 Author: iveresov Date: 2011-09-06 21:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/27702f012017 7087583: Hotspot fails to allocate heap with mmap(MAP_HUGETLB) Summary: Try using small pages when transparent huge pages allocation fails Reviewed-by: ysr ! src/os/linux/vm/os_linux.cpp Changeset: 20213c8a3c40 Author: tonyp Date: 2011-09-07 12:21 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/20213c8a3c40 7050392: G1: Introduce flag to generate a log of the G1 ergonomic decisions Summary: It introduces ergonomic decision logging in G1 for the following heuristics: heap sizing, collection set construction, concurrent cycle initiation, and partially-young GC start/end. The code has a bit of refactoring in a few places to make the decision logging possible. It also replaces alternative ad-hoc logging that we have under different parameters and switches (G1_DEBUG, G1PolicyVerbose). Reviewed-by: johnc, ysr ! src/share/vm/gc_implementation/g1/collectionSetChooser.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp + src/share/vm/gc_implementation/g1/g1ErgoVerbose.cpp + src/share/vm/gc_implementation/g1/g1ErgoVerbose.hpp ! src/share/vm/gc_implementation/g1/g1MMUTracker.cpp ! src/share/vm/gc_implementation/g1/vm_operations_g1.cpp Changeset: c2bf0120ee5d Author: stefank Date: 2011-09-01 16:18 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c2bf0120ee5d 7085906: Replace the permgen allocated sentinelRef with a self-looped end Summary: Remove the sentinelRef and let the last Reference in a discovered chain point back to itself. Reviewed-by: ysr, jmasa ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp ! src/share/vm/gc_implementation/parallelScavenge/pcTasks.cpp ! src/share/vm/gc_implementation/parallelScavenge/pcTasks.hpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psTasks.cpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/referenceProcessor.cpp ! src/share/vm/memory/referenceProcessor.hpp ! src/share/vm/memory/sharedHeap.cpp Changeset: 05550041d664 Author: ysr Date: 2011-09-07 15:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/05550041d664 Merge ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp Changeset: eca1193ca245 Author: ysr Date: 2011-09-07 13:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/eca1193ca245 4965777: GC changes to support use of discovered field for pending references Summary: If and when the reference handler thread is able to use the discovered field to link reference objects in its pending list, so will GC. In that case, GC will scan through this field once a reference object has been placed on the pending list, but not scan that field before that stage, as the field is used by the concurrent GC thread to link discovered objects. When ReferenceHandleR thread does not use the discovered field for the purpose of linking the elements in the pending list, as would be the case in older JDKs, the JVM will fall back to the old behaviour of using the next field for that purpose. Reviewed-by: jcoomes, mchung, stefank ! src/share/vm/memory/referenceProcessor.cpp ! src/share/vm/memory/referenceProcessor.hpp ! src/share/vm/oops/instanceRefKlass.cpp ! src/share/vm/prims/jvm.h ! src/share/vm/runtime/java.cpp ! src/share/vm/runtime/java.hpp Changeset: a6128a8ed624 Author: iveresov Date: 2011-09-07 18:58 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a6128a8ed624 7086226: UseNUMA fails on old versions of windows Summary: Return correct answers from os::numa_*() for UMA machines or if NUMA API is not supported Reviewed-by: johnc ! src/os/windows/vm/os_windows.cpp Changeset: 4f41766176cf Author: tonyp Date: 2011-09-08 05:16 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/4f41766176cf 7084509: G1: fix inconsistencies and mistakes in the young list target length calculations Summary: Fixed inconsistencies and mistakes in the young list target length calculations so that a) the calculated target length is optimal (before, it was not), b) other parameters like max survivor size and max gc locker eden expansion are always consistent with the calculated target length (before, they were not always), and c) the resulting target length was always bound by desired min and max values (before, it was not). Reviewed-by: brutisso, johnc ! src/share/vm/gc_implementation/g1/concurrentG1RefineThread.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/gc_implementation/g1/g1_globals.hpp Changeset: af2ab04e0038 Author: brutisso Date: 2011-09-08 16:29 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/af2ab04e0038 6929868: G1: introduce min / max young gen size bounds Summary: Make G1 handle young gen size command line flags more consistently Reviewed-by: tonyp, jwilhelm ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp Changeset: 3bddbf0f57d6 Author: tonyp Date: 2011-09-09 05:20 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3bddbf0f57d6 7087717: G1: make the G1PrintRegionLivenessInfo parameter diagnostic Reviewed-by: brutisso, ysr ! src/share/vm/gc_implementation/g1/g1_globals.hpp Changeset: e984655be425 Author: stefank Date: 2011-09-09 14:44 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e984655be425 Merge ! src/share/vm/prims/jvm.h Changeset: 79f9a3ed607a Author: jcoomes Date: 2011-09-09 16:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/79f9a3ed607a Merge ! .hgtags - agent/src/share/classes/sun/jvm/hotspot/runtime/amd64/AMD64Frame.java - agent/src/share/classes/sun/jvm/hotspot/runtime/amd64/AMD64RegisterMap.java - make/solaris/makefiles/mapfile-vers-nonproduct - src/share/vm/runtime/reflectionCompat.hpp Changeset: 513a84dd0f8b Author: jcoomes Date: 2011-09-09 16:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/513a84dd0f8b 7088991: Bump ths hs22 build number to 05 Reviewed-by: johnc Contributed-by: alejandro.murillo at oracle.com ! make/hotspot_version Changeset: 140317da459a Author: jcoomes Date: 2011-09-09 16:33 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/140317da459a Added tag hs22-b05 for changeset 513a84dd0f8b ! .hgtags Changeset: f1b4e0e0bdad Author: tonyp Date: 2011-09-13 12:40 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f1b4e0e0bdad 7089625: G1: policy for how many old regions to add to the CSet (when young gen is fixed) is broken Summary: When refactoring the code for a previous fix, a condition was not correctly negated which prevents the G1 policy from adding the correct number of old regions to the CSet when the young gen size is fixed. The changeset also fixes a small syntactical issue in g1ErgoVerbose.hpp which is causing compiler warnings. Reviewed-by: brutisso, ysr ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1ErgoVerbose.hpp Changeset: 0a63380c8ac8 Author: iveresov Date: 2011-09-13 16:58 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0a63380c8ac8 7090069: Java launcher hangs in infinite loop on windows when UseNUMA[Interleaving] is specified Summary: Fix _numa_used_node_list array size specification Reviewed-by: kvn, johnc, jmasa, ysr ! src/os/windows/vm/os_windows.cpp Changeset: f94227b6117b Author: kvn Date: 2011-09-13 20:28 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f94227b6117b 7090259: Fix hotspot sources to build with old compilers Summary: Fixed warnings which prevent building VM with old compilers. Reviewed-by: never ! make/solaris/makefiles/sparcWorks.make ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/oops/instanceRefKlass.cpp ! src/share/vm/oops/methodOop.cpp ! src/share/vm/opto/block.cpp Changeset: da6a29fb0da5 Author: kvn Date: 2011-09-07 12:58 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/da6a29fb0da5 7054211: No loop unrolling done in jdk7b144 for a test update() while loop Summary: restore unrolling code for CaffeineMark. Reviewed-by: never ! src/share/vm/opto/loopTransform.cpp Changeset: 5432047c7db7 Author: bdelsart Date: 2011-09-08 10:12 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5432047c7db7 7087445: Improve platform independence of JSR292 shared code Summary: changes necessary for some JSR292 ports Reviewed-by: jrose, dholmes ! src/cpu/sparc/vm/frame_sparc.cpp ! src/cpu/x86/vm/frame_x86.cpp ! src/cpu/x86/vm/sharedRuntime_x86_32.cpp ! src/cpu/x86/vm/sharedRuntime_x86_64.cpp ! src/cpu/zero/vm/frame_zero.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/deoptimization.hpp ! src/share/vm/runtime/frame.hpp Changeset: b0efc7ee3b31 Author: twisti Date: 2011-09-08 05:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b0efc7ee3b31 7085860: JSR 292: implement CallSite.setTargetNormal and setTargetVolatile as native methods Reviewed-by: jrose, never ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/oops/klassOop.hpp ! src/share/vm/oops/oop.hpp ! src/share/vm/oops/oop.inline.hpp ! src/share/vm/prims/methodHandles.cpp Changeset: fdcb1e828d53 Author: kvn Date: 2011-09-08 12:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/fdcb1e828d53 7087947: Add regression test for 7068051 Summary: Add regression test. Reviewed-by: never + test/compiler/7068051/Test7068051.java + test/compiler/7068051/Test7068051.sh Changeset: 8f47d8870d9a Author: roland Date: 2011-09-08 09:35 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8f47d8870d9a 7087453: PhaseChaitin::yank_if_dead() should handle MachTemp inputs Summary: PhaseChaitin::yank_if_dead() should be able to handle MachTemp inputs as a special case and yank them. Reviewed-by: never, kvn ! src/share/vm/opto/chaitin.hpp ! src/share/vm/opto/postaloc.cpp Changeset: 5257f8e66b40 Author: iveresov Date: 2011-09-09 12:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5257f8e66b40 Merge ! src/share/vm/runtime/arguments.cpp Changeset: 2c24ef16533d Author: kvn Date: 2011-09-09 13:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2c24ef16533d 7035946: Up to 15% regression on JDK 7 b136 vs b135 on specjvm2008.crypto.rsa on x64 Summary: Revert changes which caused regression. Reviewed-by: never ! src/share/vm/opto/loopnode.cpp Changeset: c565834fb592 Author: never Date: 2011-09-10 00:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c565834fb592 7088020: SEGV in JNIHandleBlock::release_block Reviewed-by: kvn, twisti ! src/cpu/sparc/vm/stubGenerator_sparc.cpp ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp ! src/cpu/zero/vm/stubGenerator_zero.cpp ! src/share/vm/runtime/stubRoutines.cpp ! src/share/vm/runtime/stubRoutines.hpp + test/compiler/7088020/Test7088020.java Changeset: e6b1331a51d2 Author: never Date: 2011-09-10 17:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e6b1331a51d2 7086585: make Java field injection more flexible Reviewed-by: jrose, twisti, kvn, coleenp ! agent/src/share/classes/sun/jvm/hotspot/oops/Field.java ! agent/src/share/classes/sun/jvm/hotspot/oops/InstanceKlass.java ! agent/src/share/classes/sun/jvm/hotspot/oops/java_lang_Class.java ! agent/src/share/classes/sun/jvm/hotspot/tools/jcore/ClassWriter.java ! agent/src/share/classes/sun/jvm/hotspot/tools/soql/SOQL.java ! agent/src/share/classes/sun/jvm/hotspot/ui/classbrowser/HTMLGenerator.java ! agent/test/jdi/sasanity.sh ! src/cpu/sparc/vm/assembler_sparc.cpp ! src/cpu/x86/vm/assembler_x86.cpp ! src/share/vm/ci/ciInstanceKlass.cpp ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/classFileParser.hpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/oops/cpCacheOop.cpp + src/share/vm/oops/fieldInfo.hpp + src/share/vm/oops/fieldStreams.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/instanceKlassKlass.cpp ! src/share/vm/prims/jni.cpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvmtiClassFileReconstituter.cpp ! src/share/vm/prims/jvmtiEnv.cpp ! src/share/vm/prims/jvmtiEnvBase.cpp ! src/share/vm/prims/jvmtiEnvBase.hpp ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/prims/unsafe.cpp ! src/share/vm/runtime/fieldDescriptor.cpp ! src/share/vm/runtime/fieldDescriptor.hpp ! src/share/vm/runtime/reflectionUtils.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/utilities/accessFlags.hpp Changeset: f6f3bb0ee072 Author: never Date: 2011-09-11 14:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f6f3bb0ee072 7088955: add C2 IR support to the SA Reviewed-by: kvn ! agent/make/Makefile ! agent/make/saenv.sh ! agent/make/saenv64.sh ! agent/src/os/solaris/Makefile - agent/src/os/solaris/dbx/Makefile - agent/src/os/solaris/dbx/README - agent/src/os/solaris/dbx/README-commands.txt - agent/src/os/solaris/dbx/helloWorld.cpp - agent/src/os/solaris/dbx/proc_service_2.h - agent/src/os/solaris/dbx/shell_imp.h - agent/src/os/solaris/dbx/svc_agent_dbx.cpp - agent/src/os/solaris/dbx/svc_agent_dbx.hpp - agent/src/os/win32/BasicList.hpp - agent/src/os/win32/Buffer.cpp - agent/src/os/win32/Buffer.hpp - agent/src/os/win32/Dispatcher.cpp - agent/src/os/win32/Dispatcher.hpp - agent/src/os/win32/Handler.hpp - agent/src/os/win32/IOBuf.cpp - agent/src/os/win32/IOBuf.hpp - agent/src/os/win32/LockableList.hpp - agent/src/os/win32/Makefile - agent/src/os/win32/Message.hpp - agent/src/os/win32/Monitor.cpp - agent/src/os/win32/Monitor.hpp - agent/src/os/win32/README-commands.txt - agent/src/os/win32/README.txt - agent/src/os/win32/Reaper.cpp - agent/src/os/win32/Reaper.hpp - agent/src/os/win32/SwDbgSrv.cpp - agent/src/os/win32/SwDbgSrv.dsp - agent/src/os/win32/SwDbgSrv.dsw - agent/src/os/win32/SwDbgSub.cpp - agent/src/os/win32/SwDbgSub.dsp - agent/src/os/win32/initWinsock.cpp - agent/src/os/win32/initWinsock.hpp - agent/src/os/win32/ioUtils.cpp - agent/src/os/win32/ioUtils.hpp - agent/src/os/win32/isNT4.cpp - agent/src/os/win32/isNT4.hpp - agent/src/os/win32/libInfo.cpp - agent/src/os/win32/libInfo.hpp - agent/src/os/win32/nt4internals.cpp - agent/src/os/win32/nt4internals.hpp - agent/src/os/win32/ports.h - agent/src/os/win32/procList.cpp - agent/src/os/win32/procList.hpp - agent/src/os/win32/serverLists.cpp - agent/src/os/win32/serverLists.hpp - agent/src/os/win32/toolHelp.cpp - agent/src/os/win32/toolHelp.hpp ! agent/src/share/classes/sun/jvm/hotspot/CLHSDB.java ! agent/src/share/classes/sun/jvm/hotspot/CommandProcessor.java ! agent/src/share/classes/sun/jvm/hotspot/DebugServer.java ! agent/src/share/classes/sun/jvm/hotspot/HotSpotAgent.java ! agent/src/share/classes/sun/jvm/hotspot/HotSpotTypeDataBase.java ! agent/src/share/classes/sun/jvm/hotspot/TestDebugger.java ! agent/src/share/classes/sun/jvm/hotspot/bugspot/BugSpot.java ! agent/src/share/classes/sun/jvm/hotspot/bugspot/BugSpotAgent.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciArrayKlass.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciArrayKlassKlass.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciConstant.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciEnv.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciField.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciInstance.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciInstanceKlass.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciInstanceKlassKlass.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciKlass.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciKlassKlass.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciMethod.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciMethodData.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciMethodKlass.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciObjArrayKlass.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciObjArrayKlassKlass.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciObject.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciObjectFactory.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciReceiverTypeData.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciSymbol.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciType.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciTypeArrayKlass.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciTypeArrayKlassKlass.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciVirtualCallData.java ! agent/src/share/classes/sun/jvm/hotspot/code/NMethod.java + agent/src/share/classes/sun/jvm/hotspot/compiler/CompileTask.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/AddressException.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/DbxAddress.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/DbxDebugger.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/DbxDebuggerLocal.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/DbxOopHandle.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/DbxThreadFactory.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/sparc/DbxSPARCThread.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/sparc/DbxSPARCThreadContext.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/sparc/DbxSPARCThreadFactory.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/x86/DbxX86Thread.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/x86/DbxX86ThreadContext.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/x86/DbxX86ThreadFactory.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/AddressDataSource.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/DLL.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/TestDebugger.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/TestHelloWorld.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32Address.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32CDebugInfoBuilder.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32CDebugger.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32Debugger.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32DebuggerLocal.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32LDTEntry.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32LDTEntryConstants.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32OopHandle.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32Thread.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32ThreadContext.java ! agent/src/share/classes/sun/jvm/hotspot/jdi/SADebugServer.java ! agent/src/share/classes/sun/jvm/hotspot/jdi/VirtualMachineImpl.java + agent/src/share/classes/sun/jvm/hotspot/oops/ArrayData.java + agent/src/share/classes/sun/jvm/hotspot/oops/BitData.java + agent/src/share/classes/sun/jvm/hotspot/oops/BranchData.java ! agent/src/share/classes/sun/jvm/hotspot/oops/CIntField.java + agent/src/share/classes/sun/jvm/hotspot/oops/CounterData.java + agent/src/share/classes/sun/jvm/hotspot/oops/DataLayout.java ! agent/src/share/classes/sun/jvm/hotspot/oops/Field.java ! agent/src/share/classes/sun/jvm/hotspot/oops/FieldType.java ! agent/src/share/classes/sun/jvm/hotspot/oops/InstanceKlass.java + agent/src/share/classes/sun/jvm/hotspot/oops/JumpData.java ! agent/src/share/classes/sun/jvm/hotspot/oops/Method.java ! agent/src/share/classes/sun/jvm/hotspot/oops/MethodData.java + agent/src/share/classes/sun/jvm/hotspot/oops/MultiBranchData.java ! agent/src/share/classes/sun/jvm/hotspot/oops/OopUtilities.java + agent/src/share/classes/sun/jvm/hotspot/oops/ProfileData.java + agent/src/share/classes/sun/jvm/hotspot/oops/ReceiverTypeData.java + agent/src/share/classes/sun/jvm/hotspot/oops/RetData.java + agent/src/share/classes/sun/jvm/hotspot/oops/VirtualCallData.java + agent/src/share/classes/sun/jvm/hotspot/opto/Block.java + agent/src/share/classes/sun/jvm/hotspot/opto/Block_Array.java + agent/src/share/classes/sun/jvm/hotspot/opto/Block_List.java + agent/src/share/classes/sun/jvm/hotspot/opto/CallDynamicJavaNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/CallJavaNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/CallNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/CallRuntimeNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/CallStaticJavaNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/Compile.java + agent/src/share/classes/sun/jvm/hotspot/opto/HaltNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/InlineTree.java + agent/src/share/classes/sun/jvm/hotspot/opto/JVMState.java + agent/src/share/classes/sun/jvm/hotspot/opto/LoopNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/MachCallJavaNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/MachCallNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/MachCallRuntimeNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/MachCallStaticJavaNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/MachIfNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/MachNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/MachReturnNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/MachSafePointNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/MultiNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/Node.java + agent/src/share/classes/sun/jvm/hotspot/opto/Node_Array.java + agent/src/share/classes/sun/jvm/hotspot/opto/Node_List.java + agent/src/share/classes/sun/jvm/hotspot/opto/Phase.java + agent/src/share/classes/sun/jvm/hotspot/opto/PhaseCFG.java + agent/src/share/classes/sun/jvm/hotspot/opto/PhaseRegAlloc.java + agent/src/share/classes/sun/jvm/hotspot/opto/PhiNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/ProjNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/RegionNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/RootNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/SafePointNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/TypeNode.java + agent/src/share/classes/sun/jvm/hotspot/prims/JvmtiExport.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/CompilerThread.java + agent/src/share/classes/sun/jvm/hotspot/runtime/InstanceConstructor.java + agent/src/share/classes/sun/jvm/hotspot/runtime/StaticBaseConstructor.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java + agent/src/share/classes/sun/jvm/hotspot/runtime/VirtualBaseConstructor.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/VirtualConstructor.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/win32_amd64/Win32AMD64JavaThreadPDAccess.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/win32_x86/Win32X86JavaThreadPDAccess.java ! agent/src/share/classes/sun/jvm/hotspot/tools/jcore/ClassDump.java ! agent/src/share/classes/sun/jvm/hotspot/types/TypeDataBase.java ! agent/src/share/classes/sun/jvm/hotspot/types/basic/BasicTypeDataBase.java ! agent/src/share/classes/sun/jvm/hotspot/ui/CommandProcessorPanel.java + agent/src/share/classes/sun/jvm/hotspot/utilities/GenericGrowableArray.java + agent/src/share/classes/sun/jvm/hotspot/utilities/GrowableArray.java ! make/sa.files ! src/share/vm/ci/ciArrayKlass.hpp ! src/share/vm/ci/ciClassList.hpp ! src/share/vm/ci/ciConstant.hpp ! src/share/vm/ci/ciObjectFactory.hpp ! src/share/vm/compiler/compileBroker.hpp ! src/share/vm/memory/allocation.hpp ! src/share/vm/memory/resourceArea.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/opto/block.hpp ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/opto/callnode.hpp ! src/share/vm/opto/chaitin.hpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/node.hpp ! src/share/vm/opto/optoreg.hpp ! src/share/vm/opto/parse.hpp ! src/share/vm/opto/regalloc.hpp ! src/share/vm/opto/type.hpp ! src/share/vm/prims/jvmtiExport.hpp ! src/share/vm/runtime/deoptimization.hpp ! src/share/vm/runtime/vframeArray.hpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/utilities/exceptions.hpp ! src/share/vm/utilities/growableArray.hpp Changeset: ab577c97a5f3 Author: never Date: 2011-09-12 13:51 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ab577c97a5f3 7089709: type "jushort" not found Reviewed-by: kvn, twisti ! src/share/vm/runtime/vmStructs.cpp Changeset: 2209834ccb59 Author: kvn Date: 2011-09-13 11:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2209834ccb59 7089632: assert(machtmp->outcnt() == 1) failed: expected for a MachTemp Summary: Replace assert with check to delete MachTemp nodes only when they are really dead. Reviewed-by: never ! src/share/vm/opto/postaloc.cpp Changeset: 10ee2b297ccd Author: bdelsart Date: 2011-09-14 10:40 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/10ee2b297ccd 7057978: improve robustness of c1 ARM back-end wrt non encodable constants Summary: ARM only, avoid assertion failures for huge constants generated by C1 shared code Reviewed-by: never, vladidan ! src/share/vm/c1/c1_LIR.cpp Changeset: 393f4b789fd0 Author: bdelsart Date: 2011-09-14 16:28 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/393f4b789fd0 7077806: ARM: java.lang.InternalError: bound subword value does not fit into the subword type Summary: shared fix necessary for ARM/PPC Reviewed-by: twisti, roland ! src/share/vm/prims/methodHandles.hpp Changeset: 35c656d0b685 Author: never Date: 2011-09-14 13:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/35c656d0b685 7090654: nightly failures after 7086585 Reviewed-by: kvn ! agent/src/share/classes/sun/jvm/hotspot/oops/InstanceKlass.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java ! src/share/vm/prims/jvmtiClassFileReconstituter.cpp Changeset: 8ed53447f690 Author: iveresov Date: 2011-09-15 12:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8ed53447f690 Merge - agent/src/os/solaris/dbx/Makefile - agent/src/os/solaris/dbx/README - agent/src/os/solaris/dbx/README-commands.txt - agent/src/os/solaris/dbx/helloWorld.cpp - agent/src/os/solaris/dbx/proc_service_2.h - agent/src/os/solaris/dbx/shell_imp.h - agent/src/os/solaris/dbx/svc_agent_dbx.cpp - agent/src/os/solaris/dbx/svc_agent_dbx.hpp - agent/src/os/win32/BasicList.hpp - agent/src/os/win32/Buffer.cpp - agent/src/os/win32/Buffer.hpp - agent/src/os/win32/Dispatcher.cpp - agent/src/os/win32/Dispatcher.hpp - agent/src/os/win32/Handler.hpp - agent/src/os/win32/IOBuf.cpp - agent/src/os/win32/IOBuf.hpp - agent/src/os/win32/LockableList.hpp - agent/src/os/win32/Makefile - agent/src/os/win32/Message.hpp - agent/src/os/win32/Monitor.cpp - agent/src/os/win32/Monitor.hpp - agent/src/os/win32/README-commands.txt - agent/src/os/win32/README.txt - agent/src/os/win32/Reaper.cpp - agent/src/os/win32/Reaper.hpp - agent/src/os/win32/SwDbgSrv.cpp - agent/src/os/win32/SwDbgSrv.dsp - agent/src/os/win32/SwDbgSrv.dsw - agent/src/os/win32/SwDbgSub.cpp - agent/src/os/win32/SwDbgSub.dsp - agent/src/os/win32/initWinsock.cpp - agent/src/os/win32/initWinsock.hpp - agent/src/os/win32/ioUtils.cpp - agent/src/os/win32/ioUtils.hpp - agent/src/os/win32/isNT4.cpp - agent/src/os/win32/isNT4.hpp - agent/src/os/win32/libInfo.cpp - agent/src/os/win32/libInfo.hpp - agent/src/os/win32/nt4internals.cpp - agent/src/os/win32/nt4internals.hpp - agent/src/os/win32/ports.h - agent/src/os/win32/procList.cpp - agent/src/os/win32/procList.hpp - agent/src/os/win32/serverLists.cpp - agent/src/os/win32/serverLists.hpp - agent/src/os/win32/toolHelp.cpp - agent/src/os/win32/toolHelp.hpp - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/DbxAddress.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/DbxDebugger.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/DbxDebuggerLocal.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/DbxOopHandle.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/DbxThreadFactory.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/sparc/DbxSPARCThread.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/sparc/DbxSPARCThreadContext.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/sparc/DbxSPARCThreadFactory.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/x86/DbxX86Thread.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/x86/DbxX86ThreadContext.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/x86/DbxX86ThreadFactory.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/AddressDataSource.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/DLL.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/TestDebugger.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/TestHelloWorld.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32Address.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32CDebugInfoBuilder.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32CDebugger.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32Debugger.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32DebuggerLocal.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32LDTEntry.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32LDTEntryConstants.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32OopHandle.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32Thread.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32ThreadContext.java ! src/share/vm/classfile/javaClasses.cpp Changeset: 558f525a6ebe Author: jcoomes Date: 2011-09-15 19:33 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/558f525a6ebe Merge ! .hgtags - agent/src/os/solaris/dbx/Makefile - agent/src/os/solaris/dbx/README - agent/src/os/solaris/dbx/README-commands.txt - agent/src/os/solaris/dbx/helloWorld.cpp - agent/src/os/solaris/dbx/proc_service_2.h - agent/src/os/solaris/dbx/shell_imp.h - agent/src/os/solaris/dbx/svc_agent_dbx.cpp - agent/src/os/solaris/dbx/svc_agent_dbx.hpp - agent/src/os/win32/BasicList.hpp - agent/src/os/win32/Buffer.cpp - agent/src/os/win32/Buffer.hpp - agent/src/os/win32/Dispatcher.cpp - agent/src/os/win32/Dispatcher.hpp - agent/src/os/win32/Handler.hpp - agent/src/os/win32/IOBuf.cpp - agent/src/os/win32/IOBuf.hpp - agent/src/os/win32/LockableList.hpp - agent/src/os/win32/Makefile - agent/src/os/win32/Message.hpp - agent/src/os/win32/Monitor.cpp - agent/src/os/win32/Monitor.hpp - agent/src/os/win32/README-commands.txt - agent/src/os/win32/README.txt - agent/src/os/win32/Reaper.cpp - agent/src/os/win32/Reaper.hpp - agent/src/os/win32/SwDbgSrv.cpp - agent/src/os/win32/SwDbgSrv.dsp - agent/src/os/win32/SwDbgSrv.dsw - agent/src/os/win32/SwDbgSub.cpp - agent/src/os/win32/SwDbgSub.dsp - agent/src/os/win32/initWinsock.cpp - agent/src/os/win32/initWinsock.hpp - agent/src/os/win32/ioUtils.cpp - agent/src/os/win32/ioUtils.hpp - agent/src/os/win32/isNT4.cpp - agent/src/os/win32/isNT4.hpp - agent/src/os/win32/libInfo.cpp - agent/src/os/win32/libInfo.hpp - agent/src/os/win32/nt4internals.cpp - agent/src/os/win32/nt4internals.hpp - agent/src/os/win32/ports.h - agent/src/os/win32/procList.cpp - agent/src/os/win32/procList.hpp - agent/src/os/win32/serverLists.cpp - agent/src/os/win32/serverLists.hpp - agent/src/os/win32/toolHelp.cpp - agent/src/os/win32/toolHelp.hpp - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/DbxAddress.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/DbxDebugger.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/DbxDebuggerLocal.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/DbxOopHandle.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/DbxThreadFactory.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/sparc/DbxSPARCThread.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/sparc/DbxSPARCThreadContext.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/sparc/DbxSPARCThreadFactory.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/x86/DbxX86Thread.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/x86/DbxX86ThreadContext.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/x86/DbxX86ThreadFactory.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/AddressDataSource.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/DLL.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/TestDebugger.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/TestHelloWorld.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32Address.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32CDebugInfoBuilder.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32CDebugger.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32Debugger.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32DebuggerLocal.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32LDTEntry.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32LDTEntryConstants.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32OopHandle.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32Thread.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32ThreadContext.java - agent/src/share/classes/sun/jvm/hotspot/runtime/amd64/AMD64Frame.java - agent/src/share/classes/sun/jvm/hotspot/runtime/amd64/AMD64RegisterMap.java - make/solaris/makefiles/mapfile-vers-nonproduct - src/share/vm/runtime/reflectionCompat.hpp Changeset: 8ab2f4108d20 Author: jcoomes Date: 2011-09-15 20:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8ab2f4108d20 7091294: disable quicksort tests Reviewed-by: jmasa, ysr, kvn ! src/share/vm/utilities/quickSort.cpp Changeset: 650d15d8f372 Author: jcoomes Date: 2011-09-15 20:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/650d15d8f372 7091255: Bump the hs22 build number to 06 Reviewed-by: johnc Contributed-by: alejandro.murillo at oracle.com ! make/hotspot_version Changeset: 5a3c2bc614ca Author: jcoomes Date: 2011-09-15 20:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5a3c2bc614ca Added tag hs22-b06 for changeset 650d15d8f372 ! .hgtags Changeset: 77e1a9153757 Author: jcoomes Date: 2011-09-16 21:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/77e1a9153757 7091545: hs23 - set hotspot version & build number Reviewed-by: tonyp, never, phh, jmasa ! make/hotspot_version Changeset: da0999c4b733 Author: dcubed Date: 2011-09-16 16:21 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/da0999c4b733 7071904: 4/4 HotSpot: Full Debug Symbols Summary: Add support for .debuginfo files for HSX libraries. Reviewed-by: poonam, dholmes, never ! make/Makefile ! make/linux/Makefile ! make/linux/makefiles/build_vm_def.sh ! make/linux/makefiles/buildtree.make ! make/linux/makefiles/defs.make ! make/linux/makefiles/gcc.make ! make/linux/makefiles/jsig.make ! make/linux/makefiles/product.make ! make/linux/makefiles/saproc.make ! make/linux/makefiles/vm.make ! make/solaris/Makefile + make/solaris/makefiles/build_vm_def.sh ! make/solaris/makefiles/buildtree.make ! make/solaris/makefiles/defs.make ! make/solaris/makefiles/dtrace.make ! make/solaris/makefiles/jsig.make ! make/solaris/makefiles/mapfile-vers ! make/solaris/makefiles/product.make ! make/solaris/makefiles/saproc.make ! make/solaris/makefiles/sparcWorks.make ! make/solaris/makefiles/vm.make Changeset: 86cbe939f0c7 Author: dcubed Date: 2011-09-19 12:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/86cbe939f0c7 Merge Changeset: 3607aac85aa9 Author: kevinw Date: 2011-09-22 16:48 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3607aac85aa9 7051189: Need to suppress info message if -xcheck:jni used with libjsig.so Reviewed-by: coleenp, minqi ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/os_solaris.cpp + test/runtime/7051189/Xchecksig.sh Changeset: 5cceda753a4a Author: iveresov Date: 2011-09-19 15:21 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5cceda753a4a 7091764: Tiered: enable aastore profiling Summary: Turn on aastore profiling Reviewed-by: jrose, twisti ! src/cpu/sparc/vm/c1_LIRGenerator_sparc.cpp ! src/cpu/x86/vm/c1_LIRGenerator_x86.cpp ! src/share/vm/c1/c1_LIR.cpp ! src/share/vm/c1/c1_LIR.hpp Changeset: 075ea0ed9e7c Author: kvn Date: 2011-09-20 08:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/075ea0ed9e7c 7081842: assert(Compile::current()->unique() < (uint)MaxNodeLimit) failed: Node limit exceeded Summary: Add missing node limit check in IGVN optimizer Reviewed-by: iveresov, never ! make/linux/build.sh ! src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/CallSite.java ! src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogCompilation.java ! src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogParser.java ! src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/Phase.java ! src/share/vm/opto/phaseX.cpp Changeset: eda6988c0d81 Author: never Date: 2011-09-20 23:50 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/eda6988c0d81 7092236: java/util/EnumSet/EnumSetBash.java fails Reviewed-by: kvn, twisti, jrose ! src/share/vm/ci/ciEnv.cpp Changeset: f08d439fab8c Author: never Date: 2011-09-25 16:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f08d439fab8c 7089790: integrate bsd-port changes Reviewed-by: kvn, twisti, jrose Contributed-by: Kurt Miller , Greg Lewis , Jung-uk Kim , Christos Zoulas , Landon Fuller , The FreeBSD Foundation , Michael Franz , Roger Hoover , Alexander Strange ! agent/make/Makefile + agent/src/os/bsd/BsdDebuggerLocal.c + agent/src/os/bsd/Makefile + agent/src/os/bsd/StubDebuggerLocal.c + agent/src/os/bsd/elfmacros.h + agent/src/os/bsd/libproc.h + agent/src/os/bsd/libproc_impl.c + agent/src/os/bsd/libproc_impl.h + agent/src/os/bsd/mapfile + agent/src/os/bsd/ps_core.c + agent/src/os/bsd/ps_proc.c + agent/src/os/bsd/salibelf.c + agent/src/os/bsd/salibelf.h + agent/src/os/bsd/symtab.c + agent/src/os/bsd/symtab.h + agent/src/os/bsd/test.c + agent/src/share/classes/sun/jvm/hotspot/BsdVtblAccess.java ! agent/src/share/classes/sun/jvm/hotspot/HotSpotAgent.java ! agent/src/share/classes/sun/jvm/hotspot/bugspot/BugSpotAgent.java + agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdAddress.java + agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdCDebugger.java + agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebugger.java + agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebuggerLocal.java + agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdOopHandle.java + agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdThread.java + agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdThreadContextFactory.java + agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/SharedObject.java + agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/amd64/BsdAMD64CFrame.java + agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/amd64/BsdAMD64ThreadContext.java + agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/x86/BsdX86CFrame.java + agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/x86/BsdX86ThreadContext.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/Threads.java + agent/src/share/classes/sun/jvm/hotspot/runtime/bsd/BsdSignals.java + agent/src/share/classes/sun/jvm/hotspot/runtime/bsd_amd64/BsdAMD64JavaThreadPDAccess.java + agent/src/share/classes/sun/jvm/hotspot/runtime/bsd_x86/BsdSignals.java + agent/src/share/classes/sun/jvm/hotspot/runtime/bsd_x86/BsdX86JavaThreadPDAccess.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/PlatformInfo.java ! make/Makefile + make/bsd/Makefile + make/bsd/README + make/bsd/adlc_updater + make/bsd/build.sh + make/bsd/makefiles/adjust-mflags.sh + make/bsd/makefiles/adlc.make + make/bsd/makefiles/amd64.make + make/bsd/makefiles/arm.make + make/bsd/makefiles/build_vm_def.sh + make/bsd/makefiles/buildtree.make + make/bsd/makefiles/compiler1.make + make/bsd/makefiles/compiler2.make + make/bsd/makefiles/core.make + make/bsd/makefiles/cscope.make + make/bsd/makefiles/debug.make + make/bsd/makefiles/defs.make + make/bsd/makefiles/dtrace.make + make/bsd/makefiles/fastdebug.make + make/bsd/makefiles/gcc.make + make/bsd/makefiles/hp.make + make/bsd/makefiles/hp1.make + make/bsd/makefiles/i486.make + make/bsd/makefiles/ia64.make + make/bsd/makefiles/jsig.make + make/bsd/makefiles/jvmg.make + make/bsd/makefiles/jvmti.make + make/bsd/makefiles/launcher.make + make/bsd/makefiles/mapfile-vers-debug + make/bsd/makefiles/mapfile-vers-jsig + make/bsd/makefiles/mapfile-vers-product + make/bsd/makefiles/optimized.make + make/bsd/makefiles/ppc.make + make/bsd/makefiles/product.make + make/bsd/makefiles/profiled.make + make/bsd/makefiles/rules.make + make/bsd/makefiles/sa.make + make/bsd/makefiles/saproc.make + make/bsd/makefiles/shark.make + make/bsd/makefiles/sparc.make + make/bsd/makefiles/sparcWorks.make + make/bsd/makefiles/sparcv9.make + make/bsd/makefiles/tiered.make + make/bsd/makefiles/top.make + make/bsd/makefiles/vm.make + make/bsd/makefiles/zero.make + make/bsd/makefiles/zeroshark.make + make/bsd/platform_amd64 + make/bsd/platform_amd64.suncc + make/bsd/platform_i486 + make/bsd/platform_i486.suncc + make/bsd/platform_ia64 + make/bsd/platform_sparc + make/bsd/platform_sparcv9 + make/bsd/platform_zero.in ! make/cscope.make ! make/defs.make ! make/linux/makefiles/arm.make ! make/linux/makefiles/defs.make ! make/linux/makefiles/ppc.make ! make/sa.files ! make/solaris/makefiles/defs.make ! make/windows/makefiles/defs.make ! src/cpu/x86/vm/bytes_x86.hpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/copy_x86.hpp ! src/cpu/x86/vm/globals_x86.hpp ! src/cpu/x86/vm/interp_masm_x86_32.cpp ! src/cpu/x86/vm/interp_masm_x86_64.cpp ! src/cpu/x86/vm/jni_x86.h ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp ! src/cpu/x86/vm/stubRoutines_x86_32.cpp ! src/cpu/x86/vm/stubRoutines_x86_64.cpp ! src/cpu/x86/vm/vm_version_x86.cpp ! src/cpu/zero/vm/bytes_zero.hpp ! src/cpu/zero/vm/globals_zero.hpp ! src/cpu/zero/vm/interp_masm_zero.cpp ! src/cpu/zero/vm/stubGenerator_zero.cpp ! src/cpu/zero/vm/stubRoutines_zero.cpp ! src/cpu/zero/vm/vm_version_zero.cpp + src/os/bsd/vm/attachListener_bsd.cpp + src/os/bsd/vm/c1_globals_bsd.hpp + src/os/bsd/vm/c2_globals_bsd.hpp + src/os/bsd/vm/chaitin_bsd.cpp + src/os/bsd/vm/decoder_bsd.cpp + src/os/bsd/vm/dtraceJSDT_bsd.cpp + src/os/bsd/vm/globals_bsd.hpp + src/os/bsd/vm/interfaceSupport_bsd.hpp + src/os/bsd/vm/jsig.c + src/os/bsd/vm/jvm_bsd.cpp + src/os/bsd/vm/jvm_bsd.h + src/os/bsd/vm/mutex_bsd.cpp + src/os/bsd/vm/mutex_bsd.inline.hpp + src/os/bsd/vm/osThread_bsd.cpp + src/os/bsd/vm/osThread_bsd.hpp + src/os/bsd/vm/os_bsd.cpp + src/os/bsd/vm/os_bsd.hpp + src/os/bsd/vm/os_bsd.inline.hpp + src/os/bsd/vm/os_share_bsd.hpp + src/os/bsd/vm/perfMemory_bsd.cpp + src/os/bsd/vm/stubRoutines_bsd.cpp + src/os/bsd/vm/threadCritical_bsd.cpp + src/os/bsd/vm/thread_bsd.inline.hpp + src/os/bsd/vm/vmError_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/posix/launcher/java_md.c ! src/os/posix/launcher/launcher.script + src/os_cpu/bsd_x86/vm/assembler_bsd_x86.cpp + src/os_cpu/bsd_x86/vm/atomic_bsd_x86.inline.hpp + src/os_cpu/bsd_x86/vm/bsd_x86_32.ad + src/os_cpu/bsd_x86/vm/bsd_x86_32.s + src/os_cpu/bsd_x86/vm/bsd_x86_64.ad + src/os_cpu/bsd_x86/vm/bsd_x86_64.s + src/os_cpu/bsd_x86/vm/bytes_bsd_x86.inline.hpp + src/os_cpu/bsd_x86/vm/copy_bsd_x86.inline.hpp + src/os_cpu/bsd_x86/vm/globals_bsd_x86.hpp + src/os_cpu/bsd_x86/vm/orderAccess_bsd_x86.inline.hpp + src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp + src/os_cpu/bsd_x86/vm/os_bsd_x86.hpp + src/os_cpu/bsd_x86/vm/prefetch_bsd_x86.inline.hpp + src/os_cpu/bsd_x86/vm/threadLS_bsd_x86.cpp + src/os_cpu/bsd_x86/vm/threadLS_bsd_x86.hpp + src/os_cpu/bsd_x86/vm/thread_bsd_x86.cpp + src/os_cpu/bsd_x86/vm/thread_bsd_x86.hpp + src/os_cpu/bsd_x86/vm/vmStructs_bsd_x86.hpp + src/os_cpu/bsd_x86/vm/vm_version_bsd_x86.cpp + src/os_cpu/bsd_zero/vm/assembler_bsd_zero.cpp + src/os_cpu/bsd_zero/vm/atomic_bsd_zero.inline.hpp + src/os_cpu/bsd_zero/vm/bytes_bsd_zero.inline.hpp + src/os_cpu/bsd_zero/vm/globals_bsd_zero.hpp + src/os_cpu/bsd_zero/vm/orderAccess_bsd_zero.inline.hpp + src/os_cpu/bsd_zero/vm/os_bsd_zero.cpp + src/os_cpu/bsd_zero/vm/os_bsd_zero.hpp + src/os_cpu/bsd_zero/vm/prefetch_bsd_zero.inline.hpp + src/os_cpu/bsd_zero/vm/threadLS_bsd_zero.cpp + src/os_cpu/bsd_zero/vm/threadLS_bsd_zero.hpp + src/os_cpu/bsd_zero/vm/thread_bsd_zero.cpp + src/os_cpu/bsd_zero/vm/thread_bsd_zero.hpp + src/os_cpu/bsd_zero/vm/vmStructs_bsd_zero.hpp + src/os_cpu/bsd_zero/vm/vm_version_bsd_zero.cpp ! src/os_cpu/linux_zero/vm/globals_linux_zero.hpp ! src/share/vm/adlc/adlc.hpp ! src/share/vm/c1/c1_globals.hpp ! src/share/vm/classfile/classLoader.cpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/code/stubs.hpp ! src/share/vm/compiler/disassembler.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsAdaptiveSizePolicy.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsCollectorPolicy.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepThread.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/freeBlockDictionary.cpp ! src/share/vm/gc_implementation/g1/dirtyCardQueue.cpp ! src/share/vm/gc_implementation/g1/g1SATBCardTableModRefBS.cpp ! src/share/vm/gc_implementation/g1/ptrQueue.cpp ! src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.cpp ! src/share/vm/gc_implementation/parallelScavenge/psVirtualspace.cpp ! src/share/vm/gc_implementation/shared/mutableNUMASpace.cpp ! src/share/vm/gc_interface/collectedHeap.cpp ! src/share/vm/gc_interface/collectedHeap.inline.hpp ! src/share/vm/interpreter/abstractInterpreter.hpp ! src/share/vm/interpreter/bytecodeInterpreter.cpp ! src/share/vm/interpreter/bytecodeTracer.cpp ! src/share/vm/interpreter/interpreterRuntime.hpp ! src/share/vm/interpreter/linkResolver.cpp ! src/share/vm/memory/allocation.cpp ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/memory/defNewGeneration.cpp ! src/share/vm/memory/gcLocker.hpp ! src/share/vm/memory/genMarkSweep.cpp ! src/share/vm/memory/resourceArea.cpp ! src/share/vm/memory/resourceArea.hpp ! src/share/vm/memory/space.hpp ! src/share/vm/memory/threadLocalAllocBuffer.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/oops/constantPoolKlass.cpp ! src/share/vm/oops/constantPoolOop.cpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/markOop.cpp ! src/share/vm/oops/oop.cpp ! src/share/vm/oops/oopsHierarchy.cpp ! src/share/vm/oops/typeArrayOop.hpp ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/prims/forte.cpp ! src/share/vm/prims/jni.cpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvm.h ! src/share/vm/prims/jvmtiEnv.cpp ! src/share/vm/prims/jvmtiImpl.cpp ! src/share/vm/prims/nativeLookup.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/atomic.cpp ! src/share/vm/runtime/fprofiler.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/handles.cpp ! src/share/vm/runtime/handles.inline.hpp ! src/share/vm/runtime/interfaceSupport.hpp ! src/share/vm/runtime/java.cpp ! src/share/vm/runtime/javaCalls.cpp ! src/share/vm/runtime/javaCalls.hpp ! src/share/vm/runtime/javaFrameAnchor.hpp ! src/share/vm/runtime/jniHandles.cpp ! src/share/vm/runtime/memprofiler.cpp ! src/share/vm/runtime/mutex.cpp ! src/share/vm/runtime/mutexLocker.cpp ! src/share/vm/runtime/mutexLocker.hpp ! src/share/vm/runtime/objectMonitor.cpp ! src/share/vm/runtime/os.cpp ! src/share/vm/runtime/os.hpp ! src/share/vm/runtime/osThread.hpp ! src/share/vm/runtime/safepoint.cpp ! src/share/vm/runtime/synchronizer.cpp ! src/share/vm/runtime/task.cpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/thread.hpp ! src/share/vm/runtime/threadLocalStorage.cpp ! src/share/vm/runtime/threadLocalStorage.hpp ! src/share/vm/runtime/timer.cpp ! src/share/vm/runtime/virtualspace.cpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/runtime/vmThread.cpp ! src/share/vm/runtime/vmThread.hpp ! src/share/vm/runtime/vm_operations.cpp ! src/share/vm/runtime/vm_version.cpp ! src/share/vm/utilities/accessFlags.cpp ! src/share/vm/utilities/array.cpp ! src/share/vm/utilities/bitMap.cpp ! src/share/vm/utilities/debug.cpp ! src/share/vm/utilities/decoder.cpp ! src/share/vm/utilities/decoder.hpp ! src/share/vm/utilities/elfFile.cpp ! src/share/vm/utilities/elfFile.hpp ! src/share/vm/utilities/elfStringTable.cpp ! src/share/vm/utilities/elfStringTable.hpp ! src/share/vm/utilities/elfSymbolTable.cpp ! src/share/vm/utilities/elfSymbolTable.hpp ! src/share/vm/utilities/events.cpp ! src/share/vm/utilities/exceptions.cpp ! src/share/vm/utilities/globalDefinitions.hpp ! src/share/vm/utilities/globalDefinitions_gcc.hpp ! src/share/vm/utilities/globalDefinitions_sparcWorks.hpp ! src/share/vm/utilities/globalDefinitions_visCPP.hpp ! src/share/vm/utilities/growableArray.cpp ! src/share/vm/utilities/histogram.hpp ! src/share/vm/utilities/macros.hpp ! src/share/vm/utilities/ostream.cpp ! src/share/vm/utilities/preserveException.hpp ! src/share/vm/utilities/taskqueue.cpp ! src/share/vm/utilities/taskqueue.hpp ! src/share/vm/utilities/vmError.cpp ! src/share/vm/utilities/workgroup.hpp ! test/Makefile ! test/jprt.config ! test/runtime/6929067/Test6929067.sh Changeset: a92cdbac8b9e Author: kvn Date: 2011-09-26 10:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a92cdbac8b9e 7081933: Use zeroing elimination optimization for large array Summary: Don't zero new typeArray during runtime call if the allocation is followed by arraycopy into it. Reviewed-by: twisti ! src/cpu/sparc/vm/stubGenerator_sparc.cpp ! src/share/vm/gc_interface/collectedHeap.hpp ! src/share/vm/gc_interface/collectedHeap.inline.hpp ! src/share/vm/memory/oopFactory.cpp ! src/share/vm/memory/oopFactory.hpp ! src/share/vm/oops/typeArrayKlass.cpp ! src/share/vm/oops/typeArrayKlass.hpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/memnode.hpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/opto/runtime.hpp Changeset: cb315dc80374 Author: never Date: 2011-09-29 09:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/cb315dc80374 7092278: "jmap -finalizerinfo" throws "sun.jvm.hotspot.utilities.AssertionFailure: invalid cp index 0 137" Reviewed-by: kvn ! agent/src/share/classes/sun/jvm/hotspot/oops/InstanceKlass.java + agent/src/share/classes/sun/jvm/hotspot/runtime/vmSymbols.java ! agent/src/share/classes/sun/jvm/hotspot/tools/jcore/ClassWriter.java ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 098acdf97f09 Author: never Date: 2011-09-29 13:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/098acdf97f09 7096016: SA build still produces "arg list too long" errors Reviewed-by: kvn, never Contributed-by: volker.simonis at gmail.com ! make/linux/makefiles/sa.make ! make/sa.files ! make/solaris/makefiles/sa.make ! make/windows/makefiles/sa.make Changeset: dc45ae774613 Author: iveresov Date: 2011-09-29 23:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/dc45ae774613 7096639: Tiered: Incorrect counter overflow handling for inlined methods Summary: Enable invocation events for inlinees Reviewed-by: kvn ! src/share/vm/c1/c1_LIRGenerator.cpp ! src/share/vm/runtime/globals.hpp Changeset: ae839d1e7d4c Author: roland Date: 2011-09-30 13:47 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ae839d1e7d4c 7096010: c2: running with +PrintOptoAssembly crashes the VM when $constanttablebase is used Summary: ADLC generates code to prepare the register string to be printed in a char array but then calls print without the char array as an argument. Reviewed-by: never ! src/share/vm/adlc/formssel.cpp Changeset: 5d871c1ff17c Author: iveresov Date: 2011-09-30 13:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5d871c1ff17c Merge ! make/Makefile ! make/linux/makefiles/defs.make ! make/solaris/makefiles/defs.make ! src/os/linux/vm/os_linux.cpp Changeset: da883b9e6d37 Author: jcoomes Date: 2011-09-30 18:27 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/da883b9e6d37 Merge ! .hgtags - agent/src/os/solaris/dbx/Makefile - agent/src/os/solaris/dbx/README - agent/src/os/solaris/dbx/README-commands.txt - agent/src/os/solaris/dbx/helloWorld.cpp - agent/src/os/solaris/dbx/proc_service_2.h - agent/src/os/solaris/dbx/shell_imp.h - agent/src/os/solaris/dbx/svc_agent_dbx.cpp - agent/src/os/solaris/dbx/svc_agent_dbx.hpp - agent/src/os/win32/BasicList.hpp - agent/src/os/win32/Buffer.cpp - agent/src/os/win32/Buffer.hpp - agent/src/os/win32/Dispatcher.cpp - agent/src/os/win32/Dispatcher.hpp - agent/src/os/win32/Handler.hpp - agent/src/os/win32/IOBuf.cpp - agent/src/os/win32/IOBuf.hpp - agent/src/os/win32/LockableList.hpp - agent/src/os/win32/Makefile - agent/src/os/win32/Message.hpp - agent/src/os/win32/Monitor.cpp - agent/src/os/win32/Monitor.hpp - agent/src/os/win32/README-commands.txt - agent/src/os/win32/README.txt - agent/src/os/win32/Reaper.cpp - agent/src/os/win32/Reaper.hpp - agent/src/os/win32/SwDbgSrv.cpp - agent/src/os/win32/SwDbgSrv.dsp - agent/src/os/win32/SwDbgSrv.dsw - agent/src/os/win32/SwDbgSub.cpp - agent/src/os/win32/SwDbgSub.dsp - agent/src/os/win32/initWinsock.cpp - agent/src/os/win32/initWinsock.hpp - agent/src/os/win32/ioUtils.cpp - agent/src/os/win32/ioUtils.hpp - agent/src/os/win32/isNT4.cpp - agent/src/os/win32/isNT4.hpp - agent/src/os/win32/libInfo.cpp - agent/src/os/win32/libInfo.hpp - agent/src/os/win32/nt4internals.cpp - agent/src/os/win32/nt4internals.hpp - agent/src/os/win32/ports.h - agent/src/os/win32/procList.cpp - agent/src/os/win32/procList.hpp - agent/src/os/win32/serverLists.cpp - agent/src/os/win32/serverLists.hpp - agent/src/os/win32/toolHelp.cpp - agent/src/os/win32/toolHelp.hpp - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/DbxAddress.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/DbxDebugger.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/DbxDebuggerLocal.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/DbxOopHandle.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/DbxThreadFactory.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/sparc/DbxSPARCThread.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/sparc/DbxSPARCThreadContext.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/sparc/DbxSPARCThreadFactory.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/x86/DbxX86Thread.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/x86/DbxX86ThreadContext.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/x86/DbxX86ThreadFactory.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/AddressDataSource.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/DLL.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/TestDebugger.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/TestHelloWorld.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32Address.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32CDebugInfoBuilder.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32CDebugger.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32Debugger.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32DebuggerLocal.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32LDTEntry.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32LDTEntryConstants.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32OopHandle.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32Thread.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32ThreadContext.java - agent/src/share/classes/sun/jvm/hotspot/runtime/amd64/AMD64Frame.java - agent/src/share/classes/sun/jvm/hotspot/runtime/amd64/AMD64RegisterMap.java - make/solaris/makefiles/mapfile-vers-nonproduct - src/share/vm/runtime/reflectionCompat.hpp Changeset: 49ed7eacfd16 Author: jcoomes Date: 2011-09-30 18:27 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/49ed7eacfd16 Added tag hs23-b01 for changeset da883b9e6d37 ! .hgtags Changeset: 7c20d272643f Author: katleman Date: 2011-10-06 14:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7c20d272643f Added tag jdk8-b08 for changeset 49ed7eacfd16 ! .hgtags Changeset: edd5f85e2de7 Author: katleman Date: 2011-10-13 10:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/edd5f85e2de7 Added tag jdk8-b09 for changeset 7c20d272643f ! .hgtags Changeset: 95607b70acb5 Author: jcoomes Date: 2011-09-30 22:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/95607b70acb5 7096124: Bump the hs23 build number to 02 Reviewed-by: johnc Contributed-by: alejandro.murillo at oracle.com ! make/hotspot_version Changeset: 4f93f0d00802 Author: tonyp Date: 2011-09-20 09:59 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/4f93f0d00802 7059019: G1: add G1 support to the SA Summary: Extend the SA to recognize the G1CollectedHeap and implement any code that's needed by our serviceability tools (jmap, jinfo, jstack, etc.) that depend on the SA. Reviewed-by: never, poonam, johnc ! agent/make/Makefile + agent/src/share/classes/sun/jvm/hotspot/gc_implementation/g1/G1CollectedHeap.java + agent/src/share/classes/sun/jvm/hotspot/gc_implementation/g1/HeapRegion.java + agent/src/share/classes/sun/jvm/hotspot/gc_implementation/g1/HeapRegionSeq.java ! agent/src/share/classes/sun/jvm/hotspot/gc_interface/CollectedHeapName.java ! agent/src/share/classes/sun/jvm/hotspot/memory/Universe.java ! agent/src/share/classes/sun/jvm/hotspot/oops/ObjectHeap.java ! agent/src/share/classes/sun/jvm/hotspot/tools/HeapSummary.java ! make/sa.files ! src/share/vm/gc_implementation/g1/heapRegionSeq.hpp + src/share/vm/gc_implementation/g1/vmStructs_g1.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 663cb89032b1 Author: johnc Date: 2011-09-20 15:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/663cb89032b1 7092412: G1: Some roots not marked during an initial mark that gets an evacuation failure Summary: As a result of the changes for 7080389, an evacuation failure during an initial mark pause may result in some root objects not being marked. Pass whether the caller is a root scanning closure into the evacuation failure handling code so that the thread that successfully forwards an object to itself also marks the object. Reviewed-by: ysr, brutisso, tonyp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1OopClosures.hpp Changeset: 114e52976463 Author: tonyp Date: 2011-09-21 01:27 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/114e52976463 7045232: G1: pool names are inconsistent with other collectors (don't have 'Space') Summary: Make sure the eden and survivor pools have "Space" in their name. Reviewed-by: jmasa, ysr ! src/share/vm/services/g1MemoryPool.cpp Changeset: 1847b501ae74 Author: johnc Date: 2011-09-21 10:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1847b501ae74 7068215: G1: Print reference processing time during remark Summary: Displays the elapsed time taken to perform reference processing during remark as part of the PrintGCDetails output. Reviewed-by: ysr ! src/share/vm/gc_implementation/g1/concurrentMark.cpp Changeset: d912b598c6c3 Author: tonyp Date: 2011-09-21 13:36 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d912b598c6c3 7091032: G1: assert failure when NewRatio is used Summary: The desired min / max heap sizes are miscalculated at initialization when NewRatio is used. The changeset also includes an additional small change to turn a print statement into a warning. Reviewed-by: johnc, jmasa, ysr, brutisso ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp Changeset: 5cc33133bc6d Author: johnc Date: 2011-09-21 15:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5cc33133bc6d 7092245: G1: Wrong format specifier in G1PrintRegionLivenessInfo header output Summary: Cast HeapRegion::GrainBytes to size_t in output statement. Reviewed-by: ysr, brutisso, pbk, tonyp ! src/share/vm/gc_implementation/g1/concurrentMark.cpp Changeset: f0ecbe78fc7b Author: tonyp Date: 2011-09-22 07:18 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f0ecbe78fc7b 7092238: G1: Uninitialized field gc_efficiency in G1PrintRegionLivenessInfo output Reviewed-by: jcoomes, johnc ! src/share/vm/gc_implementation/g1/heapRegion.cpp Changeset: 4dfb2df418f2 Author: johnc Date: 2011-09-22 10:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/4dfb2df418f2 6484982: G1: process references during evacuation pauses Summary: G1 now uses two reference processors - one is used by concurrent marking and the other is used by STW GCs (both full and incremental evacuation pauses). In an evacuation pause, the reference processor is embedded into the closures used to scan objects. Doing so causes causes reference objects to be 'discovered' by the reference processor. At the end of the evacuation pause, these discovered reference objects are processed - preserving (and copying) referent objects (and their reachable graphs) as appropriate. Reviewed-by: ysr, jwilhelm, brutisso, stefank, tonyp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/gc_implementation/g1/g1MarkSweep.cpp ! src/share/vm/gc_implementation/g1/g1OopClosures.hpp ! src/share/vm/gc_implementation/g1/g1RemSet.cpp ! src/share/vm/gc_implementation/g1/heapRegion.cpp ! src/share/vm/gc_implementation/g1/heapRegion.hpp ! src/share/vm/gc_implementation/g1/satbQueue.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/referenceProcessor.cpp ! src/share/vm/memory/referenceProcessor.hpp ! src/share/vm/runtime/thread.cpp Changeset: 8229bd737950 Author: tonyp Date: 2011-09-23 16:07 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8229bd737950 7075646: G1: fix inconsistencies in the monitoring data Summary: Fixed a few inconsistencies in the monitoring data, in particular when reported from jstat. Reviewed-by: jmasa, brutisso, johnc ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/gc_implementation/g1/g1MonitoringSupport.cpp ! src/share/vm/gc_implementation/g1/g1MonitoringSupport.hpp ! src/share/vm/gc_implementation/g1/heapRegion.hpp ! src/share/vm/gc_implementation/shared/generationCounters.cpp ! src/share/vm/gc_implementation/shared/generationCounters.hpp ! src/share/vm/services/g1MemoryPool.cpp ! src/share/vm/services/g1MemoryPool.hpp Changeset: e807478bf9ca Author: brutisso Date: 2011-09-26 10:14 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e807478bf9ca 7091366: re-enable quicksort tests Summary: Added extern "C" to make it build with JDK6 compilers Reviewed-by: jwilhelm, kvn ! src/share/vm/utilities/quickSort.cpp Changeset: 273b46400613 Author: johnc Date: 2011-09-28 10:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/273b46400613 7086533: G1: assert(!_g1->is_obj_dead(obj)): We should not be preserving dead objs: g1CollectedHeap.cpp:3835 Summary: Some objects may not be marked in the event of an evacuation failure in a partially young GC, during a marking cycle. Avoid this situation by not allowing partially young GCs during a marking cycle. Reviewed-by: tonyp, ysr, brutisso ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp Changeset: 811ec3d0833b Author: johnc Date: 2011-10-03 12:49 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/811ec3d0833b 7097053: G1: assert(da ? referent->is_oop() : referent->is_oop_or_null()) failed: referenceProcessor.cpp:1054 Summary: During remembered set scanning, the reference processor could discover a reference object whose referent was in the process of being copied and so may not be completely initialized. Do not perform reference discovery during remembered set scanning. Reviewed-by: tonyp, ysr ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1OopClosures.hpp ! src/share/vm/gc_implementation/g1/g1RemSet.cpp ! src/share/vm/gc_implementation/g1/heapRegion.cpp Changeset: 81aa07130d30 Author: tonyp Date: 2011-10-03 19:04 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/81aa07130d30 7097048: G1: extend the G1 SA changes to print per-heap space information Reviewed-by: brutisso, johnc ! agent/src/share/classes/sun/jvm/hotspot/gc_implementation/g1/G1CollectedHeap.java + agent/src/share/classes/sun/jvm/hotspot/gc_implementation/g1/G1MonitoringSupport.java ! agent/src/share/classes/sun/jvm/hotspot/tools/HeapSummary.java ! src/share/vm/gc_implementation/g1/g1MonitoringSupport.hpp ! src/share/vm/gc_implementation/g1/vmStructs_g1.hpp Changeset: c63b928b212b Author: stefank Date: 2011-09-12 16:09 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c63b928b212b 7021322: assert(object_end <= top()) failed: Object crosses promotion LAB boundary Summary: Pass the same object size value to both allocate and unallocate_object Reviewed-by: ysr, brutisso ! src/share/vm/gc_implementation/parallelScavenge/psPromotionLAB.cpp ! src/share/vm/gc_implementation/parallelScavenge/psPromotionLAB.hpp ! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.cpp Changeset: 65a8ff39a6da Author: johnc Date: 2011-10-05 08:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/65a8ff39a6da 7095194: G1: HeapRegion::GrainBytes, GrainWords, and CardsPerRegion should be size_t Summary: Declare GrainBytes, GrainWords, and CardsPerRegion as size_t. Reviewed-by: jcoomes, tonyp, jmasa ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/heapRegion.cpp ! src/share/vm/gc_implementation/g1/heapRegion.hpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.hpp ! src/share/vm/gc_implementation/g1/vmStructs_g1.hpp Changeset: fd65bc7c09b6 Author: tonyp Date: 2011-10-06 13:28 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/fd65bc7c09b6 Merge ! agent/make/Makefile ! make/sa.files ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 246daf2c601d Author: brutisso Date: 2011-09-28 08:21 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/246daf2c601d 7005808: G1: re-enable ReduceInitialCardMarks for G1 Summary: Remove the extra guard to allow G1 to use ReduceInitialCardMarks Reviewed-by: jmasa, tonyp, johnc, ysr ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1_globals.hpp Changeset: b9390528617c Author: ysr Date: 2011-10-06 18:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b9390528617c 7095236: G1: _markedRegions never contains NULL regions Summary: Removed the code for skipping over NULL regions in _markedRegions, replacing it with an assertion that a NULL region is never encountered; removed dead methods, remove() and remove_region(), and inlined a simplified addRegion() directly into fillCache(). Reviewed-by: brutisso, tonyp ! src/share/vm/gc_implementation/g1/collectionSetChooser.cpp ! src/share/vm/gc_implementation/g1/collectionSetChooser.hpp Changeset: f32dae5d5677 Author: ysr Date: 2011-10-10 08:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f32dae5d5677 Merge Changeset: 3f24f946bc2d Author: brutisso Date: 2011-10-11 10:21 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3f24f946bc2d 7099454: /bin/sh does not support syntax used in the src/os/posix/launcher/launcher.script shell script Summary: Also reviewed by mikael.gerdin at oracle.com; Changed to the `` syntax instead. Also changed "source" to ".". Reviewed-by: never, stefank, dsamersoff, rottenha ! src/os/posix/launcher/launcher.script Changeset: d1bdeef3e3e2 Author: johnc Date: 2011-10-12 10:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d1bdeef3e3e2 7098282: G1: assert(interval >= 0) failed: Sanity check, referencePolicy.cpp: 76 Summary: There is a race between one thread successfully forwarding and copying the klass mirror for the SoftReference class (including the static master clock) and another thread attempting to use the master clock while attempting to discover a soft reference object. Maintain a shadow copy of the soft reference master clock and use the shadow during reference discovery and reference processing. Reviewed-by: tonyp, brutisso, ysr ! src/share/vm/memory/referencePolicy.cpp ! src/share/vm/memory/referencePolicy.hpp ! src/share/vm/memory/referenceProcessor.cpp ! src/share/vm/memory/referenceProcessor.hpp Changeset: e4f412d2b75d Author: jcoomes Date: 2011-10-14 18:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e4f412d2b75d Merge ! .hgtags Changeset: d815de2e85e5 Author: jcoomes Date: 2011-10-14 18:21 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d815de2e85e5 Added tag hs23-b02 for changeset e4f412d2b75d ! .hgtags Changeset: 3170e4044f2d Author: katleman Date: 2011-10-20 10:32 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3170e4044f2d Added tag jdk8-b10 for changeset d815de2e85e5 ! .hgtags From lana.steuck at oracle.com Wed Oct 26 12:54:40 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 26 Oct 2011 19:54:40 +0000 Subject: hg: jdk8/tl/jdk: 29 new changesets Message-ID: <20111026195933.C1B544713F@hg.openjdk.java.net> Changeset: 19f0a3db863c Author: katleman Date: 2011-09-22 16:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/19f0a3db863c Added tag jdk8-b06 for changeset bdb870cc269e ! .hgtags Changeset: ac9349be6821 Author: katleman Date: 2011-09-29 18:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ac9349be6821 Added tag jdk8-b07 for changeset 19f0a3db863c ! .hgtags Changeset: b92341e9ae56 Author: bae Date: 2011-09-19 05:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b92341e9ae56 7088287: libpng need to be updated. Reviewed-by: jgodinez, prr ! src/share/native/sun/awt/libpng/CHANGES ! src/share/native/sun/awt/libpng/LICENSE ! src/share/native/sun/awt/libpng/README ! src/share/native/sun/awt/libpng/png.c ! src/share/native/sun/awt/libpng/png.h ! src/share/native/sun/awt/libpng/pngconf.h + src/share/native/sun/awt/libpng/pngdebug.h ! src/share/native/sun/awt/libpng/pngerror.c - src/share/native/sun/awt/libpng/pnggccrd.c ! src/share/native/sun/awt/libpng/pngget.c + src/share/native/sun/awt/libpng/pnginfo.h + src/share/native/sun/awt/libpng/pnglibconf.h ! src/share/native/sun/awt/libpng/pngmem.c ! src/share/native/sun/awt/libpng/pngpread.c + src/share/native/sun/awt/libpng/pngpriv.h ! src/share/native/sun/awt/libpng/pngread.c ! src/share/native/sun/awt/libpng/pngrio.c ! src/share/native/sun/awt/libpng/pngrtran.c ! src/share/native/sun/awt/libpng/pngrutil.c ! src/share/native/sun/awt/libpng/pngset.c + src/share/native/sun/awt/libpng/pngstruct.h ! src/share/native/sun/awt/libpng/pngtest.c ! src/share/native/sun/awt/libpng/pngtrans.c - src/share/native/sun/awt/libpng/pngvcrd.c ! src/share/native/sun/awt/libpng/pngwio.c ! src/share/native/sun/awt/libpng/pngwrite.c ! src/share/native/sun/awt/libpng/pngwtran.c ! src/share/native/sun/awt/libpng/pngwutil.c ! src/share/native/sun/awt/splashscreen/splashscreen_png.c Changeset: bbf4e1faf859 Author: lana Date: 2011-09-23 16:50 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bbf4e1faf859 Merge Changeset: c662c8cf25d6 Author: lana Date: 2011-09-26 14:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c662c8cf25d6 Merge - src/share/native/sun/awt/libpng/pnggccrd.c - src/share/native/sun/awt/libpng/pngvcrd.c Changeset: 3487d0d48662 Author: rupashka Date: 2011-09-15 16:43 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3487d0d48662 7090007: Missing style.css in nimbus/doc-files/properties.html Reviewed-by: alexp ! src/share/classes/javax/swing/plaf/nimbus/doc-files/properties.html Changeset: 16c3dcad4252 Author: rupashka Date: 2011-09-21 17:08 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/16c3dcad4252 7032018: The file list in JFileChooser does not have an accessible name Reviewed-by: rupashka Contributed-by: Charles Lee ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_de.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_es.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_fr.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_it.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_ja.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_ko.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_pt_BR.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_sv.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_zh_CN.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_zh_TW.properties ! src/share/classes/sun/swing/FilePane.java Changeset: 44040ece133c Author: lana Date: 2011-09-23 16:51 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/44040ece133c Merge Changeset: 44f50834b79c Author: rupashka Date: 2011-09-26 17:37 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/44f50834b79c 7088744: SwingUtilities.isMiddleMouseButton does not work with ALT/Meta keys Reviewed-by: alexp ! src/share/classes/javax/swing/SwingUtilities.java + test/javax/swing/SwingUtilities/7088744/bug7088744.java Changeset: d72ac458b2b7 Author: anthony Date: 2011-09-26 17:59 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d72ac458b2b7 7081670: Disposing an AppContext can lead to a spinning EventDispatchThread Reviewed-by: art, anthony, dholmes Contributed-by: Clemens Eisserer ! src/share/classes/java/awt/EventDispatchThread.java ! src/share/classes/java/awt/EventQueue.java Changeset: 7fd192952459 Author: denis Date: 2011-09-26 18:18 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7fd192952459 7080289: AWTKeystroke class registers a subclass factory during deserialization Reviewed-by: serb ! src/share/classes/java/awt/AWTKeyStroke.java Changeset: aac4041609bb Author: lana Date: 2011-09-26 14:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/aac4041609bb Merge Changeset: 1c825eac6c04 Author: lana Date: 2011-09-26 14:32 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1c825eac6c04 Merge - src/share/classes/java/util/XMLUtils.java - src/share/classes/sun/tools/jar/JarImageSource.java Changeset: f38b39ed9ed0 Author: lana Date: 2011-10-03 18:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f38b39ed9ed0 Merge - src/share/classes/java/util/XMLUtils.java - src/share/classes/sun/tools/jar/JarImageSource.java - src/share/native/sun/awt/libpng/pnggccrd.c - src/share/native/sun/awt/libpng/pngvcrd.c Changeset: 3b59f4bc8046 Author: never Date: 2011-09-07 21:05 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3b59f4bc8046 7082631: JSR 292: need profiling support in GWTs Summary: add CountingMethodHandle Reviewed-by: twisti, jrose ! src/share/classes/java/lang/invoke/AdapterMethodHandle.java + src/share/classes/java/lang/invoke/CountingMethodHandle.java ! src/share/classes/java/lang/invoke/MethodHandleImpl.java ! src/share/classes/java/lang/invoke/MethodHandleNatives.java Changeset: 7b9a0c75f5d9 Author: jcoomes Date: 2011-09-30 17:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7b9a0c75f5d9 Merge Changeset: 1c023bcd0c5a Author: jcoomes Date: 2011-10-04 12:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1c023bcd0c5a Merge - src/share/classes/java/util/XMLUtils.java - src/share/classes/sun/tools/jar/JarImageSource.java - src/share/native/sun/awt/libpng/pnggccrd.c - src/share/native/sun/awt/libpng/pngvcrd.c Changeset: f1ec21b81421 Author: katleman Date: 2011-10-06 14:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f1ec21b81421 Added tag jdk8-b08 for changeset 1c023bcd0c5a ! .hgtags Changeset: 7539cc99befe Author: katleman Date: 2011-10-13 10:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7539cc99befe Added tag jdk8-b09 for changeset f1ec21b81421 ! .hgtags Changeset: 1be72d104f9b Author: dbuck Date: 2011-09-26 15:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1be72d104f9b 7029903: Splash screen is not shown in 64-bit Linux with 16-bit color depth Summary: Added Xflush() call after splash screen is updated to ensure update is no stuck in client side buffer until JVM starts up. See JET review request 4154 for details. Reviewed-by: kevinw, anthony ! src/solaris/native/sun/awt/splashscreen/splashscreen_sys.c Changeset: cfe25bac6951 Author: bagiras Date: 2011-09-27 13:38 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cfe25bac6951 7073337: Crash after playing Java game on Pogo Reviewed-by: art, uta ! src/windows/classes/sun/awt/windows/WComponentPeer.java ! src/windows/native/sun/windows/awt_Component.cpp ! src/windows/native/sun/windows/awt_Component.h ! src/windows/native/sun/windows/awt_Toolkit.cpp ! src/windows/native/sun/windows/awt_Toolkit.h Changeset: fcdb588d77ef Author: rupashka Date: 2011-10-05 18:21 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fcdb588d77ef 7072167: The "root" field in BufferStrategyPaintManager leaks memory Reviewed-by: alexp ! src/share/classes/javax/swing/BufferStrategyPaintManager.java Changeset: 98901d41e1e2 Author: rupashka Date: 2011-10-11 15:22 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/98901d41e1e2 7076791: closed/javax/swing/JColorChooser/Test6827032.java failed on windows Reviewed-by: rupashka Contributed-by: alexandr.scherbatiy at oracle.com + test/javax/swing/JColorChooser/Test6827032.java ! test/javax/swing/regtesthelpers/Util.java Changeset: 58190ab77d2e Author: lana Date: 2011-10-12 12:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/58190ab77d2e Merge Changeset: eac5d48a6c8e Author: lana Date: 2011-10-12 12:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/eac5d48a6c8e Merge Changeset: 4788745572ef Author: lana Date: 2011-10-17 19:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4788745572ef Merge Changeset: 7ab0d613cd1a Author: katleman Date: 2011-10-20 10:32 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7ab0d613cd1a Added tag jdk8-b10 for changeset 4788745572ef ! .hgtags Changeset: 291b55aa9b1e Author: lana Date: 2011-10-25 10:51 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/291b55aa9b1e Merge - src/share/native/sun/awt/libpng/pnggccrd.c - src/share/native/sun/awt/libpng/pngvcrd.c Changeset: 64faf533b99d Author: lana Date: 2011-10-26 12:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/64faf533b99d Merge From weijun.wang at oracle.com Thu Oct 27 02:24:28 2011 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Thu, 27 Oct 2011 09:24:28 +0000 Subject: hg: jdk8/tl/jdk: 7104161: test/sun/tools/jinfo/Basic.sh fails on Ubuntu Message-ID: <20111027092454.1A76D47164@hg.openjdk.java.net> Changeset: 449113aea001 Author: weijun Date: 2011-10-27 17:23 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/449113aea001 7104161: test/sun/tools/jinfo/Basic.sh fails on Ubuntu Reviewed-by: alanb ! test/sun/tools/jinfo/Basic.sh From sean.coffey at oracle.com Thu Oct 27 02:31:50 2011 From: sean.coffey at oracle.com (sean.coffey at oracle.com) Date: Thu, 27 Oct 2011 09:31:50 +0000 Subject: hg: jdk8/tl/jdk: 7099658: Properties.loadFromXML fails with ClassCastException Message-ID: <20111027093201.0187E47165@hg.openjdk.java.net> Changeset: 64ccf18bbad5 Author: coffeys Date: 2011-10-27 10:32 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/64ccf18bbad5 7099658: Properties.loadFromXML fails with ClassCastException Reviewed-by: alanb, mchung ! src/share/classes/sun/util/xml/XMLUtils.java From sean.mullan at oracle.com Thu Oct 27 08:17:37 2011 From: sean.mullan at oracle.com (sean.mullan at oracle.com) Date: Thu, 27 Oct 2011 15:17:37 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20111027151832.25C2A4716A@hg.openjdk.java.net> Changeset: 56cc907fc8dc Author: mullan Date: 2011-10-27 10:57 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/56cc907fc8dc 7094155: JSR105 code throws javax.xml.crypto.URIReferenceException when running into Java 7 VM Reviewed-by: xuelei ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/IdResolver.java ! test/javax/xml/crypto/dsig/GenerationTests.java Changeset: 8cd2e3b8127a Author: mullan Date: 2011-10-27 11:01 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8cd2e3b8127a Merge - make/sun/rmi/rmi/mapfile-vers - src/share/native/sun/awt/libpng/pnggccrd.c - src/share/native/sun/awt/libpng/pngvcrd.c - src/share/native/sun/rmi/server/MarshalInputStream.c From xuelei.fan at oracle.com Fri Oct 28 07:20:32 2011 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Fri, 28 Oct 2011 14:20:32 +0000 Subject: hg: jdk8/tl/jdk: 7105940: Test regression: KeyStore must be from provider SunPKCS11-NSSKeyStore Message-ID: <20111028142059.6EA9B471B2@hg.openjdk.java.net> Changeset: 6e59c482e9b8 Author: xuelei Date: 2011-10-28 07:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6e59c482e9b8 7105940: Test regression: KeyStore must be from provider SunPKCS11-NSSKeyStore Reviewed-by: weijun ! test/sun/security/pkcs11/fips/CipherTest.java ! test/sun/security/pkcs11/fips/ClientJSSEServerJSSE.java From alan.bateman at oracle.com Sun Oct 30 08:04:17 2011 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Sun, 30 Oct 2011 15:04:17 +0000 Subject: hg: jdk8/tl/jdk: 7103889: (fs) Reduce String concatenation when iterating over directory Message-ID: <20111030150450.0B091471D3@hg.openjdk.java.net> Changeset: bb2b9a8b6e77 Author: alanb Date: 2011-10-30 14:53 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bb2b9a8b6e77 7103889: (fs) Reduce String concatenation when iterating over directory Reviewed-by: alanb Contributed-by: mike.skells at talk21.com ! src/share/classes/java/nio/file/Files.java ! src/windows/classes/sun/nio/fs/WindowsDirectoryStream.java ! src/windows/classes/sun/nio/fs/WindowsPathParser.java From typoon at gmail.com Sun Oct 30 16:38:14 2011 From: typoon at gmail.com (Henrique M. Decaria) Date: Sun, 30 Oct 2011 21:38:14 -0200 Subject: Strange behaviour in .class "endianess" Message-ID: Good evening, I am not sure if this is the right mailing list to ask this question, but I was unable to find a more appropriate one. If there is one, please let me know and I will ask this question there. I am working on parsing a .class file (decompiling it), and am facing a problem that I cannot explain at all. Consider the following code: public class Ex1 { static public void main(String [] args) { int i = 99; long l = 20; System.out.println("Hi!" + i + " long = " + l); } } The compiled file of this code, when decompiled, shows a strange behaviour. The constant pool count for this code is 50. I can populate the whole constant pool struct without any problems. The problem starts in the bytes that follow the constant pool. Those bytes will be in 'little endian' form instead of big-endian. If I add one more long variable to that code, then everything works as expected (the data after the constant pool goes back to being big endian). I know this might sound really strange and ilogical, but I really cannot find any explanation to that. Here is the ClassFile struct I am using typedef struct _ClassFile { u4 magic; u2 minor_version; u2 major_version; u2 constant_pool_count; cp_info *constant_pool; //[constant_pool_count-1]; u2 access_flags; u2 this_class; u2 super_class; u2 interfaces_count; u2 *interfaces; //[interfaces_count]; u2 fields_count; field_info *fields; //[fields_count]; u2 methods_count; method_info *methods; //[methods_count]; u2 attributes_count; attribute_info *attributes; //[attributes_count]; } ClassFile; And the cp_info struct typedef struct _cp_info { u1 tag; union { Class_info ci; Fieldref_info fri; Methodref_info mri; InterfaceMethodref_info imri; String_info si; Integer_info ii; Float_info fi; Long_info li; Double_info di; NameAndType_info nti; Utf8_info utfi; }; } cp_info; All the structs in the cp_info struct are pretty much as described here http://java.sun.com/docs/books/jvms/second_edition/html/ClassFile.doc.html The part of the code resposible for reading LONGs and DOUBLEs is as follows: switch(tag) { case CONSTANT_LONG: debug(DBG_WARN, "Found long at index %d\n", index); fread(&tmpu4, 1, sizeof(tmpu4), f); cf->constant_pool[index].li.high_bytes = btoli(tmpu4); cf->constant_pool[index+1].li.high_bytes = btoli(tmpu4); fread(&tmpu4, 1, sizeof(tmpu4), f); cf->constant_pool[index].li.low_bytes = btoli(tmpu4); cf->constant_pool[index+1].li.low_bytes = btoli(tmpu4); ++index; break; case CONSTANT_DOUBLE: debug(DBG_WARN, "Found long at index %d\n", index); fread(&tmpu4, 1, sizeof(tmpu4), f); cf->constant_pool[index].di.high_bytes = btoli(tmpu4); cf->constant_pool[index+1].di.high_bytes = btoli(tmpu4); fread(&tmpu4, 1, sizeof(tmpu4), f); cf->constant_pool[index].di.low_bytes = btoli(tmpu4); cf->constant_pool[index+1].di.low_bytes = btoli(tmpu4); ++index; break; } The btoli function simply converts from big endian to little endian (a swap_endian_integer name would have been more appropriate, i know). Has anyone seem such behaviour, or have any explanation to what I could be doing incorrectly? Thanks a lot for your time and help :) Henrique -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20111030/c0afd725/attachment.html From xuelei.fan at oracle.com Sun Oct 30 20:09:13 2011 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Mon, 31 Oct 2011 03:09:13 +0000 Subject: hg: jdk8/tl/jdk: 7106277: Brokenness in the seqNumberOverflow of MAC Message-ID: <20111031030931.47B4A471D4@hg.openjdk.java.net> Changeset: 30900a1a9cfc Author: xuelei Date: 2011-10-30 20:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/30900a1a9cfc 7106277: Brokenness in the seqNumberOverflow of MAC Reviewed-by: wetmore ! src/share/classes/sun/security/ssl/MAC.java From bradford.wetmore at oracle.com Mon Oct 31 11:55:37 2011 From: bradford.wetmore at oracle.com (bradford.wetmore at oracle.com) Date: Mon, 31 Oct 2011 18:55:37 +0000 Subject: hg: jdk8/tl/jdk: 7105780: Add SSLSocket client/SSLEngine server to templates directory Message-ID: <20111031185547.7C43D471DB@hg.openjdk.java.net> Changeset: 8681362a2f04 Author: wetmore Date: 2011-10-31 11:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8681362a2f04 7105780: Add SSLSocket client/SSLEngine server to templates directory Reviewed-by: xuelei + test/sun/security/ssl/templates/SSLSocketSSLEngineTemplate.java From bradford.wetmore at oracle.com Mon Oct 31 16:24:50 2011 From: bradford.wetmore at oracle.com (bradford.wetmore at oracle.com) Date: Mon, 31 Oct 2011 23:24:50 +0000 Subject: hg: jdk8/tl/jdk: 7053252: New regression test does not compile on windows-amd64 Message-ID: <20111031232500.1E7B1471E7@hg.openjdk.java.net> Changeset: b60e88ef5d8d Author: wetmore Date: 2011-10-31 16:23 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b60e88ef5d8d 7053252: New regression test does not compile on windows-amd64 Reviewed-by: valeriep ! test/ProblemList.txt ! test/sun/security/pkcs11/Provider/Absolute.java From y.s.ramakrishna at oracle.com Mon Oct 31 17:40:01 2011 From: y.s.ramakrishna at oracle.com (y.s.ramakrishna at oracle.com) Date: Tue, 01 Nov 2011 00:40:01 +0000 Subject: hg: jdk8/tl/jdk: 4243978: (ref) Race condition in Reference.enqueue(); ... Message-ID: <20111101004012.908EC471E8@hg.openjdk.java.net> Changeset: 5f2838744544 Author: ysr Date: 2011-10-31 17:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5f2838744544 4243978: (ref) Race condition in Reference.enqueue() 4268317: (ref) Reference.isEnqueued() can return true when instance not enqueued Summary: The reference handler now declares, and assumes, that the discovered field, rather than the next field, is (to be) used to link the entries in the pending list, thus allowing a reference object to be safely enqueued even while it is in the pending state. Also added slightly modified regression tests from the two bug reports. Reviewed-by: mchung, alanb, jcoomes ! src/share/classes/java/lang/ref/Reference.java ! src/share/javavm/export/jvm.h ! src/share/native/common/jdk_util.c + test/java/lang/ref/ReferenceEnqueue.java + test/java/lang/ref/ReferenceEnqueuePending.java