Code review request: 7086586 Inference producing null type argument

[Jonathan Gibbons]

On 10/06/2011 05:34 AM, Maurizio Cimadamore wrote:
> On 06/10/11 10:47, Maurizio Cimadamore wrote:
>> On 06/10/11 10:38, Dmeetry Degrave wrote:
>>>
>>> hi,
>>>
>>> i'm looking for a code review for 7086586 fix for 7u4. It implements 
>>> fix suggested by Maurizio for problem 2 from evaluation.
>>>
>>> bug description: http://bugs.sun.com/view_bug.do?bug_id=7086586
>>> jdk7 evaluation: http://bugs.sun.com/view_bug.do?bug_id=2213800
>>>
>>> webrev: http://cr.openjdk.java.net/~dmeetry/7086586/webrev.00/
>>>
>>> thanks,
>>> dmeetry
>> Approved
>>
>> Maurizio
> Remi has suggested to use 'static final' on botFilter. I'd be ok with 
> final, less ok with 'static' if no other reason than for consistencies 
> with similar declarations in Infer.java. Remi what do you think?
>
> Maurizio

Since botFilter is a private member of a javac internal class, we should 
not be optimizing the code for external use.

-- Jon