From xueming.shen at oracle.com Sat Dec 1 11:35:44 2012 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Sat, 01 Dec 2012 19:35:44 +0000 Subject: hg: jdk8/tl/jdk: 8004212: java.util.Base64 methods decodeArray and decodeBuffer should return the number of bytes written Message-ID: <20121201193555.3FF4E47C75@hg.openjdk.java.net> Changeset: fd8ba2d8baec Author: sherman Date: 2012-12-01 11:36 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fd8ba2d8baec 8004212: java.util.Base64 methods decodeArray and decodeBuffer should return the number of bytes written Summary: to return the length instead of position Reviewed-by: alanb ! src/share/classes/java/util/Base64.java ! test/java/util/Base64/TestBase64.java From alan.bateman at oracle.com Sun Dec 2 08:37:41 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Sun, 02 Dec 2012 16:37:41 +0000 Subject: hg: jdk8/tl/jdk: 8003846: Override mechanism for currency data should not require creating currency.properties in java.home Message-ID: <20121202163810.B846F47C8F@hg.openjdk.java.net> Changeset: f657adf4fe78 Author: alanb Date: 2012-12-02 16:37 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f657adf4fe78 8003846: Override mechanism for currency data should not require creating currency.properties in java.home Reviewed-by: naoto ! src/share/classes/java/util/Currency.java ! test/java/util/Currency/PropertiesTest.java ! test/java/util/Currency/PropertiesTest.sh From david.holmes at oracle.com Sun Dec 2 16:18:20 2012 From: david.holmes at oracle.com (david.holmes at oracle.com) Date: Mon, 03 Dec 2012 00:18:20 +0000 Subject: hg: jdk8/tl/jdk: 7200297: agent code does not handle multiple boot library path elements correctly Message-ID: <20121203001847.3487F47CB8@hg.openjdk.java.net> Changeset: 60550cd2b527 Author: dholmes Date: 2012-12-02 19:16 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/60550cd2b527 7200297: agent code does not handle multiple boot library path elements correctly Summary: When bug 6819213 was fixed it enabled sun.boot.library.path property to contain multiple paths. Code in agents does not handle multiple paths when attempting to find dependent shared libs. Reviewed-by: dholmes, sspitsyn, dsamersoff Contributed-by: Bill Pittore ! src/share/back/debugInit.c ! src/share/back/error_messages.c ! src/share/back/transport.c ! src/share/demo/jvmti/hprof/hprof.h ! src/share/demo/jvmti/hprof/hprof_init.c ! src/solaris/back/linker_md.c ! src/solaris/demo/jvmti/hprof/hprof_md.c ! src/solaris/npt/npt_md.h ! src/windows/back/linker_md.c ! src/windows/demo/jvmti/hprof/hprof_md.c ! src/windows/npt/npt_md.h From weijun.wang at oracle.com Mon Dec 3 01:14:21 2012 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Mon, 03 Dec 2012 09:14:21 +0000 Subject: hg: jdk8/tl/jdk: 7198507: [TEST_BUG] sun/security/tools/keytool/console.sh should be rewritten Message-ID: <20121203091444.97B8347CD1@hg.openjdk.java.net> Changeset: a42da685dfca Author: weijun Date: 2012-12-03 17:14 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a42da685dfca 7198507: [TEST_BUG] sun/security/tools/keytool/console.sh should be rewritten Reviewed-by: xuelei ! test/sun/security/tools/keytool/console.sh From xuelei.fan at oracle.com Mon Dec 3 06:01:35 2012 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Mon, 03 Dec 2012 14:01:35 +0000 Subject: hg: jdk8/tl/jdk: 8004184: security tests leave JSSEServer running Message-ID: <20121203140215.00D5D47CDD@hg.openjdk.java.net> Changeset: ead651efb271 Author: xuelei Date: 2012-12-03 06:00 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ead651efb271 8004184: security tests leave JSSEServer running Summary: Use othervm mode to release resources, and correct the system properties issues in JSSE Reviewed-by: chegar ! test/sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java From sean.mullan at oracle.com Mon Dec 3 08:17:10 2012 From: sean.mullan at oracle.com (sean.mullan at oracle.com) Date: Mon, 03 Dec 2012 16:17:10 +0000 Subject: hg: jdk8/tl/jdk: 7199143: RFE: OCSP revocation checker should provide possibility to specify connection timeout Message-ID: <20121203161732.2584F47CEC@hg.openjdk.java.net> Changeset: ee9846f351d7 Author: mullan Date: 2012-12-03 11:07 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ee9846f351d7 7199143: RFE: OCSP revocation checker should provide possibility to specify connection timeout Summary: Added com.sun.security.ocsp.timeout system property to control timeout Reviewed-by: mullan, vinnie Contributed-by: jason.uh at oracle.com ! src/share/classes/sun/security/provider/certpath/OCSP.java From alan.bateman at oracle.com Tue Dec 4 06:13:58 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Tue, 04 Dec 2012 14:13:58 +0000 Subject: hg: jdk8/tl/jdk: 7142921: (fs) Files.probeContentType reports a MIME type of "text/plain" on Ubuntu 11.04; ... Message-ID: <20121204141424.2273947D7C@hg.openjdk.java.net> Changeset: 38ec2838dd86 Author: dxu Date: 2012-12-04 14:07 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/38ec2838dd86 7142921: (fs) Files.probeContentType reports a MIME type of "text/plain" on Ubuntu 11.04 7144997: (fs) Files.probeContentType returns null on Solaris 64-bit Reviewed-by: alanb, mduigou ! make/java/nio/Makefile ! make/java/nio/mapfile-linux ! makefiles/CompileJavaClasses.gmk ! makefiles/CompileNativeLibraries.gmk ! makefiles/mapfiles/libnio/mapfile-linux ! src/solaris/classes/sun/nio/fs/BsdFileSystemProvider.java ! src/solaris/classes/sun/nio/fs/LinuxFileSystemProvider.java ! src/solaris/classes/sun/nio/fs/MacOSXFileSystemProvider.java + src/solaris/classes/sun/nio/fs/MagicFileTypeDetector.java + src/solaris/classes/sun/nio/fs/MimeTypesFileTypeDetector.java ! src/solaris/classes/sun/nio/fs/SolarisFileSystemProvider.java ! src/solaris/classes/sun/nio/fs/UnixFileSystemProvider.java + src/solaris/native/sun/nio/fs/MagicFileTypeDetector.c From alan.bateman at oracle.com Tue Dec 4 07:11:01 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Tue, 04 Dec 2012 15:11:01 +0000 Subject: hg: jdk8/tl/jdk: 8004066: TEST_BUG: test/java/lang/Math/DivModTests.java assumes ArithmeticException message Message-ID: <20121204151120.8597847D7F@hg.openjdk.java.net> Changeset: 2e8863c4f7d0 Author: kmo Date: 2012-12-04 15:10 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2e8863c4f7d0 8004066: TEST_BUG: test/java/lang/Math/DivModTests.java assumes ArithmeticException message Reviewed-by: twisti, alanb, dholmes ! test/java/lang/Math/DivModTests.java From maurizio.cimadamore at oracle.com Tue Dec 4 09:59:37 2012 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Tue, 04 Dec 2012 17:59:37 +0000 Subject: hg: jdk8/tl/langtools: 8004360: regression test DefaultMethodRegressionTests fails in langtools Message-ID: <20121204175941.ADEE447D98@hg.openjdk.java.net> Changeset: 0e70eb71fec0 Author: mcimadamore Date: 2012-12-04 17:19 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0e70eb71fec0 8004360: regression test DefaultMethodRegressionTests fails in langtools Summary: ignore broken failing test Reviewed-by: jjg - test/tools/javac/defaultMethodExecution/DefaultMethodRegressionTests.java + test/tools/javac/defaultMethods/defaultMethodExecution/DefaultMethodRegressionTests.java From mandy.chung at oracle.com Tue Dec 4 12:15:29 2012 From: mandy.chung at oracle.com (Mandy Chung) Date: Tue, 04 Dec 2012 12:15:29 -0800 Subject: 8003562: Provide a command-line tool to find static dependencies In-Reply-To: <50B54A2C.1040907@oracle.com> References: <50B54A2C.1040907@oracle.com> Message-ID: <50BE59E1.6010008@oracle.com> Alan - thanks for the feedback. I have made several changes to the jdeps tool. Here is the new webrev at: http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8003562/langtools-webrev.01/ I'll send out a formal code review request once I add the new unit tests. $ jdeps -h Usage: jdeps where possible options include: -version Version information -classpath Specify where to find class files -v --verbose Print class-level dependencies -v:class Print class-level dependencies -v:package Print package-level dependencies -v:summary Print dependency summary -p Restrict analysis to classes in this package (may be given multiple times) -e Restrict analysis to packages matching pattern (-p and -e are exclusive) -P --profile Show profile or the file containing a package -r --recursive Traverse all dependencies recursively -d Specify the depth of the transitive dependency analysis -r option is equivalent to setting depth to 0. -all Process all classes specified in -classpath Changes include: 1. Added -v:class, -v:package and -v:summary options to select the dependency output The default is package-level dependency. -v:summary only shows the dependencies across the boundaries in the given classpath or files. $ jdeps -classpath jfxrt.jar -v:summaryEnsemble.jar Ensemble.jar -> jfxrt.jar Ensemble.jar -> rt.jar 2. If only -classpath is given (taken from the -classpath in launching the application) but no input file, -all can be used to process all class files from the given classpath. 3. The output is now grouped by each input file/dir/jar file. By default, it will show the source of the dependency if it's coming from the given classpath or input files. Use -P to show the Profile and platform information. 4. -r option is repurposed for finding transitive dependencies recursively. I concur with Alan that --reverse is not needed since it only changes the output but not the dependency analysis. To find the usage of a specific class/package, -p and -e options can be used to diagnose dependency issue. Mandy On 11/27/12 3:18 PM, Mandy Chung wrote: > As part of prepare for modules [1], this RFE is to provide a > command-line tool in JDK8 so that developers can understand the static > dependencies of their applications and libraries.As part of Project > Jigsaw, a useful class analyzer [2] was developed that makes it very > easy to identify the dependencies based on the classfile library > thathas also been enhanced to support dependency analysis [3]. > > Inspired by the sample tool that Jon Gibbons developed, we propose > this new command-line name as "jdeps". > > $ ./bin/jdeps -h > Usage: jdeps > where possible options include: > -version Version information > -classpath Specify where to find class files > -v --verbose Print class-level dependencies > -r --reverse Invert the dependencies in the output > -p Restrict analysis to classes in this package > (may be given multiple times) > -e --regex Restrict analysis to packages matching pattern > (-p and -e are exclusive) > -P --profile Show profile or the file containing a package > -d --depth Specify the depth of the transitive > dependency analysis > Default depth is 1. Set depth to 0 to > traverse all dependencies. > -all Show all classes and members with no breakdown > > The jdeps tool shows package-level dependencies of the input files > that can be .class files, a directory, or a JAR file. Specify the > depth for the transitive dependency analysis; otherwise, it only > analyzes the input files. jdeps -P option will show where the > class/package comes from. For Java SE API, it will show the Profile > name (I implement a workaround for now until the profile work is in > jdk8). For JDK internal APIs, they will not be exported in modular > world. jdeps will indicate any usage of the JDK internal APIs in the > output to help developers prepare for transitioning to modules. > > See below for a few sample output. > > Webrev at: > http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8003562/ > > The implementation classes for jdeps are in the langtools repo along > with the com.sun.tools.classfile library. I'm working on adding more > unit tests. I'd like to get this webrev out to begin the discussion > and get review feedback. > > Thanks > Mandy > [1] http://openjdk.java.net/jeps/162 > [2] > http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/raw-file/543b0d24a920/make/tools/classanalyzer/classanalyzer.html > [3] http://bugs.sun.com/view_bug.do?bug_id=6907575 From alan.bateman at oracle.com Tue Dec 4 12:21:47 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Tue, 04 Dec 2012 20:21:47 +0000 Subject: hg: jdk8/tl/jdk: 8003596: TEST_BUG: java/util/logging/CheckLockLocationTest.java failing [win] Message-ID: <20121204202227.EC74B47DA4@hg.openjdk.java.net> Changeset: 7004848974a2 Author: jgish Date: 2012-12-04 20:21 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7004848974a2 8003596: TEST_BUG: java/util/logging/CheckLockLocationTest.java failing [win] Reviewed-by: alanb ! test/ProblemList.txt ! test/java/util/logging/CheckLockLocationTest.java From sean.mullan at oracle.com Tue Dec 4 14:42:45 2012 From: sean.mullan at oracle.com (sean.mullan at oracle.com) Date: Tue, 04 Dec 2012 22:42:45 +0000 Subject: hg: jdk8/tl/jdk: 8004188: Rename src/share/lib/security/java.security to java.security-linux Message-ID: <20121204224256.AAADD47DD0@hg.openjdk.java.net> Changeset: 44ae777564eb Author: mullan Date: 2012-12-04 17:40 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/44ae777564eb 8004188: Rename src/share/lib/security/java.security to java.security-linux Reviewed-by: mullan, mchung Contributed-by: jason.uh at oracle.com ! make/java/security/Makefile - src/share/lib/security/java.security + src/share/lib/security/java.security-linux From alan.bateman at oracle.com Wed Dec 5 04:55:51 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Wed, 05 Dec 2012 12:55:51 +0000 Subject: hg: jdk8/tl/jdk: 8004491: Build breakage on Linux due to 8004188 Message-ID: <20121205125631.21EC047E25@hg.openjdk.java.net> Changeset: b54a5b7d2e65 Author: alanb Date: 2012-12-05 12:20 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b54a5b7d2e65 8004491: Build breakage on Linux due to 8004188 Reviewed-by: chegar, erikj ! makefiles/CopyFiles.gmk From Alan.Bateman at oracle.com Wed Dec 5 07:57:15 2012 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 05 Dec 2012 15:57:15 +0000 Subject: 8003562: Provide a command-line tool to find static dependencies In-Reply-To: <50BE59E1.6010008@oracle.com> References: <50B54A2C.1040907@oracle.com> <50BE59E1.6010008@oracle.com> Message-ID: <50BF6EDB.6090603@oracle.com> On 04/12/2012 20:15, Mandy Chung wrote: > Alan - thanks for the feedback. I have made several changes to the > jdeps tool. Here is the new webrev at: > > http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8003562/langtools-webrev.01/ > > I'll send out a formal code review request once I add the new unit tests. I like the name of the tool, and I think the new proposed options looks much better. The only option that I suspect might confuse people is -d, I'm not sure that this is really needed. A minor observation but I wonder if -v/--verbose should be something else. The sub-options are good, it's just that -v is really is selecting the level that the dependencies are printed (and -v:summary is less verbose than the default). Otherwise I think this will be really useful to have. -Alan, From Ulf.Zibis at CoSoCo.de Wed Dec 5 13:58:37 2012 From: Ulf.Zibis at CoSoCo.de (Ulf Zibis) Date: Wed, 05 Dec 2012 22:58:37 +0100 Subject: 8003562: Provide a command-line tool to find static dependencies In-Reply-To: <50B54A2C.1040907@oracle.com> References: <50B54A2C.1040907@oracle.com> Message-ID: <50BFC38D.8020406@CoSoCo.de> Yeah, this is a great tool. Does it also help to find the need to recompile a class if the source of a inlined referred static final constant has changed? -Ulf Am 28.11.2012 00:18, schrieb Mandy Chung: > As part of prepare for modules [1], this RFE is to provide a command-line tool in JDK8 so that > developers can understand the static dependencies of their applications and libraries.As part of > Project Jigsaw, a useful class analyzer [2] was developed that makes it very easy to identify the > dependencies based on the classfile library thathas also been enhanced to support dependency > analysis [3]. > > Inspired by the sample tool that Jon Gibbons developed, we propose this new command-line name as > "jdeps". > > $ ./bin/jdeps -h > Usage: jdeps > where possible options include: > -version Version information > -classpath Specify where to find class files > -v --verbose Print class-level dependencies > -r --reverse Invert the dependencies in the output > -p Restrict analysis to classes in this package > (may be given multiple times) > -e --regex Restrict analysis to packages matching pattern > (-p and -e are exclusive) > -P --profile Show profile or the file containing a package > -d --depth Specify the depth of the transitive dependency analysis > Default depth is 1. Set depth to 0 to traverse all dependencies. > -all Show all classes and members with no breakdown > > The jdeps tool shows package-level dependencies of the input files that can be .class files, a > directory, or a JAR file. Specify the depth for the transitive dependency analysis; otherwise, it > only analyzes the input files. jdeps -P option will show where the class/package comes from. For > Java SE API, it will show the Profile name (I implement a workaround for now until the profile > work is in jdk8). For JDK internal APIs, they will not be exported in modular world. jdeps will > indicate any usage of the JDK internal APIs in the output to help developers prepare for > transitioning to modules. > > See below for a few sample output. > > Webrev at: > http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8003562/ > > The implementation classes for jdeps are in the langtools repo along with the > com.sun.tools.classfile library. I'm working on adding more unit tests. I'd like to get this > webrev out to begin the discussion and get review feedback. > > Thanks > Mandy > [1] http://openjdk.java.net/jeps/162 > [2] > http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/raw-file/543b0d24a920/make/tools/classanalyzer/classanalyzer.html > [3] http://bugs.sun.com/view_bug.do?bug_id=6907575 > > Sample Output > > $./bin/jdeps demo/jfc/Notepad/Notepad.jar > (demo/jfc/Notepad/Notepad.jar) > -> java.awt > -> java.awt.event > -> java.beans > -> java.io > -> java.lang > -> java.net > -> java.util > -> java.util.logging > -> javax.swing > -> javax.swing.border > -> javax.swing.event > -> javax.swing.text > -> javax.swing.tree > -> javax.swing.undo > > $ ./bin/jdeps -P demo/jfc/Notepad/Notepad.jar > (demo/jfc/Notepad/Notepad.jar) > -> java.awt compact4 > -> java.awt.event compact4 > -> java.beans compact4 > -> java.io compact1 > -> java.lang compact1 > -> java.net compact1 > -> java.util compact1 > -> java.util.logging compact1 > -> javax.swing compact4 > -> javax.swing.border compact4 > -> javax.swing.event compact4 > -> javax.swing.text compact4 > -> javax.swing.tree compact4 > -> javax.swing.undo compact4 > > $ ./bin/jdeps -d 10 demo/jfc/Notepad/Notepad.jar > (demo/jfc/Notepad/Notepad.jar) > -> java.awt > -> java.awt.event > -> java.beans > -> java.io > -> java.lang > -> java.net > -> java.util > -> java.util.logging > -> javax.swing > -> javax.swing.border > -> javax.swing.event > -> javax.swing.text > -> javax.swing.tree > -> javax.swing.undo > java.security (/export/mchung/ws/jdeps-repo/build/macosx-x86_64/j2sdk-image/jre/lib/rt.jar) > -> javax.crypto > javax.crypto (/export/mchung/ws/jdeps-repo/build/macosx-x86_64/j2sdk-image/jre/lib/jce.jar) > -> java.io > -> java.lang > -> java.lang.reflect > -> java.net > -> java.nio > -> java.security > -> java.security.cert > -> java.security.spec > -> java.util > -> java.util.concurrent > -> java.util.jar > -> java.util.regex > -> java.util.zip > -> sun.security.jca JDK internal API > -> sun.security.util JDK internal API > javax.crypto.spec (/export/mchung/ws/jdeps-repo/build/macosx-x86_64/j2sdk-image/jre/lib/jce.jar) > -> java.lang > -> java.security.spec > -> java.util > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20121205/b4210c1e/attachment.html From jonathan.gibbons at oracle.com Wed Dec 5 14:18:07 2012 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Wed, 05 Dec 2012 14:18:07 -0800 Subject: 8003562: Provide a command-line tool to find static dependencies In-Reply-To: <50BFC38D.8020406@CoSoCo.de> References: <50B54A2C.1040907@oracle.com> <50BFC38D.8020406@CoSoCo.de> Message-ID: <50BFC81F.2040506@oracle.com> On 12/05/2012 01:58 PM, Ulf Zibis wrote: > > > Does it also help to find the need to recompile a class if the source > of a inlined referred static final constant has changed? See this changeset http://hg.openjdk.java.net/jdk8/tl/langtools/rev/969c96b980b7 http://bugs.sun.com/view_bug.do?bug_id=7153958 -- Jon From Ulf.Zibis at CoSoCo.de Wed Dec 5 15:43:29 2012 From: Ulf.Zibis at CoSoCo.de (Ulf Zibis) Date: Thu, 06 Dec 2012 00:43:29 +0100 Subject: 8003562: Provide a command-line tool to find static dependencies In-Reply-To: <50BFC81F.2040506@oracle.com> References: <50B54A2C.1040907@oracle.com> <50BFC38D.8020406@CoSoCo.de> <50BFC81F.2040506@oracle.com> Message-ID: <50BFDC21.2030100@CoSoCo.de> :-) Am 05.12.2012 23:18, schrieb Jonathan Gibbons: > On 12/05/2012 01:58 PM, Ulf Zibis wrote: >> >> >> Does it also help to find the need to recompile a class if the source of a inlined referred >> static final constant has changed? > > See this changeset > http://hg.openjdk.java.net/jdk8/tl/langtools/rev/969c96b980b7 > http://bugs.sun.com/view_bug.do?bug_id=7153958 > > -- Jon > From mandy.chung at oracle.com Wed Dec 5 17:36:30 2012 From: mandy.chung at oracle.com (Mandy Chung) Date: Wed, 05 Dec 2012 17:36:30 -0800 Subject: Review request: 8003562: Provide a command-line tool to find static dependencies In-Reply-To: <50B54A2C.1040907@oracle.com> References: <50B54A2C.1040907@oracle.com> Message-ID: <50BFF69E.1040805@oracle.com> This review request (add a new jdeps tool in the JDK) include changes in langtools and the jdk build. I would need reviewers from the langtools and the build-infra team. Webrev for review: http://cr.openjdk.java.net/~mchung/jdk8/webrevs/jdeps/langtools-webrev.02/ http://cr.openjdk.java.net/~mchung/jdk8/webrevs/jdeps/jdk-webrev.02/ The jdeps source is in the langtools repo. The change in the jdk repo is to add the new jdeps executable. I made change in the old and new build for the addition of this new jdeps tool. I discussed with Jon whether I should modify langtools/make/build.xml to add a new jdeps target. Since the old build will be replaced by the new build soon, I simply add com/sun/tools/jdeps as part of javap.includes. Alan, The -d option is kept as a hidden option and use as implementation. We can remove it when it's determined not useful in the future. I also rename -v:summary to -summary. Thanks Mandy ---------------------------- $ jdep -h Usage: jdeps where possible options include: -version Version information -classpath Specify where to find class files -summary Print dependency summary only -v:class Print class-level dependencies -v:package Print package-level dependencies -p Restrict analysis to classes in this package (may be given multiple times) -e Restrict analysis to packages matching pattern (-p and -e are exclusive) -P --profile Show profile or the file containing a package -R --recursive Traverse all dependencies recursively -all Process all classes specified in -classpath $ jdep Notepad.jar Ensemble.jar Notepad.jar -> D:\tools\devtools\jdk8\windows-i586\jre\lib\rt.jar (Notepad.jar) -> java.awt -> java.awt.event -> java.beans -> java.io -> java.lang -> java.net -> java.util -> java.util.logging -> javax.swing -> javax.swing.border -> javax.swing.event -> javax.swing.text -> javax.swing.tree -> javax.swing.undo Ensemble.jar -> D:\tools\devtools\jdk8\windows-i586\jre\lib\jfxrt.jar Ensemble.jar -> D:\tools\devtools\jdk8\windows-i586\jre\lib\rt.jar com.javafx.main (Ensemble.jar) -> java.applet -> java.awt -> java.awt.event -> java.io -> java.lang -> java.lang.reflect -> java.net -> java.security -> java.util -> java.util.jar -> javax.swing -> sun.misc JDK internal API (rt.jar) From stuart.marks at oracle.com Wed Dec 5 21:12:03 2012 From: stuart.marks at oracle.com (stuart.marks at oracle.com) Date: Thu, 06 Dec 2012 05:12:03 +0000 Subject: hg: jdk8/tl/jdk: 8004317: TestLibrary.getUnusedRandomPort() fails intermittently, but exception not reported Message-ID: <20121206051214.7A1D447EF1@hg.openjdk.java.net> Changeset: a971516029ab Author: jgish Date: 2012-12-05 21:08 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a971516029ab 8004317: TestLibrary.getUnusedRandomPort() fails intermittently, but exception not reported Reviewed-by: alanb, dmocek, smarks ! test/java/rmi/testlibrary/TestLibrary.java From mandy.chung at oracle.com Thu Dec 6 07:35:33 2012 From: mandy.chung at oracle.com (Mandy Chung) Date: Thu, 06 Dec 2012 07:35:33 -0800 Subject: Review request: 8003562: Provide a command-line tool to find static dependencies In-Reply-To: <50C0AD96.30407@oracle.com> References: <50B54A2C.1040907@oracle.com> <50BFF69E.1040805@oracle.com> <50C0AD96.30407@oracle.com> Message-ID: <50C0BB45.9030501@oracle.com> Thanks Erik for the help. I missed the files for images build. I'll incorporate your patch. Mandy On 12/6/2012 6:37 AM, Erik Joelsson wrote: > Hello, > > I've looked at the build changes and noted that the old and new build > did not produce the same results. Here is a webrev with adjustments (I > chose to do a full forest webrev because I needed to change a file in > the root too): > > http://cr.openjdk.java.net/~erikj/8003562/webrev.03/ > > The changes are: > > * Add the jdeps package to tools.jar in new build > * Exclude jdeps from jre in new build > * Add "-DEXPAND_CLASSPATH_WILDCARDS > -DNEVER_ACT_AS_SERVER_CLASS_MACHINE" to compile in old build. I wasn't > sure if these were intended for this launcher, but I'm guessing that > it makes sense to match the settings of javap and javah. The other > alternative is to remove these from both old and new build. > * Add ./bin/jdeps to some exception lists in compare script. (jdeps, > like most executables, contains the version string.) > > With these changes, I don't see any new regressions in the compare > script on my machine. > > /Erik > > On 2012-12-06 02:36, Mandy Chung wrote: >> This review request (add a new jdeps tool in the JDK) include changes in >> langtools and the jdk build. I would need reviewers from the langtools >> and the build-infra team. >> >> Webrev for review: >> http://cr.openjdk.java.net/~mchung/jdk8/webrevs/jdeps/langtools-webrev.02/ >> http://cr.openjdk.java.net/~mchung/jdk8/webrevs/jdeps/jdk-webrev.02/ >> >> The jdeps source is in the langtools repo. The change in the jdk >> repo is >> to add the new jdeps executable. I made change in the old and new build >> for the addition of this new jdeps tool. I discussed with Jon whether I >> should modify langtools/make/build.xml to add a new jdeps target. Since >> the old build will be replaced by the new build soon, I simply add >> com/sun/tools/jdeps as part of javap.includes. >> >> Alan, >> >> The -d option is kept as a hidden option and use as implementation. We >> can remove it when it's determined not useful in the future. I also >> rename -v:summary to -summary. >> >> Thanks >> Mandy >> >> ---------------------------- >> >> $ jdep -h >> Usage: jdeps >> where possible options include: >> -version Version information >> -classpath Specify where to find class files >> -summary Print dependency summary only >> -v:class Print class-level dependencies >> -v:package Print package-level dependencies >> -p Restrict analysis to classes in this package >> (may be given multiple times) >> -e Restrict analysis to packages matching >> pattern >> (-p and -e are exclusive) >> -P --profile Show profile or the file containing a package >> -R --recursive Traverse all dependencies recursively >> -all Process all classes specified in -classpath >> >> $ jdep Notepad.jar Ensemble.jar >> Notepad.jar -> D:\tools\devtools\jdk8\windows-i586\jre\lib\rt.jar >> (Notepad.jar) >> -> java.awt >> -> java.awt.event >> -> java.beans >> -> java.io >> -> java.lang >> -> java.net >> -> java.util >> -> java.util.logging >> -> javax.swing >> -> javax.swing.border >> -> javax.swing.event >> -> javax.swing.text >> -> javax.swing.tree >> -> javax.swing.undo >> >> Ensemble.jar -> D:\tools\devtools\jdk8\windows-i586\jre\lib\jfxrt.jar >> Ensemble.jar -> D:\tools\devtools\jdk8\windows-i586\jre\lib\rt.jar >> com.javafx.main (Ensemble.jar) >> -> java.applet >> -> java.awt >> -> java.awt.event >> -> java.io >> -> java.lang >> -> java.lang.reflect >> -> java.net >> -> java.security >> -> java.util >> -> java.util.jar >> -> javax.swing >> -> sun.misc JDK internal API >> (rt.jar) -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20121206/91137d73/attachment.html From fredrik.ohrstrom at oracle.com Thu Dec 6 07:43:09 2012 From: fredrik.ohrstrom at oracle.com (=?ISO-8859-1?Q?Fredrik_=D6hrstr=F6m?=) Date: Thu, 06 Dec 2012 16:43:09 +0100 Subject: Review request: 8004657: Add hooks to javac to enable reporting dependency information. In-Reply-To: <50BFF69E.1040805@oracle.com> References: <50B54A2C.1040907@oracle.com> <50BFF69E.1040805@oracle.com> Message-ID: <50C0BD0D.3010804@oracle.com> These are the minimal changes to javac to enable the smart javac wrapper to do its work. I.e. extract dependency information from javac compiles. It also removes two global static variables that prevents multi core setting of options. http://cr.openjdk.java.net/~ohrstrom/webrev-8004657-javac_hooks/ //Fredrik From fredrik.ohrstrom at oracle.com Thu Dec 6 08:09:02 2012 From: fredrik.ohrstrom at oracle.com (=?ISO-8859-1?Q?Fredrik_=D6hrstr=F6m?=) Date: Thu, 06 Dec 2012 17:09:02 +0100 Subject: Review request: 8004658: Add internal smart javac wrapper to solve JEP 139 Message-ID: <50C0C31E.5030208@oracle.com> This the smart javac wrapper that makes use of the javac hooks for reporting dependencies. The easiest way to test it, is to clone build-infra and use --enable-sjavac with configure. After building, do "export PATH=build/.../jdk/bin:$PATH" then you can do: sjavac src -d bin --server:portfile=/tmp/myport The more sources you have under the src directory, the merrier. With enough sources, it will actually use multiple cores. Run it again, and nothing will happen, since it quickly determines that all artifacts are up to date. (add -h headers if you expect native method headers to be generated.) Try changing public methods, and recompile, dependent packages will be recompiled. Try changing private or package private methods, and recompile, only that package will be recompiled. Try changing a native method, the header file will be regenerated. The smart javac wrapper is not part of the final image. (The sjavac launcher and its classes in the tools.jar are explicitly stripped from the image.) It will remain a build tool, while we experiment and improve its multi core performance and evaluate how it should integrated into the full product. The real test is of course, to add "public void helloWorld() {}" to Object.java and do "make LOG=info". Or add a native method to Adler32.java and watch how the build system recompiles libzip.so (remember to do "make LOG=info") to see the incremental build properly. http://cr.openjdk.java.net/~ohrstrom/webrev-8004658-sjavac/ //Fredrik From jonathan.gibbons at oracle.com Thu Dec 6 11:06:38 2012 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Thu, 06 Dec 2012 11:06:38 -0800 Subject: Review request: 8004657: Add hooks to javac to enable reporting dependency information. In-Reply-To: <50C0BD0D.3010804@oracle.com> References: <50B54A2C.1040907@oracle.com> <50BFF69E.1040805@oracle.com> <50C0BD0D.3010804@oracle.com> Message-ID: <50C0ECBE.1090409@oracle.com> On 12/06/2012 07:43 AM, Fredrik ?hrstr?m wrote: > These are the minimal changes to javac to enable the smart javac > wrapper to do its work. > I.e. extract dependency information from javac compiles. It also > removes two global static > variables that prevents multi core setting of options. > > http://cr.openjdk.java.net/~ohrstrom/webrev-8004657-javac_hooks/ > > //Fredrik Log.setOut is redundant. Log.setWriters already exists with the same functionality. -- Jon From lance.andersen at oracle.com Thu Dec 6 12:52:41 2012 From: lance.andersen at oracle.com (lance.andersen at oracle.com) Date: Thu, 06 Dec 2012 20:52:41 +0000 Subject: hg: jdk8/tl/jdk: 8004374: CachedRowSetSwriter.writeData reports wrong number of conflicts in SyncProviderException Message-ID: <20121206205310.E808047F56@hg.openjdk.java.net> Changeset: 41a1b110f34d Author: lancea Date: 2012-12-06 15:51 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/41a1b110f34d 8004374: CachedRowSetSwriter.writeData reports wrong number of conflicts in SyncProviderException Reviewed-by: naoto ! src/share/classes/com/sun/rowset/internal/CachedRowSetWriter.java From mike.duigou at oracle.com Thu Dec 6 15:39:14 2012 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Thu, 06 Dec 2012 23:39:14 +0000 Subject: hg: jdk8/tl: 8004685: add java.util.function to CORE_PKGS.gmk Message-ID: <20121206233914.9C9E847F5F@hg.openjdk.java.net> Changeset: fb1bf5e5bc9e Author: henryjen Date: 2012-12-06 15:38 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/fb1bf5e5bc9e 8004685: add java.util.function to CORE_PKGS.gmk Reviewed-by: mduigou ! common/makefiles/javadoc/CORE_PKGS.gmk From robert.field at oracle.com Thu Dec 6 21:57:22 2012 From: robert.field at oracle.com (robert.field at oracle.com) Date: Fri, 07 Dec 2012 05:57:22 +0000 Subject: hg: jdk8/tl/jdk: 8003881: Prevent lambda implementing inner classes from allowing the creation of new instances Message-ID: <20121207055741.6431447FA8@hg.openjdk.java.net> Changeset: 896d4af2ebfd Author: rfield Date: 2012-12-06 21:55 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/896d4af2ebfd 8003881: Prevent lambda implementing inner classes from allowing the creation of new instances Summary: Lambda implementing inner classes now has private constructor (thanks Kumar) Reviewed-by: ksrini ! src/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java + test/java/lang/invoke/lambda/LambdaAccessControlDoPrivilegedTest.java + test/java/lang/invoke/lambda/LambdaAccessControlTest.java From fredrik.ohrstrom at oracle.com Fri Dec 7 06:54:03 2012 From: fredrik.ohrstrom at oracle.com (=?iso-8859-1?Q?Fredrik_=D6hrstr=F6m?=) Date: Fri, 7 Dec 2012 15:54:03 +0100 Subject: Review request: 8004657: Add hooks to javac to enable reporting dependency information. In-Reply-To: <50C0ECBE.1090409@oracle.com> References: <50B54A2C.1040907@oracle.com> <50BFF69E.1040805@oracle.com> <50C0BD0D.3010804@oracle.com> <50C0ECBE.1090409@oracle.com> Message-ID: <554DA049-8FB3-418F-83B0-6E254E6FA850@oracle.com> > > Log.setOut is redundant. Log.setWriters already exists with the same functionality. > > -- Jon Thanks! Fixed. New webrev is here: http://cr.openjdk.java.net/~ohrstrom/webrev-8004657-javac_hooks-v2 From martinrb at google.com Fri Dec 7 12:06:21 2012 From: martinrb at google.com (Martin Buchholz) Date: Fri, 7 Dec 2012 12:06:21 -0800 Subject: Boot JDK requirements for 8 ? In-Reply-To: <50BE9755.5040408@oracle.com> References: <50BE9755.5040408@oracle.com> Message-ID: On Tue, Dec 4, 2012 at 4:37 PM, David Holmes wrote: > /java/embedded/users/dh198349/**profiles/builds/b66/se-linux-** > i586-ea/jdk/classes/java/lang/**Integer.class: major version 52 is newer > than 51, the highest major version supported by this compiler. > Consider (just for jdk development purposes) internally turning this into an error, so that all such warnings are caught before release. I think such a thing is useful enough that you could have a system property or javac flag to turn this into an error. openjdk development would not be the only team making use of that, e.g. to find missing -bootclasspath flags. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20121207/91c8d9d8/attachment.html From Dmitry.Degrave at oracle.com Fri Dec 7 12:59:39 2012 From: Dmitry.Degrave at oracle.com (Dmeetry Degrave) Date: Sat, 08 Dec 2012 00:59:39 +0400 Subject: Code review for 8004391: Bug fix in jtreg causes test failures in pre jdk 8 langtools tests Message-ID: <50C258BB.2060908@oracle.com> Hi, We have a number of tests failed with the latest version of jtreg with -samevm option. Several tests were fixed by 7192449 and 7192744 [1][2]. The fix [3] addresses the last 8004391's failing test in jdk7. http://bugs.sun.com/view_bug.do?bug_id=8004391 thanks, dmeetry [1] http://hg.openjdk.java.net/jdk7u/jdk7u-dev/langtools/rev/42046927957f [2] http://hg.openjdk.java.net/jdk7u/jdk7u-dev/langtools/rev/346b1eb8c309 [3] http://cr.openjdk.java.net/~dmeetry/8004391/webrev.0/ From mandy.chung at oracle.com Fri Dec 7 13:55:36 2012 From: mandy.chung at oracle.com (Mandy Chung) Date: Fri, 07 Dec 2012 13:55:36 -0800 Subject: Review request: 8003562: Provide a command-line tool to find static dependencies In-Reply-To: <50BFF69E.1040805@oracle.com> References: <50B54A2C.1040907@oracle.com> <50BFF69E.1040805@oracle.com> Message-ID: <50C265D8.3050107@oracle.com> This is the updated webrev. It includes Erik's makefile changes and small change - be consistent with javap, jdeps can take classnames as the input argument or wildcard "*" to analyze all class files that replaces the "-all" option. Webrev: http://cr.openjdk.java.net/~mchung/jdk8/webrevs/jdeps/webrev.03/ Mandy On 12/5/12 5:36 PM, Mandy Chung wrote: > This review request (add a new jdeps tool in the JDK) include changes in > langtools and the jdk build. I would need reviewers from the langtools > and the build-infra team. > > Webrev for review: > > http://cr.openjdk.java.net/~mchung/jdk8/webrevs/jdeps/langtools-webrev.02/ > http://cr.openjdk.java.net/~mchung/jdk8/webrevs/jdeps/jdk-webrev.02/ > > The jdeps source is in the langtools repo. The change in the jdk repo is > to add the new jdeps executable. I made change in the old and new build > for the addition of this new jdeps tool. I discussed with Jon whether I > should modify langtools/make/build.xml to add a new jdeps target. Since > the old build will be replaced by the new build soon, I simply add > com/sun/tools/jdeps as part of javap.includes. > > Alan, > > The -d option is kept as a hidden option and use as implementation. We > can remove it when it's determined not useful in the future. I also > rename -v:summary to -summary. > > Thanks > Mandy > > ---------------------------- > > $ jdep -h > Usage: jdeps > where possible options include: > -version Version information > -classpath Specify where to find class files > -summary Print dependency summary only > -v:class Print class-level dependencies > -v:package Print package-level dependencies > -p Restrict analysis to classes in this package > (may be given multiple times) > -e Restrict analysis to packages matching pattern > (-p and -e are exclusive) > -P --profile Show profile or the file containing a package > -R --recursive Traverse all dependencies recursively > -all Process all classes specified in -classpath > > $ jdep Notepad.jar Ensemble.jar > Notepad.jar -> D:\tools\devtools\jdk8\windows-i586\jre\lib\rt.jar > (Notepad.jar) > -> java.awt > -> java.awt.event > -> java.beans > -> java.io > -> java.lang > -> java.net > -> java.util > -> java.util.logging > -> javax.swing > -> javax.swing.border > -> javax.swing.event > -> javax.swing.text > -> javax.swing.tree > -> javax.swing.undo > > Ensemble.jar -> D:\tools\devtools\jdk8\windows-i586\jre\lib\jfxrt.jar > Ensemble.jar -> D:\tools\devtools\jdk8\windows-i586\jre\lib\rt.jar > com.javafx.main (Ensemble.jar) > -> java.applet > -> java.awt > -> java.awt.event > -> java.io > -> java.lang > -> java.lang.reflect > -> java.net > -> java.security > -> java.util > -> java.util.jar > -> javax.swing > -> sun.misc JDK internal API > (rt.jar) From james.holmlund at oracle.com Fri Dec 7 14:30:07 2012 From: james.holmlund at oracle.com (Jim Holmlund) Date: Fri, 07 Dec 2012 14:30:07 -0800 Subject: Code review for 8004391: Bug fix in jtreg causes test failures in pre jdk 8 langtools tests In-Reply-To: <50C258BB.2060908@oracle.com> References: <50C258BB.2060908@oracle.com> Message-ID: <50C26DEF.5060907@oracle.com> Approved. - jjh On 12/7/2012 12:59 PM, Dmeetry Degrave wrote: > Hi, > > We have a number of tests failed with the latest version of jtreg with -samevm option. Several > tests were fixed by 7192449 and 7192744 [1][2]. The fix [3] addresses the last 8004391's failing > test in jdk7. > > http://bugs.sun.com/view_bug.do?bug_id=8004391 > > thanks, > dmeetry > > [1] http://hg.openjdk.java.net/jdk7u/jdk7u-dev/langtools/rev/42046927957f > [2] http://hg.openjdk.java.net/jdk7u/jdk7u-dev/langtools/rev/346b1eb8c309 > [3] http://cr.openjdk.java.net/~dmeetry/8004391/webrev.0/ From kumar.x.srinivasan at oracle.com Sun Dec 9 09:17:55 2012 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Sun, 09 Dec 2012 17:17:55 +0000 Subject: hg: jdk8/tl/jdk: 8004042: Arrrghs.java test failed on windows with access error. Message-ID: <20121209171842.20CC747FF6@hg.openjdk.java.net> Changeset: da387f0cecb7 Author: ksrini Date: 2012-12-09 07:43 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/da387f0cecb7 8004042: Arrrghs.java test failed on windows with access error. Reviewed-by: smarks, jjh, ksrini Contributed-by: david.dehaven at oracle.com ! test/tools/launcher/Arrrghs.java ! test/tools/launcher/TestHelper.java From alan.bateman at oracle.com Sun Dec 9 11:13:03 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Sun, 09 Dec 2012 19:13:03 +0000 Subject: hg: jdk8/tl/jdk: 7194370: (fs) WatchService fails if volume S/N is 0 [win] Message-ID: <20121209191314.ADFA647FF9@hg.openjdk.java.net> Changeset: 343615aa0539 Author: dxu Date: 2012-12-09 19:13 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/343615aa0539 7194370: (fs) WatchService fails if volume S/N is 0 [win] Reviewed-by: alanb, forax ! src/windows/classes/sun/nio/fs/WindowsFileAttributes.java From masayoshi.okutsu at oracle.com Sun Dec 9 18:01:06 2012 From: masayoshi.okutsu at oracle.com (masayoshi.okutsu at oracle.com) Date: Mon, 10 Dec 2012 02:01:06 +0000 Subject: hg: jdk8/tl/jdk: 8000983: Support narrow display names for calendar fields; ... Message-ID: <20121210020127.5EB7747FFC@hg.openjdk.java.net> Changeset: fda257689786 Author: okutsu Date: 2012-12-10 10:52 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fda257689786 8000983: Support narrow display names for calendar fields 8003267: Support generic time zone names in TimeZoneNameProvider (SPI) Reviewed-by: naoto ! make/tools/src/build/tools/cldrconverter/Bundle.java ! make/tools/src/build/tools/cldrconverter/BundleGenerator.java ! make/tools/src/build/tools/cldrconverter/CLDRConverter.java ! make/tools/src/build/tools/cldrconverter/LDMLParseHandler.java ! make/tools/src/build/tools/cldrconverter/MetaZonesParseHandler.java ! make/tools/src/build/tools/cldrconverter/ResourceBundleGenerator.java ! src/share/classes/java/text/DateFormatSymbols.java ! src/share/classes/java/text/SimpleDateFormat.java ! src/share/classes/java/util/Calendar.java ! src/share/classes/java/util/JapaneseImperialCalendar.java ! src/share/classes/java/util/TimeZone.java ! src/share/classes/java/util/spi/CalendarNameProvider.java ! src/share/classes/java/util/spi/TimeZoneNameProvider.java ! src/share/classes/sun/text/resources/FormatData.java ! src/share/classes/sun/text/resources/ar/FormatData_ar.java ! src/share/classes/sun/text/resources/be/FormatData_be.java ! src/share/classes/sun/text/resources/bg/FormatData_bg.java ! src/share/classes/sun/text/resources/ca/FormatData_ca.java ! src/share/classes/sun/text/resources/cs/FormatData_cs.java ! src/share/classes/sun/text/resources/da/FormatData_da.java ! src/share/classes/sun/text/resources/de/FormatData_de.java ! src/share/classes/sun/text/resources/el/FormatData_el.java ! src/share/classes/sun/text/resources/es/FormatData_es.java ! src/share/classes/sun/text/resources/et/FormatData_et.java ! src/share/classes/sun/text/resources/fi/FormatData_fi.java ! src/share/classes/sun/text/resources/fr/FormatData_fr.java ! src/share/classes/sun/text/resources/hi/FormatData_hi_IN.java ! src/share/classes/sun/text/resources/hr/FormatData_hr.java ! src/share/classes/sun/text/resources/hu/FormatData_hu.java ! src/share/classes/sun/text/resources/is/FormatData_is.java ! src/share/classes/sun/text/resources/it/FormatData_it.java ! src/share/classes/sun/text/resources/iw/FormatData_iw.java ! src/share/classes/sun/text/resources/ja/FormatData_ja.java ! src/share/classes/sun/text/resources/ko/FormatData_ko.java ! src/share/classes/sun/text/resources/lt/FormatData_lt.java ! src/share/classes/sun/text/resources/lv/FormatData_lv.java ! src/share/classes/sun/text/resources/mk/FormatData_mk.java ! src/share/classes/sun/text/resources/ms/FormatData_ms.java ! src/share/classes/sun/text/resources/mt/FormatData_mt.java ! src/share/classes/sun/text/resources/nl/FormatData_nl.java ! src/share/classes/sun/text/resources/pl/FormatData_pl.java ! src/share/classes/sun/text/resources/pt/FormatData_pt.java ! src/share/classes/sun/text/resources/ro/FormatData_ro.java ! src/share/classes/sun/text/resources/ru/FormatData_ru.java ! src/share/classes/sun/text/resources/sk/FormatData_sk.java ! src/share/classes/sun/text/resources/sl/FormatData_sl.java ! src/share/classes/sun/text/resources/sq/FormatData_sq.java ! src/share/classes/sun/text/resources/sr/FormatData_sr.java ! src/share/classes/sun/text/resources/sv/FormatData_sv.java ! src/share/classes/sun/text/resources/th/FormatData_th.java ! src/share/classes/sun/text/resources/tr/FormatData_tr.java ! src/share/classes/sun/text/resources/uk/FormatData_uk.java ! src/share/classes/sun/text/resources/vi/FormatData_vi.java ! src/share/classes/sun/text/resources/zh/FormatData_zh.java ! src/share/classes/sun/util/cldr/CLDRLocaleProviderAdapter.java ! src/share/classes/sun/util/locale/provider/CalendarDataUtility.java ! src/share/classes/sun/util/locale/provider/CalendarNameProviderImpl.java ! src/share/classes/sun/util/locale/provider/LocaleResources.java ! src/share/classes/sun/util/locale/provider/SPILocaleProviderAdapter.java ! src/share/classes/sun/util/locale/provider/TimeZoneNameProviderImpl.java ! src/share/classes/sun/util/locale/provider/TimeZoneNameUtility.java ! src/share/classes/sun/util/resources/LocaleData.java ! src/share/classes/sun/util/resources/OpenListResourceBundle.java ! src/share/classes/sun/util/resources/TimeZoneNames.java ! src/share/classes/sun/util/resources/TimeZoneNamesBundle.java + test/java/util/Calendar/GenericTimeZoneNamesTest.java + test/java/util/Calendar/GenericTimeZoneNamesTest.sh + test/java/util/Calendar/NarrowNamesTest.java + test/java/util/Calendar/NarrowNamesTest.sh ! test/java/util/PluggableLocale/GenericTest.java ! test/java/util/PluggableLocale/TimeZoneNameProviderTest.java ! test/java/util/PluggableLocale/TimeZoneNameProviderTest.sh ! test/java/util/PluggableLocale/barprovider.jar + test/java/util/PluggableLocale/providersrc/GenericTimeZoneNameProviderImpl.java ! test/java/util/PluggableLocale/providersrc/Makefile ! test/java/util/PluggableLocale/providersrc/java.util.spi.TimeZoneNameProvider ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java From maurizio.cimadamore at oracle.com Mon Dec 10 04:31:47 2012 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Mon, 10 Dec 2012 12:31:47 +0000 Subject: hg: jdk8/tl/langtools: 8004094: Javac compiler error - synthetic method accessor generated with duplicate name Message-ID: <20121210123154.906744700B@hg.openjdk.java.net> Changeset: c78acf6c2f3e Author: mcimadamore Date: 2012-12-10 12:10 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c78acf6c2f3e 8004094: Javac compiler error - synthetic method accessor generated with duplicate name Summary: method clash check logic should skip methods marked with ACC_SYNTHETIC Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/generics/8004094/B.java + test/tools/javac/generics/8004094/T8004094.java From michael.x.mcmahon at oracle.com Mon Dec 10 07:06:03 2012 From: michael.x.mcmahon at oracle.com (michael.x.mcmahon at oracle.com) Date: Mon, 10 Dec 2012 15:06:03 +0000 Subject: hg: jdk8/tl/jdk: 8003948: NTLM/Negotiate authentication problem Message-ID: <20121210150632.D753A47015@hg.openjdk.java.net> Changeset: fda2b2b5b98b Author: michaelm Date: 2012-12-10 14:56 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fda2b2b5b98b 8003948: NTLM/Negotiate authentication problem Reviewed-by: chegar, weijun ! src/share/classes/sun/net/www/MessageHeader.java ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java + test/sun/net/www/MessageHeaderTest.java From erik.joelsson at oracle.com Thu Dec 6 06:37:10 2012 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Thu, 06 Dec 2012 15:37:10 +0100 Subject: Review request: 8003562: Provide a command-line tool to find static dependencies In-Reply-To: <50BFF69E.1040805@oracle.com> References: <50B54A2C.1040907@oracle.com> <50BFF69E.1040805@oracle.com> Message-ID: <50C0AD96.30407@oracle.com> An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20121206/f4510cbc/attachment.html From boaznahum at gmail.com Sat Dec 8 08:12:30 2012 From: boaznahum at gmail.com (Boaz Nahum) Date: Sat, 8 Dec 2012 18:12:30 +0200 Subject: Still got verify error on static methods in interface Message-ID: Hi. I build 'JDK 8 lambda' few minutes ago, and still get verify error when trying to use static methods in interface. I'm running with -Xverify:none ...linux-x86_64-normal-server-release/images/j2sdk-image/bin/java -Xverify:none TestSI Exception in thread "main" java.lang.VerifyError: Illegal static method hello in interface SI I was told in lambda-dev 'It works fine for me..' I don't know what I'm doing wrong. My boot-jdk "1.7.0_09-icedtea" Thanks Boaz -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20121208/625b4807/attachment.html From erik.joelsson at oracle.com Mon Dec 10 02:30:10 2012 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Mon, 10 Dec 2012 02:30:10 -0800 (PST) Subject: Review request: 8003562: Provide a command-line tool to find static dependencies In-Reply-To: <50C265D8.3050107@oracle.com> References: <50B54A2C.1040907@oracle.com> <50BFF69E.1040805@oracle.com> <50C265D8.3050107@oracle.com> Message-ID: <50C5B9B2.2050705@oracle.com> Looks good. /Erik On 2012-12-07 22:55, Mandy Chung wrote: > This is the updated webrev. It includes Erik's makefile changes and > small change - be consistent with javap, jdeps can take classnames as > the input argument or wildcard "*" to analyze all class files that > replaces the "-all" option. > > Webrev: > http://cr.openjdk.java.net/~mchung/jdk8/webrevs/jdeps/webrev.03/ > > Mandy > > On 12/5/12 5:36 PM, Mandy Chung wrote: >> This review request (add a new jdeps tool in the JDK) include changes in >> langtools and the jdk build. I would need reviewers from the langtools >> and the build-infra team. >> >> Webrev for review: >> >> http://cr.openjdk.java.net/~mchung/jdk8/webrevs/jdeps/langtools-webrev.02/ >> http://cr.openjdk.java.net/~mchung/jdk8/webrevs/jdeps/jdk-webrev.02/ >> >> The jdeps source is in the langtools repo. The change in the jdk >> repo is >> to add the new jdeps executable. I made change in the old and new build >> for the addition of this new jdeps tool. I discussed with Jon whether I >> should modify langtools/make/build.xml to add a new jdeps target. Since >> the old build will be replaced by the new build soon, I simply add >> com/sun/tools/jdeps as part of javap.includes. >> >> Alan, >> >> The -d option is kept as a hidden option and use as implementation. We >> can remove it when it's determined not useful in the future. I also >> rename -v:summary to -summary. >> >> Thanks >> Mandy >> >> ---------------------------- >> >> $ jdep -h >> Usage: jdeps >> where possible options include: >> -version Version information >> -classpath Specify where to find class files >> -summary Print dependency summary only >> -v:class Print class-level dependencies >> -v:package Print package-level dependencies >> -p Restrict analysis to classes in this package >> (may be given multiple times) >> -e Restrict analysis to packages matching >> pattern >> (-p and -e are exclusive) >> -P --profile Show profile or the file containing a package >> -R --recursive Traverse all dependencies recursively >> -all Process all classes specified in -classpath >> >> $ jdep Notepad.jar Ensemble.jar >> Notepad.jar -> D:\tools\devtools\jdk8\windows-i586\jre\lib\rt.jar >> (Notepad.jar) >> -> java.awt >> -> java.awt.event >> -> java.beans >> -> java.io >> -> java.lang >> -> java.net >> -> java.util >> -> java.util.logging >> -> javax.swing >> -> javax.swing.border >> -> javax.swing.event >> -> javax.swing.text >> -> javax.swing.tree >> -> javax.swing.undo >> >> Ensemble.jar -> D:\tools\devtools\jdk8\windows-i586\jre\lib\jfxrt.jar >> Ensemble.jar -> D:\tools\devtools\jdk8\windows-i586\jre\lib\rt.jar >> com.javafx.main (Ensemble.jar) >> -> java.applet >> -> java.awt >> -> java.awt.event >> -> java.io >> -> java.lang >> -> java.lang.reflect >> -> java.net >> -> java.security >> -> java.util >> -> java.util.jar >> -> javax.swing >> -> sun.misc JDK internal API >> (rt.jar) > From mandy.chung at oracle.com Mon Dec 10 15:17:53 2012 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Mon, 10 Dec 2012 23:17:53 +0000 Subject: hg: jdk8/tl/jdk: 4819681: Typo in http://java.sun.com/j2se/1.4.1/docs/api/java/util/logging/LogManager.html Message-ID: <20121210231812.B49ED47020@hg.openjdk.java.net> Changeset: cac1bfaceaaa Author: mchung Date: 2012-12-10 15:15 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cac1bfaceaaa 4819681: Typo in http://java.sun.com/j2se/1.4.1/docs/api/java/util/logging/LogManager.html Summary: Simple capitalization typo in LogManager() description Reviewed-by: darcy, mchung ! src/share/classes/java/util/logging/LogManager.java From luchsh at linux.vnet.ibm.com Mon Dec 10 18:42:58 2012 From: luchsh at linux.vnet.ibm.com (luchsh at linux.vnet.ibm.com) Date: Tue, 11 Dec 2012 02:42:58 +0000 Subject: hg: jdk8/tl/jdk: 6512101: Incorrect encoding in NetworkInterface.getDisplayName() Message-ID: <20121211024324.4C83147036@hg.openjdk.java.net> Changeset: 883feced1cdd Author: dingxmin Date: 2012-12-11 10:42 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/883feced1cdd 6512101: Incorrect encoding in NetworkInterface.getDisplayName() Reviewed-by: chegar, dsamersoff ! src/windows/native/java/net/NetworkInterface.c From weijun.wang at oracle.com Mon Dec 10 21:15:30 2012 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Tue, 11 Dec 2012 05:15:30 +0000 Subject: hg: jdk8/tl/jdk: 8004488: wrong permissions checked in krb5 Message-ID: <20121211051541.92D194703D@hg.openjdk.java.net> Changeset: d206e52bf8a6 Author: weijun Date: 2012-12-11 13:14 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d206e52bf8a6 8004488: wrong permissions checked in krb5 Reviewed-by: xuelei ! src/share/classes/com/sun/security/auth/module/Krb5LoginModule.java ! src/share/classes/sun/security/jgss/krb5/Krb5Util.java + test/sun/security/krb5/auto/KeyPermissions.java ! test/sun/security/krb5/auto/KeyTabCompat.java From jonathan.gibbons at oracle.com Tue Dec 11 08:28:33 2012 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 11 Dec 2012 16:28:33 +0000 Subject: hg: jdk8/tl/langtools: 8003967: detect and remove all mutable implicit static enum fields in langtools Message-ID: <20121211162835.DAC7347067@hg.openjdk.java.net> Changeset: fcf89720ae71 Author: vromero Date: 2012-12-10 16:21 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/fcf89720ae71 8003967: detect and remove all mutable implicit static enum fields in langtools Reviewed-by: jjg ! src/share/classes/com/sun/tools/classfile/Opcode.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocFileFactory.java ! src/share/classes/com/sun/tools/javac/Server.java ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/code/Kinds.java ! src/share/classes/com/sun/tools/javac/code/Lint.java ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/code/TargetType.java ! src/share/classes/com/sun/tools/javac/code/TypeTag.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/ConstFold.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/file/ZipFileIndex.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/jvm/Target.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/main/Option.java ! src/share/classes/com/sun/tools/javac/parser/JavaTokenizer.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/util/BaseFileManager.java ! src/share/classes/com/sun/tools/javac/util/List.java ! src/share/classes/com/sun/tools/javac/util/MandatoryWarningHandler.java ! src/share/classes/com/sun/tools/javac/util/RichDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javah/JavahTask.java ! src/share/classes/com/sun/tools/javap/JavapTask.java ! src/share/classes/javax/lang/model/element/Modifier.java ! src/share/classes/javax/lang/model/util/ElementFilter.java ! src/share/classes/javax/tools/StandardLocation.java + test/tools/javac/T8003967/DetectMutableStaticFields.java From hsn at filez.com Tue Dec 11 12:00:44 2012 From: hsn at filez.com (Radim Kolar) Date: Tue, 11 Dec 2012 21:00:44 +0100 Subject: generic compile problem Message-ID: <50C790EC.2030609@filez.com> I need to know if javac is correct. Eclipse Juno compiles it. Program public class test2 { public void test() { Class > t = test2.class; } } C:\1>javac test2.java test2.java:4: error: incompatible types Class > t = test2.class; ^ required: Class> found: Class 1 error discussion with remarks to JLS is at https://bugs.eclipse.org/bugs/show_bug.cgi?id=396231 From alex.buckley at oracle.com Tue Dec 11 12:25:55 2012 From: alex.buckley at oracle.com (Alex Buckley) Date: Tue, 11 Dec 2012 12:25:55 -0800 Subject: generic compile problem In-Reply-To: <50C790EC.2030609@filez.com> References: <50C790EC.2030609@filez.com> Message-ID: <50C796D3.2080706@oracle.com> In an assignment context, is a widening reference conversion possible from Class to Class> ? In turn, is Class a subtype of Class> ? In turn, is test2 contained by '? extends test2' ? The rules of JLS 4.5.1 do not support that containment, so no, there is no formal subtype relation. Alex On 12/11/2012 12:00 PM, Radim Kolar wrote: > I need to know if javac is correct. Eclipse Juno compiles it. Program > > public class test2 { > > public void test() { > Class > t = test2.class; > } > } > > C:\1>javac test2.java > test2.java:4: error: incompatible types > Class > t = test2.class; > ^ > required: Class> > found: Class > 1 error > > discussion with remarks to JLS is at > https://bugs.eclipse.org/bugs/show_bug.cgi?id=396231 From hsn at filez.com Tue Dec 11 13:59:07 2012 From: hsn at filez.com (Radim Kolar) Date: Tue, 11 Dec 2012 22:59:07 +0100 Subject: generic compile problem In-Reply-To: <50C796D3.2080706@oracle.com> References: <50C790EC.2030609@filez.com> <50C796D3.2080706@oracle.com> Message-ID: <50C7ACAB.2010903@filez.com> i sent wrong example. This one is right, compiles only in eclipse. class Generic {} public class Casting { void test() { Class> generic = (Class>) Generic.class; } } javac: Casting.java:4: error: inconvertible types Class> generic = (Class>) Generic.class; From alex.buckley at oracle.com Tue Dec 11 15:02:00 2012 From: alex.buckley at oracle.com (Alex Buckley) Date: Tue, 11 Dec 2012 15:02:00 -0800 Subject: generic compile problem In-Reply-To: <50C7ACAB.2010903@filez.com> References: <50C790EC.2030609@filez.com> <50C796D3.2080706@oracle.com> <50C7ACAB.2010903@filez.com> Message-ID: <50C7BB68.20609@oracle.com> Can Class be cast to Class> ? In turn, is Class provably distinct from Class> (given that their erasures are the same) ? In turn, is 'Generic' provably distinct from '? extends Generic>' ? No, because |Generic| <: |Generic|. (JLS3 was not clear on this point. If both type arguments were ground types, JLS3 could prove them distinct and stop the cast, e.g. Class can never be cast to Class because Class is distinct from Class because String is distinct from Integer. However, JLS3 could not handle one or two wildcard type arguments. JLS7 takes the upper bound of a wildcard type argument - Generic - and considers it against the ground type argument - Generic - to conclude that the type arguments are basically related.) Therefore, there is no need for a compile-time error. Since Class is not a subtype of Class>, the cast is unchecked, and a compile-time unchecked warning is due. Alex On 12/11/2012 1:59 PM, Radim Kolar wrote: > i sent wrong example. This one is right, compiles only in eclipse. > > class Generic {} > public class Casting { > void test() { > Class> generic = (Class Generic>) Generic.class; > } > } > > javac: > Casting.java:4: error: inconvertible types > Class> generic = (Class Generic>) Generic.class; > From jonathan.gibbons at oracle.com Tue Dec 11 15:05:56 2012 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 11 Dec 2012 23:05:56 +0000 Subject: hg: jdk8/tl/langtools: 8004828: refactor init of *DocImpl classes Message-ID: <20121211230601.6FED947097@hg.openjdk.java.net> Changeset: cfde9737131e Author: jjg Date: 2012-12-11 15:05 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/cfde9737131e 8004828: refactor init of *DocImpl classes Reviewed-by: darcy ! src/share/classes/com/sun/tools/javadoc/AnnotationTypeDocImpl.java ! src/share/classes/com/sun/tools/javadoc/AnnotationTypeElementDocImpl.java ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java ! src/share/classes/com/sun/tools/javadoc/ConstructorDocImpl.java ! src/share/classes/com/sun/tools/javadoc/DocEnv.java ! src/share/classes/com/sun/tools/javadoc/DocImpl.java ! src/share/classes/com/sun/tools/javadoc/ExecutableMemberDocImpl.java ! src/share/classes/com/sun/tools/javadoc/FieldDocImpl.java ! src/share/classes/com/sun/tools/javadoc/JavadocEnter.java ! src/share/classes/com/sun/tools/javadoc/JavadocMemberEnter.java ! src/share/classes/com/sun/tools/javadoc/MemberDocImpl.java ! src/share/classes/com/sun/tools/javadoc/MethodDocImpl.java ! src/share/classes/com/sun/tools/javadoc/PackageDocImpl.java ! src/share/classes/com/sun/tools/javadoc/ProgramElementDocImpl.java ! src/share/classes/com/sun/tools/javadoc/RootDocImpl.java From mike.duigou at oracle.com Tue Dec 11 15:49:54 2012 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Tue, 11 Dec 2012 23:49:54 +0000 Subject: hg: jdk8/tl/jdk: 8003246: Add InitialValue Supplier to ThreadLocal Message-ID: <20121211235017.14A764709A@hg.openjdk.java.net> Changeset: c4bd81de2868 Author: akhil Date: 2012-12-11 15:33 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c4bd81de2868 8003246: Add InitialValue Supplier to ThreadLocal Reviewed-by: mduigou, forax, dl, chegar, briangoetz ! src/share/classes/java/lang/ThreadLocal.java + test/java/lang/ThreadLocal/ThreadLocalSupplierTest.java From mike.duigou at oracle.com Tue Dec 11 20:50:55 2012 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Wed, 12 Dec 2012 04:50:55 +0000 Subject: hg: jdk8/tl/jdk: 8004905: Correct license of test to remove classpath exception Message-ID: <20121212045118.9651C470AE@hg.openjdk.java.net> Changeset: 6c795437f212 Author: mduigou Date: 2012-12-11 20:49 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6c795437f212 8004905: Correct license of test to remove classpath exception Reviewed-by: akhil ! test/java/lang/ThreadLocal/ThreadLocalSupplierTest.java From weijun.wang at oracle.com Wed Dec 12 02:41:08 2012 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Wed, 12 Dec 2012 10:41:08 +0000 Subject: hg: jdk8/tl/jdk: 8004904: Makefile for ntlm Message-ID: <20121212104501.70F4F470BB@hg.openjdk.java.net> Changeset: 12fba0974a9d Author: weijun Date: 2012-12-12 18:39 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/12fba0974a9d 8004904: Makefile for ntlm Reviewed-by: erikj, chegar ! make/com/sun/security/Makefile + make/com/sun/security/ntlm/Makefile From chris.hegarty at oracle.com Wed Dec 12 03:36:21 2012 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Wed, 12 Dec 2012 11:36:21 +0000 Subject: hg: jdk8/tl/jdk: 8004921: Trivial javadoc warnings in Base64 Message-ID: <20121212113645.3471B470BD@hg.openjdk.java.net> Changeset: 806cf26e5063 Author: chegar Date: 2012-12-12 11:35 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/806cf26e5063 8004921: Trivial javadoc warnings in Base64 Reviewed-by: darcy ! src/share/classes/java/util/Base64.java From alan.bateman at oracle.com Wed Dec 12 05:06:39 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Wed, 12 Dec 2012 13:06:39 +0000 Subject: hg: jdk8/tl/jdk: 8004874: Reduce dependency on java.beans to only add/removePropertyChangeListener Message-ID: <20121212130702.533D2470BE@hg.openjdk.java.net> Changeset: 81640e75c7a7 Author: alanb Date: 2012-12-12 13:03 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/81640e75c7a7 8004874: Reduce dependency on java.beans to only add/removePropertyChangeListener Reviewed-by: ksrini, mchung, dholmes ! src/share/classes/com/sun/java/util/jar/pack/PropMap.java ! src/share/classes/java/util/logging/LogManager.java From sean.mullan at oracle.com Wed Dec 12 06:48:39 2012 From: sean.mullan at oracle.com (sean.mullan at oracle.com) Date: Wed, 12 Dec 2012 14:48:39 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20121212144946.95267470C0@hg.openjdk.java.net> Changeset: 346c0af4af41 Author: mullan Date: 2012-12-12 09:25 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/346c0af4af41 8004064: Downgrade normative references to ${java.home}/lib/security/java.security Reviewed-by: alanb, vinnie, xuelei ! src/share/classes/com/sun/net/ssl/KeyManagerFactory.java ! src/share/classes/com/sun/net/ssl/TrustManagerFactory.java ! src/share/classes/com/sun/security/auth/PolicyFile.java ! src/share/classes/com/sun/security/auth/login/ConfigFile.java ! src/share/classes/java/net/doc-files/net-properties.html ! src/share/classes/java/security/KeyStore.java ! src/share/classes/java/security/Policy.java ! src/share/classes/java/security/Security.java ! src/share/classes/java/security/cert/CertPathBuilder.java ! src/share/classes/java/security/cert/CertPathValidator.java ! src/share/classes/java/security/cert/CertStore.java ! src/share/classes/javax/net/ssl/KeyManagerFactory.java ! src/share/classes/javax/net/ssl/TrustManagerFactory.java ! src/share/classes/javax/security/auth/Policy.java ! src/share/classes/javax/security/auth/callback/CallbackHandler.java ! src/share/classes/javax/security/auth/login/Configuration.java ! src/share/classes/javax/security/auth/login/LoginContext.java ! src/share/classes/javax/security/cert/X509Certificate.java Changeset: c7f86908d5fd Author: mullan Date: 2012-12-12 09:27 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c7f86908d5fd Merge - src/share/lib/security/java.security From rob.mckenna at oracle.com Wed Dec 12 07:53:52 2012 From: rob.mckenna at oracle.com (rob.mckenna at oracle.com) Date: Wed, 12 Dec 2012 15:53:52 +0000 Subject: hg: jdk8/tl/jdk: 8004337: java/sql tests aren't run in test/Makefile Message-ID: <20121212155414.29B01470C5@hg.openjdk.java.net> Changeset: 68374c6e65c1 Author: robm Date: 2012-12-12 15:57 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/68374c6e65c1 8004337: java/sql tests aren't run in test/Makefile Reviewed-by: lancea, alanb ! test/Makefile From stuart.marks at oracle.com Wed Dec 12 10:16:18 2012 From: stuart.marks at oracle.com (stuart.marks at oracle.com) Date: Wed, 12 Dec 2012 18:16:18 +0000 Subject: hg: jdk8/tl/jdk: 8004748: clean up @build tags in RMI tests Message-ID: <20121212181630.EDE2E470CD@hg.openjdk.java.net> Changeset: bd84d0927a2e Author: smarks Date: 2012-12-12 09:53 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bd84d0927a2e 8004748: clean up @build tags in RMI tests Reviewed-by: alanb, darcy, mchung ! test/java/rmi/MarshalledObject/compare/Compare.java ! test/java/rmi/MarshalledObject/compare/HashCode.java ! test/java/rmi/MarshalledObject/compare/NullReference.java ! test/java/rmi/Naming/DefaultRegistryPort.java ! test/java/rmi/Naming/LookupIPv6.java ! test/java/rmi/Naming/RmiIsNoScheme.java ! test/java/rmi/Naming/UnderscoreHost.java ! test/java/rmi/Naming/legalRegistryNames/LegalRegistryNames.java ! test/java/rmi/RMISecurityManager/checkPackageAccess/CheckPackageAccess.java ! test/java/rmi/activation/Activatable/checkActivateRef/CheckActivateRef.java ! test/java/rmi/activation/Activatable/checkAnnotations/CheckAnnotations.java ! test/java/rmi/activation/Activatable/checkImplClassLoader/CheckImplClassLoader.java ! test/java/rmi/activation/Activatable/checkRegisterInLog/CheckRegisterInLog.java ! test/java/rmi/activation/Activatable/createPrivateActivable/CreatePrivateActivatable.java ! test/java/rmi/activation/Activatable/downloadParameterClass/DownloadParameterClass.java ! test/java/rmi/activation/Activatable/elucidateNoSuchMethod/ElucidateNoSuchMethod.java ! test/java/rmi/activation/Activatable/extLoadedImpl/ext.sh ! test/java/rmi/activation/Activatable/forceLogSnapshot/ForceLogSnapshot.java ! test/java/rmi/activation/Activatable/inactiveGroup/InactiveGroup.java ! test/java/rmi/activation/Activatable/lookupActivationSystem/LookupActivationSystem.java ! test/java/rmi/activation/Activatable/nestedActivate/NestedActivate.java ! test/java/rmi/activation/Activatable/nonExistentActivatable/NonExistentActivatable.java ! test/java/rmi/activation/Activatable/restartCrashedService/RestartCrashedService.java ! test/java/rmi/activation/Activatable/restartLatecomer/RestartLatecomer.java ! test/java/rmi/activation/Activatable/restartService/RestartService.java ! test/java/rmi/activation/Activatable/shutdownGracefully/ShutdownGracefully.java ! test/java/rmi/activation/Activatable/unregisterInactive/UnregisterInactive.java ! test/java/rmi/activation/ActivateFailedException/activateFails/ActivateFails.java ! test/java/rmi/activation/ActivationGroup/downloadActivationGroup/DownloadActivationGroup.java ! test/java/rmi/activation/ActivationGroupDesc/checkDefaultGroupName/CheckDefaultGroupName.java ! test/java/rmi/activation/ActivationSystem/activeGroup/IdempotentActiveGroup.java ! test/java/rmi/activation/ActivationSystem/modifyDescriptor/ModifyDescriptor.java ! test/java/rmi/activation/ActivationSystem/stubClassesPermitted/StubClassesPermitted.java ! test/java/rmi/activation/ActivationSystem/unregisterGroup/UnregisterGroup.java ! test/java/rmi/activation/CommandEnvironment/NullOptions.java ! test/java/rmi/activation/CommandEnvironment/SetChildEnv.java ! test/java/rmi/activation/checkusage/CheckUsage.java ! test/java/rmi/activation/log/LogTest.java ! test/java/rmi/activation/rmidViaInheritedChannel/InheritedChannelNotServerSocket.java ! test/java/rmi/activation/rmidViaInheritedChannel/RmidViaInheritedChannel.java ! test/java/rmi/dgc/VMID/CheckVMID.java ! test/java/rmi/dgc/dgcAckFailure/DGCAckFailure.java ! test/java/rmi/dgc/dgcImplInsulation/DGCImplInsulation.java ! test/java/rmi/dgc/retryDirtyCalls/RetryDirtyCalls.java ! test/java/rmi/invalidName/InvalidName.java ! test/java/rmi/registry/altSecurityManager/AltSecurityManager.java ! test/java/rmi/registry/checkusage/CheckUsage.java ! test/java/rmi/registry/classPathCodebase/ClassPathCodebase.java ! test/java/rmi/registry/interfaceHash/InterfaceHash.java ! test/java/rmi/registry/multipleRegistries/MultipleRegistries.java ! test/java/rmi/registry/readTest/readTest.sh ! test/java/rmi/registry/reexport/Reexport.java ! test/java/rmi/reliability/benchmark/runRmiBench.sh ! test/java/rmi/reliability/benchmark/runSerialBench.sh ! test/java/rmi/reliability/juicer/AppleUserImpl.java ! test/java/rmi/server/ObjID/randomIDs/RandomIDs.java ! test/java/rmi/server/RMIClassLoader/delegateBeforePermissionCheck/DelegateBeforePermissionCheck.java ! test/java/rmi/server/RMIClassLoader/delegateToContextLoader/DelegateToContextLoader.java ! test/java/rmi/server/RMIClassLoader/downloadArrayClass/DownloadArrayClass.java ! test/java/rmi/server/RMIClassLoader/getClassAnnotation/NullClass.java ! test/java/rmi/server/RMIClassLoader/getClassLoader/GetClassLoader.java ! test/java/rmi/server/RMIClassLoader/loadProxyClasses/LoadProxyClasses.java ! test/java/rmi/server/RMIClassLoader/noSecurityManager/NoSecurityManager.java ! test/java/rmi/server/RMIClassLoader/spi/ContextInsulation.java ! test/java/rmi/server/RMIClassLoader/spi/DefaultProperty.java ! test/java/rmi/server/RMIClassLoader/spi/Installed.java ! test/java/rmi/server/RMIClassLoader/spi/InvalidProperty.java ! test/java/rmi/server/RMIClassLoader/spi/Property.java ! test/java/rmi/server/RMIClassLoader/useCodebaseOnly/UseCodebaseOnly.java ! test/java/rmi/server/RMIClassLoader/useGetURLs/UseGetURLs.java ! test/java/rmi/server/RMISocketFactory/useSocketFactory/activatable/UseCustomSocketFactory.java ! test/java/rmi/server/RMISocketFactory/useSocketFactory/registry/UseCustomSocketFactory.java ! test/java/rmi/server/RMISocketFactory/useSocketFactory/unicast/UseCustomSocketFactory.java ! test/java/rmi/server/RemoteObject/notExtending/NotExtending.java ! test/java/rmi/server/RemoteObject/verifyRemoteEquals/VerifyRemoteEquals.java ! test/java/rmi/server/RemoteServer/AddrInUse.java ! test/java/rmi/server/UnicastRemoteObject/changeHostName/ChangeHostName.java ! test/java/rmi/server/UnicastRemoteObject/exportObject/GcDuringExport.java ! test/java/rmi/server/UnicastRemoteObject/keepAliveDuringCall/KeepAliveDuringCall.java ! test/java/rmi/server/UnicastRemoteObject/marshalAfterUnexport/MarshalAfterUnexport.java ! test/java/rmi/server/UnicastRemoteObject/marshalAfterUnexport/MarshalAfterUnexport2.java ! test/java/rmi/server/UnicastRemoteObject/unexportObject/UnexportLeak.java ! test/java/rmi/server/Unmarshal/PrimitiveClasses.java + test/java/rmi/server/Unmarshal/checkUnmarshalOnStopThread/CheckUnmarshal.java ! test/java/rmi/server/Unmarshal/checkUnmarshalOnStopThread/CheckUnmarshalOnStopThread.java - test/java/rmi/server/Unmarshal/checkUnmarshalOnStopThread/CheckUnmarshall.java ! test/java/rmi/server/Unreferenced/finiteGCLatency/FiniteGCLatency.java ! test/java/rmi/server/Unreferenced/leaseCheckInterval/LeaseCheckInterval.java ! test/java/rmi/server/Unreferenced/marshalledObjectGet/MarshalledObjectGet.java ! test/java/rmi/server/Unreferenced/unreferencedContext/UnreferencedContext.java ! test/java/rmi/server/clientStackTrace/ClientStackTrace.java ! test/java/rmi/server/getRemoteClass/GetRemoteClass.java ! test/java/rmi/server/serverStackTrace/ServerStackTrace.java ! test/java/rmi/server/serverStackTrace/SuppressStackTraces.java ! test/java/rmi/server/useCustomRef/UseCustomRef.java ! test/java/rmi/transport/acceptLoop/CloseServerSocketOnTermination.java ! test/java/rmi/transport/checkFQDN/CheckFQDN.java ! test/java/rmi/transport/checkLeaseInfoLeak/CheckLeaseLeak.java ! test/java/rmi/transport/closeServerSocket/CloseServerSocket.java ! test/java/rmi/transport/dgcDeadLock/DGCDeadLock.java ! test/java/rmi/transport/handshakeFailure/HandshakeFailure.java ! test/java/rmi/transport/handshakeTimeout/HandshakeTimeout.java ! test/java/rmi/transport/httpSocket/HttpSocketTest.java ! test/java/rmi/transport/rapidExportUnexport/RapidExportUnexport.java ! test/java/rmi/transport/readTimeout/ReadTimeoutTest.java ! test/java/rmi/transport/reuseDefaultPort/ReuseDefaultPort.java ! test/java/rmi/transport/runtimeThreadInheritanceLeak/RuntimeThreadInheritanceLeak.java ! test/javax/rmi/ssl/SocketFactoryTest.java ! test/sun/rmi/log/ReliableLog/LogAlignmentTest.java ! test/sun/rmi/log/ReliableLog/SnapshotSize.java ! test/sun/rmi/rmic/RMIGenerator/RmicDefault.java ! test/sun/rmi/rmic/newrmic/equivalence/run.sh ! test/sun/rmi/runtime/Log/6409194/NoConsoleOutput.java ! test/sun/rmi/runtime/Log/checkLogging/CheckLogStreams.java ! test/sun/rmi/runtime/Log/checkLogging/CheckLogging.java ! test/sun/rmi/server/MarshalOutputStream/marshalForeignStub/MarshalForeignStub.java ! test/sun/rmi/transport/proxy/EagerHttpFallback.java ! test/sun/rmi/transport/tcp/DeadCachedConnection.java ! test/sun/rmi/transport/tcp/blockAccept/BlockAcceptTest.java ! test/sun/rmi/transport/tcp/disableMultiplexing/DisableMultiplexing.java From jonathan.gibbons at oracle.com Wed Dec 12 14:42:06 2012 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Wed, 12 Dec 2012 22:42:06 +0000 Subject: hg: jdk8/tl/langtools: 8004504: ListBuffer could reuse List.nil() as the sentinel element Message-ID: <20121212224208.B5808470ED@hg.openjdk.java.net> Changeset: 170e486632d9 Author: jlahoda Date: 2012-12-12 20:26 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/170e486632d9 8004504: ListBuffer could reuse List.nil() as the sentinel element Summary: ListBuffer.last now points to the last elements with client data, or null if none. Reviewed-by: jjg, mcimadamore ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/util/ListBuffer.java + test/tools/javac/util/list/ListBufferTest.java From jonathan.gibbons at oracle.com Wed Dec 12 14:50:41 2012 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Wed, 12 Dec 2012 14:50:41 -0800 Subject: hg: jdk8/tl/langtools: 8004504: ListBuffer could reuse List.nil() as the sentinel element In-Reply-To: <20121212224208.B5808470ED@hg.openjdk.java.net> References: <20121212224208.B5808470ED@hg.openjdk.java.net> Message-ID: <50C90A41.4010602@oracle.com> With this changeset, we welcome Jan Lahoda as an Author directly providing changesets for javac in JDK 8. Jan is on the NetBeans team, and helps provide the red squiggly lines and other features in the Java editor windows, amongst his other duties, so he is more than a little familiar with the javac codebase. :-) He's already provided a number of contributions -- just do "hg log -k lahoda" in a langtools repository to get a list. -- Jon On 12/12/2012 02:42 PM, jonathan.gibbons at oracle.com wrote: > Changeset: 170e486632d9 > Author: jlahoda > Date: 2012-12-12 20:26 +0100 > URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/170e486632d9 > > 8004504: ListBuffer could reuse List.nil() as the sentinel element > Summary: ListBuffer.last now points to the last elements with client data, or null if none. > Reviewed-by: jjg, mcimadamore > > ! src/share/classes/com/sun/tools/javac/jvm/Code.java > ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java > ! src/share/classes/com/sun/tools/javac/util/ListBuffer.java > + test/tools/javac/util/list/ListBufferTest.java > From stuart.marks at oracle.com Wed Dec 12 15:36:13 2012 From: stuart.marks at oracle.com (stuart.marks at oracle.com) Date: Wed, 12 Dec 2012 23:36:13 +0000 Subject: hg: jdk8/tl/jdk: 8004651: TEST: java/util/logging/CheckLockLocationTest.java failed to delete file (win) Message-ID: <20121212233633.B1748470F0@hg.openjdk.java.net> Changeset: 56fd5479a98f Author: jgish Date: 2012-12-12 15:37 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/56fd5479a98f 8004651: TEST: java/util/logging/CheckLockLocationTest.java failed to delete file (win) Summary: Failure to delete test log file should be a warning instead of test failure Reviewed-by: mduigou, smarks ! test/java/util/logging/CheckLockLocationTest.java From weijun.wang at oracle.com Wed Dec 12 16:12:35 2012 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Thu, 13 Dec 2012 00:12:35 +0000 Subject: hg: jdk8/tl/jdk: 8004235: Disable native JGSS provider on Mac Message-ID: <20121213001247.26992470F2@hg.openjdk.java.net> Changeset: 5a2ab2c3f106 Author: weijun Date: 2012-12-13 08:11 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5a2ab2c3f106 8004235: Disable native JGSS provider on Mac Reviewed-by: erikj, valeriep ! make/sun/security/Makefile ! makefiles/CompileNativeLibraries.gmk ! src/share/classes/sun/security/jgss/wrapper/SunNativeProvider.java From lance.andersen at oracle.com Wed Dec 12 17:59:14 2012 From: lance.andersen at oracle.com (lance.andersen at oracle.com) Date: Thu, 13 Dec 2012 01:59:14 +0000 Subject: hg: jdk8/tl/jdk: 8004357: Implement various methods in SerialBlob/Clob/Array and specify Thread Safety Message-ID: <20121213015927.3E708470F5@hg.openjdk.java.net> Changeset: 7a8978a5bb6e Author: lancea Date: 2012-12-12 20:57 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7a8978a5bb6e 8004357: Implement various methods in SerialBlob/Clob/Array and specify Thread Safety Reviewed-by: naoto ! src/share/classes/javax/sql/rowset/serial/SerialArray.java ! src/share/classes/javax/sql/rowset/serial/SerialBlob.java ! src/share/classes/javax/sql/rowset/serial/SerialClob.java ! src/share/classes/javax/sql/rowset/serial/SerialDatalink.java ! src/share/classes/javax/sql/rowset/serial/SerialJavaObject.java ! src/share/classes/javax/sql/rowset/serial/SerialRef.java ! src/share/classes/javax/sql/rowset/serial/SerialStruct.java From chris.hegarty at oracle.com Thu Dec 13 01:57:15 2012 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Thu, 13 Dec 2012 09:57:15 +0000 Subject: hg: jdk8/tl/jdk: 8004925: java/net/Socks/SocksV4Test.java failing on all platforms Message-ID: <20121213095811.50B2E470FE@hg.openjdk.java.net> Changeset: 775b0050144a Author: chegar Date: 2012-12-13 09:55 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/775b0050144a 8004925: java/net/Socks/SocksV4Test.java failing on all platforms Reviewed-by: alanb, dsamersoff ! test/java/net/Socks/SocksV4Test.java From chris.hegarty at oracle.com Thu Dec 13 06:34:33 2012 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Thu, 13 Dec 2012 14:34:33 +0000 Subject: hg: jdk8/tl/jdk: 8004675: Inet6Address.getHostAddress should use string scope identifier where available Message-ID: <20121213143445.2B5D047108@hg.openjdk.java.net> Changeset: 682d2d3ccff5 Author: chegar Date: 2012-12-13 14:33 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/682d2d3ccff5 8004675: Inet6Address.getHostAddress should use string scope identifier where available Summary: ...and some minor stylistic cleanup Reviewed-by: khazra, dsamersoff, michaelm ! src/share/classes/java/net/Inet6Address.java ! src/share/native/java/net/Inet6Address.c + test/java/net/Inet6Address/StringScope.java From sean.mullan at oracle.com Thu Dec 13 06:37:41 2012 From: sean.mullan at oracle.com (sean.mullan at oracle.com) Date: Thu, 13 Dec 2012 14:37:41 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20121213143805.4F23147109@hg.openjdk.java.net> Changeset: c97618a3c8c2 Author: juh Date: 2012-12-13 09:35 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c97618a3c8c2 7193792: sun/security/pkcs11/ec/TestECDSA.java failing intermittently Reviewed-by: vinnie, wetmore ! test/ProblemList.txt ! test/sun/security/pkcs11/ec/TestECDSA.java Changeset: 7b697da6626a Author: mullan Date: 2012-12-13 09:37 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7b697da6626a Merge From chris.hegarty at oracle.com Thu Dec 13 06:48:45 2012 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Thu, 13 Dec 2012 14:48:45 +0000 Subject: hg: jdk8/tl/jdk: 8003890: corelibs test scripts should pass TESTVMOPTS Message-ID: <20121213144857.1B39D4710A@hg.openjdk.java.net> Changeset: ae5d04dbacd6 Author: chegar Date: 2012-12-13 14:47 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ae5d04dbacd6 8003890: corelibs test scripts should pass TESTVMOPTS Reviewed-by: chegar, alanb Contributed-by: Mark Sheppard ! test/com/oracle/net/sanity.sh ! test/com/sun/corba/cachedSocket/7056731.sh ! test/com/sun/management/OperatingSystemMXBean/TestTotalSwap.sh ! test/com/sun/management/UnixOperatingSystemMXBean/GetMaxFileDescriptorCount.sh ! test/com/sun/management/UnixOperatingSystemMXBean/GetOpenFileDescriptorCount.sh ! test/com/sun/tools/attach/ApplicationSetup.sh ! test/com/sun/tools/attach/BasicTests.sh ! test/com/sun/tools/attach/PermissionTests.sh ! test/com/sun/tools/attach/ProviderTests.sh ! test/com/sun/tools/extcheck/TestExtcheckArgs.sh ! test/demo/zipfs/basic.sh ! test/java/io/File/GetXSpace.sh ! test/java/io/File/MacPathTest.sh ! test/java/io/File/basic.sh ! test/java/io/FileOutputStream/FileOpen.sh ! test/java/io/Serializable/class/run.sh ! test/java/io/Serializable/evolution/AddedExternField/run.sh ! test/java/io/Serializable/evolution/RenamePackage/run.sh ! test/java/io/Serializable/maskSyntheticModifier/run.sh ! test/java/io/Serializable/packageAccess/run.sh ! test/java/io/Serializable/resolveClass/consTest/run.sh ! test/java/io/Serializable/resolveClass/deserializeButton/run.sh ! test/java/io/Serializable/subclass/run.sh ! test/java/io/Serializable/superclassDataLoss/run.sh ! test/java/io/Serializable/unnamedPackageSwitch/run.sh ! test/java/lang/Class/forName/NonJavaNames.sh ! test/java/lang/ClassLoader/Assert.sh ! test/java/lang/ClassLoader/deadlock/TestCrossDelegate.sh ! test/java/lang/ClassLoader/deadlock/TestOneWayDelegate.sh ! test/java/lang/ClassLoader/getdotresource.sh ! test/java/lang/Runtime/exec/setcwd.sh ! test/java/lang/StringCoding/CheckEncodings.sh ! test/java/lang/System/finalization/FinExit.sh ! test/java/lang/annotation/loaderLeak/LoaderLeak.sh ! test/java/lang/management/OperatingSystemMXBean/TestSystemLoadAvg.sh ! test/java/net/Authenticator/B4933582.sh ! test/java/net/DatagramSocket/SetDatagramSocketImplFactory/ADatagramSocket.sh ! test/java/net/InetAddress/ptr/lookup.sh ! test/java/net/ServerSocket/AcceptCauseFileDescriptorLeak.sh ! test/java/net/Socket/OldSocketImpl.sh ! test/java/net/URL/B5086147.sh ! test/java/net/URL/runconstructor.sh ! test/java/net/URLClassLoader/B5077773.sh ! test/java/net/URLClassLoader/getresourceasstream/test.sh ! test/java/net/URLClassLoader/sealing/checksealed.sh ! test/java/net/URLConnection/6212146/test.sh ! test/java/net/URLConnection/UNCTest.sh ! test/java/nio/Buffer/LimitDirectMemory.sh ! test/java/nio/channels/AsynchronousChannelGroup/run_any_task.sh ! test/java/nio/channels/spi/AsynchronousChannelProvider/custom_provider.sh ! test/java/nio/charset/Charset/default.sh ! test/java/nio/charset/coders/CheckSJISMappingProp.sh ! test/java/nio/charset/spi/basic.sh ! test/java/nio/file/Files/delete_on_close.sh ! test/java/nio/file/Files/walkFileTree/walk_file_tree.sh ! test/java/nio/file/Path/MacPathTest.sh ! test/java/rmi/activation/Activatable/extLoadedImpl/ext.sh ! test/java/rmi/registry/readTest/readTest.sh ! test/java/rmi/reliability/benchmark/runSerialBench.sh ! test/java/security/Security/ClassLoaderDeadlock/ClassLoaderDeadlock.sh ! test/java/security/Security/ClassLoaderDeadlock/Deadlock.sh ! test/java/security/Security/ClassLoaderDeadlock/Deadlock2.sh ! test/java/security/Security/signedfirst/Dyn.sh ! test/java/security/Security/signedfirst/Static.sh ! test/java/security/cert/CertificateFactory/slowstream.sh ! test/java/util/Currency/PropertiesTest.sh ! test/java/util/Locale/LocaleCategory.sh ! test/java/util/Locale/LocaleProviders.sh ! test/java/util/PluggableLocale/ExecTest.sh ! test/java/util/ResourceBundle/Bug6299235Test.sh ! test/java/util/ResourceBundle/Control/MissingResourceCauseTest.sh ! test/java/util/ServiceLoader/basic.sh ! test/java/util/TimeZone/OldIDMappingTest.sh ! test/java/util/TimeZone/TimeZoneDatePermissionCheck.sh ! test/java/util/prefs/CheckUserPrefsStorage.sh ! test/java/util/prefs/PrefsSpi.sh ! test/java/util/spi/ResourceBundleControlProvider/UserDefaultControlTest.sh ! test/java/util/zip/3GBZipFiles.sh ! test/java/util/zip/ZipFile/deletetempjar.sh ! test/javax/crypto/SecretKeyFactory/FailOverTest.sh ! test/javax/print/applet/AppletPrintLookup.sh ! test/javax/script/ProviderTest.sh ! test/javax/security/auth/Subject/doAs/Test.sh ! test/lib/security/java.policy/Ext_AllPolicy.sh ! test/sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh ! test/sun/management/jmxremote/bootstrap/CustomLauncherTest.sh ! test/sun/management/jmxremote/bootstrap/LocalManagementTest.sh ! test/sun/management/jmxremote/bootstrap/PasswordFilePermissionTest.sh ! test/sun/management/jmxremote/bootstrap/SSLConfigFilePermissionTest.sh ! test/sun/management/jmxremote/startstop/JMXStartStopTest.sh ! test/sun/misc/Cleaner/exitOnThrow.sh ! test/sun/net/InetAddress/nameservice/dns/cname.sh ! test/sun/net/sdp/sanity.sh ! test/sun/net/www/MarkResetTest.sh ! test/sun/net/www/http/HttpClient/RetryPost.sh ! test/sun/net/www/protocol/file/DirPermissionDenied.sh ! test/sun/net/www/protocol/jar/B5105410.sh ! test/sun/net/www/protocol/jar/getcontenttype.sh ! test/sun/net/www/protocol/jar/jarbug/run.sh ! test/sun/rmi/rmic/manifestClassPath/run.sh ! test/sun/rmi/rmic/minimizeWrapperInstances/run.sh ! test/sun/rmi/rmic/oldjavacRemoved/sunToolsJavacMain.sh ! test/sun/security/krb5/runNameEquals.sh ! test/sun/security/krb5/tools/ktcheck.sh ! test/sun/security/mscapi/AccessKeyStore.sh ! test/sun/security/mscapi/IsSunMSCAPIAvailable.sh ! test/sun/security/mscapi/KeyStoreCompatibilityMode.sh ! test/sun/security/mscapi/PublicKeyInterop.sh ! test/sun/security/mscapi/RSAEncryptDecrypt.sh ! test/sun/security/mscapi/ShortRSAKey1024.sh ! test/sun/security/mscapi/SignUsingNONEwithRSA.sh ! test/sun/security/mscapi/SignUsingSHA2withRSA.sh ! test/sun/security/pkcs11/KeyStore/Basic.sh ! test/sun/security/pkcs11/KeyStore/ClientAuth.sh ! test/sun/security/pkcs11/KeyStore/SecretKeysBasic.sh ! test/sun/security/pkcs11/KeyStore/Solaris.sh ! test/sun/security/pkcs11/Provider/ConfigQuotedString.sh ! test/sun/security/pkcs11/Provider/Login.sh ! test/sun/security/provider/PolicyFile/GrantAllPermToExtWhenNoPolicy.sh ! test/sun/security/provider/PolicyFile/getinstance/getinstance.sh ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/EngineArgs/DebugReportsOneExtraByte.sh ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLSocketImpl/NotifyHandshakeTest.sh ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/PostThruProxy.sh ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/PostThruProxyWithAuth.sh ! test/sun/security/tools/jarsigner/emptymanifest.sh ! test/sun/security/tools/jarsigner/ts.sh ! test/sun/security/tools/keytool/printssl.sh ! test/sun/security/tools/keytool/standard.sh ! test/sun/security/validator/certreplace.sh ! test/sun/security/validator/samedn.sh ! test/tools/launcher/6842838/Test6842838.sh ! test/tools/launcher/MultipleJRE.sh From rob.mckenna at oracle.com Thu Dec 13 07:24:20 2012 From: rob.mckenna at oracle.com (rob.mckenna at oracle.com) Date: Thu, 13 Dec 2012 15:24:20 +0000 Subject: hg: jdk8/tl/jdk: 8000525: Java.net.httpcookie api does not support 2-digit year format Message-ID: <20121213152432.0C2154710D@hg.openjdk.java.net> Changeset: 087425441a48 Author: robm Date: 2012-12-13 15:28 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/087425441a48 8000525: Java.net.httpcookie api does not support 2-digit year format Reviewed-by: chegar ! src/share/classes/java/net/HttpCookie.java ! test/java/net/CookieHandler/B6791927.java ! test/java/net/CookieHandler/CookieManagerTest.java + test/java/net/HttpCookie/ExpiredCookieTest.java From jonathan.gibbons at oracle.com Thu Dec 13 16:06:57 2012 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Thu, 13 Dec 2012 16:06:57 -0800 Subject: Review request: 8003562: Provide a command-line tool to find static dependencies In-Reply-To: <50C5B9B2.2050705@oracle.com> References: <50B54A2C.1040907@oracle.com> <50BFF69E.1040805@oracle.com> <50C265D8.3050107@oracle.com> <50C5B9B2.2050705@oracle.com> Message-ID: <50CA6DA1.1070004@oracle.com> Mandy, Mostly good -- and nice to see Dependencies getting the full tool treatment. -- Jon Archive.java:128 non-localized text: "not found" ClassFileReader.java:74, ditto similar code in JarFileReader Will not work for inner classes. ClassFileReader.java:various Langtools is (for a while longer) still using -source 6. This is to allow NetBeans to build and use langtools. I guess the code here is OK as long as NB don't try and build all of langtools. JDepsTask:111 Did you mean --summary? If you're wanting to emulate the GNU-style --options, these options normally use =, as in --name=value, so you might want to update handleOption. PlatformClassPath The API you are looking for is now available in the profiles forest, in langtools/src/classes/com/sun/tools/javac/sym -- Jon On 12/10/2012 02:30 AM, Erik Joelsson wrote: > Looks good. > > /Erik > > On 2012-12-07 22:55, Mandy Chung wrote: >> This is the updated webrev. It includes Erik's makefile changes and >> small change - be consistent with javap, jdeps can take classnames as >> the input argument or wildcard "*" to analyze all class files that >> replaces the "-all" option. >> >> Webrev: >> http://cr.openjdk.java.net/~mchung/jdk8/webrevs/jdeps/webrev.03/ >> >> Mandy >> >> On 12/5/12 5:36 PM, Mandy Chung wrote: >>> This review request (add a new jdeps tool in the JDK) include >>> changes in >>> langtools and the jdk build. I would need reviewers from the langtools >>> and the build-infra team. >>> >>> Webrev for review: >>> http://cr.openjdk.java.net/~mchung/jdk8/webrevs/jdeps/langtools-webrev.02/ >>> http://cr.openjdk.java.net/~mchung/jdk8/webrevs/jdeps/jdk-webrev.02/ >>> >>> The jdeps source is in the langtools repo. The change in the jdk >>> repo is >>> to add the new jdeps executable. I made change in the old and new >>> build >>> for the addition of this new jdeps tool. I discussed with Jon >>> whether I >>> should modify langtools/make/build.xml to add a new jdeps target. Since >>> the old build will be replaced by the new build soon, I simply add >>> com/sun/tools/jdeps as part of javap.includes. >>> >>> Alan, >>> >>> The -d option is kept as a hidden option and use as implementation. We >>> can remove it when it's determined not useful in the future. I also >>> rename -v:summary to -summary. >>> >>> Thanks >>> Mandy >>> >>> ---------------------------- >>> >>> $ jdep -h >>> Usage: jdeps >>> where possible options include: >>> -version Version information >>> -classpath Specify where to find class files >>> -summary Print dependency summary only >>> -v:class Print class-level dependencies >>> -v:package Print package-level dependencies >>> -p Restrict analysis to classes in this package >>> (may be given multiple times) >>> -e Restrict analysis to packages matching >>> pattern >>> (-p and -e are exclusive) >>> -P --profile Show profile or the file containing a >>> package >>> -R --recursive Traverse all dependencies recursively >>> -all Process all classes specified in -classpath >>> >>> $ jdep Notepad.jar Ensemble.jar >>> Notepad.jar -> D:\tools\devtools\jdk8\windows-i586\jre\lib\rt.jar >>> (Notepad.jar) >>> -> java.awt >>> -> java.awt.event >>> -> java.beans >>> -> java.io >>> -> java.lang >>> -> java.net >>> -> java.util >>> -> java.util.logging >>> -> javax.swing >>> -> javax.swing.border >>> -> javax.swing.event >>> -> javax.swing.text >>> -> javax.swing.tree >>> -> javax.swing.undo >>> >>> Ensemble.jar -> D:\tools\devtools\jdk8\windows-i586\jre\lib\jfxrt.jar >>> Ensemble.jar -> D:\tools\devtools\jdk8\windows-i586\jre\lib\rt.jar >>> com.javafx.main (Ensemble.jar) >>> -> java.applet >>> -> java.awt >>> -> java.awt.event >>> -> java.io >>> -> java.lang >>> -> java.lang.reflect >>> -> java.net >>> -> java.security >>> -> java.util >>> -> java.util.jar >>> -> javax.swing >>> -> sun.misc JDK internal API >>> (rt.jar) >> From jonathan.gibbons at oracle.com Thu Dec 13 17:50:14 2012 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Fri, 14 Dec 2012 01:50:14 +0000 Subject: hg: jdk8/tl/langtools: 8001114: Container annotation is not checked for semantic correctness Message-ID: <20121214015018.AA5C947136@hg.openjdk.java.net> Changeset: 376d6c1b49e5 Author: jfranck Date: 2012-12-03 11:16 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/376d6c1b49e5 8001114: Container annotation is not checked for semantic correctness Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Annotations.java ! src/share/classes/com/sun/tools/javac/comp/Annotate.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/tools/javac/annotations/repeatingAnnotations/MissingDefaultCase1.java ! test/tools/javac/annotations/repeatingAnnotations/MissingDefaultCase1.out ! test/tools/javac/annotations/repeatingAnnotations/MissingDefaultCase2.java ! test/tools/javac/annotations/repeatingAnnotations/MissingDefaultCase2.out ! test/tools/javac/annotations/repeatingAnnotations/NoRepeatableAnno.out + test/tools/javac/annotations/repeatingAnnotations/RepeatingTargetNotAllowed.java + test/tools/javac/annotations/repeatingAnnotations/RepeatingTargetNotAllowed.out ! test/tools/javac/diags/examples/ContainedByNonDefault.java + test/tools/javac/diags/examples/InvalidDuplicateAnnotation.java From mandy.chung at oracle.com Thu Dec 13 18:15:13 2012 From: mandy.chung at oracle.com (Mandy Chung) Date: Thu, 13 Dec 2012 18:15:13 -0800 Subject: Review request: 8003562: Provide a command-line tool to find static dependencies In-Reply-To: <50CA6DA1.1070004@oracle.com> References: <50B54A2C.1040907@oracle.com> <50BFF69E.1040805@oracle.com> <50C265D8.3050107@oracle.com> <50C5B9B2.2050705@oracle.com> <50CA6DA1.1070004@oracle.com> Message-ID: <50CA8BB1.1030502@oracle.com> On 12/13/2012 4:06 PM, Jonathan Gibbons wrote: > Mandy, > > Mostly good -- and nice to see Dependencies getting the full tool > treatment. > Thanks for the review, Jon. > -- Jon > > > Archive.java:128 > non-localized text: "not found" > Oh I missed that - will fix it. > ClassFileReader.java:74, ditto similar code in JarFileReader > Will not work for inner classes. > That's right. What's the best way handling inner classes besides retrying? > ClassFileReader.java:various > Langtools is (for a while longer) still using -source 6. This is to > allow NetBeans to build and use langtools. I guess the code here is OK > as long as NB don't try and build all of langtools. > We talked about this and I hope that some part of langtools could be built with -source 7 as they are not needed in the bootstrap phase. I will fix it since it's close to integration. That'll help when you use NB to open langtools repo; otherwise, NB will indicate the files with syntax error which is kind of annoying. > JDepsTask:111 > Did you mean --summary? Yes will fix it. > If you're wanting to emulate the GNU-style --options, these options > normally use =, as in --name=value, so you might want to update > handleOption. > That's right - will fix it. > PlatformClassPath > The API you are looking for is now available in the profiles forest, > in langtools/src/classes/com/sun/tools/javac/sym Good - I'll check that out and send out a new webrev. Thanks Mandy > > -- Jon > > On 12/10/2012 02:30 AM, Erik Joelsson wrote: >> Looks good. >> >> /Erik >> >> On 2012-12-07 22:55, Mandy Chung wrote: >>> This is the updated webrev. It includes Erik's makefile changes and >>> small change - be consistent with javap, jdeps can take classnames as >>> the input argument or wildcard "*" to analyze all class files that >>> replaces the "-all" option. >>> >>> Webrev: >>> http://cr.openjdk.java.net/~mchung/jdk8/webrevs/jdeps/webrev.03/ >>> >>> Mandy >>> >>> On 12/5/12 5:36 PM, Mandy Chung wrote: >>>> This review request (add a new jdeps tool in the JDK) include >>>> changes in >>>> langtools and the jdk build. I would need reviewers from the >>>> langtools >>>> and the build-infra team. >>>> >>>> Webrev for review: >>>> http://cr.openjdk.java.net/~mchung/jdk8/webrevs/jdeps/langtools-webrev.02/ >>>> >>>> http://cr.openjdk.java.net/~mchung/jdk8/webrevs/jdeps/jdk-webrev.02/ >>>> >>>> The jdeps source is in the langtools repo. The change in the jdk >>>> repo is >>>> to add the new jdeps executable. I made change in the old and new >>>> build >>>> for the addition of this new jdeps tool. I discussed with Jon >>>> whether I >>>> should modify langtools/make/build.xml to add a new jdeps target. >>>> Since >>>> the old build will be replaced by the new build soon, I simply add >>>> com/sun/tools/jdeps as part of javap.includes. >>>> >>>> Alan, >>>> >>>> The -d option is kept as a hidden option and use as implementation. We >>>> can remove it when it's determined not useful in the future. I also >>>> rename -v:summary to -summary. >>>> >>>> Thanks >>>> Mandy >>>> >>>> ---------------------------- >>>> >>>> $ jdep -h >>>> Usage: jdeps >>>> where possible options include: >>>> -version Version information >>>> -classpath Specify where to find class files >>>> -summary Print dependency summary only >>>> -v:class Print class-level dependencies >>>> -v:package Print package-level dependencies >>>> -p Restrict analysis to classes in this >>>> package >>>> (may be given multiple times) >>>> -e Restrict analysis to packages matching >>>> pattern >>>> (-p and -e are exclusive) >>>> -P --profile Show profile or the file containing a >>>> package >>>> -R --recursive Traverse all dependencies recursively >>>> -all Process all classes specified in -classpath >>>> >>>> $ jdep Notepad.jar Ensemble.jar >>>> Notepad.jar -> D:\tools\devtools\jdk8\windows-i586\jre\lib\rt.jar >>>> (Notepad.jar) >>>> -> java.awt >>>> -> java.awt.event >>>> -> java.beans >>>> -> java.io >>>> -> java.lang >>>> -> java.net >>>> -> java.util >>>> -> java.util.logging >>>> -> javax.swing >>>> -> javax.swing.border >>>> -> javax.swing.event >>>> -> javax.swing.text >>>> -> javax.swing.tree >>>> -> javax.swing.undo >>>> >>>> Ensemble.jar -> D:\tools\devtools\jdk8\windows-i586\jre\lib\jfxrt.jar >>>> Ensemble.jar -> D:\tools\devtools\jdk8\windows-i586\jre\lib\rt.jar >>>> com.javafx.main (Ensemble.jar) >>>> -> java.applet >>>> -> java.awt >>>> -> java.awt.event >>>> -> java.io >>>> -> java.lang >>>> -> java.lang.reflect >>>> -> java.net >>>> -> java.security >>>> -> java.util >>>> -> java.util.jar >>>> -> javax.swing >>>> -> sun.misc JDK internal API >>>> (rt.jar) >>> > From david.holmes at oracle.com Thu Dec 13 18:19:03 2012 From: david.holmes at oracle.com (david.holmes at oracle.com) Date: Fri, 14 Dec 2012 02:19:03 +0000 Subject: hg: jdk8/tl/jdk: 8003632: HPROF class file version java.lang.RuntimeException errors Message-ID: <20121214021924.3C81647137@hg.openjdk.java.net> Changeset: 8d7323a9d8ed Author: dholmes Date: 2012-12-13 21:18 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8d7323a9d8ed 8003632: HPROF class file version java.lang.RuntimeException errors Reviewed-by: mchung, lancea ! src/share/javavm/export/classfile_constants.h From mandy.chung at oracle.com Thu Dec 13 23:22:11 2012 From: mandy.chung at oracle.com (Mandy Chung) Date: Thu, 13 Dec 2012 23:22:11 -0800 Subject: Review request: 8003562: Provide a command-line tool to find static dependencies In-Reply-To: <50CA8BB1.1030502@oracle.com> References: <50B54A2C.1040907@oracle.com> <50BFF69E.1040805@oracle.com> <50C265D8.3050107@oracle.com> <50C5B9B2.2050705@oracle.com> <50CA6DA1.1070004@oracle.com> <50CA8BB1.1030502@oracle.com> Message-ID: <50CAD3A3.5040300@oracle.com> Updated webrev: http://cr.openjdk.java.net/~mchung/jdk8/webrevs/jdeps/webrev.04/ The binary name of an inner class has a '$' and so ClassFileReader.java:74 should do it. Once the jdeps change is pulled down to the profiles forest, I may make the change there to use the API as javac uses. thanks Mandy On 12/13/2012 6:15 PM, Mandy Chung wrote: > On 12/13/2012 4:06 PM, Jonathan Gibbons wrote: >> Mandy, >> >> Mostly good -- and nice to see Dependencies getting the full tool >> treatment. >> > > Thanks for the review, Jon. > >> -- Jon >> >> >> Archive.java:128 >> non-localized text: "not found" >> > > Oh I missed that - will fix it. > >> ClassFileReader.java:74, ditto similar code in JarFileReader >> Will not work for inner classes. >> > > That's right. What's the best way handling inner classes besides > retrying? > >> ClassFileReader.java:various >> Langtools is (for a while longer) still using -source 6. This is to >> allow NetBeans to build and use langtools. I guess the code here is >> OK as long as NB don't try and build all of langtools. >> > > We talked about this and I hope that some part of langtools could be > built with -source 7 as they are not needed in the bootstrap phase. I > will fix it since it's close to integration. That'll help when you > use NB to open langtools repo; otherwise, NB will indicate the files > with syntax error which is kind of annoying. > > >> JDepsTask:111 >> Did you mean --summary? > > Yes will fix it. > >> If you're wanting to emulate the GNU-style --options, these options >> normally use =, as in --name=value, so you might want to update >> handleOption. >> > > That's right - will fix it. > >> PlatformClassPath >> The API you are looking for is now available in the profiles forest, >> in langtools/src/classes/com/sun/tools/javac/sym > > Good - I'll check that out and send out a new webrev. > > Thanks > Mandy > >> >> -- Jon >> >> On 12/10/2012 02:30 AM, Erik Joelsson wrote: >>> Looks good. >>> >>> /Erik >>> >>> On 2012-12-07 22:55, Mandy Chung wrote: >>>> This is the updated webrev. It includes Erik's makefile changes and >>>> small change - be consistent with javap, jdeps can take classnames as >>>> the input argument or wildcard "*" to analyze all class files that >>>> replaces the "-all" option. >>>> >>>> Webrev: >>>> http://cr.openjdk.java.net/~mchung/jdk8/webrevs/jdeps/webrev.03/ >>>> >>>> Mandy >>>> >>>> On 12/5/12 5:36 PM, Mandy Chung wrote: >>>>> This review request (add a new jdeps tool in the JDK) include >>>>> changes in >>>>> langtools and the jdk build. I would need reviewers from the >>>>> langtools >>>>> and the build-infra team. >>>>> >>>>> Webrev for review: >>>>> http://cr.openjdk.java.net/~mchung/jdk8/webrevs/jdeps/langtools-webrev.02/ >>>>> >>>>> http://cr.openjdk.java.net/~mchung/jdk8/webrevs/jdeps/jdk-webrev.02/ >>>>> >>>>> The jdeps source is in the langtools repo. The change in the jdk >>>>> repo is >>>>> to add the new jdeps executable. I made change in the old and new >>>>> build >>>>> for the addition of this new jdeps tool. I discussed with Jon >>>>> whether I >>>>> should modify langtools/make/build.xml to add a new jdeps target. >>>>> Since >>>>> the old build will be replaced by the new build soon, I simply add >>>>> com/sun/tools/jdeps as part of javap.includes. >>>>> >>>>> Alan, >>>>> >>>>> The -d option is kept as a hidden option and use as >>>>> implementation. We >>>>> can remove it when it's determined not useful in the future. I also >>>>> rename -v:summary to -summary. >>>>> >>>>> Thanks >>>>> Mandy >>>>> >>>>> ---------------------------- >>>>> >>>>> $ jdep -h >>>>> Usage: jdeps >>>>> where possible options include: >>>>> -version Version information >>>>> -classpath Specify where to find class files >>>>> -summary Print dependency summary only >>>>> -v:class Print class-level dependencies >>>>> -v:package Print package-level dependencies >>>>> -p Restrict analysis to classes in this >>>>> package >>>>> (may be given multiple times) >>>>> -e Restrict analysis to packages matching >>>>> pattern >>>>> (-p and -e are exclusive) >>>>> -P --profile Show profile or the file containing a >>>>> package >>>>> -R --recursive Traverse all dependencies recursively >>>>> -all Process all classes specified in >>>>> -classpath >>>>> >>>>> $ jdep Notepad.jar Ensemble.jar >>>>> Notepad.jar -> D:\tools\devtools\jdk8\windows-i586\jre\lib\rt.jar >>>>> (Notepad.jar) >>>>> -> java.awt >>>>> -> java.awt.event >>>>> -> java.beans >>>>> -> java.io >>>>> -> java.lang >>>>> -> java.net >>>>> -> java.util >>>>> -> java.util.logging >>>>> -> javax.swing >>>>> -> javax.swing.border >>>>> -> javax.swing.event >>>>> -> javax.swing.text >>>>> -> javax.swing.tree >>>>> -> javax.swing.undo >>>>> >>>>> Ensemble.jar -> D:\tools\devtools\jdk8\windows-i586\jre\lib\jfxrt.jar >>>>> Ensemble.jar -> D:\tools\devtools\jdk8\windows-i586\jre\lib\rt.jar >>>>> com.javafx.main (Ensemble.jar) >>>>> -> java.applet >>>>> -> java.awt >>>>> -> java.awt.event >>>>> -> java.io >>>>> -> java.lang >>>>> -> java.lang.reflect >>>>> -> java.net >>>>> -> java.security >>>>> -> java.util >>>>> -> java.util.jar >>>>> -> javax.swing >>>>> -> sun.misc JDK internal API >>>>> (rt.jar) >>>> >> From Ulf.Zibis at CoSoCo.de Fri Dec 14 02:47:45 2012 From: Ulf.Zibis at CoSoCo.de (Ulf Zibis) Date: Fri, 14 Dec 2012 11:47:45 +0100 Subject: Review request: 8003562: Provide a command-line tool to find static dependencies In-Reply-To: <50CA8BB1.1030502@oracle.com> References: <50B54A2C.1040907@oracle.com> <50BFF69E.1040805@oracle.com> <50C265D8.3050107@oracle.com> <50C5B9B2.2050705@oracle.com> <50CA6DA1.1070004@oracle.com> <50CA8BB1.1030502@oracle.com> Message-ID: <50CB03D1.5030400@CoSoCo.de> Am 14.12.2012 03:15, schrieb Mandy Chung: >> JDepsTask:111 >> Did you mean --summary? > > Yes will fix it. Why don't you remain consistent to all other existing java tools? E.g. javac uses: -cp path or -classpath path Double hyphen '--' is never used until today. So better: -P -profile Show profile or the file containing a package -R -recursive Traverse all dependencies recursively Anyway, if you prefer to stick at '--', then you should consistently use it for '--version', '--classpath', '--all' -Ulf >>>>> -version Version information >>>>> -classpath Specify where to find class files >>>>> -summary Print dependency summary only >>>>> -v:class Print class-level dependencies >>>>> -v:package Print package-level dependencies >>>>> -p Restrict analysis to classes in this package >>>>> (may be given multiple times) >>>>> -e Restrict analysis to packages matching pattern >>>>> (-p and -e are exclusive) >>>>> -P --profile Show profile or the file containing a package >>>>> -R --recursive Traverse all dependencies recursively >>>>> -all Process all classes specified in -classpath >>>> >> > From Ulf.Zibis at CoSoCo.de Fri Dec 14 03:54:03 2012 From: Ulf.Zibis at CoSoCo.de (Ulf Zibis) Date: Fri, 14 Dec 2012 12:54:03 +0100 Subject: Review request: 8003562: Provide a command-line tool to find static dependencies In-Reply-To: <50CAD3A3.5040300@oracle.com> References: <50B54A2C.1040907@oracle.com> <50BFF69E.1040805@oracle.com> <50C265D8.3050107@oracle.com> <50C5B9B2.2050705@oracle.com> <50CA6DA1.1070004@oracle.com> <50CA8BB1.1030502@oracle.com> <50CAD3A3.5040300@oracle.com> Message-ID: <50CB135B.7070707@CoSoCo.de> Some nits again: _private_ static class Options has _public_ members, why? IMHO, defining a distinct inner class for each Option is a little bit oversized. I also do not see the need for class Options, as it is only instantiated once. Instead you could define: enum Options Anyway, isn'd there still an options parser from other java langtools, which could be reused ??? In many places the source is exhausting to read, e.g if (f.exists()) { ClassFileReader reader = ClassFileReader.newInstance(f); Archive archive = new Archive(f, reader); result.add(archive); } could simply be: if (f.exists()) result.add(new Archive(f, ClassFileReader.newInstance(f))); ... also spreading around the variable definitions at different places. -Ulf Am 14.12.2012 08:22, schrieb Mandy Chung: > Updated webrev: > http://cr.openjdk.java.net/~mchung/jdk8/webrevs/jdeps/webrev.04/ > > The binary name of an inner class has a '$' and so ClassFileReader.java:74 should do it. Once the > jdeps change is pulled down to the profiles forest, I may make the change there to use the API as > javac uses. > > thanks > Mandy > > On 12/13/2012 6:15 PM, Mandy Chung wrote: >> On 12/13/2012 4:06 PM, Jonathan Gibbons wrote: >>> Mandy, >>> >>> Mostly good -- and nice to see Dependencies getting the full tool treatment. >>> >> >> Thanks for the review, Jon. >> >>> -- Jon >>> >>> >>> Archive.java:128 >>> non-localized text: "not found" >>> >> >> Oh I missed that - will fix it. >> >>> ClassFileReader.java:74, ditto similar code in JarFileReader >>> Will not work for inner classes. >>> >> >> That's right. What's the best way handling inner classes besides retrying? >> >>> ClassFileReader.java:various >>> Langtools is (for a while longer) still using -source 6. This is to allow NetBeans to build and >>> use langtools. I guess the code here is OK as long as NB don't try and build all of langtools. >>> >> >> We talked about this and I hope that some part of langtools could be built with -source 7 as they >> are not needed in the bootstrap phase. I will fix it since it's close to integration. That'll >> help when you use NB to open langtools repo; otherwise, NB will indicate the files with syntax >> error which is kind of annoying. >> >> >>> JDepsTask:111 >>> Did you mean --summary? >> >> Yes will fix it. >> >>> If you're wanting to emulate the GNU-style --options, these options normally use =, as in >>> --name=value, so you might want to update handleOption. >>> >> >> That's right - will fix it. >> >>> PlatformClassPath >>> The API you are looking for is now available in the profiles forest, in >>> langtools/src/classes/com/sun/tools/javac/sym >> >> Good - I'll check that out and send out a new webrev. >> >> Thanks >> Mandy >> >>> >>> -- Jon >>> >>> On 12/10/2012 02:30 AM, Erik Joelsson wrote: >>>> Looks good. >>>> >>>> /Erik >>>> >>>> On 2012-12-07 22:55, Mandy Chung wrote: >>>>> This is the updated webrev. It includes Erik's makefile changes and >>>>> small change - be consistent with javap, jdeps can take classnames as >>>>> the input argument or wildcard "*" to analyze all class files that >>>>> replaces the "-all" option. >>>>> >>>>> Webrev: >>>>> http://cr.openjdk.java.net/~mchung/jdk8/webrevs/jdeps/webrev.03/ >>>>> >>>>> Mandy >>>>> >>>>> On 12/5/12 5:36 PM, Mandy Chung wrote: >>>>>> This review request (add a new jdeps tool in the JDK) include changes in >>>>>> langtools and the jdk build. I would need reviewers from the langtools >>>>>> and the build-infra team. >>>>>> >>>>>> Webrev for review: >>>>>> http://cr.openjdk.java.net/~mchung/jdk8/webrevs/jdeps/langtools-webrev.02/ >>>>>> http://cr.openjdk.java.net/~mchung/jdk8/webrevs/jdeps/jdk-webrev.02/ >>>>>> >>>>>> The jdeps source is in the langtools repo. The change in the jdk repo is >>>>>> to add the new jdeps executable. I made change in the old and new build >>>>>> for the addition of this new jdeps tool. I discussed with Jon whether I >>>>>> should modify langtools/make/build.xml to add a new jdeps target. Since >>>>>> the old build will be replaced by the new build soon, I simply add >>>>>> com/sun/tools/jdeps as part of javap.includes. >>>>>> >>>>>> Alan, >>>>>> >>>>>> The -d option is kept as a hidden option and use as implementation. We >>>>>> can remove it when it's determined not useful in the future. I also >>>>>> rename -v:summary to -summary. >>>>>> >>>>>> Thanks >>>>>> Mandy >>>>>> >>>>>> ---------------------------- >>>>>> >>>>>> $ jdep -h >>>>>> Usage: jdeps >>>>>> where possible options include: >>>>>> -version Version information >>>>>> -classpath Specify where to find class files >>>>>> -summary Print dependency summary only >>>>>> -v:class Print class-level dependencies >>>>>> -v:package Print package-level dependencies >>>>>> -p Restrict analysis to classes in this package >>>>>> (may be given multiple times) >>>>>> -e Restrict analysis to packages matching pattern >>>>>> (-p and -e are exclusive) >>>>>> -P --profile Show profile or the file containing a package >>>>>> -R --recursive Traverse all dependencies recursively >>>>>> -all Process all classes specified in -classpath >>>>>> >>>>>> $ jdep Notepad.jar Ensemble.jar >>>>>> Notepad.jar -> D:\tools\devtools\jdk8\windows-i586\jre\lib\rt.jar >>>>>> (Notepad.jar) >>>>>> -> java.awt >>>>>> -> java.awt.event >>>>>> -> java.beans >>>>>> -> java.io >>>>>> -> java.lang >>>>>> -> java.net >>>>>> -> java.util >>>>>> -> java.util.logging >>>>>> -> javax.swing >>>>>> -> javax.swing.border >>>>>> -> javax.swing.event >>>>>> -> javax.swing.text >>>>>> -> javax.swing.tree >>>>>> -> javax.swing.undo >>>>>> >>>>>> Ensemble.jar -> D:\tools\devtools\jdk8\windows-i586\jre\lib\jfxrt.jar >>>>>> Ensemble.jar -> D:\tools\devtools\jdk8\windows-i586\jre\lib\rt.jar >>>>>> com.javafx.main (Ensemble.jar) >>>>>> -> java.applet >>>>>> -> java.awt >>>>>> -> java.awt.event >>>>>> -> java.io >>>>>> -> java.lang >>>>>> -> java.lang.reflect >>>>>> -> java.net >>>>>> -> java.security >>>>>> -> java.util >>>>>> -> java.util.jar >>>>>> -> javax.swing >>>>>> -> sun.misc JDK internal API (rt.jar) >>>>> >>> > From Alan.Bateman at oracle.com Fri Dec 14 04:43:02 2012 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Fri, 14 Dec 2012 12:43:02 +0000 Subject: Review request: 8003562: Provide a command-line tool to find static dependencies In-Reply-To: <50CAD3A3.5040300@oracle.com> References: <50B54A2C.1040907@oracle.com> <50BFF69E.1040805@oracle.com> <50C265D8.3050107@oracle.com> <50C5B9B2.2050705@oracle.com> <50CA6DA1.1070004@oracle.com> <50CA8BB1.1030502@oracle.com> <50CAD3A3.5040300@oracle.com> Message-ID: <50CB1ED6.4030605@oracle.com> On 14/12/2012 07:22, Mandy Chung wrote: > Once the jdeps change is pulled down to the profiles forest, I may > make the change there to use the API as javac uses. > That would be fine, alternatively when the profiles changes get to jdk8 and jdk8/tl. -Alan. From Ulf.Zibis at CoSoCo.de Fri Dec 14 06:13:18 2012 From: Ulf.Zibis at CoSoCo.de (Ulf Zibis) Date: Fri, 14 Dec 2012 15:13:18 +0100 Subject: Review request: 8003562: Provide a command-line tool to find static dependencies In-Reply-To: <50CB03D1.5030400@CoSoCo.de> References: <50B54A2C.1040907@oracle.com> <50BFF69E.1040805@oracle.com> <50C265D8.3050107@oracle.com> <50C5B9B2.2050705@oracle.com> <50CA6DA1.1070004@oracle.com> <50CA8BB1.1030502@oracle.com> <50CB03D1.5030400@CoSoCo.de> Message-ID: <50CB33FE.7000605@CoSoCo.de> Am 14.12.2012 11:47, schrieb Ulf Zibis: > Am 14.12.2012 03:15, schrieb Mandy Chung: >>> JDepsTask:111 >>> Did you mean --summary? >> >> Yes will fix it. > > Why don't you remain consistent to all other existing java tools? > E.g. javac uses: -cp path or -classpath path > Double hyphen '--' is never used until today. > > So better: > -P -profile Show profile or the file containing a package > -R -recursive Traverse all dependencies recursively > > Anyway, if you prefer to stick at '--', then you should consistently use it for '--version', > '--classpath', '--all' Maybe I'm in error, but additionally it seems to me, that "-classpath=Foo" doesn't match by: if (a.equals(opt)) { return true; } else if (opt.startsWith("--") && hasArg && opt.startsWith(a + "=")) { return true; } -Ulf >>>>>> -version Version information >>>>>> -classpath Specify where to find class files >>>>>> -summary Print dependency summary only >>>>>> -v:class Print class-level dependencies >>>>>> -v:package Print package-level dependencies >>>>>> -p Restrict analysis to classes in this package >>>>>> (may be given multiple times) >>>>>> -e Restrict analysis to packages matching pattern >>>>>> (-p and -e are exclusive) >>>>>> -P --profile Show profile or the file containing a package >>>>>> -R --recursive Traverse all dependencies recursively >>>>>> -all Process all classes specified in -classpath >>>>> >>> >> > > From mandy.chung at oracle.com Fri Dec 14 12:54:34 2012 From: mandy.chung at oracle.com (Mandy Chung) Date: Fri, 14 Dec 2012 12:54:34 -0800 Subject: Review request: 8003562: Provide a command-line tool to find static dependencies In-Reply-To: <50CB135B.7070707@CoSoCo.de> References: <50B54A2C.1040907@oracle.com> <50BFF69E.1040805@oracle.com> <50C265D8.3050107@oracle.com> <50C5B9B2.2050705@oracle.com> <50CA6DA1.1070004@oracle.com> <50CA8BB1.1030502@oracle.com> <50CAD3A3.5040300@oracle.com> <50CB135B.7070707@CoSoCo.de> Message-ID: <50CB920A.7080208@oracle.com> I have cleaned up per your comments, Ulf. Here is the updated webrev: http://cr.openjdk.java.net/~mchung/jdk8/webrevs/jdeps/webrev.05/ This also cleans up how the inner classes are handled since Location.getClassName returns a fully-qualified classname. On 12/14/2012 3:54 AM, Ulf Zibis wrote: > Some nits again: > > _private_ static class Options has _public_ members, why? > Fixed. > IMHO, defining a distinct inner class for each Option is a little bit > oversized. I also do not see the need for class Options, as it is only > instantiated once. Instead you could define: > enum Options > Anyway, isn'd there still an options parser from other java langtools, > which could be reused ??? > I tried to be consistent with the javap implementation. It's reasonable to have a common option parsing library for the command-line tools to use - for example [1] that we hope to get to it. > In many places the source is exhausting to read, e.g > if (f.exists()) { > ClassFileReader reader = ClassFileReader.newInstance(f); > Archive archive = new Archive(f, reader); > result.add(archive); > } > could simply be: > if (f.exists()) > result.add(new Archive(f, ClassFileReader.newInstance(f))); > > ... also spreading around the variable definitions at different places. Fixed. Thanks Mandy > > > Am 14.12.2012 08:22, schrieb Mandy Chung: >> Updated webrev: >> http://cr.openjdk.java.net/~mchung/jdk8/webrevs/jdeps/webrev.04/ >> >> The binary name of an inner class has a '$' and so >> ClassFileReader.java:74 should do it. Once the jdeps change is >> pulled down to the profiles forest, I may make the change there to >> use the API as javac uses. >> >> thanks >> Mandy >> http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/file/ce66890e6d86/src/share/classes/org/openjdk/internal/joptsimple/ >> On 12/13/2012 6:15 PM, Mandy Chung wrote: >>> On 12/13/2012 4:06 PM, Jonathan Gibbons wrote: >>>> Mandy, >>>> >>>> Mostly good -- and nice to see Dependencies getting the full tool >>>> treatment. >>>> >>> >>> Thanks for the review, Jon. >>> >>>> -- Jon >>>> >>>> >>>> Archive.java:128 >>>> non-localized text: "not found" >>>> >>> >>> Oh I missed that - will fix it. >>> >>>> ClassFileReader.java:74, ditto similar code in JarFileReader >>>> Will not work for inner classes. >>>> >>> >>> That's right. What's the best way handling inner classes besides >>> retrying? >>> >>>> ClassFileReader.java:various >>>> Langtools is (for a while longer) still using -source 6. This is to >>>> allow NetBeans to build and use langtools. I guess the code here is >>>> OK as long as NB don't try and build all of langtools. >>>> >>> >>> We talked about this and I hope that some part of langtools could be >>> built with -source 7 as they are not needed in the bootstrap phase. >>> I will fix it since it's close to integration. That'll help when >>> you use NB to open langtools repo; otherwise, NB will indicate the >>> files with syntax error which is kind of annoying. >>> >>> >>>> JDepsTask:111 >>>> Did you mean --summary? >>> >>> Yes will fix it. >>> >>>> If you're wanting to emulate the GNU-style --options, these options >>>> normally use =, as in --name=value, so you might want to update >>>> handleOption. >>>> >>> >>> That's right - will fix it. >>> >>>> PlatformClassPath >>>> The API you are looking for is now available in the profiles >>>> forest, in langtools/src/classes/com/sun/tools/javac/sym >>> >>> Good - I'll check that out and send out a new webrev. >>> >>> Thanks >>> Mandy >>> >>>> >>>> -- Jon >>>> >>>> On 12/10/2012 02:30 AM, Erik Joelsson wrote: >>>>> Looks good. >>>>> >>>>> /Erik >>>>> >>>>> On 2012-12-07 22:55, Mandy Chung wrote: >>>>>> This is the updated webrev. It includes Erik's makefile changes and >>>>>> small change - be consistent with javap, jdeps can take >>>>>> classnames as >>>>>> the input argument or wildcard "*" to analyze all class files that >>>>>> replaces the "-all" option. >>>>>> >>>>>> Webrev: >>>>>> http://cr.openjdk.java.net/~mchung/jdk8/webrevs/jdeps/webrev.03/ >>>>>> >>>>>> Mandy >>>>>> >>>>>> On 12/5/12 5:36 PM, Mandy Chung wrote: >>>>>>> This review request (add a new jdeps tool in the JDK) include >>>>>>> changes in >>>>>>> langtools and the jdk build. I would need reviewers from the >>>>>>> langtools >>>>>>> and the build-infra team. >>>>>>> >>>>>>> Webrev for review: >>>>>>> http://cr.openjdk.java.net/~mchung/jdk8/webrevs/jdeps/langtools-webrev.02/ >>>>>>> >>>>>>> http://cr.openjdk.java.net/~mchung/jdk8/webrevs/jdeps/jdk-webrev.02/ >>>>>>> >>>>>>> >>>>>>> The jdeps source is in the langtools repo. The change in the >>>>>>> jdk repo is >>>>>>> to add the new jdeps executable. I made change in the old and >>>>>>> new build >>>>>>> for the addition of this new jdeps tool. I discussed with Jon >>>>>>> whether I >>>>>>> should modify langtools/make/build.xml to add a new jdeps >>>>>>> target. Since >>>>>>> the old build will be replaced by the new build soon, I simply add >>>>>>> com/sun/tools/jdeps as part of javap.includes. >>>>>>> >>>>>>> Alan, >>>>>>> >>>>>>> The -d option is kept as a hidden option and use as >>>>>>> implementation. We >>>>>>> can remove it when it's determined not useful in the future. I also >>>>>>> rename -v:summary to -summary. >>>>>>> >>>>>>> Thanks >>>>>>> Mandy >>>>>>> >>>>>>> ---------------------------- >>>>>>> >>>>>>> $ jdep -h >>>>>>> Usage: jdeps >>>>>>> where possible options include: >>>>>>> -version Version information >>>>>>> -classpath Specify where to find class files >>>>>>> -summary Print dependency summary only >>>>>>> -v:class Print class-level dependencies >>>>>>> -v:package Print package-level dependencies >>>>>>> -p Restrict analysis to classes in this >>>>>>> package >>>>>>> (may be given multiple times) >>>>>>> -e Restrict analysis to packages >>>>>>> matching pattern >>>>>>> (-p and -e are exclusive) >>>>>>> -P --profile Show profile or the file containing a >>>>>>> package >>>>>>> -R --recursive Traverse all dependencies recursively >>>>>>> -all Process all classes specified in >>>>>>> -classpath >>>>>>> >>>>>>> $ jdep Notepad.jar Ensemble.jar >>>>>>> Notepad.jar -> D:\tools\devtools\jdk8\windows-i586\jre\lib\rt.jar >>>>>>> (Notepad.jar) >>>>>>> -> java.awt >>>>>>> -> java.awt.event >>>>>>> -> java.beans >>>>>>> -> java.io >>>>>>> -> java.lang >>>>>>> -> java.net >>>>>>> -> java.util >>>>>>> -> java.util.logging >>>>>>> -> javax.swing >>>>>>> -> javax.swing.border >>>>>>> -> javax.swing.event >>>>>>> -> javax.swing.text >>>>>>> -> javax.swing.tree >>>>>>> -> javax.swing.undo >>>>>>> >>>>>>> Ensemble.jar -> >>>>>>> D:\tools\devtools\jdk8\windows-i586\jre\lib\jfxrt.jar >>>>>>> Ensemble.jar -> D:\tools\devtools\jdk8\windows-i586\jre\lib\rt.jar >>>>>>> com.javafx.main (Ensemble.jar) >>>>>>> -> java.applet >>>>>>> -> java.awt >>>>>>> -> java.awt.event >>>>>>> -> java.io >>>>>>> -> java.lang >>>>>>> -> java.lang.reflect >>>>>>> -> java.net >>>>>>> -> java.security >>>>>>> -> java.util >>>>>>> -> java.util.jar >>>>>>> -> javax.swing >>>>>>> -> sun.misc JDK internal >>>>>>> API (rt.jar) >>>>>> >>>> >> > From huizhe.wang at oracle.com Fri Dec 14 13:21:58 2012 From: huizhe.wang at oracle.com (huizhe.wang at oracle.com) Date: Fri, 14 Dec 2012 21:21:58 +0000 Subject: hg: jdk8/tl/jaxp: 8003260: [findbug] some fields should be package protected Message-ID: <20121214212203.216C64717E@hg.openjdk.java.net> Changeset: b1fdb101c82e Author: joehw Date: 2012-12-14 13:24 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/b1fdb101c82e 8003260: [findbug] some fields should be package protected Summary: change public or protected mutable static fields to private or package private. Reviewed-by: lancea ! src/com/sun/org/apache/xerces/internal/impl/XMLDocumentFragmentScannerImpl.java ! src/com/sun/org/apache/xerces/internal/impl/XMLEntityScanner.java From mandy.chung at oracle.com Fri Dec 14 13:41:09 2012 From: mandy.chung at oracle.com (Mandy Chung) Date: Fri, 14 Dec 2012 13:41:09 -0800 Subject: Review request: 8003562: Provide a command-line tool to find static dependencies In-Reply-To: <50CB33FE.7000605@CoSoCo.de> References: <50B54A2C.1040907@oracle.com> <50BFF69E.1040805@oracle.com> <50C265D8.3050107@oracle.com> <50C5B9B2.2050705@oracle.com> <50CA6DA1.1070004@oracle.com> <50CA8BB1.1030502@oracle.com> <50CB03D1.5030400@CoSoCo.de> <50CB33FE.7000605@CoSoCo.de> Message-ID: <50CB9CF5.4090300@oracle.com> Ulf, Thanks for the review. On 12/14/2012 6:13 AM, Ulf Zibis wrote: > Am 14.12.2012 11:47, schrieb Ulf Zibis: >> Am 14.12.2012 03:15, schrieb Mandy Chung: >>>> JDepsTask:111 >>>> Did you mean --summary? >>> >>> Yes will fix it. >> >> Why don't you remain consistent to all other existing java tools? >> E.g. javac uses: -cp path or -classpath path >> Double hyphen '--' is never used until today. >> '--' is the GNU-style option. pack200 uses GNU-style options for some time. There was some discussion in jigsaw-dev [1] and the new jigsaw CLIs are moving to that direction. >> So better: >> -P -profile Show profile or the file containing a package >> -R -recursive Traverse all dependencies recursively >> >> Anyway, if you prefer to stick at '--', then you should consistently >> use it for '--version', '--classpath', '--all' Renamed to --version. > > Maybe I'm in error, but additionally it seems to me, that > "-classpath=Foo" doesn't match by: -classpath is the one inconsistent with others. We think that it would be better to live with "-classpath" as people are familiar with -classpath option. Thanks Mandy [1] http://mail.openjdk.java.net/pipermail/jigsaw-dev/2009-March/000046.html From Ulf.Zibis at CoSoCo.de Fri Dec 14 16:35:00 2012 From: Ulf.Zibis at CoSoCo.de (Ulf Zibis) Date: Sat, 15 Dec 2012 01:35:00 +0100 Subject: Review request: 8003562: Provide a command-line tool to find static dependencies In-Reply-To: <50CB920A.7080208@oracle.com> References: <50B54A2C.1040907@oracle.com> <50BFF69E.1040805@oracle.com> <50C265D8.3050107@oracle.com> <50C5B9B2.2050705@oracle.com> <50CA6DA1.1070004@oracle.com> <50CA8BB1.1030502@oracle.com> <50CAD3A3.5040300@oracle.com> <50CB135B.7070707@CoSoCo.de> <50CB920A.7080208@oracle.com> Message-ID: <50CBC5B4.8010707@CoSoCo.de> Thanks for your explanations Mandy. Am 14.12.2012 21:54, schrieb Mandy Chung: > > On 12/14/2012 3:54 AM, Ulf Zibis wrote: >> In many places the source is exhausting to read, e.g >> if (f.exists()) { >> ClassFileReader reader = ClassFileReader.newInstance(f); >> Archive archive = new Archive(f, reader); >> result.add(archive); >> } >> could simply be: >> if (f.exists()) >> result.add(new Archive(f, ClassFileReader.newInstance(f))); >> >> ... also spreading around the variable definitions at different places. > > Fixed. Other examples: =================================== 484 while (arg != null) { ... 490 arg = iter.hasNext() ? iter.next() : null; 491 } Could be: 484 for (; iter.hasNext(); arg = iter.next()) { ... 491 } =================================== 224 Dependency.Finder finder = Dependencies.getClassDependencyFinder(); ... 238 findDependencies(finder, filter); ... 273 private void findDependencies(Dependency.Finder finder, 274 Dependency.Filter filter) Could be: 238 findDependencies(filter); ... 273 private void findDependencies(Dependency.Filter filter) { 274 Dependency.Finder finder = Dependencies.getClassDependencyFinder(); at least remove line 224 and use: 238 findDependencies(Dependencies.getClassDependencyFinder(), filter); =================================== -Ulf From Ulf.Zibis at CoSoCo.de Fri Dec 14 16:44:00 2012 From: Ulf.Zibis at CoSoCo.de (Ulf Zibis) Date: Sat, 15 Dec 2012 01:44:00 +0100 Subject: Review request: 8003562: Provide a command-line tool to find static dependencies In-Reply-To: <50CB9CF5.4090300@oracle.com> References: <50B54A2C.1040907@oracle.com> <50BFF69E.1040805@oracle.com> <50C265D8.3050107@oracle.com> <50C5B9B2.2050705@oracle.com> <50CA6DA1.1070004@oracle.com> <50CA8BB1.1030502@oracle.com> <50CB03D1.5030400@CoSoCo.de> <50CB33FE.7000605@CoSoCo.de> <50CB9CF5.4090300@oracle.com> Message-ID: <50CBC7D0.9050103@CoSoCo.de> Am 14.12.2012 22:41, schrieb Mandy Chung: > >> Maybe I'm in error, but additionally it seems to me, that "-classpath=Foo" doesn't match by: > > -classpath is the one inconsistent with others. We think that it would be better to live with > "-classpath" as people are familiar with -classpath option. Ah, I see. But then you should still use: 108 new Option(true, "-cp", "-classpath") { Additionally, why not providing both, the old + new syntax: 108 new Option(true, "-cp", "-classpath", "--classpath") { People are also still familiar with -version ! -Ulf From jonathan.gibbons at oracle.com Fri Dec 14 17:23:28 2012 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Fri, 14 Dec 2012 17:23:28 -0800 Subject: Review request: 8003562: Provide a command-line tool to find static dependencies In-Reply-To: <50CBC7D0.9050103@CoSoCo.de> References: <50B54A2C.1040907@oracle.com> <50BFF69E.1040805@oracle.com> <50C265D8.3050107@oracle.com> <50C5B9B2.2050705@oracle.com> <50CA6DA1.1070004@oracle.com> <50CA8BB1.1030502@oracle.com> <50CB03D1.5030400@CoSoCo.de> <50CB33FE.7000605@CoSoCo.de> <50CB9CF5.4090300@oracle.com> <50CBC7D0.9050103@CoSoCo.de> Message-ID: <50CBD110.1080208@oracle.com> On 12/14/2012 04:44 PM, Ulf Zibis wrote: > Am 14.12.2012 22:41, schrieb Mandy Chung: >> >>> Maybe I'm in error, but additionally it seems to me, that >>> "-classpath=Foo" doesn't match by: >> >> -classpath is the one inconsistent with others. We think that it >> would be better to live with "-classpath" as people are familiar with >> -classpath option. > > Ah, I see. But then you should still use: > 108 new Option(true, "-cp", "-classpath") { > > Additionally, why not providing both, the old + new syntax: > 108 new Option(true, "-cp", "-classpath", "--classpath") { > > People are also still familiar with -version ! > > -Ulf > I guess I am against inconsistent use of the GNU option pattern. It is bad enough that we have to have different tools with different standards, but if we're going to a more GNU like pattern, we should have a more consistent policy about how we mix these styles. Inconsistently adopting GNU style is in my opinion worse than not adopting it. -- Jon From mandy.chung at oracle.com Fri Dec 14 17:30:39 2012 From: mandy.chung at oracle.com (Mandy Chung) Date: Fri, 14 Dec 2012 17:30:39 -0800 Subject: Review request: 8003562: Provide a command-line tool to find static dependencies In-Reply-To: <50CBD110.1080208@oracle.com> References: <50B54A2C.1040907@oracle.com> <50BFF69E.1040805@oracle.com> <50C265D8.3050107@oracle.com> <50C5B9B2.2050705@oracle.com> <50CA6DA1.1070004@oracle.com> <50CA8BB1.1030502@oracle.com> <50CB03D1.5030400@CoSoCo.de> <50CB33FE.7000605@CoSoCo.de> <50CB9CF5.4090300@oracle.com> <50CBC7D0.9050103@CoSoCo.de> <50CBD110.1080208@oracle.com> Message-ID: <50CBD2BF.90100@oracle.com> On 12/14/2012 5:23 PM, Jonathan Gibbons wrote: >>> -classpath is the one inconsistent with others. We think that it >>> would be better to live with "-classpath" as people are familiar >>> with -classpath option. >> >> Ah, I see. But then you should still use: >> 108 new Option(true, "-cp", "-classpath") { >> >> Additionally, why not providing both, the old + new syntax: >> 108 new Option(true, "-cp", "-classpath", "--classpath") { >> >> People are also still familiar with -version ! >> >> -Ulf >> > > I guess I am against inconsistent use of the GNU option pattern. It is > bad enough that we have to have different tools with different > standards, but if we're going to a more GNU like pattern, we should > have a more consistent policy about how we mix these styles. > Inconsistently adopting GNU style is in my opinion worse than not > adopting it. Having a second thought, it's a new tool and we need to learn its options anyway. I'd opt for consistency than familiarity and not to have mixture of Unix-style and GNU-style options. If no objection, I will change it to --classpath for the initial push. Mandy From vicente.romero at oracle.com Sat Dec 15 05:43:42 2012 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Sat, 15 Dec 2012 13:43:42 +0000 Subject: hg: jdk8/tl/langtools: 8004976: test/tools/javac/7153958/CPoolRefClassContainingInlinedCts.java can fail Message-ID: <20121215134348.1B0384719A@hg.openjdk.java.net> Changeset: 37a5d7eccb87 Author: vromero Date: 2012-12-14 11:16 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/37a5d7eccb87 8004976: test/tools/javac/7153958/CPoolRefClassContainingInlinedCts.java can fail Reviewed-by: jjg, mcimadamore ! test/tools/javac/7153958/CPoolRefClassContainingInlinedCts.java From vicente.romero at oracle.com Sat Dec 15 06:02:59 2012 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Sat, 15 Dec 2012 14:02:59 +0000 Subject: hg: jdk8/tl/langtools: 8000518: Javac generates duplicate name_and_type constant pool entry for class BinaryOpValueExp.java Message-ID: <20121215140302.1CD004719B@hg.openjdk.java.net> Changeset: de1ec6fc93fe Author: vromero Date: 2012-12-15 13:54 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/de1ec6fc93fe 8000518: Javac generates duplicate name_and_type constant pool entry for class BinaryOpValueExp.java Reviewed-by: jjg, mcimadamore ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java ! src/share/classes/com/sun/tools/javac/jvm/ClassFile.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/jvm/Pool.java ! src/share/classes/com/sun/tools/javac/sym/CreateSymbols.java + test/tools/javac/8000518/DuplicateConstantPoolEntry.java ! test/tools/javac/lambda/TestInvokeDynamic.java From alan.bateman at oracle.com Sat Dec 15 07:11:18 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Sat, 15 Dec 2012 15:11:18 +0000 Subject: hg: jdk8/tl/jdk: 8004963: URLConnection, downgrade normative reference to ${java.home}/lib/content-types.properties Message-ID: <20121215151130.417F44719C@hg.openjdk.java.net> Changeset: 69fd3f3d20c1 Author: alanb Date: 2012-12-15 15:07 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/69fd3f3d20c1 8004963: URLConnection, downgrade normative reference to ${java.home}/lib/content-types.properties Reviewed-by: chegar ! src/share/classes/java/net/URLConnection.java From weijun.wang at oracle.com Sun Dec 16 20:42:00 2012 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Mon, 17 Dec 2012 04:42:00 +0000 Subject: hg: jdk8/tl/jdk: 7197159: accept different kvno if there no match Message-ID: <20121217044222.4A03C471B5@hg.openjdk.java.net> Changeset: eaaec81aa974 Author: weijun Date: 2012-12-17 12:18 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/eaaec81aa974 7197159: accept different kvno if there no match Reviewed-by: xuelei ! src/share/classes/sun/security/krb5/EncryptionKey.java ! test/sun/security/krb5/auto/DynamicKeytab.java + test/sun/security/krb5/auto/KvnoNA.java ! test/sun/security/krb5/auto/MoreKvno.java From lana.steuck at oracle.com Sun Dec 16 23:36:21 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 17 Dec 2012 07:36:21 +0000 Subject: hg: jdk8/tl: 13 new changesets Message-ID: <20121217073622.E5498471B9@hg.openjdk.java.net> Changeset: 98a7af257bee Author: erikj Date: 2012-12-03 10:26 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/rev/98a7af257bee 8003819: build-infra: backslashes at end of LIB and INCLUDE in spec.gmk Summary: Removing trailing backslash from LIB and INCLUDE. Reviewed-by: ohrstrom, ohair ! common/autoconf/generated-configure.sh ! common/autoconf/toolchain_windows.m4 Changeset: 754f91d22e1c Author: erikj Date: 2012-12-05 09:39 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/rev/754f91d22e1c 8001541: Cannot build on Solaris using softlinks Summary: Fixed softlink resolver macro in configure. Reviewed-by: tbell, ohair ! common/autoconf/basics.m4 ! common/autoconf/generated-configure.sh Changeset: ec187d02c95e Author: erikj Date: 2012-12-05 10:12 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/rev/ec187d02c95e 8004281: build-infra: Move all jar creation to images target and put jars in images/lib Summary: Fixed bug in setting up make dependencies in SetupArchive. Reviewed-by: ohair, tbell, dholmes ! common/makefiles/JavaCompilation.gmk Changeset: bd32ef0789ca Author: erikj Date: 2012-12-05 16:35 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/rev/bd32ef0789ca 8003414: build-infra: fails on on windows Summary: Added extra check that windows sdk is valid. Reviewed-by: tbell, ohrstrom, ohair ! common/autoconf/generated-configure.sh ! common/autoconf/toolchain_windows.m4 Changeset: 9a6ec97ec45c Author: katleman Date: 2012-12-05 12:52 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/9a6ec97ec45c Merge Changeset: c91c581321ce Author: katleman Date: 2012-12-06 12:04 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/c91c581321ce Added tag jdk8-b67 for changeset 9a6ec97ec45c ! .hgtags Changeset: 04435608c613 Author: lana Date: 2012-12-10 20:52 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/04435608c613 Merge Changeset: 6b96b7744913 Author: erikj Date: 2012-12-07 17:23 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/rev/6b96b7744913 8004045: build-infra: Error 12 from zip when updating src.zip Summary: Hiding this error from make so that it doesn't fail Reviewed-by: ohrstrom, dholmes ! common/makefiles/JavaCompilation.gmk Changeset: 2795874efd16 Author: erikj Date: 2012-12-11 11:29 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/rev/2795874efd16 8003945: build-infra: problems finding compiler when using --with-dev-kit Summary: Search all compiler names in dev-kit dir first. Reviewed-by: tbell ! common/autoconf/generated-configure.sh ! common/autoconf/toolchain.m4 Changeset: e175ecff1391 Author: erikj Date: 2012-12-11 11:33 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/rev/e175ecff1391 8001753: build-infra: mismatch with full debug symbol control for hotspot Summary: Enabling hotspot to use the FDS settings established at configure time Reviewed-by: dholmes, ohair ! common/autoconf/generated-configure.sh ! common/autoconf/hotspot-spec.gmk.in ! common/autoconf/jdk-options.m4 ! common/makefiles/NativeCompilation.gmk Changeset: cdb401a60cea Author: katleman Date: 2012-12-12 13:19 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/cdb401a60cea Merge Changeset: e9ec00893bb4 Author: katleman Date: 2012-12-13 09:05 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/e9ec00893bb4 Added tag jdk8-b68 for changeset cdb401a60cea ! .hgtags Changeset: 2ed5be3dd506 Author: lana Date: 2012-12-16 22:02 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/2ed5be3dd506 Merge From lana.steuck at oracle.com Sun Dec 16 23:36:21 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 17 Dec 2012 07:36:21 +0000 Subject: hg: jdk8/tl/corba: 2 new changesets Message-ID: <20121217073624.2ABCA471BA@hg.openjdk.java.net> Changeset: 82000531feaa Author: katleman Date: 2012-12-06 12:04 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/82000531feaa Added tag jdk8-b67 for changeset 394515ad2a55 ! .hgtags Changeset: 22ddcac208a8 Author: katleman Date: 2012-12-13 09:05 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/22ddcac208a8 Added tag jdk8-b68 for changeset 82000531feaa ! .hgtags From lana.steuck at oracle.com Sun Dec 16 23:36:21 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 17 Dec 2012 07:36:21 +0000 Subject: hg: jdk8/tl/jaxws: 2 new changesets Message-ID: <20121217073630.41FAB471BB@hg.openjdk.java.net> Changeset: d3fe408f3a9a Author: katleman Date: 2012-12-06 12:04 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/d3fe408f3a9a Added tag jdk8-b67 for changeset eb06aa51dfc2 ! .hgtags Changeset: 756323c99011 Author: katleman Date: 2012-12-13 09:05 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/756323c99011 Added tag jdk8-b68 for changeset d3fe408f3a9a ! .hgtags From lana.steuck at oracle.com Sun Dec 16 23:36:21 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 17 Dec 2012 07:36:21 +0000 Subject: hg: jdk8/tl/jaxp: 3 new changesets Message-ID: <20121217073633.F1ED7471BC@hg.openjdk.java.net> Changeset: b854e7008421 Author: katleman Date: 2012-12-06 12:04 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/b854e7008421 Added tag jdk8-b67 for changeset 83df3493ca3c ! .hgtags Changeset: 789a855de959 Author: katleman Date: 2012-12-13 09:05 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/789a855de959 Added tag jdk8-b68 for changeset b854e7008421 ! .hgtags Changeset: 8a20e948b806 Author: lana Date: 2012-12-16 22:05 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/8a20e948b806 Merge From lana.steuck at oracle.com Sun Dec 16 23:36:24 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 17 Dec 2012 07:36:24 +0000 Subject: hg: jdk8/tl/langtools: 4 new changesets Message-ID: <20121217073636.62D0F471BD@hg.openjdk.java.net> Changeset: e9a13a6c9d5d Author: katleman Date: 2012-12-06 12:04 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e9a13a6c9d5d Added tag jdk8-b67 for changeset 303b09787a69 ! .hgtags Changeset: 014a6a11dfe5 Author: lana Date: 2012-12-10 20:59 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/014a6a11dfe5 Merge - test/tools/javac/defaultMethodExecution/DefaultMethodRegressionTests.java - test/tools/javac/diags/examples/InvalidGenericDescInFunctionalInterface.java - test/tools/javac/lambda/LambdaConversionTest.java Changeset: 13ccb5269f3d Author: katleman Date: 2012-12-13 09:05 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/13ccb5269f3d Added tag jdk8-b68 for changeset 014a6a11dfe5 ! .hgtags Changeset: f72dc656a306 Author: lana Date: 2012-12-16 22:10 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f72dc656a306 Merge From lana.steuck at oracle.com Sun Dec 16 23:36:38 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 17 Dec 2012 07:36:38 +0000 Subject: hg: jdk8/tl/hotspot: 48 new changesets Message-ID: <20121217073813.AEFEA471BE@hg.openjdk.java.net> Changeset: e1d42ba865de Author: amurillo Date: 2012-11-16 09:43 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e1d42ba865de 8003541: new hotspot build - hs25-b11 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 49cbd3e25ba9 Author: zgu Date: 2012-11-16 09:05 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/49cbd3e25ba9 8003487: NMT: incorrect assertion in VMMemPointerIterator::remove_released_region method (memSnapshot.cpp) Summary: The assertion is applied to only the region to be released, also performs region integrity checking Reviewed-by: acorn, coleenp ! src/share/vm/services/memSnapshot.cpp ! src/share/vm/services/memSnapshot.hpp Changeset: 3ed6de6e139b Author: coleenp Date: 2012-11-20 20:27 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3ed6de6e139b Merge Changeset: 73e64867adb7 Author: mikael Date: 2012-11-21 09:02 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/73e64867adb7 8003690: Example code in JVMTI GetStackTrace documentation is broken Summary: Fixed to minor errors in example code Reviewed-by: sspitsyn, dholmes ! src/share/vm/prims/jvmti.xml Changeset: 6b881a6b0665 Author: dholmes Date: 2012-11-21 20:07 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6b881a6b0665 8003591: Abstract_VM_Version::internal_vm_info_string needs to stringify FLOAT_ARCH for ease of use Reviewed-by: coleenp, kvn ! src/share/vm/runtime/vm_version.cpp Changeset: ca1be5fbe6ff Author: dholmes Date: 2012-11-21 21:26 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ca1be5fbe6ff Merge Changeset: 7c15faa95ce7 Author: mikael Date: 2012-11-27 07:57 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7c15faa95ce7 8003879: Duplicate definitions in vmStructs Summary: Removed duplicate entries Reviewed-by: dholmes, sspitsyn ! src/share/vm/gc_implementation/concurrentMarkSweep/vmStructs_cms.hpp ! src/share/vm/prims/jni.cpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/runtime/vmStructs.hpp Changeset: bbc14465e7db Author: zgu Date: 2012-11-28 09:19 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/bbc14465e7db 8003689: MemTracker::init_tracking_options() reads outside array if commandline argument is empty Summary: Fixed potential buffer overrun when giving empty option to NativeMemoryTracking commandline option Reviewed-by: ctornqvi, hseigel, kvn ! src/share/vm/services/memTracker.cpp Changeset: 5de2a5bd519e Author: zgu Date: 2012-11-28 06:42 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5de2a5bd519e Merge Changeset: fe81517cfb77 Author: hseigel Date: 2012-11-28 08:17 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/fe81517cfb77 6924920: Class Data Sharing limit on the java version string can create failures Summary: Truncate the java version string and add a hash value if it is too long. Reviewed-by: dholmes, coleenp ! src/share/vm/memory/filemap.cpp Changeset: b51dc8df86e5 Author: coleenp Date: 2012-11-28 08:43 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b51dc8df86e5 Merge Changeset: 59c790074993 Author: coleenp Date: 2012-11-28 17:50 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/59c790074993 8003635: NPG: AsynchGetCallTrace broken by Method* virtual call Summary: Make metaspace::contains be lock free and used to see if something is in metaspace, also compare Method* with vtbl pointer. Reviewed-by: dholmes, sspitsyn, dcubed, jmasa ! src/cpu/sparc/vm/frame_sparc.cpp ! src/cpu/x86/vm/frame_x86.cpp ! src/share/vm/gc_interface/collectedHeap.hpp ! src/share/vm/gc_interface/collectedHeap.inline.hpp ! src/share/vm/memory/allocation.cpp ! src/share/vm/memory/allocation.hpp ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/metaspace.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/oops/compiledICHolder.cpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/method.hpp ! src/share/vm/prims/forte.cpp ! src/share/vm/utilities/globalDefinitions.hpp Changeset: 53715fb1597d Author: brutisso Date: 2012-11-20 11:40 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/53715fb1597d 7198334: UseNUMA modifies system parameters on non-NUMA system Summary: The flags MinHeapDeltaBytes and UseNUMAInterleaving must be adjusted after the OS have adjusted the UseNUMA flag in the method os::init_2. Reviewed-by: dholmes, brutisso Contributed-by: erik.helin at oracle.com ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/arguments.hpp ! src/share/vm/runtime/thread.cpp Changeset: 19c1bd641922 Author: coleenp Date: 2012-11-26 12:31 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/19c1bd641922 8003722: More gcc 4.7 compilation errors Summary: Add a few more this->qualifications. Reviewed-by: coleenp, dholmes Contributed-by: duboscq at ssw.jku.at ! src/share/vm/memory/binaryTreeDictionary.cpp Changeset: d0aa87f04bd5 Author: stefank Date: 2012-11-27 10:13 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d0aa87f04bd5 8003720: NPG: Method in interpreter stack frame can be deallocated Summary: Pass down a closure during root scanning to keep the class of the method alive. Reviewed-by: coleenp, jcoomes ! src/share/vm/gc_implementation/parallelScavenge/pcTasks.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psTasks.cpp ! src/share/vm/memory/iterator.cpp ! src/share/vm/memory/iterator.hpp ! src/share/vm/memory/sharedHeap.cpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/frame.cpp ! src/share/vm/runtime/frame.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/thread.hpp ! src/share/vm/runtime/vmThread.cpp ! src/share/vm/runtime/vmThread.hpp + test/runtime/8003720/Asmator.java + test/runtime/8003720/Test8003720.java + test/runtime/8003720/Victim.java + test/runtime/8003720/VictimClassLoader.java Changeset: f34d701e952e Author: stefank Date: 2012-11-27 14:20 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f34d701e952e 8003935: Simplify the needed includes for using Thread::current() Reviewed-by: dholmes, rbackman, coleenp ! src/cpu/sparc/vm/interp_masm_sparc.cpp ! src/cpu/sparc/vm/stubGenerator_sparc.cpp ! src/cpu/sparc/vm/stubRoutines_sparc.cpp ! src/cpu/x86/vm/interp_masm_x86_32.cpp ! src/cpu/x86/vm/interp_masm_x86_64.cpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp ! src/cpu/x86/vm/stubRoutines_x86_32.cpp ! src/cpu/x86/vm/stubRoutines_x86_64.cpp ! src/cpu/zero/vm/interp_masm_zero.cpp ! src/cpu/zero/vm/stubGenerator_zero.cpp ! src/cpu/zero/vm/stubRoutines_zero.cpp ! src/os/bsd/vm/mutex_bsd.cpp ! src/os/bsd/vm/mutex_bsd.inline.hpp ! src/os/bsd/vm/os_bsd.cpp ! src/os/bsd/vm/threadCritical_bsd.cpp ! src/os/bsd/vm/thread_bsd.inline.hpp ! src/os/linux/vm/mutex_linux.cpp ! src/os/linux/vm/mutex_linux.inline.hpp ! src/os/linux/vm/os_linux.cpp ! src/os/linux/vm/threadCritical_linux.cpp ! src/os/linux/vm/thread_linux.inline.hpp ! src/os/solaris/vm/mutex_solaris.cpp ! src/os/solaris/vm/mutex_solaris.inline.hpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/solaris/vm/threadCritical_solaris.cpp ! src/os/solaris/vm/thread_solaris.inline.hpp ! src/os/windows/vm/mutex_windows.cpp ! src/os/windows/vm/mutex_windows.inline.hpp ! src/os/windows/vm/os_windows.cpp ! src/os/windows/vm/threadCritical_windows.cpp ! src/os/windows/vm/thread_windows.inline.hpp ! src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp ! src/os_cpu/bsd_x86/vm/threadLS_bsd_x86.cpp ! src/os_cpu/bsd_x86/vm/thread_bsd_x86.cpp ! src/os_cpu/bsd_zero/vm/os_bsd_zero.cpp ! src/os_cpu/bsd_zero/vm/threadLS_bsd_zero.cpp ! src/os_cpu/bsd_zero/vm/thread_bsd_zero.cpp ! src/os_cpu/linux_sparc/vm/os_linux_sparc.cpp ! src/os_cpu/linux_sparc/vm/threadLS_linux_sparc.cpp ! src/os_cpu/linux_sparc/vm/thread_linux_sparc.cpp ! src/os_cpu/linux_x86/vm/os_linux_x86.cpp ! src/os_cpu/linux_x86/vm/threadLS_linux_x86.cpp ! src/os_cpu/linux_x86/vm/thread_linux_x86.cpp ! src/os_cpu/linux_zero/vm/os_linux_zero.cpp ! src/os_cpu/linux_zero/vm/threadLS_linux_zero.cpp ! src/os_cpu/linux_zero/vm/thread_linux_zero.cpp ! src/os_cpu/solaris_sparc/vm/os_solaris_sparc.cpp ! src/os_cpu/solaris_sparc/vm/threadLS_solaris_sparc.cpp ! src/os_cpu/solaris_sparc/vm/thread_solaris_sparc.cpp ! src/os_cpu/solaris_x86/vm/os_solaris_x86.cpp ! src/os_cpu/solaris_x86/vm/threadLS_solaris_x86.cpp ! src/os_cpu/solaris_x86/vm/thread_solaris_x86.cpp ! src/os_cpu/windows_x86/vm/os_windows_x86.cpp ! src/os_cpu/windows_x86/vm/threadLS_windows_x86.cpp ! src/os_cpu/windows_x86/vm/thread_windows_x86.cpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsCollectorPolicy.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepThread.hpp ! src/share/vm/gc_implementation/g1/dirtyCardQueue.cpp ! src/share/vm/gc_implementation/g1/g1SATBCardTableModRefBS.cpp ! src/share/vm/gc_implementation/g1/ptrQueue.cpp ! src/share/vm/gc_implementation/shared/mutableNUMASpace.cpp ! src/share/vm/gc_interface/collectedHeap.cpp ! src/share/vm/gc_interface/collectedHeap.inline.hpp ! src/share/vm/interpreter/abstractInterpreter.hpp ! src/share/vm/interpreter/interpreterRuntime.hpp ! src/share/vm/interpreter/linkResolver.cpp ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/memory/defNewGeneration.cpp ! src/share/vm/memory/freeBlockDictionary.cpp ! src/share/vm/memory/gcLocker.hpp ! src/share/vm/memory/genMarkSweep.cpp ! src/share/vm/memory/resourceArea.cpp ! src/share/vm/memory/resourceArea.hpp ! src/share/vm/memory/threadLocalAllocBuffer.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/markOop.cpp ! src/share/vm/oops/oop.cpp ! src/share/vm/oops/oopsHierarchy.cpp ! src/share/vm/prims/jni.cpp ! src/share/vm/prims/jvmtiEnv.cpp ! src/share/vm/prims/jvmtiImpl.cpp ! src/share/vm/runtime/fprofiler.hpp ! src/share/vm/runtime/handles.cpp ! src/share/vm/runtime/handles.inline.hpp ! src/share/vm/runtime/interfaceSupport.hpp ! src/share/vm/runtime/java.cpp ! src/share/vm/runtime/javaCalls.cpp ! src/share/vm/runtime/javaCalls.hpp ! src/share/vm/runtime/jniHandles.cpp ! src/share/vm/runtime/memprofiler.cpp ! src/share/vm/runtime/mutex.cpp ! src/share/vm/runtime/mutexLocker.cpp ! src/share/vm/runtime/objectMonitor.cpp ! src/share/vm/runtime/os.cpp ! src/share/vm/runtime/safepoint.cpp ! src/share/vm/runtime/synchronizer.cpp ! src/share/vm/runtime/task.cpp ! src/share/vm/runtime/thread.cpp + src/share/vm/runtime/thread.inline.hpp ! src/share/vm/runtime/threadLocalStorage.cpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/runtime/vmThread.cpp ! src/share/vm/runtime/vmThread.hpp ! src/share/vm/runtime/vm_operations.cpp ! src/share/vm/services/memTracker.hpp ! src/share/vm/utilities/array.cpp ! src/share/vm/utilities/debug.cpp ! src/share/vm/utilities/events.cpp ! src/share/vm/utilities/exceptions.cpp ! src/share/vm/utilities/growableArray.cpp ! src/share/vm/utilities/preserveException.hpp ! src/share/vm/utilities/taskqueue.cpp ! src/share/vm/utilities/workgroup.hpp Changeset: 2fc0334f613a Author: johnc Date: 2012-11-27 14:11 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2fc0334f613a 7194633: G1: Assertion and guarantee failures in block offset table Summary: Add detailed error messages to assertions and guarantees in G1's block offset table. Reviewed-by: ysr, brutisso ! src/share/vm/gc_implementation/g1/g1BlockOffsetTable.cpp ! src/share/vm/gc_implementation/g1/g1BlockOffsetTable.hpp ! src/share/vm/gc_implementation/g1/g1BlockOffsetTable.inline.hpp ! src/share/vm/memory/space.cpp Changeset: c24f778e9401 Author: johnc Date: 2012-11-29 11:23 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c24f778e9401 Merge ! src/share/vm/gc_interface/collectedHeap.inline.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/prims/jni.cpp ! src/share/vm/runtime/vmStructs.cpp Changeset: b2dbd323c668 Author: jiangli Date: 2012-11-27 17:03 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b2dbd323c668 8003848: Make ConstMethod::generic_signature_index optional and move Method::_max_stack to ConstMethod. Summary: Make ConstMethod::generic_signature_index optional and move Method::_max_stack to ConstMethod. Reviewed-by: bdelsart, sspitsyn, coleenp ! agent/src/share/classes/sun/jvm/hotspot/oops/ConstMethod.java ! agent/src/share/classes/sun/jvm/hotspot/oops/Method.java ! src/cpu/sparc/vm/cppInterpreter_sparc.cpp ! src/cpu/sparc/vm/interp_masm_sparc.cpp ! src/cpu/sparc/vm/templateInterpreter_sparc.cpp ! src/cpu/x86/vm/cppInterpreter_x86.cpp ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/defaultMethods.cpp ! src/share/vm/oops/constMethod.cpp ! src/share/vm/oops/constMethod.hpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/method.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 5505fbbae3d3 Author: cjplummer Date: 2012-11-29 13:55 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5505fbbae3d3 Merge ! src/cpu/sparc/vm/interp_masm_sparc.cpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/method.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 90273fc0a981 Author: coleenp Date: 2012-11-29 16:50 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/90273fc0a981 8000662: NPG: nashorn ant clean test262 out-of-memory with Java heap Summary: Add ClassLoaderData object for each anonymous class with metaspaces to allocate in. Reviewed-by: twisti, jrose, stefank ! src/share/vm/asm/codeBuffer.cpp ! src/share/vm/ci/ciReplay.cpp ! src/share/vm/ci/ciReplay.hpp ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/classFileParser.hpp ! src/share/vm/classfile/classLoader.cpp ! src/share/vm/classfile/classLoaderData.cpp ! src/share/vm/classfile/classLoaderData.hpp ! src/share/vm/classfile/classLoaderData.inline.hpp ! src/share/vm/classfile/dictionary.cpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/loaderConstraints.cpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/compiler/compileBroker.hpp ! src/share/vm/memory/metachunk.hpp ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/metaspace.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/oops/constantPool.cpp ! src/share/vm/oops/klass.cpp ! src/share/vm/oops/klass.hpp ! src/share/vm/oops/objArrayKlass.cpp ! src/share/vm/prims/unsafe.cpp Changeset: dad48145e775 Author: stefank Date: 2012-11-29 23:02 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/dad48145e775 8004199: Change the ASM package for Test8003720 Reviewed-by: kvn, jrose ! test/runtime/8003720/Asmator.java ! test/runtime/8003720/Test8003720.java Changeset: 5fafdef522c6 Author: johnc Date: 2012-11-30 12:01 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5fafdef522c6 Merge ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/metaspace.hpp ! src/share/vm/memory/universe.cpp Changeset: b61d9c88b759 Author: amurillo Date: 2012-11-30 16:45 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b61d9c88b759 Merge Changeset: 25bdce771bb3 Author: amurillo Date: 2012-11-30 16:45 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/25bdce771bb3 Added tag hs25-b11 for changeset b61d9c88b759 ! .hgtags Changeset: 10587a580c51 Author: katleman Date: 2012-12-06 12:04 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/10587a580c51 Added tag jdk8-b67 for changeset 25bdce771bb3 ! .hgtags Changeset: 816b7e5bf2ed Author: amurillo Date: 2012-11-30 17:00 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/816b7e5bf2ed 8004248: new hotspot build - hs25-b12 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 7cc69864a29b Author: kvn Date: 2012-11-16 15:49 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7cc69864a29b 7146636: compiler/6865265/StackOverflowBug.java fails due to changed stack minimum Summary: Increase the stack size in the run parameters. Reviewed-by: kvn Contributed-by: david.r.chase at oracle.com ! test/compiler/6865265/StackOverflowBug.java Changeset: ee32440febeb Author: vlivanov Date: 2012-11-21 05:57 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ee32440febeb 8001538: hs_err file does not list anymore compiled methods in compilation events Summary: Fixed message buffer size calculation. Reviewed-by: kvn, twisti ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/utilities/events.hpp Changeset: beebba0acc11 Author: twisti Date: 2012-11-26 17:25 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/beebba0acc11 7172640: C2: instrinsic implementations in LibraryCallKit should use argument() instead of pop() Reviewed-by: kvn, jrose ! src/share/vm/ci/ciMethod.cpp ! src/share/vm/ci/ciMethod.hpp ! src/share/vm/ci/ciSignature.hpp ! src/share/vm/interpreter/bytecodes.hpp ! src/share/vm/opto/callGenerator.cpp ! src/share/vm/opto/callnode.hpp ! src/share/vm/opto/doCall.cpp ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/graphKit.hpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/locknode.cpp ! src/share/vm/opto/parse1.cpp ! src/share/vm/opto/parse2.cpp ! src/share/vm/opto/parse3.cpp ! src/share/vm/opto/parseHelper.cpp ! src/share/vm/opto/type.hpp Changeset: 2cd5e15048e6 Author: twisti Date: 2012-11-27 12:48 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2cd5e15048e6 8003868: fix shark for latest HotSpot and LLVM Reviewed-by: twisti Contributed-by: Roman Kennke ! src/cpu/zero/vm/assembler_zero.cpp ! src/cpu/zero/vm/assembler_zero.hpp ! src/cpu/zero/vm/cppInterpreter_zero.cpp ! src/cpu/zero/vm/globals_zero.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/shark/llvmHeaders.hpp ! src/share/vm/shark/llvmValue.hpp ! src/share/vm/shark/sharkBlock.cpp ! src/share/vm/shark/sharkBuilder.cpp ! src/share/vm/shark/sharkBuilder.hpp ! src/share/vm/shark/sharkCacheDecache.cpp ! src/share/vm/shark/sharkCacheDecache.hpp ! src/share/vm/shark/sharkCodeBuffer.hpp ! src/share/vm/shark/sharkCompiler.cpp ! src/share/vm/shark/sharkConstant.cpp ! src/share/vm/shark/sharkContext.cpp ! src/share/vm/shark/sharkContext.hpp ! src/share/vm/shark/sharkFunction.hpp ! src/share/vm/shark/sharkIntrinsics.cpp ! src/share/vm/shark/sharkMemoryManager.cpp ! src/share/vm/shark/sharkMemoryManager.hpp ! src/share/vm/shark/sharkNativeWrapper.cpp ! src/share/vm/shark/sharkStack.cpp ! src/share/vm/shark/sharkStack.hpp ! src/share/vm/shark/sharkState.cpp ! src/share/vm/shark/sharkTopLevelBlock.cpp ! src/share/vm/shark/sharkTopLevelBlock.hpp ! src/share/vm/shark/sharkType.hpp ! src/share/vm/shark/sharkValue.cpp ! src/share/vm/shark/shark_globals.hpp Changeset: 2aff40cb4703 Author: bharadwaj Date: 2012-11-27 17:24 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2aff40cb4703 7092905: C2: Keep track of the number of dead nodes Summary: keep an (almost) accurate running count of the reachable (live) flow graph nodes. Reviewed-by: kvn, twisti, jrose, vlivanov ! src/share/tools/LogCompilation/README ! src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/CallSite.java ! src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogCompilation.java ! src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogParser.java ! src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/Phase.java ! src/share/vm/opto/block.hpp ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/opto/chaitin.cpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/gcm.cpp ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/ifg.cpp ! src/share/vm/opto/lcm.cpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/loopUnswitch.cpp ! src/share/vm/opto/loopopts.cpp ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/matcher.cpp ! src/share/vm/opto/node.cpp ! src/share/vm/opto/node.hpp ! src/share/vm/opto/output.cpp ! src/share/vm/opto/parse1.cpp ! src/share/vm/opto/phaseX.cpp ! src/share/vm/opto/postaloc.cpp ! src/share/vm/opto/reg_split.cpp ! src/share/vm/opto/stringopts.cpp Changeset: 1acccb7c0b01 Author: kvn Date: 2012-11-27 17:41 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1acccb7c0b01 8003850: add support for constants in stub code Summary: remember the code section and switch back to the proper one when adding constants. Reviewed-by: twisti, kvn Contributed-by: goetz.lindenmaier at sap.com ! src/share/vm/asm/assembler.cpp ! src/share/vm/asm/assembler.hpp ! src/share/vm/asm/codeBuffer.cpp Changeset: 6ab62ad83507 Author: twisti Date: 2012-11-30 11:44 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6ab62ad83507 8003195: AbstractAssembler should not store code pointers but use the CodeSection directly Reviewed-by: twisti, kvn Contributed-by: Bharadwaj Yadavalli ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/assembler_x86.inline.hpp ! src/share/vm/asm/assembler.cpp ! src/share/vm/asm/assembler.hpp ! src/share/vm/asm/assembler.inline.hpp ! src/share/vm/asm/codeBuffer.hpp Changeset: cd3d6a6b95d9 Author: twisti Date: 2012-11-30 15:23 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/cd3d6a6b95d9 8003240: x86: move MacroAssembler into separate file Reviewed-by: kvn ! src/cpu/sparc/vm/assembler_sparc.cpp ! src/cpu/sparc/vm/codeBuffer_sparc.hpp ! src/cpu/sparc/vm/frame_sparc.hpp ! src/cpu/sparc/vm/frame_sparc.inline.hpp ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/assembler_x86.inline.hpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/cppInterpreter_x86.cpp ! src/cpu/x86/vm/frame_x86.inline.hpp ! src/cpu/x86/vm/icBuffer_x86.cpp ! src/cpu/x86/vm/icache_x86.cpp ! src/cpu/x86/vm/interp_masm_x86_32.hpp ! src/cpu/x86/vm/interp_masm_x86_64.hpp ! src/cpu/x86/vm/interpreter_x86_32.cpp ! src/cpu/x86/vm/interpreter_x86_64.cpp ! src/cpu/x86/vm/jniFastGetField_x86_32.cpp ! src/cpu/x86/vm/jniFastGetField_x86_64.cpp + src/cpu/x86/vm/macroAssembler_x86.cpp + src/cpu/x86/vm/macroAssembler_x86.hpp ! src/cpu/x86/vm/metaspaceShared_x86_32.cpp ! src/cpu/x86/vm/metaspaceShared_x86_64.cpp ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/cpu/x86/vm/nativeInst_x86.cpp ! src/cpu/x86/vm/relocInfo_x86.cpp ! src/cpu/x86/vm/runtime_x86_32.cpp ! src/cpu/x86/vm/runtime_x86_64.cpp ! src/cpu/x86/vm/sharedRuntime_x86_32.cpp ! src/cpu/x86/vm/sharedRuntime_x86_64.cpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp ! src/cpu/x86/vm/templateInterpreter_x86_32.cpp ! src/cpu/x86/vm/templateInterpreter_x86_64.cpp ! src/cpu/x86/vm/templateTable_x86_32.cpp ! src/cpu/x86/vm/templateTable_x86_64.cpp ! src/cpu/x86/vm/vm_version_x86.cpp ! src/cpu/x86/vm/vtableStubs_x86_32.cpp ! src/cpu/x86/vm/vtableStubs_x86_64.cpp ! src/os/bsd/vm/osThread_bsd.cpp ! src/os/bsd/vm/os_bsd.cpp ! src/os/bsd/vm/os_bsd.inline.hpp ! src/os/linux/vm/osThread_linux.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/linux/vm/os_linux.inline.hpp ! src/os/solaris/vm/osThread_solaris.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/solaris/vm/os_solaris.inline.hpp ! src/os/windows/vm/osThread_windows.cpp ! src/os/windows/vm/os_windows.cpp ! src/os/windows/vm/os_windows.inline.hpp ! src/os_cpu/bsd_x86/vm/assembler_bsd_x86.cpp ! src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp ! src/os_cpu/linux_x86/vm/assembler_linux_x86.cpp ! src/os_cpu/linux_x86/vm/os_linux_x86.cpp ! src/os_cpu/solaris_x86/vm/assembler_solaris_x86.cpp ! src/os_cpu/solaris_x86/vm/orderAccess_solaris_x86.inline.hpp ! src/os_cpu/solaris_x86/vm/os_solaris_x86.cpp ! src/os_cpu/windows_x86/vm/assembler_windows_x86.cpp ! src/os_cpu/windows_x86/vm/os_windows_x86.cpp ! src/share/vm/asm/assembler.cpp ! src/share/vm/asm/assembler.hpp ! src/share/vm/asm/assembler.inline.hpp ! src/share/vm/asm/codeBuffer.cpp ! src/share/vm/asm/codeBuffer.hpp + src/share/vm/asm/macroAssembler.hpp + src/share/vm/asm/macroAssembler.inline.hpp ! src/share/vm/c1/c1_MacroAssembler.hpp ! src/share/vm/code/icBuffer.cpp ! src/share/vm/code/relocInfo.cpp ! src/share/vm/interpreter/interpreter.cpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/opto/compile.cpp ! src/share/vm/runtime/atomic.cpp ! src/share/vm/runtime/atomic.hpp + src/share/vm/runtime/atomic.inline.hpp ! src/share/vm/runtime/frame.cpp ! src/share/vm/runtime/frame.hpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/stubCodeGenerator.cpp Changeset: dd38cfd12c3a Author: twisti Date: 2012-12-03 15:48 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/dd38cfd12c3a 8004319: test/gc/7168848/HumongousAlloc.java fails after 7172640 Reviewed-by: kvn, johnc ! src/share/vm/opto/library_call.cpp Changeset: c5d414e98fd4 Author: neliasso Date: 2012-11-26 15:11 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c5d414e98fd4 8003983: LogCompilation tool is broken since c1 support Summary: Fixed emitting and parsing Reviewed-by: jrose, kvn ! src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogCompilation.java ! src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogParser.java ! src/share/vm/c1/c1_Compilation.cpp Changeset: b7ff5879152e Author: neliasso Date: 2012-12-06 09:50 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b7ff5879152e 8003934: Fix generation of malformed options to Projectcreator Summary: Makefile produces unmatched quotes due to nmake bug Reviewed-by: jwilhelm, brutisso ! make/windows/projectfiles/common/Makefile Changeset: 228a94f37a67 Author: neliasso Date: 2012-12-06 14:33 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/228a94f37a67 Merge Changeset: f0c2369fda5a Author: twisti Date: 2012-12-06 09:57 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f0c2369fda5a 8003250: SPARC: move MacroAssembler into separate file Reviewed-by: jrose, kvn ! src/cpu/sparc/vm/assembler_sparc.cpp ! src/cpu/sparc/vm/assembler_sparc.hpp ! src/cpu/sparc/vm/assembler_sparc.inline.hpp ! src/cpu/sparc/vm/frame_sparc.inline.hpp ! src/cpu/sparc/vm/icBuffer_sparc.cpp ! src/cpu/sparc/vm/icache_sparc.cpp ! src/cpu/sparc/vm/interp_masm_sparc.hpp ! src/cpu/sparc/vm/interpreter_sparc.cpp ! src/cpu/sparc/vm/jniFastGetField_sparc.cpp + src/cpu/sparc/vm/macroAssembler_sparc.cpp + src/cpu/sparc/vm/macroAssembler_sparc.hpp + src/cpu/sparc/vm/macroAssembler_sparc.inline.hpp ! src/cpu/sparc/vm/metaspaceShared_sparc.cpp ! src/cpu/sparc/vm/methodHandles_sparc.cpp ! src/cpu/sparc/vm/nativeInst_sparc.cpp ! src/cpu/sparc/vm/nativeInst_sparc.hpp ! src/cpu/sparc/vm/relocInfo_sparc.cpp ! src/cpu/sparc/vm/runtime_sparc.cpp ! src/cpu/sparc/vm/sharedRuntime_sparc.cpp ! src/cpu/sparc/vm/stubGenerator_sparc.cpp ! src/cpu/sparc/vm/templateInterpreter_sparc.cpp ! src/cpu/sparc/vm/vm_version_sparc.cpp ! src/cpu/sparc/vm/vmreg_sparc.cpp ! src/cpu/sparc/vm/vtableStubs_sparc.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/macroAssembler_x86.cpp ! src/cpu/zero/vm/assembler_zero.cpp ! src/cpu/zero/vm/assembler_zero.hpp ! src/os_cpu/linux_sparc/vm/assembler_linux_sparc.cpp ! src/os_cpu/linux_sparc/vm/os_linux_sparc.cpp ! src/os_cpu/solaris_sparc/vm/assembler_solaris_sparc.cpp ! src/os_cpu/solaris_sparc/vm/os_solaris_sparc.cpp ! src/share/vm/adlc/main.cpp ! src/share/vm/asm/assembler.hpp ! src/share/vm/asm/macroAssembler.hpp ! src/share/vm/asm/macroAssembler.inline.hpp ! src/share/vm/asm/register.hpp ! src/share/vm/code/vmreg.hpp Changeset: 522662fa9c16 Author: twisti Date: 2012-12-06 11:05 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/522662fa9c16 Merge Changeset: d2f8c38e543d Author: roland Date: 2012-12-07 01:09 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d2f8c38e543d Merge ! src/cpu/sparc/vm/stubGenerator_sparc.cpp ! src/cpu/sparc/vm/templateInterpreter_sparc.cpp ! src/cpu/x86/vm/cppInterpreter_x86.cpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp ! src/os/bsd/vm/os_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/windows/vm/os_windows.cpp ! src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp ! src/os_cpu/linux_sparc/vm/os_linux_sparc.cpp ! src/os_cpu/linux_x86/vm/os_linux_x86.cpp ! src/os_cpu/solaris_sparc/vm/os_solaris_sparc.cpp ! src/os_cpu/solaris_x86/vm/os_solaris_x86.cpp ! src/os_cpu/windows_x86/vm/os_windows_x86.cpp ! src/share/vm/asm/codeBuffer.cpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/frame.cpp ! src/share/vm/runtime/frame.hpp ! src/share/vm/runtime/thread.cpp Changeset: 0f80645e9c26 Author: johnc Date: 2012-11-30 11:46 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0f80645e9c26 8004170: G1: Verbose GC output is not getting flushed to log file using JDK 8 Summary: Add flushes to G1CollectedHeap::log_gc_footer() and TraceCPUTime destructor. Reviewed-by: jwilhelm, azeemj, brutisso ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/runtime/timer.cpp Changeset: eade6b2e4782 Author: jmasa Date: 2012-11-29 10:09 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/eade6b2e4782 8003554: NPG: move Metablock and Metachunk code out of metaspace.cpp Reviewed-by: coleenp + src/share/vm/memory/metablock.cpp + src/share/vm/memory/metachunk.cpp ! src/share/vm/memory/metaspace.cpp Changeset: cbe736bc70fa Author: jwilhelm Date: 2012-12-07 07:36 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/cbe736bc70fa Merge Changeset: a35a72dd2e12 Author: amurillo Date: 2012-12-07 10:46 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a35a72dd2e12 Merge Changeset: 121aa71316af Author: amurillo Date: 2012-12-07 10:46 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/121aa71316af Added tag hs25-b12 for changeset a35a72dd2e12 ! .hgtags Changeset: 8af7d22f1f8f Author: katleman Date: 2012-12-13 09:05 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8af7d22f1f8f Added tag jdk8-b68 for changeset 121aa71316af ! .hgtags From lana.steuck at oracle.com Sun Dec 16 23:37:33 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 17 Dec 2012 07:37:33 +0000 Subject: hg: jdk8/tl/jdk: 31 new changesets Message-ID: <20121217074324.6403E471BF@hg.openjdk.java.net> Changeset: b0f008ab45d7 Author: twisti Date: 2012-11-30 11:42 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b0f008ab45d7 8001885: JSR 292 classes should use jdk.internal.org.objectweb.asm Reviewed-by: kvn, jrose, twisti Contributed-by: David Chase ! src/share/classes/java/lang/invoke/BoundMethodHandle.java ! src/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java Changeset: 0fda013e4638 Author: erikj Date: 2012-12-05 10:12 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0fda013e4638 8004281: build-infra: Move all jar creation to images target and put jars in images/lib Reviewed-by: ohair, tbell, dholmes ! makefiles/CompileDemos.gmk ! makefiles/CompileJavaClasses.gmk ! makefiles/CreateJars.gmk ! makefiles/Images.gmk ! makefiles/Import.gmk Changeset: ce9b02a3a17e Author: katleman Date: 2012-12-05 12:53 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ce9b02a3a17e Merge Changeset: ea0d3a9d0d01 Author: katleman Date: 2012-12-06 12:04 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ea0d3a9d0d01 Added tag jdk8-b67 for changeset ce9b02a3a17e ! .hgtags Changeset: 39f9b2cc5738 Author: bae Date: 2012-11-28 12:28 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/39f9b2cc5738 4649812: GIFImageReader handles transparency incorrectly Reviewed-by: bae, prr Contributed-by: Vadim Pakhnushev ! src/share/classes/com/sun/imageio/plugins/gif/GIFImageReader.java Changeset: 6569819eb2fe Author: bae Date: 2012-11-28 12:38 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6569819eb2fe 5082749: GIF stream metadata specification of aspect ratio is incorrect Reviewed-by: bae, prr Contributed-by: Vadim Pakhnushev ! src/share/classes/javax/imageio/metadata/doc-files/gif_metadata.html Changeset: 934595726263 Author: bae Date: 2012-11-28 14:12 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/934595726263 7064516: ImageIO.read() fails to load an image Reviewed-by: jgodinez, prr ! src/share/classes/java/awt/color/ICC_Profile.java ! src/share/classes/java/awt/image/ColorConvertOp.java + test/sun/java2d/cmm/ColorConvertOp/InvalidRenderIntentTest.java Changeset: d54db1e16b97 Author: bae Date: 2012-11-30 11:32 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d54db1e16b97 7124223: [macosx] Regression test failure with new exception, when glyph is positioned explicitly Reviewed-by: jgodinez ! src/share/classes/sun/print/PathGraphics.java Changeset: bd3b3cda125d Author: lana Date: 2012-11-30 16:02 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bd3b3cda125d Merge Changeset: 3c5bf5ed45a9 Author: bae Date: 2012-12-03 16:26 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3c5bf5ed45a9 7124347: [macosx] java.lang.InternalError: not implemented yet on call Graphics2D.drawRenderedImage Reviewed-by: prr, flar ! src/share/classes/sun/java2d/opengl/OGLBlitLoops.java ! src/share/classes/sun/java2d/opengl/OGLSurfaceDataProxy.java + test/sun/java2d/OpenGL/CustomCompositeTest.java Changeset: 1175410d98ea Author: serb Date: 2012-11-21 15:50 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1175410d98ea 7124552: [macosx] NullPointerException in getBufferStrategy() 7124219: [macosx] Unable to draw images to fullscreen Reviewed-by: bae, anthony ! src/macosx/classes/sun/awt/CGraphicsConfig.java ! src/macosx/classes/sun/java2d/opengl/CGLGraphicsConfig.java ! src/macosx/classes/sun/lwawt/LWCanvasPeer.java ! src/macosx/classes/sun/lwawt/LWComponentPeer.java + src/macosx/classes/sun/lwawt/LWGraphicsConfig.java ! src/macosx/classes/sun/lwawt/LWWindowPeer.java ! src/macosx/classes/sun/lwawt/PlatformWindow.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformEmbeddedFrame.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformView.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java - src/share/classes/sun/awt/TextureSizeConstraining.java Changeset: 5b2c31d20a64 Author: serb Date: 2012-11-21 15:54 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5b2c31d20a64 7193214: Consider simplifying CPlatformWindow.setResizable() Reviewed-by: anthony, denis ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/macosx/native/sun/awt/AWTWindow.m Changeset: c9dead63607c Author: serb Date: 2012-11-21 15:58 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c9dead63607c 7154516: [macosx] Popup menus have no visible borders Reviewed-by: anthony, denis ! src/macosx/classes/com/apple/laf/AquaLookAndFeel.java Changeset: 9cd48409539e Author: kizune Date: 2012-11-21 20:42 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9cd48409539e 8003273: Missing testcase for 7171812 Reviewed-by: art, serb + test/javax/swing/dnd/7171812/JListWithScroll.java + test/javax/swing/dnd/7171812/bug7171812.java Changeset: 5600005b87fb Author: serb Date: 2012-11-27 17:03 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5600005b87fb 8002308: [macosx] 7198229 should be applied to the user action only Reviewed-by: anthony, skovatch ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/macosx/native/sun/awt/AWTWindow.m + test/java/awt/Frame/FrameSetSizeStressTest/FrameSetSizeStressTest.java Changeset: 0e91d6f3019c Author: alexsch Date: 2012-11-29 07:42 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0e91d6f3019c 8000423: Diacritic is not applyed to a base letter on Linux Reviewed-by: anthony, serb ! src/solaris/classes/sun/awt/X11/XToolkit.java Changeset: abee1d528df1 Author: kshefov Date: 2012-11-30 12:39 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/abee1d528df1 7124242: [macosx] Test doesn't work because of the frame round corners in the LaF Reviewed-by: anthony, yan, alexsch ! test/javax/swing/text/CSSBorder/6796710/bug6796710.java Changeset: 35d8085aa14a Author: lana Date: 2012-11-30 17:09 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/35d8085aa14a Merge Changeset: da55ef766e48 Author: alexsch Date: 2012-12-04 15:26 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/da55ef766e48 6671481: NPE at javax.swing.plaf.basic.BasicTreeUI$Handler.handleSelection Reviewed-by: serb ! src/share/classes/javax/swing/plaf/basic/BasicTreeUI.java Changeset: bd175c70684c Author: alexsch Date: 2012-12-04 15:56 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bd175c70684c 8003830: NPE at BasicTreeUI$Actions.page:4470 Reviewed-by: serb, alexsch Contributed-by: Jaroslav Tulach ! src/share/classes/javax/swing/plaf/basic/BasicTreeUI.java + test/javax/swing/JTree/8003830/bug8003830.java Changeset: 009fd6e1d9f5 Author: alexsch Date: 2012-12-04 16:42 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/009fd6e1d9f5 8002077: Possible mnemonic issue on JFileChooser Save button on nimbus L&F Reviewed-by: serb ! src/share/classes/sun/swing/plaf/synth/SynthFileChooserUI.java Changeset: 4aad3e6f68d2 Author: jviswana Date: 2012-12-04 17:17 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4aad3e6f68d2 4631925: JColor Chooser is not fully accessible Reviewed-by: alexsch ! src/share/classes/javax/swing/JColorChooser.java ! src/share/classes/javax/swing/colorchooser/ColorChooserPanel.java ! src/share/classes/javax/swing/colorchooser/ColorPanel.java ! src/share/classes/javax/swing/plaf/basic/BasicColorChooserUI.java Changeset: ea20c9388d90 Author: aph Date: 2012-12-04 14:02 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ea20c9388d90 8004344: Fix a crash in ToolkitErrorHandler() in XlibWrapper.c Summary: Code does not check for JNU_GetEnv returning NULL. Reviewed-by: anthony ! src/solaris/native/sun/xawt/XlibWrapper.c Changeset: bbbb5c70aa59 Author: lana Date: 2012-12-04 11:41 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bbbb5c70aa59 Merge - src/share/classes/sun/awt/TextureSizeConstraining.java Changeset: 87028eb3f020 Author: lana Date: 2012-12-04 11:46 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/87028eb3f020 Merge Changeset: b68a5404de60 Author: lana Date: 2012-12-10 20:58 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b68a5404de60 Merge ! makefiles/CompileJavaClasses.gmk - src/share/classes/sun/awt/TextureSizeConstraining.java Changeset: 379e3dfa521d Author: erikj Date: 2012-12-06 12:09 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/379e3dfa521d 8004104: build-infra: Minor cleanup Reviewed-by: ohrstrom, tbell ! makefiles/CompileJavaClasses.gmk ! makefiles/CompileNativeLibraries.gmk Changeset: 2689f6cfe835 Author: erikj Date: 2012-12-11 12:27 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2689f6cfe835 8001753: build-infra: mismatch with full debug symbol control for hotspot Summary: Changing boolean values of ENABLE_DEBUG_SYMBOLS. Reviewed-by: dholmes, ohair ! makefiles/CompileNativeLibraries.gmk Changeset: 53fb43e4d614 Author: katleman Date: 2012-12-12 13:21 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/53fb43e4d614 Merge ! makefiles/CompileJavaClasses.gmk ! makefiles/CompileNativeLibraries.gmk Changeset: 7fd56a5abd94 Author: katleman Date: 2012-12-13 09:05 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7fd56a5abd94 Added tag jdk8-b68 for changeset 53fb43e4d614 ! .hgtags Changeset: f959e0cc8766 Author: lana Date: 2012-12-16 22:09 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f959e0cc8766 Merge ! makefiles/CompileNativeLibraries.gmk - src/share/classes/sun/awt/TextureSizeConstraining.java From alexey.utkin at oracle.com Mon Dec 17 02:37:35 2012 From: alexey.utkin at oracle.com (alexey.utkin at oracle.com) Date: Mon, 17 Dec 2012 10:37:35 +0000 Subject: hg: jdk8/tl/jdk: 8004928: TEST_BUG: Reduce dependence of CoreLib tests from the AWT subsystem Message-ID: <20121217103804.29186471CB@hg.openjdk.java.net> Changeset: a02212de8db6 Author: uta Date: 2012-12-17 14:34 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a02212de8db6 8004928: TEST_BUG: Reduce dependence of CoreLib tests from the AWT subsystem Summary: the tests were refactored to drop AWT dependence where it was possible. Reviewed-by: alanb, mchung ! test/java/io/Serializable/resolveProxyClass/NonPublicInterface.java ! test/java/lang/Throwable/LegacyChainedExceptionSerialization.java ! test/java/lang/management/CompilationMXBean/Basic.java ! test/java/lang/reflect/Generics/Probe.java ! test/java/lang/reflect/Proxy/ClassRestrictions.java ! test/java/util/Collections/EmptyIterator.java ! test/java/util/logging/LoggingDeadlock4.java ! test/sun/tools/jrunscript/common.sh From sean.mullan at oracle.com Mon Dec 17 05:41:22 2012 From: sean.mullan at oracle.com (sean.mullan at oracle.com) Date: Mon, 17 Dec 2012 13:41:22 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20121217134217.4D9A9471D0@hg.openjdk.java.net> Changeset: e4d88a7352c6 Author: mullan Date: 2012-12-17 08:28 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e4d88a7352c6 8004234: Downgrade normative references to ${java.home}/lib/security/krb5.conf Reviewed-by: alanb, weijun ! src/share/classes/javax/security/auth/kerberos/package.html Changeset: 4a21f818ebb1 Author: mullan Date: 2012-12-17 08:30 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4a21f818ebb1 Merge - src/share/classes/sun/awt/TextureSizeConstraining.java - test/java/rmi/server/Unmarshal/checkUnmarshalOnStopThread/CheckUnmarshall.java From vicente.romero at oracle.com Mon Dec 17 07:00:36 2012 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Mon, 17 Dec 2012 15:00:36 +0000 Subject: hg: jdk8/tl/langtools: 8004814: javadoc should be able to detect default methods Message-ID: <20121217150042.25926471D1@hg.openjdk.java.net> Changeset: 02a18f209ab3 Author: vromero Date: 2012-12-17 14:54 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/02a18f209ab3 8004814: javadoc should be able to detect default methods Reviewed-by: jjg Contributed-by: maurizio.cimadamore at oracle.com ! src/share/classes/com/sun/javadoc/ClassDoc.java ! src/share/classes/com/sun/javadoc/MethodDoc.java ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java ! src/share/classes/com/sun/tools/javadoc/MethodDocImpl.java From jonathan.gibbons at oracle.com Mon Dec 17 07:47:49 2012 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Mon, 17 Dec 2012 15:47:49 +0000 Subject: hg: jdk8/tl/langtools: 8004832: Add new doclint package Message-ID: <20121217154752.7E17B471D3@hg.openjdk.java.net> Changeset: 75ab654b5cd5 Author: jjg Date: 2012-12-17 07:47 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/75ab654b5cd5 8004832: Add new doclint package Reviewed-by: mcimadamore ! make/build.properties ! src/share/classes/com/sun/source/util/DocTrees.java ! src/share/classes/com/sun/source/util/JavacTask.java ! src/share/classes/com/sun/source/util/TreePath.java + src/share/classes/com/sun/tools/doclint/Checker.java + src/share/classes/com/sun/tools/doclint/DocLint.java + src/share/classes/com/sun/tools/doclint/Entity.java + src/share/classes/com/sun/tools/doclint/Env.java + src/share/classes/com/sun/tools/doclint/HtmlTag.java + src/share/classes/com/sun/tools/doclint/Messages.java + src/share/classes/com/sun/tools/doclint/resources/doclint.properties ! src/share/classes/com/sun/tools/javac/api/BasicJavacTask.java ! src/share/classes/com/sun/tools/javac/api/JavacTaskImpl.java ! src/share/classes/com/sun/tools/javac/api/JavacTrees.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/model/JavacTypes.java ! src/share/classes/com/sun/tools/javac/parser/DocCommentParser.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/tree/DCTree.java ! src/share/classes/com/sun/tools/javac/tree/DocPretty.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java + test/tools/doclint/AccessTest.java + test/tools/doclint/AccessTest.package.out + test/tools/doclint/AccessTest.private.out + test/tools/doclint/AccessTest.protected.out + test/tools/doclint/AccessTest.public.out + test/tools/doclint/AccessibilityTest.java + test/tools/doclint/AccessibilityTest.out + test/tools/doclint/DocLintTester.java + test/tools/doclint/EmptyAuthorTest.java + test/tools/doclint/EmptyAuthorTest.out + test/tools/doclint/EmptyExceptionTest.java + test/tools/doclint/EmptyExceptionTest.out + test/tools/doclint/EmptyParamTest.java + test/tools/doclint/EmptyParamTest.out + test/tools/doclint/EmptyReturnTest.java + test/tools/doclint/EmptyReturnTest.out + test/tools/doclint/EmptySerialDataTest.java + test/tools/doclint/EmptySerialDataTest.out + test/tools/doclint/EmptySerialFieldTest.java + test/tools/doclint/EmptySerialFieldTest.out + test/tools/doclint/EmptySinceTest.java + test/tools/doclint/EmptySinceTest.out + test/tools/doclint/EmptyVersionTest.java + test/tools/doclint/EmptyVersionTest.out + test/tools/doclint/HtmlAttrsTest.java + test/tools/doclint/HtmlAttrsTest.out + test/tools/doclint/HtmlTagsTest.java + test/tools/doclint/HtmlTagsTest.out + test/tools/doclint/MissingCommentTest.java + test/tools/doclint/MissingCommentTest.out + test/tools/doclint/MissingParamsTest.java + test/tools/doclint/MissingParamsTest.out + test/tools/doclint/MissingReturnTest.java + test/tools/doclint/MissingReturnTest.out + test/tools/doclint/MissingThrowsTest.java + test/tools/doclint/MissingThrowsTest.out + test/tools/doclint/OptionTest.java + test/tools/doclint/OverridesTest.java + test/tools/doclint/ReferenceTest.java + test/tools/doclint/ReferenceTest.out + test/tools/doclint/RunTest.java + test/tools/doclint/SyntaxTest.java + test/tools/doclint/SyntaxTest.out + test/tools/doclint/SyntheticTest.java + test/tools/doclint/ValidTest.java + test/tools/doclint/tidy/AnchorAlreadyDefined.java + test/tools/doclint/tidy/AnchorAlreadyDefined.out + test/tools/doclint/tidy/BadEnd.java + test/tools/doclint/tidy/BadEnd.out + test/tools/doclint/tidy/InsertImplicit.java + test/tools/doclint/tidy/InsertImplicit.out + test/tools/doclint/tidy/InvalidEntity.java + test/tools/doclint/tidy/InvalidEntity.out + test/tools/doclint/tidy/InvalidName.java + test/tools/doclint/tidy/InvalidName.out + test/tools/doclint/tidy/InvalidTag.java + test/tools/doclint/tidy/InvalidTag.out + test/tools/doclint/tidy/InvalidURI.java + test/tools/doclint/tidy/InvalidURI.out + test/tools/doclint/tidy/MissingGT.java + test/tools/doclint/tidy/MissingGT.out + test/tools/doclint/tidy/MissingTag.java + test/tools/doclint/tidy/MissingTag.out + test/tools/doclint/tidy/NestedTag.java + test/tools/doclint/tidy/NestedTag.out + test/tools/doclint/tidy/ParaInPre.java + test/tools/doclint/tidy/ParaInPre.out + test/tools/doclint/tidy/README.txt + test/tools/doclint/tidy/RepeatedAttr.java + test/tools/doclint/tidy/RepeatedAttr.out + test/tools/doclint/tidy/TextNotAllowed.java + test/tools/doclint/tidy/TextNotAllowed.out + test/tools/doclint/tidy/TrimmingEmptyTag.java + test/tools/doclint/tidy/TrimmingEmptyTag.out + test/tools/doclint/tidy/UnescapedOrUnknownEntity.java + test/tools/doclint/tidy/UnescapedOrUnknownEntity.out + test/tools/doclint/tidy/util/Main.java + test/tools/doclint/tidy/util/tidy.sh + test/tools/javac/diags/examples/NoContent.java From maurizio.cimadamore at oracle.com Mon Dec 17 08:27:55 2012 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Mon, 17 Dec 2012 16:27:55 +0000 Subject: hg: jdk8/tl/langtools: 8004099: Bad compiler diagnostic generated when poly expression is passed to non-existent method Message-ID: <20121217162759.0D394471D5@hg.openjdk.java.net> Changeset: f20568328a57 Author: mcimadamore Date: 2012-12-17 16:13 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f20568328a57 8004099: Bad compiler diagnostic generated when poly expression is passed to non-existent method Summary: Some code paths in resolve do not use methodArguments to correctly format actuals Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java + test/tools/javac/lambda/BadMethodCall2.java + test/tools/javac/lambda/BadMethodCall2.out From chris.hegarty at oracle.com Mon Dec 17 08:28:02 2012 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Mon, 17 Dec 2012 16:28:02 +0000 Subject: hg: jdk8/tl/jdk: 8005081: java/util/prefs/PrefsSpi.sh fails on macos-x Message-ID: <20121217162814.AD0D8471D6@hg.openjdk.java.net> Changeset: bcf79e6f52a0 Author: chegar Date: 2012-12-17 16:27 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bcf79e6f52a0 8005081: java/util/prefs/PrefsSpi.sh fails on macos-x Reviewed-by: alanb ! test/java/util/prefs/PrefsSpi.sh From jonathan.gibbons at oracle.com Mon Dec 17 08:34:25 2012 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Mon, 17 Dec 2012 16:34:25 +0000 Subject: hg: jdk8/tl: 8005090: Include com.sun.source.doctree in Tree API docs Message-ID: <20121217163426.233EF471D8@hg.openjdk.java.net> Changeset: a0779b1e9a4d Author: jjg Date: 2012-12-17 08:34 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/a0779b1e9a4d 8005090: Include com.sun.source.doctree in Tree API docs Reviewed-by: erikj ! common/makefiles/javadoc/NON_CORE_PKGS.gmk From jonathan.gibbons at oracle.com Mon Dec 17 08:34:56 2012 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Mon, 17 Dec 2012 16:34:56 +0000 Subject: hg: jdk8/tl/jdk: 8005090: Include com.sun.source.doctree in Tree API docs Message-ID: <20121217163508.2BB34471D9@hg.openjdk.java.net> Changeset: 9f1b516cd9cb Author: jjg Date: 2012-12-17 08:34 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9f1b516cd9cb 8005090: Include com.sun.source.doctree in Tree API docs Reviewed-by: erikj ! make/docs/NON_CORE_PKGS.gmk From jonathan.gibbons at oracle.com Mon Dec 17 10:32:04 2012 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Mon, 17 Dec 2012 18:32:04 +0000 Subject: hg: jdk8/tl/jdk: 8004832: Add new doclint package Message-ID: <20121217183215.6557E471E6@hg.openjdk.java.net> Changeset: bac477d67867 Author: jjg Date: 2012-12-17 10:31 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bac477d67867 8004832: Add new doclint package Reviewed-by: erikj, ohair ! make/common/Release.gmk ! make/common/internal/Defs-langtools.gmk ! makefiles/CreateJars.gmk From jonathan.gibbons at oracle.com Mon Dec 17 10:56:12 2012 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Mon, 17 Dec 2012 18:56:12 +0000 Subject: hg: jdk8/tl/langtools: 8004961: rename Plugin.call to Plugin.init Message-ID: <20121217185615.4331E471ED@hg.openjdk.java.net> Changeset: 064e372f273d Author: jjg Date: 2012-12-17 10:55 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/064e372f273d 8004961: rename Plugin.call to Plugin.init Reviewed-by: mcimadamore ! src/share/classes/com/sun/source/util/Plugin.java ! src/share/classes/com/sun/tools/javac/main/Main.java ! test/tools/javac/plugin/showtype/ShowTypePlugin.java ! test/tools/javac/plugin/showtype/Test.java From eric.mccorkle at oracle.com Mon Dec 17 11:20:33 2012 From: eric.mccorkle at oracle.com (Eric McCorkle) Date: Mon, 17 Dec 2012 14:20:33 -0500 Subject: Review request for JDK-8004727 Message-ID: <50CF7081.6040406@oracle.com> Hello, Please review the implementation of the javac side of method parameter reflection. The feature request can be found here: http://bugs.sun.com/view_bug.do?bug_id=8004727 Summary: The names, as well as other information about method parameters can now optionally be stored in Java class files. There are updates to javac to create the parameter attributes when a -parameters flag is given. There are also updates to the com.sun.tools.classfile API to correctly parse method parameter attributes, and to javap to print them. This code includes new tests, and has been tested by running numerous regression test suites, including some with javac hardwired to generate class files with parameter annotations. The open webrev can be found here: http://cr.openjdk.java.net/~coleenp/JDK-8004727/ The specification for Method Parameter reflection can be found here: http://cr.openjdk.java.net/~abuckley/8misc.pdf Thanks, Eric -------------- next part -------------- A non-text attachment was scrubbed... Name: eric_mccorkle.vcf Type: text/x-vcard Size: 303 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20121217/ced0616c/eric_mccorkle.vcf From jonathan.gibbons at oracle.com Mon Dec 17 12:19:27 2012 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Mon, 17 Dec 2012 12:19:27 -0800 Subject: Review request for JDK-8004727 In-Reply-To: <50CF7081.6040406@oracle.com> References: <50CF7081.6040406@oracle.com> Message-ID: <50CF7E4F.503@oracle.com> jvm/ClassReader:122 sawMethodParameters is not a switch, which is a configuration parameter, and should not be grouped with them. It is just boolean state that is set while reading the classfile. jvm/ClassWriter:724 The method only writes at most one attribute, so the method name should not be plural. On the other hand, it could write more than one parameter name, so how about writeParameterNamesAttr, or better, writeMethodParametersAttr Option You need to file a CCC and make this option public; this should not be a hidden option -- Jon On 12/17/2012 11:20 AM, Eric McCorkle wrote: > Hello, > > Please review the implementation of the javac side of method parameter > reflection. The feature request can be found here: > > http://bugs.sun.com/view_bug.do?bug_id=8004727 > > Summary: > > The names, as well as other information about method parameters can now > optionally be stored in Java class files. There are updates to javac to > create the parameter attributes when a -parameters flag is given. There > are also updates to the com.sun.tools.classfile API to correctly parse > method parameter attributes, and to javap to print them. > > This code includes new tests, and has been tested by running numerous > regression test suites, including some with javac hardwired to generate > class files with parameter annotations. > > > The open webrev can be found here: > > http://cr.openjdk.java.net/~coleenp/JDK-8004727/ > > > The specification for Method Parameter reflection can be found here: > > http://cr.openjdk.java.net/~abuckley/8misc.pdf > > Thanks, > Eric From mandy.chung at oracle.com Mon Dec 17 14:48:55 2012 From: mandy.chung at oracle.com (Mandy Chung) Date: Mon, 17 Dec 2012 14:48:55 -0800 Subject: Review request 1-line change to fix langtools build failure Message-ID: <50CFA157.1070105@oracle.com> langtools build fails because of the rename of Plugin.call method [1]. Can I get someone to review this 1-line fix? Thanks Mandy diff --git a/src/share/classes/com/sun/tools/doclint/DocLint.java b/src/share/classes/com/sun/tools/doclint/DocLint.java --- a/src/share/classes/com/sun/tools/doclint/DocLint.java +++ b/src/share/classes/com/sun/tools/doclint/DocLint.java @@ -271,7 +271,7 @@ } @Override - public void call(JavacTask task, String... args) { + public void init(JavacTask task, String... args) { init(task, args, true); } [1] http://hg.openjdk.java.net/jdk8/tl/langtools/rev/064e372f273d From james.holmlund at oracle.com Mon Dec 17 15:12:39 2012 From: james.holmlund at oracle.com (Jim Holmlund) Date: Mon, 17 Dec 2012 15:12:39 -0800 Subject: Review request 1-line change to fix langtools build failure In-Reply-To: <50CFA157.1070105@oracle.com> References: <50CFA157.1070105@oracle.com> Message-ID: <50CFA6E7.7040403@oracle.com> approved - jjh On 12/17/2012 2:48 PM, Mandy Chung wrote: > langtools build fails because of the rename of Plugin.call method [1]. Can I get someone to review > this 1-line fix? > > Thanks > Mandy > > > diff --git a/src/share/classes/com/sun/tools/doclint/DocLint.java > b/src/share/classes/com/sun/tools/doclint/DocLint.java > --- a/src/share/classes/com/sun/tools/doclint/DocLint.java > +++ b/src/share/classes/com/sun/tools/doclint/DocLint.java > @@ -271,7 +271,7 @@ > } > > @Override > - public void call(JavacTask task, String... args) { > + public void init(JavacTask task, String... args) { > init(task, args, true); > } > > [1] http://hg.openjdk.java.net/jdk8/tl/langtools/rev/064e372f273d From joe.darcy at oracle.com Mon Dec 17 15:20:19 2012 From: joe.darcy at oracle.com (Joe Darcy) Date: Mon, 17 Dec 2012 15:20:19 -0800 Subject: Review request 1-line change to fix langtools build failure In-Reply-To: <50CFA157.1070105@oracle.com> References: <50CFA157.1070105@oracle.com> Message-ID: <50CFA8B3.3080507@oracle.com> Approved; thanks Mandy, -Joe On 12/17/2012 02:48 PM, Mandy Chung wrote: > langtools build fails because of the rename of Plugin.call method [1]. > Can I get someone to review this 1-line fix? > > Thanks > Mandy > > > diff --git a/src/share/classes/com/sun/tools/doclint/DocLint.java > b/src/share/classes/com/sun/tools/doclint/DocLint.java > --- a/src/share/classes/com/sun/tools/doclint/DocLint.java > +++ b/src/share/classes/com/sun/tools/doclint/DocLint.java > @@ -271,7 +271,7 @@ > } > > @Override > - public void call(JavacTask task, String... args) { > + public void init(JavacTask task, String... args) { > init(task, args, true); > } > > [1] http://hg.openjdk.java.net/jdk8/tl/langtools/rev/064e372f273d From mandy.chung at oracle.com Mon Dec 17 15:21:32 2012 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Mon, 17 Dec 2012 23:21:32 +0000 Subject: hg: jdk8/tl/langtools: 8005137: Rename DocLint.call to DocLint.init which overrides Plugin.init Message-ID: <20121217232134.BBA01471FA@hg.openjdk.java.net> Changeset: ef537bcc825a Author: mchung Date: 2012-12-17 15:19 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ef537bcc825a 8005137: Rename DocLint.call to DocLint.init which overrides Plugin.init Reviewed-by: darcy, jjh ! src/share/classes/com/sun/tools/doclint/DocLint.java From eric.mccorkle at oracle.com Mon Dec 17 17:56:34 2012 From: eric.mccorkle at oracle.com (Eric McCorkle) Date: Mon, 17 Dec 2012 20:56:34 -0500 Subject: Review request for JDK-8004727 In-Reply-To: <50CF7E4F.503@oracle.com> References: <50CF7081.6040406@oracle.com> <50CF7E4F.503@oracle.com> Message-ID: <50CFCD52.8060704@oracle.com> Thanks, Jon. I've applied the changes you suggested, and I'm putting in a CCC to add the parameter flag. On 12/17/12 15:19, Jonathan Gibbons wrote: > jvm/ClassReader:122 > sawMethodParameters is not a switch, which is a configuration parameter, > and should not be grouped with them. It is just boolean state that is > set while reading the classfile. > > jvm/ClassWriter:724 > The method only writes at most one attribute, so the method name should > not be plural. On the other hand, it could write more than one > parameter name, so how about writeParameterNamesAttr, or better, > writeMethodParametersAttr > > Option > You need to file a CCC and make this option public; this should not be a > hidden option > > -- Jon > > On 12/17/2012 11:20 AM, Eric McCorkle wrote: >> Hello, >> >> Please review the implementation of the javac side of method parameter >> reflection. The feature request can be found here: >> >> http://bugs.sun.com/view_bug.do?bug_id=8004727 >> >> Summary: >> >> The names, as well as other information about method parameters can now >> optionally be stored in Java class files. There are updates to javac to >> create the parameter attributes when a -parameters flag is given. There >> are also updates to the com.sun.tools.classfile API to correctly parse >> method parameter attributes, and to javap to print them. >> >> This code includes new tests, and has been tested by running numerous >> regression test suites, including some with javac hardwired to generate >> class files with parameter annotations. >> >> >> The open webrev can be found here: >> >> http://cr.openjdk.java.net/~coleenp/JDK-8004727/ >> >> >> The specification for Method Parameter reflection can be found here: >> >> http://cr.openjdk.java.net/~abuckley/8misc.pdf >> >> Thanks, >> Eric > -------------- next part -------------- A non-text attachment was scrubbed... Name: eric_mccorkle.vcf Type: text/x-vcard Size: 314 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20121217/bfb64db5/eric_mccorkle.vcf From joe.darcy at oracle.com Tue Dec 18 00:25:42 2012 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Tue, 18 Dec 2012 08:25:42 +0000 Subject: hg: jdk8/tl/langtools: 8005046: Provide checking for a default method in javax.lang.model Message-ID: <20121218082544.95F7B47209@hg.openjdk.java.net> Changeset: bc74006c2d8d Author: darcy Date: 2012-12-18 00:24 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/bc74006c2d8d 8005046: Provide checking for a default method in javax.lang.model Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/javax/lang/model/element/ExecutableElement.java + test/tools/javac/processing/model/element/TestExecutableElement.java From fredrik.ohrstrom at oracle.com Tue Dec 18 01:29:51 2012 From: fredrik.ohrstrom at oracle.com (fredrik.ohrstrom at oracle.com) Date: Tue, 18 Dec 2012 09:29:51 +0000 Subject: hg: jdk8/tl/langtools: 8004657: Add hooks to javac to enable reporting dependency information. Message-ID: <20121218092954.2CEDB47212@hg.openjdk.java.net> Changeset: 92fcf299cd09 Author: ohrstrom Date: 2012-12-18 10:23 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/92fcf299cd09 8004657: Add hooks to javac to enable reporting dependency information. Reviewed-by: jjg, mcimadamore ! src/share/classes/com/sun/tools/javac/api/JavacTool.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java From maurizio.cimadamore at oracle.com Tue Dec 18 03:11:17 2012 From: maurizio.cimadamore at oracle.com (Maurizio Cimadamore) Date: Tue, 18 Dec 2012 11:11:17 +0000 Subject: Review request for JDK-8004727 In-Reply-To: <50CFCD52.8060704@oracle.com> References: <50CF7081.6040406@oracle.com> <50CF7E4F.503@oracle.com> <50CFCD52.8060704@oracle.com> Message-ID: <50D04F55.3000209@oracle.com> Looks good; minor nit: order of imports in the test. Maurizio On 18/12/12 01:56, Eric McCorkle wrote: > Thanks, Jon. I've applied the changes you suggested, and I'm putting in > a CCC to add the parameter flag. > > On 12/17/12 15:19, Jonathan Gibbons wrote: >> jvm/ClassReader:122 >> sawMethodParameters is not a switch, which is a configuration parameter, >> and should not be grouped with them. It is just boolean state that is >> set while reading the classfile. >> >> jvm/ClassWriter:724 >> The method only writes at most one attribute, so the method name should >> not be plural. On the other hand, it could write more than one >> parameter name, so how about writeParameterNamesAttr, or better, >> writeMethodParametersAttr >> >> Option >> You need to file a CCC and make this option public; this should not be a >> hidden option >> >> -- Jon >> >> On 12/17/2012 11:20 AM, Eric McCorkle wrote: >>> Hello, >>> >>> Please review the implementation of the javac side of method parameter >>> reflection. The feature request can be found here: >>> >>> http://bugs.sun.com/view_bug.do?bug_id=8004727 >>> >>> Summary: >>> >>> The names, as well as other information about method parameters can now >>> optionally be stored in Java class files. There are updates to javac to >>> create the parameter attributes when a -parameters flag is given. There >>> are also updates to the com.sun.tools.classfile API to correctly parse >>> method parameter attributes, and to javap to print them. >>> >>> This code includes new tests, and has been tested by running numerous >>> regression test suites, including some with javac hardwired to generate >>> class files with parameter annotations. >>> >>> >>> The open webrev can be found here: >>> >>> http://cr.openjdk.java.net/~coleenp/JDK-8004727/ >>> >>> >>> The specification for Method Parameter reflection can be found here: >>> >>> http://cr.openjdk.java.net/~abuckley/8misc.pdf >>> >>> Thanks, >>> Eric From Ulf.Zibis at CoSoCo.de Tue Dec 18 09:06:14 2012 From: Ulf.Zibis at CoSoCo.de (Ulf Zibis) Date: Tue, 18 Dec 2012 18:06:14 +0100 Subject: Review request: 8003562: Provide a command-line tool to find static dependencies In-Reply-To: <50CFEDFC.5060903@oracle.com> References: <50B54A2C.1040907@oracle.com> <50BFF69E.1040805@oracle.com> <50C265D8.3050107@oracle.com> <50C5B9B2.2050705@oracle.com> <50CA6DA1.1070004@oracle.com> <50CA8BB1.1030502@oracle.com> <50CB03D1.5030400@CoSoCo.de> <50CB33FE.7000605@CoSoCo.de> <50CB9CF5.4090300@oracle.com> <50CBC7D0.9050103@CoSoCo.de> <50CBD110.1080208@oracle.com> <50CBD2BF.90100@oracle.com> <50CF38F2.6040707@oracle.com> <50CF44A7.8000202@CoSoCo.de> <50CFEDFC.5060903@oracle.com> Message-ID: <50D0A286.3040309@CoSoCo.de> Am 18.12.2012 05:15, schrieb Mandy Chung: > On 12/17/12 8:13 AM, Ulf Zibis wrote: >> Am 17.12.2012 16:23, schrieb Alan Bateman: >>> I mostly agree with your argument that this is a new tool and that we should be consistent with >>> GNU-style options. So what was the final bid is, is it --classpath or --class-path? > > I propose --class-path so that it makes it easier to determine -classpath is not supported I have some objections against --class-path and vote for --classpath. Reasons: - -classpath is easier to type in - -classpath matches better with environment variable CLASSPATH - I'm not sure if the term "classpath" is really wrong in english grammar. Looking into the docs, term "classpath" is in use, but less than "class path": http://docs.oracle.com/javase/6/docs/technotes/tools/windows/javac.html http://docs.oracle.com/javase/7/docs/technotes/tools/windows/java.html http://docs.oracle.com/javase/7/docs/technotes/tools/windows/classpath.html - people are familiar with "classpath" - there are similar options/terms that then also need to be changed, if some day we would adopt all other existing tools to GNU-style. E.g. --boot-class-path IMO looks bad and could semantically be interpreted as "boot the class path" or "path of the boot class". - the '-' separator usage in GNU commands and options I only know, where a verb has to be separated from a subject, e.g. "update-grub", but maybe there are contradictory examples. ...And there are examples, where even verbs are not separated from subjects, e.g. "grub-mkconfig", which should be "grub-mk-config" according the rule. What about allowing (maybe define for preferred usage) GNU/UNIX path separators even on Windows? E.g. java --classpath=C/java/jre6/lib/rt.jar ... - This would make java again more platform independent. - The mixure of UNIX and/or GNU-style options with Windows path syntax looks ugly to me. Additionally we also have a 3rd style in use, e.g. "java mypackage.MyClass". >>> I guess it wouldn't do any harm to silently supporting -cp and -classpath as folks used to java* >>> tools will probably use them without thinking. >> > How important to carry the same option -cp and -classpath on j* tools? I do think developers can > well adapt to a slight different option when using a new tool. I'm inclined not to mix these > styles. In addition, I'd like to see how jdeps will be used after the initial push and people > finds --class-path hard to move to. My vote: silently support old style with space as separator and document this as a side note on: http://docs.oracle.com/javase/6/docs/technotes/tools/windows/jdeps.html > >> Thanks for supporting my arguments about "silent familarity" to old style, Alan. >> As --class(-)path is a frequent and important option, I additionally think, we should have an >> official short form. If '-cp' doesn't conform with GNU-style, what about '-C' ? > > I considered '-C' and it might be confused with 'jar -C' and 'tar -C' option to change the > directory. I think '-c' may be okay and it can avoid such confusion and closer to '-cp'. Are > you okay with that? I agree! "-C" was from my non-reflected guess, that '-c' would be yet occupied, as you didn't consider a short form from the beginning. Thanks for your closer look. -Ulf From kumar.x.srinivasan at oracle.com Tue Dec 18 10:02:28 2012 From: kumar.x.srinivasan at oracle.com (Kumar Srinivasan) Date: Tue, 18 Dec 2012 10:02:28 -0800 Subject: Review request for JDK-8004727 In-Reply-To: <50CF7081.6040406@oracle.com> References: <50CF7081.6040406@oracle.com> Message-ID: <50D0AFB4.2020608@oracle.com> Looks good! minor nits, Copyright incorrect in: Attribute.java, ClassWriter.java and others..... ClassWriter.java + } + else + return 0; other places in the file the convention is } else return 0; Kumar > Hello, > > Please review the implementation of the javac side of method parameter > reflection. The feature request can be found here: > > http://bugs.sun.com/view_bug.do?bug_id=8004727 > > Summary: > > The names, as well as other information about method parameters can now > optionally be stored in Java class files. There are updates to javac to > create the parameter attributes when a -parameters flag is given. There > are also updates to the com.sun.tools.classfile API to correctly parse > method parameter attributes, and to javap to print them. > > This code includes new tests, and has been tested by running numerous > regression test suites, including some with javac hardwired to generate > class files with parameter annotations. > > > The open webrev can be found here: > > http://cr.openjdk.java.net/~coleenp/JDK-8004727/ > > > The specification for Method Parameter reflection can be found here: > > http://cr.openjdk.java.net/~abuckley/8misc.pdf > > Thanks, > Eric From martinrb at google.com Tue Dec 18 10:04:25 2012 From: martinrb at google.com (martinrb at google.com) Date: Tue, 18 Dec 2012 18:04:25 +0000 Subject: hg: jdk8/tl/jdk: 8004863: Infinite Loop in KeepAliveStream Message-ID: <20121218180436.864A647228@hg.openjdk.java.net> Changeset: 0fabdf676395 Author: martin Date: 2012-12-17 18:39 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0fabdf676395 8004863: Infinite Loop in KeepAliveStream Reviewed-by: chegar ! src/share/classes/sun/net/www/http/KeepAliveStream.java + test/sun/net/www/http/KeepAliveStream/InfiniteLoop.java From mandy.chung at oracle.com Tue Dec 18 11:38:58 2012 From: mandy.chung at oracle.com (Mandy Chung) Date: Tue, 18 Dec 2012 11:38:58 -0800 Subject: Review request: 8003562: Provide a command-line tool to find static dependencies In-Reply-To: <50D0A286.3040309@CoSoCo.de> References: <50B54A2C.1040907@oracle.com> <50BFF69E.1040805@oracle.com> <50C265D8.3050107@oracle.com> <50C5B9B2.2050705@oracle.com> <50CA6DA1.1070004@oracle.com> <50CA8BB1.1030502@oracle.com> <50CB03D1.5030400@CoSoCo.de> <50CB33FE.7000605@CoSoCo.de> <50CB9CF5.4090300@oracle.com> <50CBC7D0.9050103@CoSoCo.de> <50CBD110.1080208@oracle.com> <50CBD2BF.90100@oracle.com> <50CF38F2.6040707@oracle.com> <50CF44A7.8000202@CoSoCo.de> <50CFEDFC.5060903@oracle.com> <50D0A286.3040309@CoSoCo.de> Message-ID: <50D0C652.3080500@oracle.com> On 12/18/12 9:06 AM, Ulf Zibis wrote: > Am 18.12.2012 05:15, schrieb Mandy Chung: >> On 12/17/12 8:13 AM, Ulf Zibis wrote: >>> Am 17.12.2012 16:23, schrieb Alan Bateman: >>>> I mostly agree with your argument that this is a new tool and that >>>> we should be consistent with GNU-style options. So what was the >>>> final bid is, is it --classpath or --class-path? >> >> I propose --class-path so that it makes it easier to determine >> -classpath is not supported > > I have some objections against --class-path and vote for --classpath. I'm happy with "--classpath" and "-c" is the short form. > .... > > What about allowing (maybe define for preferred usage) GNU/UNIX path > separators even on Windows? E.g. > java --classpath=C/java/jre6/lib/rt.jar ... > - This would make java again more platform independent. > - The mixure of UNIX and/or GNU-style options with Windows path syntax > looks ugly to me. > I don't like dealing with Windows paths either. One use case we expect that one may take the -classpath option that may have a long list of paths from the script for launching the application and pass it to jdeps. That means jdeps would have to support both Windows paths as well as Unix paths. It's a reasonable enhancement that we can consider later. I'd really like to get this out in the next few days. > Additionally we also have a 3rd style in use, e.g. "java > mypackage.MyClass". > > >>>> I guess it wouldn't do any harm to silently supporting -cp and >>>> -classpath as folks used to java* tools will probably use them >>>> without thinking. >>> >> How important to carry the same option -cp and -classpath on j* >> tools? I do think developers can well adapt to a slight different >> option when using a new tool. I'm inclined not to mix these styles. >> In addition, I'd like to see how jdeps will be used after the initial >> push and people finds --class-path hard to move to. > > My vote: > silently support old style with space as separator and document this > as a side note on: > http://docs.oracle.com/javase/6/docs/technotes/tools/windows/jdeps.html > You meant http://docs.oracle.com/javase/8/docs/technotes/tools/windows/jdeps.html :-) We have an agreement on --classpath. It's helpful to get developers to play with jdeps and we can then improve it once we get feedback. I'll leave the old style options out in this patch as I'm inclined not to support both old style and GNU-style. >> >>> Thanks for supporting my arguments about "silent familarity" to old >>> style, Alan. >>> As --class(-)path is a frequent and important option, I additionally >>> think, we should have an official short form. If '-cp' doesn't >>> conform with GNU-style, what about '-C' ? >> >> I considered '-C' and it might be confused with 'jar -C' and 'tar -C' >> option to change the directory. I think '-c' may be okay and it can >> avoid such confusion and closer to '-cp'. Are you okay with that? > > I agree! "-C" was from my non-reflected guess, that '-c' would be yet > occupied, as you didn't consider a short form from the beginning. > Thanks for your closer look. > I missed to mention the short form in my previous reply but I did consider it :) Thanks for all the feedback. Really appreciated. Mandy From maurizio.cimadamore at oracle.com Tue Dec 18 14:17:22 2012 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Tue, 18 Dec 2012 22:17:22 +0000 Subject: hg: jdk8/tl/langtools: 8005193: New regression test test/tools/javac/lambda/BadMethodCall2.java fails Message-ID: <20121218221725.5F42E47235@hg.openjdk.java.net> Changeset: 250f0acf880c Author: mcimadamore Date: 2012-12-18 22:16 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/250f0acf880c 8005193: New regression test test/tools/javac/lambda/BadMethodCall2.java fails Summary: Bad golden file in negative test Reviewed-by: jjh ! test/tools/javac/lambda/BadMethodCall2.out From joe.darcy at oracle.com Tue Dec 18 14:44:43 2012 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Tue, 18 Dec 2012 22:44:43 +0000 Subject: hg: jdk8/tl/jdk: 8005042: Add Method.isDefault to core reflection Message-ID: <20121218224503.D996C47238@hg.openjdk.java.net> Changeset: 0a1398021c7c Author: darcy Date: 2012-12-18 14:44 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0a1398021c7c 8005042: Add Method.isDefault to core reflection Reviewed-by: alanb, forax, mduigou, jgish, mchung ! src/share/classes/java/lang/reflect/Method.java + test/java/lang/reflect/Method/IsDefaultTest.java From joe.darcy at oracle.com Tue Dec 18 14:50:26 2012 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Tue, 18 Dec 2012 22:50:26 +0000 Subject: hg: jdk8/tl/jdk: 8004699: Add type annotation storage to Constructor, Field and Method Message-ID: <20121218225038.108464723B@hg.openjdk.java.net> Changeset: 6d977f61af5e Author: darcy Date: 2012-12-18 14:49 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6d977f61af5e 8004699: Add type annotation storage to Constructor, Field and Method Reviewed-by: darcy, dholmes Contributed-by: joel.franck at oracle.com ! src/share/classes/java/lang/reflect/Constructor.java ! src/share/classes/java/lang/reflect/Field.java ! src/share/classes/java/lang/reflect/Method.java From mandy.chung at oracle.com Tue Dec 18 15:12:39 2012 From: mandy.chung at oracle.com (Mandy Chung) Date: Tue, 18 Dec 2012 15:12:39 -0800 Subject: Review request: 8003562: Provide a command-line tool to find static dependencies In-Reply-To: <50D0C652.3080500@oracle.com> References: <50B54A2C.1040907@oracle.com> <50BFF69E.1040805@oracle.com> <50C265D8.3050107@oracle.com> <50C5B9B2.2050705@oracle.com> <50CA6DA1.1070004@oracle.com> <50CA8BB1.1030502@oracle.com> <50CB03D1.5030400@CoSoCo.de> <50CB33FE.7000605@CoSoCo.de> <50CB9CF5.4090300@oracle.com> <50CBC7D0.9050103@CoSoCo.de> <50CBD110.1080208@oracle.com> <50CBD2BF.90100@oracle.com> <50CF38F2.6040707@oracle.com> <50CF44A7.8000202@CoSoCo.de> <50CFEDFC.5060903@oracle.com> <50D0A286.3040309@CoSoCo.de> <50D0C652.3080500@oracle.com> Message-ID: <50D0F867.80100@oracle.com> Alan, Ulf, I updated the jdeps CLI per the discussion we had. $ jdeps --help Usage: jdeps where can be a pathname to a .class file, a directory, a JAR file, or a fully-qualified classname or wildcard "*". Possible options include: -s --summary Print dependency summary only -v --verbose Print additional information -V --verbose-level= Print package-level or class-level dependencies Valid levels are: "package" and "class" -c --classpath= Specify where to find class files -p --package= Restrict analysis to classes in this package (may be given multiple times) -e --regex= Restrict analysis to packages matching pattern (-p and -e are exclusive) -P --profile Show profile or the file containing a package -R --recursive Recursively traverse all dependencies --version Version information Updated webrev: http://cr.openjdk.java.net/~mchung/jdk8/webrevs/jdeps/webrev.06/ jdeps only support GNU-style options. I added java.util.function and com.sun.source.doctree in the jdk.properties. I'll replace it to use the proper javac API to work with profiles next. I caught a typo 'com.sunsource.doctree' (missing dot) in NON_CORE_PKGS.gmk and I fix that in this patch. We can enhance the tool after the initial push. I'd like to get it in jdk8 soon so that developers can try it out and give feedback. Thanks Mandy From lana.steuck at oracle.com Tue Dec 18 19:17:21 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 19 Dec 2012 03:17:21 +0000 Subject: hg: jdk8/tl: 2 new changesets Message-ID: <20121219031722.0C8BC47258@hg.openjdk.java.net> Changeset: e08b0096058f Author: lana Date: 2012-12-14 11:22 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/e08b0096058f Merge Changeset: 68a81db3ceb1 Author: lana Date: 2012-12-18 17:42 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/68a81db3ceb1 Merge From lana.steuck at oracle.com Tue Dec 18 19:17:31 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 19 Dec 2012 03:17:31 +0000 Subject: hg: jdk8/tl/langtools: 2 new changesets Message-ID: <20121219031740.E4E3547259@hg.openjdk.java.net> Changeset: d7360bf35ee1 Author: lana Date: 2012-12-14 13:15 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d7360bf35ee1 Merge Changeset: 573b38691a74 Author: lana Date: 2012-12-18 18:15 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/573b38691a74 Merge From lana.steuck at oracle.com Tue Dec 18 19:17:59 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 19 Dec 2012 03:17:59 +0000 Subject: hg: jdk8/tl/jdk: 8 new changesets Message-ID: <20121219032112.8E53F4725C@hg.openjdk.java.net> Changeset: e8b54ae97344 Author: jviswana Date: 2012-12-12 13:28 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e8b54ae97344 8004316: Printer - tempfile having incorrect extension Reviewed-by: bae, jgodinez ! src/solaris/classes/sun/print/UnixPrintJob.java Changeset: fd9e6b4c8488 Author: lana Date: 2012-12-14 11:21 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fd9e6b4c8488 Merge Changeset: c69424f78060 Author: serb Date: 2012-12-11 19:45 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c69424f78060 7154778: [macosx] NSView-based implementation of sun.awt.EmbeddedFrame Summary: The new implementation of EmbeddedFrame to support SWT_AWT Bridge Reviewed-by: anthony, serb, leonidr Contributed-by: Petr Pchelko ! src/macosx/classes/sun/lwawt/LWToolkit.java ! src/macosx/classes/sun/lwawt/LWWindowPeer.java ! src/macosx/classes/sun/lwawt/PlatformWindow.java ! src/macosx/classes/sun/lwawt/macosx/CMouseInfoPeer.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformEmbeddedFrame.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformView.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/macosx/classes/sun/lwawt/macosx/CPrinterDialogPeer.java + src/macosx/classes/sun/lwawt/macosx/CViewEmbeddedFrame.java + src/macosx/classes/sun/lwawt/macosx/CViewPlatformEmbeddedFrame.java ! src/macosx/classes/sun/lwawt/macosx/CWrapper.java ! src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java ! src/macosx/native/sun/awt/AWTSurfaceLayers.m ! src/macosx/native/sun/awt/AWTView.m ! src/macosx/native/sun/awt/AWTWindow.m ! src/macosx/native/sun/awt/CCursorManager.m ! src/macosx/native/sun/awt/CWrapper.m ! src/macosx/native/sun/awt/awt.m ! src/macosx/native/sun/java2d/opengl/CGLLayer.m ! src/macosx/native/sun/osxapp/ThreadUtilities.h ! src/macosx/native/sun/osxapp/ThreadUtilities.m Changeset: e016ad35a764 Author: kshefov Date: 2012-12-13 15:14 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e016ad35a764 7132385: [macosx] IconifyTest of RepaintManager could use some delay Reviewed-by: serb, alexsch + test/javax/swing/RepaintManager/IconifyTest/IconifyTest.java Changeset: 71e03e17c183 Author: kshefov Date: 2012-12-14 13:32 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/71e03e17c183 6757986: javax/swing/JInternalFrame/5066752/bug5066752.java needs correction Reviewed-by: serb, alexsch + test/javax/swing/JInternalFrame/5066752/bug5066752.java Changeset: 9fc7460ca3ac Author: lana Date: 2012-12-14 11:22 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9fc7460ca3ac Merge Changeset: de6b54a60d60 Author: lana Date: 2012-12-14 13:14 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/de6b54a60d60 Merge ! makefiles/CompileNativeLibraries.gmk - src/share/lib/security/java.security - test/java/rmi/server/Unmarshal/checkUnmarshalOnStopThread/CheckUnmarshall.java Changeset: e515956879cd Author: lana Date: 2012-12-18 18:14 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e515956879cd Merge From Ulf.Zibis at CoSoCo.de Tue Dec 18 19:38:11 2012 From: Ulf.Zibis at CoSoCo.de (Ulf Zibis) Date: Wed, 19 Dec 2012 04:38:11 +0100 Subject: Review request: 8003562: Provide a command-line tool to find static dependencies In-Reply-To: <50D0C652.3080500@oracle.com> References: <50B54A2C.1040907@oracle.com> <50BFF69E.1040805@oracle.com> <50C265D8.3050107@oracle.com> <50C5B9B2.2050705@oracle.com> <50CA6DA1.1070004@oracle.com> <50CA8BB1.1030502@oracle.com> <50CB03D1.5030400@CoSoCo.de> <50CB33FE.7000605@CoSoCo.de> <50CB9CF5.4090300@oracle.com> <50CBC7D0.9050103@CoSoCo.de> <50CBD110.1080208@oracle.com> <50CBD2BF.90100@oracle.com> <50CF38F2.6040707@oracle.com> <50CF44A7.8000202@CoSoCo.de> <50CFEDFC.5060903@oracle.com> <50D0A286.3040309@CoSoCo.de> <50D0C652.3080500@oracle.com> Message-ID: <50D136A3.3020909@CoSoCo.de> Am 18.12.2012 20:38, schrieb Mandy Chung: > I don't like dealing with Windows paths either. > > One use case we expect that one may take the -classpath option that may have a long list of paths > from the script for launching the application and pass it to jdeps. That means jdeps would have > to support both Windows paths as well as Unix paths. It's a reasonable enhancement that we can > consider later. I'd really like to get this out in the next few days. Yes, was just an additional thought. > You meant http://docs.oracle.com/javase/8/docs/technotes/tools/windows/jdeps.html :-) Correct :-) -Ulf From huizhe.wang at oracle.com Tue Dec 18 21:08:38 2012 From: huizhe.wang at oracle.com (huizhe.wang at oracle.com) Date: Wed, 19 Dec 2012 05:08:38 +0000 Subject: hg: jdk8/tl/jaxp: 8003261: static field is public but not final Message-ID: <20121219050843.538F84726A@hg.openjdk.java.net> Changeset: 15b32367b23c Author: joehw Date: 2012-12-18 21:11 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/15b32367b23c 8003261: static field is public but not final Summary: add final to fVersion field, and make it a non-compile time constant. Reviewed-by: hawtin, lancea, dholmes, chegar ! src/com/sun/org/apache/xerces/internal/impl/Version.java From vicente.romero at oracle.com Wed Dec 19 01:28:17 2012 From: vicente.romero at oracle.com (Vicente Arturo Romero Zaldivar) Date: Wed, 19 Dec 2012 01:28:17 -0800 (PST) Subject: 8003512: javac doesn't work with jar files with >64k entries Message-ID: <58522572-23d8-44b0-84d8-7d8de37995cd@default> Hi all, This is the webrev for bug (8003512: javac doesn't work with jar files with >64k entries): http://sa.sfbay.sun.com/projects/langtools_data/8/8003512.2/ Main contributions by Martin Buchholz. @Martin your opinion about the changeset will be very appreciated. Vicente. From shanliang.jiang at oracle.com Wed Dec 19 02:31:51 2012 From: shanliang.jiang at oracle.com (shanliang.jiang at oracle.com) Date: Wed, 19 Dec 2012 10:31:51 +0000 Subject: hg: jdk8/tl/jdk: 7158614: JMXStartStopTest.sh failing intermittently Message-ID: <20121219103239.3EE244727D@hg.openjdk.java.net> Changeset: c79b26b8efe0 Author: sjiang Date: 2012-12-19 11:06 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c79b26b8efe0 7158614: JMXStartStopTest.sh failing intermittently Summary: fixed 3 problems here: 1) checked the lock file too eary 2) never got the process id of a java test 3) some shell commands were not supported in some Solaris machines. Reviewed-by: dsamersoff, alanb ! test/ProblemList.txt ! test/sun/management/jmxremote/startstop/JMXStartStopDoSomething.java ! test/sun/management/jmxremote/startstop/JMXStartStopTest.sh From jonathan.gibbons at oracle.com Wed Dec 19 03:35:36 2012 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Wed, 19 Dec 2012 11:35:36 +0000 Subject: hg: jdk8/tl/langtools: 8004833: Integrate doclint support into javac Message-ID: <20121219113546.777424727F@hg.openjdk.java.net> Changeset: 67b01d295cd2 Author: jjg Date: 2012-12-19 11:29 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/67b01d295cd2 8004833: Integrate doclint support into javac Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/main/Main.java ! src/share/classes/com/sun/tools/javac/main/Option.java ! src/share/classes/com/sun/tools/javac/resources/javac.properties + test/tools/javac/doclint/DocLintTest.java From alan.bateman at oracle.com Wed Dec 19 07:02:49 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Wed, 19 Dec 2012 15:02:49 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20121219150313.2B43C47287@hg.openjdk.java.net> Changeset: 3fd3bcc8bd42 Author: joehw Date: 2012-12-19 12:09 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3fd3bcc8bd42 8004371: (props) Properties.loadFromXML needs small footprint XML parser as fallback when JAXP is not present Reviewed-by: alanb, mchung, psandoz + src/share/classes/jdk/internal/org/xml/sax/Attributes.java + src/share/classes/jdk/internal/org/xml/sax/ContentHandler.java + src/share/classes/jdk/internal/org/xml/sax/DTDHandler.java + src/share/classes/jdk/internal/org/xml/sax/EntityResolver.java + src/share/classes/jdk/internal/org/xml/sax/ErrorHandler.java + src/share/classes/jdk/internal/org/xml/sax/InputSource.java + src/share/classes/jdk/internal/org/xml/sax/Locator.java + src/share/classes/jdk/internal/org/xml/sax/SAXException.java + src/share/classes/jdk/internal/org/xml/sax/SAXNotRecognizedException.java + src/share/classes/jdk/internal/org/xml/sax/SAXNotSupportedException.java + src/share/classes/jdk/internal/org/xml/sax/SAXParseException.java + src/share/classes/jdk/internal/org/xml/sax/XMLReader.java + src/share/classes/jdk/internal/org/xml/sax/helpers/DefaultHandler.java + src/share/classes/jdk/internal/util/xml/PropertiesDefaultHandler.java + src/share/classes/jdk/internal/util/xml/SAXParser.java + src/share/classes/jdk/internal/util/xml/XMLStreamException.java + src/share/classes/jdk/internal/util/xml/XMLStreamWriter.java + src/share/classes/jdk/internal/util/xml/impl/Attrs.java + src/share/classes/jdk/internal/util/xml/impl/Input.java + src/share/classes/jdk/internal/util/xml/impl/Pair.java + src/share/classes/jdk/internal/util/xml/impl/Parser.java + src/share/classes/jdk/internal/util/xml/impl/ParserSAX.java + src/share/classes/jdk/internal/util/xml/impl/ReaderUTF16.java + src/share/classes/jdk/internal/util/xml/impl/ReaderUTF8.java + src/share/classes/jdk/internal/util/xml/impl/SAXParserImpl.java + src/share/classes/jdk/internal/util/xml/impl/XMLStreamWriterImpl.java + src/share/classes/jdk/internal/util/xml/impl/XMLWriter.java Changeset: cf15abdcdf88 Author: alanb Date: 2012-12-19 14:53 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cf15abdcdf88 8005248: (props) Integrate small footprint parser into Properties Reviewed-by: joehw, mchung, psandoz, erikj ! make/jdk/Makefile - make/jdk/asm/Makefile ! src/share/classes/java/util/Properties.java + src/share/classes/jdk/internal/util/xml/BasicXmlPropertiesProvider.java ! test/java/util/Properties/LoadAndStoreXML.java + test/java/util/Properties/invalidxml/BadCase.xml + test/java/util/Properties/invalidxml/BadDocType.xml.excluded + test/java/util/Properties/invalidxml/NoClosingTag.xml + test/java/util/Properties/invalidxml/NoDocType.xml.excluded + test/java/util/Properties/invalidxml/NoRoot.xml + test/java/util/Properties/invalidxml/NotQuoted.xml + test/java/util/Properties/invalidxml/README.txt From jonathan.gibbons at oracle.com Wed Dec 19 08:23:08 2012 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Wed, 19 Dec 2012 16:23:08 +0000 Subject: Review request: 8003562: Provide a command-line tool to find static dependencies In-Reply-To: <50D0A286.3040309@CoSoCo.de> References: <50B54A2C.1040907@oracle.com> <50BFF69E.1040805@oracle.com> <50C265D8.3050107@oracle.com> <50C5B9B2.2050705@oracle.com> <50CA6DA1.1070004@oracle.com> <50CA8BB1.1030502@oracle.com> <50CB03D1.5030400@CoSoCo.de> <50CB33FE.7000605@CoSoCo.de> <50CB9CF5.4090300@oracle.com> <50CBC7D0.9050103@CoSoCo.de> <50CBD110.1080208@oracle.com> <50CBD2BF.90100@oracle.com> <50CF38F2.6040707@oracle.com> <50CF44A7.8000202@CoSoCo.de> <50CFEDFC.5060903@oracle.com> <50D0A286.3040309@CoSoCo.de> Message-ID: <50D1E9EC.6070803@oracle.com> On 12/18/2012 05:06 PM, Ulf Zibis wrote: > > What about allowing (maybe define for preferred usage) GNU/UNIX path > separators even on Windows? E.g. > java --classpath=C/java/jre6/lib/rt.jar ... > - This would make java again more platform independent. It's bad enough dealing with standard OS paths for Unix and Windows, without introducing non-standard variants as well. -- Jon From jonathan.gibbons at oracle.com Wed Dec 19 09:09:26 2012 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Wed, 19 Dec 2012 17:09:26 +0000 Subject: hg: jdk8/tl/langtools: 8005098: Provide isSynthesized() information on Attribute.Compound Message-ID: <20121219170928.A9A404728F@hg.openjdk.java.net> Changeset: f72c9c5aeaef Author: jfranck Date: 2012-12-16 11:09 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f72c9c5aeaef 8005098: Provide isSynthesized() information on Attribute.Compound Reviewed-by: jjg ! make/build.properties ! src/share/classes/com/sun/tools/javac/code/Attribute.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/comp/Annotate.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java ! src/share/classes/com/sun/tools/javadoc/PackageDocImpl.java ! src/share/classes/com/sun/tools/javadoc/ParameterImpl.java ! src/share/classes/com/sun/tools/javadoc/ProgramElementDocImpl.java From Alan.Bateman at oracle.com Wed Dec 19 09:19:41 2012 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 19 Dec 2012 17:19:41 +0000 Subject: Review request: 8003562: Provide a command-line tool to find static dependencies In-Reply-To: <50D0F867.80100@oracle.com> References: <50B54A2C.1040907@oracle.com> <50BFF69E.1040805@oracle.com> <50C265D8.3050107@oracle.com> <50C5B9B2.2050705@oracle.com> <50CA6DA1.1070004@oracle.com> <50CA8BB1.1030502@oracle.com> <50CB03D1.5030400@CoSoCo.de> <50CB33FE.7000605@CoSoCo.de> <50CB9CF5.4090300@oracle.com> <50CBC7D0.9050103@CoSoCo.de> <50CBD110.1080208@oracle.com> <50CBD2BF.90100@oracle.com> <50CF38F2.6040707@oracle.com> <50CF44A7.8000202@CoSoCo.de> <50CFEDFC.5060903@oracle.com> <50D0A286.3040309@CoSoCo.de> <50D0C652.3080500@oracle.com> <50D0F867.80100@oracle.com> Message-ID: <50D1F72D.3080107@oracle.com> On 18/12/2012 23:12, Mandy Chung wrote: > : > > We can enhance the tool after the initial push. I'd like to get it > in jdk8 soon so that developers can try it out and give feedback. Thanks for the update, I think it looks very good. I agree we should get this in so that people can try it out and send feedback. -Alan From vicente.romero at oracle.com Wed Dec 19 09:46:48 2012 From: vicente.romero at oracle.com (Vicente Arturo Romero Zaldivar) Date: Wed, 19 Dec 2012 09:46:48 -0800 (PST) Subject: 8003512: javac doesn't work with jar files with >64k entries Message-ID: <6f4e0e74-df11-4637-b209-6ff3a60a1413@default> Hi all, This is the webrev for bug (8003512: javac doesn't work with jar files with >64k entries): http://cr.openjdk.java.net/~vromero/8003512/webrev.00/ Apologies for sending a non-public link before. Vicente. From joe.darcy at oracle.com Wed Dec 19 11:54:06 2012 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Wed, 19 Dec 2012 19:54:06 +0000 Subject: hg: jdk8/tl/jdk: 8005097: Tie isSynthetic javadoc to the JLS Message-ID: <20121219195417.F0A1D47295@hg.openjdk.java.net> Changeset: 1f9c19741285 Author: darcy Date: 2012-12-19 11:53 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1f9c19741285 8005097: Tie isSynthetic javadoc to the JLS Reviewed-by: mduigou ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/reflect/Constructor.java ! src/share/classes/java/lang/reflect/Executable.java ! src/share/classes/java/lang/reflect/Member.java ! src/share/classes/java/lang/reflect/Method.java From martinrb at google.com Wed Dec 19 16:09:24 2012 From: martinrb at google.com (Martin Buchholz) Date: Wed, 19 Dec 2012 16:09:24 -0800 Subject: 8003512: javac doesn't work with jar files with >64k entries In-Reply-To: <6f4e0e74-df11-4637-b209-6ff3a60a1413@default> References: <6f4e0e74-df11-4637-b209-6ff3a60a1413@default> Message-ID: Thanks for productionizing my half-baked change. Looks pretty good. The test is pretty annoying, but I think the current strategy of passing system properties is as good as we're going to get. + } catch (Exception ex) { + throw new AssertionError( + "The test has failed while executing this command " + command, + ex.getCause()); + } + I would just let executeCommand throw naturally and cause the test to fail. Kill the conversion to AssertionError. --- + * -javaoption:-Djava6="/path/to/jdk_or_jre6/bin/java" It's possible other tests may end up using the same mechanism to specify some other jdk. (I'm thinking cross-version serialization tests) Perhaps better is to specify the root of a jdk so that other tests might reuse it. Perhaps -javaoption:-Djava6.home= Martin On Wed, Dec 19, 2012 at 9:46 AM, Vicente Arturo Romero Zaldivar < vicente.romero at oracle.com> wrote: > Hi all, > > This is the webrev for bug (8003512: javac doesn't work with jar files > with >64k entries): > > http://cr.openjdk.java.net/~vromero/8003512/webrev.00/ > > Apologies for sending a non-public link before. > > Vicente. > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20121219/8b1b35e0/attachment.html From dmitry.samersoff at oracle.com Thu Dec 20 04:03:29 2012 From: dmitry.samersoff at oracle.com (dmitry.samersoff at oracle.com) Date: Thu, 20 Dec 2012 12:03:29 +0000 Subject: hg: jdk8/tl/jdk: 6783290: MBeanInfo/MBeanFeatureInfo has inconsistent readObject/writeObject Message-ID: <20121220120403.14270472CB@hg.openjdk.java.net> Changeset: b600d490dc57 Author: dsamersoff Date: 2012-12-20 16:02 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b600d490dc57 6783290: MBeanInfo/MBeanFeatureInfo has inconsistent readObject/writeObject Summary: call readObject in all cases Reviewed-by: emcmanus Contributed-by: jaroslav.bachorik at oracle.com ! src/share/classes/javax/management/MBeanFeatureInfo.java ! src/share/classes/javax/management/MBeanInfo.java From dmitry.samersoff at oracle.com Thu Dec 20 05:06:16 2012 From: dmitry.samersoff at oracle.com (dmitry.samersoff at oracle.com) Date: Thu, 20 Dec 2012 13:06:16 +0000 Subject: hg: jdk8/tl/jdk: 6937053: RMI unmarshalling errors in ClientNotifForwarder cause silent failure Message-ID: <20121220130642.D07B0472CD@hg.openjdk.java.net> Changeset: e43f90d5af11 Author: dsamersoff Date: 2012-12-20 16:56 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e43f90d5af11 6937053: RMI unmarshalling errors in ClientNotifForwarder cause silent failure Summary: the catch block in the fetchNotifs() method is extended to expect UnmarshalException Reviewed-by: emcmanus Contributed-by: jaroslav.bachorik at oracle.com ! src/share/classes/com/sun/jmx/remote/internal/ClientNotifForwarder.java From dmitry.samersoff at oracle.com Thu Dec 20 05:26:33 2012 From: dmitry.samersoff at oracle.com (dmitry.samersoff at oracle.com) Date: Thu, 20 Dec 2012 13:26:33 +0000 Subject: hg: jdk8/tl/jdk: 7009998: JMX synchronization during connection restart is faulty Message-ID: <20121220132645.201C0472CE@hg.openjdk.java.net> Changeset: 3f014bc09297 Author: dsamersoff Date: 2012-12-20 17:24 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3f014bc09297 7009998: JMX synchronization during connection restart is faulty Summary: add a return statement after the re-connecting has finished and the state is CONNECTED Reviewed-by: sjiang Contributed-by: jaroslav.bachorik at oracle.com ! make/netbeans/jmx/build.properties ! src/share/classes/com/sun/jmx/remote/internal/ClientCommunicatorAdmin.java From chris.hegarty at oracle.com Thu Dec 20 05:46:19 2012 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Thu, 20 Dec 2012 13:46:19 +0000 Subject: hg: jdk8/tl/jdk: 8002356: Add ForkJoin common pool and CountedCompleter Message-ID: <20121220134631.0AC22472CF@hg.openjdk.java.net> Changeset: d01a810798e0 Author: dl Date: 2012-12-20 13:44 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d01a810798e0 8002356: Add ForkJoin common pool and CountedCompleter Reviewed-by: chegar, mduigou ! make/java/java/FILES_java.gmk + src/share/classes/java/util/concurrent/CountedCompleter.java ! src/share/classes/java/util/concurrent/ForkJoinPool.java ! src/share/classes/java/util/concurrent/ForkJoinTask.java ! src/share/classes/java/util/concurrent/ForkJoinWorkerThread.java From chris.hegarty at oracle.com Thu Dec 20 07:05:28 2012 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Thu, 20 Dec 2012 15:05:28 +0000 Subject: hg: jdk8/tl/jdk: 8005306: Redundant cast warning in KeepAliveStream.java Message-ID: <20121220150550.BC332472D3@hg.openjdk.java.net> Changeset: 31d2f9995d6c Author: chegar Date: 2012-12-20 15:04 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/31d2f9995d6c 8005306: Redundant cast warning in KeepAliveStream.java Reviewed-by: alanb ! src/share/classes/sun/net/www/http/KeepAliveStream.java From vicente.romero at oracle.com Thu Dec 20 07:18:09 2012 From: vicente.romero at oracle.com (Vicente Arturo Romero Zaldivar) Date: Thu, 20 Dec 2012 07:18:09 -0800 (PST) Subject: 8003512: javac doesn't work with jar files with >64k entries Message-ID: <7bb8cf9b-f835-4c90-b4de-272df7b89ad2@default> Hi Martin, Thanks for your comments. have generated a new webrev after them, here is the link for it: http://cr.openjdk.java.net/~vromero/8003512/webrev.01/ Vicente. ----- Original Message ----- From: martinrb at google.com To: vicente.romero at oracle.com Cc: compiler-dev at openjdk.java.net Sent: Thursday, 20 December, 2012 12:09:28 AM GMT +00:00 GMT Britain, Ireland, Portugal Subject: Re: 8003512: javac doesn't work with jar files with >64k entries Thanks for productionizing my half-baked change. Looks pretty good. The test is pretty annoying, but I think the current strategy of passing system properties is as good as we're going to get. + } catch (Exception ex) { + throw new AssertionError( + "The test has failed while executing this command " + command, + ex.getCause()); + } + I would just let executeCommand throw naturally and cause the test to fail. Kill the conversion to AssertionError. --- + * -javaoption:-Djava6="/path/to/jdk_or_jre6/bin/java" It's possible other tests may end up using the same mechanism to specify some other jdk. (I'm thinking cross-version serialization tests) Perhaps better is to specify the root of a jdk so that other tests might reuse it. Perhaps -javaoption:-Djava6.home= Martin On Wed, Dec 19, 2012 at 9:46 AM, Vicente Arturo Romero Zaldivar < vicente.romero at oracle.com > wrote: Hi all, This is the webrev for bug (8003512: javac doesn't work with jar files with >64k entries): http://cr.openjdk.java.net/~vromero/8003512/webrev.00/ Apologies for sending a non-public link before. Vicente. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20121220/6449893e/attachment.html From Ulf.Zibis at CoSoCo.de Thu Dec 20 07:52:39 2012 From: Ulf.Zibis at CoSoCo.de (Ulf Zibis) Date: Thu, 20 Dec 2012 16:52:39 +0100 Subject: 8003512: javac doesn't work with jar files with >64k entries In-Reply-To: <7bb8cf9b-f835-4c90-b4de-272df7b89ad2@default> References: <7bb8cf9b-f835-4c90-b4de-272df7b89ad2@default> Message-ID: <50D33447.9010400@CoSoCo.de> Hi, I would give the test class a more descriptive name. -Ulf Am 20.12.2012 16:18, schrieb Vicente Arturo Romero Zaldivar: > Hi Martin, > > Thanks for your comments. have generated a new webrev after them, here is the link for it: > > http://cr.openjdk.java.net/~vromero/8003512/webrev.01/ > > Vicente. > > > ----- Original Message ----- > From: martinrb at google.com > To: vicente.romero at oracle.com > Cc: compiler-dev at openjdk.java.net > Sent: Thursday, 20 December, 2012 12:09:28 AM GMT +00:00 GMT Britain, Ireland, Portugal > Subject: Re: 8003512: javac doesn't work with jar files with >64k entries > > Thanks for productionizing my half-baked change. > Looks pretty good. > The test is pretty annoying, but I think the current strategy of passing system properties is as > good as we're going to get. > > + } catch (Exception ex) { > + throw new AssertionError( > + "The test has failed while executing this command " + command, > + ex.getCause()); > + } > + > I would just let executeCommand throw naturally and cause the test to fail. Kill the conversion > to AssertionError. > > --- > + * -javaoption:-Djava6="/path/to/jdk_or_jre6/bin/java" > It's possible other tests may end up using the same mechanism to specify some other jdk. > (I'm thinking cross-version serialization tests) > Perhaps better is to specify the root of a jdk so that other tests might reuse it. > Perhaps -javaoption:-Djava6.home= > > Martin > > On Wed, Dec 19, 2012 at 9:46 AM, Vicente Arturo Romero Zaldivar > wrote: > > Hi all, > > This is the webrev for bug (8003512: javac doesn't work with jar files with >64k entries): > > http://cr.openjdk.java.net/~vromero/8003512/webrev.00/ > > > Apologies for sending a non-public link before. > > Vicente. > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20121220/7b5b2b02/attachment.html From dmitry.samersoff at oracle.com Thu Dec 20 08:16:46 2012 From: dmitry.samersoff at oracle.com (dmitry.samersoff at oracle.com) Date: Thu, 20 Dec 2012 16:16:46 +0000 Subject: hg: jdk8/tl/jdk: 8005309: Missed tests for 6783290,6937053,7009998 Message-ID: <20121220161707.A434F472DC@hg.openjdk.java.net> Changeset: c1a55ee9618e Author: dsamersoff Date: 2012-12-20 20:12 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c1a55ee9618e 8005309: Missed tests for 6783290,6937053,7009998 Summary: Missed tests for 6783290,6937053,7009998 Reviewed-by: sjiang, emcmanus Contributed-by: jaroslav.bachorik at oracle.com + test/com/sun/jmx/remote/CCAdminReconnectTest.java + test/com/sun/jmx/remote/NotificationMarshalVersions/Client/Client.java + test/com/sun/jmx/remote/NotificationMarshalVersions/Client/ConfigKey.java + test/com/sun/jmx/remote/NotificationMarshalVersions/Client/TestNotification.java + test/com/sun/jmx/remote/NotificationMarshalVersions/Server/ConfigKey.java + test/com/sun/jmx/remote/NotificationMarshalVersions/Server/Server.java + test/com/sun/jmx/remote/NotificationMarshalVersions/Server/Ste.java + test/com/sun/jmx/remote/NotificationMarshalVersions/Server/SteMBean.java + test/com/sun/jmx/remote/NotificationMarshalVersions/Server/TestNotification.java + test/com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.sh + test/javax/management/MBeanInfo/SerializationTest1.java From jonathan.gibbons at oracle.com Thu Dec 20 10:09:39 2012 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Thu, 20 Dec 2012 18:09:39 +0000 Subject: hg: jdk8/tl/langtools: 8005307: fix missing @bug tags Message-ID: <20121220180944.2AD75472ED@hg.openjdk.java.net> Changeset: a22f23fb7abf Author: jjg Date: 2012-12-20 17:59 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a22f23fb7abf 8005307: fix missing @bug tags Reviewed-by: jjh ! test/tools/doclint/AccessTest.java ! test/tools/doclint/AccessTest.package.out ! test/tools/doclint/AccessTest.private.out ! test/tools/doclint/AccessTest.protected.out ! test/tools/doclint/AccessTest.public.out ! test/tools/doclint/AccessibilityTest.java ! test/tools/doclint/AccessibilityTest.out ! test/tools/doclint/EmptyAuthorTest.java ! test/tools/doclint/EmptyAuthorTest.out ! test/tools/doclint/EmptyExceptionTest.java ! test/tools/doclint/EmptyExceptionTest.out ! test/tools/doclint/EmptyParamTest.java ! test/tools/doclint/EmptyParamTest.out ! test/tools/doclint/EmptyReturnTest.java ! test/tools/doclint/EmptyReturnTest.out ! test/tools/doclint/EmptySerialDataTest.java ! test/tools/doclint/EmptySerialDataTest.out ! test/tools/doclint/EmptySerialFieldTest.java ! test/tools/doclint/EmptySerialFieldTest.out ! test/tools/doclint/EmptySinceTest.java ! test/tools/doclint/EmptySinceTest.out ! test/tools/doclint/EmptyVersionTest.java ! test/tools/doclint/EmptyVersionTest.out ! test/tools/doclint/HtmlAttrsTest.java ! test/tools/doclint/HtmlAttrsTest.out ! test/tools/doclint/HtmlTagsTest.java ! test/tools/doclint/HtmlTagsTest.out ! test/tools/doclint/MissingParamsTest.java ! test/tools/doclint/MissingParamsTest.out ! test/tools/doclint/MissingReturnTest.java ! test/tools/doclint/MissingReturnTest.out ! test/tools/doclint/MissingThrowsTest.java ! test/tools/doclint/MissingThrowsTest.out ! test/tools/doclint/OptionTest.java ! test/tools/doclint/OverridesTest.java ! test/tools/doclint/ReferenceTest.java ! test/tools/doclint/ReferenceTest.out ! test/tools/doclint/RunTest.java ! test/tools/doclint/SyntaxTest.java ! test/tools/doclint/SyntaxTest.out ! test/tools/doclint/SyntheticTest.java ! test/tools/doclint/ValidTest.java ! test/tools/doclint/tidy/AnchorAlreadyDefined.java ! test/tools/doclint/tidy/AnchorAlreadyDefined.out ! test/tools/doclint/tidy/BadEnd.java ! test/tools/doclint/tidy/BadEnd.out ! test/tools/doclint/tidy/InsertImplicit.java ! test/tools/doclint/tidy/InsertImplicit.out ! test/tools/doclint/tidy/InvalidEntity.java ! test/tools/doclint/tidy/InvalidEntity.out ! test/tools/doclint/tidy/InvalidName.java ! test/tools/doclint/tidy/InvalidName.out ! test/tools/doclint/tidy/InvalidTag.java ! test/tools/doclint/tidy/InvalidTag.out ! test/tools/doclint/tidy/InvalidURI.java ! test/tools/doclint/tidy/InvalidURI.out ! test/tools/doclint/tidy/MissingGT.java ! test/tools/doclint/tidy/MissingGT.out ! test/tools/doclint/tidy/MissingTag.java ! test/tools/doclint/tidy/MissingTag.out ! test/tools/doclint/tidy/NestedTag.java ! test/tools/doclint/tidy/NestedTag.out ! test/tools/doclint/tidy/ParaInPre.java ! test/tools/doclint/tidy/ParaInPre.out ! test/tools/doclint/tidy/RepeatedAttr.java ! test/tools/doclint/tidy/RepeatedAttr.out ! test/tools/doclint/tidy/TextNotAllowed.java ! test/tools/doclint/tidy/TextNotAllowed.out ! test/tools/doclint/tidy/TrimmingEmptyTag.java ! test/tools/doclint/tidy/TrimmingEmptyTag.out ! test/tools/doclint/tidy/UnescapedOrUnknownEntity.java ! test/tools/doclint/tidy/UnescapedOrUnknownEntity.out From alan.bateman at oracle.com Thu Dec 20 12:32:45 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Thu, 20 Dec 2012 20:32:45 +0000 Subject: hg: jdk8/tl/jdk: 8001048: JSR-160: Allow IIOP transport to be optional Message-ID: <20121220203306.F0171472FD@hg.openjdk.java.net> Changeset: edb71a37fcb7 Author: alanb Date: 2012-12-20 20:29 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/edb71a37fcb7 8001048: JSR-160: Allow IIOP transport to be optional Reviewed-by: dsamersoff, dfuchs, mchung ! src/share/classes/com/sun/jmx/remote/internal/IIOPHelper.java ! src/share/classes/javax/management/remote/JMXConnectorFactory.java ! src/share/classes/javax/management/remote/JMXConnectorServerFactory.java ! src/share/classes/javax/management/remote/rmi/RMIConnector.java ! src/share/classes/javax/management/remote/rmi/RMIConnectorServer.java ! src/share/classes/javax/management/remote/rmi/package.html ! test/javax/management/remote/mandatory/connection/AddressableTest.java ! test/javax/management/remote/mandatory/connection/CloseableTest.java ! test/javax/management/remote/mandatory/connection/ConnectionListenerNullTest.java ! test/javax/management/remote/mandatory/connection/IIOPURLTest.java ! test/javax/management/remote/mandatory/connection/IdleTimeoutTest.java ! test/javax/management/remote/mandatory/connection/MultiThreadDeadLockTest.java ! test/javax/management/remote/mandatory/connectorServer/SetMBeanServerForwarder.java ! test/javax/management/remote/mandatory/loading/MissingClassTest.java ! test/javax/management/remote/mandatory/provider/ProviderTest.java ! test/javax/management/remote/mandatory/serverError/JMXServerErrorTest.java From alan.bateman at oracle.com Thu Dec 20 12:46:20 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Thu, 20 Dec 2012 20:46:20 +0000 Subject: hg: jdk8/tl/jdk: 8005281: (props) loadFromXML/storeToXML with small parser is not thread safe Message-ID: <20121220204631.7E4FF472FE@hg.openjdk.java.net> Changeset: eeda18683ddc Author: alanb Date: 2012-12-20 20:40 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/eeda18683ddc 8005281: (props) loadFromXML/storeToXML with small parser is not thread safe Reviewed-by: mchung ! src/share/classes/jdk/internal/util/xml/BasicXmlPropertiesProvider.java + test/java/util/Properties/ConcurrentLoadAndStoreXML.java From Ulf.Zibis at CoSoCo.de Thu Dec 20 13:06:38 2012 From: Ulf.Zibis at CoSoCo.de (Ulf Zibis) Date: Thu, 20 Dec 2012 22:06:38 +0100 Subject: Fwd: Re: Review request: 8003562: Provide a command-line tool to find static dependenciesh In-Reply-To: <50D337B0.2090504@oracle.com> References: <50D0F867.80100@oracle.com> <50D337B0.2090504@oracle.com> Message-ID: <50D37DDE.6040905@CoSoCo.de> Hi Mandy, I had much to do, guessed, all would be all-right. I first had problems to find my proposed changes from 2012-12-15 in your code. Now I found it. You did it even better Just an additional nit in JDepsTask: 511 if (o.hasArg) { 512 String arg = null; 513 if (name.startsWith("--") && name.indexOf('=') > 0) { 514 arg = name.substring(name.indexOf('=')+1, name.length()); 515 } else { 516 arg = rest.hasNext() ? rest.next() : "-"; 517 } 518 if (arg.startsWith("-")) { 519 throw new BadArgs("err.missing.arg", name).showUsage(true); 520 } else { 521 o.process(this, name, arg); 522 } 523 } else { 524 o.process(this, name, null); 525 } Could just be: 511 String param = null; 512 if (o.hasArg) { 513 if (name.startsWith("--") && name.indexOf('=') > 0) { 514 param = name.substring(name.indexOf('=')+1, name.length()); 515 } else if (!rest.hasNext() || (param = rest.next()).startsWith("-")) { 516 throw new BadArgs("err.missing.param", name).showUsage(true); 517 } 518 } 519 o.process(this, name, param); This additionally would allow negative values for the outlined option. (to avoid confusion with the upper loop, better rename arg-->param) You do not like for loops? : 492 boolean acceptOption = true; 493 while (iter.hasNext()) { 494 String arg = iter.next(); 495 if (arg.startsWith("-") && acceptOption) { Could be: 492 boolean acceptOption = true; 493 for (String arg; iter.hasNext(); arg = iter.next()) { 494 if (acceptOption && arg.startsWith("-")) { // swap order for better performance Additionally while loops tend to JIT-compile bad, see: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6932855 *Not* a nit: You do not handle a missing option parameter for the outlined form. So I think, you better handle existence and validity (e.g. wrong leading '-') or parameters by process(this, name, param) and just code: 513 o.process(this, name, (name.startsWith("--") && name.indexOf('=') > 0) 514 ? name.substring(name.indexOf('=')+1, name.length()); 515 : o.hasArg && rest.hasNext() ? rest.next() : null); This additionally would allow negative values for both option forms. As the algorithm now is very short, it could be easily inlined in the calling method About the options an additional thought: -v --verbose Print additional information -V --verbose-level= Print package-level or class-level dependencies Valid levels are: "package" and "class" 1. I think, --verbose-level= is too verbose, why not just --verbose= or maybe alternatively: -l --level= Print package-level or class-level dependencies. -D --dependency-level= Print package-level or class-level dependencies. 2. It's not clear if -v/--verbose without parameter means one of the others with which default. 3. I more would like only 1 verbose option, something like: -v --verbose= Print additional information; optional valid level dependencies: "package" and "class" 4. Couldn't you use lower-case -r for --recursive ? -Ulf Am 20.12.2012 17:07, schrieb Mandy Chung: > Ulf, > > Thanks for all the feedback. Just to double check - are you ok with the new webrev? > > Mandy > > -------- Original Message -------- > Subject: Re: Review request: 8003562: Provide a command-line tool to find static dependencies > Date: Tue, 18 Dec 2012 15:12:39 -0800 > From: Mandy Chung > To: Ulf Zibis , Alan Bateman > CC: core-libs-dev at openjdk.java.net, compiler-dev at openjdk.java.net > > > > Alan, Ulf, > > I updated the jdeps CLI per the discussion we had. > > $ jdeps --help > Usage: jdeps > where can be a pathname to a .class file, a directory, a JAR file, > or a fully-qualified classname or wildcard "*". Possible options include: > -s --summary Print dependency summary only > -v --verbose Print additional information > -V --verbose-level= Print package-level or > class-level dependencies > Valid levels are: "package" and > "class" > -c --classpath= Specify where to find class files > -p --package= Restrict analysis to classes in > this package > (may be given multiple times) > -e --regex= Restrict analysis to packages > matching pattern > (-p and -e are exclusive) > -P --profile Show profile or the file > containing a package > -R --recursive Recursively traverse all > dependencies > --version Version information > > Updated webrev: > http://cr.openjdk.java.net/~mchung/jdk8/webrevs/jdeps/webrev.06/ > > jdeps only support GNU-style options. I added java.util.function > and com.sun.source.doctree in the jdk.properties. I'll replace > it to use the proper javac API to work with profiles next. I > caught a typo 'com.sunsource.doctree' (missing dot) in NON_CORE_PKGS.gmk > and I fix that in this patch. > > We can enhance the tool after the initial push. I'd like to get it > in jdk8 soon so that developers can try it out and give feedback. > > Thanks > Mandy -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20121220/5364ddf2/attachment.html From mandy.chung at oracle.com Thu Dec 20 13:46:08 2012 From: mandy.chung at oracle.com (Mandy Chung) Date: Thu, 20 Dec 2012 13:46:08 -0800 Subject: Fwd: Re: Review request: 8003562: Provide a command-line tool to find static dependenciesh In-Reply-To: <50D37DDE.6040905@CoSoCo.de> References: <50D0F867.80100@oracle.com> <50D337B0.2090504@oracle.com> <50D37DDE.6040905@CoSoCo.de> Message-ID: <50D38720.3020408@oracle.com> On 12/20/12 1:06 PM, Ulf Zibis wrote: > Hi Mandy, > > I had much to do, guessed, all would be all-right. > > I first had problems to find my proposed changes from 2012-12-15 in > your code. > Now I found it. You did it even better > > Just an additional nit in JDepsTask: > 511 if (o.hasArg) { > 512 String arg = null; > 513 if (name.startsWith("--") && > name.indexOf('=') > 0) { > 514 arg = name.substring(name.indexOf('=')+1, > name.length()); > 515 } else { > 516 arg = rest.hasNext() ? rest.next() : "-"; > 517 } > 518 if (arg.startsWith("-")) { > 519 throw new BadArgs("err.missing.arg", > name).showUsage(true); > 520 } else { > 521 o.process(this, name, arg); > 522 } > 523 } else { > 524 o.process(this, name, null); > 525 } > > Could just be: > 511 String param = null; > 512 if (o.hasArg) { > 513 if (name.startsWith("--") && > name.indexOf('=') > 0) { > 514 param = > name.substring(name.indexOf('=')+1, name.length()); > 515 } else if (!rest.hasNext() || (param = > rest.next()).startsWith("-")) { > 516 throw new BadArgs("err.missing.param", > name).showUsage(true); > 517 } > 518 } > 519 o.process(this, name, param); > This additionally would allow negative values for the outlined option. > (to avoid confusion with the upper loop, better rename arg-->param) I can fix this. I tend not to inline the assignment in a long statement with multiple-evaluation for readability. For this case, I like your suggestion to be concise while readable. > > You do not like for loops? : I like for-loop :) What you suggested last time and below has a bug > 492 boolean acceptOption = true; > 493 while (iter.hasNext()) { > 494 String arg = iter.next(); > 495 if (arg.startsWith("-") && acceptOption) { > Could be: > 492 boolean acceptOption = true; > 493 for (String arg; iter.hasNext(); arg = iter.next()) { arg is initialized after the first iteration. I could do for (; iter.hasNext() && ((arg = iter.next()) != null);) { ... } but I don't see how it's much prettier than the while-loop above (2-line into 1-line). I considered to use foreach and move away from Iterator. > 494 if (acceptOption && arg.startsWith("-")) { // swap > order for better performance > Additionally while loops tend to JIT-compile bad, see: > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6932855 > OK. > *Not* a nit: > You do not handle a missing option parameter for the outlined form. do you have an example what it doesn't handle? If it's missing, the first given file will be used as the option parameter. It validates the option parameter for the case we can. There are cases we can't (e.g. classpath). > So I think, you better handle existence and validity (e.g. wrong > leading '-') or parameters by process(this, name, param) and just code: > 513 o.process(this, name, (name.startsWith("--") && > name.indexOf('=') > 0) > 514 ? name.substring(name.indexOf('=')+1, > name.length()); > 515 : o.hasArg && rest.hasNext() ? > rest.next() : null); > This additionally would allow negative values for both option forms. > As the algorithm now is very short, it could be easily inlined in the > calling method > I may be missing the problem you try to point out. And this is harder to read for me :) > > About the options an additional thought: > -v --verbose Print additional information > -V --verbose-level= Print package-level or > class-level dependencies > Valid levels are: "package" and > "class" I somewhat agree with this but I'd like to get this out for people to try and get feedback. We can refine the options after the first push. I expect the tool will evolve and the options may be revised too. For example there are some additional information we can enhance the tool to print out (e.g. there is a suggestion to include the method/field reference count from one class to another that will be a useful hint to indicate how interconnected a class depends on the other). Mandy > 1. I think, --verbose-level= is too verbose, why not just > --verbose= or maybe alternatively: > -l --level= Print package-level or class-level > dependencies. > -D --dependency-level= Print package-level or > class-level dependencies. > 2. It's not clear if -v/--verbose without parameter means one of the > others with which default. > 3. I more would like only 1 verbose option, something like: > -v --verbose= Print additional information; optional > valid level dependencies: > "package" and "class" > > 4. Couldn't you use lower-case -r for --recursive ? > > -Ulf > > > Am 20.12.2012 17:07, schrieb Mandy Chung: >> Ulf, >> >> Thanks for all the feedback. Just to double check - are you ok with >> the new webrev? >> >> Mandy >> >> -------- Original Message -------- >> Subject: Re: Review request: 8003562: Provide a command-line tool to >> find static dependencies >> Date: Tue, 18 Dec 2012 15:12:39 -0800 >> From: Mandy Chung >> To: Ulf Zibis , Alan Bateman >> >> CC: core-libs-dev at openjdk.java.net, compiler-dev at openjdk.java.net >> >> >> >> Alan, Ulf, >> >> I updated the jdeps CLI per the discussion we had. >> >> $ jdeps --help >> Usage: jdeps >> where can be a pathname to a .class file, a directory, a JAR file, >> or a fully-qualified classname or wildcard "*". Possible options include: >> -s --summary Print dependency summary only >> -v --verbose Print additional information >> -V --verbose-level= Print package-level or >> class-level dependencies >> Valid levels are: "package" and >> "class" >> -c --classpath= Specify where to find class files >> -p --package= Restrict analysis to classes in >> this package >> (may be given multiple times) >> -e --regex= Restrict analysis to packages >> matching pattern >> (-p and -e are exclusive) >> -P --profile Show profile or the file >> containing a package >> -R --recursive Recursively traverse all >> dependencies >> --version Version information >> >> Updated webrev: >> http://cr.openjdk.java.net/~mchung/jdk8/webrevs/jdeps/webrev.06/ >> >> jdeps only support GNU-style options. I added java.util.function >> and com.sun.source.doctree in the jdk.properties. I'll replace >> it to use the proper javac API to work with profiles next. I >> caught a typo 'com.sunsource.doctree' (missing dot) in NON_CORE_PKGS.gmk >> and I fix that in this patch. >> >> We can enhance the tool after the initial push. I'd like to get it >> in jdk8 soon so that developers can try it out and give feedback. >> >> Thanks >> Mandy > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20121220/8eb4ab1a/attachment.html From martinrb at google.com Thu Dec 20 14:14:22 2012 From: martinrb at google.com (Martin Buchholz) Date: Thu, 20 Dec 2012 14:14:22 -0800 Subject: 8003512: javac doesn't work with jar files with >64k entries In-Reply-To: <7bb8cf9b-f835-4c90-b4de-272df7b89ad2@default> References: <7bb8cf9b-f835-4c90-b4de-272df7b89ad2@default> Message-ID: Looks good to me. The one thing I might change is a jtreg design question. I wouldn't bother with T8003512.doTest, but simply run the test whenever the java6.home system property is defined. This means people can have scripts to RUN ALL THE TESTS without having to keep adding new test-specific system properties all the time. On Thu, Dec 20, 2012 at 7:18 AM, Vicente Arturo Romero Zaldivar < vicente.romero at oracle.com> wrote: > Hi Martin, > > Thanks for your comments. have generated a new webrev after them, here is > the link for it: > > http://cr.openjdk.java.net/~vromero/8003512/webrev.01/ > > > Vicente. > > > ----- Original Message ----- > From: martinrb at google.com > To: vicente.romero at oracle.com > Cc: compiler-dev at openjdk.java.net > Sent: Thursday, 20 December, 2012 12:09:28 AM GMT +00:00 GMT Britain, > Ireland, Portugal > Subject: Re: 8003512: javac doesn't work with jar files with >64k entries > > Thanks for productionizing my half-baked change. > Looks pretty good. > The test is pretty annoying, but I think the current strategy of passing > system properties is as good as we're going to get. > > + } catch (Exception ex) { > + throw new AssertionError( > + "The test has failed while executing this command " + command, > + ex.getCause()); > + } > + > > I would just let executeCommand throw naturally and cause the test to > fail. Kill the conversion to AssertionError. > > --- > > + * -javaoption:-Djava6="/path/to/jdk_or_jre6/bin/java" > > It's possible other tests may end up using the same mechanism to specify > some other jdk. > (I'm thinking cross-version serialization tests) > Perhaps better is to specify the root of a jdk so that other tests might > reuse it. > Perhaps -javaoption:-Djava6.home= > > Martin > > On Wed, Dec 19, 2012 at 9:46 AM, Vicente Arturo Romero Zaldivar < > vicente.romero at oracle.com> wrote: > >> Hi all, >> >> This is the webrev for bug (8003512: javac doesn't work with jar files >> with >64k entries): >> >> http://cr.openjdk.java.net/~vromero/8003512/webrev.00/ >> >> Apologies for sending a non-public link before. >> >> Vicente. >> > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20121220/fd617919/attachment.html From jonathan.gibbons at oracle.com Thu Dec 20 14:33:34 2012 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Thu, 20 Dec 2012 22:33:34 +0000 Subject: 8003512: javac doesn't work with jar files with >64k entries In-Reply-To: References: <7bb8cf9b-f835-4c90-b4de-272df7b89ad2@default> Message-ID: <50D3923E.8010005@oracle.com> This is a good suggestion, but does open up the discussion of standard naming for properties. java6.home is OK for now, but we might want to consider a context (faq, tag spec etc) to define standard properties or env variables like this. -- Jon On 12/20/2012 10:14 PM, Martin Buchholz wrote: > Looks good to me. > The one thing I might change is a jtreg design question. I wouldn't > bother with T8003512.doTest, but simply run the test whenever the > java6.home system property is defined. > This means people can have scripts to RUN ALL THE TESTS without having > to keep adding new test-specific system properties all the time. > > > On Thu, Dec 20, 2012 at 7:18 AM, Vicente Arturo Romero Zaldivar > > wrote: > > Hi Martin, > > Thanks for your comments. have generated a new webrev after them, > here is the link for it: > > http://cr.openjdk.java.net/~vromero/8003512/webrev.01/ > > > > Vicente. > > > ----- Original Message ----- > From: martinrb at google.com > To: vicente.romero at oracle.com > Cc: compiler-dev at openjdk.java.net > > Sent: Thursday, 20 December, 2012 12:09:28 AM GMT +00:00 GMT > Britain, Ireland, Portugal > Subject: Re: 8003512: javac doesn't work with jar files with >64k > entries > > Thanks for productionizing my half-baked change. > Looks pretty good. > The test is pretty annoying, but I think the current strategy of > passing system properties is as good as we're going to get. > > + } catch (Exception ex) { > + throw new AssertionError( > + "The test has failed while executing this command " + command, > + ex.getCause()); > + } > + > > I would just let executeCommand throw naturally and cause the test > to fail. Kill the conversion to AssertionError. > > --- > > + * -javaoption:-Djava6="/path/to/jdk_or_jre6/bin/java" > > It's possible other tests may end up using the same mechanism to > specify some other jdk. > (I'm thinking cross-version serialization tests) > Perhaps better is to specify the root of a jdk so that other tests > might reuse it. > Perhaps -javaoption:-Djava6.home= > > Martin > > On Wed, Dec 19, 2012 at 9:46 AM, Vicente Arturo Romero Zaldivar > > wrote: > > Hi all, > > This is the webrev for bug (8003512: javac doesn't work with > jar files with >64k entries): > > http://cr.openjdk.java.net/~vromero/8003512/webrev.00/ > > > Apologies for sending a non-public link before. > > Vicente. > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20121220/9d98de9e/attachment.html From stuart.marks at oracle.com Thu Dec 20 21:41:54 2012 From: stuart.marks at oracle.com (stuart.marks at oracle.com) Date: Fri, 21 Dec 2012 05:41:54 +0000 Subject: hg: jdk8/tl/jdk: 8005290: remove -showversion from RMI test library subprocess mechanism Message-ID: <20121221054214.825BB47326@hg.openjdk.java.net> Changeset: 60adb69bf043 Author: smarks Date: 2012-12-20 20:11 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/60adb69bf043 8005290: remove -showversion from RMI test library subprocess mechanism Reviewed-by: jgish, chegar, dmocek ! test/java/rmi/testlibrary/JavaVM.java ! test/java/rmi/testlibrary/StreamPipe.java ! test/sun/rmi/runtime/Log/6409194/NoConsoleOutput.java From shanliang.jiang at oracle.com Fri Dec 21 00:28:00 2012 From: shanliang.jiang at oracle.com (shanliang.jiang at oracle.com) Date: Fri, 21 Dec 2012 08:28:00 +0000 Subject: hg: jdk8/tl/jdk: 7146162: javax/management/remote/mandatory/connection/BrokenConnectionTest.java failing intermittently Message-ID: <20121221082824.8FF3047329@hg.openjdk.java.net> Changeset: 42ee6b6ad373 Author: jbachorik Date: 2012-12-21 09:27 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/42ee6b6ad373 7146162: javax/management/remote/mandatory/connection/BrokenConnectionTest.java failing intermittently Summary: ClientCommunicatorAdmin should call gotIOException((IOException)e) instead of restart((IOException)e) when detecting a communication error, because the method gotIOException will send a failure notification if necessary. Reviewed-by: emcmanus, sjiang Contributed-by: jaroslav.bachorik at oracle.com ! src/share/classes/com/sun/jmx/remote/internal/ClientCommunicatorAdmin.java From shanliang.jiang at oracle.com Fri Dec 21 02:04:35 2012 From: shanliang.jiang at oracle.com (shanliang.jiang at oracle.com) Date: Fri, 21 Dec 2012 10:04:35 +0000 Subject: hg: jdk8/tl/jdk: 8005325: The script should use TESTVMOPTS Message-ID: <20121221100457.399BB4732D@hg.openjdk.java.net> Changeset: 86c10d1484e9 Author: sjiang Date: 2012-12-21 10:58 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/86c10d1484e9 8005325: The script should use TESTVMOPTS Summary: Put back TESTVMOPTS which was removed by mistake. Reviewed-by: smarks ! test/sun/management/jmxremote/startstop/JMXStartStopTest.sh From vicente.romero at oracle.com Fri Dec 21 05:19:26 2012 From: vicente.romero at oracle.com (Vicente Arturo Romero Zaldivar) Date: Fri, 21 Dec 2012 05:19:26 -0800 (PST) Subject: 8003512: javac doesn't work with jar files with >64k entries Message-ID: <876df87e-c3ca-47e1-aca7-bc2714950b6d@default> Thanks everyone for the comments. Here you can find the final version: http://cr.openjdk.java.net/~vromero/8003512/webrev.02/ Vicente. ----- Original Message ----- From: martinrb at google.com To: vicente.romero at oracle.com Cc: compiler-dev at openjdk.java.net Sent: Thursday, 20 December, 2012 10:14:26 PM GMT +00:00 GMT Britain, Ireland, Portugal Subject: Re: 8003512: javac doesn't work with jar files with >64k entries Looks good to me. The one thing I might change is a jtreg design question. I wouldn't bother with T8003512.doTest, but simply run the test whenever the java6.home system property is defined. This means people can have scripts to RUN ALL THE TESTS without having to keep adding new test-specific system properties all the time. On Thu, Dec 20, 2012 at 7:18 AM, Vicente Arturo Romero Zaldivar < vicente.romero at oracle.com > wrote: Hi Martin, Thanks for your comments. have generated a new webrev after them, here is the link for it: http://cr.openjdk.java.net/~vromero/8003512/webrev.01/ Vicente. ----- Original Message ----- From: martinrb at google.com To: vicente.romero at oracle.com Cc: compiler-dev at openjdk.java.net Sent: Thursday, 20 December, 2012 12:09:28 AM GMT +00:00 GMT Britain, Ireland, Portugal Subject: Re: 8003512: javac doesn't work with jar files with >64k entries Thanks for productionizing my half-baked change. Looks pretty good. The test is pretty annoying, but I think the current strategy of passing system properties is as good as we're going to get. + } catch (Exception ex) { + throw new AssertionError( + "The test has failed while executing this command " + command, + ex.getCause()); + } + I would just let executeCommand throw naturally and cause the test to fail. Kill the conversion to AssertionError. --- + * -javaoption:-Djava6="/path/to/jdk_or_jre6/bin/java" It's possible other tests may end up using the same mechanism to specify some other jdk. (I'm thinking cross-version serialization tests) Perhaps better is to specify the root of a jdk so that other tests might reuse it. Perhaps -javaoption:-Djava6.home= Martin On Wed, Dec 19, 2012 at 9:46 AM, Vicente Arturo Romero Zaldivar < vicente.romero at oracle.com > wrote: Hi all, This is the webrev for bug (8003512: javac doesn't work with jar files with >64k entries): http://cr.openjdk.java.net/~vromero/8003512/webrev.00/ Apologies for sending a non-public link before. Vicente. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20121221/1b5deb7c/attachment.html From jonathan.gibbons at oracle.com Fri Dec 21 07:59:35 2012 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Fri, 21 Dec 2012 15:59:35 +0000 Subject: 8003512: javac doesn't work with jar files with >64k entries In-Reply-To: <876df87e-c3ca-47e1-aca7-bc2714950b6d@default> References: <876df87e-c3ca-47e1-aca7-bc2714950b6d@default> Message-ID: <50D48767.3070808@oracle.com> Looks good to me. -- Jon On 12/21/2012 01:19 PM, Vicente Arturo Romero Zaldivar wrote: > Thanks everyone for the comments. Here you can find the final version: > > http://cr.openjdk.java.net/~vromero/8003512/webrev.02/ > > Vicente. > > ----- Original Message ----- > From: martinrb at google.com > To: vicente.romero at oracle.com > Cc: compiler-dev at openjdk.java.net > Sent: Thursday, 20 December, 2012 10:14:26 PM GMT +00:00 GMT Britain, > Ireland, Portugal > Subject: Re: 8003512: javac doesn't work with jar files with >64k entries > > Looks good to me. > The one thing I might change is a jtreg design question. I wouldn't > bother with T8003512.doTest, but simply run the test whenever the > java6.home system property is defined. > This means people can have scripts to RUN ALL THE TESTS without having > to keep adding new test-specific system properties all the time. > > > On Thu, Dec 20, 2012 at 7:18 AM, Vicente Arturo Romero Zaldivar > > wrote: > > Hi Martin, > > Thanks for your comments. have generated a new webrev after them, > here is the link for it: > > http://cr.openjdk.java.net/~vromero/8003512/webrev.01/ > > > > Vicente. > > > ----- Original Message ----- > From: martinrb at google.com > To: vicente.romero at oracle.com > Cc: compiler-dev at openjdk.java.net > > Sent: Thursday, 20 December, 2012 12:09:28 AM GMT +00:00 GMT > Britain, Ireland, Portugal > Subject: Re: 8003512: javac doesn't work with jar files with >64k > entries > > Thanks for productionizing my half-baked change. > Looks pretty good. > The test is pretty annoying, but I think the current strategy of > passing system properties is as good as we're going to get. > > + } catch (Exception ex) { > + throw new AssertionError( > + "The test has failed while executing this command " + command, > + ex.getCause()); > + } > + > > I would just let executeCommand throw naturally and cause the test > to fail. Kill the conversion to AssertionError. > > --- > > + * -javaoption:-Djava6="/path/to/jdk_or_jre6/bin/java" > > It's possible other tests may end up using the same mechanism to > specify some other jdk. > (I'm thinking cross-version serialization tests) > Perhaps better is to specify the root of a jdk so that other tests > might reuse it. > Perhaps -javaoption:-Djava6.home= > > Martin > > On Wed, Dec 19, 2012 at 9:46 AM, Vicente Arturo Romero Zaldivar > > wrote: > > Hi all, > > This is the webrev for bug (8003512: javac doesn't work with > jar files with >64k entries): > > http://cr.openjdk.java.net/~vromero/8003512/webrev.00/ > > > Apologies for sending a non-public link before. > > Vicente. > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20121221/7a375601/attachment.html From joe.darcy at oracle.com Fri Dec 21 08:46:00 2012 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Fri, 21 Dec 2012 16:46:00 +0000 Subject: hg: jdk8/tl/langtools: 8005282: Use @library tag with non-relative path for javac tests Message-ID: <20121221164605.393E347337@hg.openjdk.java.net> Changeset: b52a38d4536c Author: darcy Date: 2012-12-21 08:45 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b52a38d4536c 8005282: Use @library tag with non-relative path for javac tests Reviewed-by: jjg ! test/tools/javac/7129225/TestImportStar.java ! test/tools/javac/cast/intersection/model/Model01.java ! test/tools/javac/classreader/T7031108.java ! test/tools/javac/enum/6350057/T6350057.java ! test/tools/javac/enum/6424358/T6424358.java ! test/tools/javac/file/T7018098.java ! test/tools/javac/multicatch/model/ModelChecker.java ! test/tools/javac/options/T7022337.java ! test/tools/javac/processing/6348499/T6348499.java ! test/tools/javac/processing/6359313/T6359313.java ! test/tools/javac/processing/6365040/T6365040.java ! test/tools/javac/processing/6413690/T6413690.java ! test/tools/javac/processing/6414633/T6414633.java ! test/tools/javac/processing/6430209/T6430209.java ! test/tools/javac/processing/6499119/ClassProcessor.java ! test/tools/javac/processing/6511613/clss41701.java ! test/tools/javac/processing/6512707/T6512707.java ! test/tools/javac/processing/6634138/T6634138.java ! test/tools/javac/processing/6994946/SemanticErrorTest.java ! test/tools/javac/processing/6994946/SyntaxErrorTest.java ! test/tools/javac/processing/T6920317.java ! test/tools/javac/processing/T7196462.java ! test/tools/javac/processing/TestWarnErrorCount.java ! test/tools/javac/processing/environment/TestSourceVersion.java ! test/tools/javac/processing/environment/round/TestContext.java ! test/tools/javac/processing/environment/round/TestElementsAnnotatedWith.java ! test/tools/javac/processing/errors/TestErrorCount.java ! test/tools/javac/processing/errors/TestFatalityOfParseErrors.java ! test/tools/javac/processing/errors/TestOptionSyntaxErrors.java ! test/tools/javac/processing/errors/TestParseErrors/TestParseErrors.java ! test/tools/javac/processing/errors/TestReturnCode.java ! test/tools/javac/processing/filer/TestFilerConstraints.java ! test/tools/javac/processing/filer/TestGetResource.java ! test/tools/javac/processing/filer/TestGetResource2.java ! test/tools/javac/processing/filer/TestInvalidRelativeNames.java ! test/tools/javac/processing/filer/TestLastRound.java ! test/tools/javac/processing/filer/TestPackageInfo.java ! test/tools/javac/processing/filer/TestValidRelativeNames.java ! test/tools/javac/processing/messager/6362067/T6362067.java ! test/tools/javac/processing/messager/MessagerBasics.java ! test/tools/javac/processing/model/6194785/T6194785.java ! test/tools/javac/processing/model/6341534/T6341534.java ! test/tools/javac/processing/model/element/TestAnonClassNames.java ! test/tools/javac/processing/model/element/TestElement.java ! test/tools/javac/processing/model/element/TestMissingElement/TestMissingElement.java ! test/tools/javac/processing/model/element/TestMissingElement2/TestMissingClass.java ! test/tools/javac/processing/model/element/TestMissingElement2/TestMissingGenericClass1.java ! test/tools/javac/processing/model/element/TestMissingElement2/TestMissingGenericClass2.java ! test/tools/javac/processing/model/element/TestMissingElement2/TestMissingGenericInterface1.java ! test/tools/javac/processing/model/element/TestMissingElement2/TestMissingGenericInterface2.java ! test/tools/javac/processing/model/element/TestMissingElement2/TestMissingInterface.java ! test/tools/javac/processing/model/element/TestNames.java ! test/tools/javac/processing/model/element/TestPackageElement.java ! test/tools/javac/processing/model/element/TestResourceElement.java ! test/tools/javac/processing/model/element/TestResourceVariable.java ! test/tools/javac/processing/model/element/TestTypeParameter.java ! test/tools/javac/processing/model/element/TypeParamBounds.java ! test/tools/javac/processing/model/type/MirroredTypeEx/OverEager.java ! test/tools/javac/processing/model/type/MirroredTypeEx/Plurality.java ! test/tools/javac/processing/model/type/NoTypes.java ! test/tools/javac/processing/model/type/TestUnionType.java ! test/tools/javac/processing/model/util/BinaryName.java ! test/tools/javac/processing/model/util/GetTypeElemBadArg.java ! test/tools/javac/processing/model/util/NoSupers.java ! test/tools/javac/processing/model/util/OverridesSpecEx.java ! test/tools/javac/processing/model/util/TypesBadArg.java ! test/tools/javac/processing/model/util/deprecation/TestDeprecation.java ! test/tools/javac/processing/model/util/directSupersOfErr/DirectSupersOfErr.java ! test/tools/javac/processing/model/util/elements/TestGetConstantExpression.java ! test/tools/javac/processing/model/util/elements/TestGetPackageOf.java ! test/tools/javac/processing/model/util/filter/TestIterables.java ! test/tools/javac/processing/options/testCommandLineClasses/Test.java ! test/tools/javac/processing/options/testPrintProcessorInfo/Test.java ! test/tools/javac/processing/options/testPrintProcessorInfo/TestWithXstdout.java ! test/tools/javac/processing/warnings/UseImplicit/TestProcUseImplicitWarning.java ! test/tools/javac/processing/werror/WError1.java ! test/tools/javac/processing/werror/WErrorGen.java ! test/tools/javac/processing/werror/WErrorLast.java ! test/tools/javac/resolve/ResolveHarness.java ! test/tools/javac/util/T6597678.java ! test/tools/javac/util/context/T7021650.java From vicente.romero at oracle.com Fri Dec 21 09:40:10 2012 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Fri, 21 Dec 2012 17:40:10 +0000 Subject: hg: jdk8/tl/langtools: 8003512: javac doesn't work with jar files with >64k entries Message-ID: <20121221174012.A48EA47340@hg.openjdk.java.net> Changeset: 189b26e3818f Author: vromero Date: 2012-12-21 15:27 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/189b26e3818f 8003512: javac doesn't work with jar files with >64k entries Reviewed-by: jjg, ksrini Contributed-by: martinrb at google.com ! src/share/classes/com/sun/tools/javac/file/ZipFileIndex.java + test/tools/javac/file/zip/8003512/LoadClassFromJava6CreatedJarTest.java ! test/tools/javac/file/zip/Utils.java From kumar.x.srinivasan at oracle.com Fri Dec 21 10:35:49 2012 From: kumar.x.srinivasan at oracle.com (Kumar Srinivasan) Date: Fri, 21 Dec 2012 10:35:49 -0800 Subject: 8003512: javac doesn't work with jar files with >64k entries In-Reply-To: <50D48767.3070808@oracle.com> References: <876df87e-c3ca-47e1-aca7-bc2714950b6d@default> <50D48767.3070808@oracle.com> Message-ID: <50D4AC05.1050503@oracle.com> Go for it!. Kumar > Looks good to me. > > -- Jon > > On 12/21/2012 01:19 PM, Vicente Arturo Romero Zaldivar wrote: >> Thanks everyone for the comments. Here you can find the final version: >> >> http://cr.openjdk.java.net/~vromero/8003512/webrev.02/ >> >> Vicente. >> >> ----- Original Message ----- >> From: martinrb at google.com >> To: vicente.romero at oracle.com >> Cc: compiler-dev at openjdk.java.net >> Sent: Thursday, 20 December, 2012 10:14:26 PM GMT +00:00 GMT Britain, >> Ireland, Portugal >> Subject: Re: 8003512: javac doesn't work with jar files with >64k entries >> >> Looks good to me. >> The one thing I might change is a jtreg design question. I wouldn't >> bother with T8003512.doTest, but simply run the test whenever the >> java6.home system property is defined. >> This means people can have scripts to RUN ALL THE TESTS without >> having to keep adding new test-specific system properties all the time. >> >> >> On Thu, Dec 20, 2012 at 7:18 AM, Vicente Arturo Romero Zaldivar >> > wrote: >> >> Hi Martin, >> >> Thanks for your comments. have generated a new webrev after them, >> here is the link for it: >> >> http://cr.openjdk.java.net/~vromero/8003512/webrev.01/ >> >> >> >> Vicente. >> >> >> ----- Original Message ----- >> From: martinrb at google.com >> To: vicente.romero at oracle.com >> Cc: compiler-dev at openjdk.java.net >> >> Sent: Thursday, 20 December, 2012 12:09:28 AM GMT +00:00 GMT >> Britain, Ireland, Portugal >> Subject: Re: 8003512: javac doesn't work with jar files with >64k >> entries >> >> Thanks for productionizing my half-baked change. >> Looks pretty good. >> The test is pretty annoying, but I think the current strategy of >> passing system properties is as good as we're going to get. >> >> + } catch (Exception ex) { >> + throw new AssertionError( >> + "The test has failed while executing this command " + command, >> + ex.getCause()); >> + } >> + >> >> I would just let executeCommand throw naturally and cause the >> test to fail. Kill the conversion to AssertionError. >> >> --- >> >> + * -javaoption:-Djava6="/path/to/jdk_or_jre6/bin/java" >> >> It's possible other tests may end up using the same mechanism to >> specify some other jdk. >> (I'm thinking cross-version serialization tests) >> Perhaps better is to specify the root of a jdk so that other >> tests might reuse it. >> Perhaps -javaoption:-Djava6.home= >> >> Martin >> >> On Wed, Dec 19, 2012 at 9:46 AM, Vicente Arturo Romero Zaldivar >> > wrote: >> >> Hi all, >> >> This is the webrev for bug (8003512: javac doesn't work with >> jar files with >64k entries): >> >> http://cr.openjdk.java.net/~vromero/8003512/webrev.00/ >> >> >> Apologies for sending a non-public link before. >> >> Vicente. >> >> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20121221/fa04c524/attachment.html From huizhe.wang at oracle.com Fri Dec 21 17:30:21 2012 From: huizhe.wang at oracle.com (huizhe.wang at oracle.com) Date: Sat, 22 Dec 2012 01:30:21 +0000 Subject: hg: jdk8/tl/jdk: 8005280: (props) Improve test coverage for small XML parser Message-ID: <20121222013044.87D3D47361@hg.openjdk.java.net> Changeset: c1227b872a12 Author: joehw Date: 2012-12-21 17:29 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c1227b872a12 8005280: (props) Improve test coverage for small XML parser Summary: added a few more invalid XML files, international characters to LoadAndStore test, and a behavior compatibility test. Reviewed-by: alanb, lancea + test/java/util/Properties/Compatibility.xml + test/java/util/Properties/CompatibilityTest.java ! test/java/util/Properties/LoadAndStoreXML.java + test/java/util/Properties/invalidxml/BadDocType.xml - test/java/util/Properties/invalidxml/BadDocType.xml.excluded + test/java/util/Properties/invalidxml/DTDRootNotMatch.xml + test/java/util/Properties/invalidxml/IllegalComment.xml + test/java/util/Properties/invalidxml/IllegalEntry.xml + test/java/util/Properties/invalidxml/IllegalEntry1.xml + test/java/util/Properties/invalidxml/IllegalKeyAttribute.xml + test/java/util/Properties/invalidxml/NoDocType.xml - test/java/util/Properties/invalidxml/NoDocType.xml.excluded + test/java/util/Properties/invalidxml/NoNamespaceSupport.xml From vicente.romero at oracle.com Sun Dec 23 10:11:21 2012 From: vicente.romero at oracle.com (Vicente Arturo Romero Zaldivar) Date: Sun, 23 Dec 2012 10:11:21 -0800 (PST) Subject: webrev 7u12 8001103 Message-ID: <4fbb2efa-2398-4689-808a-b029f785b0d8@default> Hello, This is a request to backport the JDK 8 fix into JDK 7u12: 8001103 : Javac generates duplicate name_and_type constant pool entry for class BinaryOpValueExp.java http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8001103 The fix has already been pushed to jdk8/tl/langtools, as: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/de1ec6fc93fe The id of the bug for jdk8 is 8000518 The webrev for 7u12 can be accessed here: http://cr.openjdk.java.net/~vromero/8001103/webrev.00/ Thanks, Vicente. From bhavesh.x.patel at oracle.com Tue Dec 25 17:27:38 2012 From: bhavesh.x.patel at oracle.com (bhavesh.x.patel at oracle.com) Date: Wed, 26 Dec 2012 01:27:38 +0000 Subject: hg: jdk8/tl/langtools: 8004893: the javadoc/doclet needs to be updated to accommodate lambda changes Message-ID: <20121226012742.E24CF4739F@hg.openjdk.java.net> Changeset: 690c41cdab55 Author: bpatel Date: 2012-12-25 17:23 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/690c41cdab55 8004893: the javadoc/doclet needs to be updated to accommodate lambda changes Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/resources/standard.properties ! src/share/classes/com/sun/tools/doclets/internal/toolkit/ClassWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ClassBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/doclet.xml ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/MethodTypes.java ! test/com/sun/javadoc/testHtmlTableTags/TestHtmlTableTags.java + test/com/sun/javadoc/testLambdaFeature/TestLambdaFeature.java + test/com/sun/javadoc/testLambdaFeature/pkg/A.java + test/com/sun/javadoc/testLambdaFeature/pkg/B.java ! test/com/sun/javadoc/testMethodTypes/TestMethodTypes.java From sean.mullan at oracle.com Wed Dec 26 07:44:59 2012 From: sean.mullan at oracle.com (sean.mullan at oracle.com) Date: Wed, 26 Dec 2012 15:44:59 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20121226154556.058FC473A9@hg.openjdk.java.net> Changeset: 4d28776d7007 Author: mullan Date: 2012-12-26 10:07 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4d28776d7007 8005117: Eliminate dependency from ConfigSpiFile to com.sun.security.auth.login.ConfigFile Reviewed-by: alanb, mchung, weijun ! src/share/classes/com/sun/security/auth/login/ConfigFile.java ! src/share/classes/sun/security/provider/ConfigSpiFile.java Changeset: d9cab18f326a Author: mullan Date: 2012-12-26 10:08 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d9cab18f326a Merge - make/jdk/asm/Makefile From chris.hegarty at oracle.com Thu Dec 27 13:59:01 2012 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Thu, 27 Dec 2012 21:59:01 +0000 Subject: hg: jdk8/tl/jdk: 8003981: Support Parallel Array Sorting - JEP 103 Message-ID: <20121227215929.084D9473DE@hg.openjdk.java.net> Changeset: 9d984ccd17fc Author: chegar Date: 2012-12-27 21:55 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9d984ccd17fc 8003981: Support Parallel Array Sorting - JEP 103 Reviewed-by: chegar, forax, dholmes, dl Contributed-by: david.holmes at oracle.com, dl at cs.oswego.edu, chris.hegarty at oracle.com ! make/java/java/FILES_java.gmk ! src/share/classes/java/util/Arrays.java + src/share/classes/java/util/ArraysParallelSortHelpers.java + test/java/util/Arrays/ParallelSorting.java From huizhe.wang at oracle.com Thu Dec 27 18:21:11 2012 From: huizhe.wang at oracle.com (huizhe.wang at oracle.com) Date: Fri, 28 Dec 2012 02:21:11 +0000 Subject: hg: jdk8/tl/jaxp: 8005473: Warnings compiling jaxp Message-ID: <20121228022116.28F0A473F1@hg.openjdk.java.net> Changeset: d4aea0225e80 Author: joehw Date: 2012-12-27 18:17 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/d4aea0225e80 8005473: Warnings compiling jaxp Summary: clean up compiling warnings. Reviewed-by: weijun, chegar, forax ! src/com/sun/org/apache/xalan/internal/xslt/EnvironmentCheck.java ! src/javax/xml/transform/FactoryFinder.java ! src/javax/xml/validation/SchemaFactoryFinder.java ! src/javax/xml/xpath/XPathFactoryFinder.java From masayoshi.okutsu at oracle.com Thu Dec 27 21:35:06 2012 From: masayoshi.okutsu at oracle.com (masayoshi.okutsu at oracle.com) Date: Fri, 28 Dec 2012 05:35:06 +0000 Subject: hg: jdk8/tl/jdk: 8005471: DateFormat: Time zone info is not localized when adapter is CLDR Message-ID: <20121228053527.266194740C@hg.openjdk.java.net> Changeset: 4ad38db38fff Author: okutsu Date: 2012-12-28 14:13 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4ad38db38fff 8005471: DateFormat: Time zone info is not localized when adapter is CLDR Reviewed-by: peytoia ! src/share/classes/sun/util/resources/TimeZoneNamesBundle.java + test/java/util/TimeZone/CLDRDisplayNamesTest.java From yuka.kamiya at oracle.com Thu Dec 27 22:17:06 2012 From: yuka.kamiya at oracle.com (yuka.kamiya at oracle.com) Date: Fri, 28 Dec 2012 06:17:06 +0000 Subject: hg: jdk8/tl/jdk: 8005277: Regression in JDK 7 in Bidi implementation Message-ID: <20121228061726.7F8D347415@hg.openjdk.java.net> Changeset: 1da019e7999a Author: peytoia Date: 2012-12-28 15:07 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1da019e7999a 8005277: Regression in JDK 7 in Bidi implementation Reviewed-by: okutsu ! src/share/classes/sun/text/bidi/BidiBase.java ! test/java/text/Bidi/BidiConformance.java + test/java/text/Bidi/Bug8005277.java From masayoshi.okutsu at oracle.com Thu Dec 27 23:46:32 2012 From: masayoshi.okutsu at oracle.com (masayoshi.okutsu at oracle.com) Date: Fri, 28 Dec 2012 07:46:32 +0000 Subject: hg: jdk8/tl/jdk: 8005561: typo in Calendar Message-ID: <20121228074652.4D09447416@hg.openjdk.java.net> Changeset: f3ac419e2bf0 Author: okutsu Date: 2012-12-28 16:39 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f3ac419e2bf0 8005561: typo in Calendar Reviewed-by: peytoia ! src/share/classes/java/util/Calendar.java From xuelei.fan at oracle.com Fri Dec 28 00:55:23 2012 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Fri, 28 Dec 2012 08:55:23 +0000 Subject: hg: jdk8/tl/jdk: 7109274: Restrict the use of certificates with RSA keys less than 1024 bits Message-ID: <20121228085543.B65E547419@hg.openjdk.java.net> Changeset: 645d774b683a Author: xuelei Date: 2012-12-28 00:48 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/645d774b683a 7109274: Restrict the use of certificates with RSA keys less than 1024 bits Summary: This restriction is applied via the Java Security property, "jdk.certpath.disabledAlgorithms". This will impact providers that adhere to this security property. Reviewed-by: mullan ! src/share/lib/security/java.security-linux ! src/share/lib/security/java.security-macosx ! src/share/lib/security/java.security-solaris ! src/share/lib/security/java.security-windows ! test/java/security/cert/CertPathBuilder/targetConstraints/BuildEEBasicConstraints.java ! test/java/security/cert/pkix/policyChanges/TestPolicy.java ! test/sun/security/provider/certpath/DisabledAlgorithms/CPBuilder.java ! test/sun/security/provider/certpath/DisabledAlgorithms/CPValidatorEndEntity.java ! test/sun/security/provider/certpath/DisabledAlgorithms/CPValidatorIntermediate.java ! test/sun/security/provider/certpath/DisabledAlgorithms/CPValidatorTrustAnchor.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/ClientHandshaker/RSAExport.java + test/sun/security/ssl/javax/net/ssl/TLSv12/DisabledShortRSAKeys.java ! test/sun/security/ssl/javax/net/ssl/TLSv12/ShortRSAKey512.java ! test/sun/security/tools/jarsigner/concise_jarsigner.sh From xuelei.fan at oracle.com Fri Dec 28 03:53:16 2012 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Fri, 28 Dec 2012 11:53:16 +0000 Subject: hg: jdk8/tl/jdk: 8003265: Need to clone array of input/output parameters Message-ID: <20121228115351.CAE4B4741D@hg.openjdk.java.net> Changeset: 4472a641b4dc Author: xuelei Date: 2012-12-28 03:50 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4472a641b4dc 8003265: Need to clone array of input/output parameters Reviewed-by: mullan ! src/share/classes/com/sun/jndi/dns/DnsContext.java ! src/share/classes/com/sun/jndi/ldap/BasicControl.java From shanliang.jiang at oracle.com Fri Dec 28 07:45:06 2012 From: shanliang.jiang at oracle.com (shanliang.jiang at oracle.com) Date: Fri, 28 Dec 2012 15:45:06 +0000 Subject: hg: jdk8/tl/jdk: 7120365: DiffHBTest.java fails due to ConcurrentModificationException Message-ID: <20121228154606.B349E4741F@hg.openjdk.java.net> Changeset: 46675076f753 Author: sjiang Date: 2012-12-28 16:44 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/46675076f753 7120365: DiffHBTest.java fails due to ConcurrentModificationException Summary: The problem is from the server notification forwarder, it should use a copy of listener set to do iterate. Reviewed-by: alanb ! src/share/classes/com/sun/jmx/remote/internal/ServerNotifForwarder.java ! test/ProblemList.txt + test/javax/management/remote/mandatory/notif/ConcurrentModificationTest.java From stuart.marks at oracle.com Fri Dec 28 17:35:45 2012 From: stuart.marks at oracle.com (stuart.marks at oracle.com) Date: Sat, 29 Dec 2012 01:35:45 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20121229013626.4A8414743B@hg.openjdk.java.net> Changeset: 0cfcba56cfa7 Author: jgish Date: 2012-12-28 18:32 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0cfcba56cfa7 8005594: Fix to 8003265 breaks build Summary: backout changeset 4472a641b4dc Reviewed-by: smarks, wetmore ! src/share/classes/com/sun/jndi/dns/DnsContext.java ! src/share/classes/com/sun/jndi/ldap/BasicControl.java Changeset: ac5e29b62288 Author: smarks Date: 2012-12-28 17:36 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ac5e29b62288 Merge From mandy.chung at oracle.com Fri Dec 28 22:25:45 2012 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Sat, 29 Dec 2012 06:25:45 +0000 Subject: hg: jdk8/tl: 8003562: Provide a CLI tool to analyze class dependencies Message-ID: <20121229062545.A48AB47443@hg.openjdk.java.net> Changeset: c37401e77c80 Author: mchung Date: 2012-12-28 22:20 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/c37401e77c80 8003562: Provide a CLI tool to analyze class dependencies Reviewed-by: jjg, alanb, ulfzibis, erikj ! common/bin/compare_exceptions.sh.incl From mandy.chung at oracle.com Fri Dec 28 22:27:27 2012 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Sat, 29 Dec 2012 06:27:27 +0000 Subject: hg: jdk8/tl/jdk: 8003562: Provide a CLI tool to analyze class dependencies Message-ID: <20121229062815.2274F47444@hg.openjdk.java.net> Changeset: 28b47ed08c63 Author: mchung Date: 2012-12-28 22:21 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/28b47ed08c63 8003562: Provide a CLI tool to analyze class dependencies Reviewed-by: jjg, alanb, ulfzibis, erikj ! make/common/Release.gmk ! make/docs/NON_CORE_PKGS.gmk ! make/launchers/Makefile ! make/launchers/Makefile.launcher ! makefiles/CompileLaunchers.gmk ! makefiles/CreateJars.gmk ! makefiles/Images.gmk From mandy.chung at oracle.com Fri Dec 28 22:31:06 2012 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Sat, 29 Dec 2012 06:31:06 +0000 Subject: hg: jdk8/tl/langtools: 8003562: Provide a CLI tool to analyze class dependencies Message-ID: <20121229063119.DD3B047445@hg.openjdk.java.net> Changeset: 0c244701188e Author: mchung Date: 2012-12-28 22:25 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0c244701188e 8003562: Provide a CLI tool to analyze class dependencies Reviewed-by: jjg, alanb, ulfzibis, erikj ! make/build.properties ! makefiles/BuildLangtools.gmk ! src/share/classes/com/sun/tools/classfile/Dependencies.java ! src/share/classes/com/sun/tools/classfile/Dependency.java + src/share/classes/com/sun/tools/jdeps/Archive.java + src/share/classes/com/sun/tools/jdeps/ClassFileReader.java + src/share/classes/com/sun/tools/jdeps/JdepsTask.java + src/share/classes/com/sun/tools/jdeps/Main.java + src/share/classes/com/sun/tools/jdeps/PlatformClassPath.java + src/share/classes/com/sun/tools/jdeps/resources/jdeps.properties + src/share/classes/com/sun/tools/jdeps/resources/jdk.properties + src/share/classes/com/sun/tools/jdeps/resources/version.properties-template ! test/Makefile + test/tools/jdeps/Basic.java + test/tools/jdeps/Test.java + test/tools/jdeps/p/Foo.java From chris.hegarty at oracle.com Sat Dec 29 03:01:17 2012 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Sat, 29 Dec 2012 11:01:17 +0000 Subject: hg: jdk8/tl/jdk: 8005556: java/net/Socks/SocksV4Test.java is missing @run tag Message-ID: <20121229110200.0BEA247449@hg.openjdk.java.net> Changeset: 3cc25d0e3bb0 Author: chegar Date: 2012-12-29 11:00 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3cc25d0e3bb0 8005556: java/net/Socks/SocksV4Test.java is missing @run tag Reviewed-by: alanb ! test/java/net/Socks/SocksV4Test.java From jonathan.gibbons at oracle.com Sat Dec 29 17:33:30 2012 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Sun, 30 Dec 2012 01:33:30 +0000 Subject: hg: jdk8/tl/langtools: 8004727: Add compiler support for parameter reflection Message-ID: <20121230013335.3541C47452@hg.openjdk.java.net> Changeset: 31780dd06ec7 Author: jjg Date: 2012-12-29 17:33 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/31780dd06ec7 8004727: Add compiler support for parameter reflection Reviewed-by: jjg Contributed-by: eric.mccorkle at oracle.com ! src/share/classes/com/sun/tools/classfile/Attribute.java ! src/share/classes/com/sun/tools/classfile/ClassWriter.java + src/share/classes/com/sun/tools/classfile/MethodParameters_attribute.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/main/Option.java ! src/share/classes/com/sun/tools/javac/resources/javac.properties ! src/share/classes/com/sun/tools/javac/util/Names.java ! src/share/classes/com/sun/tools/javap/AttributeWriter.java + test/tools/javac/MethodParameters.java + test/tools/javap/MethodParameters.java From jonathan.gibbons at oracle.com Sun Dec 30 06:20:43 2012 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Sun, 30 Dec 2012 14:20:43 +0000 Subject: hg: jdk8/tl/langtools: 8005195: Doclint regression tests fail on windows Message-ID: <20121230142048.B011E4745A@hg.openjdk.java.net> Changeset: 383bc0fbd759 Author: jjg Date: 2012-12-30 06:17 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/383bc0fbd759 8005195: Doclint regression tests fail on windows Reviewed-by: mcimadamore ! test/tools/doclint/DocLintTester.java