Review request for JDK-8004727

[Kumar Srinivasan]

Looks good!

  minor nits, Copyright incorrect in:
     Attribute.java, ClassWriter.java and others.....

ClassWriter.java

+        }
+        else
+            return 0;

other places in the file the convention is

} else
     return 0;


Kumar

> Hello,
>
> Please review the implementation of the javac side of method parameter
> reflection.  The feature request can be found here:
>
> http://bugs.sun.com/view_bug.do?bug_id=8004727
>
> Summary:
>
> The names, as well as other information about method parameters can now
> optionally be stored in Java class files.  There are updates to javac to
> create the parameter attributes when a -parameters flag is given.  There
> are also updates to the com.sun.tools.classfile API to correctly parse
> method parameter attributes, and to javap to print them.
>
> This code includes new tests, and has been tested by running numerous
> regression test suites, including some with javac hardwired to generate
> class files with parameter annotations.
>
>
> The open webrev can be found here:
>
> http://cr.openjdk.java.net/~coleenp/JDK-8004727/
>
>
> The specification for Method Parameter reflection can be found here:
>
> http://cr.openjdk.java.net/~abuckley/8misc.pdf
>
> Thanks,
> Eric