8003512: javac doesn't work with jar files with >64k entries

[Jonathan Gibbons]

This is a good suggestion, but does open up the discussion of standard 
naming for properties. java6.home is OK for now, but we might want to 
consider a context (faq, tag spec etc) to define standard properties or 
env variables like this.

-- Jon

On 12/20/2012 10:14 PM, Martin Buchholz wrote:
> Looks good to me.
> The one thing I might change is a jtreg design question.  I wouldn't 
> bother with T8003512.doTest, but simply run the test whenever the 
> java6.home system property is defined.
> This means people can have scripts to RUN ALL THE TESTS without having 
> to keep adding new test-specific system properties all the time.
>
>
> On Thu, Dec 20, 2012 at 7:18 AM, Vicente Arturo Romero Zaldivar 
> <vicente.romero at oracle.com <mailto:vicente.romero at oracle.com>> wrote:
>
>     Hi Martin,
>
>     Thanks for your comments. have generated a new webrev after them,
>     here is the link for it:
>
>     http://cr.openjdk.java.net/~vromero/8003512/webrev.01/
>     <http://cr.openjdk.java.net/%7Evromero/8003512/webrev.01/>
>
>
>     Vicente.
>
>
>     ----- Original Message -----
>     From: martinrb at google.com <mailto:martinrb at google.com>
>     To: vicente.romero at oracle.com <mailto:vicente.romero at oracle.com>
>     Cc: compiler-dev at openjdk.java.net
>     <mailto:compiler-dev at openjdk.java.net>
>     Sent: Thursday, 20 December, 2012 12:09:28 AM GMT +00:00 GMT
>     Britain, Ireland, Portugal
>     Subject: Re: 8003512: javac doesn't work with jar files with >64k
>     entries
>
>     Thanks for productionizing my half-baked change.
>     Looks pretty good.
>     The test is pretty annoying, but I think the current strategy of
>     passing system properties is as good as we're going to get.
>
>     +        } catch (Exception ex) {
>     +            throw new AssertionError(
>     +                "The test has failed while executing this command " + command,
>     +                ex.getCause());
>     +        }
>     +
>
>     I would just let executeCommand throw naturally and cause the test
>     to fail.  Kill the conversion to AssertionError.
>
>     ---
>
>     + * -javaoption:-Djava6="/path/to/jdk_or_jre6/bin/java"
>
>     It's possible other tests may end up using the same mechanism to
>     specify some other jdk.
>     (I'm thinking cross-version serialization tests)
>     Perhaps better is to specify the root of a jdk so that other tests
>     might reuse it.
>     Perhaps -javaoption:-Djava6.home=
>
>     Martin
>
>     On Wed, Dec 19, 2012 at 9:46 AM, Vicente Arturo Romero Zaldivar
>     <vicente.romero at oracle.com <mailto:vicente.romero at oracle.com>> wrote:
>
>         Hi all,
>
>         This is the webrev for bug (8003512: javac doesn't work with
>         jar files with >64k entries):
>
>         http://cr.openjdk.java.net/~vromero/8003512/webrev.00/
>         <http://cr.openjdk.java.net/%7Evromero/8003512/webrev.00/>
>
>         Apologies for sending a non-public link before.
>
>         Vicente.
>
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20121220/9d98de9e/attachment.html