RFR [JDK8]: 7153951: -Xlint:auxiliaryclass

Remi Forax forax at univ-mlv.fr
Wed Oct 17 05:32:32 PDT 2012


On 10/17/2012 12:44 PM, Fredrik Öhrström wrote:
> 17 okt 2012 kl. 12:22 skrev Remi Forax:
>> Fredrik,
>> I still think that the code in ClassReader should not suppose that the class name ends with .java,
>> to support classes generated by other languages than Java.
>>
>> Rémi
>>
>
> Interesting Remi, you said the exact opposite here:
>
>     Sep 20, 2012 8:00:25 am
>     "I maybe wrong but the code proposed by Fredrik in ClassReader will flag all classes
>      that are not issued from a .java file as auxiliary classes.
>     At least, a class with a filename that doesn't end with '.java' should
>     not be tagged as auxiliary."
>
> I believe you were right the first time, so I changed the code only to warn
> about auxiliary classes when the auxiliary class was generated from a Java source.

duh, sorry, read the code too fast.
I was thinking that javac could support other languages but I'm fine 
with the current change.

>
> Other languages, if they experience this problem, can surely implement a similar
> warning in their own compilers.

yes, right.
so I'm ok with the proposed patch.

>
> //Fredrik
>
>

Rémi






More information about the compiler-dev mailing list