RFR: Make -target 8 in javac generate version 52.0 classfile

Jonathan Gibbons jonathan.gibbons at oracle.com
Tue Oct 30 13:33:05 PDT 2012


Looks good to me.

I'd suggest a blank line between lines 80, 81

-- Jon

On 10/29/2012 09:20 AM, Kumar Srinivasan wrote:
> Hi J&J,
>
> * Fixed comment in Target.java
> * Added Bug-id to the relevant tests
> * Updated CR in test.sh and adjusted test.sh to test all
>   possible and valid combinations for source and target
>
> Webrev:
> http://cr.openjdk.java.net/~ksrini/8001112/webrev.1/
>
> For changes since the last reviewed version:
> http://cr.openjdk.java.net/~ksrini/8001112/webrev.1/webrev.delta/index.html 
>
>
> Thanks
> Kumar
>
>
>
>> Hello Jon, et. al.,
>>
>> This is the change to increment class files major number
>> generated by  javac, in preparation for the incoming JSRs.
>>
>> http://cr.openjdk.java.net/~ksrini/8001112/webrev.0/
>>
>> check.sh contains a set -x, I can rip it out if you think I must.
>>
>> Thanks
>> Kumar
>>
>




More information about the compiler-dev mailing list