From vicente.romero at oracle.com Thu Aug 1 02:16:34 2013 From: vicente.romero at oracle.com (Vicente-Arturo Romero-Zaldivar) Date: Thu, 01 Aug 2013 10:16:34 +0100 Subject: javac generates unverifiable initializer for nested subclass of local class. In-Reply-To: References: Message-ID: <51FA2772.1070602@oracle.com> Hi Jeremy, Thanks for the report, I filed the following bug entry to track this issue: JDK-8022053: a bad type on operand stack exception is generated at execution time for simple code Vicente On 01/08/13 07:36, Jeremy Manson wrote: > Hi folks, > > I mentioned to a couple of people on the list that we have a some > unreported bugs. In an effort to be better about reporting them, I'll > mention this oldie but goodie that dates back to JDK 6 update 4. > > (I have to verify that each of them is still a bug, so this might be a > trickle rather than a flood) > > public class TestTest { > public static void main(final String args[]) { > class NamedLocal { > Object m() { > return args; > } > > class NamedLocalSub extends NamedLocal {} > } > new NamedLocal().new NamedLocalSub(); > } > } > > With JDK8 b84: > > $ javac TestTest.java > $ java TestTest > Exception in thread "main" java.lang.VerifyError: Bad type on operand > stack > Exception Details: > Location: > TestTest$1NamedLocal$NamedLocalSub.(LTestTest$1NamedLocal;)V @7: > getfield > Reason: > Type uninitializedThis (current frame, stack[1]) is not assignable to > 'TestTest$1NamedLocal$NamedLocalSub' > Current Frame: > bci: @7 > flags: { flagThisUninit } > locals: { uninitializedThis, 'TestTest$1NamedLocal' } > stack: { uninitializedThis, uninitializedThis } > Bytecode: > 0000000: 2a2b b500 012a 2ab4 0002 b700 03b1 > > at TestTest.main(TestTest.java:10) > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20130801/d07d715a/attachment.html From chris.hegarty at oracle.com Thu Aug 1 04:38:33 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Thu, 01 Aug 2013 11:38:33 +0000 Subject: hg: jdk8/tl/jdk: 8022061: More ProblemList.txt updates (7/2013) Message-ID: <20130801113906.30C9B484F7@hg.openjdk.java.net> Changeset: c49b538ef054 Author: chegar Date: 2013-08-01 12:38 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c49b538ef054 8022061: More ProblemList.txt updates (7/2013) Reviewed-by: alanb, psandoz ! test/ProblemList.txt From dmitry.degrave at oracle.com Thu Aug 1 05:59:17 2013 From: dmitry.degrave at oracle.com (dmitry.degrave at oracle.com) Date: Thu, 01 Aug 2013 12:59:17 +0000 Subject: hg: jdk8/tl/corba: 8015987: The corba repo contains unneeded .sjava files Message-ID: <20130801125918.9222C48507@hg.openjdk.java.net> Changeset: cc11a0efb4f9 Author: aefimov Date: 2013-08-01 14:59 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/cc11a0efb4f9 8015987: The corba repo contains unneeded .sjava files Reviewed-by: alanb, chegar, coffeys - src/share/classes/com/sun/corba/se/impl/copyobject/JavaInputStream.sjava - src/share/classes/com/sun/corba/se/impl/copyobject/JavaOutputStream.sjava - src/share/classes/com/sun/corba/se/impl/interceptors/ThreadCurrentStack.sjava - src/share/classes/com/sun/corba/se/impl/orbutil/DefineWrapper.sjava - src/share/classes/com/sun/corba/se/impl/presentation/rmi/IDLNameTranslatorImpl_save.sjava - src/share/classes/com/sun/corba/se/impl/presentation/rmi/IDLTypesUtil_save.sjava - src/share/classes/com/sun/corba/se/impl/protocol/oldlocal/LocalClientRequestImpl.sjava - src/share/classes/com/sun/corba/se/impl/protocol/oldlocal/LocalClientResponseImpl.sjava - src/share/classes/com/sun/corba/se/impl/protocol/oldlocal/LocalServerRequestImpl.sjava - src/share/classes/com/sun/corba/se/impl/protocol/oldlocal/LocalServerResponseImpl.sjava - src/share/classes/com/sun/corba/se/impl/transport/BufferConnectionImpl.sjava From dmitry.degrave at oracle.com Thu Aug 1 07:20:44 2013 From: dmitry.degrave at oracle.com (dmitry.degrave at oracle.com) Date: Thu, 01 Aug 2013 14:20:44 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20130801142116.CDC4A4850C@hg.openjdk.java.net> Changeset: 36f4cf8872f3 Author: igerasim Date: 2013-07-30 21:11 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/36f4cf8872f3 7192942: (coll) Inefficient calculation of power of two in HashMap Reviewed-by: mduigou ! src/share/classes/java/util/HashMap.java Changeset: 54329c24c2f4 Author: igerasim Date: 2013-07-29 12:35 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/54329c24c2f4 8020669: (fs) Files.readAllBytes() does not read any data when Files.size() is 0 Reviewed-by: alanb, chegar, martin, rriggs ! src/share/classes/java/nio/file/Files.java ! test/java/nio/file/Files/BytesAndLines.java From xuelei.fan at oracle.com Thu Aug 1 07:35:37 2013 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Thu, 01 Aug 2013 14:35:37 +0000 Subject: hg: jdk8/tl/jdk: 7127524: P11TlsPrfGenerator has anonymous inner class with serialVersionUID Message-ID: <20130801143551.326ED4850E@hg.openjdk.java.net> Changeset: d6de149b9f20 Author: xuelei Date: 2013-08-01 07:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d6de149b9f20 7127524: P11TlsPrfGenerator has anonymous inner class with serialVersionUID Reviewed-by: vinnie ! src/share/classes/sun/security/pkcs11/P11TlsPrfGenerator.java From chris.hegarty at oracle.com Thu Aug 1 08:54:13 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Thu, 01 Aug 2013 15:54:13 +0000 Subject: hg: jdk8/tl/jdk: 8022087: Fix doclint issues in j.u.Deque & Queue Message-ID: <20130801155429.B1FE048510@hg.openjdk.java.net> Changeset: cd13a4a45a37 Author: chegar Date: 2013-08-01 16:53 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cd13a4a45a37 8022087: Fix doclint issues in j.u.Deque & Queue Reviewed-by: chegar, darcy Contributed-by: Doug Lea
! src/share/classes/java/util/Deque.java ! src/share/classes/java/util/Queue.java From jeremymanson at google.com Thu Aug 1 10:12:33 2013 From: jeremymanson at google.com (Jeremy Manson) Date: Thu, 1 Aug 2013 10:12:33 -0700 Subject: Double-semicolon in import statements Message-ID: Hi folks, Another one that came up was that javac allows an empty statement between import statements. This doesn't *seem* to be allowed by the JLS's grammar (JLS 7.5), so it should probably either be clarified in the JLS or fixed. Example: import java.util.HashMap;; public class Semicolon { public static void main(String[] args) { System.out.println("This program should not compile"); } } compiles. Jeremy -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20130801/8cb2fd3d/attachment-0001.html From alex.buckley at oracle.com Thu Aug 1 10:49:07 2013 From: alex.buckley at oracle.com (Alex Buckley) Date: Thu, 01 Aug 2013 10:49:07 -0700 Subject: Double-semicolon in import statements In-Reply-To: References: Message-ID: <51FA9F93.8010506@oracle.com> Hi Jeremy, ; is a valid TypeDeclaration in JLS 7.6. Since TypeDeclaration's follow ImportDeclaration's in CompilationUnit in JLS 7.3, it is legal to have a ; immediately after the ; of the import declaration. The rationale for ; being a TypeDeclaration is found in the JLS First Edition but was removed in the Second Edition. Here we are, 13 years after the Second Edition was published, and the ; is causing confusion. This shows that language design is _forever_. I will add the rationale back into the JLS. Alex On 8/1/2013 10:12 AM, Jeremy Manson wrote: > Hi folks, > > Another one that came up was that javac allows an empty statement > between import statements. This doesn't *seem* to be allowed by the > JLS's grammar (JLS 7.5), so it should probably either be clarified in > the JLS or fixed. Example: > > import java.util.HashMap;; > > public class Semicolon { > public static void main(String[] args) { > System.out.println("This program should not compile"); > } > } > > compiles. > > Jeremy From vicente.romero at oracle.com Thu Aug 1 10:57:40 2013 From: vicente.romero at oracle.com (Vicente-Arturo Romero-Zaldivar) Date: Thu, 01 Aug 2013 18:57:40 +0100 Subject: about bug: 8020216: Compile time error isn't shown when final class variable is not assigned In-Reply-To: <51FA9FFD.8050701@oracle.com> References: <51F7CC00.2010000@oracle.com> <51FA9FFD.8050701@oracle.com> Message-ID: <51FAA194.3060005@oracle.com> Hi Alex, Regarding the mentioned bug entry, I have a patch that solves the issue but then I have the following example taken from javac code: private final TreePath treePath; private final DocCommentTree docComment; private final DocTreePath parent; public DocTreePath(DocTreePath p, DocTree t) { if (t.getKind() == DocTree.Kind.DOC_COMMENT) { throw new IllegalArgumentException("Use DocTreePath(TreePath, DocCommentTree) to construct DocTreePath for a DocCommentTree."); } else { treePath = p.treePath; docComment = p.docComment; parent = p; } leaf = t; } with the patch javac says: error: variable treePath might not have been initialized error: variable docComment might not have been initialized error: variable parent might not have been initialized so this means that whenever we have such a code we will have to do: if (t.getKind() == DocTree.Kind.DOC_COMMENT) { treePath = null; docComment = null; parent = null; throw new IllegalArgumentException("Use DocTreePath(TreePath, DocCommentTree) to construct DocTreePath for a DocCommentTree."); } else { another option is to set the fields to null at the end of the method. Is this what we want? I think the current state of flow analysis is preferable but I wanted to double check before going on. Thanks, Vicente From adomurad at redhat.com Thu Aug 1 12:34:57 2013 From: adomurad at redhat.com (Adam Domurad) Date: Thu, 01 Aug 2013 15:34:57 -0400 Subject: Request for comments, very slow compilation with super-overloaded methods In-Reply-To: <51A77ECA.80004@oracle.com> References: <51A6526D.7080006@redhat.com> <51A71024.9090700@oracle.com> <51A77C37.6070806@redhat.com> <51A77ECA.80004@oracle.com> Message-ID: <51FAB861.50709@redhat.com> On 05/30/2013 12:31 PM, Maurizio Cimadamore wrote: > On 30/05/13 17:20, Adam Domurad wrote: >> On 05/30/2013 04:39 AM, Maurizio Cimadamore wrote: >>> Thanks for the report (and the patch) - we will file a bug on this. I >>> believe the solution for this is to maintain a fixed-size heap of >>> candidate; this stuff is mostly there for generating better overload >>> diagnostics; but in the case you have 255 candidates, I doubt you >>> want to see them all ;-) >> >> Thank you! Ah, yes that sounds reasonable. I suppose even if they >> could quickly be determined to not be equal because of parameter >> length, there would still exist some possibility with many same-name >> same-argument-count methods. >> >> Out of curiousity though, I do wonder why a custom singly-linked list >> is used everywhere. Can anyone explain this design choice ? I don't >> see where they would help performance over standard eg ArrayList. > The linked list version used by javac is permanent and immutable. This > means that all operations on the list will create a new list (bit like > String) and, even more importantly, adding new nodes will keep old list > around. ArrayList has two disadvantages: is mutable - meaning that you > can end up with very weird behavior if some compiler component > accidentally overwrites some list element; it is also, on average, > always half empty - which is also suboptimal for the particular use case > of the compiler (which is only working with very small lists). > > The VM is actually very good at optimizing permanent immutable data > structures, so this turns out to be a biggie win in JIT too. > > All experiments we made internally to replace our 'good old' linked list > implementation with some fancier data structures led to no gain > (actually, in most case a performance regression was observed). > > That said, there are things that we dislike about current implemenation: > > *) calling relatively harmless operation such as 'length' has complexity > O(n) > *) very bad append performances (O(n)) meaning that it's usually better > to to prepends and to work with a 'reversed' list, which isn't very > intuitive. > > We would like to revisit this core data structure in the future, and we > have some options on the table - ArrayList is not one of them ;-) > > Thanks > Maurizio >> >> Thanks for filing the bug. >> >> Happy hacking, >> -Adam >> >>> >>> Maurizio >>> >>> On 29/05/13 20:09, Adam Domurad wrote: >>>> Hi, see attached sources.zip containing ArrayUtil.java & >>>> MethodHandle.java, taken from Groovy sourcecode. >>>> They exhibit a case with which javac performs very badly. >>>> >>>> Try >>>> javac ArrayUtil.java #Not too bad >>>> javac MethodHandle.java # But this takes many minutes >>>> >>>> Note that MethodHandle references ArrayUtil, and this is >>>> auto-generated code. >>>> >>>> ECJ compiles this source code in ~4 seconds. >>>> >>>> This problem is present in JDK8 and JDK7. >>>> >>>> - The performance problem stems from >>>> com.sun.tools.javac.comp.Resolve.InapplicableSymbolsError.Candidate#equals. >>>> This is used during method resolution, and is performed O(n^2) times >>>> for 'n' same-name methods. It references rather expensive methods >>>> that iterate over and potentially copy (eg for erasure) both >>>> argument lists, which can be up to 255 elements in this case. >>>> - MethodHandle references a method from ArrayUtil that has 255 >>>> candidates; this is many orders of magnitude slower than it should be. >>>> >>>> I have attached a patch that does a hackish fix, by providing a fast >>>> route for when method is obviously not a sub-signature of another. >>>> The patch is mainly there as a proof-of-concept (its rather slapped >>>> on), hopefully someone knows a better way to fix these corner cases? >>>> >>>> I am rather dubious about argument lists pervasively being treated >>>> as singly-linked lists. It makes certain operations quite costly, >>>> even changing the complexity of them unfavourably. >>>> >>>> Happy hacking, >>>> -Adam >>>> >>> >> > Any progress on this bug ? Any bug ID ? Thanks, -Adam From jeremymanson at google.com Thu Aug 1 12:59:06 2013 From: jeremymanson at google.com (Jeremy Manson) Date: Thu, 1 Aug 2013 12:59:06 -0700 Subject: Double-semicolon in import statements In-Reply-To: <51FA9F93.8010506@oracle.com> References: <51FA9F93.8010506@oracle.com> Message-ID: Alex, What about the following, which also compiles? Can you have ImportDeclaration TypeDeclaration ImportDeclaration? import java.util.HashMap;; import java.util.LinkedList; public class Semicolon { public static void main(String[] args) { System.out.println("This program should not compile"); } } -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20130801/0ac4d727/attachment.html From paul.sandoz at oracle.com Thu Aug 1 14:07:32 2013 From: paul.sandoz at oracle.com (paul.sandoz at oracle.com) Date: Thu, 01 Aug 2013 21:07:32 +0000 Subject: hg: jdk8/tl/jdk: 8020016: Numerous splitereator impls do not throw NPE for null Consumers Message-ID: <20130801210757.ADA8748544@hg.openjdk.java.net> Changeset: 0be7839d4599 Author: psandoz Date: 2013-08-01 15:28 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0be7839d4599 8020016: Numerous splitereator impls do not throw NPE for null Consumers Reviewed-by: mduigou, alanb, henryjen ! src/share/classes/java/util/stream/SpinedBuffer.java ! src/share/classes/java/util/stream/StreamSpliterators.java ! src/share/classes/java/util/stream/Streams.java ! test/java/util/Spliterator/SpliteratorTraversingAndSplittingTest.java ! test/java/util/stream/bootlib/java/util/stream/SpliteratorTestHelper.java From weijun.wang at oracle.com Thu Aug 1 18:17:36 2013 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Fri, 02 Aug 2013 01:17:36 +0000 Subject: hg: jdk8/tl/jdk: 8021789: jarsigner parses alias as command line option (depending on locale) Message-ID: <20130802011827.507EE48551@hg.openjdk.java.net> Changeset: 29f153e11683 Author: weijun Date: 2013-08-02 08:59 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/29f153e11683 8021789: jarsigner parses alias as command line option (depending on locale) Reviewed-by: vinnie ! src/share/classes/sun/security/tools/jarsigner/Main.java + test/sun/security/tools/jarsigner/collator.sh From vicente.romero at oracle.com Fri Aug 2 02:40:52 2013 From: vicente.romero at oracle.com (Vicente-Arturo Romero-Zaldivar) Date: Fri, 02 Aug 2013 10:40:52 +0100 Subject: Request for comments, very slow compilation with super-overloaded methods In-Reply-To: <51FAB861.50709@redhat.com> References: <51A6526D.7080006@redhat.com> <51A71024.9090700@oracle.com> <51A77C37.6070806@redhat.com> <51A77ECA.80004@oracle.com> <51FAB861.50709@redhat.com> Message-ID: <51FB7EA4.4050005@oracle.com> Hi Adam, The bug has been solved and pushed into JDK 7 mainstream. bug id: JDK-8015668: overload resolution: performance regression in JDK 7 the changeset is accessible here: http://hg.openjdk.java.net/jdk7u/jdk7u40-dev/langtools/rev/06285eb8d755 Sorry for the late update. Vicente. On 01/08/13 20:34, Adam Domurad wrote: > On 05/30/2013 12:31 PM, Maurizio Cimadamore wrote: >> On 30/05/13 17:20, Adam Domurad wrote: >>> On 05/30/2013 04:39 AM, Maurizio Cimadamore wrote: >>>> Thanks for the report (and the patch) - we will file a bug on this. I >>>> believe the solution for this is to maintain a fixed-size heap of >>>> candidate; this stuff is mostly there for generating better overload >>>> diagnostics; but in the case you have 255 candidates, I doubt you >>>> want to see them all ;-) >>> >>> Thank you! Ah, yes that sounds reasonable. I suppose even if they >>> could quickly be determined to not be equal because of parameter >>> length, there would still exist some possibility with many same-name >>> same-argument-count methods. >>> >>> Out of curiousity though, I do wonder why a custom singly-linked list >>> is used everywhere. Can anyone explain this design choice ? I don't >>> see where they would help performance over standard eg ArrayList. >> The linked list version used by javac is permanent and immutable. This >> means that all operations on the list will create a new list (bit like >> String) and, even more importantly, adding new nodes will keep old list >> around. ArrayList has two disadvantages: is mutable - meaning that you >> can end up with very weird behavior if some compiler component >> accidentally overwrites some list element; it is also, on average, >> always half empty - which is also suboptimal for the particular use case >> of the compiler (which is only working with very small lists). >> >> The VM is actually very good at optimizing permanent immutable data >> structures, so this turns out to be a biggie win in JIT too. >> >> All experiments we made internally to replace our 'good old' linked list >> implementation with some fancier data structures led to no gain >> (actually, in most case a performance regression was observed). >> >> That said, there are things that we dislike about current implemenation: >> >> *) calling relatively harmless operation such as 'length' has complexity >> O(n) >> *) very bad append performances (O(n)) meaning that it's usually better >> to to prepends and to work with a 'reversed' list, which isn't very >> intuitive. >> >> We would like to revisit this core data structure in the future, and we >> have some options on the table - ArrayList is not one of them ;-) >> >> Thanks >> Maurizio >>> >>> Thanks for filing the bug. >>> >>> Happy hacking, >>> -Adam >>> >>>> >>>> Maurizio >>>> >>>> On 29/05/13 20:09, Adam Domurad wrote: >>>>> Hi, see attached sources.zip containing ArrayUtil.java & >>>>> MethodHandle.java, taken from Groovy sourcecode. >>>>> They exhibit a case with which javac performs very badly. >>>>> >>>>> Try >>>>> javac ArrayUtil.java #Not too bad >>>>> javac MethodHandle.java # But this takes many minutes >>>>> >>>>> Note that MethodHandle references ArrayUtil, and this is >>>>> auto-generated code. >>>>> >>>>> ECJ compiles this source code in ~4 seconds. >>>>> >>>>> This problem is present in JDK8 and JDK7. >>>>> >>>>> - The performance problem stems from >>>>> com.sun.tools.javac.comp.Resolve.InapplicableSymbolsError.Candidate#equals. >>>>> >>>>> This is used during method resolution, and is performed O(n^2) times >>>>> for 'n' same-name methods. It references rather expensive methods >>>>> that iterate over and potentially copy (eg for erasure) both >>>>> argument lists, which can be up to 255 elements in this case. >>>>> - MethodHandle references a method from ArrayUtil that has 255 >>>>> candidates; this is many orders of magnitude slower than it should >>>>> be. >>>>> >>>>> I have attached a patch that does a hackish fix, by providing a fast >>>>> route for when method is obviously not a sub-signature of another. >>>>> The patch is mainly there as a proof-of-concept (its rather slapped >>>>> on), hopefully someone knows a better way to fix these corner cases? >>>>> >>>>> I am rather dubious about argument lists pervasively being treated >>>>> as singly-linked lists. It makes certain operations quite costly, >>>>> even changing the complexity of them unfavourably. >>>>> >>>>> Happy hacking, >>>>> -Adam >>>>> >>>> >>> >> > > Any progress on this bug ? Any bug ID ? > > Thanks, > -Adam From alexey.utkin at oracle.com Fri Aug 2 02:20:40 2013 From: alexey.utkin at oracle.com (alexey.utkin at oracle.com) Date: Fri, 02 Aug 2013 09:20:40 +0000 Subject: hg: jdk8/tl/jdk: 8020191: System.getProperty("os.name") returns "Windows NT (unknown)" on Windows 8.1 Message-ID: <20130802092154.E615B48565@hg.openjdk.java.net> Changeset: 40221b09812f Author: uta Date: 2013-08-02 13:16 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/40221b09812f 8020191: System.getProperty("os.name") returns "Windows NT (unknown)" on Windows 8.1 Reviewed-by: alanb, khazra, chegar ! src/windows/native/java/lang/java_props_md.c ! src/windows/resource/java.manifest From chris.hegarty at oracle.com Fri Aug 2 03:25:17 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Fri, 02 Aug 2013 10:25:17 +0000 Subject: hg: jdk8/tl/jdk: 8022121: Remove superfluous @test tag from SpliteratorTraversingAndSplittingTest Message-ID: <20130802102548.A0C5D48569@hg.openjdk.java.net> Changeset: 60c275e56a69 Author: chegar Date: 2013-08-02 11:25 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/60c275e56a69 8022121: Remove superfluous @test tag from SpliteratorTraversingAndSplittingTest Reviewed-by: psandoz ! test/java/util/Spliterator/SpliteratorTraversingAndSplittingTest.java From chris.hegarty at oracle.com Fri Aug 2 06:30:49 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Fri, 02 Aug 2013 13:30:49 +0000 Subject: hg: jdk8/tl/jdk: 8020291: j.u.c.CompletionStage; ... Message-ID: <20130802133116.5F3184856D@hg.openjdk.java.net> Changeset: 6ec910ff3ea1 Author: chegar Date: 2013-08-02 14:29 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6ec910ff3ea1 8020291: j.u.c.CompletionStage 8020435: CompletableFuture/Basic.java fails on single core machine Reviewed-by: chegar, psandoz Contributed-by: Doug Lea
! src/share/classes/java/util/concurrent/CompletableFuture.java + src/share/classes/java/util/concurrent/CompletionStage.java ! test/ProblemList.txt ! test/java/util/concurrent/CompletableFuture/Basic.java From sean.mullan at oracle.com Fri Aug 2 06:39:43 2013 From: sean.mullan at oracle.com (sean.mullan at oracle.com) Date: Fri, 02 Aug 2013 13:39:43 +0000 Subject: hg: jdk8/tl/jdk: 3 new changesets Message-ID: <20130802134021.928284856E@hg.openjdk.java.net> Changeset: 42b786f2fb99 Author: mullan Date: 2013-08-02 08:30 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/42b786f2fb99 8001319: Add SecurityPermission "insertProvider" target name Reviewed-by: vinnie ! src/share/classes/java/security/Security.java ! src/share/classes/java/security/SecurityPermission.java + test/java/security/Security/AddProvider.java + test/java/security/Security/AddProvider.policy.1 + test/java/security/Security/AddProvider.policy.2 + test/java/security/Security/AddProvider.policy.3 Changeset: 7bbc6c2351d7 Author: mullan Date: 2013-08-02 08:37 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7bbc6c2351d7 Merge - src/share/classes/java/net/package.html - src/share/classes/java/util/stream/StreamBuilder.java - src/share/classes/javax/security/auth/callback/package.html - src/share/classes/javax/security/auth/kerberos/package.html - src/share/classes/javax/security/auth/login/package.html - src/share/classes/javax/security/auth/package.html - src/share/classes/javax/security/auth/spi/package.html - src/share/classes/javax/security/auth/x500/package.html - src/share/classes/javax/security/cert/package.html - src/share/classes/javax/security/sasl/package.html - test/java/util/Collections/EmptySortedSet.java Changeset: 0a778e487a73 Author: mullan Date: 2013-08-02 09:38 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0a778e487a73 Merge From alex.buckley at oracle.com Fri Aug 2 09:57:07 2013 From: alex.buckley at oracle.com (Alex Buckley) Date: Fri, 02 Aug 2013 09:57:07 -0700 Subject: Double-semicolon in import statements In-Reply-To: References: <51FA9F93.8010506@oracle.com> Message-ID: <51FBE4E3.8090808@oracle.com> Nope, the production is: CompilationUnit: PackageDeclarationopt ImportDeclarationsopt TypeDeclarationsopt So that's a javac bug. (And a reason for minimizing undue flexibility in the language in the first place.) Alex On 8/1/2013 12:59 PM, Jeremy Manson wrote: > Alex, > > What about the following, which also compiles? Can you > have ImportDeclaration TypeDeclaration ImportDeclaration? > > import java.util.HashMap;; > import java.util.LinkedList; > > public class Semicolon { > public static void main(String[] args) { > System.out.println("This program should not compile"); > } > } > From jhs at edg.com Fri Aug 2 10:25:28 2013 From: jhs at edg.com (John Spicer) Date: Fri, 2 Aug 2013 13:25:28 -0400 Subject: Double-semicolon in import statements In-Reply-To: <51FBE4E3.8090808@oracle.com> References: <51FA9F93.8010506@oracle.com> <51FBE4E3.8090808@oracle.com> Message-ID: <2064E555-3CC2-4625-8267-0B4868E5BE0C@edg.com> On Aug 2, 2013, at 12:57 PM, Alex Buckley wrote: > Nope, the production is: > > CompilationUnit: > PackageDeclarationopt ImportDeclarationsopt TypeDeclarationsopt > > So that's a javac bug. (And a reason for minimizing undue flexibility in the language in the first place.) I'm generally happier to ban things like extra semicolons, but it seems to me that "import x.y;;" should be allowed regardless of what follows. FWIW, out front end does give the appropriate error, the rules just seem odd to me. John. > > Alex > > On 8/1/2013 12:59 PM, Jeremy Manson wrote: >> Alex, >> >> What about the following, which also compiles? Can you >> have ImportDeclaration TypeDeclaration ImportDeclaration? >> >> import java.util.HashMap;; >> import java.util.LinkedList; >> >> public class Semicolon { >> public static void main(String[] args) { >> System.out.println("This program should not compile"); >> } >> } >> From jeremymanson at google.com Fri Aug 2 11:36:49 2013 From: jeremymanson at google.com (Jeremy Manson) Date: Fri, 2 Aug 2013 11:36:49 -0700 Subject: Double-semicolon in import statements In-Reply-To: <2064E555-3CC2-4625-8267-0B4868E5BE0C@edg.com> References: <51FA9F93.8010506@oracle.com> <51FBE4E3.8090808@oracle.com> <2064E555-3CC2-4625-8267-0B4868E5BE0C@edg.com> Message-ID: Just out of my own curiosity, who decides whether to change the spec or javac? Jeremy On Fri, Aug 2, 2013 at 10:25 AM, John Spicer wrote: > > On Aug 2, 2013, at 12:57 PM, Alex Buckley wrote: > > > Nope, the production is: > > > > CompilationUnit: > > PackageDeclarationopt ImportDeclarationsopt TypeDeclarationsopt > > > > So that's a javac bug. (And a reason for minimizing undue flexibility in > the language in the first place.) > > I'm generally happier to ban things like extra semicolons, but it seems to > me that "import x.y;;" should be allowed regardless of what follows. > > FWIW, out front end does give the appropriate error, the rules just seem > odd to me. > > John. > > > > > Alex > > > > On 8/1/2013 12:59 PM, Jeremy Manson wrote: > >> Alex, > >> > >> What about the following, which also compiles? Can you > >> have ImportDeclaration TypeDeclaration ImportDeclaration? > >> > >> import java.util.HashMap;; > >> import java.util.LinkedList; > >> > >> public class Semicolon { > >> public static void main(String[] args) { > >> System.out.println("This program should not compile"); > >> } > >> } > >> > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20130802/138a338d/attachment.html From jonathan.gibbons at oracle.com Fri Aug 2 13:45:18 2013 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Fri, 02 Aug 2013 13:45:18 -0700 Subject: Double-semicolon in import statements In-Reply-To: References: <51FA9F93.8010506@oracle.com> <51FBE4E3.8090808@oracle.com> <2064E555-3CC2-4625-8267-0B4868E5BE0C@edg.com> Message-ID: <51FC1A5E.4070003@oracle.com> In general, it is better/simpler to change javac to conform to the spec. (Except when it is not.) -- Jon On 08/02/2013 11:36 AM, Jeremy Manson wrote: > Just out of my own curiosity, who decides whether to change the spec > or javac? > > Jeremy > > > On Fri, Aug 2, 2013 at 10:25 AM, John Spicer > wrote: > > > On Aug 2, 2013, at 12:57 PM, Alex Buckley > wrote: > > > Nope, the production is: > > > > CompilationUnit: > > PackageDeclarationopt ImportDeclarationsopt TypeDeclarationsopt > > > > So that's a javac bug. (And a reason for minimizing undue > flexibility in the language in the first place.) > > I'm generally happier to ban things like extra semicolons, but it > seems to me that "import x.y;;" should be allowed regardless of > what follows. > > FWIW, out front end does give the appropriate error, the rules > just seem odd to me. > > John. > > > > > Alex > > > > On 8/1/2013 12:59 PM, Jeremy Manson wrote: > >> Alex, > >> > >> What about the following, which also compiles? Can you > >> have ImportDeclaration TypeDeclaration ImportDeclaration? > >> > >> import java.util.HashMap;; > >> import java.util.LinkedList; > >> > >> public class Semicolon { > >> public static void main(String[] args) { > >> System.out.println("This program should not compile"); > >> } > >> } > >> > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20130802/62894c66/attachment.html From jhs at edg.com Fri Aug 2 14:00:27 2013 From: jhs at edg.com (John Spicer) Date: Fri, 2 Aug 2013 17:00:27 -0400 Subject: Double-semicolon in import statements In-Reply-To: <51FC1A5E.4070003@oracle.com> References: <51FA9F93.8010506@oracle.com> <51FBE4E3.8090808@oracle.com> <2064E555-3CC2-4625-8267-0B4868E5BE0C@edg.com> <51FC1A5E.4070003@oracle.com> Message-ID: <9896C687-AE58-42C4-8EFB-A76931BDC356@edg.com> On Aug 2, 2013, at 4:45 PM, Jonathan Gibbons wrote: > In general, it is better/simpler to change javac to conform to the spec. (Except when it is not.) Well, you sure can't argue with that statement :-) It is unfortunate that, in the example given, if the user swaps what look like import declarations with a redundant semicolon the code changes from being invalid to valid (or vice-versa if the code began in the other sequence). John. > > -- Jon > > On 08/02/2013 11:36 AM, Jeremy Manson wrote: >> Just out of my own curiosity, who decides whether to change the spec or javac? >> >> Jeremy >> >> >> On Fri, Aug 2, 2013 at 10:25 AM, John Spicer wrote: >> >> On Aug 2, 2013, at 12:57 PM, Alex Buckley wrote: >> >> > Nope, the production is: >> > >> > CompilationUnit: >> > PackageDeclarationopt ImportDeclarationsopt TypeDeclarationsopt >> > >> > So that's a javac bug. (And a reason for minimizing undue flexibility in the language in the first place.) >> >> I'm generally happier to ban things like extra semicolons, but it seems to me that "import x.y;;" should be allowed regardless of what follows. >> >> FWIW, out front end does give the appropriate error, the rules just seem odd to me. >> >> John. >> >> > >> > Alex >> > >> > On 8/1/2013 12:59 PM, Jeremy Manson wrote: >> >> Alex, >> >> >> >> What about the following, which also compiles? Can you >> >> have ImportDeclaration TypeDeclaration ImportDeclaration? >> >> >> >> import java.util.HashMap;; >> >> import java.util.LinkedList; >> >> >> >> public class Semicolon { >> >> public static void main(String[] args) { >> >> System.out.println("This program should not compile"); >> >> } >> >> } >> >> >> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20130802/4b2c0008/attachment.html From jonathan.gibbons at oracle.com Fri Aug 2 14:04:36 2013 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Fri, 02 Aug 2013 14:04:36 -0700 Subject: Double-semicolon in import statements In-Reply-To: <9896C687-AE58-42C4-8EFB-A76931BDC356@edg.com> References: <51FA9F93.8010506@oracle.com> <51FBE4E3.8090808@oracle.com> <2064E555-3CC2-4625-8267-0B4868E5BE0C@edg.com> <51FC1A5E.4070003@oracle.com> <9896C687-AE58-42C4-8EFB-A76931BDC356@edg.com> Message-ID: <51FC1EE4.60301@oracle.com> True, FWIW, if we change javac such that the set of programs accepted by javac is changed, we have an process (currently Oracle internal) to get approval for such a change. So, we would not simply change javac on a whim to meet the spec; we would at least have other eyes looking at the behavioral change to determine if it is "acceptable". -- Jon On 08/02/2013 02:00 PM, John Spicer wrote: > > On Aug 2, 2013, at 4:45 PM, Jonathan Gibbons > > wrote: > >> In general, it is better/simpler to change javac to conform to the >> spec. (Except when it is not.) > > Well, you sure can't argue with that statement :-) > > It is unfortunate that, in the example given, if the user swaps what > look like import declarations with a redundant semicolon the code > changes from being invalid to valid (or vice-versa if the code began > in the other sequence). > > John. > >> >> -- Jon >> >> On 08/02/2013 11:36 AM, Jeremy Manson wrote: >>> Just out of my own curiosity, who decides whether to change the spec >>> or javac? >>> >>> Jeremy >>> >>> >>> On Fri, Aug 2, 2013 at 10:25 AM, John Spicer >> > wrote: >>> >>> >>> On Aug 2, 2013, at 12:57 PM, Alex Buckley >>> > wrote: >>> >>> > Nope, the production is: >>> > >>> > CompilationUnit: >>> > PackageDeclarationopt ImportDeclarationsopt TypeDeclarationsopt >>> > >>> > So that's a javac bug. (And a reason for minimizing undue >>> flexibility in the language in the first place.) >>> >>> I'm generally happier to ban things like extra semicolons, but >>> it seems to me that "import x.y;;" should be allowed regardless >>> of what follows. >>> >>> FWIW, out front end does give the appropriate error, the rules >>> just seem odd to me. >>> >>> John. >>> >>> > >>> > Alex >>> > >>> > On 8/1/2013 12:59 PM, Jeremy Manson wrote: >>> >> Alex, >>> >> >>> >> What about the following, which also compiles? Can you >>> >> have ImportDeclaration TypeDeclaration ImportDeclaration? >>> >> >>> >> import java.util.HashMap;; >>> >> import java.util.LinkedList; >>> >> >>> >> public class Semicolon { >>> >> public static void main(String[] args) { >>> >> System.out.println("This program should not compile"); >>> >> } >>> >> } >>> >> >>> >>> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20130802/9a7122fc/attachment.html From joe.darcy at oracle.com Fri Aug 2 14:19:21 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Fri, 02 Aug 2013 21:19:21 +0000 Subject: hg: jdk8/tl/jdk: 6476168: (fmt) Inconsistency formatting subnormal doubles with hexadecimal conversion Message-ID: <20130802212009.363134859F@hg.openjdk.java.net> Changeset: 33617583c545 Author: bpb Date: 2013-07-31 10:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/33617583c545 6476168: (fmt) Inconsistency formatting subnormal doubles with hexadecimal conversion Summary: Update specification to match implementation. Reviewed-by: darcy Contributed-by: Brian Burkhalter ! src/share/classes/java/util/Formatter.java ! test/java/util/Formatter/Basic-X.java.template ! test/java/util/Formatter/Basic.java ! test/java/util/Formatter/BasicDouble.java From alex.buckley at oracle.com Fri Aug 2 16:07:30 2013 From: alex.buckley at oracle.com (Alex Buckley) Date: Fri, 02 Aug 2013 16:07:30 -0700 Subject: Double-semicolon in import statements In-Reply-To: <51FC1EE4.60301@oracle.com> References: <51FA9F93.8010506@oracle.com> <51FBE4E3.8090808@oracle.com> <2064E555-3CC2-4625-8267-0B4868E5BE0C@edg.com> <51FC1A5E.4070003@oracle.com> <9896C687-AE58-42C4-8EFB-A76931BDC356@edg.com> <51FC1EE4.60301@oracle.com> Message-ID: <51FC3BB2.1020602@oracle.com> Another factor in determining whether to change the JLS or javac is the extent of the mis-implementation. Here's an example. Jeremy had the insight to try an extra semicolon after an import declaration other than the last one, and javac accepted it. Suppose he'd also tried an extra semicolon after the package declaration, and that javac accepted it too. We would then have to accept that real-world code probably has more stray semicolons than we imagined, since javac has been allowing them all this time. That makes it harder to change javac to ban them, since it would spark a round of bug reports that have no good outcome for anyone. And so, I'd be more inclined than usual to change the JLS to accommodate javac. Sadly, as of JDK8b98, I can report that javac accepts extra semicolons after the package declaration. I would be interested in other locations anyone might find, but right now, it's looking like JLS 7.3 will have to change. Alex On 8/2/2013 2:04 PM, Jonathan Gibbons wrote: > True, > > FWIW, if we change javac such that the set of programs accepted by javac > is changed, we have an process (currently Oracle internal) to get > approval for such a change. So, we would not simply change javac on a > whim to meet the spec; we would at least have other eyes looking at the > behavioral change to determine if it is "acceptable". > > -- Jon > > > On 08/02/2013 02:00 PM, John Spicer wrote: >> >> On Aug 2, 2013, at 4:45 PM, Jonathan Gibbons >> > wrote: >> >>> In general, it is better/simpler to change javac to conform to the >>> spec. (Except when it is not.) >> >> Well, you sure can't argue with that statement :-) >> >> It is unfortunate that, in the example given, if the user swaps what >> look like import declarations with a redundant semicolon the code >> changes from being invalid to valid (or vice-versa if the code began >> in the other sequence). >> >> John. >> >>> >>> -- Jon >>> >>> On 08/02/2013 11:36 AM, Jeremy Manson wrote: >>>> Just out of my own curiosity, who decides whether to change the spec >>>> or javac? >>>> >>>> Jeremy >>>> >>>> >>>> On Fri, Aug 2, 2013 at 10:25 AM, John Spicer >>> > wrote: >>>> >>>> >>>> On Aug 2, 2013, at 12:57 PM, Alex Buckley >>>> > wrote: >>>> >>>> > Nope, the production is: >>>> > >>>> > CompilationUnit: >>>> > PackageDeclarationopt ImportDeclarationsopt TypeDeclarationsopt >>>> > >>>> > So that's a javac bug. (And a reason for minimizing undue >>>> flexibility in the language in the first place.) >>>> >>>> I'm generally happier to ban things like extra semicolons, but >>>> it seems to me that "import x.y;;" should be allowed regardless >>>> of what follows. >>>> >>>> FWIW, out front end does give the appropriate error, the rules >>>> just seem odd to me. >>>> >>>> John. >>>> >>>> > >>>> > Alex >>>> > >>>> > On 8/1/2013 12:59 PM, Jeremy Manson wrote: >>>> >> Alex, >>>> >> >>>> >> What about the following, which also compiles? Can you >>>> >> have ImportDeclaration TypeDeclaration ImportDeclaration? >>>> >> >>>> >> import java.util.HashMap;; >>>> >> import java.util.LinkedList; >>>> >> >>>> >> public class Semicolon { >>>> >> public static void main(String[] args) { >>>> >> System.out.println("This program should not compile"); >>>> >> } >>>> >> } >>>> >> >>>> >>>> >>> >> > From naoto.sato at oracle.com Fri Aug 2 15:45:52 2013 From: naoto.sato at oracle.com (naoto.sato at oracle.com) Date: Fri, 02 Aug 2013 22:45:52 +0000 Subject: hg: jdk8/tl/jdk: 8011194: Apps launched via double-clicked .jars have file.encoding value of US-ASCII on Mac OS X Message-ID: <20130802224616.147DA485A2@hg.openjdk.java.net> Changeset: 883cc296ec89 Author: bchristi Date: 2013-08-02 15:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/883cc296ec89 8011194: Apps launched via double-clicked .jars have file.encoding value of US-ASCII on Mac OS X Summary: On Mac, default to UTF-8 if no environmental hints are available Reviewed-by: naoto, ddehaven ! src/solaris/native/java/lang/java_props_md.c + test/java/lang/System/MacEncoding/ExpectedEncoding.java + test/java/lang/System/MacEncoding/MacJNUEncoding.sh + test/java/lang/System/MacEncoding/TestFileEncoding.java - test/java/lang/System/MacJNUEncoding/ExpectedEncoding.java - test/java/lang/System/MacJNUEncoding/MacJNUEncoding.sh From jeremymanson at google.com Fri Aug 2 17:01:05 2013 From: jeremymanson at google.com (Jeremy Manson) Date: Fri, 2 Aug 2013 17:01:05 -0700 Subject: Double-semicolon in import statements In-Reply-To: <51FC3BB2.1020602@oracle.com> References: <51FA9F93.8010506@oracle.com> <51FBE4E3.8090808@oracle.com> <2064E555-3CC2-4625-8267-0B4868E5BE0C@edg.com> <51FC1A5E.4070003@oracle.com> <9896C687-AE58-42C4-8EFB-A76931BDC356@edg.com> <51FC1EE4.60301@oracle.com> <51FC3BB2.1020602@oracle.com> Message-ID: That was why I asked - my assumption was that something like this is going to be present in a *lot* of Java code, which would then need to be fixed. OTOH, Martin and I just searched a very large code base, and there were a vanishingly small number of these (this may be because eclipse treats the double semicolon as an error). There were far, far more instances of classes that of accessed the private fields of superclasses. Also, it doesn't seem to be present in any JDK code. Perhaps it isn't as big a problem as one might imagine. Jeremy On Fri, Aug 2, 2013 at 4:07 PM, Alex Buckley wrote: > Another factor in determining whether to change the JLS or javac is the > extent of the mis-implementation. > > Here's an example. Jeremy had the insight to try an extra semicolon after > an import declaration other than the last one, and javac accepted it. > Suppose he'd also tried an extra semicolon after the package declaration, > and that javac accepted it too. We would then have to accept that > real-world code probably has more stray semicolons than we imagined, since > javac has been allowing them all this time. That makes it harder to change > javac to ban them, since it would spark a round of bug reports that have no > good outcome for anyone. And so, I'd be more inclined than usual to change > the JLS to accommodate javac. > > Sadly, as of JDK8b98, I can report that javac accepts extra semicolons > after the package declaration. I would be interested in other locations > anyone might find, but right now, it's looking like JLS 7.3 will have to > change. > > Alex > > > On 8/2/2013 2:04 PM, Jonathan Gibbons wrote: > >> True, >> >> FWIW, if we change javac such that the set of programs accepted by javac >> is changed, we have an process (currently Oracle internal) to get >> approval for such a change. So, we would not simply change javac on a >> whim to meet the spec; we would at least have other eyes looking at the >> behavioral change to determine if it is "acceptable". >> >> -- Jon >> >> >> On 08/02/2013 02:00 PM, John Spicer wrote: >> >>> >>> On Aug 2, 2013, at 4:45 PM, Jonathan Gibbons >>> >> >>> wrote: >>> >>> In general, it is better/simpler to change javac to conform to the >>>> spec. (Except when it is not.) >>>> >>> >>> Well, you sure can't argue with that statement :-) >>> >>> It is unfortunate that, in the example given, if the user swaps what >>> look like import declarations with a redundant semicolon the code >>> changes from being invalid to valid (or vice-versa if the code began >>> in the other sequence). >>> >>> John. >>> >>> >>>> -- Jon >>>> >>>> On 08/02/2013 11:36 AM, Jeremy Manson wrote: >>>> >>>>> Just out of my own curiosity, who decides whether to change the spec >>>>> or javac? >>>>> >>>>> Jeremy >>>>> >>>>> >>>>> On Fri, Aug 2, 2013 at 10:25 AM, John Spicer >>>> > wrote: >>>>> >>>>> >>>>> On Aug 2, 2013, at 12:57 PM, Alex Buckley >>>>> >> >>>>> wrote: >>>>> >>>>> > Nope, the production is: >>>>> > >>>>> > CompilationUnit: >>>>> > PackageDeclarationopt ImportDeclarationsopt TypeDeclarationsopt >>>>> > >>>>> > So that's a javac bug. (And a reason for minimizing undue >>>>> flexibility in the language in the first place.) >>>>> >>>>> I'm generally happier to ban things like extra semicolons, but >>>>> it seems to me that "import x.y;;" should be allowed regardless >>>>> of what follows. >>>>> >>>>> FWIW, out front end does give the appropriate error, the rules >>>>> just seem odd to me. >>>>> >>>>> John. >>>>> >>>>> > >>>>> > Alex >>>>> > >>>>> > On 8/1/2013 12:59 PM, Jeremy Manson wrote: >>>>> >> Alex, >>>>> >> >>>>> >> What about the following, which also compiles? Can you >>>>> >> have ImportDeclaration TypeDeclaration ImportDeclaration? >>>>> >> >>>>> >> import java.util.HashMap;; >>>>> >> import java.util.LinkedList; >>>>> >> >>>>> >> public class Semicolon { >>>>> >> public static void main(String[] args) { >>>>> >> System.out.println("This program should not compile"); >>>>> >> } >>>>> >> } >>>>> >> >>>>> >>>>> >>>>> >>>> >>> >> -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20130802/6b066af5/attachment.html From alex.buckley at oracle.com Fri Aug 2 17:36:51 2013 From: alex.buckley at oracle.com (Alex Buckley) Date: Fri, 02 Aug 2013 17:36:51 -0700 Subject: Double-semicolon in import statements In-Reply-To: References: <51FA9F93.8010506@oracle.com> <51FBE4E3.8090808@oracle.com> <2064E555-3CC2-4625-8267-0B4868E5BE0C@edg.com> <51FC1A5E.4070003@oracle.com> <9896C687-AE58-42C4-8EFB-A76931BDC356@edg.com> <51FC1EE4.60301@oracle.com> <51FC3BB2.1020602@oracle.com> Message-ID: <51FC50A3.5020204@oracle.com> Oh, I wouldn't assume a _lot_ of code has stray semicolons, in either relative or absolute terms. But if it's prevalent at one company (bad Perl script or whatever), then the bug report about how they moved to JDK8 and their code stopped compiling will have more force. Anyway, it's good to know that Eclipse-written code doesn't have stray semicolons. That certainly tips the scale back towards changing javac. Of course a clean solution would be to remove the ability to use ; as a type declaration. It's as obsolescent in 2013 as the ability to place [] after the formal parameter section of a method declaration (JLS 8.4). It would be interesting to know, Jeremy, if either ;-as-type-declaration or []-after-parameters occurs in your codebase. Alex On 8/2/2013 5:01 PM, Jeremy Manson wrote: > That was why I asked - my assumption was that something like this is > going to be present in a *lot* of Java code, which would then need to be > fixed. > > OTOH, Martin and I just searched a very large code base, and there were > a vanishingly small number of these (this may be because eclipse treats > the double semicolon as an error). There were far, far more instances > of classes that of accessed the private fields of superclasses. Also, > it doesn't seem to be present in any JDK code. Perhaps it isn't as big a > problem as one might imagine. > > Jeremy > > > On Fri, Aug 2, 2013 at 4:07 PM, Alex Buckley > wrote: > > Another factor in determining whether to change the JLS or javac is > the extent of the mis-implementation. > > Here's an example. Jeremy had the insight to try an extra semicolon > after an import declaration other than the last one, and javac > accepted it. Suppose he'd also tried an extra semicolon after the > package declaration, and that javac accepted it too. We would then > have to accept that real-world code probably has more stray > semicolons than we imagined, since javac has been allowing them all > this time. That makes it harder to change javac to ban them, since > it would spark a round of bug reports that have no good outcome for > anyone. And so, I'd be more inclined than usual to change the JLS to > accommodate javac. > > Sadly, as of JDK8b98, I can report that javac accepts extra > semicolons after the package declaration. I would be interested in > other locations anyone might find, but right now, it's looking like > JLS 7.3 will have to change. > > Alex > > > On 8/2/2013 2:04 PM, Jonathan Gibbons wrote: > > True, > > FWIW, if we change javac such that the set of programs accepted > by javac > is changed, we have an process (currently Oracle internal) to get > approval for such a change. So, we would not simply change > javac on a > whim to meet the spec; we would at least have other eyes looking > at the > behavioral change to determine if it is "acceptable". > > -- Jon > > > On 08/02/2013 02:00 PM, John Spicer wrote: > > > On Aug 2, 2013, at 4:45 PM, Jonathan Gibbons > > >> wrote: > > In general, it is better/simpler to change javac to > conform to the > spec. (Except when it is not.) > > > Well, you sure can't argue with that statement :-) > > It is unfortunate that, in the example given, if the user > swaps what > look like import declarations with a redundant semicolon the > code > changes from being invalid to valid (or vice-versa if the > code began > in the other sequence). > > John. > > > -- Jon > > On 08/02/2013 11:36 AM, Jeremy Manson wrote: > > Just out of my own curiosity, who decides whether to > change the spec > or javac? > > Jeremy > > > On Fri, Aug 2, 2013 at 10:25 AM, John Spicer > > >> wrote: > > > On Aug 2, 2013, at 12:57 PM, Alex Buckley > > >> wrote: > > > Nope, the production is: > > > > CompilationUnit: > > PackageDeclarationopt ImportDeclarationsopt > TypeDeclarationsopt > > > > So that's a javac bug. (And a reason for > minimizing undue > flexibility in the language in the first place.) > > I'm generally happier to ban things like extra > semicolons, but > it seems to me that "import x.y;;" should be > allowed regardless > of what follows. > > FWIW, out front end does give the appropriate > error, the rules > just seem odd to me. > > John. > > > > > Alex > > > > On 8/1/2013 12:59 PM, Jeremy Manson wrote: > >> Alex, > >> > >> What about the following, which also > compiles? Can you > >> have ImportDeclaration TypeDeclaration > ImportDeclaration? > >> > >> import java.util.HashMap;; > >> import java.util.LinkedList; > >> > >> public class Semicolon { > >> public static void main(String[] args) { > >> System.out.println("This program should > not compile"); > >> } > >> } > >> > > > > > > From michel.trudeau at oracle.com Fri Aug 2 19:35:51 2013 From: michel.trudeau at oracle.com (Michel Trudeau) Date: Fri, 2 Aug 2013 19:35:51 -0700 Subject: Double-semicolon in import statements In-Reply-To: References: <51FA9F93.8010506@oracle.com> <51FBE4E3.8090808@oracle.com> <2064E555-3CC2-4625-8267-0B4868E5BE0C@edg.com> <51FC1A5E.4070003@oracle.com> <9896C687-AE58-42C4-8EFB-A76931BDC356@edg.com> <51FC1EE4.60301@oracle.com> <51FC3BB2.1020602@oracle.com> Message-ID: <4370B142-65DC-46B0-89D1-1BD9FB3A5FCE@oracle.com> Please note that Eclipse got it right here. Meaning, an empty semicolon is only allowed after the last import stmt. And IntelliJ got it wrong, but behaves slightly differently than Javac/Netbeans. Michel On Aug 2, 2013, at 5:01 PM, Jeremy Manson wrote: That was why I asked - my assumption was that something like this is going to be present in a *lot* of Java code, which would then need to be fixed. OTOH, Martin and I just searched a very large code base, and there were a vanishingly small number of these (this may be because eclipse treats the double semicolon as an error). There were far, far more instances of classes that of accessed the private fields of superclasses. Also, it doesn't seem to be present in any JDK code. Perhaps it isn't as big a problem as one might imagine. Jeremy On Fri, Aug 2, 2013 at 4:07 PM, Alex Buckley wrote: Another factor in determining whether to change the JLS or javac is the extent of the mis-implementation. Here's an example. Jeremy had the insight to try an extra semicolon after an import declaration other than the last one, and javac accepted it. Suppose he'd also tried an extra semicolon after the package declaration, and that javac accepted it too. We would then have to accept that real-world code probably has more stray semicolons than we imagined, since javac has been allowing them all this time. That makes it harder to change javac to ban them, since it would spark a round of bug reports that have no good outcome for anyone. And so, I'd be more inclined than usual to change the JLS to accommodate javac. Sadly, as of JDK8b98, I can report that javac accepts extra semicolons after the package declaration. I would be interested in other locations anyone might find, but right now, it's looking like JLS 7.3 will have to change. Alex On 8/2/2013 2:04 PM, Jonathan Gibbons wrote: True, FWIW, if we change javac such that the set of programs accepted by javac is changed, we have an process (currently Oracle internal) to get approval for such a change. So, we would not simply change javac on a whim to meet the spec; we would at least have other eyes looking at the behavioral change to determine if it is "acceptable". -- Jon On 08/02/2013 02:00 PM, John Spicer wrote: On Aug 2, 2013, at 4:45 PM, Jonathan Gibbons > wrote: In general, it is better/simpler to change javac to conform to the spec. (Except when it is not.) Well, you sure can't argue with that statement :-) It is unfortunate that, in the example given, if the user swaps what look like import declarations with a redundant semicolon the code changes from being invalid to valid (or vice-versa if the code began in the other sequence). John. -- Jon On 08/02/2013 11:36 AM, Jeremy Manson wrote: Just out of my own curiosity, who decides whether to change the spec or javac? Jeremy On Fri, Aug 2, 2013 at 10:25 AM, John Spicer > wrote: On Aug 2, 2013, at 12:57 PM, Alex Buckley > wrote: > Nope, the production is: > > CompilationUnit: > PackageDeclarationopt ImportDeclarationsopt TypeDeclarationsopt > > So that's a javac bug. (And a reason for minimizing undue flexibility in the language in the first place.) I'm generally happier to ban things like extra semicolons, but it seems to me that "import x.y;;" should be allowed regardless of what follows. FWIW, out front end does give the appropriate error, the rules just seem odd to me. John. > > Alex > > On 8/1/2013 12:59 PM, Jeremy Manson wrote: >> Alex, >> >> What about the following, which also compiles? Can you >> have ImportDeclaration TypeDeclaration ImportDeclaration? >> >> import java.util.HashMap;; >> import java.util.LinkedList; >> >> public class Semicolon { >> public static void main(String[] args) { >> System.out.println("This program should not compile"); >> } >> } >> -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20130802/94a2598f/attachment.html From alan.bateman at oracle.com Sat Aug 3 19:14:50 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Sun, 04 Aug 2013 02:14:50 +0000 Subject: hg: jdk8/tl/jdk: 8022094: BigDecimal/CompareToTests and BigInteger/CompareToTests are incorrect Message-ID: <20130804021551.9BF2A485B9@hg.openjdk.java.net> Changeset: dd1040690e31 Author: bpb Date: 2013-08-02 11:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dd1040690e31 8022094: BigDecimal/CompareToTests and BigInteger/CompareToTests are incorrect Summary: Fail test if errors; fix test values; port BigDecimal version to BigInteger Reviewed-by: smarks, alanb Contributed-by: Brian Burkhalter ! test/java/math/BigDecimal/CompareToTests.java ! test/java/math/BigInteger/CompareToTests.java From joe.darcy at oracle.com Mon Aug 5 07:50:31 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Mon, 05 Aug 2013 14:50:31 +0000 Subject: hg: jdk8/tl/jdk: 8022190: Fix varargs lint warnings in the JDK Message-ID: <20130805145121.77CAF485DA@hg.openjdk.java.net> Changeset: 80da091343af Author: darcy Date: 2013-08-05 07:50 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/80da091343af 8022190: Fix varargs lint warnings in the JDK Reviewed-by: alanb, lancea, alexsch ! src/share/classes/java/util/stream/Stream.java ! src/share/classes/javax/swing/SwingWorker.java ! src/share/classes/sun/reflect/annotation/AnnotationParser.java ! src/share/classes/sun/swing/AccumulativeRunnable.java From sundararajan.athijegannathan at oracle.com Mon Aug 5 09:02:20 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Mon, 05 Aug 2013 16:02:20 +0000 Subject: hg: jdk8/tl/jdk: 8016531: jconsole-plugin script demo does not work with nashorn Message-ID: <20130805160233.DF480485DE@hg.openjdk.java.net> Changeset: 87367a1c7f76 Author: sundar Date: 2013-08-05 21:31 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/87367a1c7f76 8016531: jconsole-plugin script demo does not work with nashorn Reviewed-by: lagergren, hannesw Contributed-by: rieberandreas at gmail.com ! src/share/demo/scripting/jconsole-plugin/src/com/sun/demo/scripting/jconsole/ScriptShellPanel.java ! src/share/demo/scripting/jconsole-plugin/src/resources/jconsole.js ! src/share/demo/scripting/jconsole-plugin/src/scripts/invoke.js ! src/share/demo/scripting/jconsole-plugin/src/scripts/jstack.js ! src/share/demo/scripting/jconsole-plugin/src/scripts/jtop.js ! src/share/demo/scripting/jconsole-plugin/src/scripts/sysprops.js ! src/share/sample/scripting/scriptpad/README.txt ! src/share/sample/scripting/scriptpad/src/resources/conc.js ! src/share/sample/scripting/scriptpad/src/resources/mm.js From stuart.marks at oracle.com Mon Aug 5 19:08:25 2013 From: stuart.marks at oracle.com (stuart.marks at oracle.com) Date: Tue, 06 Aug 2013 02:08:25 +0000 Subject: hg: jdk8/tl/jdk: 8020854: change RMI javadocs to specify that remote objects are exported to the wildcard address Message-ID: <20130806020849.73652485F5@hg.openjdk.java.net> Changeset: 31759750ff63 Author: smarks Date: 2013-08-05 19:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/31759750ff63 8020854: change RMI javadocs to specify that remote objects are exported to the wildcard address Reviewed-by: rgallard, alanb ! src/share/classes/java/rmi/server/RMISocketFactory.java ! src/share/classes/java/rmi/server/UnicastRemoteObject.java From sundararajan.athijegannathan at oracle.com Tue Aug 6 02:03:35 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Tue, 06 Aug 2013 09:03:35 +0000 Subject: hg: jdk8/tl/nashorn: 2 new changesets Message-ID: <20130806090338.AC2B7485FB@hg.openjdk.java.net> Changeset: 0ad00ae4fec6 Author: hannesw Date: 2013-08-01 12:23 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/0ad00ae4fec6 8020132: Big object literal with numerical keys exceeds method size Reviewed-by: lagergren, sundar ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/FieldObjectCreator.java ! src/jdk/nashorn/internal/codegen/MapCreator.java ! src/jdk/nashorn/internal/codegen/SpillObjectCreator.java ! src/jdk/nashorn/internal/objects/ArrayBufferView.java ! src/jdk/nashorn/internal/runtime/NashornLoader.java ! src/jdk/nashorn/internal/runtime/arrays/ArrayData.java ! src/jdk/nashorn/internal/runtime/arrays/ArrayIndex.java ! src/jdk/nashorn/internal/runtime/arrays/ArrayIterator.java ! src/jdk/nashorn/internal/runtime/arrays/DeletedArrayFilter.java ! src/jdk/nashorn/internal/runtime/arrays/DeletedRangeArrayFilter.java ! src/jdk/nashorn/internal/runtime/arrays/FrozenArrayFilter.java ! src/jdk/nashorn/internal/runtime/arrays/IntArrayData.java ! src/jdk/nashorn/internal/runtime/arrays/LongArrayData.java ! src/jdk/nashorn/internal/runtime/arrays/NoTypeArrayData.java ! src/jdk/nashorn/internal/runtime/arrays/NumberArrayData.java ! src/jdk/nashorn/internal/runtime/arrays/ObjectArrayData.java ! src/jdk/nashorn/internal/runtime/arrays/ReverseArrayIterator.java ! src/jdk/nashorn/internal/runtime/arrays/SealedArrayFilter.java ! src/jdk/nashorn/internal/runtime/arrays/SparseArrayData.java ! src/jdk/nashorn/internal/runtime/arrays/UndefinedArrayFilter.java + test/script/basic/JDK-8020132.js + test/script/basic/JDK-8020132.js.EXPECTED Changeset: bb0f3c896cb7 Author: sundar Date: 2013-08-06 13:10 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/bb0f3c896cb7 Merge From dmitry.samersoff at oracle.com Tue Aug 6 03:05:31 2013 From: dmitry.samersoff at oracle.com (dmitry.samersoff at oracle.com) Date: Tue, 06 Aug 2013 10:05:31 +0000 Subject: hg: jdk8/tl/jdk: 8011038: sourceObj validation during desereliazation of RelationNotification should be relaxed Message-ID: <20130806100558.D1A33485FD@hg.openjdk.java.net> Changeset: fce446b29577 Author: dsamersoff Date: 2013-08-06 14:04 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fce446b29577 8011038: sourceObj validation during desereliazation of RelationNotification should be relaxed Summary: sourceObj could be set to null by setSource() relax a validation of deserialized object. Reviewed-by: sjiang, skoivu, dfuchs ! src/share/classes/javax/management/relation/RelationNotification.java From vicente.romero at oracle.com Tue Aug 6 07:18:15 2013 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Tue, 06 Aug 2013 14:18:15 +0000 Subject: hg: jdk8/tl/langtools: 8022186: javac generates dead code if a try with an empty body has a finalizer Message-ID: <20130806141821.C84924860B@hg.openjdk.java.net> Changeset: 99b60bcf3862 Author: vromero Date: 2013-08-06 15:08 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/99b60bcf3862 8022186: javac generates dead code if a try with an empty body has a finalizer Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/jvm/Gen.java + test/tools/javac/T8022186/DeadCodeGeneratedForEmptyTryTest.java From chris.hegarty at oracle.com Tue Aug 6 07:35:49 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Tue, 06 Aug 2013 14:35:49 +0000 Subject: hg: jdk8/tl/jdk: 8022344: Additional debug info for test/java/net/NetworkInterface/IndexTest.java Message-ID: <20130806143616.38D8B4860E@hg.openjdk.java.net> Changeset: 6773af0dda02 Author: chegar Date: 2013-08-06 15:35 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6773af0dda02 8022344: Additional debug info for test/java/net/NetworkInterface/IndexTest.java Reviewed-by: michaelm, alanb ! test/java/net/NetworkInterface/IndexTest.java From sean.mullan at oracle.com Tue Aug 6 08:56:29 2013 From: sean.mullan at oracle.com (sean.mullan at oracle.com) Date: Tue, 06 Aug 2013 15:56:29 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20130806155652.F28CB48610@hg.openjdk.java.net> Changeset: 1f4af3e0447e Author: mullan Date: 2013-08-06 08:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1f4af3e0447e 8022120: JCK test api/javax_xml/crypto/dsig/TransformService/index_ParamMethods fails Summary: TransformService.init and marshalParams must throw NullPointerException when parent parameter is null Reviewed-by: xuelei ! src/share/classes/org/jcp/xml/dsig/internal/dom/ApacheCanonicalizer.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/ApacheTransform.java + test/javax/xml/crypto/dsig/TransformService/NullParent.java Changeset: ba634b53f53a Author: mullan Date: 2013-08-06 08:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ba634b53f53a Merge From joel.franck at oracle.com Tue Aug 6 10:03:13 2013 From: joel.franck at oracle.com (joel.franck at oracle.com) Date: Tue, 06 Aug 2013 17:03:13 +0000 Subject: hg: jdk8/tl/jdk: 7184826: (reflect) Add support for Project Lambda concepts in core reflection Message-ID: <20130806170335.9D79848615@hg.openjdk.java.net> Changeset: cd0ea5563523 Author: jfranck Date: 2013-08-06 18:54 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cd0ea5563523 7184826: (reflect) Add support for Project Lambda concepts in core reflection Reviewed-by: darcy, jfranck Contributed-by: Amy Lu + test/java/lang/reflect/DefaultStaticTest/DefaultStaticInvokeTest.java + test/java/lang/reflect/DefaultStaticTest/DefaultStaticTestData.java + test/java/lang/reflect/DefaultStaticTest/helper/Declared.java + test/java/lang/reflect/DefaultStaticTest/helper/Mod.java ! test/java/lang/reflect/Method/DefaultMethodModeling.java ! test/java/lang/reflect/Method/IsDefaultTest.java From joe.darcy at oracle.com Tue Aug 6 13:25:21 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Tue, 06 Aug 2013 20:25:21 +0000 Subject: hg: jdk8/tl/jdk: 8022174: Fix doclint warnings in javax.sound; ... Message-ID: <20130806202538.5AED948628@hg.openjdk.java.net> Changeset: 98643f3ddf40 Author: darcy Date: 2013-08-06 13:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/98643f3ddf40 8022174: Fix doclint warnings in javax.sound 8022404: Fix doclint issues in java.applet Reviewed-by: prr ! src/share/classes/java/applet/AppletContext.java ! src/share/classes/javax/sound/midi/MetaMessage.java ! src/share/classes/javax/sound/midi/MidiDevice.java ! src/share/classes/javax/sound/midi/MidiDeviceReceiver.java ! src/share/classes/javax/sound/midi/MidiDeviceTransmitter.java ! src/share/classes/javax/sound/midi/MidiFileFormat.java ! src/share/classes/javax/sound/midi/MidiMessage.java ! src/share/classes/javax/sound/midi/MidiSystem.java ! src/share/classes/javax/sound/midi/ShortMessage.java ! src/share/classes/javax/sound/midi/Synthesizer.java ! src/share/classes/javax/sound/midi/SysexMessage.java ! src/share/classes/javax/sound/midi/Track.java ! src/share/classes/javax/sound/sampled/AudioFileFormat.java ! src/share/classes/javax/sound/sampled/AudioFormat.java ! src/share/classes/javax/sound/sampled/AudioSystem.java ! src/share/classes/javax/sound/sampled/BooleanControl.java ! src/share/classes/javax/sound/sampled/Mixer.java ! src/share/classes/javax/sound/sampled/spi/FormatConversionProvider.java From stuart.marks at oracle.com Tue Aug 6 13:40:32 2013 From: stuart.marks at oracle.com (stuart.marks at oracle.com) Date: Tue, 06 Aug 2013 20:40:32 +0000 Subject: hg: jdk8/tl/jdk: 8022412: Fixed warnings in java.util root, except for HashMap Message-ID: <20130806204046.A790D4862B@hg.openjdk.java.net> Changeset: 12c1b78acf9a Author: lagergren Date: 2013-08-06 12:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/12c1b78acf9a 8022412: Fixed warnings in java.util root, except for HashMap Reviewed-by: mduigou, darcy Contributed-by: marcus.lagergren at oracle.com ! src/share/classes/java/util/ArrayPrefixHelpers.java ! src/share/classes/java/util/Collections.java ! src/share/classes/java/util/Comparator.java ! src/share/classes/java/util/Comparators.java ! src/share/classes/java/util/Hashtable.java ! src/share/classes/java/util/IdentityHashMap.java ! src/share/classes/java/util/Vector.java ! src/share/classes/java/util/WeakHashMap.java From jason.uh at oracle.com Tue Aug 6 13:46:52 2013 From: jason.uh at oracle.com (jason.uh at oracle.com) Date: Tue, 06 Aug 2013 20:46:52 +0000 Subject: hg: jdk8/tl/jdk: 8022439: Fix lint warnings in sun.security.ec Message-ID: <20130806204704.1C4B04862C@hg.openjdk.java.net> Changeset: 8112076ae424 Author: juh Date: 2013-08-06 13:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8112076ae424 8022439: Fix lint warnings in sun.security.ec Reviewed-by: darcy ! src/share/classes/sun/security/ec/ECDSASignature.java From jason.uh at oracle.com Tue Aug 6 14:10:36 2013 From: jason.uh at oracle.com (jason.uh at oracle.com) Date: Tue, 06 Aug 2013 21:10:36 +0000 Subject: hg: jdk8/tl/jdk: 8022443: Fix lint warnings in sun.security.pkcs12 Message-ID: <20130806211049.52D984862E@hg.openjdk.java.net> Changeset: 69cfd941aec2 Author: juh Date: 2013-08-06 14:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/69cfd941aec2 8022443: Fix lint warnings in sun.security.pkcs12 Reviewed-by: darcy ! src/share/classes/sun/security/pkcs12/PKCS12KeyStore.java From dan.xu at oracle.com Tue Aug 6 14:34:13 2013 From: dan.xu at oracle.com (dan.xu at oracle.com) Date: Tue, 06 Aug 2013 21:34:13 +0000 Subject: hg: jdk8/tl/jdk: 8022410: Fix Javac Warnings in com.sun.security.auth Package Message-ID: <20130806213427.3FD5948632@hg.openjdk.java.net> Changeset: 4b8b811059db Author: dxu Date: 2013-08-06 14:33 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4b8b811059db 8022410: Fix Javac Warnings in com.sun.security.auth Package Reviewed-by: darcy ! src/share/classes/com/sun/security/auth/PolicyFile.java ! src/share/classes/com/sun/security/auth/SubjectCodeSource.java From stuart.marks at oracle.com Tue Aug 6 14:19:57 2013 From: stuart.marks at oracle.com (stuart.marks at oracle.com) Date: Tue, 06 Aug 2013 21:19:57 +0000 Subject: hg: jdk8/tl/jdk: 8022440: suppress deprecation warnings in sun.rmi Message-ID: <20130806212010.B4F394862F@hg.openjdk.java.net> Changeset: 31e923842d49 Author: smarks Date: 2013-08-06 14:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/31e923842d49 8022440: suppress deprecation warnings in sun.rmi Reviewed-by: mduigou ! src/share/classes/sun/rmi/runtime/Log.java ! src/share/classes/sun/rmi/server/ActivatableRef.java ! src/share/classes/sun/rmi/server/Dispatcher.java ! src/share/classes/sun/rmi/server/LoaderHandler.java ! src/share/classes/sun/rmi/server/UnicastRef.java ! src/share/classes/sun/rmi/server/UnicastServerRef.java ! src/share/classes/sun/rmi/server/Util.java ! src/share/classes/sun/rmi/transport/DGCImpl.java ! src/share/classes/sun/rmi/transport/StreamRemoteCall.java ! src/share/classes/sun/rmi/transport/Transport.java ! src/share/classes/sun/rmi/transport/proxy/RMIMasterSocketFactory.java ! src/share/classes/sun/rmi/transport/tcp/ConnectionMultiplexer.java ! src/share/classes/sun/rmi/transport/tcp/TCPTransport.java From joe.darcy at oracle.com Tue Aug 6 16:01:58 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Tue, 06 Aug 2013 23:01:58 +0000 Subject: hg: jdk8/tl/jdk: 8022406: Fix doclint issues in java.beans Message-ID: <20130806230214.28DEC48634@hg.openjdk.java.net> Changeset: d5694d78ebc6 Author: darcy Date: 2013-08-06 16:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d5694d78ebc6 8022406: Fix doclint issues in java.beans Reviewed-by: prr ! src/share/classes/java/beans/AppletInitializer.java ! src/share/classes/java/beans/Beans.java ! src/share/classes/java/beans/ConstructorProperties.java ! src/share/classes/java/beans/DefaultPersistenceDelegate.java ! src/share/classes/java/beans/EventHandler.java ! src/share/classes/java/beans/Expression.java ! src/share/classes/java/beans/IndexedPropertyDescriptor.java ! src/share/classes/java/beans/Introspector.java ! src/share/classes/java/beans/PersistenceDelegate.java ! src/share/classes/java/beans/PropertyChangeSupport.java ! src/share/classes/java/beans/PropertyDescriptor.java ! src/share/classes/java/beans/Transient.java ! src/share/classes/java/beans/VetoableChangeSupport.java ! src/share/classes/java/beans/beancontext/BeanContext.java ! src/share/classes/java/beans/beancontext/BeanContextChild.java ! src/share/classes/java/beans/beancontext/BeanContextChildSupport.java ! src/share/classes/java/beans/beancontext/BeanContextMembershipEvent.java ! src/share/classes/java/beans/beancontext/BeanContextServices.java ! src/share/classes/java/beans/beancontext/BeanContextServicesSupport.java ! src/share/classes/java/beans/beancontext/BeanContextSupport.java From joel.franck at oracle.com Tue Aug 6 16:40:45 2013 From: joel.franck at oracle.com (joel.franck at oracle.com) Date: Tue, 06 Aug 2013 23:40:45 +0000 Subject: hg: jdk8/tl/langtools: 8009367: Wrong kind of name used in comparison in javax.lang.model code for repeatable annotations Message-ID: <20130806234048.1AF1848637@hg.openjdk.java.net> Changeset: 051e64d0816e Author: jfranck Date: 2013-08-07 01:32 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/051e64d0816e 8009367: Wrong kind of name used in comparison in javax.lang.model code for repeatable annotations Reviewed-by: jjg, darcy ! src/share/classes/com/sun/tools/javac/model/JavacAnnoConstructs.java + test/tools/javac/processing/model/element/8009367/TestQualifiedNameUsed.java + test/tools/javac/processing/model/element/8009367/p/Q.java + test/tools/javac/processing/model/element/8009367/p/QQ.java + test/tools/javac/processing/model/element/8009367/p/R.java + test/tools/javac/processing/model/element/8009367/p/RR.java From joe.darcy at oracle.com Tue Aug 6 16:45:51 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Tue, 06 Aug 2013 23:45:51 +0000 Subject: hg: jdk8/tl/jdk: 8022453: Fix doclint issues in javax.accessibility Message-ID: <20130806234603.A3A9048638@hg.openjdk.java.net> Changeset: 6cc8c2ad9804 Author: darcy Date: 2013-08-06 16:45 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6cc8c2ad9804 8022453: Fix doclint issues in javax.accessibility Reviewed-by: prr ! src/share/classes/javax/accessibility/Accessible.java ! src/share/classes/javax/accessibility/AccessibleBundle.java ! src/share/classes/javax/accessibility/AccessibleExtendedTable.java ! src/share/classes/javax/accessibility/AccessibleRelationSet.java ! src/share/classes/javax/accessibility/AccessibleTable.java ! src/share/classes/javax/accessibility/AccessibleTableModelChange.java ! src/share/classes/javax/accessibility/AccessibleTextSequence.java ! src/share/classes/javax/accessibility/AccessibleValue.java From henry.jen at oracle.com Tue Aug 6 16:21:11 2013 From: henry.jen at oracle.com (henry.jen at oracle.com) Date: Tue, 06 Aug 2013 23:21:11 +0000 Subject: hg: jdk8/tl/jdk: 8015318: Extend Collector with 'finish' operation Message-ID: <20130806232124.D773C48636@hg.openjdk.java.net> Changeset: 939c3be6cc86 Author: briangoetz Date: 2013-06-28 16:26 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/939c3be6cc86 8015318: Extend Collector with 'finish' operation Reviewed-by: mduigou Contributed-by: brian.goetz at oracle.com ! src/share/classes/java/util/DoubleSummaryStatistics.java ! src/share/classes/java/util/IntSummaryStatistics.java ! src/share/classes/java/util/LongSummaryStatistics.java ! src/share/classes/java/util/StringJoiner.java ! src/share/classes/java/util/stream/Collector.java ! src/share/classes/java/util/stream/Collectors.java ! src/share/classes/java/util/stream/DelegatingStream.java ! src/share/classes/java/util/stream/DoubleStream.java ! src/share/classes/java/util/stream/IntStream.java ! src/share/classes/java/util/stream/LongStream.java ! src/share/classes/java/util/stream/ReduceOps.java ! src/share/classes/java/util/stream/ReferencePipeline.java ! src/share/classes/java/util/stream/Stream.java ! src/share/classes/java/util/stream/package-info.java ! test/java/util/stream/test/org/openjdk/tests/java/util/FillableStringTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/GroupByOpTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/SummaryStatisticsTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/TabulatorsTest.java ! test/jdk/lambda/MethodReferenceTestInstanceMethod.java ! test/jdk/lambda/separate/TestHarness.java From lana.steuck at oracle.com Tue Aug 6 17:16:51 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 07 Aug 2013 00:16:51 +0000 Subject: hg: jdk8/tl/corba: 2 new changesets Message-ID: <20130807001653.ECB1B4863C@hg.openjdk.java.net> Changeset: 528c7e76eaee Author: cl Date: 2013-08-01 04:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/528c7e76eaee Added tag jdk8-b101 for changeset a013024b0747 ! .hgtags Changeset: 342a954b68f3 Author: lana Date: 2013-08-06 16:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/342a954b68f3 Merge From lana.steuck at oracle.com Tue Aug 6 17:16:56 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 07 Aug 2013 00:16:56 +0000 Subject: hg: jdk8/tl/jaxws: Added tag jdk8-b101 for changeset 60b623a36164 Message-ID: <20130807001701.D5BDD4863E@hg.openjdk.java.net> Changeset: 988a5f2ac559 Author: cl Date: 2013-08-01 04:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/988a5f2ac559 Added tag jdk8-b101 for changeset 60b623a36164 ! .hgtags From lana.steuck at oracle.com Tue Aug 6 17:16:59 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 07 Aug 2013 00:16:59 +0000 Subject: hg: jdk8/tl/nashorn: 3 new changesets Message-ID: <20130807001704.8F0EE4863F@hg.openjdk.java.net> Changeset: 573ccf92d646 Author: cl Date: 2013-08-01 04:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/573ccf92d646 Added tag jdk8-b101 for changeset a302b05d0ee4 ! .hgtags Changeset: e966ff0a3ffe Author: lana Date: 2013-08-06 10:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/e966ff0a3ffe Merge Changeset: ab90c566272d Author: lana Date: 2013-08-06 17:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/ab90c566272d Merge From lana.steuck at oracle.com Tue Aug 6 17:16:56 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 07 Aug 2013 00:16:56 +0000 Subject: hg: jdk8/tl/jaxp: 2 new changesets Message-ID: <20130807001706.D504A48640@hg.openjdk.java.net> Changeset: b8cd8b101ecb Author: cl Date: 2013-08-01 04:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/b8cd8b101ecb Added tag jdk8-b101 for changeset 0a7432f898e5 ! .hgtags Changeset: 7cffafa606e9 Author: lana Date: 2013-08-06 10:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/7cffafa606e9 Merge From lana.steuck at oracle.com Tue Aug 6 17:17:23 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 07 Aug 2013 00:17:23 +0000 Subject: hg: jdk8/tl/hotspot: 61 new changesets Message-ID: <20130807001932.4D8C048642@hg.openjdk.java.net> Changeset: 2285b4a0a4e6 Author: amurillo Date: 2013-07-18 09:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2285b4a0a4e6 8020797: new hotspot build - hs25-b43 Reviewed-by: jcoomes ! make/hotspot_version Changeset: dbc0b5dc08f5 Author: fparain Date: 2013-07-10 15:49 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/dbc0b5dc08f5 7143807: ResourceMark nesting problem in stringStream Reviewed-by: kvn, dcubed ! src/share/vm/memory/resourceArea.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/thread.hpp ! src/share/vm/utilities/ostream.cpp ! src/share/vm/utilities/ostream.hpp Changeset: c9a5fab39234 Author: zgu Date: 2013-07-11 13:15 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c9a5fab39234 8012241: NMT huge memory footprint, it usually leads to OOME Summary: Enforce memory limitation on NMT to prevent JVM OOM Reviewed-by: acorn, dcubed, minqi ! src/share/vm/services/memTracker.cpp Changeset: 5f056abe17c6 Author: zgu Date: 2013-07-12 04:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5f056abe17c6 Merge Changeset: 2e8f19c2feef Author: allwin Date: 2013-07-12 18:43 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2e8f19c2feef 7162400: Intermittent java.io.IOException: Bad file number during HotSpotVirtualMachine.executeCommand Summary: Intermittent java.io.IOException: Bad file number during HotSpotVirtualMachine.executeCommand Reviewed-by: dcubed, dholmes, sspitsyn, mgerdin, ctornqvi, dsamersoff ! src/os/bsd/vm/attachListener_bsd.cpp ! src/os/linux/vm/attachListener_linux.cpp ! src/os/solaris/vm/attachListener_solaris.cpp ! src/os/windows/vm/attachListener_windows.cpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/services/attachListener.hpp + test/serviceability/attach/AttachWithStalePidFile.java + test/serviceability/attach/AttachWithStalePidFileTarget.java Changeset: c0cb474be37e Author: ctornqvi Date: 2013-07-12 20:47 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c0cb474be37e Merge Changeset: 862625d214fa Author: fparain Date: 2013-07-15 00:23 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/862625d214fa Merge Changeset: 23123fc6968a Author: rbackman Date: 2013-07-15 11:35 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/23123fc6968a 8019324: assert(_f2 == 0 || _f2 == f2) failed: illegal field change Reviewed-by: dholmes, rbackman Contributed-by: David Simms ! src/share/vm/oops/cpCache.hpp Changeset: ee9e76adced3 Author: rbackman Date: 2013-07-15 12:06 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ee9e76adced3 Merge Changeset: 33c52908bcdb Author: dholmes Date: 2013-07-15 23:23 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/33c52908bcdb 8015759: hotspot changes needed to compile with Visual Studio 2012 Reviewed-by: anthony, dholmes, dcubed Contributed-by: Tim Bell ! make/windows/makefiles/compile.make ! make/windows/makefiles/sanity.make ! make/windows/makefiles/vm.make ! src/os_cpu/windows_x86/vm/unwind_windows_x86.hpp Changeset: 39deebbc90b3 Author: mgerdin Date: 2013-07-16 07:33 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/39deebbc90b3 6671508: JNI GetPrimitiveArrayCritical should not be callable on object arrays Summary: Checked JNI now reports error for Get/ReleasePrimitiveArrayCritical on object arrays Reviewed-by: dholmes, acorn Contributed-by: david.simms at oracle.com ! src/share/vm/prims/jniCheck.cpp Changeset: e619a2766bcc Author: rbackman Date: 2013-06-12 11:17 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e619a2766bcc 8016131: nsk/sysdict/vm/stress/chain tests crash the VM in 'entry_frame_is_first()' Reviewed-by: jrose, kvn, mgronlun ! src/cpu/sparc/vm/frame_sparc.inline.hpp ! src/cpu/x86/vm/frame_x86.inline.hpp ! src/share/vm/prims/forte.cpp ! src/share/vm/runtime/frame.cpp ! src/share/vm/runtime/frame.hpp ! src/share/vm/runtime/javaCalls.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/thread.hpp Changeset: 732af649bc3a Author: ccheung Date: 2013-07-17 12:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/732af649bc3a 8017498: JVM crashes when native code calls sigaction(sig) where sig>=0x20 Summary: Added (sig < MAXSIGNUM) check in jsig.c Reviewed-by: dholmes, acorn ! src/os/linux/vm/jsig.c + test/runtime/jsig/Test8017498.sh + test/runtime/jsig/TestJNI.c + test/runtime/jsig/TestJNI.java Changeset: 825e6cb66923 Author: jiangli Date: 2013-07-17 18:06 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/825e6cb66923 8020309: Eliminate InstanceKlass::_cached_class_file_len. Summary: Use JvmtiCachedClassFileData. Reviewed-by: iklam, sspitsyn, dcubed ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/prims/jvmtiExport.cpp ! src/share/vm/prims/jvmtiExport.hpp ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! src/share/vm/prims/jvmtiRedefineClasses.hpp Changeset: 6388dbc4b7ca Author: jiangli Date: 2013-07-17 17:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6388dbc4b7ca Merge Changeset: c29568b733d2 Author: dholmes Date: 2013-07-18 06:47 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c29568b733d2 8020697: jniCheck.cpp:check_is_obj_array asserts on TypeArrayKlass::cast(aOop->klass()) Reviewed-by: dcubed, fparain, dholmes Contributed-by: David Simms ! src/share/vm/prims/jniCheck.cpp Changeset: 5e3b6f79d280 Author: rbackman Date: 2013-07-17 13:48 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5e3b6f79d280 8020701: Avoid crashes in WatcherThread Reviewed-by: acorn, dcubed, dsimms ! src/os/posix/vm/os_posix.cpp ! src/os/posix/vm/os_posix.hpp ! src/os/windows/vm/os_windows.cpp ! src/os/windows/vm/os_windows.hpp ! src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp ! src/os_cpu/linux_sparc/vm/os_linux_sparc.cpp ! src/os_cpu/linux_x86/vm/os_linux_x86.cpp ! src/os_cpu/solaris_sparc/vm/os_solaris_sparc.cpp ! src/os_cpu/solaris_x86/vm/os_solaris_x86.cpp ! src/share/vm/runtime/mutex.cpp ! src/share/vm/runtime/os.cpp ! src/share/vm/runtime/os.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/thread.hpp Changeset: 248c459b2b75 Author: dcubed Date: 2013-07-18 12:05 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/248c459b2b75 Merge ! src/share/vm/services/memTracker.cpp Changeset: af21010d1062 Author: dcubed Date: 2013-07-18 12:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/af21010d1062 Merge ! src/os/windows/vm/os_windows.cpp ! src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp ! src/os_cpu/linux_sparc/vm/os_linux_sparc.cpp ! src/os_cpu/linux_x86/vm/os_linux_x86.cpp ! src/os_cpu/solaris_sparc/vm/os_solaris_sparc.cpp ! src/os_cpu/solaris_x86/vm/os_solaris_x86.cpp ! src/share/vm/runtime/os.hpp Changeset: 02d7aa1456c9 Author: ccheung Date: 2013-07-18 14:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/02d7aa1456c9 8004872: Early loading of HashMap and StringValue under -XX:+AggressiveOpts can be removed Summary: this fix also removes the -XX:+UseStringCache option Reviewed-by: dholmes, acorn, iklam ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/thread.cpp Changeset: 383a5e21cc2d Author: minqi Date: 2013-07-18 18:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/383a5e21cc2d Merge Changeset: 060ae9b7ffea Author: mgronlun Date: 2013-07-19 17:56 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/060ae9b7ffea 8020547: Event based tracing needs a UNICODE string type Reviewed-by: egahlin, rbackman, dcubed, brutisso, acorn ! src/share/vm/trace/traceDataTypes.hpp ! src/share/vm/trace/tracetypes.xml ! src/share/vm/trace/xinclude.mod Changeset: 4614a598dae1 Author: minqi Date: 2013-07-19 08:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/4614a598dae1 8016538: volatile double access via Unsafe.cpp is not atomic Summary: volatile jdouble load/store is not atomic, fix by using of existing volatile jlong operations which are atomic for jdouble. Reviewed-by: kvn, vladidan, jrose Contributed-by: david.holmes at oracle.com ! src/os_cpu/bsd_x86/vm/orderAccess_bsd_x86.inline.hpp ! src/os_cpu/linux_x86/vm/orderAccess_linux_x86.inline.hpp ! src/os_cpu/solaris_x86/vm/orderAccess_solaris_x86.inline.hpp ! src/os_cpu/windows_x86/vm/orderAccess_windows_x86.inline.hpp Changeset: 55a61ceb2fe7 Author: minqi Date: 2013-07-19 11:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/55a61ceb2fe7 Merge Changeset: 16511b7e3d35 Author: emc Date: 2013-07-22 17:57 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/16511b7e3d35 8019632: Method parameters are not copied in clone_with_new_data Summary: Add code to copy method parameters data in clone_with_new_data Reviewed-by: coleenp, sspitsyn ! src/share/vm/oops/method.cpp Changeset: 72727c4b6dec Author: ccheung Date: 2013-07-19 14:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/72727c4b6dec 8020791: [TESTBUG] runtime/jsig/Test8017498.sh failed to compile native code Summary: Added -DLINUX to the gcc command and improved the .sh script Reviewed-by: dcubed, dholmes, minqi ! test/runtime/jsig/Test8017498.sh ! test/runtime/jsig/TestJNI.c Changeset: 5165d659cebd Author: minqi Date: 2013-07-22 22:21 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5165d659cebd Merge Changeset: c0f353803b47 Author: minqi Date: 2013-07-23 12:50 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c0f353803b47 Merge Changeset: c90c698831d7 Author: kvn Date: 2013-07-12 14:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c90c698831d7 8020215: Different execution plan when using JIT vs interpreter Summary: fix bytecode analyzer Reviewed-by: twisti ! src/share/vm/ci/bcEscapeAnalyzer.cpp ! src/share/vm/ci/bcEscapeAnalyzer.hpp + test/compiler/EscapeAnalysis/Test8020215.java Changeset: fcf521c3fbc6 Author: kvn Date: 2013-07-12 14:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/fcf521c3fbc6 8007898: Incorrect optimization of Memory Barriers in Matcher::post_store_load_barrier() Summary: generate one "fat" membar instead of set of barriers for volitile store Reviewed-by: roland ! src/share/vm/opto/matcher.cpp ! src/share/vm/opto/parse3.cpp + test/compiler/membars/DekkerTest.java Changeset: 34ce0b5acb81 Author: morris Date: 2013-07-15 06:27 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/34ce0b5acb81 Merge Changeset: 0f57ccdb9084 Author: kvn Date: 2013-07-15 10:28 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0f57ccdb9084 8020433: Crash when using -XX:+RestoreMXCSROnJNICalls Summary: remove StubRoutines::x86::_mxcsr_std and use StubRoutines::_mxcsr_std Reviewed-by: jrose ! src/cpu/x86/vm/stubGenerator_x86_64.cpp ! src/cpu/x86/vm/stubRoutines_x86_64.cpp ! src/cpu/x86/vm/stubRoutines_x86_64.hpp + test/compiler/cpuflags/RestoreMXCSR.java Changeset: 46a90f83df31 Author: morris Date: 2013-07-19 13:59 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/46a90f83df31 Merge ! src/cpu/x86/vm/stubGenerator_x86_64.cpp Changeset: 6efedc114807 Author: morris Date: 2013-07-24 13:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6efedc114807 Merge Changeset: 01aa164323fa Author: dholmes Date: 2013-07-24 19:23 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/01aa164323fa 8020799: Allow customization of hotspot source directories and files Reviewed-by: kvn, dlong ! make/linux/makefiles/vm.make Changeset: a4b9a8ec8f4a Author: jiangli Date: 2013-07-25 18:12 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a4b9a8ec8f4a Merge Changeset: 46487ba40ff2 Author: amurillo Date: 2013-07-26 03:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/46487ba40ff2 Merge Changeset: f6921c876db1 Author: amurillo Date: 2013-07-26 03:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f6921c876db1 Added tag hs25-b43 for changeset 46487ba40ff2 ! .hgtags Changeset: 7c9885d23744 Author: cl Date: 2013-08-01 04:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7c9885d23744 Added tag jdk8-b101 for changeset f6921c876db1 ! .hgtags Changeset: e84845884c85 Author: amurillo Date: 2013-07-26 04:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e84845884c85 8021566: new hotspot build - hs25-b44 Reviewed-by: jcoomes ! make/hotspot_version Changeset: d90d1b96b65b Author: kvn Date: 2013-07-26 12:37 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d90d1b96b65b 8008938: TieredCompilation should be default Summary: switch on TieredCompilation by default Reviewed-by: twisti ! src/cpu/sparc/vm/c2_globals_sparc.hpp ! src/cpu/x86/vm/c2_globals_x86.hpp Changeset: 1b6395189726 Author: minqi Date: 2013-07-19 14:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1b6395189726 8012263: ciReplay: gracefully exit & report meaningful error when replay data parsing fails Summary: find_method could return NULL so need explicitly check if there is error after parse_method, exit on error to avoid crash. Reviewed-by: kvn, twisti Contributed-by: yumin.qi at oracle.com ! src/share/vm/ci/ciReplay.cpp Changeset: 5ad7f8179bf7 Author: minqi Date: 2013-07-24 08:04 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5ad7f8179bf7 Merge Changeset: b6baf306e698 Author: fparain Date: 2013-07-26 05:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b6baf306e698 Merge Changeset: 83ca9dc4564d Author: fparain Date: 2013-07-26 15:24 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/83ca9dc4564d 8019845: Memory leak during class redefinition Reviewed-by: acorn, jmasa, coleenp, dcubed, mgerdin ! src/share/vm/memory/metaspace.cpp Changeset: f9ee986a9fea Author: ccheung Date: 2013-07-30 14:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f9ee986a9fea 8021296: [TESTBUG] Test8017498.sh fails to find "gcc" and fails to compile on some Linux releases Summary: Added checking for gcc and simplified the sig_handler() in the test case Reviewed-by: dcubed, coleenp, minqi, dlong ! test/runtime/6929067/Test6929067.sh ! test/runtime/7107135/Test7107135.sh ! test/runtime/jsig/Test8017498.sh ! test/runtime/jsig/TestJNI.c Changeset: 0f98cc013b21 Author: fparain Date: 2013-07-31 08:28 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0f98cc013b21 Merge Changeset: c65045599519 Author: dholmes Date: 2013-07-25 21:05 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c65045599519 8021314: minimal1.make needs to force off components not supported by the minimal VM Reviewed-by: coleenp, bpittore ! make/bsd/makefiles/minimal1.make ! make/linux/makefiles/minimal1.make Changeset: 078e5eb2e52e Author: clucasius Date: 2013-07-27 17:23 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/078e5eb2e52e Merge Changeset: da839a3c5735 Author: dholmes Date: 2013-07-31 19:05 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/da839a3c5735 Merge Changeset: e3c8767c5cf8 Author: tschatzl Date: 2013-07-24 10:07 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e3c8767c5cf8 8020123: Test gc/g1/TestPrintRegionRememberedSetInfo.java fails with "test result: Error. No action after @build" Summary: Remove the @build tag and replace it by a @run tag so that the test gets executed Reviewed-by: brutisso, mgerdin ! test/gc/g1/TestPrintRegionRememberedSetInfo.java Changeset: 7b06ae405d7b Author: jmasa Date: 2013-07-23 09:49 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7b06ae405d7b 6990419: CMS Remaining work for 6572569: consistently skewed work distribution in (long) re-mark pauses Reviewed-by: rasbold, tschatzl, jmasa Contributed-by: yamauchi at google.com ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp ! src/share/vm/memory/defNewGeneration.cpp ! src/share/vm/memory/generation.hpp ! src/share/vm/runtime/globals.hpp Changeset: fb7010c7c011 Author: jmasa Date: 2013-07-25 07:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/fb7010c7c011 Merge Changeset: ca9dedeebdec Author: jmasa Date: 2013-07-25 11:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ca9dedeebdec 6412968: CMS Long initial mark pauses Reviewed-by: rasbold, tschatzl, jmasa Contributed-by: yamauchi at google.com ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsOopClosures.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp ! src/share/vm/memory/sharedHeap.cpp ! src/share/vm/runtime/globals.hpp Changeset: 8796fd3ac898 Author: tamao Date: 2013-07-26 13:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8796fd3ac898 Merge ! src/share/vm/runtime/globals.hpp Changeset: 313227279a05 Author: brutisso Date: 2013-08-01 07:03 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/313227279a05 8021967: Deprecate -XX:DefaultMaxRAMFraction Reviewed-by: tschatzl, jmasa, kvn, tamao ! src/share/vm/runtime/arguments.cpp + test/gc/startup_warnings/TestDefaultMaxRAMFraction.java Changeset: dae8324fc7d1 Author: brutisso Date: 2013-08-01 09:35 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/dae8324fc7d1 8021879: G1: G1HeapRegionSize flag value not updated correctly Reviewed-by: tschatzl, jmasa ! src/share/vm/gc_implementation/g1/heapRegion.cpp + test/gc/arguments/TestG1HeapRegionSize.java Changeset: 8d4ff57af591 Author: brutisso Date: 2013-08-01 17:29 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8d4ff57af591 8022051: G1: Remove some unused G1 flags Reviewed-by: tschatzl, jmasa ! src/share/vm/gc_implementation/g1/g1_globals.hpp Changeset: 69d0dbb53c78 Author: tamao Date: 2013-08-01 17:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/69d0dbb53c78 Merge Changeset: 530fe88b3b2c Author: amurillo Date: 2013-08-02 02:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/530fe88b3b2c Merge Changeset: c4697c1c4484 Author: amurillo Date: 2013-08-02 02:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c4697c1c4484 Added tag hs25-b44 for changeset 530fe88b3b2c ! .hgtags From lana.steuck at oracle.com Tue Aug 6 17:17:01 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 07 Aug 2013 00:17:01 +0000 Subject: hg: jdk8/tl/langtools: 4 new changesets Message-ID: <20130807001717.0D2A148641@hg.openjdk.java.net> Changeset: 4c42fba7b0e7 Author: cl Date: 2013-08-01 04:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4c42fba7b0e7 Added tag jdk8-b101 for changeset 0324dbf07b0f ! .hgtags Changeset: 453a305e1165 Author: lana Date: 2013-08-06 10:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/453a305e1165 Merge Changeset: f3ea20a6e958 Author: lana Date: 2013-08-06 17:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f3ea20a6e958 Merge Changeset: b926dc251be8 Author: lana Date: 2013-08-06 17:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b926dc251be8 Merge From lana.steuck at oracle.com Tue Aug 6 17:19:12 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 07 Aug 2013 00:19:12 +0000 Subject: hg: jdk8/tl/jdk: 28 new changesets Message-ID: <20130807002511.5A6A848643@hg.openjdk.java.net> Changeset: b52a2ecdb803 Author: cl Date: 2013-08-01 04:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b52a2ecdb803 Added tag jdk8-b101 for changeset 690161232823 ! .hgtags Changeset: 2978c0a543ed Author: prr Date: 2013-07-22 12:52 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2978c0a543ed 7196866: CTW fails on all Solaris platforms Reviewed-by: prr, jrose, twisti, kvn ! src/solaris/native/sun/awt/awt_GraphicsEnv.c ! src/solaris/native/sun/java2d/x11/XRBackendNative.c Changeset: 784589c7bc55 Author: vadim Date: 2013-07-24 13:38 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/784589c7bc55 8008782: NPE in TrueTypeGlyphMapper Reviewed-by: bae, prr ! src/share/classes/sun/font/TrueTypeFont.java Changeset: db2e3a686cf3 Author: jchen Date: 2013-07-24 12:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/db2e3a686cf3 8011709: [parfait] False positive: memory leak in jdk/src/share/native/sun/font/layout/CanonShaping.cpp Reviewed-by: jgodinez, prr ! src/share/native/sun/font/layout/CanonShaping.cpp Changeset: c2e27e7a42ae Author: jchen Date: 2013-07-24 13:05 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c2e27e7a42ae 8005126: [parfait] #418 - #428 XRBackendNative.c Integer overflow Reviewed-by: prr, vadim ! src/solaris/native/sun/java2d/x11/XRBackendNative.c Changeset: 833f05116f7b Author: bae Date: 2013-07-25 17:14 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/833f05116f7b 8019201: Regression: java.awt.image.ConvolveOp throws java.awt.image.ImagingOpException Reviewed-by: prr ! src/share/native/sun/awt/medialib/awt_ImagingLib.c + test/sun/awt/image/ImagingLib/SamePackingTypeTest.java Changeset: a8b9df782017 Author: serb Date: 2013-07-26 21:18 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a8b9df782017 7190349: [macosx] Text (Label) is incorrectly drawn with a rotated g2d 8013569: [macosx] JLabel preferred size incorrect on retina displays with non-default font size Reviewed-by: prr ! src/macosx/classes/sun/font/CStrike.java ! src/macosx/native/sun/font/AWTStrike.h ! src/macosx/native/sun/font/AWTStrike.m ! src/macosx/native/sun/font/CGGlyphImages.m + test/java/awt/Graphics2D/DrawString/DrawRotatedString.java + test/java/awt/Graphics2D/IncorrectTextSize/IncorrectTextSize.java Changeset: 467a0c21790b Author: jgodinez Date: 2013-07-26 15:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/467a0c21790b 8020208: NullPointerException at sun.print.Win32PrintService.getMediaPrintables Reviewed-by: jchen, prr ! src/windows/classes/sun/print/Win32PrintService.java Changeset: 56c6f9a9653d Author: jgodinez Date: 2013-07-26 15:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/56c6f9a9653d 8016343: [macosx] Print job goes to default printer regardless of chosen printer Reviewed-by: jchen, prr ! src/share/classes/sun/print/PSPrinterJob.java ! src/solaris/classes/sun/print/IPPPrintService.java ! src/solaris/classes/sun/print/UnixPrintJob.java ! test/javax/print/DialogMargins.java Changeset: 1c48544c3da9 Author: lana Date: 2013-07-26 15:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1c48544c3da9 Merge - src/share/classes/com/sun/org/apache/xml/internal/security/resource/log4j.properties - src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/FuncHereContext.java - src/share/classes/com/sun/org/apache/xml/internal/security/utils/CachedXPathAPIHolder.java - src/share/classes/com/sun/org/apache/xml/internal/security/utils/CachedXPathFuncHereAPI.java - src/share/classes/com/sun/org/apache/xml/internal/security/utils/XPathFuncHereAPI.java - src/share/classes/java/util/stream/StreamBuilder.java - src/share/classes/javax/security/auth/callback/package.html - src/share/classes/javax/security/auth/kerberos/package.html - src/share/classes/javax/security/auth/login/package.html - src/share/classes/javax/security/auth/package.html - src/share/classes/javax/security/auth/spi/package.html - src/share/classes/javax/security/auth/x500/package.html - src/share/classes/javax/security/cert/package.html - src/share/classes/javax/security/sasl/package.html - test/java/util/Collections/EmptySortedSet.java Changeset: 921338e44ba7 Author: lana Date: 2013-07-26 17:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/921338e44ba7 Merge Changeset: 046025f78ea8 Author: jgodinez Date: 2013-07-30 13:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/046025f78ea8 8021835: Fix for 8016343 will not compile on Windows. Reviewed-by: jchen, prr ! src/share/classes/sun/print/PSPrinterJob.java Changeset: 7f0e569c5a66 Author: bae Date: 2013-07-31 13:11 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7f0e569c5a66 8020983: OutOfMemoryError caused by non garbage collected JPEGImageWriter Instances Reviewed-by: prr, flar ! src/share/native/sun/awt/image/jpeg/imageioJPEG.c + test/javax/imageio/plugins/jpeg/JpegWriterLeakTest.java Changeset: 607ad960fe24 Author: malenkov Date: 2013-07-22 15:36 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/607ad960fe24 8019975: closed/javax/swing/JFileChooser/4966171/bug4966171.java throws java.io.NotSerializableException: javax.swing.plaf.basic.BasicFileChooserUI$AcceptAllFileFilter Reviewed-by: alexsch ! src/share/classes/javax/swing/JFileChooser.java Changeset: 3cbe376233a9 Author: malenkov Date: 2013-07-22 20:33 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3cbe376233a9 8015926: NPE when using SynthTreeUI's expandPath() Reviewed-by: alexsch ! src/share/classes/javax/swing/plaf/synth/SynthTreeUI.java + test/javax/swing/plaf/synth/Test8015926.java Changeset: bdad697c03aa Author: pchelko Date: 2013-07-23 13:09 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bdad697c03aa 7184951: [macosx] Exception at java.awt.datatransfer on headless mode (only in GUI session) Reviewed-by: art, anthony ! src/macosx/classes/sun/lwawt/macosx/CDataTransferer.java Changeset: 99ee6ddab113 Author: serb Date: 2013-07-24 17:14 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/99ee6ddab113 8017189: [macosx] AWT program menu disabled on Mac Reviewed-by: leonidr, anthony ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/macosx/native/sun/awt/AWTWindow.h ! src/macosx/native/sun/awt/AWTWindow.m ! src/macosx/native/sun/awt/CMenuBar.m Changeset: 7bd6eda2d217 Author: leonidr Date: 2013-07-26 16:22 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7bd6eda2d217 8007267: [macosx] com.apple.eawt.Application.setDefaultMenuBar is not working Reviewed-by: anthony, serb ! src/macosx/classes/com/apple/eawt/_AppMenuBarHandler.java ! src/macosx/classes/sun/lwawt/macosx/CMenuComponent.java ! src/macosx/native/sun/awt/AWTWindow.m ! src/macosx/native/sun/awt/CMenuItem.m Changeset: 65c90209edbb Author: lana Date: 2013-07-26 15:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/65c90209edbb Merge - src/share/classes/com/sun/org/apache/xml/internal/security/resource/log4j.properties - src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/FuncHereContext.java - src/share/classes/com/sun/org/apache/xml/internal/security/utils/CachedXPathAPIHolder.java - src/share/classes/com/sun/org/apache/xml/internal/security/utils/CachedXPathFuncHereAPI.java - src/share/classes/com/sun/org/apache/xml/internal/security/utils/XPathFuncHereAPI.java - src/share/classes/java/util/stream/StreamBuilder.java - src/share/classes/javax/security/auth/callback/package.html - src/share/classes/javax/security/auth/kerberos/package.html - src/share/classes/javax/security/auth/login/package.html - src/share/classes/javax/security/auth/package.html - src/share/classes/javax/security/auth/spi/package.html - src/share/classes/javax/security/auth/x500/package.html - src/share/classes/javax/security/cert/package.html - src/share/classes/javax/security/sasl/package.html - test/java/util/Collections/EmptySortedSet.java Changeset: 37016eaea5d2 Author: serb Date: 2013-07-29 16:57 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/37016eaea5d2 6230360: Spelling mistake in documentation for AWT: 1.4, 1.5, 1.6, 1.7 Reviewed-by: malenkov, art ! src/share/classes/java/awt/AWTException.java Changeset: bf80c2965a84 Author: malenkov Date: 2013-07-29 18:48 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bf80c2965a84 8010782: clean up source files containing carriage return characters Reviewed-by: alexsch, art ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth.properties Changeset: 1e482f58c747 Author: ant Date: 2013-07-30 16:15 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1e482f58c747 8020927: JLightweightFrame API should export layout properties change notifications Reviewed-by: anthony ! src/share/classes/sun/swing/JLightweightFrame.java ! src/share/classes/sun/swing/LightweightContent.java Changeset: 336a94dbecb5 Author: malenkov Date: 2013-07-30 17:46 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/336a94dbecb5 8015300: JComboBox text sometimes become selected, sometimes not (Windows LAF) Reviewed-by: alexsch, serb ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsComboBoxUI.java + test/javax/swing/JComboBox/8015300/Test8015300.java Changeset: 726ac8f75b54 Author: lana Date: 2013-07-31 12:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/726ac8f75b54 Merge Changeset: 0741b19835b0 Author: lana Date: 2013-07-31 13:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0741b19835b0 Merge - src/share/classes/java/net/package.html Changeset: 8ed8e2b4b90e Author: lana Date: 2013-08-06 10:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8ed8e2b4b90e Merge Changeset: 2bc9ce1aade5 Author: lana Date: 2013-08-06 17:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2bc9ce1aade5 Merge Changeset: 7ab5f19a9a31 Author: lana Date: 2013-08-06 17:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7ab5f19a9a31 Merge From henry.jen at oracle.com Tue Aug 6 17:43:18 2013 From: henry.jen at oracle.com (henry.jen at oracle.com) Date: Wed, 07 Aug 2013 00:43:18 +0000 Subject: hg: jdk8/tl/jdk: 8022446: Fix serial warnings in java.util.stream Message-ID: <20130807004332.2400448644@hg.openjdk.java.net> Changeset: e303c228bf31 Author: henryjen Date: 2013-08-06 17:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e303c228bf31 8022446: Fix serial warnings in java.util.stream Reviewed-by: darcy ! src/share/classes/java/util/stream/AbstractShortCircuitTask.java ! src/share/classes/java/util/stream/AbstractTask.java ! src/share/classes/java/util/stream/FindOps.java ! src/share/classes/java/util/stream/ForEachOps.java ! src/share/classes/java/util/stream/MatchOps.java ! src/share/classes/java/util/stream/Nodes.java ! src/share/classes/java/util/stream/ReduceOps.java ! src/share/classes/java/util/stream/SliceOps.java From lana.steuck at oracle.com Tue Aug 6 17:16:51 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 07 Aug 2013 00:16:51 +0000 Subject: hg: jdk8/tl: Added tag jdk8-b101 for changeset 9f74a220677d Message-ID: <20130807001651.B35284863B@hg.openjdk.java.net> Changeset: 5eb3c1dc348f Author: cl Date: 2013-08-01 04:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/5eb3c1dc348f Added tag jdk8-b101 for changeset 9f74a220677d ! .hgtags From dan.xu at oracle.com Tue Aug 6 18:16:57 2013 From: dan.xu at oracle.com (dan.xu at oracle.com) Date: Wed, 07 Aug 2013 01:16:57 +0000 Subject: hg: jdk8/tl/jdk: 8022478: Fix Warnings In sun.net.www.protocol.http Package Message-ID: <20130807011708.86F7148645@hg.openjdk.java.net> Changeset: 1d21ff5c2b3f Author: dxu Date: 2013-08-06 18:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1d21ff5c2b3f 8022478: Fix Warnings In sun.net.www.protocol.http Package Reviewed-by: darcy ! src/share/classes/sun/net/www/protocol/http/AuthCacheValue.java ! src/share/classes/sun/net/www/protocol/http/AuthenticationInfo.java From mike.duigou at oracle.com Tue Aug 6 18:21:43 2013 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Wed, 07 Aug 2013 01:21:43 +0000 Subject: hg: jdk8/tl/jdk: 8022476: cleanup some raw types and unchecked warnings in java.util.stream Message-ID: <20130807012155.28BBF48646@hg.openjdk.java.net> Changeset: e117fcdd2176 Author: mduigou Date: 2013-08-06 18:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e117fcdd2176 8022476: cleanup some raw types and unchecked warnings in java.util.stream Reviewed-by: darcy Contributed-by: mike.duigou at oracle.com, henry.jen at oracle.com ! src/share/classes/java/util/Optional.java ! src/share/classes/java/util/stream/AbstractPipeline.java ! src/share/classes/java/util/stream/AbstractShortCircuitTask.java ! src/share/classes/java/util/stream/DoublePipeline.java ! src/share/classes/java/util/stream/IntPipeline.java ! src/share/classes/java/util/stream/LongPipeline.java ! src/share/classes/java/util/stream/Nodes.java ! src/share/classes/java/util/stream/ReduceOps.java ! src/share/classes/java/util/stream/ReferencePipeline.java ! src/share/classes/java/util/stream/Sink.java ! src/share/classes/java/util/stream/SortedOps.java ! src/share/classes/java/util/stream/StreamSpliterators.java From erik.joelsson at oracle.com Wed Aug 7 02:37:00 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Wed, 07 Aug 2013 11:37:00 +0200 Subject: RFR: 8015145: Smartjavac needs more flexibility with linking to sources In-Reply-To: <51F2DEA5.4020404@oracle.com> References: <51B1D57A.3030305@oracle.com> <51F2DEA5.4020404@oracle.com> Message-ID: <5202153C.4020509@oracle.com> On 2013-07-26 22:40, Jonathan Gibbons wrote: > I am concerned by the preceding comment, starting line 255. > > 255 // Always reuse -src for linking as well! This means > that we might > 256 // get two -sourcepath on the commandline after the > rewrite, which is > 257 // fine. We can have as many as we like. > > Yes, you can put as many -sourcepath options as you want, but as far > as javac > is concerned, "last one wins". If you want all the options to be > significant in the > child javac commands, you need to join the values. > I have reworded the comment, explaining that they are indeed joined later, before being handed to javac. I also added a test for the usecase I'm describing below and made the Sjavac tests runnable by jtreg. http://cr.openjdk.java.net/~erikj/8015145/webrev.langtools.02/ /Erik > -- Jon > > On 06/07/2013 05:43 AM, Erik Joelsson wrote: >> Here is a patch solving a problem with -sourcepath for sjavac. >> >> First some background. The security sources (the ones that require >> signing) need to be built to a separate directory. If they aren't (as >> is the case now) security tests will fail if run on the exploded jdk >> image (the one you get when just typing make or make jdk). In >> JDK-8009280, I'm trying to fix this. The solution I have for that bug >> is working well, except when running with sjavac, and basically >> builds all classes except the security classes first to the normal >> outputdir and then as a separate step builds just the security >> classes to a different outputdir. >> >> There are two issues that need to be addressed in sjavac for this to >> work. First, it needs to be possible to supply the same source root >> both to the -src and -sourcepath option (but with different filter >> rules). Sjavac is very picky and only links to sources that are >> included in either of those options, and since we are excluding the >> security sources from -src, we need to add them to -sourcepath. >> >> The second thing is more of a bug as far as I can tell. Sjavac >> compares the found set of sources to compile with what the makefile >> think needs to be compiled, as a safety check. Currently, sjavac is >> including sources that are just being linked to in this comparison. I >> would think that it should only include sources that are meant to be >> compiled. >> >> http://cr.openjdk.java.net/~erikj/8015145/webrev.langtools.01/ >> >> http://bugs.sun.com/view_bug.do?bug_id=8015145 >> >> /Erik > From vicente.romero at oracle.com Wed Aug 7 02:41:49 2013 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Wed, 07 Aug 2013 09:41:49 +0000 Subject: hg: jdk8/tl/langtools: 8020997: TreeMaker.AnnotationBuilder creates broken element literals with repeating annotations Message-ID: <20130807094204.96FBC48665@hg.openjdk.java.net> Changeset: f3deeccbf4cf Author: vromero Date: 2013-08-07 10:41 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f3deeccbf4cf 8020997: TreeMaker.AnnotationBuilder creates broken element literals with repeating annotations Reviewed-by: jjg, jfranck ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java + test/tools/javac/T8020997/CannotCompileRepeatedAnnoTest.java From vicente.romero at oracle.com Wed Aug 7 03:11:08 2013 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Wed, 07 Aug 2013 10:11:08 +0000 Subject: hg: jdk8/tl/langtools: 8008274: javac should not reference/use sample code Message-ID: <20130807101110.F276C48668@hg.openjdk.java.net> Changeset: c7dcf899ffff Author: vromero Date: 2013-08-07 11:04 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c7dcf899ffff 8008274: javac should not reference/use sample code Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/Main.java From weijun.wang at oracle.com Wed Aug 7 04:07:15 2013 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Wed, 07 Aug 2013 11:07:15 +0000 Subject: hg: jdk8/tl/jdk: 7151062: [macosx] SCDynamicStore prints error messages to stderr Message-ID: <20130807110825.4E6F348669@hg.openjdk.java.net> Changeset: 906dd23334c1 Author: weijun Date: 2013-08-07 19:06 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/906dd23334c1 7151062: [macosx] SCDynamicStore prints error messages to stderr Reviewed-by: xuelei ! src/macosx/native/java/util/SCDynamicStoreConfig.m From sundararajan.athijegannathan at oracle.com Wed Aug 7 05:47:00 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Wed, 07 Aug 2013 12:47:00 +0000 Subject: hg: jdk8/tl/jdk: 8022483: Nashorn compatibility issues in jhat's OQL feature Message-ID: <20130807124753.CE61248677@hg.openjdk.java.net> Changeset: 99f4319763a9 Author: sundar Date: 2013-08-07 18:16 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/99f4319763a9 8022483: Nashorn compatibility issues in jhat's OQL feature Reviewed-by: lagergren, attila, hannesw ! src/share/classes/com/sun/tools/hat/resources/hat.js ! src/share/classes/com/sun/tools/hat/resources/oqlhelp.html From xuelei.fan at oracle.com Wed Aug 7 06:43:10 2013 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Wed, 07 Aug 2013 13:43:10 +0000 Subject: hg: jdk8/tl/jdk: 8013809: deadlock in SSLSocketImpl between between write and close Message-ID: <20130807134325.C4A2E48679@hg.openjdk.java.net> Changeset: 8c7cf4926157 Author: xuelei Date: 2013-08-07 06:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8c7cf4926157 8013809: deadlock in SSLSocketImpl between between write and close Reviewed-by: wetmore ! src/share/classes/sun/security/ssl/SSLSocketImpl.java From adomurad at redhat.com Wed Aug 7 07:13:54 2013 From: adomurad at redhat.com (Adam Domurad) Date: Wed, 07 Aug 2013 10:13:54 -0400 Subject: Request for comments, very slow compilation with super-overloaded methods In-Reply-To: <51FB7EA4.4050005@oracle.com> References: <51A6526D.7080006@redhat.com> <51A71024.9090700@oracle.com> <51A77C37.6070806@redhat.com> <51A77ECA.80004@oracle.com> <51FAB861.50709@redhat.com> <51FB7EA4.4050005@oracle.com> Message-ID: <52025622.6020800@redhat.com> On 08/02/2013 05:40 AM, Vicente-Arturo Romero-Zaldivar wrote: > Hi Adam, > > The bug has been solved and pushed into JDK 7 mainstream. > > bug id: JDK-8015668: overload resolution: performance regression in JDK 7 > > the changeset is accessible here: > > http://hg.openjdk.java.net/jdk7u/jdk7u40-dev/langtools/rev/06285eb8d755 > > Sorry for the late update. > > Vicente. > > TYVM. So I assume the regression fix comes from a faster 'contains' method ? Happy hacking, -Adam From vicente.romero at oracle.com Wed Aug 7 07:34:09 2013 From: vicente.romero at oracle.com (Vicente-Arturo Romero-Zaldivar) Date: Wed, 07 Aug 2013 15:34:09 +0100 Subject: Request for comments, very slow compilation with super-overloaded methods In-Reply-To: <52025622.6020800@redhat.com> References: <51A6526D.7080006@redhat.com> <51A71024.9090700@oracle.com> <51A77C37.6070806@redhat.com> <51A77ECA.80004@oracle.com> <51FAB861.50709@redhat.com> <51FB7EA4.4050005@oracle.com> <52025622.6020800@redhat.com> Message-ID: <52025AE1.4090704@oracle.com> On 07/08/13 15:13, Adam Domurad wrote: > On 08/02/2013 05:40 AM, Vicente-Arturo Romero-Zaldivar wrote: >> Hi Adam, >> >> The bug has been solved and pushed into JDK 7 mainstream. >> >> bug id: JDK-8015668: overload resolution: performance regression in >> JDK 7 >> >> the changeset is accessible here: >> >> http://hg.openjdk.java.net/jdk7u/jdk7u40-dev/langtools/rev/06285eb8d755 >> >> Sorry for the late update. >> >> Vicente. >> >> > > TYVM. So I assume the regression fix comes from a faster 'contains' > method ? > > Happy hacking, > -Adam Exactly, the List.contains takes O(n) but the LinkedHashSet takes a constant time. Vicente. From joe.darcy at oracle.com Wed Aug 7 09:39:59 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Wed, 07 Aug 2013 16:39:59 +0000 Subject: hg: jdk8/tl/jdk: 8022454: Fixed various serializations and deprecation warnings in java.util, java.net and sun.tools Message-ID: <20130807164058.5468948686@hg.openjdk.java.net> Changeset: c1f129f62f36 Author: lagergren Date: 2013-08-07 08:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c1f129f62f36 8022454: Fixed various serializations and deprecation warnings in java.util, java.net and sun.tools Reviewed-by: darcy Contributed-by: marcus.lagergren at oracle.com ! src/share/classes/java/net/SocketAddress.java ! src/share/classes/java/util/logging/XMLFormatter.java ! src/share/classes/sun/tools/jar/JarException.java From dan.xu at oracle.com Wed Aug 7 12:13:55 2013 From: dan.xu at oracle.com (dan.xu at oracle.com) Date: Wed, 07 Aug 2013 19:13:55 +0000 Subject: hg: jdk8/tl/jdk: 8022554: Fix Warnings in sun.invoke.anon Package Message-ID: <20130807191425.1EC9648690@hg.openjdk.java.net> Changeset: d1c82d5bee3f Author: dxu Date: 2013-08-07 12:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d1c82d5bee3f 8022554: Fix Warnings in sun.invoke.anon Package Reviewed-by: darcy, mduigou, lancea ! src/share/classes/sun/invoke/anon/ConstantPoolPatch.java From bhavesh.x.patel at oracle.com Wed Aug 7 15:01:33 2013 From: bhavesh.x.patel at oracle.com (bhavesh.x.patel at oracle.com) Date: Wed, 07 Aug 2013 22:01:33 +0000 Subject: hg: jdk8/tl/langtools: 7198274: RFE : Javadoc Accessibility : Use CSS styles rather than or tags Message-ID: <20130807220139.563DB486A5@hg.openjdk.java.net> Changeset: 8c55df2442c1 Author: bpatel Date: 2013-08-07 15:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8c55df2442c1 7198274: RFE : Javadoc Accessibility : Use CSS styles rather than or tags Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractExecutableMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeRequiredMemberWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/EnumConstantWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/FieldWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/MethodWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/NestedClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PropertyWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/SubWriterHolderWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlStyle.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTree.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/stylesheet.css ! test/com/sun/javadoc/testClassCrossReferences/TestClassCrossReferences.java ! test/com/sun/javadoc/testExternalOverridenMethod/TestExternalOverridenMethod.java ! test/com/sun/javadoc/testHtmlDefinitionListTag/TestHtmlDefinitionListTag.java ! test/com/sun/javadoc/testInterface/TestInterface.java ! test/com/sun/javadoc/testJavaFX/TestJavaFX.java ! test/com/sun/javadoc/testMemberInheritence/TestMemberInheritence.java ! test/com/sun/javadoc/testMemberSummary/TestMemberSummary.java ! test/com/sun/javadoc/testNewLanguageFeatures/TestNewLanguageFeatures.java ! test/com/sun/javadoc/testOverridenMethods/TestOverridenMethodDocCopy.java ! test/com/sun/javadoc/testOverridenMethods/TestOverridenPrivateMethods.java ! test/com/sun/javadoc/testOverridenMethods/TestOverridenPrivateMethodsWithPackageFlag.java ! test/com/sun/javadoc/testOverridenMethods/TestOverridenPrivateMethodsWithPrivateFlag.java ! test/com/sun/javadoc/testPackageDeprecation/TestPackageDeprecation.java ! test/com/sun/javadoc/testPrivateClasses/TestPrivateClasses.java ! test/com/sun/javadoc/testSerializedFormDeprecationInfo/TestSerializedFormDeprecationInfo.java From bhavesh.x.patel at oracle.com Wed Aug 7 16:09:51 2013 From: bhavesh.x.patel at oracle.com (bhavesh.x.patel at oracle.com) Date: Wed, 07 Aug 2013 23:09:51 +0000 Subject: hg: jdk8/tl/langtools: 4749567: stddoclet: Add CSS style for setting header/footer to be italic Message-ID: <20130807230956.4B163486AA@hg.openjdk.java.net> Changeset: 33294f02c9a5 Author: bpatel Date: 2013-08-07 16:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/33294f02c9a5 4749567: stddoclet: Add CSS style for setting header/footer to be italic Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/HelpWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTree.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/stylesheet.css + test/com/sun/javadoc/testOptions/TestOptions.java + test/com/sun/javadoc/testOptions/pkg/Foo.java From alex.buckley at oracle.com Wed Aug 7 17:59:13 2013 From: alex.buckley at oracle.com (Alex Buckley) Date: Wed, 07 Aug 2013 17:59:13 -0700 Subject: about bug: 8020216: Compile time error isn't shown when final class variable is not assigned In-Reply-To: <51FAA194.3060005@oracle.com> References: <51F7CC00.2010000@oracle.com> <51FA9FFD.8050701@oracle.com> <51FAA194.3060005@oracle.com> Message-ID: <5202ED61.4080005@oracle.com> Each of the three final instance variables is not definitely assigned after the if-then-else, but JLS 16 only requires a compile-time error when such a variable is accessed. There's no access in the code below, so why is an error being given? Alex On 8/1/2013 10:57 AM, Vicente-Arturo Romero-Zaldivar wrote: > Hi Alex, > > Regarding the mentioned bug entry, I have a patch that solves the issue > but then I have the following example taken from javac code: > > private final TreePath treePath; > private final DocCommentTree docComment; > private final DocTreePath parent; > > public DocTreePath(DocTreePath p, DocTree t) { > if (t.getKind() == DocTree.Kind.DOC_COMMENT) { > throw new IllegalArgumentException("Use > DocTreePath(TreePath, DocCommentTree) to construct DocTreePath for a > DocCommentTree."); > } else { > treePath = p.treePath; > docComment = p.docComment; > parent = p; > } > leaf = t; > } > > with the patch javac says: > > error: variable treePath might not have been initialized > error: variable docComment might not have been initialized > error: variable parent might not have been initialized > > so this means that whenever we have such a code we will have to do: > > if (t.getKind() == DocTree.Kind.DOC_COMMENT) { > treePath = null; > docComment = null; > parent = null; > throw new IllegalArgumentException("Use > DocTreePath(TreePath, DocCommentTree) to construct DocTreePath for a > DocCommentTree."); > } else { > > another option is to set the fields to null at the end of the method. > > Is this what we want? I think the current state of flow analysis is > preferable but I wanted to double check before going on. > > Thanks, > Vicente From stuart.marks at oracle.com Wed Aug 7 16:25:51 2013 From: stuart.marks at oracle.com (stuart.marks at oracle.com) Date: Wed, 07 Aug 2013 23:25:51 +0000 Subject: hg: jdk8/tl/jdk: 8022479: clean up warnings from sun.tools.asm Message-ID: <20130807232621.8D617486AD@hg.openjdk.java.net> Changeset: 8c50c27418d3 Author: smarks Date: 2013-08-07 16:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8c50c27418d3 8022479: clean up warnings from sun.tools.asm Reviewed-by: lancea, darcy ! src/share/classes/sun/tools/asm/Assembler.java ! src/share/classes/sun/tools/asm/ConstantPool.java ! src/share/classes/sun/tools/asm/Instruction.java ! src/share/classes/sun/tools/asm/SwitchData.java ! src/share/classes/sun/tools/asm/TryData.java From john.r.rose at oracle.com Wed Aug 7 19:05:13 2013 From: john.r.rose at oracle.com (John Rose) Date: Wed, 7 Aug 2013 19:05:13 -0700 Subject: about bug: 8020216: Compile time error isn't shown when final class variable is not assigned In-Reply-To: <51FAA194.3060005@oracle.com> References: <51F7CC00.2010000@oracle.com> <51FA9FFD.8050701@oracle.com> <51FAA194.3060005@oracle.com> Message-ID: On Aug 1, 2013, at 10:57 AM, Vicente-Arturo Romero-Zaldivar wrote: > Is this what we want? No. For blank-final instance variables, the definite assignment is only required at *normal* completion of the constructor. Abnormal completion (such as the throw in your example) *must* be allowed to happen when blank-finals are still unassigned. Otherwise this code would fail: class HasBlankF { final int hc; HasBlankF(Object x) { hc = x.hashCode(); } } It would fail because there is a potential throw that works like this: class HasBlankF { final int hc; HasBlankF(Object x) { if (x == null) throw new NullPointerException(); hc = x.hashCode(); } } I added a comment to this effect on the bug report. The same point applies for abnormal completion of methods (static initializers). Blank finals which are statics must be definitely assigned at normal termination of the last static initializer. If a static initializer terminates abnormally, the class is not available to its users, and some of its blank finals may validly remain forever uninitialized. ? John -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20130807/b5dad15b/attachment.html From masayoshi.okutsu at oracle.com Wed Aug 7 21:52:43 2013 From: masayoshi.okutsu at oracle.com (masayoshi.okutsu at oracle.com) Date: Thu, 08 Aug 2013 04:52:43 +0000 Subject: hg: jdk8/tl/jdk: 8015986: Incorrect Localization of HijrahChronology Message-ID: <20130808045318.043F3486C2@hg.openjdk.java.net> Changeset: 0beaa65c90c8 Author: okutsu Date: 2013-08-08 13:51 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0beaa65c90c8 8015986: Incorrect Localization of HijrahChronology Reviewed-by: naoto Contributed-by: scolebourne at joda.org, roger.riggs at oracle.com ! make/tools/src/build/tools/cldrconverter/CLDRConverter.java ! make/tools/src/build/tools/cldrconverter/CalendarType.java ! src/share/classes/sun/text/resources/FormatData.java ! src/share/classes/sun/text/resources/ar/FormatData_ar.java ! test/java/time/test/java/time/format/TestNonIsoFormatter.java From alexey.utkin at oracle.com Wed Aug 7 22:19:00 2013 From: alexey.utkin at oracle.com (alexey.utkin at oracle.com) Date: Thu, 08 Aug 2013 05:19:00 +0000 Subject: hg: jdk8/tl/jdk: 7147084: (process) appA hangs when read output stream of appB which starts appC that runs forever Message-ID: <20130808051923.3FFD6486C5@hg.openjdk.java.net> Changeset: 2c4f1081a0fa Author: uta Date: 2013-08-08 09:16 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2c4f1081a0fa 7147084: (process) appA hangs when read output stream of appB which starts appC that runs forever Reviewed-by: alanb, robm, martin ! src/windows/classes/java/lang/ProcessImpl.java ! src/windows/native/java/lang/ProcessImpl_md.c + test/java/lang/ProcessBuilder/InheritIOEHandle.java + test/java/lang/ProcessBuilder/SiblingIOEHandle.java From vicente.romero at oracle.com Thu Aug 8 02:57:00 2013 From: vicente.romero at oracle.com (Vicente-Arturo Romero-Zaldivar) Date: Thu, 08 Aug 2013 10:57:00 +0100 Subject: about bug: 8020216: Compile time error isn't shown when final class variable is not assigned In-Reply-To: <5202ED61.4080005@oracle.com> References: <51F7CC00.2010000@oracle.com> <51FA9FFD.8050701@oracle.com> <51FAA194.3060005@oracle.com> <5202ED61.4080005@oracle.com> Message-ID: <52036B6C.4040808@oracle.com> Well this code sample was to show what problems a "fix" to bug 8020216 may imply. If you check the corresponding bug entry [1], there is another similar case and I'm writing you because there you added a comment saying that it should be a compiler error. Probably that case is different from this one. For me this is not an issue. Vicente [1] https://jbs.oracle.com/bugs/browse/JDK-8020216 PD. the comments I'm referring to are not present in http://bugs.sun.com/bugdatabase On 08/08/13 01:59, Alex Buckley wrote: > Each of the three final instance variables is not definitely assigned > after the if-then-else, but JLS 16 only requires a compile-time error > when such a variable is accessed. There's no access in the code below, > so why is an error being given? > > Alex > > On 8/1/2013 10:57 AM, Vicente-Arturo Romero-Zaldivar wrote: >> Hi Alex, >> >> Regarding the mentioned bug entry, I have a patch that solves the issue >> but then I have the following example taken from javac code: >> >> private final TreePath treePath; >> private final DocCommentTree docComment; >> private final DocTreePath parent; >> >> public DocTreePath(DocTreePath p, DocTree t) { >> if (t.getKind() == DocTree.Kind.DOC_COMMENT) { >> throw new IllegalArgumentException("Use >> DocTreePath(TreePath, DocCommentTree) to construct DocTreePath for a >> DocCommentTree."); >> } else { >> treePath = p.treePath; >> docComment = p.docComment; >> parent = p; >> } >> leaf = t; >> } >> >> with the patch javac says: >> >> error: variable treePath might not have been initialized >> error: variable docComment might not have been initialized >> error: variable parent might not have been initialized >> >> so this means that whenever we have such a code we will have to do: >> >> if (t.getKind() == DocTree.Kind.DOC_COMMENT) { >> treePath = null; >> docComment = null; >> parent = null; >> throw new IllegalArgumentException("Use >> DocTreePath(TreePath, DocCommentTree) to construct DocTreePath for a >> DocCommentTree."); >> } else { >> >> another option is to set the fields to null at the end of the method. >> >> Is this what we want? I think the current state of flow analysis is >> preferable but I wanted to double check before going on. >> >> Thanks, >> Vicente From vicente.romero at oracle.com Thu Aug 8 03:37:41 2013 From: vicente.romero at oracle.com (Vicente-Arturo Romero-Zaldivar) Date: Thu, 08 Aug 2013 11:37:41 +0100 Subject: about bug: 8020216: Compile time error isn't shown when final class variable is not assigned In-Reply-To: References: <51F7CC00.2010000@oracle.com> <51FA9FFD.8050701@oracle.com> <51FAA194.3060005@oracle.com> Message-ID: <520374F5.2050304@oracle.com> Hi John, Thanks for your answer. I agree with you. Vicente On 08/08/13 03:05, John Rose wrote: > On Aug 1, 2013, at 10:57 AM, Vicente-Arturo Romero-Zaldivar > > wrote: > >> Is this what we want? > > No. > > For blank-final instance variables, the definite assignment is only > required at *normal* completion of the constructor. Abnormal > completion (such as the throw in your example) *must* be allowed to > happen when blank-finals are still unassigned. Otherwise this code > would fail: > > class HasBlankF { > final int hc; > HasBlankF(Object x) { > hc = x.hashCode(); > } > } > > It would fail because there is a potential throw that works like this: > > class HasBlankF { > final int hc; > HasBlankF(Object x) { > if (x == null) throw new NullPointerException(); > hc = x.hashCode(); > } > } > > I added a comment to this effect on the bug report. > > The same point applies for abnormal completion of methods > (static initializers). Blank finals which are statics must be > definitely assigned at normal termination of the last static > initializer. If a static initializer terminates abnormally, the class > is not available to its users, and some of its blank finals may > validly remain forever uninitialized. > > ? John -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20130808/4659dd22/attachment.html From vicente.romero at oracle.com Thu Aug 8 03:49:52 2013 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Thu, 08 Aug 2013 10:49:52 +0000 Subject: hg: jdk8/tl/langtools: 8019486: javac, generates erroneous LVT for a test case with lambda code Message-ID: <20130808105013.81177486D1@hg.openjdk.java.net> Changeset: b8610a65fbf9 Author: vromero Date: 2013-08-08 11:49 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b8610a65fbf9 8019486: javac, generates erroneous LVT for a test case with lambda code Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java + test/tools/javac/T8019486/WrongLVTForLambdaTest.java From weijun.wang at oracle.com Thu Aug 8 06:13:28 2013 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Thu, 08 Aug 2013 13:13:28 +0000 Subject: hg: jdk8/tl/jdk: 8016594: Native Windows ccache still reads DES tickets Message-ID: <20130808131448.9A66E486D9@hg.openjdk.java.net> Changeset: b7d594716f86 Author: weijun Date: 2013-08-08 21:13 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b7d594716f86 8016594: Native Windows ccache still reads DES tickets Reviewed-by: dsamersoff, xuelei ! src/share/classes/sun/security/krb5/Credentials.java ! src/share/native/sun/security/krb5/nativeccache.c ! src/windows/native/sun/security/krb5/NativeCreds.c From sundararajan.athijegannathan at oracle.com Thu Aug 8 07:01:50 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Thu, 08 Aug 2013 14:01:50 +0000 Subject: hg: jdk8/tl/nashorn: 3 new changesets Message-ID: <20130808140155.13604486DB@hg.openjdk.java.net> Changeset: 9a3e3bb30db3 Author: attila Date: 2013-08-07 16:38 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/9a3e3bb30db3 8022509: Various Dynalink security enhancements Reviewed-by: jlaskey, hannesw ! src/jdk/internal/dynalink/ChainedCallSite.java ! src/jdk/internal/dynalink/DynamicLinkerFactory.java ! src/jdk/internal/dynalink/beans/ClassString.java ! src/jdk/internal/dynalink/beans/StaticClassLinker.java - src/jdk/internal/dynalink/support/Backport.java ! src/jdk/internal/dynalink/support/ClassMap.java ! src/jdk/internal/dynalink/support/Guards.java ! src/jdk/internal/dynalink/support/Lookup.java ! src/jdk/internal/dynalink/support/TypeConverterFactory.java ! src/jdk/nashorn/internal/runtime/linker/Bootstrap.java Changeset: dd79c04ef7df Author: sundar Date: 2013-08-08 16:38 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/dd79c04ef7df 8022524: Memory leaks in nashorn sources and tests found by jhat analysis Reviewed-by: attila, hannesw ! make/project.properties ! src/jdk/nashorn/internal/codegen/CompileUnit.java ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/objects/NativeArray.java ! src/jdk/nashorn/internal/objects/NativeDate.java ! src/jdk/nashorn/internal/objects/NativeJSON.java ! src/jdk/nashorn/internal/objects/NativeObject.java ! src/jdk/nashorn/internal/runtime/GlobalObject.java ! src/jdk/nashorn/internal/runtime/JSONFunctions.java ! src/jdk/nashorn/internal/runtime/ListAdapter.java ! src/jdk/nashorn/internal/runtime/RecompilableScriptFunctionData.java ! src/jdk/nashorn/internal/runtime/ScriptFunction.java ! src/jdk/nashorn/internal/runtime/UserAccessorProperty.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterClassLoader.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java ! test/script/basic/JDK-8020357.js ! test/src/jdk/nashorn/api/javaaccess/BooleanAccessTest.java ! test/src/jdk/nashorn/api/javaaccess/MethodAccessTest.java ! test/src/jdk/nashorn/api/javaaccess/NumberAccessTest.java ! test/src/jdk/nashorn/api/javaaccess/NumberBoxingTest.java ! test/src/jdk/nashorn/api/javaaccess/ObjectAccessTest.java ! test/src/jdk/nashorn/api/javaaccess/StringAccessTest.java ! test/src/jdk/nashorn/internal/codegen/CompilerTest.java ! test/src/jdk/nashorn/internal/parser/ParserTest.java Changeset: 0d7484bf8597 Author: sundar Date: 2013-08-08 18:19 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/0d7484bf8597 Merge - src/jdk/internal/dynalink/support/Backport.java From xueming.shen at oracle.com Thu Aug 8 12:00:49 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Thu, 08 Aug 2013 19:00:49 +0000 Subject: hg: jdk8/tl/jdk: 8015666: test/tools/pack200/TimeStamp.java failing Message-ID: <20130808190152.9A34248707@hg.openjdk.java.net> Changeset: a388263a7287 Author: sherman Date: 2013-08-08 12:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a388263a7287 8015666: test/tools/pack200/TimeStamp.java failing Summary: to keep the default behavior of ZOS unchanged, if ze extra time not explicitly set Reviewed-by: alanb, ksrini ! src/share/classes/java/util/zip/ZipConstants.java ! src/share/classes/java/util/zip/ZipEntry.java ! src/share/classes/java/util/zip/ZipFile.java ! src/share/classes/java/util/zip/ZipInputStream.java ! src/share/classes/java/util/zip/ZipOutputStream.java ! src/share/classes/java/util/zip/ZipUtils.java ! test/ProblemList.txt ! test/java/util/zip/TestExtraTime.java ! test/tools/pack200/TimeStamp.java From alex.buckley at oracle.com Thu Aug 8 13:36:25 2013 From: alex.buckley at oracle.com (Alex Buckley) Date: Thu, 08 Aug 2013 13:36:25 -0700 Subject: about bug: 8020216: Compile time error isn't shown when final class variable is not assigned In-Reply-To: <52036B6C.4040808@oracle.com> References: <51F7CC00.2010000@oracle.com> <51FA9FFD.8050701@oracle.com> <51FAA194.3060005@oracle.com> <5202ED61.4080005@oracle.com> <52036B6C.4040808@oracle.com> Message-ID: <52040149.1080005@oracle.com> Let's talk about the program in 8020216. A final static variable is not initialized in its own variable initializer or a static initializer, so the class should not compile. Please add a comment in 8020216 about whether that's going to be fixed in javac. Alex On 8/8/2013 2:57 AM, Vicente-Arturo Romero-Zaldivar wrote: > Well this code sample was to show what problems a "fix" to bug 8020216 > may imply. If you check the corresponding bug entry [1], there is > another similar case and I'm writing you because there you added a > comment saying that it should be a compiler error. Probably that case is > different from this one. For me this is not an issue. > > Vicente > > [1] https://jbs.oracle.com/bugs/browse/JDK-8020216 > > PD. the comments I'm referring to are not present in > http://bugs.sun.com/bugdatabase > > > On 08/08/13 01:59, Alex Buckley wrote: >> Each of the three final instance variables is not definitely assigned >> after the if-then-else, but JLS 16 only requires a compile-time error >> when such a variable is accessed. There's no access in the code below, >> so why is an error being given? >> >> Alex >> >> On 8/1/2013 10:57 AM, Vicente-Arturo Romero-Zaldivar wrote: >>> Hi Alex, >>> >>> Regarding the mentioned bug entry, I have a patch that solves the issue >>> but then I have the following example taken from javac code: >>> >>> private final TreePath treePath; >>> private final DocCommentTree docComment; >>> private final DocTreePath parent; >>> >>> public DocTreePath(DocTreePath p, DocTree t) { >>> if (t.getKind() == DocTree.Kind.DOC_COMMENT) { >>> throw new IllegalArgumentException("Use >>> DocTreePath(TreePath, DocCommentTree) to construct DocTreePath for a >>> DocCommentTree."); >>> } else { >>> treePath = p.treePath; >>> docComment = p.docComment; >>> parent = p; >>> } >>> leaf = t; >>> } >>> >>> with the patch javac says: >>> >>> error: variable treePath might not have been initialized >>> error: variable docComment might not have been initialized >>> error: variable parent might not have been initialized >>> >>> so this means that whenever we have such a code we will have to do: >>> >>> if (t.getKind() == DocTree.Kind.DOC_COMMENT) { >>> treePath = null; >>> docComment = null; >>> parent = null; >>> throw new IllegalArgumentException("Use >>> DocTreePath(TreePath, DocCommentTree) to construct DocTreePath for a >>> DocCommentTree."); >>> } else { >>> >>> another option is to set the fields to null at the end of the method. >>> >>> Is this what we want? I think the current state of flow analysis is >>> preferable but I wanted to double check before going on. >>> >>> Thanks, >>> Vicente > From jason.uh at oracle.com Thu Aug 8 17:07:19 2013 From: jason.uh at oracle.com (jason.uh at oracle.com) Date: Fri, 09 Aug 2013 00:07:19 +0000 Subject: hg: jdk8/tl/jdk: 8022461: Fix lint warnings in sun.security.{provider, rsa, x509} Message-ID: <20130809000738.593224872F@hg.openjdk.java.net> Changeset: 67edbf7e6b26 Author: juh Date: 2013-08-08 17:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/67edbf7e6b26 8022461: Fix lint warnings in sun.security.{provider,rsa,x509} Reviewed-by: darcy, weijun, xuelei, mullan ! src/share/classes/sun/security/provider/DSAPublicKey.java ! src/share/classes/sun/security/rsa/RSAPublicKeyImpl.java ! src/share/classes/sun/security/rsa/RSASignature.java ! src/share/classes/sun/security/x509/AlgIdDSA.java ! src/share/classes/sun/security/x509/X509Key.java From jose.cornado at gmail.com Thu Aug 8 17:43:03 2013 From: jose.cornado at gmail.com (=?ISO-8859-1?Q?Jos=E9_Cornado?=) Date: Thu, 8 Aug 2013 18:43:03 -0600 Subject: Problems with "-implicit:none" Message-ID: Hello! I have the following problem with javax.tools.JavaCompiler: A background jvm, depending on user input from IDE, generates classes dynamically. This can take time, so to avoid the delay I use the flag "-implicit:none". The IDE provides enough data I can infer if everything is in place and stick to parse/build just the target class. Because I don't write some streams to disk there are a lot of cases where the *.class is in the correct directory but the *.java does not exist. Now the problem: If the target class imports a type from another package/location the flag works great. If the target class imports a class from the same location the JavaCompiler completely ignores this flag and the fact that the *.class exists and looks for the source file which doesn't exist and fails. Question 1: is this the expected behavior of the compiler. Question 2: would avoid importing type from the same package change the behavior of the compiler in anyway? I am running build 1.7.0_25-b15 on a mac Thanks a lot in advance!!! -- Jos? Cornado -- home: http://www.efekctive.com blog: http://blogging.efekctive.com ---------------------- Everything has been said before, but since nobody listens we have to keep going back and beginning all over again. Andre Gide -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20130808/28e556d2/attachment.html From jonathan.gibbons at oracle.com Thu Aug 8 18:19:19 2013 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Thu, 08 Aug 2013 18:19:19 -0700 Subject: Problems with "-implicit:none" In-Reply-To: References: Message-ID: <52044397.7020705@oracle.com> Jos?, -implicit:none is intended to affect any/all source files which are read by the compiler in order to complete a compilation, but which are not explicitly specified on the command line. The package name is irrelevant; the important factor is whether it is specified on the javac command line or not. Note that IDEs and other systems for driving javac, (like Ant) may muddy the waters somewhat by determining for themselves what they think should best appear on the javac command line. If you are using such tools, I suggest you carefully examine the set of files being fed to javac. -- Jon On 08/08/2013 05:43 PM, Jos? Cornado wrote: > Hello! > > I have the following problem with javax.tools.JavaCompiler: > > A background jvm, depending on user input from IDE, generates classes > dynamically. > > This can take time, so to avoid the delay I use the flag > "-implicit:none". The IDE provides enough data I can infer if > everything is in place and stick to parse/build just the target class. > Because I don't write some streams to disk there are a lot of cases > where the *.class is in the correct directory but the *.java does not > exist. > > Now the problem: > > If the target class imports a type from another package/location the > flag works great. If the target class imports a class from the same > location the JavaCompiler completely ignores this flag and the fact > that the *.class exists and looks for the source file which doesn't > exist and fails. > > Question 1: is this the expected behavior of the compiler. > > Question 2: would avoid importing type from the same package change > the behavior of the compiler in anyway? > > I am running build 1.7.0_25-b15 on a mac > > > Thanks a lot in advance!!! > > -- > Jos? Cornado > > -- > > home: http://www.efekctive.com > blog: http://blogging.efekctive.com > ---------------------- > > Everything has been said before, but since nobody listens we have to > keep going back and beginning all over again. > > Andre Gide From weijun.wang at oracle.com Thu Aug 8 20:42:53 2013 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Fri, 09 Aug 2013 03:42:53 +0000 Subject: hg: jdk8/tl/jdk: 8021788: JarInputStream doesn't provide certificates for some file under META-INF Message-ID: <20130809034314.C36B848735@hg.openjdk.java.net> Changeset: 758e3117899c Author: weijun Date: 2013-08-09 11:41 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/758e3117899c 8021788: JarInputStream doesn't provide certificates for some file under META-INF Reviewed-by: chegar, sherman ! src/share/classes/java/util/jar/JarVerifier.java + test/java/util/jar/JarInputStream/ExtraFileInMetaInf.java From xueming.shen at oracle.com Thu Aug 8 23:39:17 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Fri, 09 Aug 2013 06:39:17 +0000 Subject: hg: jdk8/tl/jdk: 6614237: missing codepage Cp290 at java runtime Message-ID: <20130809063942.0D9734873B@hg.openjdk.java.net> Changeset: 54f0ccdd9ad7 Author: sherman Date: 2013-08-08 23:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/54f0ccdd9ad7 6614237: missing codepage Cp290 at java runtime Summary: to add charset Cp290 and Cp300 Reviewed-by: okutsu + make/tools/CharsetMapping/IBM290.c2b + make/tools/CharsetMapping/IBM290.map + make/tools/CharsetMapping/IBM300.c2b + make/tools/CharsetMapping/IBM300.map ! make/tools/CharsetMapping/dbcs ! make/tools/CharsetMapping/extsbcs ! make/tools/src/build/tools/charsetmapping/DBCS.java ! src/share/classes/sun/nio/cs/ext/ExtendedCharsets.java From paul.sandoz at oracle.com Fri Aug 9 02:55:25 2013 From: paul.sandoz at oracle.com (paul.sandoz at oracle.com) Date: Fri, 09 Aug 2013 09:55:25 +0000 Subject: hg: jdk8/tl/jdk: 8022326: Spliterator for values of j.u.c.ConcurrentSkipListMap does not report ORDERED Message-ID: <20130809095620.E542848740@hg.openjdk.java.net> Changeset: c29ca19cb816 Author: psandoz Date: 2013-08-09 11:44 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c29ca19cb816 8022326: Spliterator for values of j.u.c.ConcurrentSkipListMap does not report ORDERED Reviewed-by: martin, chegar ! src/share/classes/java/util/TreeMap.java ! src/share/classes/java/util/concurrent/ConcurrentSkipListMap.java ! test/java/util/Spliterator/SpliteratorCharacteristics.java From chris.hegarty at oracle.com Fri Aug 9 05:50:52 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Fri, 09 Aug 2013 12:50:52 +0000 Subject: hg: jdk8/tl/jdk: 8022661: InetAddress.writeObject() performs flush() on object output stream Message-ID: <20130809125140.B289D48748@hg.openjdk.java.net> Changeset: 84004d0e3fdd Author: chegar Date: 2013-08-09 13:50 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/84004d0e3fdd 8022661: InetAddress.writeObject() performs flush() on object output stream Reviewed-by: michaelm, alanb ! src/share/classes/java/net/InetAddress.java From jose.cornado at gmail.com Fri Aug 9 06:37:26 2013 From: jose.cornado at gmail.com (=?ISO-8859-1?Q?Jos=E9_Cornado?=) Date: Fri, 9 Aug 2013 07:37:26 -0600 Subject: Problems with "-implicit:none" Message-ID: Hello! I have the following problem with javax.tools.JavaCompiler: A background jvm, depending on user input from IDE, generates classes dynamically. This can take time, so to avoid the delay I use the flag "-implicit:none". The IDE provides enough data I can infer if everything is in place and stick to parse/build just the target class. Because I don't write some streams to disk there are a lot of cases where the *.class is in the correct directory but the *.java does not exist. Now the problem: If the target class imports a type from another package/location the flag works great. If the target class imports a class from the same location the JavaCompiler completely ignores this flag and the fact that the *.class exists and looks for the source file which doesn't exist and fails. Question 1: is this the expected behavior of the compiler. Question 2: would avoid importing type from the same package change the behavior of the compiler in anyway? I am running build 1.7.0_25-b15 on a mac Thanks a lot in advance!!! -- Jos? Cornado -- home: http://www.efekctive.com blog: http://blogging.efekctive.com ---------------------- Everything has been said before, but since nobody listens we have to keep going back and beginning all over again. Andre Gide -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20130809/c3329b03/attachment-0001.html From chris.hegarty at oracle.com Fri Aug 9 09:57:08 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Fri, 09 Aug 2013 16:57:08 +0000 Subject: hg: jdk8/tl/jdk: 8022724: lint warnings in j.u.concurrent packages Message-ID: <20130809165838.A48BB48759@hg.openjdk.java.net> Changeset: ce1c874903cb Author: dl Date: 2013-08-09 17:56 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ce1c874903cb 8022724: lint warnings in j.u.concurrent packages Reviewed-by: chegar, lancea, darcy ! src/share/classes/java/util/concurrent/CompletableFuture.java ! src/share/classes/java/util/concurrent/ConcurrentHashMap.java ! src/share/classes/java/util/concurrent/atomic/Striped64.java From dan.xu at oracle.com Fri Aug 9 10:55:59 2013 From: dan.xu at oracle.com (dan.xu at oracle.com) Date: Fri, 09 Aug 2013 17:55:59 +0000 Subject: hg: jdk8/tl/jdk: 8021977: Opening a file using java.io can throw IOException on Windows Message-ID: <20130809175620.B80534875C@hg.openjdk.java.net> Changeset: 03822f2389bf Author: dxu Date: 2013-08-09 10:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/03822f2389bf 8021977: Opening a file using java.io can throw IOException on Windows Summary: Remove IOException related error-handling code for backward compatibility Reviewed-by: alanb, lancea, mr ! src/windows/native/java/io/io_util_md.c From xueming.shen at oracle.com Fri Aug 9 12:38:03 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Fri, 09 Aug 2013 19:38:03 +0000 Subject: hg: jdk8/tl/jdk: 8020054: (tz) Support tzdata2013d Message-ID: <20130809193841.0F87148762@hg.openjdk.java.net> Changeset: a7c341f30747 Author: sherman Date: 2013-08-09 12:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a7c341f30747 8020054: (tz) Support tzdata2013d Summary: update the jdk8 tz data to version 2013d Reviewed-by: coffeys, peytoia ! make/sun/javazic/tzdata/VERSION ! make/sun/javazic/tzdata/africa ! make/sun/javazic/tzdata/antarctica ! make/sun/javazic/tzdata/asia ! make/sun/javazic/tzdata/australasia ! make/sun/javazic/tzdata/backward ! make/sun/javazic/tzdata/etcetera ! make/sun/javazic/tzdata/europe ! make/sun/javazic/tzdata/factory ! make/sun/javazic/tzdata/iso3166.tab ! make/sun/javazic/tzdata/leapseconds ! make/sun/javazic/tzdata/northamerica ! make/sun/javazic/tzdata/pacificnew ! make/sun/javazic/tzdata/solar87 ! make/sun/javazic/tzdata/solar88 ! make/sun/javazic/tzdata/solar89 ! make/sun/javazic/tzdata/southamerica ! make/sun/javazic/tzdata/systemv ! make/sun/javazic/tzdata/zone.tab ! test/sun/util/calendar/zi/tzdata/VERSION ! test/sun/util/calendar/zi/tzdata/africa ! test/sun/util/calendar/zi/tzdata/antarctica ! test/sun/util/calendar/zi/tzdata/asia ! test/sun/util/calendar/zi/tzdata/australasia ! test/sun/util/calendar/zi/tzdata/backward ! test/sun/util/calendar/zi/tzdata/etcetera ! test/sun/util/calendar/zi/tzdata/europe ! test/sun/util/calendar/zi/tzdata/factory ! test/sun/util/calendar/zi/tzdata/iso3166.tab ! test/sun/util/calendar/zi/tzdata/leapseconds ! test/sun/util/calendar/zi/tzdata/northamerica ! test/sun/util/calendar/zi/tzdata/pacificnew ! test/sun/util/calendar/zi/tzdata/solar87 ! test/sun/util/calendar/zi/tzdata/solar88 ! test/sun/util/calendar/zi/tzdata/solar89 ! test/sun/util/calendar/zi/tzdata/southamerica ! test/sun/util/calendar/zi/tzdata/systemv ! test/sun/util/calendar/zi/tzdata/zone.tab From huizhe.wang at oracle.com Fri Aug 9 12:42:39 2013 From: huizhe.wang at oracle.com (huizhe.wang at oracle.com) Date: Fri, 09 Aug 2013 19:42:39 +0000 Subject: hg: jdk8/tl/jaxp: 8022548: SPECJVM2008 has errors introduced in 7u40-b34 Message-ID: <20130809194247.32C3B48763@hg.openjdk.java.net> Changeset: 4e23bc205d9d Author: joehw Date: 2013-08-09 12:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/4e23bc205d9d 8022548: SPECJVM2008 has errors introduced in 7u40-b34 Reviewed-by: chegar, lancea ! src/com/sun/org/apache/xerces/internal/parsers/DTDConfiguration.java ! src/com/sun/org/apache/xerces/internal/parsers/NonValidatingConfiguration.java ! src/com/sun/org/apache/xerces/internal/parsers/SAXParser.java From huizhe.wang at oracle.com Fri Aug 9 12:54:51 2013 From: huizhe.wang at oracle.com (huizhe.wang at oracle.com) Date: Fri, 09 Aug 2013 19:54:51 +0000 Subject: hg: jdk8/tl/jdk: 8022548: SPECJVM2008 has errors introduced in 7u40-b34 Message-ID: <20130809195532.B759848766@hg.openjdk.java.net> Changeset: 8f01ccb0c981 Author: joehw Date: 2013-08-09 12:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8f01ccb0c981 8022548: SPECJVM2008 has errors introduced in 7u40-b34 Reviewed-by: chegar, lancea + test/javax/xml/jaxp/parsers/8022548/JDK8022548.xml + test/javax/xml/jaxp/parsers/8022548/JDK8022548.xsl + test/javax/xml/jaxp/parsers/8022548/TestBase.java + test/javax/xml/jaxp/parsers/8022548/XOMParserTest.java From kumar.x.srinivasan at oracle.com Fri Aug 9 15:36:04 2013 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Fri, 09 Aug 2013 22:36:04 +0000 Subject: hg: jdk8/tl/langtools: 8022161: javac Null Pointer Exception in Enter.visitTopLevel Message-ID: <20130809223615.468C748776@hg.openjdk.java.net> Changeset: d601238641e6 Author: ksrini Date: 2013-08-09 15:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d601238641e6 8022161: javac Null Pointer Exception in Enter.visitTopLevel Reviewed-by: jjg, vromero, jlahoda ! src/share/classes/com/sun/tools/javac/comp/Enter.java ! test/tools/javac/TestPkgInfo.java From vicente.romero at oracle.com Sat Aug 10 05:28:55 2013 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Sat, 10 Aug 2013 12:28:55 +0000 Subject: hg: jdk8/tl/langtools: 8009640: -profile does not work when -bootclasspath specified Message-ID: <20130810122858.15F1748789@hg.openjdk.java.net> Changeset: 0d9bc764cac7 Author: vromero Date: 2013-08-10 13:27 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0d9bc764cac7 8009640: -profile does not work when -bootclasspath specified Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/main/Main.java ! src/share/classes/com/sun/tools/javac/resources/javac.properties + test/tools/javac/T8009640/CheckRejectProfileBCPOptionsIfUsedTogetherTest.java From vicente.romero at oracle.com Sat Aug 10 08:27:28 2013 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Sat, 10 Aug 2013 15:27:28 +0000 Subject: hg: jdk8/tl/langtools: 8022622: javac, two tests are failing with compile time error after class Collector was modified Message-ID: <20130810152735.353B74878B@hg.openjdk.java.net> Changeset: 8f282dc58dfc Author: vromero Date: 2013-08-10 16:26 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8f282dc58dfc 8022622: javac, two tests are failing with compile time error after class Collector was modified Reviewed-by: mcimadamore ! test/tools/javac/lambda/TargetType59.java ! test/tools/javac/lambda/TargetType62.java From vicente.romero at oracle.com Sat Aug 10 08:30:27 2013 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Sat, 10 Aug 2013 15:30:27 +0000 Subject: hg: jdk8/tl/langtools: 6983297: methods missing from NewArrayTree Message-ID: <20130810153030.01FCA4878C@hg.openjdk.java.net> Changeset: aa6c6f8b5622 Author: vromero Date: 2013-08-10 16:29 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/aa6c6f8b5622 6983297: methods missing from NewArrayTree Reviewed-by: jjg ! src/share/classes/com/sun/source/tree/NewArrayTree.java ! src/share/classes/com/sun/source/util/TreeScanner.java ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! test/tools/javac/tree/SourceTreeScannerTest.java From jeremymanson at google.com Sat Aug 10 15:10:54 2013 From: jeremymanson at google.com (Jeremy Manson) Date: Sat, 10 Aug 2013 15:10:54 -0700 Subject: Unclear error message when class has same name as package Message-ID: Hi folks, One of our users said that he spent a day trying to figure out where how this error happened (lots of autogenerated code made it all rather opaque), so I'm reporting it. $ cat C.java import p.D.E; public class C { } $ cat p/D.java package p; public class D { } $ cat p/D/E.java package p.D; public class E { } $ javac C.java C.java:1: error: cannot find symbol import p.D.E; ^ symbol: class E location: class D 1 error The reporter suggested that the error "cannot find symbol" would be better as something like "package D clashes with class of same name". Jeremy -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20130810/99f896e6/attachment.html From oehrstroem at gmail.com Sun Aug 11 06:23:29 2013 From: oehrstroem at gmail.com (=?ISO-8859-1?Q?Fredrik_=D6hrstr=F6m?=) Date: Sun, 11 Aug 2013 15:23:29 +0200 Subject: RFR: 8015145: Smartjavac needs more flexibility with linking to sources In-Reply-To: <5202153C.4020509@oracle.com> References: <51B1D57A.3030305@oracle.com> <51F2DEA5.4020404@oracle.com> <5202153C.4020509@oracle.com> Message-ID: Looks great to me! 2013/8/7 Erik Joelsson > > > On 2013-07-26 22:40, Jonathan Gibbons wrote: > >> I am concerned by the preceding comment, starting line 255. >> >> 255 // Always reuse -src for linking as well! This means >> that we might >> 256 // get two -sourcepath on the commandline after the >> rewrite, which is >> 257 // fine. We can have as many as we like. >> >> Yes, you can put as many -sourcepath options as you want, but as far as >> javac >> is concerned, "last one wins". If you want all the options to be >> significant in the >> child javac commands, you need to join the values. >> >> I have reworded the comment, explaining that they are indeed joined > later, before being handed to javac. I also added a test for the usecase > I'm describing below and made the Sjavac tests runnable by jtreg. > > http://cr.openjdk.java.net/~**erikj/8015145/webrev.**langtools.02/ > > /Erik > > -- Jon >> >> On 06/07/2013 05:43 AM, Erik Joelsson wrote: >> >>> Here is a patch solving a problem with -sourcepath for sjavac. >>> >>> First some background. The security sources (the ones that require >>> signing) need to be built to a separate directory. If they aren't (as is >>> the case now) security tests will fail if run on the exploded jdk image >>> (the one you get when just typing make or make jdk). In JDK-8009280, I'm >>> trying to fix this. The solution I have for that bug is working well, >>> except when running with sjavac, and basically builds all classes except >>> the security classes first to the normal outputdir and then as a separate >>> step builds just the security classes to a different outputdir. >>> >>> There are two issues that need to be addressed in sjavac for this to >>> work. First, it needs to be possible to supply the same source root both to >>> the -src and -sourcepath option (but with different filter rules). Sjavac >>> is very picky and only links to sources that are included in either of >>> those options, and since we are excluding the security sources from -src, >>> we need to add them to -sourcepath. >>> >>> The second thing is more of a bug as far as I can tell. Sjavac compares >>> the found set of sources to compile with what the makefile think needs to >>> be compiled, as a safety check. Currently, sjavac is including sources that >>> are just being linked to in this comparison. I would think that it should >>> only include sources that are meant to be compiled. >>> >>> http://cr.openjdk.java.net/~**erikj/8015145/webrev.**langtools.01/ >>> >>> http://bugs.sun.com/view_bug.**do?bug_id=8015145 >>> >>> /Erik >>> >> >> -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20130811/8ba91054/attachment.html From xuelei.fan at oracle.com Sun Aug 11 18:22:09 2013 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Mon, 12 Aug 2013 01:22:09 +0000 Subject: hg: jdk8/tl/jdk: 8022487: DEREncodedKeyValue.supportedKeyTypes should be private Message-ID: <20130812012258.BACF2487A1@hg.openjdk.java.net> Changeset: ea4f4164422e Author: xuelei Date: 2013-08-11 18:21 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ea4f4164422e 8022487: DEREncodedKeyValue.supportedKeyTypes should be private Reviewed-by: mullan ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/DEREncodedKeyValue.java From sean.mullan at oracle.com Mon Aug 12 06:54:59 2013 From: sean.mullan at oracle.com (sean.mullan at oracle.com) Date: Mon, 12 Aug 2013 13:54:59 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20130812135553.CEA46487BD@hg.openjdk.java.net> Changeset: ffacf3e7a130 Author: mullan Date: 2013-08-12 09:03 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ffacf3e7a130 8016848: javax_security/auth/login tests fail in compact 1 and 2 profiles Summary: Change the default value of the "login.configuration.provider" security property to sun.security.provider.ConfigFile Reviewed-by: xuelei ! src/share/classes/com/sun/security/auth/login/ConfigFile.java ! src/share/classes/javax/security/auth/login/Configuration.java + src/share/classes/sun/security/provider/ConfigFile.java - src/share/classes/sun/security/provider/ConfigSpiFile.java ! src/share/classes/sun/security/provider/SunEntries.java ! src/share/lib/security/java.security-linux ! src/share/lib/security/java.security-macosx ! src/share/lib/security/java.security-solaris ! src/share/lib/security/java.security-windows Changeset: d73fbf005f5f Author: mullan Date: 2013-08-12 09:29 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d73fbf005f5f Merge - src/share/classes/java/net/package.html - test/java/lang/System/MacJNUEncoding/ExpectedEncoding.java - test/java/lang/System/MacJNUEncoding/MacJNUEncoding.sh From sundararajan.athijegannathan at oracle.com Mon Aug 12 08:14:44 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Mon, 12 Aug 2013 15:14:44 +0000 Subject: hg: jdk8/tl/nashorn: 9 new changesets Message-ID: <20130812151453.0397A487BF@hg.openjdk.java.net> Changeset: 14ea21d58f83 Author: jlaskey Date: 2013-08-08 11:20 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/14ea21d58f83 Merge - src/jdk/internal/dynalink/support/Backport.java Changeset: 47e2b609fe31 Author: sundar Date: 2013-08-09 20:48 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/47e2b609fe31 8022707: Revisit all doPrivileged blocks Reviewed-by: jlaskey, hannesw ! make/project.properties ! src/jdk/nashorn/api/scripting/NashornScriptEngine.java ! src/jdk/nashorn/api/scripting/NashornScriptEngineFactory.java ! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/objects/NativeDebug.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/ECMAErrors.java ! src/jdk/nashorn/internal/runtime/Logging.java ! src/jdk/nashorn/internal/runtime/linker/ClassAndLoader.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterBytecodeGenerator.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterClassLoader.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java ! src/jdk/nashorn/internal/runtime/linker/ReflectionCheckLinker.java ! src/jdk/nashorn/internal/runtime/options/Options.java ! src/jdk/nashorn/tools/Shell.java Changeset: 01304b0550fb Author: sundar Date: 2013-08-12 14:43 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/01304b0550fb 8022782: publicLookup access failures in ScriptObject, ScriptFunction and ScriptFunction Reviewed-by: lagergren, attila, hannesw ! src/jdk/nashorn/internal/codegen/CompilerConstants.java ! src/jdk/nashorn/internal/runtime/JSType.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/ScriptRuntime.java Changeset: 3c13fba4d727 Author: attila Date: 2013-08-12 12:46 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/3c13fba4d727 8022789: Revisit doPrivileged blocks in Dynalink Reviewed-by: lagergren, sundar ! src/jdk/internal/dynalink/DynamicLinkerFactory.java + src/jdk/internal/dynalink/support/ClassLoaderGetterContextProvider.java ! src/jdk/internal/dynalink/support/ClassMap.java ! src/jdk/internal/dynalink/support/TypeConverterFactory.java Changeset: 0bbaa0ac36ab Author: sundar Date: 2013-08-12 16:52 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/0bbaa0ac36ab 8022614: Please exclude test test/script/trusted/JDK-8020809.js from Nashorn code coverage run Reviewed-by: jlaskey, lagergren ! exclude/exclude_list_cc.txt Changeset: 03ba1cd734c0 Author: hannesw Date: 2013-08-12 13:31 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/03ba1cd734c0 8022731: NativeArguments has wrong implementation of isMapped() Reviewed-by: lagergren, jlaskey ! src/jdk/nashorn/internal/objects/NativeArguments.java + test/script/basic/JDK-8022731.js + test/script/basic/JDK-8022731.js.EXPECTED Changeset: 821b605c7046 Author: sundar Date: 2013-08-12 17:08 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/821b605c7046 8022615: [nightly] Two nashorn print tests fail in nightly builds on Windows Reviewed-by: lagergren, jlaskey ! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java Changeset: f2e1673db03b Author: sundar Date: 2013-08-12 18:16 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/f2e1673db03b 8022598: Object.getPrototypeOf should return null for host objects rather than throwing TypeError Reviewed-by: lagergren, jlaskey, attila, hannesw ! src/jdk/nashorn/internal/objects/NativeObject.java + test/script/basic/JDK-8022598.js Changeset: a0807e889be3 Author: sundar Date: 2013-08-12 20:37 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/a0807e889be3 Merge From maurizio.cimadamore at oracle.com Mon Aug 12 09:29:08 2013 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Mon, 12 Aug 2013 16:29:08 +0000 Subject: hg: jdk8/tl/langtools: 2 new changesets Message-ID: <20130812162917.4FA16487C5@hg.openjdk.java.net> Changeset: f7f271bd74a2 Author: mcimadamore Date: 2013-08-12 17:25 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f7f271bd74a2 6537020: JCK tests: a compile-time error should be given in case of ambiguously imported fields (types, methods) Summary: Hiding check does not support interface multiple inheritance Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Scope.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! test/tools/javac/4980495/static/Test.out ! test/tools/javac/diags/examples/AlreadyDefinedStaticImport/AlreadDefinedStaticImport.java ! test/tools/javac/diags/examples/AlreadyDefinedStaticImport/p/E1.java ! test/tools/javac/diags/examples/AlreadyDefinedStaticImport/p/E2.java + test/tools/javac/staticImport/6537020/T6537020.java + test/tools/javac/staticImport/6537020/T6537020.out Changeset: af80273f630a Author: mcimadamore Date: 2013-08-12 17:28 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/af80273f630a 8021567: Javac doesn't report \"java: reference to method is ambiguous\" any more Summary: Javac incorrectly forgets about constant folding results within lambdas Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java + test/tools/javac/lambda/8021567/T8021567.java + test/tools/javac/lambda/8021567/T8021567.out + test/tools/javac/lambda/8021567/T8021567b.java From vicente.romero at oracle.com Mon Aug 12 09:41:24 2013 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Mon, 12 Aug 2013 16:41:24 +0000 Subject: hg: jdk8/tl/jdk: 8015780: java/lang/reflect/Method/GenericStringTest.java failing Message-ID: <20130812164149.C5B8B487C9@hg.openjdk.java.net> Changeset: 70c8f4a4b8d6 Author: vromero Date: 2013-08-12 17:40 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/70c8f4a4b8d6 8015780: java/lang/reflect/Method/GenericStringTest.java failing Reviewed-by: darcy, jfranck ! test/ProblemList.txt ! test/java/lang/reflect/Method/GenericStringTest.java From henry.jen at oracle.com Mon Aug 12 12:12:06 2013 From: henry.jen at oracle.com (henry.jen at oracle.com) Date: Mon, 12 Aug 2013 19:12:06 +0000 Subject: hg: jdk8/tl/jdk: 8022749: Convert junit tests to testng in test/java/lang/invoke Message-ID: <20130812191235.BC88E487D6@hg.openjdk.java.net> Changeset: 7758bcf0ab6b Author: henryjen Date: 2013-08-12 12:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7758bcf0ab6b 8022749: Convert junit tests to testng in test/java/lang/invoke Reviewed-by: mduigou, alanb Contributed-by: Mani Sarkar ! test/java/lang/invoke/AccessControlTest.java ! test/java/lang/invoke/ClassValueTest.java ! test/java/lang/invoke/InvokeGenericTest.java ! test/java/lang/invoke/JavaDocExamplesTest.java ! test/java/lang/invoke/MethodTypeTest.java ! test/java/lang/invoke/PermuteArgsTest.java ! test/java/lang/invoke/ThrowExceptionsTest.java From lance.andersen at oracle.com Mon Aug 12 13:09:57 2013 From: lance.andersen at oracle.com (lance.andersen at oracle.com) Date: Mon, 12 Aug 2013 20:09:57 +0000 Subject: hg: jdk8/tl/jdk: 8022753: SQLXML javadoc example typo Message-ID: <20130812201011.0221F487E1@hg.openjdk.java.net> Changeset: cc64a05836a7 Author: lancea Date: 2013-08-12 16:09 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cc64a05836a7 8022753: SQLXML javadoc example typo Reviewed-by: alanb, mchung ! src/share/classes/java/sql/SQLXML.java From vicente.romero at oracle.com Tue Aug 13 02:31:36 2013 From: vicente.romero at oracle.com (Vicente-Arturo Romero-Zaldivar) Date: Tue, 13 Aug 2013 10:31:36 +0100 Subject: Unclear error message when class has same name as package In-Reply-To: References: Message-ID: <5209FCF8.6020303@oracle.com> Hi Jeremy, Thanks for the report I have created a bug entry with id JDK-8022873 to track this issue, Vicente On 10/08/13 23:10, Jeremy Manson wrote: > Hi folks, > > One of our users said that he spent a day trying to figure out where > how this error happened (lots of autogenerated code made it all rather > opaque), so I'm reporting it. > > $ cat C.java > import p.D.E; > > public class C { > } > $ cat p/D.java > package p; > public class D { > } > $ cat p/D/E.java > package p.D; > > public class E { > } > $ javac C.java > C.java:1: error: cannot find symbol > import p.D.E; > ^ > symbol: class E > location: class D > 1 error > > > The reporter suggested that the error "cannot find symbol" would be > better as something like "package D clashes with class of same name". > > Jeremy From sean.mullan at oracle.com Tue Aug 13 06:05:47 2013 From: sean.mullan at oracle.com (sean.mullan at oracle.com) Date: Tue, 13 Aug 2013 13:05:47 +0000 Subject: hg: jdk8/tl/jdk: 8020081: Cipher with OAEPPadding and OAEPParameterSpec can't be created Message-ID: <20130813130623.337D448806@hg.openjdk.java.net> Changeset: 5b14d702b0b8 Author: ascarpino Date: 2013-08-12 11:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5b14d702b0b8 8020081: Cipher with OAEPPadding and OAEPParameterSpec can't be created Reviewed-by: mullan ! src/share/classes/com/sun/crypto/provider/SunJCE.java + test/com/sun/crypto/provider/Cipher/RSA/TestOAEPPadding.java From vincent.x.ryan at oracle.com Tue Aug 13 06:19:13 2013 From: vincent.x.ryan at oracle.com (vincent.x.ryan at oracle.com) Date: Tue, 13 Aug 2013 13:19:13 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20130813131940.272B248807@hg.openjdk.java.net> Changeset: 818c3f82269c Author: vinnie Date: 2013-08-13 14:15 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/818c3f82269c 8013170: Spec for PBEParameterSpec does not specify behavior when paramSpec is null Reviewed-by: mullan ! src/share/classes/javax/crypto/spec/PBEParameterSpec.java Changeset: 26753a05859a Author: vinnie Date: 2013-08-13 14:18 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/26753a05859a Merge From alan.bateman at oracle.com Tue Aug 13 06:46:41 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Tue, 13 Aug 2013 13:46:41 +0000 Subject: hg: jdk8/tl/jdk: 8022180: BigInteger Burnikel-Ziegler quotient and remainder calculation assumes quotient parameter is zero Message-ID: <20130813134655.5EFA14880A@hg.openjdk.java.net> Changeset: 834faf2081b3 Author: bpb Date: 2013-08-12 16:21 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/834faf2081b3 8022180: BigInteger Burnikel-Ziegler quotient and remainder calculation assumes quotient parameter is zero Summary: Clear the quotient in divideAndRemainderBurnikelZiegler() if the divisor is larger than the dividend. Reviewed-by: alanb, bpb Contributed-by: Timothy Buktu ! src/share/classes/java/math/MutableBigInteger.java ! test/java/math/BigInteger/BigIntegerTest.java From daniel.fuchs at oracle.com Tue Aug 13 07:01:14 2013 From: daniel.fuchs at oracle.com (daniel.fuchs at oracle.com) Date: Tue, 13 Aug 2013 14:01:14 +0000 Subject: hg: jdk8/tl/jdk: 8019948: java/util/logging/bundlesearch/ResourceBundleSearchTest.java is failing intermittently Message-ID: <20130813140126.A06E14880E@hg.openjdk.java.net> Changeset: 78c102c3eefc Author: dfuchs Date: 2013-08-13 16:00 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/78c102c3eefc 8019948: java/util/logging/bundlesearch/ResourceBundleSearchTest.java is failing intermittently Reviewed-by: mchung, dholmes ! test/java/util/logging/bundlesearch/ResourceBundleSearchTest.java From sean.mullan at oracle.com Tue Aug 13 07:10:00 2013 From: sean.mullan at oracle.com (sean.mullan at oracle.com) Date: Tue, 13 Aug 2013 14:10:00 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20130813141024.7A95E4880F@hg.openjdk.java.net> Changeset: 412b2f0950a9 Author: mullan Date: 2013-08-13 10:06 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/412b2f0950a9 8022897: Add test/com/sun/crypto/provider/Cipher/RSA/TestOAEPPadding.java to ProblemList Reviewed-by: vinnie, chegar ! test/ProblemList.txt Changeset: 19133b3af95f Author: mullan Date: 2013-08-13 10:07 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/19133b3af95f Merge ! test/ProblemList.txt From chris.hegarty at oracle.com Tue Aug 13 06:57:59 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Tue, 13 Aug 2013 13:57:59 +0000 Subject: hg: jdk8/tl/jdk: 8022779: ProblemList.txt updates (8/2013) Message-ID: <20130813135811.2FB3A4880C@hg.openjdk.java.net> Changeset: 18e15d92610b Author: chegar Date: 2013-08-13 14:57 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/18e15d92610b 8022779: ProblemList.txt updates (8/2013) Summary: Update ProblemList and remove AggressiveOpts MOAT test run Reviewed-by: chegar, alanb Contributed-by: Amy Lu ! test/ProblemList.txt ! test/java/util/Collection/MOAT.java From joe.darcy at oracle.com Tue Aug 13 10:12:46 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Tue, 13 Aug 2013 17:12:46 +0000 Subject: hg: jdk8/tl/jdk: 8022959: Fix new doclint issues in java.util.zip Message-ID: <20130813171336.4A95548827@hg.openjdk.java.net> Changeset: cd9379e348d0 Author: darcy Date: 2013-08-13 10:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cd9379e348d0 8022959: Fix new doclint issues in java.util.zip Reviewed-by: chegar ! src/share/classes/java/util/zip/ZipEntry.java From rob.mckenna at oracle.com Tue Aug 13 11:09:34 2013 From: rob.mckenna at oracle.com (rob.mckenna at oracle.com) Date: Tue, 13 Aug 2013 18:09:34 +0000 Subject: hg: jdk8/tl/jdk: 5049299: (process) Use posix_spawn, not fork, on S10 to avoid swap exhaustion Message-ID: <20130813181025.5211F4882B@hg.openjdk.java.net> Changeset: a4b0be7341ef Author: robm Date: 2013-08-13 19:10 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a4b0be7341ef 5049299: (process) Use posix_spawn, not fork, on S10 to avoid swap exhaustion Reviewed-by: alanb, dholmes, martin, erikj, coffeys ! make/java/java/Exportedfiles.gmk ! make/java/java/Makefile ! makefiles/CompileLaunchers.gmk ! makefiles/CompileNativeLibraries.gmk ! src/solaris/classes/java/lang/UNIXProcess.java.bsd ! src/solaris/classes/java/lang/UNIXProcess.java.linux ! src/solaris/classes/java/lang/UNIXProcess.java.solaris ! src/solaris/native/java/lang/UNIXProcess_md.c + src/solaris/native/java/lang/childproc.c + src/solaris/native/java/lang/childproc.h + src/solaris/native/java/lang/jspawnhelper.c ! test/java/lang/ProcessBuilder/Basic.java From jose.cornado at gmail.com Tue Aug 13 11:30:28 2013 From: jose.cornado at gmail.com (=?ISO-8859-1?Q?Jos=E9_Cornado?=) Date: Tue, 13 Aug 2013 12:30:28 -0600 Subject: Problems with "-implicit:none" In-Reply-To: References: Message-ID: Problem worked around. Thanks anyway! On Fri, Aug 9, 2013 at 7:37 AM, Jos? Cornado wrote: > Hello! > > I have the following problem with javax.tools.JavaCompiler: > > A background jvm, depending on user input from IDE, generates classes > dynamically. > > This can take time, so to avoid the delay I use the flag "-implicit:none". > The IDE provides enough data I can infer if everything is in place and > stick to parse/build just the target class. Because I don't write some > streams to disk there are a lot of cases where the *.class is in the > correct directory but the *.java does not exist. > > Now the problem: > > If the target class imports a type from another package/location the flag > works great. If the target class imports a class from the same location the > JavaCompiler completely ignores this flag and the fact that the *.class > exists and looks for the source file which doesn't exist and fails. > > Question 1: is this the expected behavior of the compiler. > > Question 2: would avoid importing type from the same package change the > behavior of the compiler in anyway? > > I am running build 1.7.0_25-b15 on a mac > > > Thanks a lot in advance!!! > > -- > Jos? Cornado > > -- > > home: http://www.efekctive.com > blog: http://blogging.efekctive.com > ---------------------- > > Everything has been said before, but since nobody listens we have to keep > going back and beginning all over again. > > Andre Gide > -- Jos? Cornado -- home: http://www.efekctive.com blog: http://blogging.efekctive.com ---------------------- Everything has been said before, but since nobody listens we have to keep going back and beginning all over again. Andre Gide -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20130813/53e24884/attachment-0001.html From jeremymanson at google.com Tue Aug 13 12:36:51 2013 From: jeremymanson at google.com (Jeremy Manson) Date: Tue, 13 Aug 2013 12:36:51 -0700 Subject: Unclear error message when class has same name as package In-Reply-To: <5209FCF8.6020303@oracle.com> References: <5209FCF8.6020303@oracle.com> Message-ID: Thanks! Jeremy On Tue, Aug 13, 2013 at 2:31 AM, Vicente-Arturo Romero-Zaldivar < vicente.romero at oracle.com> wrote: > Hi Jeremy, > > Thanks for the report I have created a bug entry with id JDK-8022873 to > track this issue, > > Vicente > > > On 10/08/13 23:10, Jeremy Manson wrote: > >> Hi folks, >> >> One of our users said that he spent a day trying to figure out where how >> this error happened (lots of autogenerated code made it all rather opaque), >> so I'm reporting it. >> >> $ cat C.java >> import p.D.E; >> >> public class C { >> } >> $ cat p/D.java >> package p; >> public class D { >> } >> $ cat p/D/E.java >> package p.D; >> >> public class E { >> } >> $ javac C.java >> C.java:1: error: cannot find symbol >> import p.D.E; >> ^ >> symbol: class E >> location: class D >> 1 error >> >> >> The reporter suggested that the error "cannot find symbol" would be >> better as something like "package D clashes with class of same name". >> >> Jeremy >> > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20130813/a00e6355/attachment.html From jonathan.gibbons at oracle.com Tue Aug 13 15:32:15 2013 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Tue, 13 Aug 2013 15:32:15 -0700 Subject: Unclear error message when class has same name as package In-Reply-To: References: <5209FCF8.6020303@oracle.com> Message-ID: <520AB3EF.50103@oracle.com> Jeremy, To be realistic, I do not know what we can do about this issue. It is legal to have a class and a package with the same name, which means that in a sufficiently perverse case, and the following import import A.B.C.D.E; the problem could occur at any point along the qualified name, where the compiler chooses a type name contrary to the erroneous expectation of the programmer. See JLS 6.5.4. So, as much as it would be nice to be able to warn the programmer of problematic coding, this error message is not the place to do it. The compiler already tries to give you enough detail by point out (in your case) that it is trying to find "class E" within "class D". That should surely be enough to have you realize that the compiler is looking at "class D" and not "package D". -- Jon On 08/13/2013 12:36 PM, Jeremy Manson wrote: > Thanks! > > Jeremy > > > On Tue, Aug 13, 2013 at 2:31 AM, Vicente-Arturo Romero-Zaldivar > > wrote: > > Hi Jeremy, > > Thanks for the report I have created a bug entry with id > JDK-8022873 to track this issue, > > Vicente > > > On 10/08/13 23:10, Jeremy Manson wrote: > > Hi folks, > > One of our users said that he spent a day trying to figure out > where how this error happened (lots of autogenerated code made > it all rather opaque), so I'm reporting it. > > $ cat C.java > import p.D.E; > > public class C { > } > $ cat p/D.java > package p; > public class D { > } > $ cat p/D/E.java > package p.D; > > public class E { > } > $ javac C.java > C.java:1: error: cannot find symbol > import p.D.E; > ^ > symbol: class E > location: class D > 1 error > > > The reporter suggested that the error "cannot find symbol" > would be better as something like "package D clashes with > class of same name". > > Jeremy > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20130813/4f935e72/attachment.html From lana.steuck at oracle.com Tue Aug 13 19:47:11 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 14 Aug 2013 02:47:11 +0000 Subject: hg: jdk8/tl/nashorn: 3 new changesets Message-ID: <20130814024719.4B06448856@hg.openjdk.java.net> Changeset: 795cff5c1b5c Author: cl Date: 2013-08-08 10:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/795cff5c1b5c Added tag jdk8-b102 for changeset e966ff0a3ffe ! .hgtags Changeset: 414203de4374 Author: lana Date: 2013-08-13 10:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/414203de4374 Merge Changeset: 8ecf68b292d0 Author: lana Date: 2013-08-13 18:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/8ecf68b292d0 Merge From lana.steuck at oracle.com Tue Aug 13 19:47:11 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 14 Aug 2013 02:47:11 +0000 Subject: hg: jdk8/tl/jaxp: 2 new changesets Message-ID: <20130814024727.1676748858@hg.openjdk.java.net> Changeset: b1ceab582fc6 Author: cl Date: 2013-08-08 10:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/b1ceab582fc6 Added tag jdk8-b102 for changeset 7cffafa606e9 ! .hgtags Changeset: 9800647936dd Author: lana Date: 2013-08-13 18:28 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/9800647936dd Merge From lana.steuck at oracle.com Tue Aug 13 19:47:03 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 14 Aug 2013 02:47:03 +0000 Subject: hg: jdk8/tl/corba: 2 new changesets Message-ID: <20130814024709.852E048855@hg.openjdk.java.net> Changeset: f8ed09af1df6 Author: cl Date: 2013-08-08 10:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/f8ed09af1df6 Added tag jdk8-b102 for changeset 528c7e76eaee ! .hgtags Changeset: 49c4a777fdfd Author: lana Date: 2013-08-13 10:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/49c4a777fdfd Merge From lana.steuck at oracle.com Tue Aug 13 19:47:08 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 14 Aug 2013 02:47:08 +0000 Subject: hg: jdk8/tl: Added tag jdk8-b102 for changeset 5eb3c1dc348f Message-ID: <20130814024709.7C73148854@hg.openjdk.java.net> Changeset: b7e64be81c8a Author: cl Date: 2013-08-08 10:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/b7e64be81c8a Added tag jdk8-b102 for changeset 5eb3c1dc348f ! .hgtags From lana.steuck at oracle.com Tue Aug 13 19:47:11 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 14 Aug 2013 02:47:11 +0000 Subject: hg: jdk8/tl/langtools: 3 new changesets Message-ID: <20130814024733.007B548859@hg.openjdk.java.net> Changeset: 6718df4cd616 Author: cl Date: 2013-08-08 10:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6718df4cd616 Added tag jdk8-b102 for changeset 453a305e1165 ! .hgtags Changeset: 76cfe7c61f25 Author: lana Date: 2013-08-13 10:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/76cfe7c61f25 Merge Changeset: 32b6a99cc74e Author: lana Date: 2013-08-13 18:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/32b6a99cc74e Merge From lana.steuck at oracle.com Tue Aug 13 19:47:20 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 14 Aug 2013 02:47:20 +0000 Subject: hg: jdk8/tl/hotspot: 25 new changesets Message-ID: <20130814024823.802374885A@hg.openjdk.java.net> Changeset: b9a927798f12 Author: cl Date: 2013-08-08 10:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b9a927798f12 Added tag jdk8-b102 for changeset c4697c1c4484 ! .hgtags Changeset: 79ce055063e9 Author: amurillo Date: 2013-08-02 03:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/79ce055063e9 8022124: new hotspot build - hs25-b45 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 9bd314787fad Author: mseledtsov Date: 2013-08-01 22:15 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9bd314787fad 8020614: OutputAnalyzer.shouldHaveExitValue() should print stdout/stderr output Summary: OutputAnalyzer.shouldHaveExitValue() should print stdout/stderr output Reviewed-by: kvn, ctornqvi, dholmes + test/testlibrary/OutputAnalyzerReportingTest.java ! test/testlibrary/com/oracle/java/testlibrary/OutputAnalyzer.java ! test/testlibrary/com/oracle/java/testlibrary/ProcessTools.java Changeset: c01913206da5 Author: ctornqvi Date: 2013-08-01 22:20 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c01913206da5 8014294: Assert in ThreadTimesClosure::do_thread() due to use of naked oop instead of handle Summary: Assert in ThreadTimesClosure::do_thread() due to use of naked oop instead of handle Reviewed-by: coleenp, sspitsyn ! src/share/vm/services/management.cpp Changeset: 81e0f17ade64 Author: ctornqvi Date: 2013-08-01 22:25 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/81e0f17ade64 8009407: runtime/8000968/Test8000968.sh has incorrect check for proper config Summary: runtime/8000968/Test8000968.sh has incorrect check for proper config Reviewed-by: coleenp, mseledtsov, sspitsyn, hseigel - test/runtime/8000968/Test8000968.sh + test/runtime/CompressedOops/CompressedKlassPointerAndOops.java Changeset: 32e3bada0978 Author: kevinw Date: 2013-08-02 12:26 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/32e3bada0978 8020943: Memory leak when GCNotifier uses create_from_platform_dependent_str() Reviewed-by: mgerdin, fparain, dcubed ! src/share/vm/services/gcNotifier.cpp Changeset: dee4c330acd4 Author: dcubed Date: 2013-08-02 08:32 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/dee4c330acd4 Merge - test/runtime/8000968/Test8000968.sh Changeset: fa57c8104b76 Author: ctornqvi Date: 2013-08-02 18:12 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/fa57c8104b76 8009585: test/runtime/7196045 times out Summary: test/runtime/7196045 times out Reviewed-by: dholmes, mseledtsov - test/runtime/7196045/Test7196045.java + test/runtime/InternalApi/ThreadCpuTimesDeadlock.java Changeset: 0f209afdfcf8 Author: ctornqvi Date: 2013-08-02 18:26 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0f209afdfcf8 Merge Changeset: d02de8cac823 Author: ctornqvi Date: 2013-08-02 22:34 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d02de8cac823 Merge - test/runtime/7196045/Test7196045.java Changeset: e0379d5ba5d2 Author: kevinw Date: 2013-08-05 10:27 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e0379d5ba5d2 8021444: SA: ClassDump.run() should not ignore existing ClassFilter. Reviewed-by: minqi, poonam ! agent/src/share/classes/sun/jvm/hotspot/tools/jcore/ClassDump.java Changeset: b67604b59546 Author: hseigel Date: 2013-08-04 16:30 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b67604b59546 7073961: [TESTBUG] closed/runtime/4845371/DBB.java failed on solaris 10 X65 Summary: Added a x86 64-bit Solaris shared library and rewrote test in Java Reviewed-by: dholmes, ctornqvi ! test/testlibrary/com/oracle/java/testlibrary/Platform.java Changeset: 9064e3a19525 Author: hseigel Date: 2013-08-05 08:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9064e3a19525 Merge - test/runtime/7196045/Test7196045.java - test/runtime/8000968/Test8000968.sh Changeset: 22a5aff0df0b Author: dsamersoff Date: 2013-08-06 14:28 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/22a5aff0df0b 8019396: SA-JDI OSThread class initialization throws an exception Summary: Method sun.jvm.hotspot.runtime.OSThread.initialize throws a sun.jvm.hotspot.types.WrongTypeException Reviewed-by: dholmes, mgerdin ! agent/src/share/classes/sun/jvm/hotspot/jdi/JVMTIThreadState.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/OSThread.java Changeset: cd25d3be91c5 Author: vladidan Date: 2013-08-06 20:01 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/cd25d3be91c5 8012144: multiple SIGSEGVs fails on staxf Summary: Forward port of 7u change to add additional fence() on RMO platforms, with a load_acquire on all platforms Reviewed-by: dholmes, kvn ! src/share/vm/utilities/taskqueue.hpp Changeset: f5bed20f2492 Author: dholmes Date: 2013-08-08 08:29 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f5bed20f2492 Merge Changeset: 79a5283f4595 Author: iignatyev Date: 2013-07-29 11:54 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/79a5283f4595 8021120: TieredCompilation can be enabled even if TIERED is undefined Reviewed-by: kvn, dholmes ! src/share/vm/runtime/arguments.cpp Changeset: 8d77d02828d9 Author: twisti Date: 2013-07-29 16:32 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8d77d02828d9 8016474: Crash in sun.reflect.UnsafeObjectFieldAccessorImpl.get Summary: C1's GetUnsafeObject G1 pre-barrier uses the wrong type to read the klass pointer. Reviewed-by: iveresov, kvn ! src/share/vm/c1/c1_LIRGenerator.cpp + test/compiler/unsafe/GetUnsafeObjectG1PreBarrier.java Changeset: 446cb5d25d03 Author: anoll Date: 2013-08-01 16:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/446cb5d25d03 8020531: Test compiler/codecache/CheckUpperLimit.java fails when memory limited Summary: Removed part of the test that required the VM to start up with -XX:ReservedCodeCacheSize=2048m Reviewed-by: kvn, rbackman ! test/compiler/codecache/CheckUpperLimit.java Changeset: 6e04c193845f Author: anoll Date: 2013-08-02 10:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6e04c193845f 8021301: better event messages Summary: made event messages better readable Reviewed-by: kvn, rbackman ! src/share/vm/classfile/classLoader.cpp ! src/share/vm/utilities/exceptions.cpp Changeset: 5e0b3d7df485 Author: rbackman Date: 2013-08-05 17:15 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5e0b3d7df485 Merge ! src/share/vm/runtime/arguments.cpp Changeset: 71526a36ebb4 Author: twisti Date: 2013-08-05 15:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/71526a36ebb4 8022029: GetUnsafeObjectG1PreBarrier fails on 32-bit with: Unrecognized VM option 'ObjectAlignmentInBytes=32' Reviewed-by: kvn ! test/compiler/unsafe/GetUnsafeObjectG1PreBarrier.java Changeset: dadf62510ae4 Author: rbackman Date: 2013-08-08 23:49 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/dadf62510ae4 Merge Changeset: 7f55137d6aa8 Author: amurillo Date: 2013-08-09 01:32 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7f55137d6aa8 Merge - test/runtime/7196045/Test7196045.java - test/runtime/8000968/Test8000968.sh Changeset: 6f9be7f87b96 Author: amurillo Date: 2013-08-09 01:32 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6f9be7f87b96 Added tag hs25-b45 for changeset 7f55137d6aa8 ! .hgtags From lana.steuck at oracle.com Tue Aug 13 19:47:11 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 14 Aug 2013 02:47:11 +0000 Subject: hg: jdk8/tl/jaxws: Added tag jdk8-b102 for changeset 988a5f2ac559 Message-ID: <20130814024722.7F86B48857@hg.openjdk.java.net> Changeset: 6cdc6ed98780 Author: cl Date: 2013-08-08 10:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/6cdc6ed98780 Added tag jdk8-b102 for changeset 988a5f2ac559 ! .hgtags From lana.steuck at oracle.com Tue Aug 13 19:48:48 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 14 Aug 2013 02:48:48 +0000 Subject: hg: jdk8/tl/jdk: 21 new changesets Message-ID: <20130814025338.ABC014885B@hg.openjdk.java.net> Changeset: e057cddf0d6c Author: cl Date: 2013-08-08 10:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e057cddf0d6c Added tag jdk8-b102 for changeset 8ed8e2b4b90e ! .hgtags Changeset: 1c6bfb303ffc Author: prr Date: 2013-08-06 13:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1c6bfb303ffc 8022175: Fix doclint warnings in javax.print Reviewed-by: darcy ! src/share/classes/javax/print/DocFlavor.java ! src/share/classes/javax/print/MultiDocPrintJob.java ! src/share/classes/javax/print/PrintService.java ! src/share/classes/javax/print/ServiceUI.java ! src/share/classes/javax/print/ServiceUIFactory.java ! src/share/classes/javax/print/attribute/AttributeSet.java ! src/share/classes/javax/print/attribute/DateTimeSyntax.java ! src/share/classes/javax/print/attribute/DocAttributeSet.java ! src/share/classes/javax/print/attribute/EnumSyntax.java ! src/share/classes/javax/print/attribute/HashAttributeSet.java ! src/share/classes/javax/print/attribute/IntegerSyntax.java ! src/share/classes/javax/print/attribute/PrintJobAttributeSet.java ! src/share/classes/javax/print/attribute/PrintRequestAttributeSet.java ! src/share/classes/javax/print/attribute/PrintServiceAttributeSet.java ! src/share/classes/javax/print/attribute/ResolutionSyntax.java ! src/share/classes/javax/print/attribute/Size2DSyntax.java ! src/share/classes/javax/print/attribute/standard/Chromaticity.java ! src/share/classes/javax/print/attribute/standard/Compression.java ! src/share/classes/javax/print/attribute/standard/Finishings.java ! src/share/classes/javax/print/attribute/standard/JobKOctets.java ! src/share/classes/javax/print/attribute/standard/MediaPrintableArea.java ! src/share/classes/javax/print/attribute/standard/MediaSize.java ! src/share/classes/javax/print/attribute/standard/PresentationDirection.java ! src/share/classes/javax/print/attribute/standard/PrinterMoreInfoManufacturer.java ! src/share/classes/javax/print/attribute/standard/PrinterResolution.java Changeset: c3b91dc2504a Author: jgodinez Date: 2013-08-06 14:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c3b91dc2504a 8021583: test/javax/print/autosense/PrintAutoSenseData.java throwing NPE Reviewed-by: jchen, prr ! src/solaris/classes/sun/print/UnixPrintJob.java ! src/windows/classes/sun/print/Win32PrintJob.java ! test/javax/print/attribute/autosense/PrintAutoSenseData.java + test/javax/print/attribute/autosense/sample.txt Changeset: fe04f40cf469 Author: prr Date: 2013-08-06 17:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fe04f40cf469 8022455: Fix doclint warnings in javax.imageio Reviewed-by: darcy ! src/share/classes/javax/imageio/ImageIO.java ! src/share/classes/javax/imageio/ImageReadParam.java ! src/share/classes/javax/imageio/ImageReader.java ! src/share/classes/javax/imageio/ImageTypeSpecifier.java ! src/share/classes/javax/imageio/ImageWriteParam.java ! src/share/classes/javax/imageio/ImageWriter.java ! src/share/classes/javax/imageio/metadata/IIOMetadataFormatImpl.java ! src/share/classes/javax/imageio/plugins/bmp/BMPImageWriteParam.java ! src/share/classes/javax/imageio/plugins/jpeg/JPEGImageReadParam.java ! src/share/classes/javax/imageio/plugins/jpeg/JPEGImageWriteParam.java ! src/share/classes/javax/imageio/spi/ImageReaderSpi.java ! src/share/classes/javax/imageio/spi/ImageWriterSpi.java ! src/share/classes/javax/imageio/spi/ServiceRegistry.java ! src/share/classes/javax/imageio/stream/ImageInputStream.java ! src/share/classes/javax/imageio/stream/ImageInputStreamImpl.java ! src/share/classes/javax/imageio/stream/ImageOutputStream.java Changeset: c827ad8c1101 Author: prr Date: 2013-08-06 17:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c827ad8c1101 8022447: Fix doclint warnings in java.awt.image Reviewed-by: darcy ! src/share/classes/java/awt/image/BufferStrategy.java ! src/share/classes/java/awt/image/BufferedImage.java ! src/share/classes/java/awt/image/ByteLookupTable.java ! src/share/classes/java/awt/image/ColorModel.java ! src/share/classes/java/awt/image/DirectColorModel.java ! src/share/classes/java/awt/image/ImageProducer.java ! src/share/classes/java/awt/image/IndexColorModel.java ! src/share/classes/java/awt/image/MemoryImageSource.java ! src/share/classes/java/awt/image/MultiPixelPackedSampleModel.java ! src/share/classes/java/awt/image/PixelGrabber.java ! src/share/classes/java/awt/image/RGBImageFilter.java ! src/share/classes/java/awt/image/ShortLookupTable.java ! src/share/classes/java/awt/image/SinglePixelPackedSampleModel.java ! src/share/classes/java/awt/image/WritableRaster.java Changeset: 9314c199003d Author: lana Date: 2013-08-06 22:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9314c199003d Merge - src/share/classes/java/net/package.html Changeset: ab64c138d5bd Author: prr Date: 2013-08-07 18:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ab64c138d5bd 8014883: java.awt.container.add(component comp object constraints) doesn't work as expected on some linux platforms Reviewed-by: jgodinez ! makefiles/CompileNativeLibraries.gmk ! src/solaris/native/sun/java2d/x11/XRBackendNative.c Changeset: 645a37a3559f Author: leonidr Date: 2013-08-01 01:26 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/645a37a3559f 8021815: Add regression test for JDK-8007267 Reviewed-by: serb + test/com/apple/eawt/DefaultMenuBar/DefaultMenuBarTest.java Changeset: 495ca130cbde Author: alexsch Date: 2013-08-01 17:09 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/495ca130cbde 7161568: [macosx] api/javax_swing/JTabbedPane/index2.html#varios fails Reviewed-by: malenkov, serb ! src/macosx/classes/com/apple/laf/AquaTabbedPaneCopyFromBasicUI.java ! src/macosx/classes/com/apple/laf/AquaTabbedPaneUI.java + test/javax/swing/JTabbedPane/4361477/bug4361477.java + test/javax/swing/JTabbedPane/6495408/bug6495408.java + test/javax/swing/JTabbedPane/7161568/bug7161568.java Changeset: e76b1568d002 Author: leonidr Date: 2013-08-02 15:42 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e76b1568d002 8021381: JavaFX scene included in Swing JDialog not starting from Web Start Reviewed-by: art, dcherepanov ! src/share/classes/sun/awt/AppContext.java Changeset: 07abddc1d7f2 Author: leonidr Date: 2013-08-06 17:07 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/07abddc1d7f2 8022247: java/awt/EventDispatchThread/LoopRobustness/LoopRobustness throws NPE Reviewed-by: art ! test/java/awt/EventDispatchThread/LoopRobustness/LoopRobustness.java Changeset: 27d1bdf2f7d9 Author: mcherkas Date: 2013-08-06 17:29 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/27d1bdf2f7d9 8016833: Underlines and strikethrough not rendering correctly Reviewed-by: alexsch, serb Contributed-by: anton.nashatyrev at oracle.com ! src/share/classes/javax/swing/text/GlyphView.java + test/javax/swing/text/StyledEditorKit/8016833/bug8016833.java Changeset: f8ed88f5ed87 Author: alexsch Date: 2013-08-07 18:32 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f8ed88f5ed87 8022532: [parfait] Potential memory leak in gtk2_interface.c Reviewed-by: art, serb ! src/solaris/native/sun/awt/gtk2_interface.c Changeset: 7706a622d35f Author: alexsch Date: 2013-08-07 18:58 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7706a622d35f 8013849: Awt assert on Hashtable.cpp:124 Reviewed-by: serb ! src/windows/native/sun/windows/awt_Component.cpp + test/java/awt/event/KeyEvent/DeadKey/DeadKeySystemAssertionDialog.java Changeset: f70492d969e7 Author: serb Date: 2013-08-07 19:57 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f70492d969e7 7124339: [macosx] setIconImage is not endlessly tolerant to the broken image-arguments Reviewed-by: alexsch, leonidr ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java Changeset: 540192229a69 Author: art Date: 2013-08-07 21:31 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/540192229a69 6551589: ContainerListener Documentation may be incorrect Reviewed-by: serb ! src/share/classes/java/awt/event/ContainerListener.java Changeset: 9bcc3f2af980 Author: lana Date: 2013-08-07 12:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9bcc3f2af980 Merge - src/share/classes/java/net/package.html Changeset: e193c4ad940a Author: lana Date: 2013-08-07 19:52 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e193c4ad940a Merge Changeset: 23e68a8e4b91 Author: lana Date: 2013-08-07 19:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/23e68a8e4b91 Merge - test/java/lang/System/MacJNUEncoding/ExpectedEncoding.java - test/java/lang/System/MacJNUEncoding/MacJNUEncoding.sh Changeset: e0f6039c0290 Author: lana Date: 2013-08-13 10:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e0f6039c0290 Merge Changeset: 18ce880b5fb4 Author: lana Date: 2013-08-13 18:33 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/18ce880b5fb4 Merge ! makefiles/CompileNativeLibraries.gmk From vicente.romero at oracle.com Wed Aug 14 02:56:50 2013 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Wed, 14 Aug 2013 09:56:50 +0000 Subject: hg: jdk8/tl/langtools: 8013394: compile of iterator use fails with error \"defined in an inaccessible class or interface\" Message-ID: <20130814095656.1A4184886E@hg.openjdk.java.net> Changeset: 0ad781399706 Author: vromero Date: 2013-08-14 10:53 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0ad781399706 8013394: compile of iterator use fails with error \"defined in an inaccessible class or interface\" Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Lower.java + test/tools/javac/T8013394/CompileErrorWithIteratorTest.java From kumar.x.srinivasan at oracle.com Wed Aug 14 07:12:00 2013 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Wed, 14 Aug 2013 14:12:00 +0000 Subject: hg: jdk8/tl/langtools: 8007517: DefaultMethodRegressionTests.java fail in TL Message-ID: <20130814141207.40C9548882@hg.openjdk.java.net> Changeset: 3ab468194f11 Author: ksrini Date: 2013-08-14 07:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3ab468194f11 8007517: DefaultMethodRegressionTests.java fail in TL Reviewed-by: jjg, vromero - test/tools/javac/defaultMethods/defaultMethodExecution/DefaultMethodRegressionTests.java From coleen.phillimore at oracle.com Wed Aug 14 07:22:53 2013 From: coleen.phillimore at oracle.com (coleen.phillimore at oracle.com) Date: Wed, 14 Aug 2013 14:22:53 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20130814142330.58BF748884@hg.openjdk.java.net> Changeset: cb74d71fd02f Author: hseigel Date: 2013-08-13 10:56 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cb74d71fd02f 8022259: MakeClasslist is buggy and its README is out of date. Summary: Fixed bug in FOR loop and updated comments and README Reviewed-by: dholmes, alanb ! make/tools/sharing/README.txt ! make/tools/src/build/tools/makeclasslist/MakeClasslist.java Changeset: f9cf6ecf596c Author: coleenp Date: 2013-08-14 10:14 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f9cf6ecf596c Merge From jose.cornado at gmail.com Wed Aug 14 07:31:58 2013 From: jose.cornado at gmail.com (=?ISO-8859-1?Q?Jos=E9_Cornado?=) Date: Wed, 14 Aug 2013 08:31:58 -0600 Subject: Problems with "-implicit:none" In-Reply-To: References: Message-ID: It is no fun if the workaround is not posted :-} I flushed the streams to disk thus creating the *.java. Since the background jvm uses these classes and not the user, the files (*.java and *.class) can be deleted from disk soon after consumption. The disk remains free of clutter. I can not tell if the compiler processes the imported *.java or just merely checks its presence since the corresponding *.class is already in place. Hope these two cents help! On Tue, Aug 13, 2013 at 12:30 PM, Jos? Cornado wrote: > Problem worked around. Thanks anyway! > > > On Fri, Aug 9, 2013 at 7:37 AM, Jos? Cornado wrote: > >> Hello! >> >> I have the following problem with javax.tools.JavaCompiler: >> >> A background jvm, depending on user input from IDE, generates classes >> dynamically. >> >> This can take time, so to avoid the delay I use the flag >> "-implicit:none". The IDE provides enough data I can infer if everything is >> in place and stick to parse/build just the target class. Because I don't >> write some streams to disk there are a lot of cases where the *.class is in >> the correct directory but the *.java does not exist. >> >> Now the problem: >> >> If the target class imports a type from another package/location the flag >> works great. If the target class imports a class from the same location the >> JavaCompiler completely ignores this flag and the fact that the *.class >> exists and looks for the source file which doesn't exist and fails. >> >> Question 1: is this the expected behavior of the compiler. >> >> Question 2: would avoid importing type from the same package change the >> behavior of the compiler in anyway? >> >> I am running build 1.7.0_25-b15 on a mac >> >> >> Thanks a lot in advance!!! >> >> -- >> Jos? Cornado >> >> -- >> >> home: http://www.efekctive.com >> blog: http://blogging.efekctive.com >> ---------------------- >> >> Everything has been said before, but since nobody listens we have to keep >> going back and beginning all over again. >> >> Andre Gide >> > > > > -- > Jos? Cornado > > -- > > home: http://www.efekctive.com > blog: http://blogging.efekctive.com > ---------------------- > > Everything has been said before, but since nobody listens we have to keep > going back and beginning all over again. > > Andre Gide > -- Jos? Cornado -- home: http://www.efekctive.com blog: http://blogging.efekctive.com ---------------------- Everything has been said before, but since nobody listens we have to keep going back and beginning all over again. Andre Gide -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20130814/67cd4245/attachment.html From kumar.x.srinivasan at oracle.com Wed Aug 14 08:14:11 2013 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Wed, 14 Aug 2013 15:14:11 +0000 Subject: hg: jdk8/tl/jdk: 8022547: [verifier] move DefaultMethodRegressionTests.java to jdk Message-ID: <20130814151438.4906648890@hg.openjdk.java.net> Changeset: bc3cafb17c09 Author: ksrini Date: 2013-08-14 08:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bc3cafb17c09 8022547: [verifier] move DefaultMethodRegressionTests.java to jdk Reviewed-by: acorn + test/vm/verifier/defaultMethods/DefaultMethodRegressionTests.java + test/vm/verifier/defaultMethods/DefaultMethodRegressionTestsRun.java From vicente.romero at oracle.com Wed Aug 14 10:51:03 2013 From: vicente.romero at oracle.com (Vicente-Arturo Romero-Zaldivar) Date: Wed, 14 Aug 2013 18:51:03 +0100 Subject: Problems with "-implicit:none" In-Reply-To: References: Message-ID: <520BC387.60205@oracle.com> On 14/08/13 15:31, Jos? Cornado wrote: > It is no fun if the workaround is not posted :-} > > I flushed the streams to disk thus creating the *.java. Since the > background jvm uses these classes and not the user, the files (*.java > and *.class) can be deleted from disk soon after consumption. The disk > remains free of clutter. > > I can not tell if the compiler processes the imported *.java or just > merely checks its presence since the corresponding *.class is already > in place. > > Hope these two cents help! Hi Jose, Thanks for the info, you can probably get more info if you compile your files with -verbose option. Vicente > > > On Tue, Aug 13, 2013 at 12:30 PM, Jos? Cornado > wrote: > > Problem worked around. Thanks anyway! > > > On Fri, Aug 9, 2013 at 7:37 AM, Jos? Cornado > > wrote: > > Hello! > > I have the following problem with javax.tools.JavaCompiler: > > A background jvm, depending on user input from IDE, generates > classes dynamically. > > This can take time, so to avoid the delay I use the flag > "-implicit:none". The IDE provides enough data I can infer if > everything is in place and stick to parse/build just the > target class. Because I don't write some streams to disk > there are a lot of cases where the *.class is in the correct > directory but the *.java does not exist. > > Now the problem: > > If the target class imports a type from another > package/location the flag works great. If the target class > imports a class from the same location the JavaCompiler > completely ignores this flag and the fact that the *.class > exists and looks for the source file which doesn't exist and > fails. > > Question 1: is this the expected behavior of the compiler. > > Question 2: would avoid importing type from the same package > change the behavior of the compiler in anyway? > > I am running build 1.7.0_25-b15 on a mac > > > Thanks a lot in advance!!! > > -- > Jos? Cornado > > -- > > home: http://www.efekctive.com > blog: http://blogging.efekctive.com > ---------------------- > > Everything has been said before, but since nobody listens we > have to keep going back and beginning all over again. > > Andre Gide > > > > > -- > Jos? Cornado > > -- > > home: http://www.efekctive.com > blog: http://blogging.efekctive.com > ---------------------- > > Everything has been said before, but since nobody listens we have > to keep going back and beginning all over again. > > Andre Gide > > > > > -- > Jos? Cornado > > -- > > home: http://www.efekctive.com > blog: http://blogging.efekctive.com > ---------------------- > > Everything has been said before, but since nobody listens we have to > keep going back and beginning all over again. > > Andre Gide -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20130814/2c787189/attachment.html From xueming.shen at oracle.com Wed Aug 14 11:40:18 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Wed, 14 Aug 2013 18:40:18 +0000 Subject: hg: jdk8/tl/jdk: 8022178: System.console() throws IOE on some Windows Message-ID: <20130814184030.A190B48897@hg.openjdk.java.net> Changeset: c138d1b608e0 Author: sherman Date: 2013-08-14 11:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c138d1b608e0 8022178: System.console() throws IOE on some Windows Summary: to remove the IOE throwing code Reviewed-by: alanb ! src/windows/native/java/io/Console_md.c From joe.darcy at oracle.com Wed Aug 14 11:27:21 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Wed, 14 Aug 2013 18:27:21 +0000 Subject: hg: jdk8/tl/jdk: 8022990: Fix dep_ann lint warnings in swing code Message-ID: <20130814182745.46DDC48895@hg.openjdk.java.net> Changeset: 444a7edcf367 Author: darcy Date: 2013-08-14 11:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/444a7edcf367 8022990: Fix dep_ann lint warnings in swing code Reviewed-by: alexsch ! src/share/classes/com/sun/java/swing/Painter.java ! src/share/classes/com/sun/java/swing/plaf/nimbus/AbstractRegionPainter.java ! src/share/classes/com/sun/java/swing/plaf/nimbus/NimbusLookAndFeel.java From mike.duigou at oracle.com Wed Aug 14 13:38:36 2013 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Wed, 14 Aug 2013 20:38:36 +0000 Subject: hg: jdk8/tl/jdk: 8022109: Evaluate adding incrementExact, decrementExact, negateExact to java.lang.Math Message-ID: <20130814203859.9BC0F4889C@hg.openjdk.java.net> Changeset: 17dfbb3f60d3 Author: bpb Date: 2013-08-12 10:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/17dfbb3f60d3 8022109: Evaluate adding incrementExact, decrementExact, negateExact to java.lang.Math Summary: Add the methods for parameter types int and long. Reviewed-by: mduigou Contributed-by: Brian Burkhalter ! src/share/classes/java/lang/Math.java ! test/java/lang/Math/ExactArithTests.java From jonathan.gibbons at oracle.com Wed Aug 14 16:41:29 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Wed, 14 Aug 2013 23:41:29 +0000 Subject: hg: jdk8/tl/langtools: 8017191: Javadoc is confused by @link to imported classes outside of the set of generated packages Message-ID: <20130814234134.907F4488A5@hg.openjdk.java.net> Changeset: 14faef2b51eb Author: jjg Date: 2013-08-14 16:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/14faef2b51eb 8017191: Javadoc is confused by @link to imported classes outside of the set of generated packages Reviewed-by: bpatel ! src/share/classes/com/sun/tools/doclets/formats/html/LinkFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/StringContent.java + test/com/sun/javadoc/testSeeTag/TestSeeTag.java + test/com/sun/javadoc/testSeeTag/pkg/Test.java From kumar.x.srinivasan at oracle.com Wed Aug 14 18:59:33 2013 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Thu, 15 Aug 2013 01:59:33 +0000 Subject: hg: jdk8/tl/langtools: 6840442: JavaCompiler.getTask() has incomplete specification for IllegalArgumentException Message-ID: <20130815015938.49FDB488A8@hg.openjdk.java.net> Changeset: fac0d1bb87f2 Author: ksrini Date: 2013-08-14 18:58 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/fac0d1bb87f2 6840442: JavaCompiler.getTask() has incomplete specification for IllegalArgumentException Reviewed-by: jjg ! src/share/classes/javax/tools/JavaCompiler.java From bhavesh.x.patel at oracle.com Wed Aug 14 21:49:20 2013 From: bhavesh.x.patel at oracle.com (bhavesh.x.patel at oracle.com) Date: Thu, 15 Aug 2013 04:49:20 +0000 Subject: hg: jdk8/tl/langtools: 8016921: Change the profiles table on overview-summary.html page to a list Message-ID: <20130815044923.A3925488B2@hg.openjdk.java.net> Changeset: 3d4f0fa2ad05 Author: bpatel Date: 2013-08-14 21:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3d4f0fa2ad05 8016921: Change the profiles table on overview-summary.html page to a list Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractPackageIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexWriter.java ! test/com/sun/javadoc/testProfiles/TestProfiles.java From bradford.wetmore at oracle.com Wed Aug 14 19:21:36 2013 From: bradford.wetmore at oracle.com (bradford.wetmore at oracle.com) Date: Thu, 15 Aug 2013 02:21:36 +0000 Subject: hg: jdk8/tl/jdk: 8023075: JDK-5049299 has broken old make in jdk8 Message-ID: <20130815022202.8E3A8488AA@hg.openjdk.java.net> Changeset: f8af3499c1fb Author: wetmore Date: 2013-08-14 19:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f8af3499c1fb 8023075: JDK-5049299 has broken old make in jdk8 Reviewed-by: katleman ! make/java/java/Makefile From yong.huang at oracle.com Wed Aug 14 23:00:07 2013 From: yong.huang at oracle.com (yong.huang at oracle.com) Date: Thu, 15 Aug 2013 06:00:07 +0000 Subject: hg: jdk8/tl/jdk: 8021121: ISO 4217 Amendment Number 156 Message-ID: <20130815060019.9A492488B3@hg.openjdk.java.net> Changeset: 2f6523abab08 Author: yhuang Date: 2013-08-14 22:49 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2f6523abab08 8021121: ISO 4217 Amendment Number 156 Reviewed-by: naoto ! src/share/classes/java/util/CurrencyData.properties ! src/share/classes/sun/util/resources/lv/CurrencyNames_lv_LV.properties ! test/java/util/Currency/tablea1.txt ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java From erik.joelsson at oracle.com Thu Aug 15 03:36:26 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Thu, 15 Aug 2013 12:36:26 +0200 Subject: RFR: 8015145: Smartjavac needs more flexibility with linking to sources In-Reply-To: <5202153C.4020509@oracle.com> References: <51B1D57A.3030305@oracle.com> <51F2DEA5.4020404@oracle.com> <5202153C.4020509@oracle.com> Message-ID: <520CAF2A.2030407@oracle.com> Friendly reminder that this needs to be looked at. The JCE team converting to the new build is dependent on this change. /Erik On 2013-08-07 11:37, Erik Joelsson wrote: > > > On 2013-07-26 22:40, Jonathan Gibbons wrote: >> I am concerned by the preceding comment, starting line 255. >> >> 255 // Always reuse -src for linking as well! This means >> that we might >> 256 // get two -sourcepath on the commandline after the >> rewrite, which is >> 257 // fine. We can have as many as we like. >> >> Yes, you can put as many -sourcepath options as you want, but as far >> as javac >> is concerned, "last one wins". If you want all the options to be >> significant in the >> child javac commands, you need to join the values. >> > I have reworded the comment, explaining that they are indeed joined > later, before being handed to javac. I also added a test for the > usecase I'm describing below and made the Sjavac tests runnable by jtreg. > > http://cr.openjdk.java.net/~erikj/8015145/webrev.langtools.02/ > > /Erik >> -- Jon >> >> On 06/07/2013 05:43 AM, Erik Joelsson wrote: >>> Here is a patch solving a problem with -sourcepath for sjavac. >>> >>> First some background. The security sources (the ones that require >>> signing) need to be built to a separate directory. If they aren't >>> (as is the case now) security tests will fail if run on the exploded >>> jdk image (the one you get when just typing make or make jdk). In >>> JDK-8009280, I'm trying to fix this. The solution I have for that >>> bug is working well, except when running with sjavac, and basically >>> builds all classes except the security classes first to the normal >>> outputdir and then as a separate step builds just the security >>> classes to a different outputdir. >>> >>> There are two issues that need to be addressed in sjavac for this to >>> work. First, it needs to be possible to supply the same source root >>> both to the -src and -sourcepath option (but with different filter >>> rules). Sjavac is very picky and only links to sources that are >>> included in either of those options, and since we are excluding the >>> security sources from -src, we need to add them to -sourcepath. >>> >>> The second thing is more of a bug as far as I can tell. Sjavac >>> compares the found set of sources to compile with what the makefile >>> think needs to be compiled, as a safety check. Currently, sjavac is >>> including sources that are just being linked to in this comparison. >>> I would think that it should only include sources that are meant to >>> be compiled. >>> >>> http://cr.openjdk.java.net/~erikj/8015145/webrev.langtools.01/ >>> >>> http://bugs.sun.com/view_bug.do?bug_id=8015145 >>> >>> /Erik >> From alan.bateman at oracle.com Thu Aug 15 03:59:11 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Thu, 15 Aug 2013 10:59:11 +0000 Subject: hg: jdk8/tl/jdk: 8022921: Remove experimental Profile attribute Message-ID: <20130815105950.DE270488BB@hg.openjdk.java.net> Changeset: 5ff3b55df2d4 Author: alanb Date: 2013-08-15 11:54 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5ff3b55df2d4 8022921: Remove experimental Profile attribute Reviewed-by: mchung, chegar ! src/share/classes/java/net/URLClassLoader.java ! src/share/classes/java/util/jar/Attributes.java ! src/share/classes/java/util/jar/JarFile.java ! src/share/classes/java/util/jar/JavaUtilJarAccessImpl.java - src/share/classes/java/util/jar/UnsupportedProfileException.java ! src/share/classes/sun/launcher/LauncherHelper.java ! src/share/classes/sun/launcher/resources/launcher.properties ! src/share/classes/sun/misc/JavaUtilJarAccess.java ! src/share/classes/sun/misc/URLClassPath.java ! src/share/classes/sun/misc/Version.java.template ! src/share/classes/sun/tools/jar/Main.java ! src/share/classes/sun/tools/jar/resources/jar.properties - test/java/net/URLClassLoader/profiles/Basic.java - test/java/net/URLClassLoader/profiles/Lib.java - test/java/net/URLClassLoader/profiles/basic.sh - test/tools/jar/AddAndUpdateProfile.java - test/tools/launcher/profiles/Basic.java - test/tools/launcher/profiles/Logging.java - test/tools/launcher/profiles/Main.java - test/tools/launcher/profiles/VersionCheck.java From alan.bateman at oracle.com Thu Aug 15 05:47:15 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Thu, 15 Aug 2013 12:47:15 +0000 Subject: hg: jdk8/tl/jdk: 8015765: TEST_BUG: java/nio/channels/ServerSocketChannel/AdaptServerSocket.java failing intermittently Message-ID: <20130815124748.AA4E2488BC@hg.openjdk.java.net> Changeset: b7b0beef5ded Author: alanb Date: 2013-08-15 13:42 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b7b0beef5ded 8015765: TEST_BUG: java/nio/channels/ServerSocketChannel/AdaptServerSocket.java failing intermittently Reviewed-by: chegar, dholmes, alanb Contributed-by: yiming.wang at oracle.com ! test/java/nio/channels/ServerSocketChannel/AdaptServerSocket.java From chris.hegarty at oracle.com Thu Aug 15 06:52:27 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Thu, 15 Aug 2013 13:52:27 +0000 Subject: hg: jdk8/tl/jdk: 8022584: Memory leak in some NetworkInterface methods Message-ID: <20130815135302.BDDF0488C0@hg.openjdk.java.net> Changeset: 7d7d553a8c61 Author: igerasim Date: 2013-08-13 13:04 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7d7d553a8c61 8022584: Memory leak in some NetworkInterface methods Reviewed-by: alanb, dholmes, chegar, michaelm ! src/solaris/native/java/net/NetworkInterface.c + test/java/net/NetworkInterface/MemLeakTest.java From chris.hegarty at oracle.com Thu Aug 15 07:01:52 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Thu, 15 Aug 2013 14:01:52 +0000 Subject: hg: jdk8/tl/jdk: 8023103: FJ parallelism zero; ... Message-ID: <20130815140204.0D5EE488C1@hg.openjdk.java.net> Changeset: 3223342fb76e Author: dl Date: 2013-08-15 15:01 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3223342fb76e 8023103: FJ parallelism zero 8020537: java/util/concurrent/forkjoin/ThrowingRunnable.java Reviewed-by: chegar, mduigou, alanb ! src/share/classes/java/util/concurrent/ForkJoinPool.java From chris.hegarty at oracle.com Thu Aug 15 07:05:14 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Thu, 15 Aug 2013 14:05:14 +0000 Subject: hg: jdk8/tl/jdk: 8023104: ConcurrentHashMap typo Message-ID: <20130815140526.9587B488C2@hg.openjdk.java.net> Changeset: b07b19182e40 Author: dl Date: 2013-08-15 15:04 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b07b19182e40 8023104: ConcurrentHashMap typo Reviewed-by: chegar, mduigou ! src/share/classes/java/util/concurrent/ConcurrentHashMap.java From chris.hegarty at oracle.com Thu Aug 15 07:16:47 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Thu, 15 Aug 2013 14:16:47 +0000 Subject: hg: jdk8/tl/jdk: 8022126: Remove throws SocketException from DatagramPacket constructors accepting SocketAddress Message-ID: <20130815141659.619C8488C3@hg.openjdk.java.net> Changeset: e7137695dce3 Author: chegar Date: 2013-08-15 15:16 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e7137695dce3 8022126: Remove throws SocketException from DatagramPacket constructors accepting SocketAddress Reviewed-by: smarks, alanb, michaelm, darcy ! src/share/classes/java/net/DatagramPacket.java From jonathan.gibbons at oracle.com Thu Aug 15 08:11:13 2013 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Thu, 15 Aug 2013 08:11:13 -0700 Subject: RFR: 8015145: Smartjavac needs more flexibility with linking to sources In-Reply-To: <520CAF2A.2030407@oracle.com> References: <51B1D57A.3030305@oracle.com> <51F2DEA5.4020404@oracle.com> <5202153C.4020509@oracle.com> <520CAF2A.2030407@oracle.com> Message-ID: <520CEF91.8050705@oracle.com> Looks OK. -- jon On 08/15/2013 03:36 AM, Erik Joelsson wrote: > Friendly reminder that this needs to be looked at. The JCE team > converting to the new build is dependent on this change. > > /Erik > > On 2013-08-07 11:37, Erik Joelsson wrote: >> >> >> On 2013-07-26 22:40, Jonathan Gibbons wrote: >>> I am concerned by the preceding comment, starting line 255. >>> >>> 255 // Always reuse -src for linking as well! This >>> means that we might >>> 256 // get two -sourcepath on the commandline after the >>> rewrite, which is >>> 257 // fine. We can have as many as we like. >>> >>> Yes, you can put as many -sourcepath options as you want, but as far >>> as javac >>> is concerned, "last one wins". If you want all the options to be >>> significant in the >>> child javac commands, you need to join the values. >>> >> I have reworded the comment, explaining that they are indeed joined >> later, before being handed to javac. I also added a test for the >> usecase I'm describing below and made the Sjavac tests runnable by >> jtreg. >> >> http://cr.openjdk.java.net/~erikj/8015145/webrev.langtools.02/ >> >> /Erik >>> -- Jon >>> >>> On 06/07/2013 05:43 AM, Erik Joelsson wrote: >>>> Here is a patch solving a problem with -sourcepath for sjavac. >>>> >>>> First some background. The security sources (the ones that require >>>> signing) need to be built to a separate directory. If they aren't >>>> (as is the case now) security tests will fail if run on the >>>> exploded jdk image (the one you get when just typing make or make >>>> jdk). In JDK-8009280, I'm trying to fix this. The solution I have >>>> for that bug is working well, except when running with sjavac, and >>>> basically builds all classes except the security classes first to >>>> the normal outputdir and then as a separate step builds just the >>>> security classes to a different outputdir. >>>> >>>> There are two issues that need to be addressed in sjavac for this >>>> to work. First, it needs to be possible to supply the same source >>>> root both to the -src and -sourcepath option (but with different >>>> filter rules). Sjavac is very picky and only links to sources that >>>> are included in either of those options, and since we are excluding >>>> the security sources from -src, we need to add them to -sourcepath. >>>> >>>> The second thing is more of a bug as far as I can tell. Sjavac >>>> compares the found set of sources to compile with what the makefile >>>> think needs to be compiled, as a safety check. Currently, sjavac is >>>> including sources that are just being linked to in this comparison. >>>> I would think that it should only include sources that are meant to >>>> be compiled. >>>> >>>> http://cr.openjdk.java.net/~erikj/8015145/webrev.langtools.01/ >>>> >>>> http://bugs.sun.com/view_bug.do?bug_id=8015145 >>>> >>>> /Erik >>> From erik.joelsson at oracle.com Thu Aug 15 08:38:22 2013 From: erik.joelsson at oracle.com (erik.joelsson at oracle.com) Date: Thu, 15 Aug 2013 15:38:22 +0000 Subject: hg: jdk8/tl/langtools: 8015145: Smartjavac needs more flexibility with linking to sources Message-ID: <20130815153832.4D627488C6@hg.openjdk.java.net> Changeset: 71b0089b146f Author: erikj Date: 2013-08-15 17:24 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/71b0089b146f 8015145: Smartjavac needs more flexibility with linking to sources Reviewed-by: jjg, ohrstrom ! src/share/classes/com/sun/tools/sjavac/JavacState.java ! src/share/classes/com/sun/tools/sjavac/Main.java ! test/tools/sjavac/SJavac.java From xueming.shen at oracle.com Thu Aug 15 10:39:16 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Thu, 15 Aug 2013 17:39:16 +0000 Subject: hg: jdk8/tl/jdk: 7154662: {CRC32, Adler32}.update(byte[] b, int off, int len): undocumented ArrayIndexOutOfBoundsException Message-ID: <20130815173953.E887D488DF@hg.openjdk.java.net> Changeset: 6c307b4d0dd8 Author: sherman Date: 2013-08-15 10:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6c307b4d0dd8 7154662: {CRC32, Adler32}.update(byte[] b, int off, int len): undocumented ArrayIndexOutOfBoundsException Summary: to add the throws clause Reviewed-by: alanb, chegar ! src/share/classes/java/util/zip/Adler32.java ! src/share/classes/java/util/zip/CRC32.java From vincent.x.ryan at oracle.com Thu Aug 15 11:57:28 2013 From: vincent.x.ryan at oracle.com (vincent.x.ryan at oracle.com) Date: Thu, 15 Aug 2013 18:57:28 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20130815185828.D4AEB488F8@hg.openjdk.java.net> Changeset: b4645069238a Author: vinnie Date: 2013-08-15 19:49 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b4645069238a 8023108: Remove ShortRSAKey1024.sh from ProblemList.txt Reviewed-by: mullan ! test/ProblemList.txt Changeset: 3211caab58ba Author: vinnie Date: 2013-08-15 19:56 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3211caab58ba Merge From dan.xu at oracle.com Thu Aug 15 12:37:01 2013 From: dan.xu at oracle.com (dan.xu at oracle.com) Date: Thu, 15 Aug 2013 19:37:01 +0000 Subject: hg: jdk8/tl/jdk: 4858457: File.getCanonicalPath() throws IOException when invoked with "nul" (win) Message-ID: <20130815193727.9F60848905@hg.openjdk.java.net> Changeset: 5bb196aa183c Author: dxu Date: 2013-08-15 12:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5bb196aa183c 4858457: File.getCanonicalPath() throws IOException when invoked with "nul" (win) Reviewed-by: alanb ! src/windows/native/java/io/canonicalize_md.c ! test/java/io/File/WinDeviceName.java From dan.xu at oracle.com Thu Aug 15 14:11:34 2013 From: dan.xu at oracle.com (dan.xu at oracle.com) Date: Thu, 15 Aug 2013 21:11:34 +0000 Subject: hg: jdk8/tl/jdk: 8017109: Cleanup overrides warning in src/solaris/classes/sun/print/AttributeClass.java Message-ID: <20130815211147.0FDCE48913@hg.openjdk.java.net> Changeset: 0d27309a87e0 Author: dxu Date: 2013-08-15 14:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0d27309a87e0 8017109: Cleanup overrides warning in src/solaris/classes/sun/print/AttributeClass.java Reviewed-by: jgodinez ! src/solaris/classes/sun/print/AttributeClass.java From henry.jen at oracle.com Thu Aug 15 16:14:21 2013 From: henry.jen at oracle.com (henry.jen at oracle.com) Date: Thu, 15 Aug 2013 23:14:21 +0000 Subject: hg: jdk8/tl/jdk: 8019401: Collectors.collectingAndThen Message-ID: <20130815231432.C0BFB48918@hg.openjdk.java.net> Changeset: 5649837a4cfa Author: briangoetz Date: 2013-08-12 12:06 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5649837a4cfa 8019401: Collectors.collectingAndThen Reviewed-by: mduigou Contributed-by: brian.goetz at oracle.com ! src/share/classes/java/util/stream/Collectors.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/TabulatorsTest.java From debasish.raychawdhuri at gmail.com Thu Aug 15 21:14:53 2013 From: debasish.raychawdhuri at gmail.com (Debasish Chawdhuri) Date: Fri, 16 Aug 2013 04:14:53 +0000 (UTC) Subject: Invitation to connect on LinkedIn Message-ID: <2096325348.92556811.1376626493363.JavaMail.app@ela4-app3202.prod> LinkedIn ------------ I'd like to add you to my professional network on LinkedIn. - Debasish Debasish Chawdhuri Senior Software Engineer at Oracle India Pvt. Ltd. New Delhi Area, India Confirm that you know Debasish Chawdhuri: https://www.linkedin.com/e/-slh87j-hkevvcei-2b/isd/15820579866/G4S12-rN/?hs=false&tok=2NnFr0Xeou65U1 -- You are receiving Invitation to Connect emails. Click to unsubscribe: http://www.linkedin.com/e/-slh87j-hkevvcei-2b/R-3fFUUSpgBaav3UBk3ikLZSLgptC85tbbYbkTOanhiv/goo/compiler-dev%40openjdk%2Ejava%2Enet/20061/I5263387340_1/?hs=false&tok=2RkoPNQVsu65U1 (c) 2012 LinkedIn Corporation. 2029 Stierlin Ct, Mountain View, CA 94043, USA. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20130816/c2a997d9/attachment.html From erik.joelsson at oracle.com Fri Aug 16 01:35:06 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Fri, 16 Aug 2013 10:35:06 +0200 Subject: RFR: 8023146: Sjavac test failes in langtools nightly Message-ID: <520DE43A.9040907@oracle.com> In JDK-8015145, I converted the test for sjavac into a jtreg test. This proved to be a mistake. Since sjavac isn't being shipped with the product, tests for it can't be included in the regression testsuite as they will not even compile when run against a product build. I propose to remove the jtreg declaration from this test to make it stop failing. This is just reverting what I did in the previous change. http://cr.openjdk.java.net/~erikj/8023146/webrev.langtools.01/ /Erik From vicente.romero at oracle.com Fri Aug 16 02:33:30 2013 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Fri, 16 Aug 2013 09:33:30 +0000 Subject: hg: jdk8/tl/langtools: 8022053: javac generates unverifiable initializer for nested subclass of local class Message-ID: <20130816093341.F3A3D48927@hg.openjdk.java.net> Changeset: a6378c19836b Author: vromero Date: 2013-08-16 10:32 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a6378c19836b 8022053: javac generates unverifiable initializer for nested subclass of local class Reviewed-by: jjg, mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Lower.java + test/tools/javac/T8022053/UnverifiableInitForNestedLocalClassTest.java From vicente.romero at oracle.com Fri Aug 16 02:37:38 2013 From: vicente.romero at oracle.com (Vicente-Arturo Romero-Zaldivar) Date: Fri, 16 Aug 2013 10:37:38 +0100 Subject: javac generates unverifiable initializer for nested subclass of local class. In-Reply-To: References: Message-ID: <520DF2E2.8050805@oracle.com> Hi Jeremy, This bug has been fixed: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a6378c19836b Thanks for your report, Vicente On 01/08/13 07:36, Jeremy Manson wrote: > Hi folks, > > I mentioned to a couple of people on the list that we have a some > unreported bugs. In an effort to be better about reporting them, I'll > mention this oldie but goodie that dates back to JDK 6 update 4. > > (I have to verify that each of them is still a bug, so this might be a > trickle rather than a flood) > > public class TestTest { > public static void main(final String args[]) { > class NamedLocal { > Object m() { > return args; > } > > class NamedLocalSub extends NamedLocal {} > } > new NamedLocal().new NamedLocalSub(); > } > } > > With JDK8 b84: > > $ javac TestTest.java > $ java TestTest > Exception in thread "main" java.lang.VerifyError: Bad type on operand > stack > Exception Details: > Location: > TestTest$1NamedLocal$NamedLocalSub.(LTestTest$1NamedLocal;)V @7: > getfield > Reason: > Type uninitializedThis (current frame, stack[1]) is not assignable to > 'TestTest$1NamedLocal$NamedLocalSub' > Current Frame: > bci: @7 > flags: { flagThisUninit } > locals: { uninitializedThis, 'TestTest$1NamedLocal' } > stack: { uninitializedThis, uninitializedThis } > Bytecode: > 0000000: 2a2b b500 012a 2ab4 0002 b700 03b1 > > at TestTest.main(TestTest.java:10) > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20130816/ed35046c/attachment.html From paul.sandoz at oracle.com Fri Aug 16 03:41:09 2013 From: paul.sandoz at oracle.com (paul.sandoz at oracle.com) Date: Fri, 16 Aug 2013 10:41:09 +0000 Subject: hg: jdk8/tl/jdk: 8023150: java/util/stream tests no longer compiling following JDK-8019401 Message-ID: <20130816104126.AC1FD4892A@hg.openjdk.java.net> Changeset: 5fe19566b6f0 Author: psandoz Date: 2013-08-16 12:29 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5fe19566b6f0 8023150: java/util/stream tests no longer compiling following JDK-8019401 Reviewed-by: alanb ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/TabulatorsTest.java From paul.sandoz at oracle.com Fri Aug 16 03:50:51 2013 From: paul.sandoz at oracle.com (paul.sandoz at oracle.com) Date: Fri, 16 Aug 2013 10:50:51 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20130816105116.052784892B@hg.openjdk.java.net> Changeset: 2eebaff52a94 Author: psandoz Date: 2013-08-16 12:46 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2eebaff52a94 8012940: More than 50 tests failed in Serialization/DeSerialization testing (test-mangled) Reviewed-by: ksrini + test/java/util/stream/bootlib/java/util/stream/LambdaTestMode.java ! test/java/util/stream/bootlib/java/util/stream/StreamTestDataProvider.java Changeset: 02ce5a0e4b98 Author: psandoz Date: 2013-08-16 12:46 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/02ce5a0e4b98 8022898: java/util/Spliterator/SpliteratorCollisions.java fails in HashableIntSpliteratorWithNull data provider Reviewed-by: henryjen, alanb, rriggs ! test/java/util/Spliterator/SpliteratorCollisions.java From maurizio.cimadamore at oracle.com Fri Aug 16 04:02:10 2013 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Fri, 16 Aug 2013 11:02:10 +0000 Subject: hg: jdk8/tl/langtools: 2 new changesets Message-ID: <20130816110219.73A474892C@hg.openjdk.java.net> Changeset: ec77c7b46c37 Author: jlahoda Date: 2013-08-15 22:33 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ec77c7b46c37 8015809: More user friendly compile-time errors for uncaught exceptions in lambda expression Summary: Producing individual errors for uncaught undeclared exceptions inside lambda expressions, rather than one error for the whole lambda Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/tree/JCTree.java - test/tools/javac/diags/examples/IncompatibleThrownTypesInLambda.java + test/tools/javac/lambda/ExceptionsInLambda.java + test/tools/javac/lambda/ExceptionsInLambda.out ! test/tools/javac/lambda/TargetType21.out Changeset: f657d400c736 Author: jlahoda Date: 2013-08-15 22:36 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f657d400c736 8022508: javac crashes if the generics arity of a base class is wrong Reviewed-by: mcimadamore, vromero ! src/share/classes/com/sun/tools/javac/comp/Check.java ! test/tools/javac/generics/8016640/T8016640.java From paul.sandoz at oracle.com Fri Aug 16 04:24:39 2013 From: paul.sandoz at oracle.com (paul.sandoz at oracle.com) Date: Fri, 16 Aug 2013 11:24:39 +0000 Subject: hg: jdk8/tl/jdk: 8022797: Clarify spliterator characteristics for collections containing no elements Message-ID: <20130816112450.C13654892E@hg.openjdk.java.net> Changeset: 737b6c298d81 Author: psandoz Date: 2013-08-13 11:16 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/737b6c298d81 8022797: Clarify spliterator characteristics for collections containing no elements Reviewed-by: alanb, mduigou ! src/share/classes/java/util/Collection.java From joel.franck at oracle.com Fri Aug 16 06:07:38 2013 From: joel.franck at oracle.com (Joel Borggren-Franck) Date: Fri, 16 Aug 2013 15:07:38 +0200 Subject: RFR: 8023146: Sjavac test failes in langtools nightly In-Reply-To: <520DE43A.9040907@oracle.com> References: <520DE43A.9040907@oracle.com> Message-ID: <20130816130738.GN12405@jfranck-desktop.jrpg.bea.com> On 2013-08-16, Erik Joelsson wrote: > In JDK-8015145, I converted the test for sjavac into a jtreg test. > This proved to be a mistake. Since sjavac isn't being shipped with > the product, tests for it can't be included in the regression > testsuite as they will not even compile when run against a product > build. > > I propose to remove the jtreg declaration from this test to make it > stop failing. This is just reverting what I did in the previous > change. > > http://cr.openjdk.java.net/~erikj/8023146/webrev.langtools.01/ > Looks good to me. (Not a Reviewer kind of reviewer). Looks like we moved the jtreg block from SJavac to SjavacWrapper the change before yours. cheers /Joel From maurizio.cimadamore at oracle.com Fri Aug 16 06:46:10 2013 From: maurizio.cimadamore at oracle.com (Maurizio Cimadamore) Date: Fri, 16 Aug 2013 14:46:10 +0100 Subject: RFR: 8023146: Sjavac test failes in langtools nightly In-Reply-To: <20130816130738.GN12405@jfranck-desktop.jrpg.bea.com> References: <520DE43A.9040907@oracle.com> <20130816130738.GN12405@jfranck-desktop.jrpg.bea.com> Message-ID: <520E2D22.3040006@oracle.com> On 16/08/13 14:07, Joel Borggren-Franck wrote: > On 2013-08-16, Erik Joelsson wrote: >> In JDK-8015145, I converted the test for sjavac into a jtreg test. >> This proved to be a mistake. Since sjavac isn't being shipped with >> the product, tests for it can't be included in the regression >> testsuite as they will not even compile when run against a product >> build. >> >> I propose to remove the jtreg declaration from this test to make it >> stop failing. This is just reverting what I did in the previous >> change. >> >> http://cr.openjdk.java.net/~erikj/8023146/webrev.langtools.01/ >> > Looks good to me. (Not a Reviewer kind of reviewer). > > Looks like we moved the jtreg block from SJavac to SjavacWrapper the > change before yours. > > cheers > /Joel Looks good Maurizio From erik.joelsson at oracle.com Fri Aug 16 07:00:31 2013 From: erik.joelsson at oracle.com (erik.joelsson at oracle.com) Date: Fri, 16 Aug 2013 14:00:31 +0000 Subject: hg: jdk8/tl/langtools: 8023146: Sjavac test failes in langtools nightly Message-ID: <20130816140037.E276D48935@hg.openjdk.java.net> Changeset: 4300c2f5fb1b Author: erikj Date: 2013-08-16 16:00 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4300c2f5fb1b 8023146: Sjavac test failes in langtools nightly Reviewed-by: mcimadamore, jfranck ! test/tools/sjavac/SJavac.java From kumar.x.srinivasan at oracle.com Fri Aug 16 07:46:22 2013 From: kumar.x.srinivasan at oracle.com (Kumar Srinivasan) Date: Fri, 16 Aug 2013 07:46:22 -0700 Subject: RFR: 8023146: Sjavac test failes in langtools nightly In-Reply-To: <520DE43A.9040907@oracle.com> References: <520DE43A.9040907@oracle.com> Message-ID: <520E3B3E.7080108@oracle.com> Erik, FWIW, We have some "long" running tests which are activated by setting a system property, this makes it easier for a developer to set a property and test the functionality in a developer build. Kumar > In JDK-8015145, I converted the test for sjavac into a jtreg test. > This proved to be a mistake. Since sjavac isn't being shipped with the > product, tests for it can't be included in the regression testsuite as > they will not even compile when run against a product build. > > I propose to remove the jtreg declaration from this test to make it > stop failing. This is just reverting what I did in the previous change. > > http://cr.openjdk.java.net/~erikj/8023146/webrev.langtools.01/ > > /Erik From jonathan.gibbons at oracle.com Fri Aug 16 09:28:51 2013 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Fri, 16 Aug 2013 09:28:51 -0700 Subject: RFR: 8023146: Sjavac test failes in langtools nightly In-Reply-To: <520DE43A.9040907@oracle.com> References: <520DE43A.9040907@oracle.com> Message-ID: <520E5343.7060000@oracle.com> Eric, Please don't do this. The correct solution is to make sure the test passes vacuously when sjavac is not available. -- Jon On 08/16/2013 01:35 AM, Erik Joelsson wrote: > In JDK-8015145, I converted the test for sjavac into a jtreg test. > This proved to be a mistake. Since sjavac isn't being shipped with the > product, tests for it can't be included in the regression testsuite as > they will not even compile when run against a product build. > > I propose to remove the jtreg declaration from this test to make it > stop failing. This is just reverting what I did in the previous change. > > http://cr.openjdk.java.net/~erikj/8023146/webrev.langtools.01/ > > /Erik From jonathan.gibbons at oracle.com Fri Aug 16 09:46:31 2013 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Fri, 16 Aug 2013 09:46:31 -0700 Subject: RFR: 8023146: Sjavac test failes in langtools nightly In-Reply-To: <520E5343.7060000@oracle.com> References: <520DE43A.9040907@oracle.com> <520E5343.7060000@oracle.com> Message-ID: <520E5767.2000908@oracle.com> Eric, My apologies. Your fix is correct. The functionality I was expecting is in SJavacWrapper.java -- Jon On 08/16/2013 09:28 AM, Jonathan Gibbons wrote: > Eric, > > Please don't do this. The correct solution is to make sure the test > passes vacuously when sjavac is not available. > > -- Jon > > On 08/16/2013 01:35 AM, Erik Joelsson wrote: >> In JDK-8015145, I converted the test for sjavac into a jtreg test. >> This proved to be a mistake. Since sjavac isn't being shipped with >> the product, tests for it can't be included in the regression >> testsuite as they will not even compile when run against a product >> build. >> >> I propose to remove the jtreg declaration from this test to make it >> stop failing. This is just reverting what I did in the previous change. >> >> http://cr.openjdk.java.net/~erikj/8023146/webrev.langtools.01/ >> >> /Erik > From roger.riggs at oracle.com Fri Aug 16 09:50:21 2013 From: roger.riggs at oracle.com (roger.riggs at oracle.com) Date: Fri, 16 Aug 2013 16:50:21 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20130816165100.1B3C04893F@hg.openjdk.java.net> Changeset: 53819fd0ab61 Author: rriggs Date: 2013-08-16 11:28 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/53819fd0ab61 8022770: java/time/tck/java/time/chrono/TCKChronology.java start failing 8022766: java/time/test/java/time/chrono/TestUmmAlQuraChronology.java failed. Summary: TCKChronology: corrected display name to match update from JDK-8015986 Reviewed-by: alanb ! test/java/time/tck/java/time/chrono/TCKChronology.java ! test/java/time/test/java/time/chrono/TestUmmAlQuraChronology.java Changeset: d7fc4e149bb8 Author: rriggs Date: 2013-08-16 11:11 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d7fc4e149bb8 8022193: java/time/test/java/util/TestFormatter.java failed in th locale. Summary: Tests corrected to use fixed locale and not dependent on the environment Reviewed-by: sherman ! src/share/classes/java/util/Formatter.java ! test/java/time/test/java/util/TestFormatter.java From roger.riggs at oracle.com Fri Aug 16 11:00:01 2013 From: roger.riggs at oracle.com (roger.riggs at oracle.com) Date: Fri, 16 Aug 2013 18:00:01 +0000 Subject: hg: jdk8/tl/jdk: 8019185: Inconsistency between JapaneseEra start dates and java.util.JapaneseImperialDate Message-ID: <20130816180013.E79D848946@hg.openjdk.java.net> Changeset: acaa256e3f7c Author: rriggs Date: 2013-08-16 13:58 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/acaa256e3f7c 8019185: Inconsistency between JapaneseEra start dates and java.util.JapaneseImperialDate Summary: align Meiji start date with lib/calendar.properties to avoid any confusion Reviewed-by: sherman ! src/share/classes/java/time/chrono/JapaneseEra.java From eric.mccorkle at oracle.com Fri Aug 16 13:00:56 2013 From: eric.mccorkle at oracle.com (Eric McCorkle) Date: Fri, 16 Aug 2013 16:00:56 -0400 Subject: Review request for JDK-7118412: Shadowing of type-variables vs. member types In-Reply-To: <51F0687F.3070001@oracle.com> References: <5189365A.1020005@oracle.com> <5193AAA4.6060608@oracle.com> <519B4DE5.3020706@oracle.com> <519B4E17.8080908@oracle.com> <519B94F1.8020307@oracle.com> <51F04A2A.6070505@oracle.com> <51F0687F.3070001@oracle.com> Message-ID: <520E84F8.6030406@oracle.com> (Been gone for 2+ weeks) I will incorporate these changes. However, I'm also going to give the new Crucible review system a try. As such, I've uploaded this patch (not yet with Alex's suggested changes). However, anyone not on the Crucible system should feel free to contribute a review. On 07/24/13 19:51, Alex Buckley wrote: > In the test: > > - Check @summary :-( > > - I wanted to like the nested switch statements in MethodCall.succeeds, > but found them inscrutable. I think more descriptive names for enum > constants would help a lot, e.g. INNER_CLASS. And why are type variables > a.k.a. TYPEVAR so interested in a method called "iterator", can't any > reference type have a method called "iterator" ? > > - Shadowing is not specific to method calls, so I think the succeeds > logic should be moved to an instance method of ShadowingTest. doTest > already has to pass three things to call.succeeds, in order for > MethodCall to work out the answer, so passing 'call' as a fourth > argument is no big deal. It is a good thing to have single-purpose enums > to model the language constructs being combined, since the constructs > are already complicated enough themselves. > > - MethodContext suggests some entity apart from a method that provides > an environment for the method. But in fact, MethodContext represents > whether the method iself is a class method or instance method. > MethodKind would be a better name. > > - InsideDef would be better called MethodDeclaration. (And "NONE"? None > what?) TyVar would be better called TypeParameterDeclaration. ( extends ...> is a _type parameter_ declaration, and introduces a _type > variable_ which may be referred to as T in contexts where reference > types are used, e.g. the type in a field declaration. Can you tell I've > been adding annotations on type uses to the JLS recently?) > > - main calls run calls doTest, but doTest is declared before run - and > is private too? Why are some members private and others package-private? > > Alex > > On 7/24/2013 2:42 PM, Eric McCorkle wrote: >> This RFR was dormant for a while pending CCC approval, which happened >> today. Please note that I've made updates since the last reviews. >> >> I will be running the JCK test suite, as this affects the core compiler. >> >> The updated webrev is here: >> http://cr.openjdk.java.net/~emc/7118412/webrew.02/ >> >> On 05/21/13 11:38, Eric McCorkle wrote: >>> I hit a couple of corner cases with the regression tests mid last week. >>> Expect another update sometime in the near future. >>> >>> On 05/21/13 06:36, Maurizio Cimadamore wrote: >>>> On 21/05/13 11:35, Maurizio Cimadamore wrote: >>>>> Fix looks nice - only bit that seems suspicious is the check for >>>>> >>>>> sym == null >>>>> >>>>> The symbol could be different than null, but still not be a 'valid' >>>>> symbol (i.e. because it's an error). Actually, a lookup should never >>>>> return a null symbol. I suggest you return the 'bestSoFar' (which >>>>> would be typeNotFound') and then use the useful method Symbol.exists() >>>>> which should do what you need (check if the symbol is a valid symbol). >>>>> I think in cases where the found symbol is inaccessible it's important >>>>> to stop and to log the error, you should not keep going recursively >>>>> until you find a correct symbol. >>>> The test also needs some work in order to match the combo test idiom (I >>>> should have sent you an example of such tests already). >>>> >>>> Maurizio >>>>> >>>>> Maurizio >>>>> >>>>> On 15/05/13 16:32, Eric McCorkle wrote: >>>>>> I have updated this patch to correct the shadowing of type >>>>>> variables by >>>>>> both member and static member class definitions. >>>>>> >>>>>> I have also included an improved testing framework that exhaustively >>>>>> tests the possible combinations. >>>>>> >>>>>> Note that a CCC has been filed for this patch, as it changes the way >>>>>> that type names are resolved in the compiler. >>>>>> >>>>>> Please review and comment. >>>>>> >>>>>> On 05/07/13 13:14, Eric McCorkle wrote: >>>>>>> Hello, >>>>>>> >>>>>>> Please review this patch which fixes an issue with shadowing by type >>>>>>> variables. >>>>>>> >>>>>>> Note: despite the very small size of this patch, it makes changes to >>>>>>> the >>>>>>> way that types are resolved in scopes, thus it needs to be >>>>>>> treated with >>>>>>> extreme care. Please review it and the test I have included >>>>>>> carefully. >>>>>>> >>>>>>> The webrev is here: >>>>>>> http://cr.openjdk.java.net/~emc/7118412/webrew.00/ >>>>>>> >>>>>>> The bug can be found here: >>>>>>> http://bugs.sun.com/view_bug.do?bug_id=7118412 >>>>>>> >>>>>>> Thanks, >>>>>>> Eric >>>>>>> >>>>> >>>> -------------- next part -------------- A non-text attachment was scrubbed... Name: eric_mccorkle.vcf Type: text/x-vcard Size: 314 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20130816/2e998a0a/eric_mccorkle.vcf From eric.mccorkle at oracle.com Fri Aug 16 15:05:06 2013 From: eric.mccorkle at oracle.com (Eric McCorkle) Date: Fri, 16 Aug 2013 18:05:06 -0400 Subject: Review request for JDK-7118412: Shadowing of type-variables vs. member types In-Reply-To: <520E84F8.6030406@oracle.com> References: <5189365A.1020005@oracle.com> <5193AAA4.6060608@oracle.com> <519B4DE5.3020706@oracle.com> <519B4E17.8080908@oracle.com> <519B94F1.8020307@oracle.com> <51F04A2A.6070505@oracle.com> <51F0687F.3070001@oracle.com> <520E84F8.6030406@oracle.com> Message-ID: <520EA212.5030108@oracle.com> Crucible appears to have eaten my review :( I've uploaded a new webrev with Alex's changes incorporated, except for renaming MethodContext. It refers to the context (instance vs static) in which a call to T. is made. The method names in MethodCall are deliberately different. I use "iterator", because the class type variable extends Collection, the method names are a way of requiring resolution to have a particular result. I also added comments explaining everything. The webrev is here: http://cr.openjdk.java.net/~emc/7118412/ On 08/16/13 16:00, Eric McCorkle wrote: > (Been gone for 2+ weeks) > > I will incorporate these changes. > > However, I'm also going to give the new Crucible review system a try. > As such, I've uploaded this patch (not yet with Alex's suggested changes). > > However, anyone not on the Crucible system should feel free to > contribute a review. > > On 07/24/13 19:51, Alex Buckley wrote: >> In the test: >> >> - Check @summary :-( >> >> - I wanted to like the nested switch statements in MethodCall.succeeds, >> but found them inscrutable. I think more descriptive names for enum >> constants would help a lot, e.g. INNER_CLASS. And why are type variables >> a.k.a. TYPEVAR so interested in a method called "iterator", can't any >> reference type have a method called "iterator" ? >> >> - Shadowing is not specific to method calls, so I think the succeeds >> logic should be moved to an instance method of ShadowingTest. doTest >> already has to pass three things to call.succeeds, in order for >> MethodCall to work out the answer, so passing 'call' as a fourth >> argument is no big deal. It is a good thing to have single-purpose enums >> to model the language constructs being combined, since the constructs >> are already complicated enough themselves. >> >> - MethodContext suggests some entity apart from a method that provides >> an environment for the method. But in fact, MethodContext represents >> whether the method iself is a class method or instance method. >> MethodKind would be a better name. >> >> - InsideDef would be better called MethodDeclaration. (And "NONE"? None >> what?) TyVar would be better called TypeParameterDeclaration. (> extends ...> is a _type parameter_ declaration, and introduces a _type >> variable_ which may be referred to as T in contexts where reference >> types are used, e.g. the type in a field declaration. Can you tell I've >> been adding annotations on type uses to the JLS recently?) >> >> - main calls run calls doTest, but doTest is declared before run - and >> is private too? Why are some members private and others package-private? >> >> Alex >> >> On 7/24/2013 2:42 PM, Eric McCorkle wrote: >>> This RFR was dormant for a while pending CCC approval, which happened >>> today. Please note that I've made updates since the last reviews. >>> >>> I will be running the JCK test suite, as this affects the core compiler. >>> >>> The updated webrev is here: >>> http://cr.openjdk.java.net/~emc/7118412/webrew.02/ >>> >>> On 05/21/13 11:38, Eric McCorkle wrote: >>>> I hit a couple of corner cases with the regression tests mid last week. >>>> Expect another update sometime in the near future. >>>> >>>> On 05/21/13 06:36, Maurizio Cimadamore wrote: >>>>> On 21/05/13 11:35, Maurizio Cimadamore wrote: >>>>>> Fix looks nice - only bit that seems suspicious is the check for >>>>>> >>>>>> sym == null >>>>>> >>>>>> The symbol could be different than null, but still not be a 'valid' >>>>>> symbol (i.e. because it's an error). Actually, a lookup should never >>>>>> return a null symbol. I suggest you return the 'bestSoFar' (which >>>>>> would be typeNotFound') and then use the useful method Symbol.exists() >>>>>> which should do what you need (check if the symbol is a valid symbol). >>>>>> I think in cases where the found symbol is inaccessible it's important >>>>>> to stop and to log the error, you should not keep going recursively >>>>>> until you find a correct symbol. >>>>> The test also needs some work in order to match the combo test idiom (I >>>>> should have sent you an example of such tests already). >>>>> >>>>> Maurizio >>>>>> >>>>>> Maurizio >>>>>> >>>>>> On 15/05/13 16:32, Eric McCorkle wrote: >>>>>>> I have updated this patch to correct the shadowing of type >>>>>>> variables by >>>>>>> both member and static member class definitions. >>>>>>> >>>>>>> I have also included an improved testing framework that exhaustively >>>>>>> tests the possible combinations. >>>>>>> >>>>>>> Note that a CCC has been filed for this patch, as it changes the way >>>>>>> that type names are resolved in the compiler. >>>>>>> >>>>>>> Please review and comment. >>>>>>> >>>>>>> On 05/07/13 13:14, Eric McCorkle wrote: >>>>>>>> Hello, >>>>>>>> >>>>>>>> Please review this patch which fixes an issue with shadowing by type >>>>>>>> variables. >>>>>>>> >>>>>>>> Note: despite the very small size of this patch, it makes changes to >>>>>>>> the >>>>>>>> way that types are resolved in scopes, thus it needs to be >>>>>>>> treated with >>>>>>>> extreme care. Please review it and the test I have included >>>>>>>> carefully. >>>>>>>> >>>>>>>> The webrev is here: >>>>>>>> http://cr.openjdk.java.net/~emc/7118412/webrew.00/ >>>>>>>> >>>>>>>> The bug can be found here: >>>>>>>> http://bugs.sun.com/view_bug.do?bug_id=7118412 >>>>>>>> >>>>>>>> Thanks, >>>>>>>> Eric >>>>>>>> >>>>>> >>>>> -------------- next part -------------- A non-text attachment was scrubbed... Name: eric_mccorkle.vcf Type: text/x-vcard Size: 314 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20130816/26f21a75/eric_mccorkle.vcf From erik.joelsson at oracle.com Mon Aug 19 00:33:12 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Mon, 19 Aug 2013 09:33:12 +0200 Subject: RFR: 8023146: Sjavac test failes in langtools nightly In-Reply-To: <520E5767.2000908@oracle.com> References: <520DE43A.9040907@oracle.com> <520E5343.7060000@oracle.com> <520E5767.2000908@oracle.com> Message-ID: <5211CA38.6080200@oracle.com> Yes, thanks. Joel also pointed this out to me so it should be correct now. /Erik On 2013-08-16 18:46, Jonathan Gibbons wrote: > Eric, > > My apologies. Your fix is correct. The functionality I was expecting > is in SJavacWrapper.java > > -- Jon > > On 08/16/2013 09:28 AM, Jonathan Gibbons wrote: >> Eric, >> >> Please don't do this. The correct solution is to make sure the test >> passes vacuously when sjavac is not available. >> >> -- Jon >> >> On 08/16/2013 01:35 AM, Erik Joelsson wrote: >>> In JDK-8015145, I converted the test for sjavac into a jtreg test. >>> This proved to be a mistake. Since sjavac isn't being shipped with >>> the product, tests for it can't be included in the regression >>> testsuite as they will not even compile when run against a product >>> build. >>> >>> I propose to remove the jtreg declaration from this test to make it >>> stop failing. This is just reverting what I did in the previous change. >>> >>> http://cr.openjdk.java.net/~erikj/8023146/webrev.langtools.01/ >>> >>> /Erik >> > From joel.franck at oracle.com Mon Aug 19 01:50:28 2013 From: joel.franck at oracle.com (Joel Borggren-Franck) Date: Mon, 19 Aug 2013 10:50:28 +0200 Subject: Missing LineNumberTable entries with JDK8? Message-ID: <20130819085028.GA31919@jfranck-desktop.jrpg.bea.com> Hi Marc, Thanks for the report. Bug id 8023214. Should show up here: http://bugs.sun.com/view_bug.do?bug_id=8023214 cheers /Joel In-Reply-To: <51E3B136.4030800 at mountainminds.com> On 2013-07-15, Marc R. Hoffmann wrote: > Hi, > > I'm currently working on a Java 8 version of the code coverage tool > JaCoCo. This tool relies on line number information within class > files. Some of our integration tests fail with JDK8, probably due to > incomplete line number information. > > STEPS TO REPRODUCE > > Compile the source file attached with the lates JDK8 build > (1.8.0-ea-b97). Compiled class is also attached. > > EXPECTED > > The compiled class files has a LineNumberTable entry for the method > invocation b() in line 10. > > ACTUAL > > There is no separate LineNumberTable entry for the invocation of > b(). So b() appears to be invoked in line 8 instead of 10. See javap > output below. > > The problem seems to be specific to static methods. Line numbers are > reported correctly if method b() is an instance method. > > Best regards, > -marc > > > static void m(boolean); > descriptor: (Z)V > flags: ACC_STATIC > Code: > stack=1, locals=1, args_size=1 > 0: iload_0 > 1: ifeq 10 > 4: invokestatic #2 // Method a:()V > 7: goto 13 > 10: invokestatic #3 // Method b:()V > 13: return > LineNumberTable: > line 7: 0 > line 8: 4 > line 12: 13 > StackMapTable: number_of_entries = 2 > frame_type = 10 /* same */ > frame_type = 2 /* same */ > > /** > * Reproducer for Java 8 compiler issue where wrong line numbers are reported.. > */ > public class Target01 { > > static void m(boolean flag) { > if (flag) { > a(); > } else { > b(); // Wrong line number for this invocation (8 instead of 10) > } > } > > static void a() { > } > > static void b() { > } > > } From jaroslav.bachorik at oracle.com Mon Aug 19 02:05:55 2013 From: jaroslav.bachorik at oracle.com (jaroslav.bachorik at oracle.com) Date: Mon, 19 Aug 2013 09:05:55 +0000 Subject: hg: jdk8/tl/jdk: 4 new changesets Message-ID: <20130819090651.373E34898A@hg.openjdk.java.net> Changeset: 8e098a29ecd8 Author: egahlin Date: 2013-08-16 17:02 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8e098a29ecd8 6417702: Graph in Memory tab is not redrawn immediately if changed via 'Chart' combo box Reviewed-by: alanb, jbachorik, sjiang ! src/share/classes/sun/tools/jconsole/MemoryTab.java Changeset: c67cb9d4d51a Author: egahlin Date: 2013-08-16 17:11 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c67cb9d4d51a 6721425: jconsole Makefile clean rule is missing rm of generated Version.java Reviewed-by: alanb, jbachorik ! make/sun/jconsole/Makefile Changeset: 89ef4bcf7b0e Author: egahlin Date: 2013-08-16 16:53 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/89ef4bcf7b0e 7015157: String "Tabular Navigation" should be rephrased for avoiding mistranslation Reviewed-by: alanb, jbachorik, sjiang ! src/share/classes/sun/tools/jconsole/resources/messages.properties Changeset: 71bad9540825 Author: egahlin Date: 2013-08-16 18:58 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/71bad9540825 6696970: Jconsole becomes unusable if a plugin throws an exception Reviewed-by: mchung, jbachorik + src/share/classes/sun/tools/jconsole/ExceptionSafePlugin.java ! src/share/classes/sun/tools/jconsole/Messages.java ! src/share/classes/sun/tools/jconsole/VMPanel.java ! src/share/classes/sun/tools/jconsole/resources/messages.properties From paul.sandoz at oracle.com Mon Aug 19 01:54:44 2013 From: paul.sandoz at oracle.com (paul.sandoz at oracle.com) Date: Mon, 19 Aug 2013 08:54:44 +0000 Subject: hg: jdk8/tl/jdk: 8022318: Document Spliterator characteristics and binding policy of java util concurrent collection impls Message-ID: <20130819085531.8707F48988@hg.openjdk.java.net> Changeset: 9e9f5713b26d Author: psandoz Date: 2013-08-06 14:26 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9e9f5713b26d 8022318: Document Spliterator characteristics and binding policy of java util concurrent collection impls Reviewed-by: chegar Contributed-by: Martin Buchholz , Paul Sandoz ! src/share/classes/java/util/concurrent/ArrayBlockingQueue.java ! src/share/classes/java/util/concurrent/ConcurrentHashMap.java ! src/share/classes/java/util/concurrent/ConcurrentLinkedDeque.java ! src/share/classes/java/util/concurrent/ConcurrentLinkedQueue.java ! src/share/classes/java/util/concurrent/ConcurrentNavigableMap.java ! src/share/classes/java/util/concurrent/ConcurrentSkipListMap.java ! src/share/classes/java/util/concurrent/ConcurrentSkipListSet.java ! src/share/classes/java/util/concurrent/CopyOnWriteArrayList.java ! src/share/classes/java/util/concurrent/CopyOnWriteArraySet.java ! src/share/classes/java/util/concurrent/DelayQueue.java ! src/share/classes/java/util/concurrent/LinkedBlockingDeque.java ! src/share/classes/java/util/concurrent/LinkedBlockingQueue.java ! src/share/classes/java/util/concurrent/LinkedTransferQueue.java ! src/share/classes/java/util/concurrent/PriorityBlockingQueue.java ! src/share/classes/java/util/concurrent/SynchronousQueue.java ! src/share/classes/java/util/concurrent/package-info.java From vicente.romero at oracle.com Mon Aug 19 02:32:16 2013 From: vicente.romero at oracle.com (Vicente-Arturo Romero-Zaldivar) Date: Mon, 19 Aug 2013 10:32:16 +0100 Subject: Missing LineNumberTable entries with JDK8? In-Reply-To: <20130819085028.GA31919@jfranck-desktop.jrpg.bea.com> References: <20130819085028.GA31919@jfranck-desktop.jrpg.bea.com> Message-ID: <5211E620.8080001@oracle.com> Hi, This bug has already been solved by Jan Lahoda. Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8c4b2987edac original bug id: http://bugs.sun.com/view_bug.do?bug_id=8020689 Thanks, Vicente On 19/08/13 09:50, Joel Borggren-Franck wrote: > Hi Marc, > > Thanks for the report. Bug id 8023214. > > Should show up here: http://bugs.sun.com/view_bug.do?bug_id=8023214 > > cheers > /Joel > > In-Reply-To: <51E3B136.4030800 at mountainminds.com> > > On 2013-07-15, Marc R. Hoffmann wrote: >> Hi, >> >> I'm currently working on a Java 8 version of the code coverage tool >> JaCoCo. This tool relies on line number information within class >> files. Some of our integration tests fail with JDK8, probably due to >> incomplete line number information. >> >> STEPS TO REPRODUCE >> >> Compile the source file attached with the lates JDK8 build >> (1.8.0-ea-b97). Compiled class is also attached. >> >> EXPECTED >> >> The compiled class files has a LineNumberTable entry for the method >> invocation b() in line 10. >> >> ACTUAL >> >> There is no separate LineNumberTable entry for the invocation of >> b(). So b() appears to be invoked in line 8 instead of 10. See javap >> output below. >> >> The problem seems to be specific to static methods. Line numbers are >> reported correctly if method b() is an instance method. >> >> Best regards, >> -marc >> >> >> static void m(boolean); >> descriptor: (Z)V >> flags: ACC_STATIC >> Code: >> stack=1, locals=1, args_size=1 >> 0: iload_0 >> 1: ifeq 10 >> 4: invokestatic #2 // Method a:()V >> 7: goto 13 >> 10: invokestatic #3 // Method b:()V >> 13: return >> LineNumberTable: >> line 7: 0 >> line 8: 4 >> line 12: 13 >> StackMapTable: number_of_entries = 2 >> frame_type = 10 /* same */ >> frame_type = 2 /* same */ >> >> /** >> * Reproducer for Java 8 compiler issue where wrong line numbers are reported.. >> */ >> public class Target01 { >> >> static void m(boolean flag) { >> if (flag) { >> a(); >> } else { >> b(); // Wrong line number for this invocation (8 instead of 10) >> } >> } >> >> static void a() { >> } >> >> static void b() { >> } >> >> } > From chris.hegarty at oracle.com Mon Aug 19 02:45:33 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Mon, 19 Aug 2013 09:45:33 +0000 Subject: hg: jdk8/tl: 8021820: Number of opened files used in select() is limited to 1024 [macosx] Message-ID: <20130819094534.30D3F4898B@hg.openjdk.java.net> Changeset: 00dcfaa6bc01 Author: aefimov Date: 2013-08-16 18:40 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/rev/00dcfaa6bc01 8021820: Number of opened files used in select() is limited to 1024 [macosx] Reviewed-by: alanb, chegar, tbell, smarks ! common/autoconf/generated-configure.sh ! common/autoconf/toolchain.m4 From chris.hegarty at oracle.com Mon Aug 19 02:47:17 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Mon, 19 Aug 2013 09:47:17 +0000 Subject: hg: jdk8/tl/jdk: 8021820: Number of opened files used in select() is limited to 1024 [macosx] Message-ID: <20130819094817.B3DE94898E@hg.openjdk.java.net> Changeset: 11ccaabdb2a8 Author: aefimov Date: 2013-08-16 18:41 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/11ccaabdb2a8 8021820: Number of opened files used in select() is limited to 1024 [macosx] Reviewed-by: alanb, chegar, tbell, smarks + test/java/net/ServerSocket/SelectFdsLimit.java From alan.bateman at oracle.com Mon Aug 19 03:07:04 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Mon, 19 Aug 2013 10:07:04 +0000 Subject: hg: jdk8/tl/jdk: 8023215: test/java/util/Comparator/TypeTest.java not running (failing but reported as passing) Message-ID: <20130819100719.3AF2648991@hg.openjdk.java.net> Changeset: f580728b08b4 Author: alanb Date: 2013-08-19 11:04 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f580728b08b4 8023215: test/java/util/Comparator/TypeTest.java not running (failing but reported as passing) Reviewed-by: psandoz ! test/java/util/Comparator/TypeTest.java From joel.franck at oracle.com Mon Aug 19 03:39:51 2013 From: joel.franck at oracle.com (Joel Borggren-Franck) Date: Mon, 19 Aug 2013 12:39:51 +0200 Subject: Missing LineNumberTable entries with JDK8? In-Reply-To: <5211E620.8080001@oracle.com> References: <20130819085028.GA31919@jfranck-desktop.jrpg.bea.com> <5211E620.8080001@oracle.com> Message-ID: <20130819103951.GC31919@jfranck-desktop.jrpg.bea.com> Great :) On 2013-08-19, Vicente-Arturo Romero-Zaldivar wrote: > Hi, > > This bug has already been solved by Jan Lahoda. > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8c4b2987edac > original bug id: http://bugs.sun.com/view_bug.do?bug_id=8020689 > > Thanks, > Vicente > > On 19/08/13 09:50, Joel Borggren-Franck wrote: > >Hi Marc, > > > >Thanks for the report. Bug id 8023214. > > > >Should show up here: http://bugs.sun.com/view_bug.do?bug_id=8023214 > > > >cheers > >/Joel > > > >In-Reply-To: <51E3B136.4030800 at mountainminds.com> > > > >On 2013-07-15, Marc R. Hoffmann wrote: > >>Hi, > >> > >>I'm currently working on a Java 8 version of the code coverage tool > >>JaCoCo. This tool relies on line number information within class > >>files. Some of our integration tests fail with JDK8, probably due to > >>incomplete line number information. > >> > >>STEPS TO REPRODUCE > >> > >>Compile the source file attached with the lates JDK8 build > >>(1.8.0-ea-b97). Compiled class is also attached. > >> > >>EXPECTED > >> > >>The compiled class files has a LineNumberTable entry for the method > >>invocation b() in line 10. > >> > >>ACTUAL > >> > >>There is no separate LineNumberTable entry for the invocation of > >>b(). So b() appears to be invoked in line 8 instead of 10. See javap > >>output below. > >> > >>The problem seems to be specific to static methods. Line numbers are > >>reported correctly if method b() is an instance method. > >> > >>Best regards, > >>-marc > >> > >> > >> static void m(boolean); > >> descriptor: (Z)V > >> flags: ACC_STATIC > >> Code: > >> stack=1, locals=1, args_size=1 > >> 0: iload_0 > >> 1: ifeq 10 > >> 4: invokestatic #2 // Method a:()V > >> 7: goto 13 > >> 10: invokestatic #3 // Method b:()V > >> 13: return > >> LineNumberTable: > >> line 7: 0 > >> line 8: 4 > >> line 12: 13 > >> StackMapTable: number_of_entries = 2 > >> frame_type = 10 /* same */ > >> frame_type = 2 /* same */ > >> > >>/** > >> * Reproducer for Java 8 compiler issue where wrong line numbers are reported.. > >> */ > >>public class Target01 { > >> > >> static void m(boolean flag) { > >> if (flag) { > >> a(); > >> } else { > >> b(); // Wrong line number for this invocation (8 instead of 10) > >> } > >> } > >> > >> static void a() { > >> } > >> > >> static void b() { > >> } > >> > >>} > > > From paul.sandoz at oracle.com Mon Aug 19 07:15:56 2013 From: paul.sandoz at oracle.com (paul.sandoz at oracle.com) Date: Mon, 19 Aug 2013 14:15:56 +0000 Subject: hg: jdk8/tl/jdk: 8014824: Document Spliterator characteristics and binding policy of java util collection impls Message-ID: <20130819141634.3910A4899C@hg.openjdk.java.net> Changeset: 3647aab7b1d5 Author: psandoz Date: 2013-08-06 14:26 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3647aab7b1d5 8014824: Document Spliterator characteristics and binding policy of java util collection impls Reviewed-by: chegar ! src/share/classes/java/util/ArrayDeque.java ! src/share/classes/java/util/ArrayList.java ! src/share/classes/java/util/HashSet.java ! src/share/classes/java/util/LinkedHashMap.java ! src/share/classes/java/util/LinkedHashSet.java ! src/share/classes/java/util/LinkedList.java ! src/share/classes/java/util/List.java ! src/share/classes/java/util/PriorityQueue.java ! src/share/classes/java/util/Set.java ! src/share/classes/java/util/SortedSet.java ! src/share/classes/java/util/Spliterator.java ! src/share/classes/java/util/TreeMap.java ! src/share/classes/java/util/TreeSet.java ! src/share/classes/java/util/Vector.java From sundararajan.athijegannathan at oracle.com Mon Aug 19 07:48:58 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Mon, 19 Aug 2013 14:48:58 +0000 Subject: hg: jdk8/tl/nashorn: 7 new changesets Message-ID: <20130819144905.7CC544899E@hg.openjdk.java.net> Changeset: bbc4e9d37315 Author: jlaskey Date: 2013-08-12 18:00 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/bbc4e9d37315 8022676: Confusing error message checking instanceof non-class Reviewed-by: jlaskey, sundar Contributed-by: michael.horowitz at oracle.com ! src/jdk/nashorn/internal/runtime/resources/Messages.properties Changeset: ba507ac08719 Author: sundar Date: 2013-08-14 20:51 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/ba507ac08719 8023026: Array.prototype iterator functions like forEach, reduce should work for Java arrays, lists Reviewed-by: jlaskey, lagergren - src/jdk/nashorn/internal/runtime/arrays/ArrayIterator.java ! src/jdk/nashorn/internal/runtime/arrays/ArrayLikeIterator.java + src/jdk/nashorn/internal/runtime/arrays/JavaArrayIterator.java + src/jdk/nashorn/internal/runtime/arrays/JavaListIterator.java - src/jdk/nashorn/internal/runtime/arrays/MapIterator.java - src/jdk/nashorn/internal/runtime/arrays/ReverseArrayIterator.java + src/jdk/nashorn/internal/runtime/arrays/ReverseJavaArrayIterator.java + src/jdk/nashorn/internal/runtime/arrays/ReverseJavaListIterator.java - src/jdk/nashorn/internal/runtime/arrays/ReverseMapIterator.java + src/jdk/nashorn/internal/runtime/arrays/ReverseScriptArrayIterator.java + src/jdk/nashorn/internal/runtime/arrays/ReverseScriptObjectIterator.java + src/jdk/nashorn/internal/runtime/arrays/ScriptArrayIterator.java + src/jdk/nashorn/internal/runtime/arrays/ScriptObjectIterator.java + test/script/basic/JDK-8023026.js + test/script/basic/JDK-8023026.js.EXPECTED Changeset: 09c99b58b81e Author: sundar Date: 2013-08-16 15:04 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/09c99b58b81e 8020355: bind on built-in constructors don't use bound argument values Reviewed-by: lagergren, hannesw ! src/jdk/nashorn/internal/runtime/ScriptFunctionData.java + test/script/basic/JDK-8020355.js Changeset: 1d29d2e27590 Author: hannesw Date: 2013-08-16 13:42 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/1d29d2e27590 8019985: Date.parse("2000-01-01T00:00:00.Z") should return NaN Reviewed-by: sundar, jlaskey ! src/jdk/nashorn/internal/parser/DateParser.java + test/script/basic/JDK-8019985.js Changeset: 36fb36217e1d Author: lagergren Date: 2013-08-16 18:51 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/36fb36217e1d 8023017: SUB missing for widest op == number for BinaryNode Reviewed-by: sundar, jlaskey ! src/jdk/nashorn/internal/codegen/ObjectClassGenerator.java ! src/jdk/nashorn/internal/codegen/ObjectCreator.java ! src/jdk/nashorn/internal/ir/BinaryNode.java ! src/jdk/nashorn/internal/ir/BreakableNode.java ! src/jdk/nashorn/internal/ir/IdentNode.java ! src/jdk/nashorn/internal/ir/LexicalContextNode.java ! src/jdk/nashorn/internal/objects/NativeArguments.java ! src/jdk/nashorn/internal/objects/NativeArray.java ! src/jdk/nashorn/internal/parser/Parser.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/RecompilableScriptFunctionData.java ! src/jdk/nashorn/internal/runtime/ScriptFunction.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/arrays/ArrayLikeIterator.java ! src/jdk/nashorn/internal/runtime/arrays/LongArrayData.java ! src/jdk/nashorn/internal/runtime/arrays/SparseArrayData.java ! src/jdk/nashorn/internal/runtime/linker/BoundDynamicMethod.java ! src/jdk/nashorn/internal/runtime/linker/BoundDynamicMethodLinker.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterClassLoader.java Changeset: bd0174b1a42f Author: sundar Date: 2013-08-19 17:16 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/bd0174b1a42f 8023210: jjs tools should support a mode where it will load few command line scripts and then entering into interactive shell Reviewed-by: hannesw, attila, lagergren, jlaskey ! src/jdk/nashorn/internal/runtime/options/Options.java ! src/jdk/nashorn/tools/Shell.java Changeset: e628aefac504 Author: sundar Date: 2013-08-19 19:37 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/e628aefac504 Merge - src/jdk/nashorn/internal/runtime/arrays/ArrayIterator.java - src/jdk/nashorn/internal/runtime/arrays/MapIterator.java - src/jdk/nashorn/internal/runtime/arrays/ReverseArrayIterator.java - src/jdk/nashorn/internal/runtime/arrays/ReverseMapIterator.java From kumar.x.srinivasan at oracle.com Mon Aug 19 09:42:45 2013 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Mon, 19 Aug 2013 16:42:45 +0000 Subject: hg: jdk8/tl/langtools: 7071377: Exception when javac -processor is given a class name with invalid postfix Message-ID: <20130819164255.72E15489A4@hg.openjdk.java.net> Changeset: 389eaf6ed973 Author: ksrini Date: 2013-08-19 07:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/389eaf6ed973 7071377: Exception when javac -processor is given a class name with invalid postfix Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/comp/Attr.java + test/tools/javac/processing/errors/TestClassNames.java From sean.mullan at oracle.com Mon Aug 19 12:13:44 2013 From: sean.mullan at oracle.com (sean.mullan at oracle.com) Date: Mon, 19 Aug 2013 19:13:44 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20130819191422.3915D489A7@hg.openjdk.java.net> Changeset: bce5205dbe84 Author: ascarpino Date: 2013-08-14 10:50 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bce5205dbe84 8022669: OAEPParameterSpec does not work if MGF1ParameterSpec is set to SHA2 algorithms Reviewed-by: mullan ! src/share/classes/sun/security/rsa/RSAPadding.java ! test/com/sun/crypto/provider/Cipher/RSA/TestOAEPPadding.java Changeset: b40d246d4d81 Author: ascarpino Date: 2013-08-16 12:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b40d246d4d81 8022896: test/com/sun/crypto/provider/Cipher/RSA/TestOAEPPadding.java fails Reviewed-by: mullan ! test/ProblemList.txt From jeremymanson at google.com Mon Aug 19 12:49:45 2013 From: jeremymanson at google.com (Jeremy Manson) Date: Mon, 19 Aug 2013 12:49:45 -0700 Subject: javac generates unverifiable initializer for nested subclass of local class. In-Reply-To: <520DF2E2.8050805@oracle.com> References: <520DF2E2.8050805@oracle.com> Message-ID: Thanks! Jeremy On Fri, Aug 16, 2013 at 2:37 AM, Vicente-Arturo Romero-Zaldivar < vicente.romero at oracle.com> wrote: > Hi Jeremy, > > This bug has been fixed: > http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a6378c19836b > > Thanks for your report, > > > Vicente > > On 01/08/13 07:36, Jeremy Manson wrote: > > Hi folks, > > I mentioned to a couple of people on the list that we have a some > unreported bugs. In an effort to be better about reporting them, I'll > mention this oldie but goodie that dates back to JDK 6 update 4. > > (I have to verify that each of them is still a bug, so this might be a > trickle rather than a flood) > > public class TestTest { > public static void main(final String args[]) { > class NamedLocal { > Object m() { > return args; > } > > class NamedLocalSub extends NamedLocal {} > } > new NamedLocal().new NamedLocalSub(); > } > } > > With JDK8 b84: > > $ javac TestTest.java > $ java TestTest > Exception in thread "main" java.lang.VerifyError: Bad type on operand stack > Exception Details: > Location: > TestTest$1NamedLocal$NamedLocalSub.(LTestTest$1NamedLocal;)V @7: > getfield > Reason: > Type uninitializedThis (current frame, stack[1]) is not assignable to > 'TestTest$1NamedLocal$NamedLocalSub' > Current Frame: > bci: @7 > flags: { flagThisUninit } > locals: { uninitializedThis, 'TestTest$1NamedLocal' } > stack: { uninitializedThis, uninitializedThis } > Bytecode: > 0000000: 2a2b b500 012a 2ab4 0002 b700 03b1 > > at TestTest.main(TestTest.java:10) > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20130819/a916808d/attachment.html From jeremymanson at google.com Mon Aug 19 12:52:29 2013 From: jeremymanson at google.com (Jeremy Manson) Date: Mon, 19 Aug 2013 12:52:29 -0700 Subject: Unclear error message when class has same name as package In-Reply-To: <520AB3EF.50103@oracle.com> References: <5209FCF8.6020303@oracle.com> <520AB3EF.50103@oracle.com> Message-ID: Okay, thanks for the attention, Jon. I didn't feel too strongly about it; it was just that a user had mentioned it, and it did seem less than ideal from a usability POV. Jeremy On Tue, Aug 13, 2013 at 3:32 PM, Jonathan Gibbons < jonathan.gibbons at oracle.com> wrote: > Jeremy, > > To be realistic, I do not know what we can do about this issue. It is > legal to have a class and a package with the same name, which means that in > a sufficiently perverse case, and the following import > > import A.B.C.D.E; > > the problem could occur at any point along the qualified name, where the > compiler chooses a type name contrary to the erroneous expectation of the > programmer. See JLS 6.5.4. > > So, as much as it would be nice to be able to warn the programmer of > problematic coding, this error message is not the place to do it. The > compiler already tries to give you enough detail by point out (in your > case) that it is trying to find "class E" within "class D". That should > surely be enough to have you realize that the compiler is looking at "class > D" and not "package D". > > -- Jon > > > > On 08/13/2013 12:36 PM, Jeremy Manson wrote: > > Thanks! > > Jeremy > > > On Tue, Aug 13, 2013 at 2:31 AM, Vicente-Arturo Romero-Zaldivar < > vicente.romero at oracle.com> wrote: > >> Hi Jeremy, >> >> Thanks for the report I have created a bug entry with id JDK-8022873 to >> track this issue, >> >> Vicente >> >> >> On 10/08/13 23:10, Jeremy Manson wrote: >> >>> Hi folks, >>> >>> One of our users said that he spent a day trying to figure out where how >>> this error happened (lots of autogenerated code made it all rather opaque), >>> so I'm reporting it. >>> >>> $ cat C.java >>> import p.D.E; >>> >>> public class C { >>> } >>> $ cat p/D.java >>> package p; >>> public class D { >>> } >>> $ cat p/D/E.java >>> package p.D; >>> >>> public class E { >>> } >>> $ javac C.java >>> C.java:1: error: cannot find symbol >>> import p.D.E; >>> ^ >>> symbol: class E >>> location: class D >>> 1 error >>> >>> >>> The reporter suggested that the error "cannot find symbol" would be >>> better as something like "package D clashes with class of same name". >>> >>> Jeremy >>> >> >> > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20130819/65519e7b/attachment.html From jonathan.gibbons at oracle.com Mon Aug 19 13:31:38 2013 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Mon, 19 Aug 2013 13:31:38 -0700 Subject: Unclear error message when class has same name as package In-Reply-To: References: <5209FCF8.6020303@oracle.com> <520AB3EF.50103@oracle.com> Message-ID: <521280AA.1080602@oracle.com> Usability is always a good reason to revisit diagnostics. We have put work over the last couple of releases to make diagnostics clearer, at the cost of making them longer. One area where I think we could wish for more support is better display of diagnostics in an IDE, such as linking to symbols, using rich text and so on. Also in this bucket is the general concept of a possible "More Info..." link. Back on this specific message, although I don't see any obvious easy improvement, it does seem like we could/should have a lint option for clashing names -- for example package and class name clash (this case) or any name clash that might be a problem on systems with case-equivalent file-systems, or name clashes on systems with reserved names (CON, COMn, LPTn come to mind.) -- Jon On 08/19/2013 12:52 PM, Jeremy Manson wrote: > Okay, thanks for the attention, Jon. I didn't feel too strongly about > it; it was just that a user had mentioned it, and it did seem less > than ideal from a usability POV. > > Jeremy > > > On Tue, Aug 13, 2013 at 3:32 PM, Jonathan Gibbons > > wrote: > > Jeremy, > > To be realistic, I do not know what we can do about this issue. > It is legal to have a class and a package with the same name, > which means that in a sufficiently perverse case, and the > following import > > import A.B.C.D.E; > > the problem could occur at any point along the qualified name, > where the compiler chooses a type name contrary to the erroneous > expectation of the programmer. See JLS 6.5.4. > > So, as much as it would be nice to be able to warn the programmer > of problematic coding, this error message is not the place to do > it. The compiler already tries to give you enough detail by > point out (in your case) that it is trying to find "class E" > within "class D". That should surely be enough to have you > realize that the compiler is looking at "class D" and not "package D". > > -- Jon > > > > On 08/13/2013 12:36 PM, Jeremy Manson wrote: >> Thanks! >> >> Jeremy >> >> >> On Tue, Aug 13, 2013 at 2:31 AM, Vicente-Arturo Romero-Zaldivar >> > wrote: >> >> Hi Jeremy, >> >> Thanks for the report I have created a bug entry with id >> JDK-8022873 to track this issue, >> >> Vicente >> >> >> On 10/08/13 23:10, Jeremy Manson wrote: >> >> Hi folks, >> >> One of our users said that he spent a day trying to >> figure out where how this error happened (lots of >> autogenerated code made it all rather opaque), so I'm >> reporting it. >> >> $ cat C.java >> import p.D.E; >> >> public class C { >> } >> $ cat p/D.java >> package p; >> public class D { >> } >> $ cat p/D/E.java >> package p.D; >> >> public class E { >> } >> $ javac C.java >> C.java:1: error: cannot find symbol >> import p.D.E; >> ^ >> symbol: class E >> location: class D >> 1 error >> >> >> The reporter suggested that the error "cannot find >> symbol" would be better as something like "package D >> clashes with class of same name". >> >> Jeremy >> >> >> > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20130819/2159df9e/attachment-0001.html From dan.xu at oracle.com Mon Aug 19 12:39:13 2013 From: dan.xu at oracle.com (dan.xu at oracle.com) Date: Mon, 19 Aug 2013 19:39:13 +0000 Subject: hg: jdk8/tl/jdk: 8023203: Wrap RandomAccessFile.seek native method into a Java helper method Message-ID: <20130819193934.17B0D489B2@hg.openjdk.java.net> Changeset: 2fd841fccb2e Author: dxu Date: 2013-08-19 12:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2fd841fccb2e 8023203: Wrap RandomAccessFile.seek native method into a Java helper method Reviewed-by: alanb, chegar ! make/java/java/mapfile-vers ! makefiles/mapfiles/libjava/mapfile-vers ! src/share/classes/java/io/RandomAccessFile.java ! src/share/native/java/io/RandomAccessFile.c From sean.mullan at oracle.com Mon Aug 19 14:19:17 2013 From: sean.mullan at oracle.com (sean.mullan at oracle.com) Date: Mon, 19 Aug 2013 21:19:17 +0000 Subject: hg: jdk8/tl/jdk: 8016850: JCK javax.security.auth.Policy tests fail when run in Profiles mode Message-ID: <20130819211951.B52AD489C1@hg.openjdk.java.net> Changeset: f120e2c4b4b1 Author: mullan Date: 2013-08-19 17:17 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f120e2c4b4b1 8016850: JCK javax.security.auth.Policy tests fail when run in Profiles mode Summary: Move default javax.security.auth.Policy implementation to compact1 profile Reviewed-by: vinnie ! src/share/classes/com/sun/security/auth/PolicyFile.java - src/share/classes/com/sun/security/auth/PolicyParser.java - src/share/classes/com/sun/security/auth/SubjectCodeSource.java ! src/share/classes/javax/security/auth/Policy.java + src/share/classes/sun/security/provider/AuthPolicyFile.java + src/share/classes/sun/security/provider/SubjectCodeSource.java From eric.mccorkle at oracle.com Mon Aug 19 16:31:00 2013 From: eric.mccorkle at oracle.com (Eric McCorkle) Date: Mon, 19 Aug 2013 19:31:00 -0400 Subject: Review request for JDK-8020745: Suspicious MethodParameters attribute generated for local classes capturing local variables Message-ID: <5212AAB4.8060700@oracle.com> Hello, Please review this patch, which causes captured locals to be added to the end of a MethodParameters attribute, like they should. The webrev is here: http://cr.openjdk.java.net/~emc/8020745/ The bug report is here: http://bugs.sun.com/view_bug.do?bug_id=8020745 This review is also on the new Crucible system. Thanks, Eric -------------- next part -------------- A non-text attachment was scrubbed... Name: eric_mccorkle.vcf Type: text/x-vcard Size: 303 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20130819/a802d24e/eric_mccorkle.vcf From alex.buckley at oracle.com Mon Aug 19 17:28:34 2013 From: alex.buckley at oracle.com (Alex Buckley) Date: Mon, 19 Aug 2013 17:28:34 -0700 Subject: Review request for JDK-8020745: Suspicious MethodParameters attribute generated for local classes capturing local variables In-Reply-To: <5212AAB4.8060700@oracle.com> References: <5212AAB4.8060700@oracle.com> Message-ID: <5212B832.6040508@oracle.com> The AnonymousParameters.java test is very confusing. Two classes with main methods in the same compilation unit?! Bug 8020745 indicates a mismatch between parameter names and types, but this test only checks names. Rather than relying on the order of names from the JVM to match the 'names' array, you should match up names and types explicitly. List is a bad name for a helper class, and the @summary is not very helpful. Most importantly, there are no anonymous classes here - List is a local class. The test should have an anonymous class too - in fact, an anonymous class whose superclass is not inner and an anonymous class whose superclass is inner. (See the notes in 8misc.pdf 2.2 8.8.9 for why that matters.) Alex On 8/19/2013 4:31 PM, Eric McCorkle wrote: > Hello, > > Please review this patch, which causes captured locals to be added to > the end of a MethodParameters attribute, like they should. > > The webrev is here: > http://cr.openjdk.java.net/~emc/8020745/ > > The bug report is here: > http://bugs.sun.com/view_bug.do?bug_id=8020745 > > This review is also on the new Crucible system. > > Thanks, > Eric > From xuelei.fan at oracle.com Mon Aug 19 17:43:43 2013 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Tue, 20 Aug 2013 00:43:43 +0000 Subject: hg: jdk8/tl/jdk: 8020842: IDN do not throw IAE when hostname ends with a trailing dot Message-ID: <20130820004420.A5A84489CB@hg.openjdk.java.net> Changeset: 096e7c665857 Author: xuelei Date: 2013-08-19 17:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/096e7c665857 8020842: IDN do not throw IAE when hostname ends with a trailing dot Reviewed-by: weijun, michaelm ! src/share/classes/java/net/IDN.java + test/java/net/IDN/IllegalArg.java + test/sun/security/ssl/javax/net/ssl/ServerName/IllegalSNIName.java From xuelei.fan at oracle.com Mon Aug 19 18:51:26 2013 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Tue, 20 Aug 2013 01:51:26 +0000 Subject: hg: jdk8/tl/jdk: 8023230: The impl of KerberosClientKeyExchange maybe not exist Message-ID: <20130820015148.C0D5F489CE@hg.openjdk.java.net> Changeset: 21a25911f7f7 Author: xuelei Date: 2013-08-19 18:49 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/21a25911f7f7 8023230: The impl of KerberosClientKeyExchange maybe not exist Reviewed-by: weijun ! src/share/classes/sun/security/ssl/KerberosClientKeyExchange.java From staffan.larsen at oracle.com Mon Aug 19 23:59:36 2013 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Tue, 20 Aug 2013 06:59:36 +0000 Subject: hg: jdk8/tl/jdk: 8022071: Some vm/jvmti tests fail because cannot attach to the Java virtual machine Message-ID: <20130820070010.F0E36489D2@hg.openjdk.java.net> Changeset: 53ea4b5cef9b Author: sla Date: 2013-08-20 08:59 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/53ea4b5cef9b 8022071: Some vm/jvmti tests fail because cannot attach to the Java virtual machine Reviewed-by: erikj, sspitsyn ! makefiles/CompileNativeLibraries.gmk + makefiles/mapfiles/libattach/reorder-windows-x86 + makefiles/mapfiles/libattach/reorder-windows-x86_64 ! src/windows/native/sun/tools/attach/WindowsVirtualMachine.c From david.holmes at oracle.com Tue Aug 20 00:19:32 2013 From: david.holmes at oracle.com (david.holmes at oracle.com) Date: Tue, 20 Aug 2013 07:19:32 +0000 Subject: hg: jdk8/tl/jdk: 8023311: Clean up profile-includes.txt Message-ID: <20130820071955.810B7489D5@hg.openjdk.java.net> Changeset: e17da8b09f5e Author: dholmes Date: 2013-08-20 03:18 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e17da8b09f5e 8023311: Clean up profile-includes.txt Reviewed-by: alanb ! makefiles/profile-includes.txt From alexander.zuev at oracle.com Tue Aug 20 06:36:52 2013 From: alexander.zuev at oracle.com (alexander.zuev at oracle.com) Date: Tue, 20 Aug 2013 13:36:52 +0000 Subject: hg: jdk8/tl/langtools: 7182350: Regression in wording of unchecked warning message Message-ID: <20130820133656.57107489E0@hg.openjdk.java.net> Changeset: 55da6b3a6940 Author: kizune Date: 2013-08-20 17:34 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/55da6b3a6940 7182350: Regression in wording of unchecked warning message Reviewed-by: mcimadamore, jjg ! src/share/classes/com/sun/tools/javac/comp/Check.java ! test/tools/javac/6758789/T6758789b.out + test/tools/javac/7182350/T7182350.java + test/tools/javac/7182350/T7182350.out ! test/tools/javac/generics/7015430/T7015430_1.out ! test/tools/javac/generics/7015430/T7015430_2.out ! test/tools/javac/generics/7151802/T7151802.out ! test/tools/javac/generics/inference/6718364/T6718364.out ! test/tools/javac/generics/inference/7177306/T7177306a.out From eric.mccorkle at oracle.com Tue Aug 20 07:55:10 2013 From: eric.mccorkle at oracle.com (Eric McCorkle) Date: Tue, 20 Aug 2013 10:55:10 -0400 Subject: Review request for JDK-8020745: Suspicious MethodParameters attribute generated for local classes capturing local variables In-Reply-To: <5212B832.6040508@oracle.com> References: <5212AAB4.8060700@oracle.com> <5212B832.6040508@oracle.com> Message-ID: <5213834E.4000701@oracle.com> Good suggestions, I'll write a more general test and move it into the general MethodParameters test directory. On 08/19/13 20:28, Alex Buckley wrote: > The AnonymousParameters.java test is very confusing. Two classes with > main methods in the same compilation unit?! > > Bug 8020745 indicates a mismatch between parameter names and types, but > this test only checks names. Rather than relying on the order of names > from the JVM to match the 'names' array, you should match up names and > types explicitly. > > List is a bad name for a helper class, and the @summary is not very > helpful. > > Most importantly, there are no anonymous classes here - List is a local > class. The test should have an anonymous class too - in fact, an > anonymous class whose superclass is not inner and an anonymous class > whose superclass is inner. (See the notes in 8misc.pdf 2.2 8.8.9 for why > that matters.) > > Alex > > On 8/19/2013 4:31 PM, Eric McCorkle wrote: >> Hello, >> >> Please review this patch, which causes captured locals to be added to >> the end of a MethodParameters attribute, like they should. >> >> The webrev is here: >> http://cr.openjdk.java.net/~emc/8020745/ >> >> The bug report is here: >> http://bugs.sun.com/view_bug.do?bug_id=8020745 >> >> This review is also on the new Crucible system. >> >> Thanks, >> Eric >> -------------- next part -------------- A non-text attachment was scrubbed... Name: eric_mccorkle.vcf Type: text/x-vcard Size: 314 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20130820/b3da2881/eric_mccorkle.vcf From eric.mccorkle at oracle.com Tue Aug 20 07:55:39 2013 From: eric.mccorkle at oracle.com (Eric McCorkle) Date: Tue, 20 Aug 2013 10:55:39 -0400 Subject: Review request for JDK-7118412: Shadowing of type-variables vs. member types In-Reply-To: <520EA212.5030108@oracle.com> References: <5189365A.1020005@oracle.com> <5193AAA4.6060608@oracle.com> <519B4DE5.3020706@oracle.com> <519B4E17.8080908@oracle.com> <519B94F1.8020307@oracle.com> <51F04A2A.6070505@oracle.com> <51F0687F.3070001@oracle.com> <520E84F8.6030406@oracle.com> <520EA212.5030108@oracle.com> Message-ID: <5213836B.8010602@oracle.com> Are there any more comments on this one, or is it good to go? On 08/16/13 18:05, Eric McCorkle wrote: > Crucible appears to have eaten my review :( > > I've uploaded a new webrev with Alex's changes incorporated, except for > renaming MethodContext. It refers to the context (instance vs static) > in which a call to T. is made. > > The method names in MethodCall are deliberately different. I use > "iterator", because the class type variable extends Collection, the > method names are a way of requiring resolution to have a particular result. > > I also added comments explaining everything. > > The webrev is here: > http://cr.openjdk.java.net/~emc/7118412/ > > On 08/16/13 16:00, Eric McCorkle wrote: >> (Been gone for 2+ weeks) >> >> I will incorporate these changes. >> >> However, I'm also going to give the new Crucible review system a try. >> As such, I've uploaded this patch (not yet with Alex's suggested changes). >> >> However, anyone not on the Crucible system should feel free to >> contribute a review. >> >> On 07/24/13 19:51, Alex Buckley wrote: >>> In the test: >>> >>> - Check @summary :-( >>> >>> - I wanted to like the nested switch statements in MethodCall.succeeds, >>> but found them inscrutable. I think more descriptive names for enum >>> constants would help a lot, e.g. INNER_CLASS. And why are type variables >>> a.k.a. TYPEVAR so interested in a method called "iterator", can't any >>> reference type have a method called "iterator" ? >>> >>> - Shadowing is not specific to method calls, so I think the succeeds >>> logic should be moved to an instance method of ShadowingTest. doTest >>> already has to pass three things to call.succeeds, in order for >>> MethodCall to work out the answer, so passing 'call' as a fourth >>> argument is no big deal. It is a good thing to have single-purpose enums >>> to model the language constructs being combined, since the constructs >>> are already complicated enough themselves. >>> >>> - MethodContext suggests some entity apart from a method that provides >>> an environment for the method. But in fact, MethodContext represents >>> whether the method iself is a class method or instance method. >>> MethodKind would be a better name. >>> >>> - InsideDef would be better called MethodDeclaration. (And "NONE"? None >>> what?) TyVar would be better called TypeParameterDeclaration. (>> extends ...> is a _type parameter_ declaration, and introduces a _type >>> variable_ which may be referred to as T in contexts where reference >>> types are used, e.g. the type in a field declaration. Can you tell I've >>> been adding annotations on type uses to the JLS recently?) >>> >>> - main calls run calls doTest, but doTest is declared before run - and >>> is private too? Why are some members private and others package-private? >>> >>> Alex >>> >>> On 7/24/2013 2:42 PM, Eric McCorkle wrote: >>>> This RFR was dormant for a while pending CCC approval, which happened >>>> today. Please note that I've made updates since the last reviews. >>>> >>>> I will be running the JCK test suite, as this affects the core compiler. >>>> >>>> The updated webrev is here: >>>> http://cr.openjdk.java.net/~emc/7118412/webrew.02/ >>>> >>>> On 05/21/13 11:38, Eric McCorkle wrote: >>>>> I hit a couple of corner cases with the regression tests mid last week. >>>>> Expect another update sometime in the near future. >>>>> >>>>> On 05/21/13 06:36, Maurizio Cimadamore wrote: >>>>>> On 21/05/13 11:35, Maurizio Cimadamore wrote: >>>>>>> Fix looks nice - only bit that seems suspicious is the check for >>>>>>> >>>>>>> sym == null >>>>>>> >>>>>>> The symbol could be different than null, but still not be a 'valid' >>>>>>> symbol (i.e. because it's an error). Actually, a lookup should never >>>>>>> return a null symbol. I suggest you return the 'bestSoFar' (which >>>>>>> would be typeNotFound') and then use the useful method Symbol.exists() >>>>>>> which should do what you need (check if the symbol is a valid symbol). >>>>>>> I think in cases where the found symbol is inaccessible it's important >>>>>>> to stop and to log the error, you should not keep going recursively >>>>>>> until you find a correct symbol. >>>>>> The test also needs some work in order to match the combo test idiom (I >>>>>> should have sent you an example of such tests already). >>>>>> >>>>>> Maurizio >>>>>>> >>>>>>> Maurizio >>>>>>> >>>>>>> On 15/05/13 16:32, Eric McCorkle wrote: >>>>>>>> I have updated this patch to correct the shadowing of type >>>>>>>> variables by >>>>>>>> both member and static member class definitions. >>>>>>>> >>>>>>>> I have also included an improved testing framework that exhaustively >>>>>>>> tests the possible combinations. >>>>>>>> >>>>>>>> Note that a CCC has been filed for this patch, as it changes the way >>>>>>>> that type names are resolved in the compiler. >>>>>>>> >>>>>>>> Please review and comment. >>>>>>>> >>>>>>>> On 05/07/13 13:14, Eric McCorkle wrote: >>>>>>>>> Hello, >>>>>>>>> >>>>>>>>> Please review this patch which fixes an issue with shadowing by type >>>>>>>>> variables. >>>>>>>>> >>>>>>>>> Note: despite the very small size of this patch, it makes changes to >>>>>>>>> the >>>>>>>>> way that types are resolved in scopes, thus it needs to be >>>>>>>>> treated with >>>>>>>>> extreme care. Please review it and the test I have included >>>>>>>>> carefully. >>>>>>>>> >>>>>>>>> The webrev is here: >>>>>>>>> http://cr.openjdk.java.net/~emc/7118412/webrew.00/ >>>>>>>>> >>>>>>>>> The bug can be found here: >>>>>>>>> http://bugs.sun.com/view_bug.do?bug_id=7118412 >>>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> Eric >>>>>>>>> >>>>>>> >>>>>> -------------- next part -------------- A non-text attachment was scrubbed... Name: eric_mccorkle.vcf Type: text/x-vcard Size: 314 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20130820/1b058d4e/eric_mccorkle-0001.vcf From staffan.larsen at oracle.com Tue Aug 20 07:56:12 2013 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Tue, 20 Aug 2013 14:56:12 +0000 Subject: hg: jdk8/tl/jdk: 8016727: test/com/sun/jdi/sde/TemperatureTableTest.java failing intermittently Message-ID: <20130820145635.5C28E489E3@hg.openjdk.java.net> Changeset: 961cdea684b5 Author: sla Date: 2013-08-20 16:53 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/961cdea684b5 8016727: test/com/sun/jdi/sde/TemperatureTableTest.java failing intermittently Reviewed-by: alanb ! test/com/sun/jdi/sde/TemperatureTableTest.java From joel.franck at oracle.com Tue Aug 20 08:27:15 2013 From: joel.franck at oracle.com (joel.franck at oracle.com) Date: Tue, 20 Aug 2013 15:27:15 +0000 Subject: hg: jdk8/tl/langtools: 8019243: AnnotationTypeMismatchException instead of MirroredTypeException Message-ID: <20130820152718.E9171489E6@hg.openjdk.java.net> Changeset: e811fb09a1dc Author: jfranck Date: 2013-08-20 17:21 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e811fb09a1dc 8019243: AnnotationTypeMismatchException instead of MirroredTypeException Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Attribute.java ! src/share/classes/com/sun/tools/javac/comp/Annotate.java ! src/share/classes/com/sun/tools/javac/model/AnnotationProxyMaker.java + test/tools/javac/processing/errors/EnsureMirroredTypeException/Processor.java + test/tools/javac/processing/errors/EnsureMirroredTypeException/Source.java + test/tools/javac/processing/errors/EnsureMirroredTypeException/Source.out From paul.sandoz at oracle.com Tue Aug 20 09:47:20 2013 From: paul.sandoz at oracle.com (paul.sandoz at oracle.com) Date: Tue, 20 Aug 2013 16:47:20 +0000 Subject: hg: jdk8/tl/jdk: 8023367: Collections.emptyList().sort((Comparator)null) throws NPE Message-ID: <20130820164747.1CD50489ED@hg.openjdk.java.net> Changeset: c17d6543b30f Author: psandoz Date: 2013-08-20 17:36 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c17d6543b30f 8023367: Collections.emptyList().sort((Comparator)null) throws NPE Reviewed-by: alanb, mduigou ! src/share/classes/java/util/Collections.java ! test/java/util/Collection/ListDefaults.java From staffan.larsen at oracle.com Tue Aug 20 10:07:41 2013 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Tue, 20 Aug 2013 17:07:41 +0000 Subject: hg: jdk8/tl/jdk: 8023250: Update JavaScript code in JDK for changes in iteration over Java arrays Message-ID: <20130820170753.D7C43489F1@hg.openjdk.java.net> Changeset: 1ccc7bbee0bb Author: attila Date: 2013-08-20 11:15 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1ccc7bbee0bb 8023250: Update JavaScript code in JDK for changes in iteration over Java arrays Reviewed-by: sundar, sla ! src/share/classes/com/sun/tools/hat/resources/hat.js From joe.darcy at oracle.com Tue Aug 20 12:16:27 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Tue, 20 Aug 2013 19:16:27 +0000 Subject: hg: jdk8/tl/langtools: 8011043: Warn about use of 1.5 and earlier source and target values Message-ID: <20130820191632.B7F59489F6@hg.openjdk.java.net> Changeset: 58da1296c6b3 Author: darcy Date: 2013-08-20 12:15 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/58da1296c6b3 8011043: Warn about use of 1.5 and earlier source and target values Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javadoc/Start.java + test/tools/javac/diags/examples/ObsoleteSourceAndTarget.java From jonathan.gibbons at oracle.com Tue Aug 20 14:48:34 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 20 Aug 2013 21:48:34 +0000 Subject: hg: jdk8/tl/langtools: 8020663: Restructure some properties to facilitate better translation Message-ID: <20130820214837.9671E48A07@hg.openjdk.java.net> Changeset: a76dc1b4c299 Author: jjg Date: 2013-08-20 14:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a76dc1b4c299 8020663: Restructure some properties to facilitate better translation Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/doclets.properties ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Util.java From kumar.x.srinivasan at oracle.com Tue Aug 20 14:18:34 2013 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Tue, 20 Aug 2013 21:18:34 +0000 Subject: hg: jdk8/tl/langtools: 7179455: tools/javac/processing/model/testgetallmembers/Main.java fails against JDK 7 and JDK 8 Message-ID: <20130820211839.BB48A48A01@hg.openjdk.java.net> Changeset: 0f88e3d3d250 Author: ksrini Date: 2013-08-20 14:15 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0f88e3d3d250 7179455: tools/javac/processing/model/testgetallmembers/Main.java fails against JDK 7 and JDK 8 Reviewed-by: jjg ! test/tools/javac/processing/model/testgetallmembers/Main.java From jonathan.gibbons at oracle.com Tue Aug 20 14:55:32 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 20 Aug 2013 21:55:32 +0000 Subject: hg: jdk8/tl/langtools: 8022080: javadoc generates invalid HTML in Turkish locale Message-ID: <20130820215535.36BC748A08@hg.openjdk.java.net> Changeset: 79e341614c50 Author: jjg Date: 2013-08-20 14:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/79e341614c50 8022080: javadoc generates invalid HTML in Turkish locale Reviewed-by: bpatel ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTag.java ! src/share/classes/com/sun/tools/doclint/HtmlTag.java From jonathan.gibbons at oracle.com Tue Aug 20 15:13:02 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 20 Aug 2013 22:13:02 +0000 Subject: hg: jdk8/tl/langtools: 8013887: In class use, some tables are randomly unsorted Message-ID: <20130820221305.33B1448A09@hg.openjdk.java.net> Changeset: 720992953d43 Author: jjg Date: 2013-08-20 15:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/720992953d43 8013887: In class use, some tables are randomly unsorted Reviewed-by: bpatel ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java From eric.mccorkle at oracle.com Tue Aug 20 15:36:34 2013 From: eric.mccorkle at oracle.com (Eric McCorkle) Date: Tue, 20 Aug 2013 18:36:34 -0400 Subject: Review request for JDK-8020745: Suspicious MethodParameters attribute generated for local classes capturing local variables In-Reply-To: <5212B832.6040508@oracle.com> References: <5212AAB4.8060700@oracle.com> <5212B832.6040508@oracle.com> Message-ID: <5213EF72.6080100@oracle.com> A new webrev has been uploaded which addresses these issues. http://cr.openjdk.java.net/~emc/8020745/ On 08/19/13 20:28, Alex Buckley wrote: > The AnonymousParameters.java test is very confusing. Two classes with > main methods in the same compilation unit?! > > Bug 8020745 indicates a mismatch between parameter names and types, but > this test only checks names. Rather than relying on the order of names > from the JVM to match the 'names' array, you should match up names and > types explicitly. > > List is a bad name for a helper class, and the @summary is not very > helpful. > > Most importantly, there are no anonymous classes here - List is a local > class. The test should have an anonymous class too - in fact, an > anonymous class whose superclass is not inner and an anonymous class > whose superclass is inner. (See the notes in 8misc.pdf 2.2 8.8.9 for why > that matters.) > > Alex > > On 8/19/2013 4:31 PM, Eric McCorkle wrote: >> Hello, >> >> Please review this patch, which causes captured locals to be added to >> the end of a MethodParameters attribute, like they should. >> >> The webrev is here: >> http://cr.openjdk.java.net/~emc/8020745/ >> >> The bug report is here: >> http://bugs.sun.com/view_bug.do?bug_id=8020745 >> >> This review is also on the new Crucible system. >> >> Thanks, >> Eric >> -------------- next part -------------- A non-text attachment was scrubbed... Name: eric_mccorkle.vcf Type: text/x-vcard Size: 314 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20130820/894d5e9c/eric_mccorkle.vcf From mike.duigou at oracle.com Tue Aug 20 17:51:30 2013 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Wed, 21 Aug 2013 00:51:30 +0000 Subject: hg: jdk8/tl: 8023433: Improve 'make help' Message-ID: <20130821005130.7CC5C48A18@hg.openjdk.java.net> Changeset: c8da1b6a9762 Author: mduigou Date: 2013-08-20 17:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/c8da1b6a9762 8023433: Improve 'make help' Reviewed-by: tbell ! NewMakefile.gmk From alex.buckley at oracle.com Tue Aug 20 18:17:38 2013 From: alex.buckley at oracle.com (Alex Buckley) Date: Tue, 20 Aug 2013 18:17:38 -0700 Subject: Review request for JDK-8020745: Suspicious MethodParameters attribute generated for local classes capturing local variables In-Reply-To: <5213EF72.6080100@oracle.com> References: <5212AAB4.8060700@oracle.com> <5212B832.6040508@oracle.com> <5213EF72.6080100@oracle.com> Message-ID: <52141532.7020404@oracle.com> - Method makeAnonExtendsInner does not return an instance of an anonymous class whose superclass is inner. InnerList is a local class, and its superclass ArrayList is top level. Also, you should document the kinds of classes for which you're exercising parameter generation. - Encapsulate! The "expected" variables like Inner_names should be closer to the classes declaring the "actual" variables (i.e. constructor parameters) of interest. checkConstructor should merely have to ask that class to check itself. Alex On 8/20/2013 3:36 PM, Eric McCorkle wrote: > A new webrev has been uploaded which addresses these issues. > http://cr.openjdk.java.net/~emc/8020745/ > > On 08/19/13 20:28, Alex Buckley wrote: >> The AnonymousParameters.java test is very confusing. Two classes with >> main methods in the same compilation unit?! >> >> Bug 8020745 indicates a mismatch between parameter names and types, but >> this test only checks names. Rather than relying on the order of names >> from the JVM to match the 'names' array, you should match up names and >> types explicitly. >> >> List is a bad name for a helper class, and the @summary is not very >> helpful. >> >> Most importantly, there are no anonymous classes here - List is a local >> class. The test should have an anonymous class too - in fact, an >> anonymous class whose superclass is not inner and an anonymous class >> whose superclass is inner. (See the notes in 8misc.pdf 2.2 8.8.9 for why >> that matters.) >> >> Alex >> >> On 8/19/2013 4:31 PM, Eric McCorkle wrote: >>> Hello, >>> >>> Please review this patch, which causes captured locals to be added to >>> the end of a MethodParameters attribute, like they should. >>> >>> The webrev is here: >>> http://cr.openjdk.java.net/~emc/8020745/ >>> >>> The bug report is here: >>> http://bugs.sun.com/view_bug.do?bug_id=8020745 >>> >>> This review is also on the new Crucible system. >>> >>> Thanks, >>> Eric >>> From alan.bateman at oracle.com Wed Aug 21 02:02:07 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Wed, 21 Aug 2013 09:02:07 +0000 Subject: hg: jdk8/tl/jdk: 8023351: Add TEST.groups in preparation to simplify rules in jdk/test/Makefile Message-ID: <20130821090221.72AF148A34@hg.openjdk.java.net> Changeset: eb18a483e772 Author: alanb Date: 2013-08-21 09:59 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/eb18a483e772 8023351: Add TEST.groups in preparation to simplify rules in jdk/test/Makefile Reviewed-by: lancea, mduigou ! test/TEST.ROOT + test/TEST.groups From staffan.larsen at oracle.com Wed Aug 21 02:43:40 2013 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Wed, 21 Aug 2013 09:43:40 +0000 Subject: hg: jdk8/tl/jdk: 4 new changesets Message-ID: <20130821094503.9A16C48A37@hg.openjdk.java.net> Changeset: 68be998c2596 Author: egahlin Date: 2013-08-19 12:57 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/68be998c2596 6358357: Division by zero in Threads tab when shrinking jconsole window Reviewed-by: mchung, leifs, jbachorik ! src/share/classes/sun/tools/jconsole/Plotter.java Changeset: bddf55211ed8 Author: egahlin Date: 2013-08-19 16:21 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bddf55211ed8 6417721: Thread list should not allow multiple selection Reviewed-by: alanb, jbachorik, sjiang ! src/share/classes/sun/tools/jconsole/ThreadTab.java Changeset: 2636d337a1ed Author: egahlin Date: 2013-08-19 16:41 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2636d337a1ed 6800801: NPE in JConsole when using Nimbus L&F Reviewed-by: alanb, sjiang ! src/share/classes/sun/tools/jconsole/ConnectDialog.java ! src/share/classes/sun/tools/jconsole/VMPanel.java Changeset: ba943fc47fc8 Author: egahlin Date: 2013-08-19 13:11 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ba943fc47fc8 7042707: Un-needed mnemonic in JConsole resource file Reviewed-by: mfang, jbachorik ! src/share/classes/sun/tools/jconsole/Messages.java ! src/share/classes/sun/tools/jconsole/resources/messages.properties ! src/share/classes/sun/tools/jconsole/resources/messages_ja.properties ! src/share/classes/sun/tools/jconsole/resources/messages_zh_CN.properties From david.holmes at oracle.com Wed Aug 21 02:57:16 2013 From: david.holmes at oracle.com (david.holmes at oracle.com) Date: Wed, 21 Aug 2013 09:57:16 +0000 Subject: hg: jdk8/tl/jdk: 8023460: OPENJDK build fails due to missing jfr.jar Message-ID: <20130821095728.7866948A38@hg.openjdk.java.net> Changeset: 3b8fed46b2a8 Author: dholmes Date: 2013-08-21 05:56 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3b8fed46b2a8 8023460: OPENJDK build fails due to missing jfr.jar Reviewed-by: alanb ! makefiles/Profiles.gmk From staffan.larsen at oracle.com Wed Aug 21 08:33:42 2013 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Wed, 21 Aug 2013 15:33:42 +0000 Subject: hg: jdk8/tl/jdk: 8023485: Remove com/sun/jdi/DoubleAgentTest.java and com/sun/jdi/FieldWatchpoints.java from ProblemList.txt Message-ID: <20130821153409.DC15048A46@hg.openjdk.java.net> Changeset: 8996f47f738d Author: sla Date: 2013-08-21 17:19 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8996f47f738d 8023485: Remove com/sun/jdi/DoubleAgentTest.java and com/sun/jdi/FieldWatchpoints.java from ProblemList.txt Reviewed-by: chegar, mgronlun ! test/ProblemList.txt From eaftan at google.com Wed Aug 21 11:32:50 2013 From: eaftan at google.com (Eddie Aftandilian) Date: Wed, 21 Aug 2013 11:32:50 -0700 Subject: Misleading error message when using diamond operator with private constructor Message-ID: Hi compiler-dev, I work with Jeremy on javac at Google. A user pointed out to us that compiling code that uses the diamond operator and attempts to access a private constructor fails with a misleading error message: Test.java:3: error: cannot infer type arguments for MyList<> MyList foo = new MyList<>(); ^ 1 error The error is not that the types cannot be inferred, but that the constructor for MyList is private. If you explicitly specify the type parameter in the call to the MyList constructor, you get the correct error message telling you that the constructor is private. Steps to reproduce: I'm using javac version 1.7.0_25. 1) Create these 2 files. MyList.java: public class MyList { private MyList() { } } Test.java: public class Test { public void foo() { MyList foo = new MyList<>(); } } 2) Compile. $ javac Test.java Test.java:3: error: cannot infer type arguments for MyList<> MyList foo = new MyList<>(); ^ 1 error It would be great if javac produced a more helpful error message in this case. Thanks, Eddie -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20130821/c4f210ef/attachment.html From henry.jen at oracle.com Wed Aug 21 13:14:41 2013 From: henry.jen at oracle.com (henry.jen at oracle.com) Date: Wed, 21 Aug 2013 20:14:41 +0000 Subject: hg: jdk8/tl/jdk: 8016846: Pattern.splitAsStream tests required Message-ID: <20130821201454.58B7848A5E@hg.openjdk.java.net> Changeset: 60891d90327f Author: henryjen Date: 2013-08-20 14:23 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/60891d90327f 8016846: Pattern.splitAsStream tests required Reviewed-by: alanb, psandoz Contributed-by: Ben Evans + test/java/util/regex/PatternTest.java From mike.duigou at oracle.com Wed Aug 21 12:49:20 2013 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Wed, 21 Aug 2013 19:49:20 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20130821194944.A99FD48A5B@hg.openjdk.java.net> Changeset: fad3b6673159 Author: mduigou Date: 2013-08-21 12:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fad3b6673159 8023306: Add replace() implementations to TreeMap Reviewed-by: psandoz, alanb, chegar, bpb ! src/share/classes/java/util/TreeMap.java Changeset: 91a31c77be5b Author: mduigou Date: 2013-08-21 12:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/91a31c77be5b 8023395: Remove sun.misc.Sort and sun.misc.Compare Reviewed-by: alanb, smarks, darcy, mr - src/share/classes/sun/misc/Compare.java - src/share/classes/sun/misc/Sort.java From eric.mccorkle at oracle.com Wed Aug 21 14:00:59 2013 From: eric.mccorkle at oracle.com (Eric McCorkle) Date: Wed, 21 Aug 2013 17:00:59 -0400 Subject: Review request for JDK-8020745: Suspicious MethodParameters attribute generated for local classes capturing local variables In-Reply-To: <52141532.7020404@oracle.com> References: <5212AAB4.8060700@oracle.com> <5212B832.6040508@oracle.com> <5213EF72.6080100@oracle.com> <52141532.7020404@oracle.com> Message-ID: <52152A8B.5090307@oracle.com> I have addressed these issues and uploaded a new webrev. Crucible reviews are also complete. On 08/20/13 21:17, Alex Buckley wrote: > - Method makeAnonExtendsInner does not return an instance of an > anonymous class whose superclass is inner. InnerList is a local class, > and its superclass ArrayList is top level. Also, you should document the > kinds of classes for which you're exercising parameter generation. > > - Encapsulate! The "expected" variables like Inner_names should be > closer to the classes declaring the "actual" variables (i.e. constructor > parameters) of interest. checkConstructor should merely have to ask that > class to check itself. > > Alex > > On 8/20/2013 3:36 PM, Eric McCorkle wrote: >> A new webrev has been uploaded which addresses these issues. >> http://cr.openjdk.java.net/~emc/8020745/ >> >> On 08/19/13 20:28, Alex Buckley wrote: >>> The AnonymousParameters.java test is very confusing. Two classes with >>> main methods in the same compilation unit?! >>> >>> Bug 8020745 indicates a mismatch between parameter names and types, but >>> this test only checks names. Rather than relying on the order of names >>> from the JVM to match the 'names' array, you should match up names and >>> types explicitly. >>> >>> List is a bad name for a helper class, and the @summary is not very >>> helpful. >>> >>> Most importantly, there are no anonymous classes here - List is a local >>> class. The test should have an anonymous class too - in fact, an >>> anonymous class whose superclass is not inner and an anonymous class >>> whose superclass is inner. (See the notes in 8misc.pdf 2.2 8.8.9 for why >>> that matters.) >>> >>> Alex >>> >>> On 8/19/2013 4:31 PM, Eric McCorkle wrote: >>>> Hello, >>>> >>>> Please review this patch, which causes captured locals to be added to >>>> the end of a MethodParameters attribute, like they should. >>>> >>>> The webrev is here: >>>> http://cr.openjdk.java.net/~emc/8020745/ >>>> >>>> The bug report is here: >>>> http://bugs.sun.com/view_bug.do?bug_id=8020745 >>>> >>>> This review is also on the new Crucible system. >>>> >>>> Thanks, >>>> Eric >>>> -------------- next part -------------- A non-text attachment was scrubbed... Name: eric_mccorkle.vcf Type: text/x-vcard Size: 314 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20130821/105d71a5/eric_mccorkle.vcf From alex.buckley at oracle.com Wed Aug 21 14:52:56 2013 From: alex.buckley at oracle.com (Alex Buckley) Date: Wed, 21 Aug 2013 14:52:56 -0700 Subject: Review request for JDK-8020745: Suspicious MethodParameters attribute generated for local classes capturing local variables In-Reply-To: <52152A8B.5090307@oracle.com> References: <5212AAB4.8060700@oracle.com> <5212B832.6040508@oracle.com> <5213EF72.6080100@oracle.com> <52141532.7020404@oracle.com> <52152A8B.5090307@oracle.com> Message-ID: <521536B8.2010501@oracle.com> The major test cases are now covered, which is good. You should add a multi-line comment which enumerates them. The @summary is just not enough. You could get rid of some "line noise" by using array initializers: return new String[] { "this$1", "innerparam" }; This will minimize the number of variables with general names like "names" and "types". Such variables already exist in Tester#check and you _really_ want to avoid a hiding scenario. Tester#message is pretty obscure. I mean, you can't _force_ the methods overriding it to capture the 'message' variable of ParameterNames. It would be more direct for class InnerTester et al so simply declare their own fields which reference ParameterNames.message. Then you could drop Tester#message. Please document that ParameterNames.message exists only to be captured, and that javac currently happens to choose val$message for the name of the synthetic ctor parameter but it may choose another name in the future. I don't see what Tester.field is doing. Alex On 8/21/2013 2:00 PM, Eric McCorkle wrote: > I have addressed these issues and uploaded a new webrev. Crucible > reviews are also complete. > > On 08/20/13 21:17, Alex Buckley wrote: >> - Method makeAnonExtendsInner does not return an instance of an >> anonymous class whose superclass is inner. InnerList is a local class, >> and its superclass ArrayList is top level. Also, you should document the >> kinds of classes for which you're exercising parameter generation. >> >> - Encapsulate! The "expected" variables like Inner_names should be >> closer to the classes declaring the "actual" variables (i.e. constructor >> parameters) of interest. checkConstructor should merely have to ask that >> class to check itself. >> >> Alex >> >> On 8/20/2013 3:36 PM, Eric McCorkle wrote: >>> A new webrev has been uploaded which addresses these issues. >>> http://cr.openjdk.java.net/~emc/8020745/ >>> >>> On 08/19/13 20:28, Alex Buckley wrote: >>>> The AnonymousParameters.java test is very confusing. Two classes with >>>> main methods in the same compilation unit?! >>>> >>>> Bug 8020745 indicates a mismatch between parameter names and types, but >>>> this test only checks names. Rather than relying on the order of names >>>> from the JVM to match the 'names' array, you should match up names and >>>> types explicitly. >>>> >>>> List is a bad name for a helper class, and the @summary is not very >>>> helpful. >>>> >>>> Most importantly, there are no anonymous classes here - List is a local >>>> class. The test should have an anonymous class too - in fact, an >>>> anonymous class whose superclass is not inner and an anonymous class >>>> whose superclass is inner. (See the notes in 8misc.pdf 2.2 8.8.9 for why >>>> that matters.) >>>> >>>> Alex >>>> >>>> On 8/19/2013 4:31 PM, Eric McCorkle wrote: >>>>> Hello, >>>>> >>>>> Please review this patch, which causes captured locals to be added to >>>>> the end of a MethodParameters attribute, like they should. >>>>> >>>>> The webrev is here: >>>>> http://cr.openjdk.java.net/~emc/8020745/ >>>>> >>>>> The bug report is here: >>>>> http://bugs.sun.com/view_bug.do?bug_id=8020745 >>>>> >>>>> This review is also on the new Crucible system. >>>>> >>>>> Thanks, >>>>> Eric >>>>> From jonathan.gibbons at oracle.com Wed Aug 21 16:14:14 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Wed, 21 Aug 2013 23:14:14 +0000 Subject: hg: jdk8/tl/langtools: 8023515: import type-annotations updates Message-ID: <20130821231417.A145A48A61@hg.openjdk.java.net> Changeset: 7de231613e4a Author: jjg Date: 2013-08-21 16:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7de231613e4a 8023515: import type-annotations updates Reviewed-by: jjg Contributed-by: wdietl at gmail.com ! src/share/classes/com/sun/source/tree/MethodTree.java ! src/share/classes/com/sun/source/tree/TypeParameterTree.java ! src/share/classes/com/sun/tools/javac/code/Printer.java ! src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/tree/Pretty.java ! test/tools/javac/annotations/typeAnnotations/classfile/CombinationsTargetTest2.java + test/tools/javac/annotations/typeAnnotations/failures/DummyProcessor.java + test/tools/javac/annotations/typeAnnotations/failures/T8020715.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/Constructors.java + test/tools/javac/tree/TypeAnnotationsPretty.java From eric.mccorkle at oracle.com Wed Aug 21 17:24:04 2013 From: eric.mccorkle at oracle.com (eric.mccorkle at oracle.com) Date: Thu, 22 Aug 2013 00:24:04 +0000 Subject: hg: jdk8/tl/langtools: 7118412: Shadowing of type-variables vs. member types; ... Message-ID: <20130822002407.9A65248A64@hg.openjdk.java.net> Changeset: 2068190f8ac2 Author: emc Date: 2013-08-21 20:23 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2068190f8ac2 7118412: Shadowing of type-variables vs. member types 4987840: What is the scope of an annotation? Summary: Fixed issue with shadowing of type names. Reviewed-by: jjg, abuckley, mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Resolve.java From jonathan.gibbons at oracle.com Wed Aug 21 17:29:36 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Thu, 22 Aug 2013 00:29:36 +0000 Subject: hg: jdk8/tl/langtools: 8022287: javac.sym.Profiles uses a static Map when it should not Message-ID: <20130822002939.8336848A65@hg.openjdk.java.net> Changeset: 57e1266527dd Author: jjg Date: 2013-08-21 17:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/57e1266527dd 8022287: javac.sym.Profiles uses a static Map when it should not Reviewed-by: ksrini ! src/share/classes/com/sun/tools/javac/sym/Profiles.java + test/tools/javac/profiles/ProfileTest.java From eric.mccorkle at oracle.com Wed Aug 21 17:43:27 2013 From: eric.mccorkle at oracle.com (eric.mccorkle at oracle.com) Date: Thu, 22 Aug 2013 00:43:27 +0000 Subject: hg: jdk8/tl/langtools: 8023520: Add missing test for JDK-7118412 Message-ID: <20130822004330.6C49548A66@hg.openjdk.java.net> Changeset: eebb29618f50 Author: emc Date: 2013-08-21 20:41 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/eebb29618f50 8023520: Add missing test for JDK-7118412 Summary: The test for JDK-7118412 was dropped from the changeset in a merging accident. Reviewed-by: jjg + test/tools/javac/7118412/ShadowingTest.java From xuelei.fan at oracle.com Wed Aug 21 19:46:51 2013 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Thu, 22 Aug 2013 02:46:51 +0000 Subject: hg: jdk8/tl/jdk: 8022228: Intermittent test failures in sun/security/ssl/javax/net/ssl/NewAPIs Message-ID: <20130822024717.B922548A76@hg.openjdk.java.net> Changeset: ec827a62070a Author: xuelei Date: 2013-08-21 19:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ec827a62070a 8022228: Intermittent test failures in sun/security/ssl/javax/net/ssl/NewAPIs Reviewed-by: weijun ! test/sun/security/ssl/javax/net/ssl/NewAPIs/SessionCacheSizeTests.java ! test/sun/security/ssl/javax/net/ssl/NewAPIs/SessionTimeOutTests.java ! test/sun/security/ssl/templates/SSLSocketTemplate.java From staffan.larsen at oracle.com Wed Aug 21 23:29:14 2013 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Thu, 22 Aug 2013 06:29:14 +0000 Subject: hg: jdk8/tl/jdk: 8023101: java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java fails Message-ID: <20130822062937.A47CB48A7B@hg.openjdk.java.net> Changeset: a0896634ab46 Author: sla Date: 2013-08-22 08:28 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a0896634ab46 8023101: java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java fails Reviewed-by: ysr ! test/java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java From vicente.romero at oracle.com Thu Aug 22 02:23:48 2013 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Thu, 22 Aug 2013 09:23:48 +0000 Subject: hg: jdk8/tl/langtools: 8022316: Generic throws, overriding and method reference Message-ID: <20130822092359.E724B48A80@hg.openjdk.java.net> Changeset: 7a4717f3ea7b Author: vromero Date: 2013-08-22 10:22 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7a4717f3ea7b 8022316: Generic throws, overriding and method reference Reviewed-by: jjg, mcimadamore ! src/share/classes/com/sun/tools/javac/code/Types.java + test/tools/javac/T8022316/CompilerErrorGenericThrowPlusMethodRefTest.java + test/tools/javac/T8022316/CompilerErrorGenericThrowPlusMethodRefTest.out From maurizio.cimadamore at oracle.com Thu Aug 22 03:09:29 2013 From: maurizio.cimadamore at oracle.com (Maurizio Cimadamore) Date: Thu, 22 Aug 2013 11:09:29 +0100 Subject: Misleading error message when using diamond operator with private constructor In-Reply-To: References: Message-ID: <5215E359.60407@oracle.com> On 21/08/13 19:32, Eddie Aftandilian wrote: > Hi compiler-dev, > > I work with Jeremy on javac at Google. A user pointed out to us that > compiling code that uses the diamond operator and attempts to access a > private constructor fails with a misleading error message: > > Test.java:3: error: cannot infer type arguments for MyList<> > MyList foo = new MyList<>(); > ^ > 1 error > > The error is not that the types cannot be inferred, but that the > constructor for MyList is private. If you explicitly specify the type > parameter in the call to the MyList constructor, you get the correct > error message telling you that the constructor is private. Thanks for the report - it's true that error messages in diamond are suboptimal when the failure occurs for reasons other than inference. I'll file a bug on this one. Maurizio > > Steps to reproduce: > > I'm using javac version 1.7.0_25. > > 1) Create these 2 files. > > MyList.java: > public class MyList { > private MyList() { } > } > > Test.java: > public class Test { > public void foo() { > MyList foo = new MyList<>(); > } > } > > 2) Compile. > > $ javac Test.java > Test.java:3: error: cannot infer type arguments for MyList<> > MyList foo = new MyList<>(); > ^ > 1 error > > It would be great if javac produced a more helpful error message in > this case. > > Thanks, > Eddie From maurizio.cimadamore at oracle.com Thu Aug 22 03:19:30 2013 From: maurizio.cimadamore at oracle.com (Maurizio Cimadamore) Date: Thu, 22 Aug 2013 11:19:30 +0100 Subject: Misleading error message when using diamond operator with private constructor In-Reply-To: <5215E359.60407@oracle.com> References: <5215E359.60407@oracle.com> Message-ID: <5215E5B2.10702@oracle.com> On 22/08/13 11:09, Maurizio Cimadamore wrote: > On 21/08/13 19:32, Eddie Aftandilian wrote: >> Hi compiler-dev, >> >> I work with Jeremy on javac at Google. A user pointed out to us that >> compiling code that uses the diamond operator and attempts to access >> a private constructor fails with a misleading error message: >> >> Test.java:3: error: cannot infer type arguments for MyList<> >> MyList foo = new MyList<>(); >> ^ >> 1 error >> >> The error is not that the types cannot be inferred, but that the >> constructor for MyList is private. If you explicitly specify the >> type parameter in the call to the MyList constructor, you get the >> correct error message telling you that the constructor is private. > Thanks for the report - it's true that error messages in diamond are > suboptimal when the failure occurs for reasons other than inference. > I'll file a bug on this one. Filed bug no. 8023545 Thanks again Maurizio > > Maurizio >> >> Steps to reproduce: >> >> I'm using javac version 1.7.0_25. >> >> 1) Create these 2 files. >> >> MyList.java: >> public class MyList { >> private MyList() { } >> } >> >> Test.java: >> public class Test { >> public void foo() { >> MyList foo = new MyList<>(); >> } >> } >> >> 2) Compile. >> >> $ javac Test.java >> Test.java:3: error: cannot infer type arguments for MyList<> >> MyList foo = new MyList<>(); >> ^ >> 1 error >> >> It would be great if javac produced a more helpful error message in >> this case. >> >> Thanks, >> Eddie > From vicente.romero at oracle.com Thu Aug 22 05:13:31 2013 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Thu, 22 Aug 2013 12:13:31 +0000 Subject: hg: jdk8/tl/langtools: 8023112: javac should not use lazy constant evaluation approach for method references Message-ID: <20130822121336.74ABE48A86@hg.openjdk.java.net> Changeset: 25aaff78d754 Author: vromero Date: 2013-08-22 13:12 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/25aaff78d754 8023112: javac should not use lazy constant evaluation approach for method references Reviewed-by: jjg, mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java + test/tools/javac/T8023112/SkipLazyConstantCreationForMethodRefTest.java From eric.mccorkle at oracle.com Thu Aug 22 08:05:57 2013 From: eric.mccorkle at oracle.com (Eric McCorkle) Date: Thu, 22 Aug 2013 11:05:57 -0400 Subject: Review request for JDK-8020745: Suspicious MethodParameters attribute generated for local classes capturing local variables In-Reply-To: <521536B8.2010501@oracle.com> References: <5212AAB4.8060700@oracle.com> <5212B832.6040508@oracle.com> <5213EF72.6080100@oracle.com> <52141532.7020404@oracle.com> <52152A8B.5090307@oracle.com> <521536B8.2010501@oracle.com> Message-ID: <521628D5.9040500@oracle.com> These have been addressed. A new webrev has been posted. On 08/21/13 17:52, Alex Buckley wrote: > The major test cases are now covered, which is good. > > You should add a multi-line comment which enumerates them. The @summary > is just not enough. > > You could get rid of some "line noise" by using array initializers: > > return new String[] { "this$1", > "innerparam" }; > > This will minimize the number of variables with general names like > "names" and "types". Such variables already exist in Tester#check and > you _really_ want to avoid a hiding scenario. > > Tester#message is pretty obscure. I mean, you can't _force_ the methods > overriding it to capture the 'message' variable of ParameterNames. It > would be more direct for class InnerTester et al so simply declare their > own fields which reference ParameterNames.message. Then you could drop > Tester#message. Please document that ParameterNames.message exists only > to be captured, and that javac currently happens to choose val$message > for the name of the synthetic ctor parameter but it may choose another > name in the future. > > I don't see what Tester.field is doing. > > Alex > > On 8/21/2013 2:00 PM, Eric McCorkle wrote: >> I have addressed these issues and uploaded a new webrev. Crucible >> reviews are also complete. >> >> On 08/20/13 21:17, Alex Buckley wrote: >>> - Method makeAnonExtendsInner does not return an instance of an >>> anonymous class whose superclass is inner. InnerList is a local class, >>> and its superclass ArrayList is top level. Also, you should document the >>> kinds of classes for which you're exercising parameter generation. >>> >>> - Encapsulate! The "expected" variables like Inner_names should be >>> closer to the classes declaring the "actual" variables (i.e. constructor >>> parameters) of interest. checkConstructor should merely have to ask that >>> class to check itself. >>> >>> Alex >>> >>> On 8/20/2013 3:36 PM, Eric McCorkle wrote: >>>> A new webrev has been uploaded which addresses these issues. >>>> http://cr.openjdk.java.net/~emc/8020745/ >>>> >>>> On 08/19/13 20:28, Alex Buckley wrote: >>>>> The AnonymousParameters.java test is very confusing. Two classes with >>>>> main methods in the same compilation unit?! >>>>> >>>>> Bug 8020745 indicates a mismatch between parameter names and types, >>>>> but >>>>> this test only checks names. Rather than relying on the order of names >>>>> from the JVM to match the 'names' array, you should match up names and >>>>> types explicitly. >>>>> >>>>> List is a bad name for a helper class, and the @summary is not very >>>>> helpful. >>>>> >>>>> Most importantly, there are no anonymous classes here - List is a >>>>> local >>>>> class. The test should have an anonymous class too - in fact, an >>>>> anonymous class whose superclass is not inner and an anonymous class >>>>> whose superclass is inner. (See the notes in 8misc.pdf 2.2 8.8.9 >>>>> for why >>>>> that matters.) >>>>> >>>>> Alex >>>>> >>>>> On 8/19/2013 4:31 PM, Eric McCorkle wrote: >>>>>> Hello, >>>>>> >>>>>> Please review this patch, which causes captured locals to be added to >>>>>> the end of a MethodParameters attribute, like they should. >>>>>> >>>>>> The webrev is here: >>>>>> http://cr.openjdk.java.net/~emc/8020745/ >>>>>> >>>>>> The bug report is here: >>>>>> http://bugs.sun.com/view_bug.do?bug_id=8020745 >>>>>> >>>>>> This review is also on the new Crucible system. >>>>>> >>>>>> Thanks, >>>>>> Eric >>>>>> -------------- next part -------------- A non-text attachment was scrubbed... Name: eric_mccorkle.vcf Type: text/x-vcard Size: 303 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20130822/bb31cf70/eric_mccorkle.vcf From joe.darcy at oracle.com Thu Aug 22 09:41:33 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Thu, 22 Aug 2013 16:41:33 +0000 Subject: hg: jdk8/tl/jdk: 8023587: Fix lone remaining doclint issue in java.util.regex Message-ID: <20130822164212.2D00B48AA0@hg.openjdk.java.net> Changeset: b7c4094be729 Author: darcy Date: 2013-08-22 09:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b7c4094be729 8023587: Fix lone remaining doclint issue in java.util.regex Reviewed-by: jjg ! src/share/classes/java/util/regex/Pattern.java From eric.mccorkle at oracle.com Thu Aug 22 09:49:15 2013 From: eric.mccorkle at oracle.com (eric.mccorkle at oracle.com) Date: Thu, 22 Aug 2013 16:49:15 +0000 Subject: hg: jdk8/tl/langtools: 8020745: Suspicious MethodParameters attribute generated for local classes capturing local variables Message-ID: <20130822164921.71E4548AA1@hg.openjdk.java.net> Changeset: 1ab22e60a738 Author: emc Date: 2013-08-22 12:47 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1ab22e60a738 8020745: Suspicious MethodParameters attribute generated for local classes capturing local variables Summary: Corrected an error in a previous patch that caused captured locals to be added to the beginning, not the end of a parameter list. Reviewed-by: jjg, mcimadamore, ksrini, abuckley ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java - test/tools/javac/8015701/AnonymousParameters.java + test/tools/javac/MethodParameters/CaptureTest.java From alex.buckley at oracle.com Thu Aug 22 11:35:56 2013 From: alex.buckley at oracle.com (Alex Buckley) Date: Thu, 22 Aug 2013 11:35:56 -0700 Subject: Review request for JDK-8020745: Suspicious MethodParameters attribute generated for local classes capturing local variables In-Reply-To: <521628D5.9040500@oracle.com> References: <5212AAB4.8060700@oracle.com> <5212B832.6040508@oracle.com> <5213EF72.6080100@oracle.com> <52141532.7020404@oracle.com> <52152A8B.5090307@oracle.com> <521536B8.2010501@oracle.com> <521628D5.9040500@oracle.com> Message-ID: <52165A0C.6080809@oracle.com> Thanks for improving the clarity of the test cases within Encloser. I have some comments on the expected flags of parameters. First, the good news: - The makeInner case is correct. Since InnerTester is private, the only code that can instantiate it is in the same top level class. This means the immediately enclosing instance of InnerTester can be transmitted to InnerTester's ctor in a proprietary manner; the JLS does not specify it. Hence, this$1 is SYNTHETIC, not MANDATED. - The makeAnon case is correct. Since the anonymous class has a superclass that is inner (Tester), there must be a standard, JLS-specified way of transmitting, to the anonymous class's constructor, the immediately enclosing instance of the anonymous class with respect to the superclass. Hence, this$1 is MANDATED, not SYNTHETIC. - The makeAnonExtendsInner case is similar to makeAnon, in that the anonymous class's superclass is inner (InnerTester). But because InnerTester is private, it is possible to transmit the immediately enclosing instance of the anonymous class with respect to the superclass in a proprietary manner to the anonymous class's constructor. That argues for this$1 being SYNTHETIC, rather than MANDATED as in the test case. However, the spec is not clear on this scenario. I intend to clarify the spec ASAP, which will make the current makeAnonExtendsInner incorrect. Now the bad news: - The makeLocal case is incorrect. Since LocalTester is local, the only code that can instantiate it is in the body of the makeLocal method. This means the immediately enclosing instance of LocalTester can be transmitted to LocalTester's ctor in a proprietary manner; the JLS does not specify it. Hence, this$1 should be SYNTHETIC, not MANDATED. - The makeAnonExtendsLocal case is tricky. Please recognize that the constructor of the abstract class LocalTester is not the same thing as the constructor of the anonymous class whose superclass is LocalTester. names() et al in the abstract class LocalTester are necessarily identical to those in the class LocalTester in makeLocal; they should be removed from makeAnonExtendsLocal. Then, please add names() et al to the body of the anonymous class, akin to the anonymous class declared in makeAnonExtendsInner. What values are expected by the new names()? Good question. The anonymous class in makeAnonExtendsLocal has a superclass (LocalTester) which is inner but also local, so the spec is not clear how to transmit the immediately enclosing instance of the anonymous class with respect to the superclass. Again, I intend to clarify the spec ASAP. FWIW the Inner Classes Specification in 1997 described the transmission of enclosing instances to nested class constructors, but did not quite appreciate the subtlety of what needed to be "mandated" for compiler interoperability. Alex On 8/22/2013 8:05 AM, Eric McCorkle wrote: > These have been addressed. A new webrev has been posted. > > On 08/21/13 17:52, Alex Buckley wrote: >> The major test cases are now covered, which is good. >> >> You should add a multi-line comment which enumerates them. The @summary >> is just not enough. >> >> You could get rid of some "line noise" by using array initializers: >> >> return new String[] { "this$1", >> "innerparam" }; >> >> This will minimize the number of variables with general names like >> "names" and "types". Such variables already exist in Tester#check and >> you _really_ want to avoid a hiding scenario. >> >> Tester#message is pretty obscure. I mean, you can't _force_ the methods >> overriding it to capture the 'message' variable of ParameterNames. It >> would be more direct for class InnerTester et al so simply declare their >> own fields which reference ParameterNames.message. Then you could drop >> Tester#message. Please document that ParameterNames.message exists only >> to be captured, and that javac currently happens to choose val$message >> for the name of the synthetic ctor parameter but it may choose another >> name in the future. >> >> I don't see what Tester.field is doing. >> >> Alex >> >> On 8/21/2013 2:00 PM, Eric McCorkle wrote: >>> I have addressed these issues and uploaded a new webrev. Crucible >>> reviews are also complete. >>> >>> On 08/20/13 21:17, Alex Buckley wrote: >>>> - Method makeAnonExtendsInner does not return an instance of an >>>> anonymous class whose superclass is inner. InnerList is a local class, >>>> and its superclass ArrayList is top level. Also, you should document the >>>> kinds of classes for which you're exercising parameter generation. >>>> >>>> - Encapsulate! The "expected" variables like Inner_names should be >>>> closer to the classes declaring the "actual" variables (i.e. constructor >>>> parameters) of interest. checkConstructor should merely have to ask that >>>> class to check itself. >>>> >>>> Alex >>>> >>>> On 8/20/2013 3:36 PM, Eric McCorkle wrote: >>>>> A new webrev has been uploaded which addresses these issues. >>>>> http://cr.openjdk.java.net/~emc/8020745/ >>>>> >>>>> On 08/19/13 20:28, Alex Buckley wrote: >>>>>> The AnonymousParameters.java test is very confusing. Two classes with >>>>>> main methods in the same compilation unit?! >>>>>> >>>>>> Bug 8020745 indicates a mismatch between parameter names and types, >>>>>> but >>>>>> this test only checks names. Rather than relying on the order of names >>>>>> from the JVM to match the 'names' array, you should match up names and >>>>>> types explicitly. >>>>>> >>>>>> List is a bad name for a helper class, and the @summary is not very >>>>>> helpful. >>>>>> >>>>>> Most importantly, there are no anonymous classes here - List is a >>>>>> local >>>>>> class. The test should have an anonymous class too - in fact, an >>>>>> anonymous class whose superclass is not inner and an anonymous class >>>>>> whose superclass is inner. (See the notes in 8misc.pdf 2.2 8.8.9 >>>>>> for why >>>>>> that matters.) >>>>>> >>>>>> Alex >>>>>> >>>>>> On 8/19/2013 4:31 PM, Eric McCorkle wrote: >>>>>>> Hello, >>>>>>> >>>>>>> Please review this patch, which causes captured locals to be added to >>>>>>> the end of a MethodParameters attribute, like they should. >>>>>>> >>>>>>> The webrev is here: >>>>>>> http://cr.openjdk.java.net/~emc/8020745/ >>>>>>> >>>>>>> The bug report is here: >>>>>>> http://bugs.sun.com/view_bug.do?bug_id=8020745 >>>>>>> >>>>>>> This review is also on the new Crucible system. >>>>>>> >>>>>>> Thanks, >>>>>>> Eric >>>>>>> From dan.xu at oracle.com Thu Aug 22 11:43:40 2013 From: dan.xu at oracle.com (dan.xu at oracle.com) Date: Thu, 22 Aug 2013 18:43:40 +0000 Subject: hg: jdk8/tl/jdk: 8023430: Replace File.mkdirs with Files.createDirectories to get MaxPathLength.java failure details Message-ID: <20130822184414.54EE348ACC@hg.openjdk.java.net> Changeset: 8a7d9cc2f41c Author: dxu Date: 2013-08-22 11:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8a7d9cc2f41c 8023430: Replace File.mkdirs with Files.createDirectories to get MaxPathLength.java failure details Reviewed-by: alanb ! test/ProblemList.txt ! test/java/io/File/MaxPathLength.java From jonathan.gibbons at oracle.com Thu Aug 22 12:53:39 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Thu, 22 Aug 2013 19:53:39 +0000 Subject: hg: jdk8/tl/langtools: 8022173: Relax some warnings in doclint Message-ID: <20130822195344.ABB5648AD2@hg.openjdk.java.net> Changeset: b77381d99056 Author: jjg Date: 2013-08-22 12:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b77381d99056 8022173: Relax some warnings in doclint Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclint/HtmlTag.java ! test/tools/doclint/html/ListTagsTest.java ! test/tools/doclint/html/OtherTagsTest.java ! test/tools/doclint/html/OtherTagsTest.out ! test/tools/doclint/html/TableTagsTest.java From peter.levart at gmail.com Thu Aug 22 15:10:50 2013 From: peter.levart at gmail.com (peter.levart at gmail.com) Date: Thu, 22 Aug 2013 22:10:50 +0000 Subject: hg: jdk8/tl/jdk: 8022721: AnnotationTypeDeadlockTest.java throws java.lang.IllegalStateException: unexpected condition Message-ID: <20130822221116.9EE9548ADC@hg.openjdk.java.net> Changeset: 2281a7f79738 Author: plevart Date: 2013-08-20 14:13 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2281a7f79738 8022721: AnnotationTypeDeadlockTest.java throws java.lang.IllegalStateException: unexpected condition Reviewed-by: alanb, jfranck ! test/java/lang/annotation/AnnotationType/AnnotationTypeDeadlockTest.java From stuart.marks at oracle.com Thu Aug 22 15:53:20 2013 From: stuart.marks at oracle.com (stuart.marks at oracle.com) Date: Thu, 22 Aug 2013 22:53:20 +0000 Subject: hg: jdk8/tl/jdk: 8022445: fix RMISocketFactory example to avoid using localhost Message-ID: <20130822225333.EBC9548ADD@hg.openjdk.java.net> Changeset: 7496ec8bab76 Author: smarks Date: 2013-08-22 15:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7496ec8bab76 8022445: fix RMISocketFactory example to avoid using localhost Reviewed-by: chegar, alanb ! src/share/classes/java/rmi/server/RMISocketFactory.java From staffan.larsen at oracle.com Thu Aug 22 22:55:36 2013 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Fri, 23 Aug 2013 05:55:36 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20130823055615.9B27648AE6@hg.openjdk.java.net> Changeset: 7b6211cd8d76 Author: egahlin Date: 2013-08-21 17:15 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7b6211cd8d76 6417649: -interval=0 is accepted and jconsole doesn't update window content at all Reviewed-by: alanb, jbachorik ! src/share/classes/sun/tools/jconsole/JConsole.java Changeset: 77a32e5df365 Author: egahlin Date: 2013-08-21 17:17 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/77a32e5df365 6359971: Threads tab: Simple text to explain that one can click on a thread to get stack trace Reviewed-by: alanb, jbachorik ! src/share/classes/sun/tools/jconsole/Messages.java ! src/share/classes/sun/tools/jconsole/ThreadTab.java ! src/share/classes/sun/tools/jconsole/resources/messages.properties From chris.hegarty at oracle.com Fri Aug 23 02:03:01 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Fri, 23 Aug 2013 09:03:01 +0000 Subject: hg: jdk8/tl/jdk: 6470700: Math.random() / Math.initRNG() uses "double checked locking" Message-ID: <20130823090333.C8F7F48AF2@hg.openjdk.java.net> Changeset: 223be1d3494f Author: bpb Date: 2013-08-22 13:32 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/223be1d3494f 6470700: Math.random() / Math.initRNG() uses "double checked locking" Summary: Replace class Random variable with a static final holder class Reviewed-by: alanb, mduigou, chegar Contributed-by: Brian Burkhalter ! src/share/classes/java/lang/Math.java ! src/share/classes/java/lang/StrictMath.java From chris.hegarty at oracle.com Fri Aug 23 01:58:15 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Fri, 23 Aug 2013 08:58:15 +0000 Subject: hg: jdk8/tl/jaxws: 8022885: Update JAX-WS RI integration to 2.2.9-b14140; ... Message-ID: <20130823085819.860EF48AF0@hg.openjdk.java.net> Changeset: b99d7e355d4b Author: mkos Date: 2013-08-23 09:57 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/b99d7e355d4b 8022885: Update JAX-WS RI integration to 2.2.9-b14140 8013016: Rebase 8009009 against the latest jdk8/jaxws Reviewed-by: alanb, chegar ! src/share/jaxws_classes/com/sun/istack/internal/tools/ParallelWorldClassLoader.java ! src/share/jaxws_classes/com/sun/org/glassfish/external/probe/provider/annotations/Probe.java ! src/share/jaxws_classes/com/sun/org/glassfish/external/statistics/impl/AverageRangeStatisticImpl.java ! src/share/jaxws_classes/com/sun/org/glassfish/external/statistics/impl/BoundaryStatisticImpl.java ! src/share/jaxws_classes/com/sun/org/glassfish/external/statistics/impl/BoundedRangeStatisticImpl.java ! src/share/jaxws_classes/com/sun/org/glassfish/external/statistics/impl/CountStatisticImpl.java ! src/share/jaxws_classes/com/sun/org/glassfish/external/statistics/impl/RangeStatisticImpl.java ! src/share/jaxws_classes/com/sun/org/glassfish/external/statistics/impl/StatisticImpl.java ! src/share/jaxws_classes/com/sun/org/glassfish/external/statistics/impl/StringStatisticImpl.java ! src/share/jaxws_classes/com/sun/org/glassfish/external/statistics/impl/TimeStatisticImpl.java ! src/share/jaxws_classes/com/sun/tools/internal/jxc/MessageBundle.properties ! src/share/jaxws_classes/com/sun/tools/internal/jxc/MessageBundle_de.properties ! src/share/jaxws_classes/com/sun/tools/internal/jxc/MessageBundle_es.properties ! src/share/jaxws_classes/com/sun/tools/internal/jxc/MessageBundle_fr.properties ! src/share/jaxws_classes/com/sun/tools/internal/jxc/MessageBundle_it.properties ! src/share/jaxws_classes/com/sun/tools/internal/jxc/MessageBundle_ja.properties ! src/share/jaxws_classes/com/sun/tools/internal/jxc/MessageBundle_ko.properties ! src/share/jaxws_classes/com/sun/tools/internal/jxc/MessageBundle_pt_BR.properties ! src/share/jaxws_classes/com/sun/tools/internal/jxc/MessageBundle_zh_CN.properties ! src/share/jaxws_classes/com/sun/tools/internal/jxc/MessageBundle_zh_TW.properties ! src/share/jaxws_classes/com/sun/tools/internal/jxc/gen/config/AttributesImpl.java ! src/share/jaxws_classes/com/sun/tools/internal/jxc/gen/config/Classes.java ! src/share/jaxws_classes/com/sun/tools/internal/jxc/gen/config/Config.java ! src/share/jaxws_classes/com/sun/tools/internal/jxc/gen/config/NGCCEventReceiver.java ! src/share/jaxws_classes/com/sun/tools/internal/jxc/gen/config/NGCCEventSource.java ! src/share/jaxws_classes/com/sun/tools/internal/jxc/gen/config/NGCCHandler.java ! src/share/jaxws_classes/com/sun/tools/internal/jxc/gen/config/NGCCInterleaveFilter.java ! src/share/jaxws_classes/com/sun/tools/internal/jxc/gen/config/NGCCRuntime.java ! src/share/jaxws_classes/com/sun/tools/internal/jxc/gen/config/Schema.java ! src/share/jaxws_classes/com/sun/tools/internal/ws/version.properties ! src/share/jaxws_classes/com/sun/tools/internal/xjc/MessageBundle.properties ! src/share/jaxws_classes/com/sun/tools/internal/xjc/MessageBundle_de.properties ! src/share/jaxws_classes/com/sun/tools/internal/xjc/MessageBundle_es.properties ! src/share/jaxws_classes/com/sun/tools/internal/xjc/MessageBundle_fr.properties ! src/share/jaxws_classes/com/sun/tools/internal/xjc/MessageBundle_it.properties ! src/share/jaxws_classes/com/sun/tools/internal/xjc/MessageBundle_ja.properties ! src/share/jaxws_classes/com/sun/tools/internal/xjc/MessageBundle_ko.properties ! src/share/jaxws_classes/com/sun/tools/internal/xjc/MessageBundle_pt_BR.properties ! src/share/jaxws_classes/com/sun/tools/internal/xjc/MessageBundle_zh_CN.properties ! src/share/jaxws_classes/com/sun/tools/internal/xjc/MessageBundle_zh_TW.properties ! src/share/jaxws_classes/com/sun/tools/internal/xjc/SchemaCache.java ! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlAccessorOrderWriter.java ! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlAccessorTypeWriter.java ! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlAnyAttributeWriter.java ! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlAnyElementWriter.java ! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlAttachmentRefWriter.java ! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlAttributeWriter.java ! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlElementDeclWriter.java ! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlElementRefWriter.java ! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlElementRefsWriter.java ! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlElementWrapperWriter.java ! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlElementWriter.java ! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlElementsWriter.java ! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlEnumValueWriter.java ! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlEnumWriter.java ! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlIDREFWriter.java ! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlIDWriter.java ! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlInlineBinaryDataWriter.java ! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlJavaTypeAdapterWriter.java ! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlListWriter.java ! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlMimeTypeWriter.java ! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlMixedWriter.java ! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlNsWriter.java ! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlRegistryWriter.java ! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlRootElementWriter.java ! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlSchemaTypeWriter.java ! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlSchemaTypesWriter.java ! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlSchemaWriter.java ! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlSeeAlsoWriter.java ! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlTransientWriter.java ! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlTypeWriter.java ! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlValueWriter.java ! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/bean/MessageBundle.properties ! src/share/jaxws_classes/com/sun/tools/internal/xjc/model/CPropertyInfo.java ! src/share/jaxws_classes/com/sun/tools/internal/xjc/model/CTypeRef.java ! src/share/jaxws_classes/com/sun/tools/internal/xjc/model/package-info.java ! src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/internalizer/AbstractReferenceFinderImpl.java ! src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/internalizer/DOMForest.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/Util.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/Messages.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/Messages.properties ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/annotation/Init.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/annotation/XmlAttributeQuick.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/annotation/XmlElementDeclQuick.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/annotation/XmlElementQuick.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/annotation/XmlElementRefQuick.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/annotation/XmlElementRefsQuick.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/annotation/XmlEnumQuick.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/annotation/XmlRootElementQuick.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/annotation/XmlSchemaQuick.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/annotation/XmlSchemaTypeQuick.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/annotation/XmlTransientQuick.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/annotation/XmlTypeQuick.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/annotation/XmlValueQuick.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/core/package-info.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/impl/RuntimeBuiltinLeafInfoImpl.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/package-info.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/BridgeAdapter.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/Coordinator.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/XMLSerializer.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/reflect/PrimitiveArrayListerBoolean.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/reflect/PrimitiveArrayListerCharacter.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/reflect/PrimitiveArrayListerDouble.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/reflect/PrimitiveArrayListerFloat.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/reflect/PrimitiveArrayListerInteger.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/reflect/PrimitiveArrayListerLong.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/reflect/PrimitiveArrayListerShort.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/reflect/opt/FieldAccessor_Boolean.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/reflect/opt/FieldAccessor_Character.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/reflect/opt/FieldAccessor_Double.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/reflect/opt/FieldAccessor_Float.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/reflect/opt/FieldAccessor_Integer.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/reflect/opt/FieldAccessor_Long.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/reflect/opt/FieldAccessor_Short.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/reflect/opt/MethodAccessor_Boolean.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/reflect/opt/MethodAccessor_Character.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/reflect/opt/MethodAccessor_Double.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/reflect/opt/MethodAccessor_Float.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/reflect/opt/MethodAccessor_Integer.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/reflect/opt/MethodAccessor_Long.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/reflect/opt/MethodAccessor_Short.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/reflect/opt/TransducedAccessor_field_Double.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/reflect/opt/TransducedAccessor_field_Float.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/reflect/opt/TransducedAccessor_field_Long.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/reflect/opt/TransducedAccessor_field_Short.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/reflect/opt/TransducedAccessor_method_Boolean.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/reflect/opt/TransducedAccessor_method_Double.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/reflect/opt/TransducedAccessor_method_Float.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/reflect/opt/TransducedAccessor_method_Long.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/reflect/opt/TransducedAccessor_method_Short.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/unmarshaller/Loader.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/unmarshaller/Messages.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/unmarshaller/Messages.properties ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/unmarshaller/SAXConnector.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/unmarshaller/UnmarshallingContext.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/unmarshaller/XsiTypeLoader.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/Annotated.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/Annotation.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/Any.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/Appinfo.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/AttrDecls.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/AttributeType.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/ComplexContent.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/ComplexExtension.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/ComplexRestriction.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/ComplexType.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/ComplexTypeHost.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/ComplexTypeModel.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/Documentation.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/Element.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/ExplicitGroup.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/ExtensionType.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/FixedOrDefault.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/Import.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/List.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/LocalAttribute.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/LocalElement.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/NestedParticle.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/NoFixedFacet.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/Occurs.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/Redefinable.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/Schema.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/SchemaTop.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/SimpleContent.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/SimpleDerivation.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/SimpleExtension.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/SimpleRestriction.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/SimpleRestrictionModel.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/SimpleType.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/SimpleTypeHost.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/TopLevelAttribute.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/TopLevelElement.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/TypeDefParticle.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/TypeHost.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/Union.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/Wildcard.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/util/EditDistance.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/util/XmlFactory.java ! src/share/jaxws_classes/com/sun/xml/internal/dtdparser/DTDEventListener.java ! src/share/jaxws_classes/com/sun/xml/internal/dtdparser/DTDHandlerBase.java ! src/share/jaxws_classes/com/sun/xml/internal/dtdparser/DTDParser.java ! src/share/jaxws_classes/com/sun/xml/internal/dtdparser/EndOfInputException.java ! src/share/jaxws_classes/com/sun/xml/internal/dtdparser/EntityDecl.java ! src/share/jaxws_classes/com/sun/xml/internal/dtdparser/ExternalEntity.java ! src/share/jaxws_classes/com/sun/xml/internal/dtdparser/InputEntity.java ! src/share/jaxws_classes/com/sun/xml/internal/dtdparser/InternalEntity.java ! src/share/jaxws_classes/com/sun/xml/internal/dtdparser/MessageCatalog.java ! src/share/jaxws_classes/com/sun/xml/internal/dtdparser/Resolver.java ! src/share/jaxws_classes/com/sun/xml/internal/dtdparser/SimpleHashtable.java ! src/share/jaxws_classes/com/sun/xml/internal/dtdparser/XmlChars.java ! src/share/jaxws_classes/com/sun/xml/internal/dtdparser/XmlNames.java ! src/share/jaxws_classes/com/sun/xml/internal/dtdparser/XmlReader.java ! src/share/jaxws_classes/com/sun/xml/internal/dtdparser/package.html ! src/share/jaxws_classes/com/sun/xml/internal/dtdparser/resources/Messages.properties ! src/share/jaxws_classes/com/sun/xml/internal/stream/buffer/AbstractCreatorProcessor.java ! src/share/jaxws_classes/com/sun/xml/internal/stream/buffer/AbstractProcessor.java ! src/share/jaxws_classes/com/sun/xml/internal/stream/buffer/AttributesHolder.java ! src/share/jaxws_classes/com/sun/xml/internal/stream/buffer/FragmentedArray.java ! src/share/jaxws_classes/com/sun/xml/internal/stream/buffer/MutableXMLStreamBuffer.java ! src/share/jaxws_classes/com/sun/xml/internal/stream/buffer/XMLStreamBuffer.java ! src/share/jaxws_classes/com/sun/xml/internal/stream/buffer/XMLStreamBufferException.java ! src/share/jaxws_classes/com/sun/xml/internal/stream/buffer/XMLStreamBufferMark.java ! src/share/jaxws_classes/com/sun/xml/internal/stream/buffer/XMLStreamBufferResult.java ! src/share/jaxws_classes/com/sun/xml/internal/stream/buffer/XMLStreamBufferSource.java ! src/share/jaxws_classes/com/sun/xml/internal/stream/buffer/sax/DefaultWithLexicalHandler.java ! src/share/jaxws_classes/com/sun/xml/internal/stream/buffer/sax/Features.java ! src/share/jaxws_classes/com/sun/xml/internal/stream/buffer/sax/Properties.java ! src/share/jaxws_classes/com/sun/xml/internal/stream/buffer/sax/SAXBufferCreator.java ! src/share/jaxws_classes/com/sun/xml/internal/stream/buffer/stax/StreamBufferCreator.java ! src/share/jaxws_classes/com/sun/xml/internal/stream/buffer/stax/StreamReaderBufferCreator.java ! src/share/jaxws_classes/com/sun/xml/internal/stream/buffer/stax/StreamReaderBufferProcessor.java ! src/share/jaxws_classes/com/sun/xml/internal/stream/buffer/stax/StreamWriterBufferCreator.java ! src/share/jaxws_classes/com/sun/xml/internal/txw2/output/XMLWriter.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/api/message/Packet.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/api/server/Container.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/api/server/ThreadLocalContainerResolver.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/api/streaming/XMLStreamReaderFactory.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/api/wsdl/writer/WSDLGeneratorExtension.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/commons/xmlutil/Converter.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/encoding/MtomCodec.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/encoding/StreamSOAP11Codec.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/encoding/StreamSOAP12Codec.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/encoding/StreamSOAPCodec.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/encoding/TagInfoset.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/message/AbstractMessageImpl.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/message/jaxb/JAXBHeader.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/message/jaxb/JAXBMessage.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/message/saaj/SAAJMessage.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/message/stream/StreamMessage.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/resources/StreamingMessages.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/resources/streaming.properties ! src/share/jaxws_classes/com/sun/xml/internal/ws/server/SDDocumentImpl.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/spi/db/BindingContext.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/util/pipe/AbstractSchemaValidationTube.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/util/resources/Messages_en.properties ! src/share/jaxws_classes/com/sun/xml/internal/ws/util/version.properties ! src/share/jaxws_classes/com/sun/xml/internal/ws/util/xml/XmlUtil.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/writer/WSDLGenerator.java ! src/share/jaxws_classes/com/sun/xml/internal/xsom/impl/parser/Messages.java ! src/share/jaxws_classes/com/sun/xml/internal/xsom/impl/parser/Messages.properties ! src/share/jaxws_classes/com/sun/xml/internal/xsom/impl/parser/SAXParserFactoryAdaptor.java ! src/share/jaxws_classes/com/sun/xml/internal/xsom/impl/parser/state/Schema.java ! src/share/jaxws_classes/com/sun/xml/internal/xsom/impl/parser/state/SimpleType_List.java ! src/share/jaxws_classes/com/sun/xml/internal/xsom/impl/parser/state/SimpleType_Restriction.java ! src/share/jaxws_classes/com/sun/xml/internal/xsom/impl/parser/state/SimpleType_Union.java ! src/share/jaxws_classes/com/sun/xml/internal/xsom/impl/parser/state/annotation.java ! src/share/jaxws_classes/com/sun/xml/internal/xsom/impl/parser/state/attributeDeclBody.java ! src/share/jaxws_classes/com/sun/xml/internal/xsom/impl/parser/state/attributeGroupDecl.java ! src/share/jaxws_classes/com/sun/xml/internal/xsom/impl/parser/state/attributeUses.java ! src/share/jaxws_classes/com/sun/xml/internal/xsom/impl/parser/state/complexType.java ! src/share/jaxws_classes/com/sun/xml/internal/xsom/impl/parser/state/complexType_complexContent_body.java ! src/share/jaxws_classes/com/sun/xml/internal/xsom/impl/parser/state/elementDeclBody.java ! src/share/jaxws_classes/com/sun/xml/internal/xsom/impl/parser/state/erSet.java ! src/share/jaxws_classes/com/sun/xml/internal/xsom/impl/parser/state/ersSet.java ! src/share/jaxws_classes/com/sun/xml/internal/xsom/impl/parser/state/facet.java ! src/share/jaxws_classes/com/sun/xml/internal/xsom/impl/parser/state/group.java ! src/share/jaxws_classes/com/sun/xml/internal/xsom/impl/parser/state/identityConstraint.java ! src/share/jaxws_classes/com/sun/xml/internal/xsom/impl/parser/state/importDecl.java ! src/share/jaxws_classes/com/sun/xml/internal/xsom/impl/parser/state/includeDecl.java ! src/share/jaxws_classes/com/sun/xml/internal/xsom/impl/parser/state/modelGroupBody.java ! src/share/jaxws_classes/com/sun/xml/internal/xsom/impl/parser/state/notation.java ! src/share/jaxws_classes/com/sun/xml/internal/xsom/impl/parser/state/occurs.java ! src/share/jaxws_classes/com/sun/xml/internal/xsom/impl/parser/state/particle.java ! src/share/jaxws_classes/com/sun/xml/internal/xsom/impl/parser/state/qname.java ! src/share/jaxws_classes/com/sun/xml/internal/xsom/impl/parser/state/redefine.java ! src/share/jaxws_classes/com/sun/xml/internal/xsom/impl/parser/state/simpleType.java ! src/share/jaxws_classes/com/sun/xml/internal/xsom/impl/parser/state/wildcardBody.java ! src/share/jaxws_classes/com/sun/xml/internal/xsom/impl/parser/state/xpath.java ! src/share/jaxws_classes/com/sun/xml/internal/xsom/parser/JAXPParser.java ! src/share/jaxws_classes/com/sun/xml/internal/xsom/parser/XSOMParser.java ! src/share/jaxws_classes/com/sun/xml/internal/xsom/util/DomAnnotationParserFactory.java ! src/share/jaxws_classes/javax/xml/bind/Binder.java ! src/share/jaxws_classes/javax/xml/bind/ContextFinder.java ! src/share/jaxws_classes/javax/xml/bind/DataBindingException.java ! src/share/jaxws_classes/javax/xml/bind/DatatypeConverter.java ! src/share/jaxws_classes/javax/xml/bind/DatatypeConverterImpl.java ! src/share/jaxws_classes/javax/xml/bind/DatatypeConverterInterface.java ! src/share/jaxws_classes/javax/xml/bind/Element.java ! src/share/jaxws_classes/javax/xml/bind/GetPropertyAction.java ! src/share/jaxws_classes/javax/xml/bind/JAXB.java ! src/share/jaxws_classes/javax/xml/bind/JAXBContext.java ! src/share/jaxws_classes/javax/xml/bind/JAXBElement.java ! src/share/jaxws_classes/javax/xml/bind/JAXBException.java ! src/share/jaxws_classes/javax/xml/bind/JAXBIntrospector.java ! src/share/jaxws_classes/javax/xml/bind/JAXBPermission.java ! src/share/jaxws_classes/javax/xml/bind/MarshalException.java ! src/share/jaxws_classes/javax/xml/bind/Messages.java ! src/share/jaxws_classes/javax/xml/bind/Messages.properties ! src/share/jaxws_classes/javax/xml/bind/NotIdentifiableEvent.java ! src/share/jaxws_classes/javax/xml/bind/ParseConversionEvent.java ! src/share/jaxws_classes/javax/xml/bind/PrintConversionEvent.java ! src/share/jaxws_classes/javax/xml/bind/PropertyException.java ! src/share/jaxws_classes/javax/xml/bind/SchemaOutputResolver.java ! src/share/jaxws_classes/javax/xml/bind/TypeConstraintException.java ! src/share/jaxws_classes/javax/xml/bind/UnmarshalException.java ! src/share/jaxws_classes/javax/xml/bind/Unmarshaller.java ! src/share/jaxws_classes/javax/xml/bind/UnmarshallerHandler.java ! src/share/jaxws_classes/javax/xml/bind/ValidationEvent.java ! src/share/jaxws_classes/javax/xml/bind/ValidationEventHandler.java ! src/share/jaxws_classes/javax/xml/bind/ValidationEventLocator.java ! src/share/jaxws_classes/javax/xml/bind/ValidationException.java ! src/share/jaxws_classes/javax/xml/bind/Validator.java ! src/share/jaxws_classes/javax/xml/bind/WhiteSpaceProcessor.java ! src/share/jaxws_classes/javax/xml/bind/annotation/DomHandler.java ! src/share/jaxws_classes/javax/xml/bind/annotation/W3CDomHandler.java ! src/share/jaxws_classes/javax/xml/bind/annotation/XmlAccessOrder.java ! src/share/jaxws_classes/javax/xml/bind/annotation/XmlAccessType.java ! src/share/jaxws_classes/javax/xml/bind/annotation/XmlAccessorOrder.java ! src/share/jaxws_classes/javax/xml/bind/annotation/XmlAccessorType.java ! src/share/jaxws_classes/javax/xml/bind/annotation/XmlAnyAttribute.java ! src/share/jaxws_classes/javax/xml/bind/annotation/XmlAnyElement.java ! src/share/jaxws_classes/javax/xml/bind/annotation/XmlAttachmentRef.java ! src/share/jaxws_classes/javax/xml/bind/annotation/XmlAttribute.java ! src/share/jaxws_classes/javax/xml/bind/annotation/XmlElement.java ! src/share/jaxws_classes/javax/xml/bind/annotation/XmlElementDecl.java ! src/share/jaxws_classes/javax/xml/bind/annotation/XmlElementRef.java ! src/share/jaxws_classes/javax/xml/bind/annotation/XmlElementRefs.java ! src/share/jaxws_classes/javax/xml/bind/annotation/XmlElementWrapper.java ! src/share/jaxws_classes/javax/xml/bind/annotation/XmlElements.java ! src/share/jaxws_classes/javax/xml/bind/annotation/XmlEnum.java ! src/share/jaxws_classes/javax/xml/bind/annotation/XmlEnumValue.java ! src/share/jaxws_classes/javax/xml/bind/annotation/XmlID.java ! src/share/jaxws_classes/javax/xml/bind/annotation/XmlIDREF.java ! src/share/jaxws_classes/javax/xml/bind/annotation/XmlList.java ! src/share/jaxws_classes/javax/xml/bind/annotation/XmlMixed.java ! src/share/jaxws_classes/javax/xml/bind/annotation/XmlNs.java ! src/share/jaxws_classes/javax/xml/bind/annotation/XmlNsForm.java ! src/share/jaxws_classes/javax/xml/bind/annotation/XmlRegistry.java ! src/share/jaxws_classes/javax/xml/bind/annotation/XmlRootElement.java ! src/share/jaxws_classes/javax/xml/bind/annotation/XmlSchema.java ! src/share/jaxws_classes/javax/xml/bind/annotation/XmlSchemaType.java ! src/share/jaxws_classes/javax/xml/bind/annotation/XmlSchemaTypes.java ! src/share/jaxws_classes/javax/xml/bind/annotation/XmlSeeAlso.java ! src/share/jaxws_classes/javax/xml/bind/annotation/XmlTransient.java ! src/share/jaxws_classes/javax/xml/bind/annotation/XmlType.java ! src/share/jaxws_classes/javax/xml/bind/annotation/XmlValue.java ! src/share/jaxws_classes/javax/xml/bind/annotation/adapters/CollapsedStringAdapter.java ! src/share/jaxws_classes/javax/xml/bind/annotation/adapters/HexBinaryAdapter.java ! src/share/jaxws_classes/javax/xml/bind/annotation/adapters/NormalizedStringAdapter.java ! src/share/jaxws_classes/javax/xml/bind/annotation/adapters/XmlJavaTypeAdapter.java ! src/share/jaxws_classes/javax/xml/bind/annotation/adapters/XmlJavaTypeAdapters.java ! src/share/jaxws_classes/javax/xml/bind/annotation/adapters/package.html ! src/share/jaxws_classes/javax/xml/bind/annotation/package.html ! src/share/jaxws_classes/javax/xml/bind/attachment/AttachmentMarshaller.java ! src/share/jaxws_classes/javax/xml/bind/attachment/AttachmentUnmarshaller.java ! src/share/jaxws_classes/javax/xml/bind/attachment/package.html ! src/share/jaxws_classes/javax/xml/bind/helpers/AbstractMarshallerImpl.java ! src/share/jaxws_classes/javax/xml/bind/helpers/AbstractUnmarshallerImpl.java ! src/share/jaxws_classes/javax/xml/bind/helpers/DefaultValidationEventHandler.java ! src/share/jaxws_classes/javax/xml/bind/helpers/Messages.java ! src/share/jaxws_classes/javax/xml/bind/helpers/Messages.properties ! src/share/jaxws_classes/javax/xml/bind/helpers/NotIdentifiableEventImpl.java ! src/share/jaxws_classes/javax/xml/bind/helpers/ParseConversionEventImpl.java ! src/share/jaxws_classes/javax/xml/bind/helpers/PrintConversionEventImpl.java ! src/share/jaxws_classes/javax/xml/bind/helpers/ValidationEventImpl.java ! src/share/jaxws_classes/javax/xml/bind/helpers/ValidationEventLocatorImpl.java ! src/share/jaxws_classes/javax/xml/bind/helpers/package.html ! src/share/jaxws_classes/javax/xml/bind/package.html ! src/share/jaxws_classes/javax/xml/bind/util/JAXBResult.java ! src/share/jaxws_classes/javax/xml/bind/util/JAXBSource.java ! src/share/jaxws_classes/javax/xml/bind/util/Messages.java ! src/share/jaxws_classes/javax/xml/bind/util/Messages.properties ! src/share/jaxws_classes/javax/xml/bind/util/ValidationEventCollector.java ! src/share/jaxws_classes/javax/xml/bind/util/package.html From chris.hegarty at oracle.com Fri Aug 23 03:11:40 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Fri, 23 Aug 2013 10:11:40 +0000 Subject: hg: jdk8/tl/jaxws: 8023636: Missing files from 8022885 Message-ID: <20130823101142.65C0348AF4@hg.openjdk.java.net> Changeset: d8593d8581df Author: mkos Date: 2013-08-23 11:10 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/d8593d8581df 8023636: Missing files from 8022885 Reviewed-by: alanb, chegar + src/share/jaxws_classes/com/sun/xml/internal/ws/api/message/StreamingSOAP.java + src/share/jaxws_classes/com/sun/xml/internal/ws/util/xml/NamespaceContextExAdaper.java + src/share/jaxws_classes/com/sun/xml/internal/ws/util/xml/XMLReaderComposite.java From sundararajan.athijegannathan at oracle.com Fri Aug 23 05:39:40 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Fri, 23 Aug 2013 12:39:40 +0000 Subject: hg: jdk8/tl/nashorn: 12 new changesets Message-ID: <20130823123951.C054048AFE@hg.openjdk.java.net> Changeset: dbb0a20a6f27 Author: attila Date: 2013-08-21 13:39 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/dbb0a20a6f27 8023373: allow super invocation for adapters Reviewed-by: lagergren, sundar ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterBytecodeGenerator.java + test/script/basic/JDK-8023373.js + test/script/basic/JDK-8023373.js.EXPECTED Changeset: dc322503ce36 Author: attila Date: 2013-08-21 13:39 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/dc322503ce36 8022903: Enhance for-in and for-each for Lists and Maps Reviewed-by: lagergren, sundar ! src/jdk/nashorn/internal/runtime/ScriptRuntime.java + test/script/basic/JDK-8022903.js + test/script/basic/JDK-8022903.js.EXPECTED Changeset: b7c04b3b01a7 Author: sundar Date: 2013-08-21 17:28 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/b7c04b3b01a7 8023368: Instance __proto__ property should exist and be writable. Reviewed-by: attila, hannesw ! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java ! src/jdk/nashorn/internal/objects/NativeObject.java ! src/jdk/nashorn/internal/runtime/PropertyListener.java ! src/jdk/nashorn/internal/runtime/PropertyListenerManager.java ! src/jdk/nashorn/internal/runtime/PropertyMap.java ! src/jdk/nashorn/internal/runtime/ScriptEnvironment.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/resources/Messages.properties ! src/jdk/nashorn/internal/runtime/resources/Options.properties ! src/jdk/nashorn/internal/runtime/resources/mozilla_compat.js + test/script/basic/JDK-8023368.js + test/script/basic/JDK-8023368.js.EXPECTED + test/script/basic/JDK-8023368_2.js + test/script/basic/JDK-8023368_2.js.EXPECTED + test/script/basic/circular_proto.js + test/script/basic/circular_proto.js.EXPECTED + test/script/basic/mirror_proto_assign.js + test/script/basic/mirror_proto_assign.js.EXPECTED + test/script/basic/nonextensible_proto_assign.js + test/script/basic/nonextensible_proto_assign.js.EXPECTED Changeset: 54f60d91024c Author: sundar Date: 2013-08-22 18:46 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/54f60d91024c 8023551: Mirror functions can not be invoked using invokeMethod, invokeFunction Reviewed-by: attila, jlaskey, lagergren ! src/jdk/nashorn/api/scripting/NashornScriptEngine.java ! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java + test/script/basic/JDK-8023551.js + test/script/basic/JDK-8023551.js.EXPECTED ! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java Changeset: 8ad9bcb04e6d Author: hannesw Date: 2013-08-22 17:23 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/8ad9bcb04e6d 8023531: new RegExp('').toString() should return '/(?:)/' Reviewed-by: sundar, jlaskey ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/WithObject.java ! src/jdk/nashorn/internal/runtime/regexp/RegExp.java + test/script/basic/JDK-8023531.js Changeset: c5c5ab3f420a Author: jlaskey Date: 2013-08-22 13:51 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/c5c5ab3f420a 8023228: Debugger information gather is too slow. Reviewed-by: sundar, lagergren Contributed-by: james.laskey at oracle.com ! src/jdk/nashorn/internal/runtime/Context.java + src/jdk/nashorn/internal/runtime/DebuggerSupport.java Changeset: 5a1e07b9a3cd Author: sundar Date: 2013-08-22 22:32 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/5a1e07b9a3cd 8023560: Arbitrary javax.script.Bindings objects as ENGINE_SCOPE objects are not handled as expected. Reviewed-by: jlaskey, lagergren, hannesw ! src/jdk/nashorn/api/scripting/NashornScriptEngine.java ! src/jdk/nashorn/internal/runtime/ScriptEnvironment.java ! src/jdk/nashorn/internal/runtime/resources/Options.properties ! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java ! test/src/jdk/nashorn/internal/runtime/TrustedScriptEngineTest.java Changeset: d82ac93aa55c Author: sundar Date: 2013-08-23 16:10 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/d82ac93aa55c 8023631: engine.js init script should be loaded into every global instance created by engines Reviewed-by: attila, hannesw ! src/jdk/nashorn/api/scripting/NashornScriptEngine.java ! src/jdk/nashorn/api/scripting/resources/engine.js + test/src/jdk/nashorn/api/scripting/InvocableTest.java + test/src/jdk/nashorn/api/scripting/ScopeTest.java ! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java + test/src/jdk/nashorn/api/scripting/ScriptObjectMirrorTest.java Changeset: 6b6a8fc714a9 Author: lagergren Date: 2013-08-23 12:43 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/6b6a8fc714a9 8023453: --log=attr did not unindent identNodes Reviewed-by: attila, jlaskey ! src/jdk/nashorn/internal/codegen/Attr.java Changeset: 4dcd5a22fdd3 Author: lagergren Date: 2013-08-23 12:44 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/4dcd5a22fdd3 Merge Changeset: f18f2ce1b2dc Author: attila Date: 2013-08-23 13:10 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/f18f2ce1b2dc 8023630: Implement Java.super() as the preferred way to call super methods Reviewed-by: jlaskey, lagergren, sundar ! src/jdk/nashorn/internal/objects/NativeJava.java ! src/jdk/nashorn/internal/runtime/JSType.java ! src/jdk/nashorn/internal/runtime/linker/Bootstrap.java ! src/jdk/nashorn/internal/runtime/linker/BoundDynamicMethodLinker.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterBytecodeGenerator.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterClassLoader.java + src/jdk/nashorn/internal/runtime/linker/JavaSuperAdapter.java + src/jdk/nashorn/internal/runtime/linker/JavaSuperAdapterLinker.java + test/script/basic/JDK-8023630.js + test/script/basic/JDK-8023630.js.EXPECTED ! test/script/basic/NASHORN-397.js Changeset: 2ce55025a37d Author: sundar Date: 2013-08-23 16:44 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/2ce55025a37d Merge From daniel.fuchs at oracle.com Fri Aug 23 12:02:10 2013 From: daniel.fuchs at oracle.com (daniel.fuchs at oracle.com) Date: Fri, 23 Aug 2013 19:02:10 +0000 Subject: hg: jdk8/tl/jdk: 8005899: Logger.getLogger(name, null) should not allow to reset a non-null resource bundle Message-ID: <20130823190232.AE95C48B16@hg.openjdk.java.net> Changeset: 4ef82445ea20 Author: dfuchs Date: 2013-08-23 20:59 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4ef82445ea20 8005899: Logger.getLogger(name, null) should not allow to reset a non-null resource bundle Reviewed-by: mchung, lancea ! src/share/classes/java/util/logging/Logger.java + test/java/util/logging/Logger/getLogger/TestLogger.java + test/java/util/logging/Logger/getLogger/testlogger/MyResource.java From alex.buckley at oracle.com Fri Aug 23 15:18:40 2013 From: alex.buckley at oracle.com (Alex Buckley) Date: Fri, 23 Aug 2013 15:18:40 -0700 Subject: Unchecked conversion and super raw type In-Reply-To: <5167E101.4080507@oracle.com> References: <5167E101.4080507@oracle.com> Message-ID: <5217DFC0.4040809@oracle.com> I am happy to report that JLS7 makes foo(A) applicable by method invocation conversion (15.12.2.3), so javac is right to report an ambiguity. Method invocation conversion allows B to undergo a widening reference conversion to A, because B's direct supertype is A; and then, because A is a raw type, an unchecked conversion may be applied from A to A. Alex On 4/12/2013 3:25 AM, Maurizio Cimadamore wrote: > The spec is saying: > > "The method m is applicable by subtyping if and only if both of the > following conditions hold: > > For 1 ? i ? n, either: > > Ai <: Si (?4.10), or > > Ai is convertible to some type Ci by unchecked conversion (?5.1.9), and > Ci <: Si." > > > And I agree this seems to be a spec problem - there's no unchecked > conversion for going from B to A, as unchecked conversion > requires that source bases type and target nbae type are the same - in > this case we have that B != A so no unchecked conversion applies. > > However, javac (and Eclipse) implement a relaxed check; for example, > javac is happy whenever it can find a supertype of the LHS type that > matches the base type of the RHS. Which in this case is satisfied. > > Maurizio > > > On 11/04/13 23:40, Zhong Yu wrote: >> >> >> >> On Thu, Apr 11, 2013 at 5:10 PM, Zhong Yu > > wrote: >> >> Consider this example: >> >> public class Test >> { >> static class A {} >> >> static class B extends A {} >> >> void foo(A a) {} >> >> void foo(B b) {} >> >> void test() >> { >> B b = new B(); >> foo(b); // error: reference to foo is ambiguous >> } >> } >> >> For the method invocation expression `foo(b)`, method `foo(B)` is >> applicable by subtyping. However is that also true for >> `foo(A)`? By the letter of the spec, we cannot find a Ci >> such that "B" is convertible to Ci by unchecked conversion and Ci >> <: A. So my understanding is that `foo(A)` is not >> applicable to `foo(b)` by subtyping, and the code should compile >> since only one applicable method is found during "15.12.2.2. Phase 1" >> >> >> >> Or, is this a bug of the spec? Maybe the spec intends to say >> >> For 1 ? /i/ ? /n/, either: >> >> * >> >> A_i |<:| S_i (?4.10 >> ), >> or >> >> * >> >> A_i |<:| |S_i | >> >> The second clause is for the legacy code that saw a non-generic method >> parameter type. >> >> Zhong Yu >> > From alex.buckley at oracle.com Fri Aug 23 15:46:25 2013 From: alex.buckley at oracle.com (Alex Buckley) Date: Fri, 23 Aug 2013 15:46:25 -0700 Subject: Unchecked conversion and super raw type In-Reply-To: <5217DFC0.4040809@oracle.com> References: <5167E101.4080507@oracle.com> <5217DFC0.4040809@oracle.com> Message-ID: <5217E641.60508@oracle.com> On second thoughts, this is a complicated mess. foo(B) is applicable by subtyping and foo(A) isn't. Since at least one method is applicable by subtyping, overload resolution should stop and foo(B) should be selected. If overload resolution was to proceed to applicability by method invocation conversion, it would find that foo(A) is applicable (as described earlier) and also that foo(B) is applicable (identity conversion) - but it's not meant to proceed! So, javac is wrong to give an ambiguity. Or is it? In the pre-generics world - static class A {} ... void foo(A a) ... - JLS2 would have said that "foo(b)" was ambiguous because foo(A) and foo(B) were both applicable by method invocation conversion. Generifying the declaration of class A and parameterizing the formal parameter type A should not change that. And so, JLS3's two-stage applicability testing is inaccurate when it chooses foo(B) as The Answer. Perhaps if I had a complete description of javac's overload resolution rules, I could make 15.12.2 reflect what really happens. Or maybe this whole idea of "migration compatibility" is just too hard. Alex On 8/23/2013 3:18 PM, Alex Buckley wrote: > I am happy to report that JLS7 makes foo(A) applicable by method > invocation conversion (15.12.2.3), so javac is right to report an > ambiguity. > > Method invocation conversion allows B to undergo a widening reference > conversion to A, because B's direct supertype is A; and then, because A > is a raw type, an unchecked conversion may be applied from A to A. > > Alex > > On 4/12/2013 3:25 AM, Maurizio Cimadamore wrote: >> The spec is saying: >> >> "The method m is applicable by subtyping if and only if both of the >> following conditions hold: >> >> For 1 ? i ? n, either: >> >> Ai <: Si (?4.10), or >> >> Ai is convertible to some type Ci by unchecked conversion (?5.1.9), and >> Ci <: Si." >> >> >> And I agree this seems to be a spec problem - there's no unchecked >> conversion for going from B to A, as unchecked conversion >> requires that source bases type and target nbae type are the same - in >> this case we have that B != A so no unchecked conversion applies. >> >> However, javac (and Eclipse) implement a relaxed check; for example, >> javac is happy whenever it can find a supertype of the LHS type that >> matches the base type of the RHS. Which in this case is satisfied. >> >> Maurizio >> >> >> On 11/04/13 23:40, Zhong Yu wrote: >>> >>> >>> >>> On Thu, Apr 11, 2013 at 5:10 PM, Zhong Yu >> > wrote: >>> >>> Consider this example: >>> >>> public class Test >>> { >>> static class A {} >>> >>> static class B extends A {} >>> >>> void foo(A a) {} >>> >>> void foo(B b) {} >>> >>> void test() >>> { >>> B b = new B(); >>> foo(b); // error: reference to foo is ambiguous >>> } >>> } >>> >>> For the method invocation expression `foo(b)`, method `foo(B)` is >>> applicable by subtyping. However is that also true for >>> `foo(A)`? By the letter of the spec, we cannot find a Ci >>> such that "B" is convertible to Ci by unchecked conversion and Ci >>> <: A. So my understanding is that `foo(A)` is not >>> applicable to `foo(b)` by subtyping, and the code should compile >>> since only one applicable method is found during "15.12.2.2. >>> Phase 1" >>> >>> >>> >>> Or, is this a bug of the spec? Maybe the spec intends to say >>> >>> For 1 ? /i/ ? /n/, either: >>> >>> * >>> >>> A_i |<:| S_i (?4.10 >>> >>> ), >>> or >>> >>> * >>> >>> A_i |<:| |S_i | >>> >>> The second clause is for the legacy code that saw a non-generic method >>> parameter type. >>> >>> Zhong Yu >>> >> From zhong.j.yu at gmail.com Fri Aug 23 23:12:07 2013 From: zhong.j.yu at gmail.com (Zhong Yu) Date: Sat, 24 Aug 2013 01:12:07 -0500 Subject: Unchecked conversion and super raw type In-Reply-To: <5217E641.60508@oracle.com> References: <5167E101.4080507@oracle.com> <5217DFC0.4040809@oracle.com> <5217E641.60508@oracle.com> Message-ID: On Fri, Aug 23, 2013 at 5:46 PM, Alex Buckley wrote: > On second thoughts, this is a complicated mess. > > foo(B) is applicable by subtyping and foo(A) isn't. Since at least > one method is applicable by subtyping, overload resolution should stop and > foo(B) should be selected. > > If overload resolution was to proceed to applicability by method invocation > conversion, it would find that foo(A) is applicable (as described > earlier) and also that foo(B) is applicable (identity conversion) - but it's > not meant to proceed! So the conflict is that m2 is more specific than m1, yet m1 is "more applicable" than m2, in the sense that m1 belongs to the 1st kind of applicable methods. This is confusing to average programmers who probably aren't aware that there are different kinds of applicable methods. It might have been easier to consider all applicable methods indiscriminately. > > So, javac is wrong to give an ambiguity. Or is it? In the pre-generics world > - static class A {} ... void foo(A a) ... - JLS2 would have said that > "foo(b)" was ambiguous because foo(A) and foo(B) were both applicable by > method invocation conversion. Generifying the declaration of class A and > parameterizing the formal parameter type A should not change that. And so, > JLS3's two-stage applicability testing is inaccurate when it chooses foo(B) > as The Answer. > > Perhaps if I had a complete description of javac's overload resolution > rules, I could make 15.12.2 reflect what really happens. Or maybe this whole > idea of "migration compatibility" is just too hard. > > Alex > > > On 8/23/2013 3:18 PM, Alex Buckley wrote: >> >> I am happy to report that JLS7 makes foo(A) applicable by method >> invocation conversion (15.12.2.3), so javac is right to report an >> ambiguity. >> >> Method invocation conversion allows B to undergo a widening reference >> conversion to A, because B's direct supertype is A; and then, because A >> is a raw type, an unchecked conversion may be applied from A to A. >> >> Alex >> >> On 4/12/2013 3:25 AM, Maurizio Cimadamore wrote: >>> >>> The spec is saying: >>> >>> "The method m is applicable by subtyping if and only if both of the >>> following conditions hold: >>> >>> For 1 ? i ? n, either: >>> >>> Ai <: Si (?4.10), or >>> >>> Ai is convertible to some type Ci by unchecked conversion (?5.1.9), and >>> Ci <: Si." >>> >>> >>> And I agree this seems to be a spec problem - there's no unchecked >>> conversion for going from B to A, as unchecked conversion >>> requires that source bases type and target nbae type are the same - in >>> this case we have that B != A so no unchecked conversion applies. >>> >>> However, javac (and Eclipse) implement a relaxed check; for example, >>> javac is happy whenever it can find a supertype of the LHS type that >>> matches the base type of the RHS. Which in this case is satisfied. >>> >>> Maurizio >>> >>> >>> On 11/04/13 23:40, Zhong Yu wrote: >>>> >>>> >>>> >>>> >>>> On Thu, Apr 11, 2013 at 5:10 PM, Zhong Yu >>> > wrote: >>>> >>>> Consider this example: >>>> >>>> public class Test >>>> { >>>> static class A {} >>>> >>>> static class B extends A {} >>>> >>>> void foo(A a) {} >>>> >>>> void foo(B b) {} >>>> >>>> void test() >>>> { >>>> B b = new B(); >>>> foo(b); // error: reference to foo is ambiguous >>>> } >>>> } >>>> >>>> For the method invocation expression `foo(b)`, method `foo(B)` is >>>> applicable by subtyping. However is that also true for >>>> `foo(A)`? By the letter of the spec, we cannot find a Ci >>>> such that "B" is convertible to Ci by unchecked conversion and Ci >>>> <: A. So my understanding is that `foo(A)` is not >>>> applicable to `foo(b)` by subtyping, and the code should compile >>>> since only one applicable method is found during "15.12.2.2. >>>> Phase 1" >>>> >>>> >>>> >>>> Or, is this a bug of the spec? Maybe the spec intends to say >>>> >>>> For 1 ? /i/ ? /n/, either: >>>> >>>> * >>>> >>>> A_i |<:| S_i (?4.10 >>>> >>>> ), >>>> or >>>> >>>> * >>>> >>>> A_i |<:| |S_i | >>>> >>>> The second clause is for the legacy code that saw a non-generic method >>>> parameter type. >>>> >>>> Zhong Yu >>>> >>> > From alan.bateman at oracle.com Sat Aug 24 13:11:53 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Sat, 24 Aug 2013 20:11:53 +0000 Subject: hg: jdk8/tl/jdk: 6378503: In java.math.BigDecimal, division by one returns zero; ... Message-ID: <20130824201246.F01CE48B32@hg.openjdk.java.net> Changeset: 216a4b93cee8 Author: bpb Date: 2013-08-23 14:15 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/216a4b93cee8 6378503: In java.math.BigDecimal, division by one returns zero 6446965: Using BigDecimal.divideToIntegralValue with extreme scales can lead to an incorrect result Summary: Fix overflow of ints and ensure appropriate values passed to checkScaleNonZero() Reviewed-by: darcy, martin Contributed-by: Brian Burkhalter ! src/share/classes/java/math/BigDecimal.java ! src/share/classes/java/math/BigInteger.java ! test/java/math/BigDecimal/IntegralDivisionTests.java From alan.bateman at oracle.com Mon Aug 26 02:04:09 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Mon, 26 Aug 2013 09:04:09 +0000 Subject: hg: jdk8/tl/jdk: 8023139: java/nio/file/WatchService/SensitivityModifier.java failing intermittently (win8) Message-ID: <20130826090449.47C6448B54@hg.openjdk.java.net> Changeset: 0ee3b995d63b Author: alanb Date: 2013-08-26 10:01 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0ee3b995d63b 8023139: java/nio/file/WatchService/SensitivityModifier.java failing intermittently (win8) Reviewed-by: alanb Contributed-by: yiming.wang at oracle.com ! test/java/nio/file/WatchService/SensitivityModifier.java From alan.bateman at oracle.com Mon Aug 26 03:35:06 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Mon, 26 Aug 2013 10:35:06 +0000 Subject: hg: jdk8/tl/jdk: 7129312: BufferedInputStream calculates negative array size with large streams and mark Message-ID: <20130826103531.1189748B56@hg.openjdk.java.net> Changeset: 67a1a031876a Author: igerasim Date: 2013-08-25 23:20 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/67a1a031876a 7129312: BufferedInputStream calculates negative array size with large streams and mark Reviewed-by: alanb ! src/share/classes/java/io/BufferedInputStream.java + test/java/io/BufferedInputStream/LargeCopyWithMark.java From joel.franck at oracle.com Mon Aug 26 04:47:46 2013 From: joel.franck at oracle.com (joel.franck at oracle.com) Date: Mon, 26 Aug 2013 11:47:46 +0000 Subject: hg: jdk8/tl/jdk: 8022343: j.l.Class.getAnnotatedSuperclass() doesn't return null in some cases Message-ID: <20130826114801.4A35F48B59@hg.openjdk.java.net> Changeset: 6917c114b197 Author: jfranck Date: 2013-08-26 13:38 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6917c114b197 8022343: j.l.Class.getAnnotatedSuperclass() doesn't return null in some cases Reviewed-by: darcy, vromero, psandoz ! src/share/classes/java/lang/Class.java ! test/java/lang/annotation/TypeAnnotationReflection.java + test/java/lang/annotation/typeAnnotations/GetAnnotatedSuperclass.java From paul.sandoz at oracle.com Mon Aug 26 07:20:29 2013 From: paul.sandoz at oracle.com (paul.sandoz at oracle.com) Date: Mon, 26 Aug 2013 14:20:29 +0000 Subject: hg: jdk8/tl/jdk: 8023234: StampedLock serializes readers on writer unlock Message-ID: <20130826142104.159D148B60@hg.openjdk.java.net> Changeset: 8a36fc7f494c Author: shade Date: 2013-08-26 17:50 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8a36fc7f494c 8023234: StampedLock serializes readers on writer unlock Summary: Sync-up the fix from jsr166 CVS, signal more readers on writer unlock Reviewed-by: martin, shade Contributed-by: Doug Lea
! src/share/classes/java/util/concurrent/locks/StampedLock.java + test/java/util/concurrent/locks/StampedLock/ReadersUnlockAfterWriteUnlock.java From roger.riggs at oracle.com Mon Aug 26 09:00:48 2013 From: roger.riggs at oracle.com (roger.riggs at oracle.com) Date: Mon, 26 Aug 2013 16:00:48 +0000 Subject: hg: jdk8/tl/jdk: 8011944: Sort fails with ArrayIndexOutOfBoundsException Message-ID: <20130826160109.BC73D48B69@hg.openjdk.java.net> Changeset: 07585a2483fa Author: rriggs Date: 2013-08-26 11:46 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/07585a2483fa 8011944: Sort fails with ArrayIndexOutOfBoundsException Summary: Increase the size of pending stack and add test cases Reviewed-by: alanb ! src/share/classes/java/util/ComparableTimSort.java ! src/share/classes/java/util/TimSort.java + test/java/util/Arrays/TimSortStackSize.java From sean.coffey at oracle.com Mon Aug 26 10:34:36 2013 From: sean.coffey at oracle.com (sean.coffey at oracle.com) Date: Mon, 26 Aug 2013 17:34:36 +0000 Subject: hg: jdk8/tl/jdk: 8016018: Typo in AbstractStringBuilder#indexOf and #lastIndexOf descriptions Message-ID: <20130826173447.BBEA048B6F@hg.openjdk.java.net> Changeset: 92a66af7f834 Author: igerasim Date: 2013-08-26 18:26 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/92a66af7f834 8016018: Typo in AbstractStringBuilder#indexOf and #lastIndexOf descriptions Reviewed-by: alanb, chegar ! src/share/classes/java/lang/AbstractStringBuilder.java From mike.duigou at oracle.com Mon Aug 26 11:38:22 2013 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Mon, 26 Aug 2013 18:38:22 +0000 Subject: hg: jdk8/tl: 8023491: Remove target names from test/Makefile and defer to sub-repo makefiles. Message-ID: <20130826183822.7C91C48B79@hg.openjdk.java.net> Changeset: f643fee2b40f Author: mduigou Date: 2013-08-26 10:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/f643fee2b40f 8023491: Remove target names from test/Makefile and defer to sub-repo makefiles. Reviewed-by: erikj ! common/makefiles/Main.gmk ! test/Makefile From jonathan.gibbons at oracle.com Mon Aug 26 11:49:13 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Mon, 26 Aug 2013 18:49:13 +0000 Subject: hg: jdk8/tl/langtools: 8023701: Fix badly named test Message-ID: <20130826184916.B9D5B48B7B@hg.openjdk.java.net> Changeset: 60f156c653d3 Author: jjg Date: 2013-08-26 11:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/60f156c653d3 8023701: Fix badly named test Reviewed-by: bpatel - test/com/sun/javadoc/testNavagation/TestNavagation.java - test/com/sun/javadoc/testNavagation/pkg/A.java - test/com/sun/javadoc/testNavagation/pkg/C.java - test/com/sun/javadoc/testNavagation/pkg/E.java - test/com/sun/javadoc/testNavagation/pkg/I.java + test/com/sun/javadoc/testNavigation/TestNavigation.java + test/com/sun/javadoc/testNavigation/pkg/A.java + test/com/sun/javadoc/testNavigation/pkg/C.java + test/com/sun/javadoc/testNavigation/pkg/E.java + test/com/sun/javadoc/testNavigation/pkg/I.java From paul.sandoz at oracle.com Mon Aug 26 13:55:36 2013 From: paul.sandoz at oracle.com (paul.sandoz at oracle.com) Date: Mon, 26 Aug 2013 20:55:36 +0000 Subject: hg: jdk8/tl/jdk: 8020292: j.u.SplittableRandom Message-ID: <20130826205600.268B448B83@hg.openjdk.java.net> Changeset: 5ce9025c9e1a Author: psandoz Date: 2013-08-26 22:55 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5ce9025c9e1a 8020292: j.u.SplittableRandom Reviewed-by: mduigou Contributed-by: Guy Steele , Doug Lea
, Brian Goetz , Paul Sandoz + src/share/classes/java/util/SplittableRandom.java + test/java/util/SplittableRandom/SplittableRandomTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/SplittableRandomTest.java From henry.jen at oracle.com Mon Aug 26 15:20:16 2013 From: henry.jen at oracle.com (henry.jen at oracle.com) Date: Mon, 26 Aug 2013 22:20:16 +0000 Subject: hg: jdk8/tl/jdk: 8023681: Fix raw type warning caused by Sink Message-ID: <20130826222042.C71A848B87@hg.openjdk.java.net> Changeset: 35c1609d9488 Author: henryjen Date: 2013-08-09 09:05 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/35c1609d9488 8023681: Fix raw type warning caused by Sink Reviewed-by: mduigou, briangoetz ! src/share/classes/java/util/stream/Collectors.java ! src/share/classes/java/util/stream/DistinctOps.java ! src/share/classes/java/util/stream/DoublePipeline.java ! src/share/classes/java/util/stream/IntPipeline.java ! src/share/classes/java/util/stream/LongPipeline.java ! src/share/classes/java/util/stream/ReferencePipeline.java ! src/share/classes/java/util/stream/Sink.java ! src/share/classes/java/util/stream/SliceOps.java ! src/share/classes/java/util/stream/SortedOps.java From jonathan.gibbons at oracle.com Mon Aug 26 15:56:30 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Mon, 26 Aug 2013 22:56:30 +0000 Subject: hg: jdk8/tl/langtools: 8023768: Use the unannotatedType in cyclicity checks. Message-ID: <20130826225633.9D81D48B89@hg.openjdk.java.net> Changeset: 7bf6313e1ced Author: jjg Date: 2013-08-26 15:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7bf6313e1ced 8023768: Use the unannotatedType in cyclicity checks. Reviewed-by: jjg Contributed-by: wdietl at gmail.com ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/annotations/typeAnnotations/failures/TypeVariableCycleTest.java From david.holmes at oracle.com Mon Aug 26 17:12:08 2013 From: david.holmes at oracle.com (david.holmes at oracle.com) Date: Tue, 27 Aug 2013 00:12:08 +0000 Subject: hg: jdk8/tl/jdk: 8014135: The JVMTI specification does not conform to recent changes in JNI specification Message-ID: <20130827001233.54B4148B8C@hg.openjdk.java.net> Changeset: 9586ca82bd8b Author: bpittore Date: 2013-08-26 11:27 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9586ca82bd8b 8014135: The JVMTI specification does not conform to recent changes in JNI specification Summary: Added support for statically linked agents Reviewed-by: alanb, sspitsyn, bobv, coleenp ! src/share/classes/com/sun/tools/attach/VirtualMachine.java From lana.steuck at oracle.com Mon Aug 26 22:20:16 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Tue, 27 Aug 2013 05:20:16 +0000 Subject: hg: jdk8/tl/corba: 2 new changesets Message-ID: <20130827052022.CF0A448BA2@hg.openjdk.java.net> Changeset: d411c60a8c2f Author: cl Date: 2013-08-15 09:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/d411c60a8c2f Added tag jdk8-b103 for changeset 49c4a777fdfd ! .hgtags Changeset: 4e38de7c767e Author: cl Date: 2013-08-22 09:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/4e38de7c767e Added tag jdk8-b104 for changeset d411c60a8c2f ! .hgtags From lana.steuck at oracle.com Mon Aug 26 22:20:26 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Tue, 27 Aug 2013 05:20:26 +0000 Subject: hg: jdk8/tl: 9 new changesets Message-ID: <20130827052027.B374E48BA3@hg.openjdk.java.net> Changeset: ceefd94ef326 Author: cl Date: 2013-08-15 09:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/ceefd94ef326 Added tag jdk8-b103 for changeset b7e64be81c8a ! .hgtags Changeset: 4fb877dfe5c4 Author: erikj Date: 2013-08-15 17:14 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/rev/4fb877dfe5c4 8020411: lin32 - JDK 8 build for Linux-i586 on Oracle Linux 6.4 64-bit machines does not generate the bundles directory in the build directory Reviewed-by: tbell ! common/autoconf/generated-configure.sh ! common/autoconf/platform.m4 ! common/autoconf/spec.gmk.in Changeset: f10f673d9b17 Author: igerasim Date: 2013-08-16 14:43 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/rev/f10f673d9b17 8023156: make dist-clean should remove javacservers directory Reviewed-by: erikj ! common/makefiles/Main.gmk Changeset: dadf49495ab4 Author: erikj Date: 2013-08-19 10:31 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/rev/dadf49495ab4 8021430: 64 bit JDK build fails on windows 7 due to missing corba source files Reviewed-by: tbell, katleman ! common/makefiles/IdlCompilation.gmk Changeset: 96c1b9b7524b Author: katleman Date: 2013-08-20 15:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/96c1b9b7524b Merge Changeset: c3b5197f2851 Author: cl Date: 2013-08-22 09:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/c3b5197f2851 Added tag jdk8-b104 for changeset 96c1b9b7524b ! .hgtags Changeset: e8a3edda1f60 Author: lana Date: 2013-08-20 17:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/e8a3edda1f60 Merge Changeset: 056398db9dcb Author: lana Date: 2013-08-23 14:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/056398db9dcb Merge ! common/autoconf/generated-configure.sh Changeset: 163091288aeb Author: lana Date: 2013-08-26 14:49 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/163091288aeb Merge ! common/makefiles/Main.gmk From lana.steuck at oracle.com Mon Aug 26 22:20:31 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Tue, 27 Aug 2013 05:20:31 +0000 Subject: hg: jdk8/tl/jaxp: 4 new changesets Message-ID: <20130827052056.027AB48BA4@hg.openjdk.java.net> Changeset: a22fe9bd01e6 Author: cl Date: 2013-08-15 09:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/a22fe9bd01e6 Added tag jdk8-b103 for changeset b1ceab582fc6 ! .hgtags Changeset: af28b93bfb6f Author: cl Date: 2013-08-22 09:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/af28b93bfb6f Added tag jdk8-b104 for changeset a22fe9bd01e6 ! .hgtags Changeset: d4d6422ec564 Author: lana Date: 2013-08-20 17:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/d4d6422ec564 Merge Changeset: 09a46ec11f88 Author: lana Date: 2013-08-23 14:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/09a46ec11f88 Merge From lana.steuck at oracle.com Mon Aug 26 22:20:35 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Tue, 27 Aug 2013 05:20:35 +0000 Subject: hg: jdk8/tl/jaxws: 3 new changesets Message-ID: <20130827052056.7DA8C48BA5@hg.openjdk.java.net> Changeset: 42211ab0ab1c Author: cl Date: 2013-08-15 09:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/42211ab0ab1c Added tag jdk8-b103 for changeset 6cdc6ed98780 ! .hgtags Changeset: 88390df7ed2c Author: cl Date: 2013-08-22 09:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/88390df7ed2c Added tag jdk8-b104 for changeset 42211ab0ab1c ! .hgtags Changeset: 533c1032337c Author: lana Date: 2013-08-26 14:50 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/533c1032337c Merge From lana.steuck at oracle.com Mon Aug 26 22:20:46 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Tue, 27 Aug 2013 05:20:46 +0000 Subject: hg: jdk8/tl/nashorn: 5 new changesets Message-ID: <20130827052057.0813148BA6@hg.openjdk.java.net> Changeset: afc100513451 Author: cl Date: 2013-08-15 09:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/afc100513451 Added tag jdk8-b103 for changeset 414203de4374 ! .hgtags Changeset: 74244f43c577 Author: cl Date: 2013-08-22 09:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/74244f43c577 Added tag jdk8-b104 for changeset afc100513451 ! .hgtags Changeset: 1f2394beecf7 Author: lana Date: 2013-08-20 17:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/1f2394beecf7 Merge - src/jdk/internal/dynalink/support/Backport.java - src/jdk/nashorn/internal/runtime/arrays/ArrayIterator.java - src/jdk/nashorn/internal/runtime/arrays/MapIterator.java - src/jdk/nashorn/internal/runtime/arrays/ReverseArrayIterator.java - src/jdk/nashorn/internal/runtime/arrays/ReverseMapIterator.java Changeset: f484bfb624dd Author: lana Date: 2013-08-23 14:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/f484bfb624dd Merge - src/jdk/internal/dynalink/support/Backport.java - src/jdk/nashorn/internal/runtime/arrays/ArrayIterator.java - src/jdk/nashorn/internal/runtime/arrays/MapIterator.java - src/jdk/nashorn/internal/runtime/arrays/ReverseArrayIterator.java - src/jdk/nashorn/internal/runtime/arrays/ReverseMapIterator.java Changeset: a18f92a0a910 Author: lana Date: 2013-08-26 14:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/a18f92a0a910 Merge From lana.steuck at oracle.com Mon Aug 26 22:20:47 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Tue, 27 Aug 2013 05:20:47 +0000 Subject: hg: jdk8/tl/langtools: 6 new changesets Message-ID: <20130827052114.E6B9448BA7@hg.openjdk.java.net> Changeset: dd4a00c220c6 Author: cl Date: 2013-08-15 09:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/dd4a00c220c6 Added tag jdk8-b103 for changeset 76cfe7c61f25 ! .hgtags Changeset: f2ee3a4e7927 Author: cl Date: 2013-08-22 09:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f2ee3a4e7927 Added tag jdk8-b104 for changeset dd4a00c220c6 ! .hgtags Changeset: b59a0b4675c9 Author: lana Date: 2013-08-20 17:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b59a0b4675c9 Merge - test/tools/javac/defaultMethods/defaultMethodExecution/DefaultMethodRegressionTests.java - test/tools/javac/diags/examples/IncompatibleThrownTypesInLambda.java Changeset: 375834b5cf08 Author: lana Date: 2013-08-23 14:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/375834b5cf08 Merge - test/tools/javac/defaultMethods/defaultMethodExecution/DefaultMethodRegressionTests.java - test/tools/javac/diags/examples/IncompatibleThrownTypesInLambda.java Changeset: 00ca54ceca1b Author: lana Date: 2013-08-26 14:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/00ca54ceca1b Merge Changeset: cc3fb73f5e08 Author: lana Date: 2013-08-26 22:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/cc3fb73f5e08 Merge From lana.steuck at oracle.com Mon Aug 26 22:20:56 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Tue, 27 Aug 2013 05:20:56 +0000 Subject: hg: jdk8/tl/hotspot: 32 new changesets Message-ID: <20130827052233.5940E48BA8@hg.openjdk.java.net> Changeset: 0bbd1c775bef Author: cl Date: 2013-08-15 09:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0bbd1c775bef Added tag jdk8-b103 for changeset 6f9be7f87b96 ! .hgtags Changeset: 39127bb12d32 Author: amurillo Date: 2013-08-09 01:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/39127bb12d32 8022688: new hotspot build - hs25-b46 Reviewed-by: jcoomes ! make/hotspot_version Changeset: ca0165daa6ec Author: sspitsyn Date: 2013-08-06 16:33 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ca0165daa6ec 7187554: JSR 292: JVMTI PopFrame needs to handle appendix arguments Summary: Restore the appendix argument after PopFrame() call Reviewed-by: twisti, coleenp Contributed-by: serguei.spitsyn at oracle.com ! src/cpu/sparc/vm/templateInterpreter_sparc.cpp ! src/cpu/x86/vm/templateInterpreter_x86_32.cpp ! src/cpu/x86/vm/templateInterpreter_x86_64.cpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/interpreter/interpreterRuntime.hpp Changeset: c54a3122f9c8 Author: omajid Date: 2013-08-06 12:28 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c54a3122f9c8 8022188: Make zero compile after 8016131 and 8016697 Reviewed-by: dholmes, twisti ! src/cpu/zero/vm/entryFrame_zero.hpp ! src/cpu/zero/vm/frame_zero.inline.hpp ! src/cpu/zero/vm/stubGenerator_zero.cpp ! src/os_cpu/linux_zero/vm/os_linux_zero.cpp Changeset: 196aa14f9f29 Author: dholmes Date: 2013-08-06 21:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/196aa14f9f29 Merge Changeset: 195ff07bc7f6 Author: dsamersoff Date: 2013-08-07 19:02 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/195ff07bc7f6 8021771: warning stat64 is deprecated - when building on OSX 10.7.5 Summary: stat64 have to be replaced with stat Reviewed-by: dholmes, kmo Contributed-by: rednaxelafx at gmail.com ! src/os/bsd/vm/attachListener_bsd.cpp Changeset: 31f3b1e1c5e5 Author: dcubed Date: 2013-08-08 09:21 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/31f3b1e1c5e5 8016601: Unable to build hsx24 on Windows using project creator and Visual Studio Summary: ProjectCreator tool is modified to support two new options: '-relativeAltSrcInclude' and '-altRelativeInclude' which prevents IDE linker errors. Also fixed some cmd line build linker warnings. Misc cleanups. Reviewed-by: rdurbin, coleenp ! make/windows/create.bat ! make/windows/create_obj_files.sh ! make/windows/makefiles/projectcreator.make ! make/windows/makefiles/trace.make ! make/windows/makefiles/vm.make ! src/share/tools/ProjectCreator/BuildConfig.java ! src/share/tools/ProjectCreator/FileTreeCreatorVC10.java ! src/share/tools/ProjectCreator/ProjectCreator.java ! src/share/tools/ProjectCreator/WinGammaPlatform.java ! src/share/tools/ProjectCreator/WinGammaPlatformVC10.java Changeset: c661fa2e5189 Author: iklam Date: 2013-08-08 14:45 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c661fa2e5189 8022093: syntax error near "umpiconninfo_t" -- when building on Solaris 10 Summary: Added extra help message in make/solaris/makefiles/dtrace.make Reviewed-by: dholmes, sspitsyn ! make/solaris/makefiles/dtrace.make Changeset: 57ac7245594c Author: minqi Date: 2013-08-08 15:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/57ac7245594c 8019583: [TESTBUG] runtime/7107135 always passes Summary: If java test return none zero, the value will be override by 'if' statement, the exit value will always '0' and pass. Fix by recording the result in a variable. Reviewed-by: coleenp, dholmes, iklam Contributed-by: yumin.qi at oracle.com ! test/runtime/7107135/Test7107135.sh Changeset: 6222a021d582 Author: minqi Date: 2013-08-08 20:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6222a021d582 Merge Changeset: 98aa538fd97e Author: mikael Date: 2013-08-09 09:51 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/98aa538fd97e 8022452: Hotspot needs to know about Windows 8.1 and Windows Server 2012 R2 Summary: Add support for recognizing Windows 8.1 and Server 2012 R2 and minor cleanup Reviewed-by: coleenp, dsamersoff ! src/os/windows/vm/os_windows.cpp Changeset: ed7c17e7d45b Author: dcubed Date: 2013-08-09 13:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ed7c17e7d45b Merge Changeset: 7b03590c334b Author: dcubed Date: 2013-08-09 15:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7b03590c334b Merge Changeset: bd0e82136b03 Author: iklam Date: 2013-08-10 10:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/bd0e82136b03 8022740: Visual 2008 IDE build is broken Summary: Fixed project generation code, and added warning to upgrade to VS 2008 SP1. Reviewed-by: dcubed, ccheung ! make/windows/projectfiles/common/Makefile ! src/share/tools/ProjectCreator/FileTreeCreator.java ! src/share/tools/ProjectCreator/FileTreeCreatorVC10.java ! src/share/tools/ProjectCreator/FileTreeCreatorVC7.java ! src/share/tools/ProjectCreator/WinGammaPlatformVC7.java Changeset: 85147f28faba Author: coleenp Date: 2013-08-12 17:24 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/85147f28faba 8009728: nsk/jvmti/AttachOnDemand/attach030 crashes on Win32 Summary: ActiveMethodOopsCache was used to keep track of old versions of some methods that are cached in Universe but is buggy with permgen removal and not needed anymore Reviewed-by: sspitsyn, dcubed, mseledtsov ! src/share/vm/memory/universe.cpp ! src/share/vm/memory/universe.hpp ! src/share/vm/oops/method.cpp ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! test/runtime/RedefineObject/Agent.java ! test/runtime/RedefineObject/TestRedefineObject.java + test/runtime/RedefineObject/WalkThroughInvoke.java Changeset: d1034bd8cefc Author: adlertz Date: 2013-08-07 17:56 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d1034bd8cefc 8022284: Hide internal data structure in PhaseCFG Summary: Hide private node to block mapping using public interface Reviewed-by: kvn, roland ! agent/src/share/classes/sun/jvm/hotspot/opto/PhaseCFG.java ! src/share/vm/opto/block.cpp ! src/share/vm/opto/block.hpp ! src/share/vm/opto/buildOopMap.cpp ! src/share/vm/opto/chaitin.cpp ! src/share/vm/opto/coalesce.cpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/domgraph.cpp ! src/share/vm/opto/gcm.cpp ! src/share/vm/opto/idealGraphPrinter.cpp ! src/share/vm/opto/ifg.cpp ! src/share/vm/opto/lcm.cpp ! src/share/vm/opto/live.cpp ! src/share/vm/opto/node.hpp ! src/share/vm/opto/output.cpp ! src/share/vm/opto/output.hpp ! src/share/vm/opto/postaloc.cpp ! src/share/vm/opto/reg_split.cpp ! src/share/vm/runtime/vmStructs.cpp Changeset: ce8969c36762 Author: adlertz Date: 2013-08-07 18:04 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ce8969c36762 8022475: Remove unneeded ad-files Summary: Remove .ad files that are not used Reviewed-by: kvn ! make/bsd/makefiles/adlc.make ! make/linux/makefiles/adlc.make ! make/solaris/makefiles/adlc.make ! make/windows/makefiles/adlc.make - src/os_cpu/bsd_x86/vm/bsd_x86_32.ad - src/os_cpu/bsd_x86/vm/bsd_x86_64.ad - src/os_cpu/linux_x86/vm/linux_x86_32.ad - src/os_cpu/linux_x86/vm/linux_x86_64.ad - src/os_cpu/solaris_sparc/vm/solaris_sparc.ad - src/os_cpu/solaris_x86/vm/solaris_x86_32.ad - src/os_cpu/solaris_x86/vm/solaris_x86_64.ad - src/os_cpu/windows_x86/vm/windows_x86_32.ad - src/os_cpu/windows_x86/vm/windows_x86_64.ad Changeset: 5394ec69f112 Author: rbackman Date: 2013-08-09 18:05 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5394ec69f112 Merge - src/os_cpu/bsd_x86/vm/bsd_x86_32.ad - src/os_cpu/bsd_x86/vm/bsd_x86_64.ad - src/os_cpu/linux_x86/vm/linux_x86_32.ad - src/os_cpu/linux_x86/vm/linux_x86_64.ad - src/os_cpu/solaris_sparc/vm/solaris_sparc.ad - src/os_cpu/solaris_x86/vm/solaris_x86_32.ad - src/os_cpu/solaris_x86/vm/solaris_x86_64.ad - src/os_cpu/windows_x86/vm/windows_x86_32.ad - src/os_cpu/windows_x86/vm/windows_x86_64.ad Changeset: 11237ee74aae Author: iignatyev Date: 2013-08-10 10:01 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/11237ee74aae 8019915: whitebox testClearMethodStateTest fails with tiered on sparc Summary: 'compileonly' directive has beens added to each 'compiler/whitebox' test Reviewed-by: kvn ! test/compiler/whitebox/ClearMethodStateTest.java ! test/compiler/whitebox/CompilerWhiteBoxTest.java ! test/compiler/whitebox/DeoptimizeAllTest.java ! test/compiler/whitebox/DeoptimizeMethodTest.java ! test/compiler/whitebox/EnqueueMethodForCompilationTest.java ! test/compiler/whitebox/IsMethodCompilableTest.java ! test/compiler/whitebox/MakeMethodNotCompilableTest.java ! test/compiler/whitebox/SetDontInlineMethodTest.java ! test/compiler/whitebox/SetForceInlineMethodTest.java Changeset: bcc4f6f54d83 Author: kvn Date: 2013-08-14 10:21 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/bcc4f6f54d83 8022993: Convert MAX_UNROLL constant to LoopMaxUnroll C2 flag Summary: Replace MAX_UNROLL constant with new C2 LoopMaxUnroll flag. Reviewed-by: roland ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/opto/loopTransform.cpp Changeset: 56b94e55267a Author: rbackman Date: 2013-08-15 15:26 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/56b94e55267a Merge - src/os_cpu/bsd_x86/vm/bsd_x86_32.ad - src/os_cpu/bsd_x86/vm/bsd_x86_64.ad - src/os_cpu/linux_x86/vm/linux_x86_32.ad - src/os_cpu/linux_x86/vm/linux_x86_64.ad - src/os_cpu/solaris_sparc/vm/solaris_sparc.ad - src/os_cpu/solaris_x86/vm/solaris_x86_32.ad - src/os_cpu/solaris_x86/vm/solaris_x86_64.ad - src/os_cpu/windows_x86/vm/windows_x86_32.ad - src/os_cpu/windows_x86/vm/windows_x86_64.ad Changeset: 9766f73e770d Author: stefank Date: 2013-05-31 14:32 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9766f73e770d 8022880: False sharing between PSPromotionManager instances Summary: Pad the PSPromotionManager instances in the manager array. Reviewed-by: brutisso, jmasa ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/parNew/parNewGeneration.hpp ! src/share/vm/gc_implementation/parNew/parOopClosures.hpp ! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.cpp ! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.hpp ! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.inline.hpp + src/share/vm/memory/padded.hpp + src/share/vm/memory/padded.inline.hpp ! src/share/vm/utilities/debug.hpp ! src/share/vm/utilities/globalDefinitions.hpp Changeset: 330dfb0476f4 Author: brutisso Date: 2013-08-14 09:02 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/330dfb0476f4 8022800: Use specific generations rather than generation iteration Reviewed-by: jmasa, ehelin ! src/share/vm/gc_implementation/parNew/parNewGeneration.cpp ! src/share/vm/memory/cardTableRS.cpp ! src/share/vm/memory/cardTableRS.hpp ! src/share/vm/memory/defNewGeneration.cpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/genCollectedHeap.hpp ! src/share/vm/memory/genMarkSweep.cpp ! src/share/vm/memory/genRemSet.hpp Changeset: 3f22cbf5275d Author: brutisso Date: 2013-08-14 10:55 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3f22cbf5275d Merge Changeset: 5d9995d16b26 Author: ehelin Date: 2013-08-14 13:49 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5d9995d16b26 8022899: SunStudio compiler can not handle EXCEPTION_MARK and inlining Reviewed-by: coleenp, mgerdin ! src/share/vm/utilities/exceptions.hpp Changeset: bd902affe102 Author: brutisso Date: 2013-08-15 10:05 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/bd902affe102 8023021: Unnecessary clearing of the card table introduced by the fix for JDK-8023013 Reviewed-by: stefank, ehelin ! src/share/vm/memory/cardTableRS.cpp ! src/share/vm/memory/cardTableRS.hpp ! src/share/vm/memory/genMarkSweep.cpp ! src/share/vm/memory/genRemSet.hpp Changeset: 274ce305e5b9 Author: ehelin Date: 2013-08-13 18:16 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/274ce305e5b9 8020598: ObjectCountEventSender::send needs INCLUDE_TRACE guards when building OpenJDK with INCLUDE_TRACE=0 Reviewed-by: stefank, brutisso, sjohanss ! src/share/vm/gc_implementation/shared/objectCountEventSender.cpp Changeset: 33d39b75663f Author: ehelin Date: 2013-08-15 06:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/33d39b75663f Merge Changeset: 5a62937e55b3 Author: brutisso Date: 2013-08-16 09:02 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5a62937e55b3 Merge - src/os_cpu/bsd_x86/vm/bsd_x86_32.ad - src/os_cpu/bsd_x86/vm/bsd_x86_64.ad - src/os_cpu/linux_x86/vm/linux_x86_32.ad - src/os_cpu/linux_x86/vm/linux_x86_64.ad - src/os_cpu/solaris_sparc/vm/solaris_sparc.ad - src/os_cpu/solaris_x86/vm/solaris_x86_32.ad - src/os_cpu/solaris_x86/vm/solaris_x86_64.ad - src/os_cpu/windows_x86/vm/windows_x86_32.ad - src/os_cpu/windows_x86/vm/windows_x86_64.ad Changeset: 580430d131cc Author: amurillo Date: 2013-08-16 04:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/580430d131cc Merge - src/os_cpu/bsd_x86/vm/bsd_x86_32.ad - src/os_cpu/bsd_x86/vm/bsd_x86_64.ad - src/os_cpu/linux_x86/vm/linux_x86_32.ad - src/os_cpu/linux_x86/vm/linux_x86_64.ad - src/os_cpu/solaris_sparc/vm/solaris_sparc.ad - src/os_cpu/solaris_x86/vm/solaris_x86_32.ad - src/os_cpu/solaris_x86/vm/solaris_x86_64.ad - src/os_cpu/windows_x86/vm/windows_x86_32.ad - src/os_cpu/windows_x86/vm/windows_x86_64.ad Changeset: 104743074675 Author: amurillo Date: 2013-08-16 04:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/104743074675 Added tag hs25-b46 for changeset 580430d131cc ! .hgtags Changeset: c93e0a210e1b Author: cl Date: 2013-08-22 09:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c93e0a210e1b Added tag jdk8-b104 for changeset 104743074675 ! .hgtags From lana.steuck at oracle.com Mon Aug 26 22:22:10 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Tue, 27 Aug 2013 05:22:10 +0000 Subject: hg: jdk8/tl/jdk: 23 new changesets Message-ID: <20130827052721.2B1BC48BA9@hg.openjdk.java.net> Changeset: f1d8d15bfcb5 Author: cl Date: 2013-08-15 09:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f1d8d15bfcb5 Added tag jdk8-b103 for changeset e0f6039c0290 ! .hgtags Changeset: c982f579b67e Author: cl Date: 2013-08-22 09:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c982f579b67e Added tag jdk8-b104 for changeset f1d8d15bfcb5 ! .hgtags Changeset: 2722f4000b65 Author: jgodinez Date: 2013-08-15 11:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2722f4000b65 8023045: [MacOSX] PrinterIOException when printing a JComponent Reviewed-by: bae, jchen ! src/share/classes/sun/print/PSPrinterJob.java Changeset: b44ce67c0565 Author: vadim Date: 2013-08-16 15:57 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b44ce67c0565 8013446: [parfait] Memory leak in jdk/src/windows/native/sun/java2d/opengl/WGLSurfaceData.c Reviewed-by: bae, prr ! src/windows/native/sun/java2d/opengl/WGLSurfaceData.c Changeset: dadd43e02a79 Author: prr Date: 2013-08-19 03:58 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dadd43e02a79 8017580: Crash in font loading code on Linux (due to use of reflection) Reviewed-by: bae, vadim ! src/share/native/sun/font/sunFont.c ! src/share/native/sun/font/sunfontids.h Changeset: 0c950b2be7ab Author: jgodinez Date: 2013-08-19 11:21 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0c950b2be7ab 8022241: [macosx] [PIT] lookupPrintServices() returns one too long array Reviewed-by: prr, jchen ! src/solaris/classes/sun/print/UnixPrintServiceLookup.java Changeset: 64be71ae6185 Author: lana Date: 2013-08-20 17:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/64be71ae6185 Merge Changeset: 903a279f1fce Author: ant Date: 2013-08-09 05:20 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/903a279f1fce 8013611: Modal dialog fails to obtain keyboard focus Reviewed-by: leonidr ! src/share/classes/java/awt/KeyboardFocusManager.java + test/java/awt/Focus/8013611/JDK8013611.java Changeset: 2cd1a041381b Author: alexsch Date: 2013-08-09 14:16 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2cd1a041381b 7121409: Two conformance tests for AccessibleText.getCharacterBounds(int i) fail Reviewed-by: serb ! src/share/classes/javax/swing/JLabel.java Changeset: 4702ab74b70a Author: serb Date: 2013-08-13 15:41 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4702ab74b70a 7027045: (doc) java/awt/Window.java has several typos in javadoc Reviewed-by: art, serb Contributed-by: konstantin.perikov at gmail.com ! src/share/classes/java/awt/Window.java Changeset: 149bf2400fa1 Author: lana Date: 2013-08-13 15:49 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/149bf2400fa1 Merge - test/java/lang/System/MacJNUEncoding/ExpectedEncoding.java - test/java/lang/System/MacJNUEncoding/MacJNUEncoding.sh Changeset: c5db3ec83cba Author: pchelko Date: 2013-08-14 16:17 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c5db3ec83cba 8013454: [parfait] Memory leak in jdk/src/windows/native/sun/windows/awt_Cursor.cpp 8012079: [parfait] possible null pointer dereference in jdk/src/windows/native/sun/windows/awt_Font.cpp Reviewed-by: art, serb ! src/windows/native/sun/windows/awt_Cursor.cpp ! src/windows/native/sun/windows/awt_Font.cpp Changeset: 1d6ce0070fd3 Author: pchelko Date: 2013-08-14 17:20 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1d6ce0070fd3 7173464: Clipboard.getAvailableDataFlavors: Comparison method violates contract Reviewed-by: anthony, art, serb ! src/share/classes/sun/awt/datatransfer/ClipboardTransferable.java ! src/share/classes/sun/awt/datatransfer/DataTransferer.java + test/sun/awt/datatransfer/DataFlavorComparatorTest.java Changeset: 3930a827160a Author: leonidr Date: 2013-08-15 01:17 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3930a827160a 8022997: [macosx] Remaining duplicated key events Reviewed-by: anthony, serb ! src/macosx/native/sun/awt/CMenuItem.m ! test/javax/swing/JMenuItem/ActionListenerCalledTwice/ActionListenerCalledTwiceTest.java Changeset: d7a34d7e7f22 Author: alitvinov Date: 2013-08-15 14:20 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d7a34d7e7f22 7191018: Manual test closed/java/awt/JAWT causes JVM to crash starting from JDK 5 Reviewed-by: anthony, serb ! src/solaris/native/sun/awt/awt_DrawingSurface.c Changeset: c089e93e6444 Author: serb Date: 2013-08-16 16:52 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c089e93e6444 8020051: [TEST_BUG] Testcase for 8004859 has a typo Reviewed-by: anthony ! test/java/awt/Graphics2D/Test8004859/Test8004859.java Changeset: e3316cd6ca47 Author: serb Date: 2013-08-16 20:56 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e3316cd6ca47 8006085: [findbugs] a warning on javax.sound.sampled.DataLine$Info constructor Reviewed-by: art, prr ! src/share/classes/javax/sound/sampled/DataLine.java Changeset: 64dc24e0d577 Author: serb Date: 2013-08-16 21:18 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/64dc24e0d577 8005980: [findbugs] More com.sun.media.sound.* warnings Reviewed-by: art, prr ! src/share/classes/com/sun/media/sound/DataPusher.java ! src/share/classes/com/sun/media/sound/ModelStandardDirector.java ! src/share/classes/com/sun/media/sound/ModelStandardIndexedDirector.java ! src/share/classes/com/sun/media/sound/SoftMixingClip.java ! src/share/classes/sun/audio/AudioData.java Changeset: fefa29e15a14 Author: lana Date: 2013-08-20 17:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fefa29e15a14 Merge Changeset: a79fcf53195f Author: lana Date: 2013-08-20 17:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a79fcf53195f Merge - src/share/classes/com/sun/security/auth/PolicyParser.java - src/share/classes/com/sun/security/auth/SubjectCodeSource.java - src/share/classes/java/util/jar/UnsupportedProfileException.java - src/share/classes/sun/security/provider/ConfigSpiFile.java - test/java/net/URLClassLoader/profiles/Basic.java - test/java/net/URLClassLoader/profiles/Lib.java - test/java/net/URLClassLoader/profiles/basic.sh - test/tools/jar/AddAndUpdateProfile.java - test/tools/launcher/profiles/Basic.java - test/tools/launcher/profiles/Logging.java - test/tools/launcher/profiles/Main.java - test/tools/launcher/profiles/VersionCheck.java Changeset: 9626ba160e3d Author: lana Date: 2013-08-23 14:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9626ba160e3d Merge - src/share/classes/com/sun/security/auth/PolicyParser.java - src/share/classes/com/sun/security/auth/SubjectCodeSource.java - src/share/classes/java/util/jar/UnsupportedProfileException.java - src/share/classes/sun/security/provider/ConfigSpiFile.java - test/java/net/URLClassLoader/profiles/Basic.java - test/java/net/URLClassLoader/profiles/Lib.java - test/java/net/URLClassLoader/profiles/basic.sh - test/tools/jar/AddAndUpdateProfile.java - test/tools/launcher/profiles/Basic.java - test/tools/launcher/profiles/Logging.java - test/tools/launcher/profiles/Main.java - test/tools/launcher/profiles/VersionCheck.java Changeset: c58e39bb5d62 Author: lana Date: 2013-08-26 14:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c58e39bb5d62 Merge Changeset: 6cdc679e3412 Author: lana Date: 2013-08-26 22:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6cdc679e3412 Merge From weijun.wang at oracle.com Tue Aug 27 02:51:22 2013 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Tue, 27 Aug 2013 09:51:22 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20130827095225.1083C48BB4@hg.openjdk.java.net> Changeset: ca53110f1c74 Author: weijun Date: 2013-08-27 17:50 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ca53110f1c74 8015669: KerberosPrincipal::equals should ignore name-type Reviewed-by: mullan ! src/share/classes/javax/security/auth/kerberos/KerberosPrincipal.java + test/sun/security/krb5/auto/KPEquals.java Changeset: 4bddc344848e Author: weijun Date: 2013-08-27 17:50 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4bddc344848e 8022761: regression: SecurityException is NOT thrown while trying to pack a wrongly signed Indexed Jar file Reviewed-by: sherman ! src/share/classes/java/util/jar/JarVerifier.java + test/sun/security/tools/jarsigner/jvindex.sh From sundararajan.athijegannathan at oracle.com Tue Aug 27 07:22:31 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Tue, 27 Aug 2013 14:22:31 +0000 Subject: hg: jdk8/tl/nashorn: 10 new changesets Message-ID: <20130827142242.4903548BC2@hg.openjdk.java.net> Changeset: badc919cd621 Author: lagergren Date: 2013-08-23 14:16 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/badc919cd621 8023550: -d option was broken for any dir but '.'. Fixed Java warnings. Reviewed-by: jlaskey, sundar ! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/ConstructorGenerator.java ! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/ScriptClassInstrumentor.java ! src/jdk/internal/dynalink/ChainedCallSite.java ! src/jdk/internal/dynalink/DefaultBootstrapper.java ! src/jdk/internal/dynalink/beans/AbstractJavaLinker.java ! src/jdk/internal/dynalink/beans/OverloadedDynamicMethod.java ! src/jdk/nashorn/api/scripting/NashornScriptEngine.java ! src/jdk/nashorn/internal/codegen/CompilationPhase.java ! src/jdk/nashorn/internal/objects/NativeArray.java ! src/jdk/nashorn/internal/objects/NativeRegExp.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/DebuggerSupport.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/regexp/joni/ArrayCompiler.java ! src/jdk/nashorn/internal/runtime/regexp/joni/BitSet.java ! src/jdk/nashorn/internal/runtime/regexp/joni/ByteCodeMachine.java ! src/jdk/nashorn/internal/runtime/regexp/joni/CodeRangeBuffer.java ! src/jdk/nashorn/internal/runtime/regexp/joni/Lexer.java ! src/jdk/nashorn/internal/runtime/regexp/joni/Parser.java ! src/jdk/nashorn/internal/runtime/regexp/joni/Region.java ! src/jdk/nashorn/internal/runtime/regexp/joni/ScannerSupport.java ! src/jdk/nashorn/internal/runtime/regexp/joni/SearchAlgorithm.java ! src/jdk/nashorn/internal/runtime/regexp/joni/StackMachine.java ! src/jdk/nashorn/internal/runtime/regexp/joni/WarnCallback.java ! src/jdk/nashorn/internal/runtime/regexp/joni/ast/EncloseNode.java ! src/jdk/nashorn/internal/runtime/regexp/joni/ast/Node.java ! src/jdk/nashorn/internal/runtime/regexp/joni/ast/QuantifierNode.java ! src/jdk/nashorn/internal/runtime/regexp/joni/exception/ErrorMessages.java ! tools/fxshell/jdk/nashorn/tools/FXShell.java Changeset: e2d94d032760 Author: jlaskey Date: 2013-08-23 09:56 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/e2d94d032760 8020946: TokenType#toString returned null Reviewed-by: hannesw, lagergren Contributed-by: james.laskey at oracle.com ! src/jdk/nashorn/internal/parser/TokenType.java Changeset: eb7b8340ce3a Author: lagergren Date: 2013-08-23 15:46 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/eb7b8340ce3a 8023454: Updated DEVELOPER_README and command line flags, ensuring that undocumented flags that aren't guaranteed to work (disabled by default) and that are work in progress show up with an EXPERIMENTAL tag. Reviewed-by: attila, jlaskey ! docs/DEVELOPER_README ! src/jdk/nashorn/internal/runtime/resources/Options.properties Changeset: 12820c8d0a5d Author: jlaskey Date: 2013-08-23 12:20 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/12820c8d0a5d 8019987: String trimRight and trimLeft could be defined Reviewed-by: sundar Contributed-by: james.laskey at oracle.com ! src/jdk/nashorn/internal/objects/NativeString.java + test/script/basic/JDK-8019987.js Changeset: c19c66e661a9 Author: hannesw Date: 2013-08-26 15:59 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/c19c66e661a9 8023650: Regexp m flag does not recognize CRNL or CR Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/internal/runtime/regexp/joni/ByteCodeMachine.java ! src/jdk/nashorn/internal/runtime/regexp/joni/Config.java ! src/jdk/nashorn/internal/runtime/regexp/joni/EncodingHelper.java ! src/jdk/nashorn/internal/runtime/regexp/joni/Lexer.java ! src/jdk/nashorn/internal/runtime/regexp/joni/Matcher.java ! src/jdk/nashorn/tools/Shell.java + test/script/basic/JDK-8023650.js Changeset: 99e48c76d11f Author: jlaskey Date: 2013-08-26 15:33 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/99e48c76d11f 8023721: Simplify eval in DebuggerSupport. Reviewed-by: sundar, lagergren, hannesw Contributed-by: james.laskey at oracle.com ! src/jdk/nashorn/internal/runtime/DebuggerSupport.java Changeset: 3bd077423a08 Author: sundar Date: 2013-08-27 15:54 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/3bd077423a08 8022773: ScriptEngineTest.printManyTest fails Reviewed-by: lagergren, attila ! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java Changeset: 47f0a4c4b729 Author: attila Date: 2013-08-27 13:17 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/47f0a4c4b729 8023780: Gracefully handle @CS methods while binding bean properties Reviewed-by: jlaskey, lagergren, sundar ! src/jdk/nashorn/internal/objects/NativeObject.java + test/script/basic/JDK-8023780.js + test/script/basic/JDK-8023780.js.EXPECTED Changeset: bda0e89f88ae Author: sundar Date: 2013-08-27 18:57 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/bda0e89f88ae 8023784: Object.prototype.toString should contain the class name for all instances Reviewed-by: lagergren, jlaskey ! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java ! src/jdk/nashorn/internal/objects/NativeArrayBuffer.java ! src/jdk/nashorn/internal/objects/NativeFloat32Array.java ! src/jdk/nashorn/internal/objects/NativeFloat64Array.java ! src/jdk/nashorn/internal/objects/NativeInt16Array.java ! src/jdk/nashorn/internal/objects/NativeInt32Array.java ! src/jdk/nashorn/internal/objects/NativeInt8Array.java ! src/jdk/nashorn/internal/objects/NativeUint16Array.java ! src/jdk/nashorn/internal/objects/NativeUint32Array.java ! src/jdk/nashorn/internal/objects/NativeUint8Array.java ! src/jdk/nashorn/internal/objects/NativeUint8ClampedArray.java ! src/jdk/nashorn/internal/runtime/ScriptRuntime.java + test/script/basic/JDK-8023784.js + test/script/basic/JDK-8023784.js.EXPECTED ! test/script/basic/NASHORN-377.js.EXPECTED Changeset: 101606d3eb84 Author: sundar Date: 2013-08-27 19:26 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/101606d3eb84 Merge From sean.mullan at oracle.com Tue Aug 27 07:47:34 2013 From: sean.mullan at oracle.com (sean.mullan at oracle.com) Date: Tue, 27 Aug 2013 14:47:34 +0000 Subject: hg: jdk8/tl/jdk: 8023769: JDK-8016850 broke the old build Message-ID: <20130827144802.7A91E48BC4@hg.openjdk.java.net> Changeset: 134283a88499 Author: mullan Date: 2013-08-27 10:46 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/134283a88499 8023769: JDK-8016850 broke the old build Summary: remove files that were moved/removed from com/sun/security/auth/FILES_java.gmk Reviewed-by: chegar, xuelei ! make/com/sun/security/auth/FILES_java.gmk From sean.mullan at oracle.com Tue Aug 27 10:00:32 2013 From: sean.mullan at oracle.com (sean.mullan at oracle.com) Date: Tue, 27 Aug 2013 17:00:32 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20130827170114.3E4EF48BD4@hg.openjdk.java.net> Changeset: 6a1bfcde4d4d Author: mullan Date: 2013-08-27 12:04 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6a1bfcde4d4d 8019830: Add com.sun.media.sound to the list of restricted package Reviewed-by: vinnie ! src/share/lib/security/java.security-linux ! src/share/lib/security/java.security-macosx ! src/share/lib/security/java.security-solaris ! src/share/lib/security/java.security-windows ! test/java/lang/SecurityManager/CheckPackageAccess.java Changeset: 3575263eefab Author: mullan Date: 2013-08-27 12:27 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3575263eefab Merge - src/share/classes/com/sun/security/auth/PolicyParser.java - src/share/classes/com/sun/security/auth/SubjectCodeSource.java - src/share/classes/sun/misc/Compare.java - src/share/classes/sun/misc/Sort.java From bhavesh.x.patel at oracle.com Tue Aug 27 11:42:23 2013 From: bhavesh.x.patel at oracle.com (bhavesh.x.patel at oracle.com) Date: Tue, 27 Aug 2013 18:42:23 +0000 Subject: hg: jdk8/tl/langtools: 7052170: javadoc -charset option generates wrong meta tag Message-ID: <20130827184229.9910448BE1@hg.openjdk.java.net> Changeset: 7fb27bc201cc Author: bpatel Date: 2013-08-27 11:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7fb27bc201cc 7052170: javadoc -charset option generates wrong meta tag Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlAttr.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTree.java + test/com/sun/javadoc/testCharset/TestCharset.java + test/com/sun/javadoc/testCharset/pkg/Foo.java From joe.darcy at oracle.com Tue Aug 27 11:46:44 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Tue, 27 Aug 2013 18:46:44 +0000 Subject: hg: jdk8/tl/jdk: 8023827: Fix doclint issues in javax.net.ssl Message-ID: <20130827184707.54C9948BE2@hg.openjdk.java.net> Changeset: 51151b440e95 Author: darcy Date: 2013-08-27 11:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/51151b440e95 8023827: Fix doclint issues in javax.net.ssl Reviewed-by: wetmore, xuelei ! src/share/classes/javax/net/ssl/SNIHostName.java ! src/share/classes/javax/net/ssl/X509KeyManager.java From henry.jen at oracle.com Tue Aug 27 12:08:23 2013 From: henry.jen at oracle.com (henry.jen at oracle.com) Date: Tue, 27 Aug 2013 19:08:23 +0000 Subject: hg: jdk8/tl/jdk: 8023275: Wrapping collections should override default methods Message-ID: <20130827190924.2BB8348BE8@hg.openjdk.java.net> Changeset: ade440668f94 Author: henryjen Date: 2013-08-26 22:32 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ade440668f94 8023275: Wrapping collections should override default methods Reviewed-by: mduigou, psandoz ! src/share/classes/java/util/Collections.java + test/java/util/Collections/Wrappers.java From joe.darcy at oracle.com Tue Aug 27 11:59:39 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Tue, 27 Aug 2013 18:59:39 +0000 Subject: hg: jdk8/tl/langtools: 8023826: Typo in warning about obsolete source / target values Message-ID: <20130827185942.4591C48BE3@hg.openjdk.java.net> Changeset: 662a5188bded Author: darcy Date: 2013-08-27 11:58 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/662a5188bded 8023826: Typo in warning about obsolete source / target values Reviewed-by: jjg, wmdietl ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java From xueming.shen at oracle.com Tue Aug 27 12:51:41 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Tue, 27 Aug 2013 19:51:41 +0000 Subject: hg: jdk8/tl/jdk: 8023647: "abc1c".matches("(\\w)+1\\1")) returns false Message-ID: <20130827195214.B335F48BEF@hg.openjdk.java.net> Changeset: 3f6777cbfe69 Author: sherman Date: 2013-08-27 12:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3f6777cbfe69 8023647: "abc1c".matches("(\\w)+1\\1")) returns false Summary: to correct the wrong GroupCurly group index backoff code Reviewed-by: alanb ! src/share/classes/java/util/regex/Pattern.java ! test/java/util/regex/RegExTest.java From henry.jen at oracle.com Tue Aug 27 21:24:49 2013 From: henry.jen at oracle.com (henry.jen at oracle.com) Date: Wed, 28 Aug 2013 04:24:49 +0000 Subject: hg: jdk8/tl/jdk: 8023528: Rename Comparator combinators to disambiguate overloading methods Message-ID: <20130828042521.5AB2A48C07@hg.openjdk.java.net> Changeset: be2d25a277a7 Author: henryjen Date: 2013-08-21 20:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/be2d25a277a7 8023528: Rename Comparator combinators to disambiguate overloading methods Reviewed-by: mduigou, smarks ! src/share/classes/java/util/Comparator.java ! test/java/util/Comparator/BasicTest.java ! test/java/util/Map/EntryComparators.java ! test/java/util/function/BinaryOperator/BasicTest.java From alan.bateman at oracle.com Wed Aug 28 07:33:51 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Wed, 28 Aug 2013 14:33:51 +0000 Subject: hg: jdk8/tl/jdk: 8023717: (process) ProcessBuilder should catch SecurityException rather than AccessControlException Message-ID: <20130828143416.D038248C29@hg.openjdk.java.net> Changeset: 2efa310226f7 Author: alanb Date: 2013-08-28 14:07 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2efa310226f7 8023717: (process) ProcessBuilder should catch SecurityException rather than AccessControlException Reviewed-by: wetmore, alanb Contributed-by: martinrb at google.com ! src/share/classes/java/lang/ProcessBuilder.java From alan.bateman at oracle.com Wed Aug 28 07:53:08 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Wed, 28 Aug 2013 14:53:08 +0000 Subject: hg: jdk8/tl/jdk: 8022594: Potential deadlock in of sun.nio.ch.Util/IOUtil Message-ID: <20130828145330.265AB48C2B@hg.openjdk.java.net> Changeset: 378acd4d03c8 Author: alanb Date: 2013-08-28 15:50 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/378acd4d03c8 8022594: Potential deadlock in of sun.nio.ch.Util/IOUtil Reviewed-by: chegar ! src/macosx/classes/sun/nio/ch/KQueueArrayWrapper.java ! src/macosx/classes/sun/nio/ch/KQueueSelectorImpl.java ! src/share/classes/sun/nio/ch/AbstractPollSelectorImpl.java ! src/share/classes/sun/nio/ch/DatagramChannelImpl.java ! src/share/classes/sun/nio/ch/FileChannelImpl.java ! src/share/classes/sun/nio/ch/IOUtil.java ! src/share/classes/sun/nio/ch/Net.java ! src/share/classes/sun/nio/ch/ServerSocketChannelImpl.java ! src/share/classes/sun/nio/ch/SocketChannelImpl.java ! src/share/classes/sun/nio/ch/Util.java ! src/solaris/classes/sun/nio/ch/DatagramDispatcher.java ! src/solaris/classes/sun/nio/ch/DevPollArrayWrapper.java ! src/solaris/classes/sun/nio/ch/DevPollSelectorImpl.java ! src/solaris/classes/sun/nio/ch/EPoll.java ! src/solaris/classes/sun/nio/ch/EPollArrayWrapper.java ! src/solaris/classes/sun/nio/ch/EPollPort.java ! src/solaris/classes/sun/nio/ch/EPollSelectorImpl.java ! src/solaris/classes/sun/nio/ch/FileDispatcherImpl.java ! src/solaris/classes/sun/nio/ch/InheritedChannel.java ! src/solaris/classes/sun/nio/ch/KQueue.java ! src/solaris/classes/sun/nio/ch/KQueuePort.java ! src/solaris/classes/sun/nio/ch/NativeThread.java ! src/solaris/classes/sun/nio/ch/PollArrayWrapper.java ! src/solaris/classes/sun/nio/ch/SinkChannelImpl.java ! src/solaris/classes/sun/nio/ch/SolarisEventPort.java ! src/solaris/classes/sun/nio/ch/SourceChannelImpl.java ! src/solaris/classes/sun/nio/ch/UnixAsynchronousServerSocketChannelImpl.java ! src/solaris/classes/sun/nio/ch/UnixAsynchronousSocketChannelImpl.java ! src/solaris/classes/sun/nio/ch/sctp/SctpChannelImpl.java ! src/solaris/classes/sun/nio/ch/sctp/SctpMultiChannelImpl.java ! src/solaris/classes/sun/nio/ch/sctp/SctpServerChannelImpl.java ! src/windows/classes/sun/nio/ch/DatagramDispatcher.java ! src/windows/classes/sun/nio/ch/FileDispatcherImpl.java ! src/windows/classes/sun/nio/ch/FileKey.java ! src/windows/classes/sun/nio/ch/Iocp.java ! src/windows/classes/sun/nio/ch/PipeImpl.java ! src/windows/classes/sun/nio/ch/SocketDispatcher.java ! src/windows/classes/sun/nio/ch/WindowsAsynchronousFileChannelImpl.java ! src/windows/classes/sun/nio/ch/WindowsAsynchronousServerSocketChannelImpl.java ! src/windows/classes/sun/nio/ch/WindowsAsynchronousSocketChannelImpl.java ! src/windows/classes/sun/nio/ch/WindowsSelectorImpl.java From ralucas at google.com Wed Aug 28 09:08:09 2013 From: ralucas at google.com (Raluca Sauciuc) Date: Wed, 28 Aug 2013 09:08:09 -0700 Subject: Warnings getting past @SuppressWarnings Message-ID: Hi compiler-dev, We ran into an unexpected behavior with javac7 and unchecked warnings. Code that compiled without any warnings, by using @SuppressWarnings in a few places, has started to display them again. Here's the simplest example I could find: public class Test { @SuppressWarnings("unchecked") public static Foo of(Class type) { return (Foo) cache.get(type); } private static final Cache,Foo> cache = null; interface Cache { V get(K key); } interface Foo { T newFoo(String name); } interface Bar { } } $ javac -Xlint:unchecked Test.java Test.java:5: warning: [unchecked] unchecked cast return (Foo) cache.get(type); ^ required: Foo found: Foo where T is a type-variable: T extends Bar declared in method of(Class) where CAP#1 is a fresh type-variable: CAP#1 extends Bar from capture of ? 1 warning The warning is legitimate, as Cache,Foo> loses the constraint between key and value type, but we expect @SuppressWarnings to silence it. Note that javac6 doesn't emit the warning. Is this expected behavior? Thanks, Raluca -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20130828/b8537244/attachment.html From xueming.shen at oracle.com Wed Aug 28 09:43:58 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Wed, 28 Aug 2013 16:43:58 +0000 Subject: hg: jdk8/tl/jdk: 8023713: ZipFileSystem crashes on old zip file Message-ID: <20130828164438.79F9A6236B@hg.openjdk.java.net> Changeset: 690b2931baef Author: sherman Date: 2013-08-28 09:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/690b2931baef 8023713: ZipFileSystem crashes on old zip file Summary: to handle extra data field copy correctly even the extra data does not follow the spec Reviewed-by: alanb, martin, chegar ! src/share/classes/java/util/zip/ZipOutputStream.java ! test/java/util/zip/TestExtraTime.java From henry.jen at oracle.com Wed Aug 28 10:17:30 2013 From: henry.jen at oracle.com (henry.jen at oracle.com) Date: Wed, 28 Aug 2013 17:17:30 +0000 Subject: hg: jdk8/tl/langtools: 8014566: Remove @ignore tags from MethodReference66 and InInterface when 8013875 is fixed Message-ID: <20130828171737.A464F62371@hg.openjdk.java.net> Changeset: 7de7100c30ce Author: henryjen Date: 2013-08-28 10:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7de7100c30ce 8014566: Remove @ignore tags from MethodReference66 and InInterface when 8013875 is fixed Reviewed-by: briangoetz, jjg ! test/tools/javac/lambda/MethodReference66.java ! test/tools/javac/lambda/lambdaExecution/InInterface.java From paul.sandoz at oracle.com Wed Aug 28 13:13:49 2013 From: paul.sandoz at oracle.com (paul.sandoz at oracle.com) Date: Wed, 28 Aug 2013 20:13:49 +0000 Subject: hg: jdk8/tl/jdk: 8023155: Ensure functional consistency across Random, ThreadLocalRandom, SplittableRandom Message-ID: <20130828201419.3B4096237E@hg.openjdk.java.net> Changeset: b1f41565b806 Author: psandoz Date: 2013-08-28 22:11 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b1f41565b806 8023155: Ensure functional consistency across Random, ThreadLocalRandom, SplittableRandom Reviewed-by: mduigou Contributed-by: Doug Lea
, Paul Sandoz ! src/share/classes/java/util/Random.java ! src/share/classes/java/util/concurrent/ThreadLocalRandom.java ! test/java/util/Random/RandomStreamTest.java + test/java/util/Random/RandomTest.java ! test/java/util/SplittableRandom/SplittableRandomTest.java + test/java/util/concurrent/ThreadLocalRandom/ThreadLocalRandomTest.java From jonathan.gibbons at oracle.com Wed Aug 28 15:41:21 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Wed, 28 Aug 2013 22:41:21 +0000 Subject: hg: jdk8/tl/langtools: 8010310: [javadoc] Error processing sources with -private Message-ID: <20130828224126.38AC562385@hg.openjdk.java.net> Changeset: 189942cdf585 Author: jjg Date: 2013-08-28 15:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/189942cdf585 8010310: [javadoc] Error processing sources with -private Reviewed-by: vromero, mcimadamore ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javadoc/JavadocMemberEnter.java + test/tools/javadoc/nonConstExprs/Test.java From mike.duigou at oracle.com Wed Aug 28 18:51:36 2013 From: mike.duigou at oracle.com (Mike Duigou) Date: Wed, 28 Aug 2013 18:51:36 -0700 Subject: RFR : 8023892 : (xs) /test/Makefile should not try to tell langtools/test/Makefile where to put output Message-ID: <0A778193-9981-4E62-9C68-07D15EA04069@oracle.com> Hello all; JDK-8023491 included a change which attempted to adjust the location that the langtools/test/Makefile used to write test results. This change conflicted with how the test/Makefiles are used by important scripts. This change backs out the langtools testing output location changes which were part of JDK-8023491. http://cr.openjdk.java.net/~mduigou/JDK-8023892/0/webrev The net effect is that langtools/test/Makefile will return to it's former behaviour and write it's test results to a non-standard location (outside of the build/$(CONF)/testoutput directory) until additional changeset(s) can be prepared to correct this problem. Sorry for any inconvenience this problem caused. All future changes impacting langtools test execution will include the compiler-dev mailing list. Mike From alex.buckley at oracle.com Wed Aug 28 19:26:55 2013 From: alex.buckley at oracle.com (Alex Buckley) Date: Wed, 28 Aug 2013 19:26:55 -0700 Subject: Review request for JDK-8020745: Suspicious MethodParameters attribute generated for local classes capturing local variables In-Reply-To: <52169F0C.50305@oracle.com> References: <5212AAB4.8060700@oracle.com> <5212B832.6040508@oracle.com> <5213EF72.6080100@oracle.com> <52141532.7020404@oracle.com> <52152A8B.5090307@oracle.com> <521536B8.2010501@oracle.com> <521628D5.9040500@oracle.com> <52165A0C.6080809@oracle.com> <52169F0C.50305@oracle.com> Message-ID: <521EB16F.8000302@oracle.com> As I suspected, there is a hole in the JLS: the immediately enclosing instance of an inner member class is determined by 15.9.2 but is not specified as being passed to the constructor of the inner member class by 15.9.3. The JLS _must_ specify that it is passed, for the reason given in 8misc.pdf: the member class may have been emitted by a compiler which is different than the compiler of the CICE, so there must be a standard way for the compiler of the CICE to transmit the immediately enclosing instance to the member class's constructor. 15.9.3 only remembers to pass an extra value to the constructor of an anonymous class whose superclass is inner; the value in that case is the immediately enclosing instance with respect to the superclass. (Assuming the superclass is not local in a static context, in which case there is no value to pass.) I have filed JDK-8023949 to change the JLS to reflect what Java compilers must have been doing since 1997. On 8/22/2013 4:30 PM, Eric McCorkle wrote: > On 08/22/13 14:35, Alex Buckley wrote: > >> Now the bad news: >> >> - The makeLocal case is incorrect. Since LocalTester is local, the >> only code that can instantiate it is in the body of the makeLocal >> method. This means the immediately enclosing instance of >> LocalTester can be transmitted to LocalTester's ctor in a >> proprietary manner; the JLS does not specify it. Hence, this$1 >> should be SYNTHETIC, not MANDATED. > > That would be a problem in javac's gen. OK. >> - The makeAnonExtendsLocal case is tricky. Please recognize that >> the constructor of the abstract class LocalTester is not the same >> thing as the constructor of the anonymous class whose superclass is >> LocalTester. names() et al in the abstract class LocalTester are >> necessarily identical to those in the class LocalTester in >> makeLocal; they should be removed from makeAnonExtendsLocal. Then, >> please add names() et al to the body of the anonymous class, akin >> to the anonymous class declared in makeAnonExtendsInner. What >> values are expected by the new names()? Good question. The >> anonymous class in makeAnonExtendsLocal has a superclass >> (LocalTester) which is inner but also local, so the spec is not >> clear how to transmit the immediately enclosing instance of the >> anonymous class with respect to the superclass. Again, I intend to >> clarify the spec ASAP. > > Let me know when you do, and I'll file an appropriate request. In makeAnonExtendsLocal, you have "return new LocalTester(2) {...}". This anonymous class has a superclass which is a local class not in a static context. JLS 15.9.3 always said to pass the immediately enclosing instance of the new object with respect to LocalTester to the anonymous class's constructor. Similarly, JLS 15.9.5.1 always said that the anonymous class's constructor has a first formal parameter of type Encloser (the class enclosing LocalTester). So the this$1 parameter in the constructor should be MANDATED. This case is interesting because the mandated first formal parameter doesn't really need to be specified; see the sidebar in JDK-8023949. But the JLS has been clear about this case since 1997, and it ties back to 15.9.2's determination of immediately enclosing instance with respect to the superclass. So it's not changeable now. Alex From erik.joelsson at oracle.com Thu Aug 29 00:43:52 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Thu, 29 Aug 2013 09:43:52 +0200 Subject: RFR : 8023892 : (xs) /test/Makefile should not try to tell langtools/test/Makefile where to put output In-Reply-To: <0A778193-9981-4E62-9C68-07D15EA04069@oracle.com> References: <0A778193-9981-4E62-9C68-07D15EA04069@oracle.com> Message-ID: <521EFBB8.30700@oracle.com> Looks OK from the build group. /Erik On 2013-08-29 03:51, Mike Duigou wrote: > Hello all; > > JDK-8023491 included a change which attempted to adjust the location that the langtools/test/Makefile used to write test results. This change conflicted with how the test/Makefiles are used by important scripts. This change backs out the langtools testing output location changes which were part of JDK-8023491. > > http://cr.openjdk.java.net/~mduigou/JDK-8023892/0/webrev > > The net effect is that langtools/test/Makefile will return to it's former behaviour and write it's test results to a non-standard location (outside of the build/$(CONF)/testoutput directory) until additional changeset(s) can be prepared to correct this problem. > > Sorry for any inconvenience this problem caused. All future changes impacting langtools test execution will include the compiler-dev mailing list. > > Mike From staffan.larsen at oracle.com Thu Aug 29 02:26:05 2013 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Thu, 29 Aug 2013 09:26:05 +0000 Subject: hg: jdk8/tl/jdk: 8023786: (jdk) setjmp/longjmp changes the process signal mask on OS X Message-ID: <20130829093110.91F276239C@hg.openjdk.java.net> Changeset: 779ff9f3b2e3 Author: sla Date: 2013-08-29 11:22 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/779ff9f3b2e3 8023786: (jdk) setjmp/longjmp changes the process signal mask on OS X Reviewed-by: dholmes ! src/share/back/SDE.c ! src/share/native/common/check_code.c From vicente.romero at oracle.com Thu Aug 29 02:43:28 2013 From: vicente.romero at oracle.com (Vicente-Arturo Romero-Zaldivar) Date: Thu, 29 Aug 2013 10:43:28 +0100 Subject: RFR : 8023892 : (xs) /test/Makefile should not try to tell langtools/test/Makefile where to put output In-Reply-To: <0A778193-9981-4E62-9C68-07D15EA04069@oracle.com> References: <0A778193-9981-4E62-9C68-07D15EA04069@oracle.com> Message-ID: <521F17C0.9080105@oracle.com> On 29/08/13 02:51, Mike Duigou wrote: > Hello all; > > JDK-8023491 included a change which attempted to adjust the location that the langtools/test/Makefile used to write test results. This change conflicted with how the test/Makefiles are used by important scripts. This change backs out the langtools testing output location changes which were part of JDK-8023491. > > http://cr.openjdk.java.net/~mduigou/JDK-8023892/0/webrev > > The net effect is that langtools/test/Makefile will return to it's former behaviour and write it's test results to a non-standard location (outside of the build/$(CONF)/testoutput directory) until additional changeset(s) can be prepared to correct this problem. > > Sorry for any inconvenience this problem caused. All future changes impacting langtools test execution will include the compiler-dev mailing list. > > Mike Looks OK to me. Vicente From dan.xu at oracle.com Thu Aug 29 10:44:20 2013 From: dan.xu at oracle.com (dan.xu at oracle.com) Date: Thu, 29 Aug 2013 17:44:20 +0000 Subject: hg: jdk8/tl/jdk: 4792059: test/java/io/pathNames/GeneralSolaris.java fails on symbolic links Message-ID: <20130829174445.5008B623C7@hg.openjdk.java.net> Changeset: 5bf4f2eeee85 Author: dxu Date: 2013-08-29 10:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5bf4f2eeee85 4792059: test/java/io/pathNames/GeneralSolaris.java fails on symbolic links Summary: Exclude the possible usage of linked files or directories in the test Reviewed-by: alanb ! test/java/io/pathNames/General.java From jan.lahoda at oracle.com Thu Aug 29 11:13:36 2013 From: jan.lahoda at oracle.com (Jan Lahoda) Date: Thu, 29 Aug 2013 20:13:36 +0200 Subject: Warnings getting past @SuppressWarnings In-Reply-To: References: Message-ID: <521F8F50.1010605@oracle.com> Hi Raluca, Thanks for the test case - I believe this behavior is a bug. This particular usecase was likely fixed by Vicente as bug 8016099: http://bugs.sun.com/view_bug.do?bug_id=8016099 Sadly, there are a handful of additional usecases where @SuppressWarnings does not currently work properly. I am looking into these currently. Thanks for the report, Jan On 08/28/2013 06:08 PM, Raluca Sauciuc wrote: > Hi compiler-dev, > > We ran into an unexpected behavior with javac7 and unchecked warnings. > Code that compiled without any warnings, by using @SuppressWarnings in a > few places, has started to display them again. > > Here's the simplest example I could find: > > public class Test { > > @SuppressWarnings("unchecked") > public static Foo of(Class type) { > return (Foo) cache.get(type); > } > > private static final Cache,Foo> cache = null; > > interface Cache { > V get(K key); > } > > interface Foo { > T newFoo(String name); > } > > interface Bar { } > } > > $ javac -Xlint:unchecked Test.java > Test.java:5: warning: [unchecked] unchecked cast > return (Foo) cache.get(type); > ^ > required: Foo > found: Foo > where T is a type-variable: > T extends Bar declared in method of(Class) > where CAP#1 is a fresh type-variable: > CAP#1 extends Bar from capture of ? > 1 warning > > The warning is legitimate, as Cache,Foo> loses > the constraint between key and value type, but we expect > @SuppressWarnings to silence it. Note that javac6 doesn't emit the warning. > > Is this expected behavior? > > Thanks, > Raluca From jonathan.gibbons at oracle.com Thu Aug 29 11:42:43 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Thu, 29 Aug 2013 18:42:43 +0000 Subject: hg: jdk8/tl/langtools: 8001669: javadoc internal DocletAbortException should set cause when appropriate Message-ID: <20130829184250.9071D623CF@hg.openjdk.java.net> Changeset: 0e6577980181 Author: jjg Date: 2013-08-29 11:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0e6577980181 8001669: javadoc internal DocletAbortException should set cause when appropriate Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/AllClassesFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/DeprecatedListWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/FrameOutputWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HelpWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDoclet.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageTreeWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ProfileIndexFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageIndexFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/SingleIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/SplitIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/TreeWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/Comment.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/DocType.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocument.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/RawHtml.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/StringContent.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Content.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AbstractBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AbstractMemberBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/LayoutParser.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/SerializedFormBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ValueTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/ClassUseMapper.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocFile.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocletAbortException.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/PackageListWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/PathDocFileFactory.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/SimpleDocFileFactory.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/StandardDocFileFactory.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Util.java From jonathan.gibbons at oracle.com Thu Aug 29 11:58:03 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Thu, 29 Aug 2013 18:58:03 +0000 Subject: hg: jdk8/tl/langtools: 8023522: tools/javac/tree/TypeAnnotationsPretty.java test cases with @TA newline fail on windows only Message-ID: <20130829185809.5FF98623D3@hg.openjdk.java.net> Changeset: b0b25c1f6cbd Author: jjg Date: 2013-08-29 11:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b0b25c1f6cbd 8023522: tools/javac/tree/TypeAnnotationsPretty.java test cases with @TA newline fail on windows only Reviewed-by: darcy ! test/tools/javac/tree/TypeAnnotationsPretty.java From jonathan.gibbons at oracle.com Thu Aug 29 12:04:23 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Thu, 29 Aug 2013 19:04:23 +0000 Subject: hg: jdk8/tl/langtools: 8013384: Potential infinite loop in javadoc Message-ID: <20130829190432.B1D57623D8@hg.openjdk.java.net> Changeset: 9c0e192c0926 Author: jjg Date: 2013-08-29 12:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9c0e192c0926 8013384: Potential infinite loop in javadoc Reviewed-by: darcy ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java From jonathan.gibbons at oracle.com Thu Aug 29 12:12:25 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Thu, 29 Aug 2013 19:12:25 +0000 Subject: hg: jdk8/tl/langtools: 8022744: javac -Xpkginfo command's documentation is sparse Message-ID: <20130829191232.EF632623DA@hg.openjdk.java.net> Changeset: 96b6865eda94 Author: jjg Date: 2013-08-29 12:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/96b6865eda94 8022744: javac -Xpkginfo command's documentation is sparse Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/main/Option.java From mike.duigou at oracle.com Thu Aug 29 16:05:12 2013 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Thu, 29 Aug 2013 23:05:12 +0000 Subject: hg: jdk8/tl: 8023892: test/Makefile shouldn't try to tell langtools/test/Makefile where to put output. Message-ID: <20130829230512.8E950623FC@hg.openjdk.java.net> Changeset: 51a61778a99d Author: mduigou Date: 2013-08-29 16:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/51a61778a99d 8023892: test/Makefile shouldn't try to tell langtools/test/Makefile where to put output. Reviewed-by: erikj, vromero, henryjen ! test/Makefile From jonathan.gibbons at oracle.com Thu Aug 29 19:20:32 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Fri, 30 Aug 2013 02:20:32 +0000 Subject: hg: jdk8/tl/langtools: 8023833: Replace direct use of AnnotatedType in javadoc code Message-ID: <20130830022040.35E3D62403@hg.openjdk.java.net> Changeset: 23f0f3c9c44a Author: jjg Date: 2013-08-29 19:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/23f0f3c9c44a 8023833: Replace direct use of AnnotatedType in javadoc code Reviewed-by: darcy ! src/share/classes/com/sun/tools/javadoc/AnnotatedTypeImpl.java ! src/share/classes/com/sun/tools/javadoc/TypeMaker.java ! src/share/classes/com/sun/tools/javadoc/TypeVariableImpl.java From xuelei.fan at oracle.com Thu Aug 29 18:59:41 2013 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Fri, 30 Aug 2013 01:59:41 +0000 Subject: hg: jdk8/tl/jdk: 8023881: IDN.USE_STD3_ASCII_RULES option is too strict to use Unicode in IDN.toASCII Message-ID: <20130830015953.C9E4362401@hg.openjdk.java.net> Changeset: cdf68747b0fb Author: xuelei Date: 2013-08-29 18:58 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cdf68747b0fb 8023881: IDN.USE_STD3_ASCII_RULES option is too strict to use Unicode in IDN.toASCII Reviewed-by: michaelm ! src/share/classes/java/net/IDN.java + test/java/net/IDN/UseSTD3ASCIIRules.java From shanliang.jiang at oracle.com Fri Aug 30 04:16:26 2013 From: shanliang.jiang at oracle.com (shanliang.jiang at oracle.com) Date: Fri, 30 Aug 2013 11:16:26 +0000 Subject: hg: jdk8/tl/jdk: 6566891: RMIConnector: map value referencing map key in WeakHashMap prevents map entry to be removed Message-ID: <20130830111652.648B762418@hg.openjdk.java.net> Changeset: 2d51653d9b4b Author: sjiang Date: 2013-08-30 12:49 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2d51653d9b4b 6566891: RMIConnector: map value referencing map key in WeakHashMap prevents map entry to be removed Reviewed-by: egahlin, jbachorik, dfuchs, dholmes ! src/share/classes/javax/management/remote/rmi/RMIConnector.java + test/javax/management/remote/mandatory/connection/RMIConnectorInternalMapTest.java + test/javax/management/remote/mandatory/connection/RMIConnectorNullSubjectConnTest.java From jonathan.gibbons at oracle.com Fri Aug 30 11:50:05 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Fri, 30 Aug 2013 18:50:05 +0000 Subject: hg: jdk8/tl/langtools: 8023700: Use non breaking space in various labels Message-ID: <20130830185013.C200E6243A@hg.openjdk.java.net> Changeset: 240f424cc0d5 Author: jjg Date: 2013-08-30 11:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/240f424cc0d5 8023700: Use non breaking space in various labels Reviewed-by: bpatel ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java ! test/com/sun/javadoc/testNavigation/TestNavigation.java ! test/com/sun/javadoc/testProfiles/TestProfiles.java From jonathan.gibbons at oracle.com Fri Aug 30 15:16:09 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Fri, 30 Aug 2013 22:16:09 +0000 Subject: hg: jdk8/tl/langtools: 8024093: Two *.rej files checked in to langtools/test directory Message-ID: <20130830221612.C01AF62443@hg.openjdk.java.net> Changeset: 3dd40e5715fb Author: jjg Date: 2013-08-30 15:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3dd40e5715fb 8024093: Two *.rej files checked in to langtools/test directory Reviewed-by: mchung - test/tools/javac/diags/examples/MrefStat.java.rej - test/tools/javac/diags/examples/MrefStat1.java.rej From bhavesh.x.patel at oracle.com Fri Aug 30 16:00:17 2013 From: bhavesh.x.patel at oracle.com (bhavesh.x.patel at oracle.com) Date: Fri, 30 Aug 2013 23:00:17 +0000 Subject: hg: jdk8/tl/langtools: 7198273: RFE : Javadoc Accessibility : Hyperlinks should contain text or an image with alt text Message-ID: <20130830230023.2444562447@hg.openjdk.java.net> Changeset: dd64288f5659 Author: bpatel Date: 2013-08-30 15:59 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/dd64288f5659 7198273: RFE : Javadoc Accessibility : Hyperlinks should contain text or an image with alt text Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlStyle.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/stylesheet.css ! test/com/sun/javadoc/AccessSkipNav/AccessSkipNav.java ! test/com/sun/javadoc/testNavigation/TestNavigation.java From bhavesh.x.patel at oracle.com Fri Aug 30 16:18:07 2013 From: bhavesh.x.patel at oracle.com (bhavesh.x.patel at oracle.com) Date: Fri, 30 Aug 2013 23:18:07 +0000 Subject: hg: jdk8/tl/langtools: 8015882: Javadoc prints NPE when using Taglet Message-ID: <20130830231814.D085462448@hg.openjdk.java.net> Changeset: 7a2fe98cb0e6 Author: bpatel Date: 2013-08-30 16:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7a2fe98cb0e6 8015882: Javadoc prints NPE when using Taglet Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/LegacyTaglet.java ! test/com/sun/javadoc/testLegacyTaglet/C.java + test/com/sun/javadoc/testLegacyTaglet/Check.java ! test/com/sun/javadoc/testLegacyTaglet/TestLegacyTaglet.java From jonathan.gibbons at oracle.com Fri Aug 30 16:27:42 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Fri, 30 Aug 2013 23:27:42 +0000 Subject: hg: jdk8/tl/langtools: 8008367: Sub-packages missing from Profiles javadoc Message-ID: <20130830232747.8DC6E6244C@hg.openjdk.java.net> Changeset: f050c714b556 Author: jjg Date: 2013-08-30 16:27 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f050c714b556 8008367: Sub-packages missing from Profiles javadoc Reviewed-by: bpatel ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java From bhavesh.x.patel at oracle.com Fri Aug 30 16:40:18 2013 From: bhavesh.x.patel at oracle.com (bhavesh.x.patel at oracle.com) Date: Fri, 30 Aug 2013 23:40:18 +0000 Subject: hg: jdk8/tl/langtools: 8022738: doclet should only generate functional interface text if source >= 8 Message-ID: <20130830234023.0A39A6244D@hg.openjdk.java.net> Changeset: b25e387481dc Author: bpatel Date: 2013-08-30 16:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b25e387481dc 8022738: doclet should only generate functional interface text if source >= 8 Reviewed-by: jjg ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java ! src/share/classes/com/sun/tools/javadoc/DocEnv.java ! test/com/sun/javadoc/testLambdaFeature/TestLambdaFeature.java + test/com/sun/javadoc/testLambdaFeature/pkg1/FuncInf.java From jonathan.gibbons at oracle.com Fri Aug 30 17:37:22 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Sat, 31 Aug 2013 00:37:22 +0000 Subject: hg: jdk8/tl/langtools: 8015663: Need to supply tests to provide javadoc for profiles support code coverage Message-ID: <20130831003729.303AE62453@hg.openjdk.java.net> Changeset: 7993cfab8610 Author: jjg Date: 2013-08-30 17:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7993cfab8610 8015663: Need to supply tests to provide javadoc for profiles support code coverage Reviewed-by: jjg Contributed-by: evgeniya.stepanova at oracle.com ! test/com/sun/javadoc/testProfiles/TestProfiles.java + test/com/sun/javadoc/testProfiles/TestProfilesConfiguration.java ! test/com/sun/javadoc/testProfiles/pkg2/Class1Pkg2.java + test/com/sun/javadoc/testProfiles/pkg2/ClassError.java + test/com/sun/javadoc/testProfiles/pkg2/ClassException.java + test/com/sun/javadoc/testProfiles/pkgDeprecated/Class1PkgDeprecated.java + test/com/sun/javadoc/testProfiles/pkgDeprecated/package-info.java ! test/com/sun/javadoc/testProfiles/profile-rtjar-includes.txt From dan.xu at oracle.com Fri Aug 30 16:46:11 2013 From: dan.xu at oracle.com (dan.xu at oracle.com) Date: Fri, 30 Aug 2013 23:46:11 +0000 Subject: hg: jdk8/tl/jdk: 8023765: Improve MaxPathLength.java testcase and reduce its test load; ... Message-ID: <20130830234645.ED4336244F@hg.openjdk.java.net> Changeset: 5b01c851bb1d Author: dxu Date: 2013-08-30 16:45 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5b01c851bb1d 8023765: Improve MaxPathLength.java testcase and reduce its test load 7160013: java/io/File/MaxPathLength.java fails Reviewed-by: alanb ! test/ProblemList.txt ! test/java/io/File/MaxPathLength.java From nit.dgp673 at gmail.com Wed Aug 21 20:37:44 2013 From: nit.dgp673 at gmail.com (Laxmi Narayan NIT DGP) Date: Thu, 22 Aug 2013 03:37:44 -0000 Subject: hg: jdk8/tl/jdk: 8022228: Intermittent test failures in sun/security/ssl/javax/net/ssl/NewAPIs In-Reply-To: <20130822024717.B922548A76@hg.openjdk.java.net> References: <20130822024717.B922548A76@hg.openjdk.java.net> Message-ID: is there are any chances of contribution for outsider of oracle and even student developers ?? * Laxmi Narayan Patel * * MCA NIT Durgapur (Pre final year) * * mob:- 8345847473 * On Thu, Aug 22, 2013 at 8:16 AM, wrote: > Changeset: ec827a62070a > Author: xuelei > Date: 2013-08-21 19:44 -0700 > URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ec827a62070a > > 8022228: Intermittent test failures in > sun/security/ssl/javax/net/ssl/NewAPIs > Reviewed-by: weijun > > ! test/sun/security/ssl/javax/net/ssl/NewAPIs/SessionCacheSizeTests.java > ! test/sun/security/ssl/javax/net/ssl/NewAPIs/SessionTimeOutTests.java > ! test/sun/security/ssl/templates/SSLSocketTemplate.java > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20130822/a690dc45/attachment.html