RFR: 8023146: Sjavac test failes in langtools nightly

Jonathan Gibbons jonathan.gibbons at oracle.com
Fri Aug 16 09:46:31 PDT 2013


Eric,

My apologies. Your fix is correct.  The functionality I was expecting is 
in SJavacWrapper.java

-- Jon

On 08/16/2013 09:28 AM, Jonathan Gibbons wrote:
> Eric,
>
> Please don't do this.  The correct solution is to make sure the test 
> passes vacuously when sjavac is not available.
>
> -- Jon
>
> On 08/16/2013 01:35 AM, Erik Joelsson wrote:
>> In JDK-8015145, I converted the test for sjavac into a jtreg test. 
>> This proved to be a mistake. Since sjavac isn't being shipped with 
>> the product, tests for it can't be included in the regression 
>> testsuite as they will not even compile when run against a product 
>> build.
>>
>> I propose to remove the jtreg declaration from this test to make it 
>> stop failing. This is just reverting what I did in the previous change.
>>
>> http://cr.openjdk.java.net/~erikj/8023146/webrev.langtools.01/
>>
>> /Erik
>



More information about the compiler-dev mailing list