Review request: update javac to properly output mandated parameters in MethodParameters attributes
Maurizio Cimadamore
maurizio.cimadamore at oracle.com
Tue Feb 12 08:22:16 PST 2013
On 12/02/13 16:17, Eric McCorkle wrote:
> Maybe make the one for ClassSymbol take a ClassSymbol as an argument as
> opposed to a Symbol?
Why do we need to replicate all that code?
Maurizio
>
> On 02/12/13 10:52, Maurizio Cimadamore wrote:
>> On 12/02/13 14:53, Eric McCorkle wrote:
>>> No, actually, that variant has to be there in order to add the outer
>>> this field in a ClassSymbol.
>> The overloading on Symbol/MethodSymbol is very hard to parse - i.e.
>> it's hard to tell whether a client would call one or the other. What I'm
>> suggesting is that, since both methods seem to share 99% of the code,
>> you add the extra logic to the old method guarded by a check (which I
>> think is sym.kind == MTH - i.e. if the symbl is a method).
>>
>> Maurizio
More information about the compiler-dev
mailing list