Request for Review JDK-8006948: Update javac for MethodParameters format change

Eric McCorkle eric.mccorkle at
Thu Feb 14 10:55:02 PST 2013

The changeset for 8006949 has been integrated into TL, so I want to move
towards pushing this one as well.  These changes allow hotspot to
recognize class files with both the old and the new format of flags.

I have updated the webrev to reflect some recent changes (pushed for
8006345 and others).

Note: there is a comprehensive test suite for the parameter reflection
feature that is about to be pushed.  I do not plan on submitting this
changeset until the tests have been pushed.

Please review and comment on the latest webrev.


On 01/25/13 12:49, Eric McCorkle wrote:
> Hello,
> Please review this change, which updates javac and the classfile library
> to reflect changes in the class file format of MethodParameters attributes.
> The webrev is here:
> The latest version of the spec can be found here:
> The enhancement request is here:
> Note that this will break compatibility with existing versions.
> Furthermore, the companion changeset for hotspot will go into hsx, and
> will take some time to propagate to TL.  However, there are no tests
> enabled at this point that rely on the old binary format, so there
> should be no JPRT failures arising from this fix.
> Thanks,
> Eric
-------------- next part --------------
A non-text attachment was scrubbed...
Name: eric_mccorkle.vcf
Type: text/x-vcard
Size: 314 bytes
Desc: not available
Url : 

More information about the compiler-dev mailing list