JDK-8015701: MethodParameters are not filled in for synthetic captured local variables
Maurizio Cimadamore
maurizio.cimadamore at oracle.com
Wed Jun 5 07:56:25 PDT 2013
I think it's ok - note that you can cache the result of proxyName() and
reuse it twice.
Maurizio
On 05/06/13 15:35, Eric McCorkle wrote:
> I moved that code outside initField. It leads to a bit more code
> duplication than I'd have liked, though.
>
> On 06/04/13 12:17, Maurizio Cimadamore wrote:
>> On 04/06/13 16:12, Eric McCorkle wrote:
>>> Any comments on this patch?
>> Having initField subtly changing stuff on the outer method symbol is not
>> good. Move that code outside the initField method, so that the symbol
>> update is very clear.
>>
>> Maurizio
>>> On 06/01/13 22:04, Eric McCorkle wrote:
>>>> I did. It's up there now.
>>>>
>>>> On 06/01/13 13:06, Jonathan Gibbons wrote:
>>>>> There's no test. Did you forget to hg add it?
>>>>>
>>>>> -- Jon
>>>>>
>>>>> On 06/01/2013 05:31 AM, Eric McCorkle wrote:
>>>>>> Hello,
>>>>>>
>>>>>> Please review this patch, which fixes the generation of
>>>>>> MethodParameters
>>>>>> entries for extra parameters to constructors for anonymous inner
>>>>>> classes.
>>>>>>
>>>>>> The webrev is here:
>>>>>> http://cr.openjdk.java.net/~emc/8015701/
>>>>>>
>>>>>> The bug report is here:
>>>>>> http://bugs.sun.com/view_bug.do?bug_id=8015701
>>>>>>
>>>>>> Thanks,
>>>>>> Eric
More information about the compiler-dev
mailing list