JDK-8015701: MethodParameters are not filled in for, synthetic captured local variables

[Vicente-Arturo Romero-Zaldivar]

Hi Eric,

Comments on the test:

- As the test is new you don't need to add 2012 in the Copyright section.
- import java.lang.Class can be removed.
- the test can be further simplified. You don't need the ParameterNames 
class, instead you can move the makeInner method from that class to 
AnonymousParameters class and later in the run method you can do: 
Class<?> cls = makeInner("hello").getClass(); keeping the rest unchanged.


Vicente.


> Date: Wed, 05 Jun 2013 10:35:45 -0400
> From: Eric McCorkle <eric.mccorkle at oracle.com>
> Subject: Re: JDK-8015701: MethodParameters are not filled in for
> 	synthetic	captured local variables
> To: Maurizio Cimadamore <maurizio.cimadamore at oracle.com>
> Cc: compiler-dev at openjdk.java.net
> Message-ID: <51AF4CC1.3090106 at oracle.com>
> Content-Type: text/plain; charset="utf-8"
>
> I moved that code outside initField.  It leads to a bit more code
> duplication than I'd have liked, though.
>
> On 06/04/13 12:17, Maurizio Cimadamore wrote:
>> On 04/06/13 16:12, Eric McCorkle wrote:
>>> Any comments on this patch?
>> Having initField subtly changing stuff on the outer method symbol is not
>> good. Move that code outside the initField method, so that the symbol
>> update is very clear.
>>
>> Maurizio
>>> On 06/01/13 22:04, Eric McCorkle wrote:
>>>> I did.  It's up there now.
>>>>
>>>> On 06/01/13 13:06, Jonathan Gibbons wrote:
>>>>> There's no test.  Did you forget to hg add it?
>>>>>
>>>>> -- Jon
>>>>>
>>>>> On 06/01/2013 05:31 AM, Eric McCorkle wrote:
>>>>>> Hello,
>>>>>>
>>>>>> Please review this patch, which fixes the generation of
>>>>>> MethodParameters
>>>>>> entries for extra parameters to constructors for anonymous inner
>>>>>> classes.
>>>>>>
>>>>>> The webrev is here:
>>>>>> http://cr.openjdk.java.net/~emc/8015701/
>>>>>>
>>>>>> The bug report is here:
>>>>>> http://bugs.sun.com/view_bug.do?bug_id=8015701
>>>>>>
>>>>>> Thanks,
>>>>>> Eric
>