Review request for JDK-8014230: Compilation incorrectly succeeds with inner class constructor with 254 parameters

Eric McCorkle eric.mccorkle at
Fri Jun 14 13:14:50 PDT 2013

Is there a more convenient API for checking error messages?  Golden will
make for an incredibly frail test, I think.

On 06/14/13 15:46, Jonathan Gibbons wrote:
> The change to Gen looks OK, but the tests look weak.  At a minimum, I
> would expect to see the test check the validity of the error message
> that is generated; even better would be to generate the test cases on
> the fly.
> -- Jon
> On 06/14/2013 11:29 AM, Eric McCorkle wrote:
>> Hello,
>> Please review this patch, which addresses a problem with javac not
>> taking inner this parameters into account when determining if there are
>> too many parameters to a function.
>> The webrev is here:
>> The bug report is here:
>> Thanks,
>> Eric
-------------- next part --------------
A non-text attachment was scrubbed...
Name: eric_mccorkle.vcf
Type: text/x-vcard
Size: 314 bytes
Desc: not available
Url : 

More information about the compiler-dev mailing list