Review request for JDK-8012722: Single comma in array initializer should parse

Jonathan Gibbons jonathan.gibbons at oracle.com
Mon Jun 24 10:53:48 PDT 2013


On 06/24/2013 10:24 AM, Eric McCorkle wrote:
> Hello,
>
> Please review this simple patch which updates the javac parser to accept
> array constants in the form of @Foo({,}) in accordance with JLS 9.7.1.
>
> The webrev is here:
> http://cr.openjdk.java.net/~emc/8012722/
>
> The bug report is here:
> http://bugs.sun.com/view_bug.do?bug_id=8012722
>
> Thanks,
> Eric

OK, but the negative test would be better if you checked it failed for the
right reason, perhaps by using -XDrawDiagnostics and a .out file, per
\the prevailing standard.

-- Jon


More information about the compiler-dev mailing list