Code review request for more informative comments in SourceVersion

Jonathan Gibbons jonathan.gibbons at oracle.com
Thu Jun 27 11:10:43 PDT 2013


Looks good to me.

--Jon

On 06/27/2013 10:48 AM, Joe Darcy wrote:
> Hello,
>
> It was recently been brought to my attention that the SourceVersion 
> enum in javax.lang.model did not have informative descriptions of the 
> language changes in Java SE 7 and 8.
>
> Please review the patch below which add this information.
>
> Thanks,
>
> -Joe
>
> --- a/src/share/classes/javax/lang/model/SourceVersion.java    Thu Jun 
> 27 00:37:13 2013 -0400
> +++ b/src/share/classes/javax/lang/model/SourceVersion.java    Thu Jun 
> 27 10:42:25 2013 -0700
> @@ -53,6 +53,8 @@
>       * 1.4: assert
>       * 1.5: annotations, generics, autoboxing, var-args...
>       * 1.6: no changes
> +     * 1.7: diamond syntax, try-with-resources, etc.
> +     * 1.8: lambda and default methods
>       */
>
>      /**
> @@ -122,6 +124,9 @@
>       * The version recognized by the Java Platform, Standard Edition
>       * 7.
>       *
> +     * Additions in this release include, diamond syntax for
> +     * constructors, {@code try}-with-resources, strings in switch,
> +     * binary literals, and multi-catch.
>       * @since 1.7
>       */
>      RELEASE_7,
> @@ -130,6 +135,7 @@
>       * The version recognized by the Java Platform, Standard Edition
>       * 8.
>       *
> +     * Additions in this release include lambda expression and 
> default methods.
>       * @since 1.8
>       */
>      RELEASE_8;
>



More information about the compiler-dev mailing list