RFR: 8020779 & 8026988 : Improvements to JTReg executable location handling

Erik Joelsson erik.joelsson at oracle.com
Thu Nov 7 01:24:56 PST 2013


Hello Mike,

I think this looks good. A couple of comments that don't necessarily 
call for any changes.

The version check is commented out, when is it planned to be activated?

I see you use 'which' as a fallback in the makefiles. Just be aware that 
we have had some trouble using the which command in the past. Sometimes 
on Solaris it gives unexpected output depending on your environment and 
the behavior on fail is different on various platforms and 
implementations. It looks like you are trying to handle all the weird 
cases though.

/Erik

On 2013-11-06 21:40, Mike Duigou wrote:
> Hello all;
>
> With JDK-8015068 only very recently pushed it's time for the next set of jtreg test/Makfile changes. These changes improve the configure script detection of jtreg and improve the handling of the specification variables in the jdk and langtools test/Makefiles. This changeset is also the first step in syncing the two test/Makefiles. More will follow which will further simplify the integration of testing into the overall build/test process.
>
> http://cr.openjdk.java.net/~mduigou/JDK-8020779/0/webrev/
>
> Mike



More information about the compiler-dev mailing list