path caching in Locations.java is broken

Jonathan Gibbons jonathan.gibbons at oracle.com
Fri Nov 8 13:10:07 PST 2013


Martin,

It's not so much about using JavaCompilers separate from JavacTasks, 
it's more about the file managers involved.

Within the langtools test suite we reuse file managers across multiple 
JavacTasks for efficiency, but when we do, we use the API methods to 
get/setLocation, and not the command line options.  So, gnerally, I 
think that folk doing one-off operations may choose to use the command 
line options to set paths, folk using file managers extensively are more 
likely to use API to set paths.

That's not to say that Liam's comment is not a reasonable one; in fact 
I'm pretty sure it's a duplicate of a much older issue, but I haven't 
had time to track that one down yet.

-- Jon



On 11/08/2013 12:59 PM, Martin Buchholz wrote:
> My hypothesis is that few people create JavaCompilers independently of 
> the JavacTasks created from them, so it's rare for configuration 
> options of the file manager to interact with different configuration 
> options of the compilation itself.  Which is why there aren't too many 
> people screaming about this?!
>
>
> On Fri, Nov 8, 2013 at 8:51 AM, Liam Miller-Cushon <cushon at google.com 
> <mailto:cushon at google.com>> wrote:
>
>     Hello,
>
>     I encountered what appears to be a serious problem with the path
>     caching in Locations.java. A demo is attached. What's to be done?
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20131108/80d7e96e/attachment.html 


More information about the compiler-dev mailing list