RFR 8054461: Add @file support to sjavac

Jonathan Gibbons jonathan.gibbons at oracle.com
Fri Aug 8 18:53:08 UTC 2014

On 08/08/2014 09:11 AM, Andreas Lundblad wrote:
> On Fri, Aug 08, 2014 at 09:44:23AM +0200, Fredrik Öhrström wrote:
>> See update:
>> http://cr.openjdk.java.net/~ohrstrom/webrev-8054461-atfile-v2/
> I don't really like the idea of Sjavac.java:
>    * @summary Test all aspects of sjavac.
> Can't we try to have one test per feature / bug?
> Code looks good.
> -- Andreas

Note that the need for the overhead of the test wrapper classes has gone 
away, which makes it easier to have a test per feature/bug.

I'm OK with multiple test cases within a test (it's a style issue that 
can go either way) but I would note that these days we are focussing on 
verifying that the tests for a feature do at least minimally execute the 
new or modified code for the feature.  You can do this with the jcov 
support for checking the coverage of the new or modified code in a 
patch, and you can easily access this functionality from recent releases 
of jtreg.

-- Jon

More information about the compiler-dev mailing list