RFR 8054465: Add --permit-unidentified-artifact=bar.txt support to sjavac

[Jonathan Gibbons]

Approved

-- Jon

On 08/08/2014 01:41 PM, Fredrik Öhrström wrote:
> Added semantic test and renamed the option to --permit-artifact=
>
> http://cr.openjdk.java.net/~ohrstrom/webrev-8054465-permit-v2/ 
> <http://cr.openjdk.java.net/%7Eohrstrom/webrev-8054465-permit-v2/>
>
>
> 2014-08-08 22:39 GMT+02:00 Fredrik Öhrström <oehrstroem at gmail.com 
> <mailto:oehrstroem at gmail.com>>:
>
>     Added semantic test and renamed the option to --permit-artifact=
>
>
>
>
>     2014-08-08 17:51 GMT+02:00 Andreas Lundblad
>     <andreas.lundblad at oracle.com <mailto:andreas.lundblad at oracle.com>>:
>
>         On Wed, Aug 06, 2014 at 11:22:36PM +0200, Fredrik Öhrström wrote:
>         > The --permit-unidentified-artifacts option is too broad for
>         many use cases.
>         >
>         > White-listing is more safe for many use cases, thus
>         > --permit-unidentified-artifact=bar.txt
>         > will allow bar.txt to remain within the destination dir and
>         be ignored by
>         > sjavac.
>         >
>         > http://cr.openjdk.java.net/~ohrstrom/webrev-8054465-permit/
>         <http://cr.openjdk.java.net/%7Eohrstrom/webrev-8054465-permit/>
>         >
>         > https://bugs.openjdk.java.net/browse/JDK-8054465
>         >
>         > //Fredrik
>
>         I suggest you add a test that tests the semantics of the
>         option as well (and not just the option decoding).
>
>         Other than that it looks good.
>
>         -- Andreas
>
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20140808/ffa86549/attachment.html>