RFR: JDK-8055767: Sjavac is leaking servers

[Marcus Lagergren]

+1

On 21 Aug 2014, at 16:58, Erik Joelsson <erik.joelsson at oracle.com> wrote:

> Hello,
> 
> Please review this simple fix to a rather annoying problem. Since JDK-8044131, Sjavac is never shutting down the server, at least not on Unix platforms. I have just killed a big bunch of stale servers in JPRT.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8055767
> Patch inline:
> 
> diff -r 4d1ea4477956 src/jdk.compiler/share/classes/com/sun/tools/sjavac/server/SjavacServer.java
> --- a/src/jdk.compiler/share/classes/com/sun/tools/sjavac/server/SjavacServer.java
> +++ b/src/jdk.compiler/share/classes/com/sun/tools/sjavac/server/SjavacServer.java
> @@ -310,7 +310,7 @@
> 
>     @Override
>     public void shutdown(String quitMsg) {
> -        if (!keepAcceptingRequests.compareAndSet(false, true)) {
> +        if (!keepAcceptingRequests.compareAndSet(true, false)) {
>             // Already stopped, no need to shut down again
>             return;
>         }
> 
> /Erik

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 842 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20140822/b2448df9/signature.asc>