RFR: 8054717: SJavac should track changes in the public apis of classpath classes!
Erik Joelsson
erik.joelsson at oracle.com
Thu Dec 11 11:43:07 UTC 2014
Hello,
This version seems to be working quite well for me at least. Only thing
I've noticed is a confusing log message. After a full build:
$ touch jdk/src/java.base/share/classes/java/lang/Object.java
$ make LOG=info
...
Compiling java.base
Starting server. Command: /localhome/java/default/bin/java -d64 -Xms512M
-Xmx2048M
-Xbootclasspath/p:/localhome/hg/jdk9-dev-sjavacpatch/build/linux-x86_64-normal-server-release/buildtools/interim_langtools.jar
-cp
/localhome/hg/jdk9-dev-sjavacpatch/build/linux-x86_64-normal-server-release/buildtools/interim_langtools.jar
com.sun.tools.sjavac.Main
--startserver:portfile=/localhome/hg/jdk9-dev-sjavacpatch/build/linux-x86_64-normal-server-release/javacservers/server.port,logfile=/localhome/hg/jdk9-dev-sjavacpatch/build/linux-x86_64-normal-server-release/javacservers/server.port.javaclog,stdouterrfile=/localhome/hg/jdk9-dev-sjavacpatch/build/linux-x86_64-normal-server-release/javacservers/server.port.stdouterr,poolsize=32,keepalive=120
Trying to connect. Attempt 1 of 3
Connected
Compiling java.lang(118) (with 1 dependents)
Trying to connect. Attempt 1 of 3
Connected
The pubapi of java.lang.Character has changed!
...
I'm pretty sure java.lang.Character didn't change and sjavac seems to be
behaving correctly by not acting like it has. I'm also wondering why the
messages about connect are printed twice. I'm fine with fixing this in a
followup bug.
/Erik
On 2014-12-11 11:45, Andreas Lundblad wrote:
> On Thu, Dec 04, 2014 at 04:59:33PM +0100, Andreas Lundblad wrote:
>> On Thu, Nov 27, 2014 at 02:26:18AM +0100, Andreas Lundblad wrote:
>>> [...]
>>>
>>> Link to web review:
>>> http://cr.openjdk.java.net/~alundblad/8054717
>>>
>>> Link to bug report:
>>> http://bugs.openjdk.java.net/browse/JDK-8054717
>>>
>>> -- Andreas Lundblad
> Another revision up for review.
>
> This fixes a bug where sjavac erroneously compiled too many files after just touching a source file.
>
> -- Andreas
More information about the compiler-dev
mailing list