Review Request : JDK-8031670: remove unneeded -source option from javadoc tests

[Joseph Darcy]

Hi Neil,

On the removal of

     test/tools/javadoc/sourceOption/SourceOption.java

after your patch is there some remaining javadoc test which uses the 
-source option? We probably want to keep one test which uses to the 
option to make sure it is supported. If there is no such remaining test, 
SourceOption.java could be resurrected and make to check that a JDK 8 
feature is rejected under source 7, etc.

Otherwise, the removal of the other -source uses looks fine.

Thanks,

-Joe

On 2/19/2014 7:37 AM, Vicente-Arturo Romero-Zaldivar wrote:
> Hi Neil,
>
> there is a typo at test/tools/javadoc/6964914/JavacWarning.java:
>
> "It *amy* be deprecated in JDK8"
>
> at test/com/sun/javadoc/testLambdaFeature/TestLambdaFeature.java:
>
> I would add the note as an independent comment after the
>
> * @test
> * @bug      8004893 8022738
> section not as part of it.
>
> Vicente
>
> On 18/02/14 21:10, Neil Toda wrote:
>>
>> A small set of javadoc tests contain the -source parameter.  In most 
>> cases, the parameter is
>> not required for the test.  In several cases, the -source parameter 
>> is being explicitly tested,
>> but relies on a JDK version that will be removed from JDK9.
>>
>> This changeset removes unnecessary -source specification when not 
>> needed, or changes the
>> test/source-version requested to one that will work in JDK9.
>>
>> http://cr.openjdk.java.net/~darcy/neiltoda/8031670.0/
>>
>> Thanks
>>
>> -neil
>>
>>
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20140219/f27ef68b/attachment.html