Review Request : JDK-8031670: remove unneeded -source option from javadoc tests

Joseph Darcy joe.darcy at
Fri Feb 21 15:19:20 PST 2014

On 2/21/2014 1:28 PM, Neil Toda wrote:
> Hi Vicente..  some additional thoughts/comments below...
> On 2/21/2014 12:53 PM, Vicente-Arturo Romero-Zaldivar wrote:
>> Hi Neil,
>> On 21/02/14 01:25, Neil Toda wrote:
>>> There is another test that does a negative check on a feature, 
>>> testLambdaFeature.
>>> However, it too will stop working when support for 1.7 is removed 
>>> from the JDK.
>>> Granted that will be several years from now, but by then we'll all 
>>> forget and just
>>> remove the negative test.
>> I hope that we won't ever remove negative tests just because they fail.
> This test has two parts.  The first checks to see that lambda is 
> recognized.
> The second part checks that if the version supplied via -source does 
> not support
> lambda, the case is correctly handled.
> When 1.7 is no longer supported in the JDK, then specifying "-source 
> 1.7" will not be
> valid.  At that point, all supported versions will support lambda.
> So I mean that in that case, the second part of the test is no longer 
> needed nor valid.
>>> I think I've made a mistake taking out the ./sourceOption test.  It 
>>> is better that this
>>> test exist and be specifically designed to make sure -source is working.
>> Agree.
> So, below when you say you'd like to see the proposed change, you are 
> referring to statement
> about leaving ./sourceOption in?  I'm just suggesting that my note 
> below be added to ./sourceOption
> in the form of comment giving guidance for future releases, when 1.6, 
> then 1.7 is no longer supported.

As a general comment, with the new policy on managing -source / -target 
options, one of the new start of release tasks will be cleaning out 
stale uses of the source/target value that is going to be dropped in the 
next release. (Since JDK 9 is the first full implementation of this 
policy, we have more work to do this time priming the pump.)

-------------- next part --------------
An HTML attachment was scrubbed...

More information about the compiler-dev mailing list