From bhavesh.x.patel at oracle.com Thu Jan 2 02:17:42 2014 From: bhavesh.x.patel at oracle.com (bhavesh.x.patel at oracle.com) Date: Thu, 02 Jan 2014 10:17:42 +0000 Subject: hg: jdk8/tl/langtools: 8029143: javadoc standard doclet should add Functional Interface blurb when @FunctionalInterface annotation is present Message-ID: <20140102101745.F3C9D62FD7@hg.openjdk.java.net> Changeset: 4a6f853f8721 Author: bpatel Date: 2014-01-02 02:15 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4a6f853f8721 8029143: javadoc standard doclet should add Functional Interface blurb when @FunctionalInterface annotation is present Reviewed-by: jjg ! src/share/classes/com/sun/javadoc/ClassDoc.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java ! src/share/classes/com/sun/tools/javadoc/RootDocImpl.java ! test/com/sun/javadoc/testLambdaFeature/TestLambdaFeature.java ! test/com/sun/javadoc/testLambdaFeature/pkg/A.java ! test/com/sun/javadoc/testLambdaFeature/pkg1/FuncInf.java + test/com/sun/javadoc/testLambdaFeature/pkg1/NotAFuncInf.java From chris.hegarty at oracle.com Thu Jan 2 22:58:37 2014 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Fri, 03 Jan 2014 06:58:37 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20140103065950.CE6EF62FEB@hg.openjdk.java.net> Changeset: 18080cca998a Author: dl Date: 2014-01-03 06:22 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/18080cca998a 8031133: AbstractMap should specify its default implementation using @implSpec Reviewed-by: chegar, alanb ! src/share/classes/java/util/AbstractMap.java Changeset: 33a60ce1e35d Author: chegar Date: 2014-01-03 06:23 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/33a60ce1e35d Merge ! src/share/classes/java/util/AbstractMap.java From gunnar at hibernate.org Fri Jan 3 02:12:51 2014 From: gunnar at hibernate.org (Gunnar Morling) Date: Fri, 3 Jan 2014 11:12:51 +0100 Subject: Compilation failure on JDK 8 involving inferred generic type Message-ID: Hi, I'm investigating a compilation error which I'm seeing when compiling the Bean Validation TCK using JDK 8 (build 121). The following example shows the issue: public class GenericsTest { public class Input> {} public class Output> {} public class OutputContainer> {} public , I extends Input> OutputContainer process( Class inputType) { return null; } public void testProcess() { Class inputType = null; //next line compiles with source level 1.7 but fails with source level 1.8 OutputContainer outputContainer = process( inputType ); } } This code used to compile with JDK 7 and it also does with JDK 8, when using 1.7 as source level. But it fails with source level 1.8, saying: "incompatible types: inferred type does not conform to upper bound(s)" I can make the code compile when declaring the outputContainer variable of the raw type OutputContainer instead of declaring it with the wildcard parameter. Is this an intentional change in JDK 8 or is it some kind of regression? If it is intentional, maybe the error message should be a bit more descriptive, mentioning the concerned inferred type and the bounds? Many thanks, --Gunnar -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20140103/a8d76a3e/attachment.html From sean.coffey at oracle.com Fri Jan 3 08:47:54 2014 From: sean.coffey at oracle.com (sean.coffey at oracle.com) Date: Fri, 03 Jan 2014 16:47:54 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20140103164849.42D2E62FFC@hg.openjdk.java.net> Changeset: 46c727d6ecc2 Author: aefimov Date: 2013-12-30 16:46 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/46c727d6ecc2 8025051: Update resource files for TimeZone display names Reviewed-by: okutsu, mfang ! src/share/classes/sun/util/resources/de/TimeZoneNames_de.java ! src/share/classes/sun/util/resources/es/TimeZoneNames_es.java ! src/share/classes/sun/util/resources/fr/TimeZoneNames_fr.java ! src/share/classes/sun/util/resources/it/TimeZoneNames_it.java ! src/share/classes/sun/util/resources/ja/TimeZoneNames_ja.java ! src/share/classes/sun/util/resources/ko/TimeZoneNames_ko.java ! src/share/classes/sun/util/resources/pt/TimeZoneNames_pt_BR.java ! src/share/classes/sun/util/resources/sv/TimeZoneNames_sv.java ! src/share/classes/sun/util/resources/zh/TimeZoneNames_zh_CN.java ! src/share/classes/sun/util/resources/zh/TimeZoneNames_zh_TW.java ! test/java/util/Calendar/GenericTimeZoneNamesTest.sh ! test/sun/util/resources/TimeZone/Bug6317929.java + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNamesTest.java + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_de.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_de_short.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_es.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_es_short.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_fr.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_fr_short.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_it.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_it_short.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_ja.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_ja_short.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_ko.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_ko_short.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_pt_BR.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_pt_BR_short.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_short.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_sv.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_sv_short.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_zh_CN.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_zh_CN_short.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_zh_TW.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_zh_TW_short.properties Changeset: c0970860803e Author: coffeys Date: 2014-01-03 16:45 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c0970860803e Merge From joe.darcy at oracle.com Fri Jan 3 11:39:28 2014 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Fri, 03 Jan 2014 19:39:28 +0000 Subject: hg: jdk8/tl/jdk: 8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity" Message-ID: <20140103193957.9AB6C6235D@hg.openjdk.java.net> Changeset: 68de5492a06d Author: darcy Date: 2014-01-03 11:38 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/68de5492a06d 8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity" Reviewed-by: mduigou, psandoz ! src/share/classes/java/util/DoubleSummaryStatistics.java ! src/share/classes/java/util/stream/Collectors.java ! src/share/classes/java/util/stream/DoublePipeline.java ! test/java/util/stream/TestDoubleSumAverage.java From daniel.fuchs at oracle.com Mon Jan 6 10:40:18 2014 From: daniel.fuchs at oracle.com (daniel.fuchs at oracle.com) Date: Mon, 06 Jan 2014 18:40:18 +0000 Subject: hg: jdk8/tl/jdk: 8030850: Setting .level=FINEST in logging configuration file doesn't work Message-ID: <20140106184132.99103623E5@hg.openjdk.java.net> Changeset: d77a1c9fd5b8 Author: dfuchs Date: 2013-12-22 11:20 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d77a1c9fd5b8 8030850: Setting .level=FINEST in logging configuration file doesn't work Summary: setLevel(INFO) was called too early on root logger, causing the value found in configuration file to be later ignored. Reviewed-by: mchung ! src/share/classes/java/util/logging/LogManager.java + test/java/util/logging/RootLogger/RootLevelInConfigFile.java + test/java/util/logging/RootLogger/rootlogger.properties From roger.riggs at oracle.com Tue Jan 7 09:29:07 2014 From: roger.riggs at oracle.com (roger.riggs at oracle.com) Date: Tue, 07 Jan 2014 17:29:07 +0000 Subject: hg: jdk8/tl/jdk: 8031103: java.time.Duration has wrong Javadoc Comments in toDays() and toHours() Message-ID: <20140107172936.C23DA6242B@hg.openjdk.java.net> Changeset: 1b503dd54b95 Author: rriggs Date: 2014-01-07 11:50 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1b503dd54b95 8031103: java.time.Duration has wrong Javadoc Comments in toDays() and toHours() Summary: Correct specification for Duration.toDays, toHours Reviewed-by: lancea, alanb ! src/share/classes/java/time/Duration.java From joe.darcy at oracle.com Tue Jan 7 12:00:53 2014 From: joe.darcy at oracle.com (Joe Darcy) Date: Tue, 07 Jan 2014 12:00:53 -0800 Subject: JDK 9 RFR of JDK-8031360: Update langtools code base to use RELEASE_9 Message-ID: <52CC5CF5.4030704@oracle.com> Hello, Please review the patch below for JDK-8031360: Update langtools code base to use RELEASE_9 which further updates the langtools code base to use the SourceVersion.RELEASE_9 constant. Thanks, -Joe /* - * Copyright (c) 2002, 2013, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2002, 2014, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -251,7 +251,7 @@ case JDK1_8: return RELEASE_8; case JDK1_9: - return RELEASE_8; // Adjust once RELEASE_9 exists + return RELEASE_9; default: return null; } diff -r 0d0ca880c22e src/share/classes/com/sun/tools/javac/processing/PrintingProcessor.java --- a/src/share/classes/com/sun/tools/javac/processing/PrintingProcessor.java Tue Jan 07 11:43:56 2014 -0800 +++ b/src/share/classes/com/sun/tools/javac/processing/PrintingProcessor.java Tue Jan 07 12:00:32 2014 -0800 @@ -49,7 +49,7 @@ * deletion without notice. */ @SupportedAnnotationTypes("*") - at SupportedSourceVersion(SourceVersion.RELEASE_8) + at SupportedSourceVersion(SourceVersion.RELEASE_9) public class PrintingProcessor extends AbstractProcessor { PrintWriter writer; diff -r 0d0ca880c22e test/tools/javac/lib/JavacTestingAbstractProcessor.java --- a/test/tools/javac/lib/JavacTestingAbstractProcessor.java Tue Jan 07 11:43:56 2014 -0800 +++ b/test/tools/javac/lib/JavacTestingAbstractProcessor.java Tue Jan 07 12:00:32 2014 -0800 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2010, 2011, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2010, 2014, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -102,7 +102,7 @@ * corresponding platform visitor type. */ - @SupportedSourceVersion(RELEASE_8) + @SupportedSourceVersion(RELEASE_9) public static abstract class AbstractAnnotationValueVisitor extends AbstractAnnotationValueVisitor8 { /** @@ -113,7 +113,7 @@ } } - @SupportedSourceVersion(RELEASE_8) + @SupportedSourceVersion(RELEASE_9) public static abstract class AbstractElementVisitor extends AbstractElementVisitor8 { /** * Constructor for concrete subclasses to call. @@ -123,7 +123,7 @@ } } - @SupportedSourceVersion(RELEASE_8) + @SupportedSourceVersion(RELEASE_9) public static abstract class AbstractTypeVisitor extends AbstractTypeVisitor8 { /** * Constructor for concrete subclasses to call. @@ -133,7 +133,7 @@ } } - @SupportedSourceVersion(RELEASE_8) + @SupportedSourceVersion(RELEASE_9) public static class ElementKindVisitor extends ElementKindVisitor8 { /** * Constructor for concrete subclasses; uses {@code null} for the @@ -154,7 +154,7 @@ } } - @SupportedSourceVersion(RELEASE_8) + @SupportedSourceVersion(RELEASE_9) public static class ElementScanner extends ElementScanner8 { /** * Constructor for concrete subclasses; uses {@code null} for the @@ -173,7 +173,7 @@ } } - @SupportedSourceVersion(RELEASE_8) + @SupportedSourceVersion(RELEASE_9) public static class SimpleAnnotationValueVisitor extends SimpleAnnotationValueVisitor8 { /** * Constructor for concrete subclasses; uses {@code null} for the @@ -194,7 +194,7 @@ } } - @SupportedSourceVersion(RELEASE_8) + @SupportedSourceVersion(RELEASE_9) public static class SimpleElementVisitor extends SimpleElementVisitor8 { /** * Constructor for concrete subclasses; uses {@code null} for the @@ -215,7 +215,7 @@ } } - @SupportedSourceVersion(RELEASE_8) + @SupportedSourceVersion(RELEASE_9) public static class SimpleTypeVisitor extends SimpleTypeVisitor8 { /** * Constructor for concrete subclasses; uses {@code null} for the @@ -236,7 +236,7 @@ } } - @SupportedSourceVersion(RELEASE_8) + @SupportedSourceVersion(RELEASE_9) public static class TypeKindVisitor extends TypeKindVisitor8 { /** * Constructor for concrete subclasses to call; uses {@code null} From jonathan.gibbons at oracle.com Tue Jan 7 12:54:31 2014 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Tue, 07 Jan 2014 12:54:31 -0800 Subject: JDK 9 RFR of JDK-8031360: Update langtools code base to use RELEASE_9 In-Reply-To: <52CC5CF5.4030704@oracle.com> References: <52CC5CF5.4030704@oracle.com> Message-ID: <52CC6987.3090306@oracle.com> Looks good to me. -- Jon On 01/07/2014 12:00 PM, Joe Darcy wrote: > Hello, > > Please review the patch below for > > JDK-8031360: Update langtools code base to use RELEASE_9 > > which further updates the langtools code base to use the > SourceVersion.RELEASE_9 constant. > > Thanks, > > -Joe > > /* > - * Copyright (c) 2002, 2013, Oracle and/or its affiliates. All rights > reserved. > + * Copyright (c) 2002, 2014, Oracle and/or its affiliates. All rights > reserved. > * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > * > * This code is free software; you can redistribute it and/or modify it > @@ -251,7 +251,7 @@ > case JDK1_8: > return RELEASE_8; > case JDK1_9: > - return RELEASE_8; // Adjust once RELEASE_9 exists > + return RELEASE_9; > default: > return null; > } > diff -r 0d0ca880c22e > src/share/classes/com/sun/tools/javac/processing/PrintingProcessor.java > --- > a/src/share/classes/com/sun/tools/javac/processing/PrintingProcessor.java > Tue Jan 07 11:43:56 2014 -0800 > +++ > b/src/share/classes/com/sun/tools/javac/processing/PrintingProcessor.java > Tue Jan 07 12:00:32 2014 -0800 > @@ -49,7 +49,7 @@ > * deletion without notice. > */ > @SupportedAnnotationTypes("*") > - at SupportedSourceVersion(SourceVersion.RELEASE_8) > + at SupportedSourceVersion(SourceVersion.RELEASE_9) > public class PrintingProcessor extends AbstractProcessor { > PrintWriter writer; > > diff -r 0d0ca880c22e > test/tools/javac/lib/JavacTestingAbstractProcessor.java > --- a/test/tools/javac/lib/JavacTestingAbstractProcessor.java Tue Jan > 07 11:43:56 2014 -0800 > +++ b/test/tools/javac/lib/JavacTestingAbstractProcessor.java Tue Jan > 07 12:00:32 2014 -0800 > @@ -1,5 +1,5 @@ > /* > - * Copyright (c) 2010, 2011, Oracle and/or its affiliates. All rights > reserved. > + * Copyright (c) 2010, 2014, Oracle and/or its affiliates. All rights > reserved. > * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > * > * This code is free software; you can redistribute it and/or modify it > @@ -102,7 +102,7 @@ > * corresponding platform visitor type. > */ > > - @SupportedSourceVersion(RELEASE_8) > + @SupportedSourceVersion(RELEASE_9) > public static abstract class AbstractAnnotationValueVisitor > extends AbstractAnnotationValueVisitor8 { > > /** > @@ -113,7 +113,7 @@ > } > } > > - @SupportedSourceVersion(RELEASE_8) > + @SupportedSourceVersion(RELEASE_9) > public static abstract class AbstractElementVisitor extends > AbstractElementVisitor8 { > /** > * Constructor for concrete subclasses to call. > @@ -123,7 +123,7 @@ > } > } > > - @SupportedSourceVersion(RELEASE_8) > + @SupportedSourceVersion(RELEASE_9) > public static abstract class AbstractTypeVisitor extends > AbstractTypeVisitor8 { > /** > * Constructor for concrete subclasses to call. > @@ -133,7 +133,7 @@ > } > } > > - @SupportedSourceVersion(RELEASE_8) > + @SupportedSourceVersion(RELEASE_9) > public static class ElementKindVisitor extends > ElementKindVisitor8 { > /** > * Constructor for concrete subclasses; uses {@code null} for > the > @@ -154,7 +154,7 @@ > } > } > > - @SupportedSourceVersion(RELEASE_8) > + @SupportedSourceVersion(RELEASE_9) > public static class ElementScanner extends > ElementScanner8 { > /** > * Constructor for concrete subclasses; uses {@code null} for > the > @@ -173,7 +173,7 @@ > } > } > > - @SupportedSourceVersion(RELEASE_8) > + @SupportedSourceVersion(RELEASE_9) > public static class SimpleAnnotationValueVisitor extends > SimpleAnnotationValueVisitor8 { > /** > * Constructor for concrete subclasses; uses {@code null} for > the > @@ -194,7 +194,7 @@ > } > } > > - @SupportedSourceVersion(RELEASE_8) > + @SupportedSourceVersion(RELEASE_9) > public static class SimpleElementVisitor extends > SimpleElementVisitor8 { > /** > * Constructor for concrete subclasses; uses {@code null} for > the > @@ -215,7 +215,7 @@ > } > } > > - @SupportedSourceVersion(RELEASE_8) > + @SupportedSourceVersion(RELEASE_9) > public static class SimpleTypeVisitor extends > SimpleTypeVisitor8 { > /** > * Constructor for concrete subclasses; uses {@code null} for > the > @@ -236,7 +236,7 @@ > } > } > > - @SupportedSourceVersion(RELEASE_8) > + @SupportedSourceVersion(RELEASE_9) > public static class TypeKindVisitor extends > TypeKindVisitor8 { > /** > * Constructor for concrete subclasses to call; uses {@code > null} > From erik.joelsson at oracle.com Wed Jan 8 06:24:24 2014 From: erik.joelsson at oracle.com (erik.joelsson at oracle.com) Date: Wed, 08 Jan 2014 14:24:24 +0000 Subject: hg: jdk8/tl: 8030781: System.setProperties(null) drops all system properties (RELEASE not set) Message-ID: <20140108142425.364A862461@hg.openjdk.java.net> Changeset: 53d74b77ee53 Author: erikj Date: 2014-01-08 14:02 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/rev/53d74b77ee53 8030781: System.setProperties(null) drops all system properties (RELEASE not set) Reviewed-by: alanb, ihse, tbell ! common/autoconf/generated-configure.sh ! common/autoconf/toolchain.m4 From erik.joelsson at oracle.com Wed Jan 8 06:24:48 2014 From: erik.joelsson at oracle.com (erik.joelsson at oracle.com) Date: Wed, 08 Jan 2014 14:24:48 +0000 Subject: hg: jdk8/tl/jdk: 8030781: System.setProperties(null) drops all system properties (RELEASE not set) Message-ID: <20140108142555.A4F0B62462@hg.openjdk.java.net> Changeset: 2437ccbf3504 Author: erikj Date: 2014-01-08 14:04 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2437ccbf3504 8030781: System.setProperties(null) drops all system properties (RELEASE not set) Reviewed-by: alanb + test/java/lang/System/SetPropertiesNull.java From michael.fang at oracle.com Wed Jan 8 06:58:52 2014 From: michael.fang at oracle.com (michael.fang at oracle.com) Date: Wed, 08 Jan 2014 14:58:52 +0000 Subject: hg: jdk8/tl/jdk: 3 new changesets Message-ID: <20140108145930.428F162463@hg.openjdk.java.net> Changeset: 5d05be02629c Author: mfang Date: 2014-01-07 21:44 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5d05be02629c 8029239: jdk8 l10n resource file translation update - localenames Reviewed-by: okutsu ! src/share/classes/sun/util/resources/de/LocaleNames_de.properties ! src/share/classes/sun/util/resources/es/LocaleNames_es.properties ! src/share/classes/sun/util/resources/fr/LocaleNames_fr.properties ! src/share/classes/sun/util/resources/it/LocaleNames_it.properties ! src/share/classes/sun/util/resources/ja/LocaleNames_ja.properties ! src/share/classes/sun/util/resources/ko/LocaleNames_ko.properties ! src/share/classes/sun/util/resources/sv/LocaleNames_sv.properties ! src/share/classes/sun/util/resources/zh/LocaleNames_zh.properties ! src/share/classes/sun/util/resources/zh/LocaleNames_zh_TW.properties Changeset: b7e7d7ad6f68 Author: mfang Date: 2014-01-07 22:04 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b7e7d7ad6f68 8026570: NLS: jdk8 man page update Reviewed-by: naoto, okutsu ! make/Images.gmk ! src/linux/doc/man/ja/appletviewer.1 ! src/linux/doc/man/ja/extcheck.1 ! src/linux/doc/man/ja/idlj.1 ! src/linux/doc/man/ja/jar.1 ! src/linux/doc/man/ja/jarsigner.1 ! src/linux/doc/man/ja/java.1 ! src/linux/doc/man/ja/javac.1 ! src/linux/doc/man/ja/javadoc.1 ! src/linux/doc/man/ja/javah.1 ! src/linux/doc/man/ja/javap.1 ! src/linux/doc/man/ja/javaws.1 + src/linux/doc/man/ja/jcmd.1 ! src/linux/doc/man/ja/jconsole.1 ! src/linux/doc/man/ja/jdb.1 + src/linux/doc/man/ja/jdeps.1 ! src/linux/doc/man/ja/jhat.1 ! src/linux/doc/man/ja/jinfo.1 + src/linux/doc/man/ja/jjs.1 ! src/linux/doc/man/ja/jmap.1 ! src/linux/doc/man/ja/jps.1 ! src/linux/doc/man/ja/jrunscript.1 ! src/linux/doc/man/ja/jsadebugd.1 ! src/linux/doc/man/ja/jstack.1 ! src/linux/doc/man/ja/jstat.1 ! src/linux/doc/man/ja/jstatd.1 ! src/linux/doc/man/ja/jvisualvm.1 ! src/linux/doc/man/ja/keytool.1 ! src/linux/doc/man/ja/native2ascii.1 ! src/linux/doc/man/ja/orbd.1 ! src/linux/doc/man/ja/pack200.1 ! src/linux/doc/man/ja/policytool.1 ! src/linux/doc/man/ja/rmic.1 ! src/linux/doc/man/ja/rmid.1 ! src/linux/doc/man/ja/rmiregistry.1 ! src/linux/doc/man/ja/schemagen.1 ! src/linux/doc/man/ja/serialver.1 ! src/linux/doc/man/ja/servertool.1 ! src/linux/doc/man/ja/tnameserv.1 ! src/linux/doc/man/ja/unpack200.1 ! src/linux/doc/man/ja/wsgen.1 ! src/linux/doc/man/ja/wsimport.1 ! src/linux/doc/man/ja/xjc.1 ! src/solaris/doc/sun/man/man1/ja/appletviewer.1 ! src/solaris/doc/sun/man/man1/ja/extcheck.1 ! src/solaris/doc/sun/man/man1/ja/idlj.1 ! src/solaris/doc/sun/man/man1/ja/jar.1 ! src/solaris/doc/sun/man/man1/ja/jarsigner.1 ! src/solaris/doc/sun/man/man1/ja/java.1 ! src/solaris/doc/sun/man/man1/ja/javac.1 ! src/solaris/doc/sun/man/man1/ja/javadoc.1 ! src/solaris/doc/sun/man/man1/ja/javah.1 ! src/solaris/doc/sun/man/man1/ja/javap.1 + src/solaris/doc/sun/man/man1/ja/jcmd.1 ! src/solaris/doc/sun/man/man1/ja/jconsole.1 ! src/solaris/doc/sun/man/man1/ja/jdb.1 + src/solaris/doc/sun/man/man1/ja/jdeps.1 ! src/solaris/doc/sun/man/man1/ja/jhat.1 ! src/solaris/doc/sun/man/man1/ja/jinfo.1 + src/solaris/doc/sun/man/man1/ja/jjs.1 ! src/solaris/doc/sun/man/man1/ja/jmap.1 ! src/solaris/doc/sun/man/man1/ja/jps.1 ! src/solaris/doc/sun/man/man1/ja/jrunscript.1 ! src/solaris/doc/sun/man/man1/ja/jsadebugd.1 ! src/solaris/doc/sun/man/man1/ja/jstack.1 ! src/solaris/doc/sun/man/man1/ja/jstat.1 ! src/solaris/doc/sun/man/man1/ja/jstatd.1 ! src/solaris/doc/sun/man/man1/ja/jvisualvm.1 ! src/solaris/doc/sun/man/man1/ja/keytool.1 ! src/solaris/doc/sun/man/man1/ja/native2ascii.1 ! src/solaris/doc/sun/man/man1/ja/orbd.1 ! src/solaris/doc/sun/man/man1/ja/pack200.1 ! src/solaris/doc/sun/man/man1/ja/policytool.1 ! src/solaris/doc/sun/man/man1/ja/rmic.1 ! src/solaris/doc/sun/man/man1/ja/rmid.1 ! src/solaris/doc/sun/man/man1/ja/rmiregistry.1 ! src/solaris/doc/sun/man/man1/ja/schemagen.1 ! src/solaris/doc/sun/man/man1/ja/serialver.1 ! src/solaris/doc/sun/man/man1/ja/servertool.1 ! src/solaris/doc/sun/man/man1/ja/tnameserv.1 ! src/solaris/doc/sun/man/man1/ja/unpack200.1 ! src/solaris/doc/sun/man/man1/ja/wsgen.1 ! src/solaris/doc/sun/man/man1/ja/wsimport.1 ! src/solaris/doc/sun/man/man1/ja/xjc.1 Changeset: 7c8f4610a23d Author: mfang Date: 2014-01-08 06:50 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7c8f4610a23d Merge From paul.sandoz at oracle.com Thu Jan 9 02:50:48 2014 From: paul.sandoz at oracle.com (paul.sandoz at oracle.com) Date: Thu, 09 Jan 2014 10:50:48 +0000 Subject: hg: jdk8/tl/jdk: 8031187: DoubleStream.count is incorrect for a stream containing > Integer.MAX_VALUE elements Message-ID: <20140109105107.5E7D86248A@hg.openjdk.java.net> Changeset: 630a92015993 Author: psandoz Date: 2014-01-09 10:52 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/630a92015993 8031187: DoubleStream.count is incorrect for a stream containing > Integer.MAX_VALUE elements Reviewed-by: darcy ! src/share/classes/java/util/stream/DoublePipeline.java ! src/share/classes/java/util/stream/IntPipeline.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/CountLargeTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/CountTest.java From gunnar at hibernate.org Fri Jan 10 04:42:10 2014 From: gunnar at hibernate.org (Gunnar Morling) Date: Fri, 10 Jan 2014 13:42:10 +0100 Subject: Compilation failure on JDK 8 involving inferred generic type In-Reply-To: References: Message-ID: Hi, Does anyone have an idea whether this is a regression or an intentional change? My apologies, if this is not the right place to ask this question (I'd be happy then about a pointer where to post it instead). Many thanks, --Gunnar 2014/1/3 Gunnar Morling > Hi, > > I'm investigating a compilation error which I'm seeing when compiling the > Bean Validation TCK using JDK 8 (build 121). The following example shows > the issue: > > public class GenericsTest { > > public class Input> {} > > public class Output> {} > > public class OutputContainer> {} > > public , I extends Input> > OutputContainer process( > Class inputType) { > return null; > } > > public void testProcess() { > Class inputType = null; > > //next line compiles with source level 1.7 but fails with > source level 1.8 > OutputContainer outputContainer = process( inputType ); > } > } > > This code used to compile with JDK 7 and it also does with JDK 8, when > using 1.7 as source level. But it fails with source level 1.8, saying: > > "incompatible types: inferred type does not conform to upper bound(s)" > > I can make the code compile when declaring the outputContainer variable of > the raw type OutputContainer instead of declaring it with the wildcard > parameter. > > Is this an intentional change in JDK 8 or is it some kind of regression? > If it is intentional, maybe the error message should be a bit more > descriptive, mentioning the concerned inferred type and the bounds? > > Many thanks, > > --Gunnar > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20140110/d8031cd4/attachment.html From vicente.romero at oracle.com Fri Jan 10 05:08:03 2014 From: vicente.romero at oracle.com (Vicente-Arturo Romero-Zaldivar) Date: Fri, 10 Jan 2014 13:08:03 +0000 Subject: Compilation failure on JDK 8 involving inferred generic type In-Reply-To: References: Message-ID: <52CFF0B3.4080402@oracle.com> Hi Gunnar, Yes this is the right list, sorry for the late response. I will look at it. Thanks, Vicente On 10/01/14 12:42, Gunnar Morling wrote: > Hi, > > Does anyone have an idea whether this is a regression or an > intentional change? My apologies, if this is not the right place to > ask this question (I'd be happy then about a pointer where to post > it instead). > > Many thanks, > > --Gunnar > > > > 2014/1/3 Gunnar Morling > > > Hi, > > I'm investigating a compilation error which I'm seeing when > compiling the Bean Validation TCK using JDK 8 (build 121). The > following example shows the issue: > > public class GenericsTest { > public class Input> {} > public class Output> {} > public class OutputContainer> {} > public , I extends Input> > OutputContainer process( > Class inputType) { > return null; > } > public void testProcess() { > Class inputType = null; > > //next line compiles with source level 1.7 but fails > with source level 1.8 > OutputContainer outputContainer = process( inputType ); > } > } > > This code used to compile with JDK 7 and it also does with JDK 8, > when using 1.7 as source level. But it fails with source level > 1.8, saying: > > "incompatible types: inferred type does not conform to upper > bound(s)" > > I can make the code compile when declaring the outputContainer > variable of the raw type OutputContainer instead of declaring it > with the wildcard parameter. > > Is this an intentional change in JDK 8 or is it some kind of > regression? If it is intentional, maybe the error message should > be a bit more descriptive, mentioning the concerned inferred type > and the bounds? > > Many thanks, > > --Gunnar > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20140110/f06795fe/attachment.html From erik.joelsson at oracle.com Fri Jan 10 04:29:57 2014 From: erik.joelsson at oracle.com (erik.joelsson at oracle.com) Date: Fri, 10 Jan 2014 12:29:57 +0000 Subject: hg: jdk8/tl/jdk: 8031300: No jdeps.1 and jjs.1 man pages in jdk8 b122 build and jvisualvm.1 and jcmd.1 missing on macosx; ... Message-ID: <20140110123036.99DB6624BC@hg.openjdk.java.net> Changeset: 6f3a3bd78c57 Author: erikj Date: 2014-01-10 10:25 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6f3a3bd78c57 8031300: No jdeps.1 and jjs.1 man pages in jdk8 b122 build and jvisualvm.1 and jcmd.1 missing on macosx 8030946: No jmc.1 for man page of JMC Reviewed-by: ihse, tbell ! make/Images.gmk + src/bsd/doc/man/ja/jcmd.1 + src/bsd/doc/man/ja/jdeps.1 + src/bsd/doc/man/ja/jjs.1 - src/bsd/doc/man/ja/kinit.1 - src/bsd/doc/man/ja/klist.1 - src/bsd/doc/man/ja/ktab.1 From emailgrant at gmail.com Mon Jan 13 05:03:51 2014 From: emailgrant at gmail.com (Grant) Date: Mon, 13 Jan 2014 05:03:51 -0800 Subject: NullPointerException at TestCryptoLevel.main Message-ID: Can anyone tell me how to get this to compile? '/var/tmp/portage/dev-java/icedtea-7.9999/work/icedtea-9999/tz.properties' -> '/var/tmp/portage/dev-java/icedtea-7.9999/work/icedtea-9999/openjdk.build-boot/j2sdk-image/jre/lib/tz.properties' touch stamps/add-tzdata-support-boot.stamp mkdir -p /var/tmp/portage/dev-java/icedtea-7.9999/work/icedtea-9999/cryptocheck.build /var/tmp/portage/dev-java/icedtea-7.9999/work/icedtea-9999/bootstrap/jdk1.6.0/bin/javac -g -encoding utf-8 -source 7 -target 7 \ -d /var/tmp/portage/dev-java/icedtea-7.9999/work/icedtea-9999/cryptocheck.build ./TestCryptoLevel.java Annotation processing got disabled, since it requires a 1.6 compliant JVM mkdir -p stamps touch stamps/cryptocheck.stamp if [ -e /var/tmp/portage/dev-java/icedtea-7.9999/work/icedtea-9999/openjdk.build-boot/j2sdk-image/bin/java ] ; then \ /var/tmp/portage/dev-java/icedtea-7.9999/work/icedtea-9999/openjdk.build-boot/j2sdk-image/bin/java -cp /var/tmp/portage/dev-java/icedtea-7.9999/work/icedtea-9999/cryptocheck.build TestCryptoLevel ; \ fi Exception in thread "main" java.lang.NullPointerException at java.lang.Throwable.fillInStackTrace(Throwable.java:783) at java.lang.Throwable.(Throwable.java:250) at java.lang.Exception.(Exception.java:54) at java.lang.RuntimeException.(RuntimeException.java:51) at java.lang.NullPointerException.(NullPointerException.java:60) at TestCryptoLevel.main(TestCryptoLevel.java:46) make: *** [stamps/check-crypto-boot.stamp] Error 1 - Grant From alan.bateman at oracle.com Mon Jan 13 08:21:07 2014 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Mon, 13 Jan 2014 16:21:07 +0000 Subject: hg: jdk8/tl/jaxws: 8027908: serialVersionUID of javax.xml.bind.TypeConstraintException accidently changed Message-ID: <20140113162119.3F8986240B@hg.openjdk.java.net> Changeset: bd943bdbce05 Author: alanb Date: 2014-01-13 16:17 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/bd943bdbce05 8027908: serialVersionUID of javax.xml.bind.TypeConstraintException accidently changed Reviewed-by: alanb Contributed-by: iaroslav.savytskyi at oracle.com ! src/share/jaxws_classes/javax/xml/bind/TypeConstraintException.java From jeremymanson at google.com Mon Jan 13 16:11:52 2014 From: jeremymanson at google.com (Jeremy Manson) Date: Mon, 13 Jan 2014 16:11:52 -0800 Subject: Preferring class files to source files in ClassReader.java In-Reply-To: <528522FF.7030104@oracle.com> References: <20131114120346.GA9397@oracle.com> <52851A28.3060902@oracle.com> <4B48D1B9-519A-4B6F-AA0A-5BCD45EFC1B6@oracle.com> <528522FF.7030104@oracle.com> Message-ID: Bump, because of JDK9 opening (I somehow missed the conversation after my last message - sorry about abandoning the thread mid-stream). I'd say that regardless of which you choose, it should probably be consistently preferring source or classfile. Right now, the preference depends on what it happens to encounter first, which is rather unpredictable. Anyone actually relying on this behavior is doing something deeply brittle, since a small refactoring of their build rules can change which they get. Once the decision has been taken to pin it down one way or the other, I'm not averse to a flag or something. Jeremy On Thu, Nov 14, 2013 at 11:22 AM, Jonathan Gibbons < jonathan.gibbons at oracle.com> wrote: > On 11/14/2013 11:06 AM, Joel Borggr?n-Franck wrote: > >> On 14 nov 2013, at 19:44, Jonathan Gibbons >> wrote: >> >> On 11/14/2013 04:03 AM, Joel Borggren-Franck wrote: >>> >>>> Hi Jeremy, >>>> >>>> On 2013-11-13, Jeremy Manson wrote: >>>> >>>>> Hi folks, >>>>> >>>>> A bit of background: >>>>> >>>>> - We use a content-addressable storage around here, so to minimize the >>>>> diffs between two JAR files (and get more hits in our >>>>> content-addressable >>>>> storage), we reset all timestamps in JAR files to the same values. >>>>> - Some of our users include both source and class files in their JAR >>>>> files. >>>>> - When those users want to put those JAR files on the classpath for >>>>> javac, >>>>> and use them to compile other files, they may not have included enough >>>>> on >>>>> the classpath to compile the source files. >>>>> - We've worked around this by favoring classfiles when the two files >>>>> are of >>>>> the same age. This has the added benefit of not having to recompile >>>>> the >>>>> source files when they are found. >>>>> - What do you think? Too esoteric? Wait for JDK9? >>>>> >>>>> Thinking out loud here. While I do understand your usecase, don't we >>>> want the opposite to be the default case? If javac finds a source and a >>>> class file and the timestamps are suspect isn't the responsible thing to >>>> do to compile the source again? >>>> >>>> cheers >>>> /Joel >>>> >>> I think Jeremy would argue that the timestamps are not suspect -- they >>> are exactly what they have set them to be! >>> >>> >> Yes, but javac doesn't know that. In order to make a change like this I >> think you need to argue it is correct in all cases. I'm not convinced of >> that yet, but then again I'm not yet convinced of the opposite either. >> >> Could be interesting to compare with how make handles equal timestamps. >> >> cheers >> /Joel >> > > > I think the general take on this discussion is that in JDK 9, we should > examine the possibility of updating -Xprefer to have more policies > available. I'm also open to changing existing policies -- but with some > concern for compatibility for those who like the existing policies. > > -- Jon > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20140113/30a1d842/attachment.html From jonathan.gibbons at oracle.com Mon Jan 13 16:39:30 2014 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Mon, 13 Jan 2014 16:39:30 -0800 Subject: Preferring class files to source files in ClassReader.java In-Reply-To: References: <20131114120346.GA9397@oracle.com> <52851A28.3060902@oracle.com> <4B48D1B9-519A-4B6F-AA0A-5BCD45EFC1B6@oracle.com> <528522FF.7030104@oracle.com> Message-ID: <52D48742.7070100@oracle.com> I'm not sure what you mean about preferring the first encountered: are you referring to javac, or to some modified version? I completely agree that the preference should be preference should be consistent and deterministic. -- Jon On 01/13/2014 04:11 PM, Jeremy Manson wrote: > Bump, because of JDK9 opening (I somehow missed the conversation after > my last message - sorry about abandoning the thread mid-stream). > > I'd say that regardless of which you choose, it should probably be > consistently preferring source or classfile. Right now, the > preference depends on what it happens to encounter first, which is > rather unpredictable. Anyone actually relying on this behavior is > doing something deeply brittle, since a small refactoring of their > build rules can change which they get. > > Once the decision has been taken to pin it down one way or the other, > I'm not averse to a flag or something. > > Jeremy > > > On Thu, Nov 14, 2013 at 11:22 AM, Jonathan Gibbons > > wrote: > > On 11/14/2013 11:06 AM, Joel Borggr?n-Franck wrote: > > On 14 nov 2013, at 19:44, Jonathan Gibbons > > wrote: > > On 11/14/2013 04:03 AM, Joel Borggren-Franck wrote: > > Hi Jeremy, > > On 2013-11-13, Jeremy Manson wrote: > > Hi folks, > > A bit of background: > > - We use a content-addressable storage around > here, so to minimize the > diffs between two JAR files (and get more hits in > our content-addressable > storage), we reset all timestamps in JAR files to > the same values. > - Some of our users include both source and class > files in their JAR files. > - When those users want to put those JAR files on > the classpath for javac, > and use them to compile other files, they may not > have included enough on > the classpath to compile the source files. > - We've worked around this by favoring classfiles > when the two files are of > the same age. This has the added benefit of not > having to recompile the > source files when they are found. > - What do you think? Too esoteric? Wait for JDK9? > > Thinking out loud here. While I do understand your > usecase, don't we > want the opposite to be the default case? If javac > finds a source and a > class file and the timestamps are suspect isn't the > responsible thing to > do to compile the source again? > > cheers > /Joel > > I think Jeremy would argue that the timestamps are not > suspect -- they are exactly what they have set them to be! > > > Yes, but javac doesn't know that. In order to make a change > like this I think you need to argue it is correct in all > cases. I'm not convinced of that yet, but then again I'm not > yet convinced of the opposite either. > > Could be interesting to compare with how make handles equal > timestamps. > > cheers > /Joel > > > > I think the general take on this discussion is that in JDK 9, we > should examine the possibility of updating -Xprefer to have more > policies available. I'm also open to changing existing policies > -- but with some concern for compatibility for those who like the > existing policies. > > -- Jon > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20140113/4f4c996c/attachment.html From jeremymanson at google.com Mon Jan 13 22:04:26 2014 From: jeremymanson at google.com (Jeremy Manson) Date: Mon, 13 Jan 2014 22:04:26 -0800 Subject: Preferring class files to source files in ClassReader.java In-Reply-To: <52D48742.7070100@oracle.com> References: <20131114120346.GA9397@oracle.com> <52851A28.3060902@oracle.com> <4B48D1B9-519A-4B6F-AA0A-5BCD45EFC1B6@oracle.com> <528522FF.7030104@oracle.com> <52D48742.7070100@oracle.com> Message-ID: I mean that if adate == bdate, then it will always pick b, regardless of whether it is source or class. Perhaps that's what you want, but it seems brittle. Jeremy On Mon, Jan 13, 2014 at 4:39 PM, Jonathan Gibbons < jonathan.gibbons at oracle.com> wrote: > I'm not sure what you mean about preferring the first encountered: are > you referring to javac, or to some modified version? I completely agree > that the preference should be preference should be consistent and > deterministic. > > -- Jon > > > On 01/13/2014 04:11 PM, Jeremy Manson wrote: > > Bump, because of JDK9 opening (I somehow missed the conversation after my > last message - sorry about abandoning the thread mid-stream). > > I'd say that regardless of which you choose, it should probably be > consistently preferring source or classfile. Right now, the preference > depends on what it happens to encounter first, which is rather > unpredictable. Anyone actually relying on this behavior is doing something > deeply brittle, since a small refactoring of their build rules can change > which they get. > > Once the decision has been taken to pin it down one way or the other, > I'm not averse to a flag or something. > > Jeremy > > > On Thu, Nov 14, 2013 at 11:22 AM, Jonathan Gibbons < > jonathan.gibbons at oracle.com> wrote: > >> On 11/14/2013 11:06 AM, Joel Borggr?n-Franck wrote: >> >>> On 14 nov 2013, at 19:44, Jonathan Gibbons >>> wrote: >>> >>> On 11/14/2013 04:03 AM, Joel Borggren-Franck wrote: >>>> >>>>> Hi Jeremy, >>>>> >>>>> On 2013-11-13, Jeremy Manson wrote: >>>>> >>>>>> Hi folks, >>>>>> >>>>>> A bit of background: >>>>>> >>>>>> - We use a content-addressable storage around here, so to minimize the >>>>>> diffs between two JAR files (and get more hits in our >>>>>> content-addressable >>>>>> storage), we reset all timestamps in JAR files to the same values. >>>>>> - Some of our users include both source and class files in their JAR >>>>>> files. >>>>>> - When those users want to put those JAR files on the classpath for >>>>>> javac, >>>>>> and use them to compile other files, they may not have included >>>>>> enough on >>>>>> the classpath to compile the source files. >>>>>> - We've worked around this by favoring classfiles when the two files >>>>>> are of >>>>>> the same age. This has the added benefit of not having to recompile >>>>>> the >>>>>> source files when they are found. >>>>>> - What do you think? Too esoteric? Wait for JDK9? >>>>>> >>>>>> Thinking out loud here. While I do understand your usecase, don't we >>>>> want the opposite to be the default case? If javac finds a source and a >>>>> class file and the timestamps are suspect isn't the responsible thing >>>>> to >>>>> do to compile the source again? >>>>> >>>>> cheers >>>>> /Joel >>>>> >>>> I think Jeremy would argue that the timestamps are not suspect -- they >>>> are exactly what they have set them to be! >>>> >>>> >>> Yes, but javac doesn't know that. In order to make a change like this I >>> think you need to argue it is correct in all cases. I'm not convinced of >>> that yet, but then again I'm not yet convinced of the opposite either. >>> >>> Could be interesting to compare with how make handles equal timestamps. >>> >>> cheers >>> /Joel >>> >> >> >> I think the general take on this discussion is that in JDK 9, we should >> examine the possibility of updating -Xprefer to have more policies >> available. I'm also open to changing existing policies -- but with some >> concern for compatibility for those who like the existing policies. >> >> -- Jon >> > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20140113/d4ed8669/attachment-0001.html From alexander.zuev at oracle.com Tue Jan 14 11:17:52 2014 From: alexander.zuev at oracle.com (alexander.zuev at oracle.com) Date: Tue, 14 Jan 2014 19:17:52 +0000 Subject: hg: jdk8/tl: 3 new changesets Message-ID: <20140114191752.B1DC66242B@hg.openjdk.java.net> Changeset: ff1478785e43 Author: katleman Date: 2014-01-03 11:54 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/ff1478785e43 Added tag jdk8-b122 for changeset 347009c58816 ! .hgtags Changeset: c330fa67c4da Author: katleman Date: 2014-01-10 08:31 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/c330fa67c4da Added tag jdk8-b123 for changeset ff1478785e43 ! .hgtags Changeset: fd869d9f3ca7 Author: kizune Date: 2014-01-14 23:10 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/rev/fd869d9f3ca7 Merge From alexander.zuev at oracle.com Tue Jan 14 11:18:03 2014 From: alexander.zuev at oracle.com (alexander.zuev at oracle.com) Date: Tue, 14 Jan 2014 19:18:03 +0000 Subject: hg: jdk8/tl/corba: 10 new changesets Message-ID: <20140114191809.3B0F76242C@hg.openjdk.java.net> Changeset: 98a5caae1990 Author: chegar Date: 2013-11-03 07:32 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/98a5caae1990 Merge Changeset: 880514b576d5 Author: msheppar Date: 2013-11-12 17:56 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/880514b576d5 8026193: Enhance CORBA stub factories Summary: modify com.sun.corba.se.impl.presenetation.rmi.StubFactoryDynamicBase inheritance structure. Reviewed-by: alanb, coffeys, ahgross ! src/share/classes/com/sun/corba/se/impl/presentation/rmi/StubFactoryDynamicBase.java ! src/share/classes/com/sun/corba/se/impl/presentation/rmi/StubFactoryFactoryProxyImpl.java Changeset: b083590cb088 Author: msheppar Date: 2013-11-12 18:04 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/b083590cb088 8025767: Enhance IIOP Streams Summary: modify org.omg.CORBA_2_3.portable.InputStream inheritance structure. Reviewed-by: alanb, coffeys, skoivu ! src/share/classes/com/sun/corba/se/impl/corba/AnyImpl.java ! src/share/classes/com/sun/corba/se/impl/encoding/EncapsInputStream.java ! src/share/classes/com/sun/corba/se/impl/encoding/EncapsOutputStream.java ! src/share/classes/com/sun/corba/se/impl/encoding/TypeCodeInputStream.java ! src/share/classes/com/sun/corba/se/impl/encoding/TypeCodeOutputStream.java ! src/share/classes/com/sun/corba/se/impl/interceptors/CDREncapsCodec.java ! src/share/classes/com/sun/corba/se/impl/io/IIOPInputStream.java ! src/share/classes/com/sun/corba/se/impl/io/InputStreamHook.java ! src/share/classes/com/sun/corba/se/impl/ior/EncapsulationUtility.java ! src/share/classes/com/sun/corba/se/impl/ior/ObjectKeyFactoryImpl.java ! src/share/classes/com/sun/corba/se/impl/ior/iiop/IIOPProfileImpl.java ! src/share/classes/com/sun/corba/se/impl/protocol/CorbaClientRequestDispatcherImpl.java ! src/share/classes/com/sun/corba/se/impl/protocol/SharedCDRClientRequestDispatcherImpl.java ! src/share/classes/com/sun/corba/se/impl/resolver/INSURLOperationImpl.java ! src/share/classes/com/sun/corba/se/spi/servicecontext/ServiceContexts.java ! src/share/classes/org/omg/CORBA_2_3/portable/InputStream.java + src/share/classes/sun/corba/EncapsInputStreamFactory.java Changeset: 6b9b31f2298b Author: kizune Date: 2013-12-03 14:13 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/6b9b31f2298b Merge Changeset: d05c64360b6c Author: kizune Date: 2013-12-05 16:37 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/d05c64360b6c Merge - make/com/Makefile - make/com/sun/Makefile - make/com/sun/corba/Makefile - make/com/sun/corba/minclude/com_sun_corba_se_PortableActivationIDL.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_activation.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_corba.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_core.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_dynamicany.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_encoding.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_interceptors.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_io.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_ior.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_legacy.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_logging.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_monitoring.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_naming_cosnaming.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_naming_namingutil.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_naming_pcosnaming.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_oa_poa.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_oa_toa.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_orb.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_orbutil.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_presentation_rmi.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_protocol.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_resolver.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_transport.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_util.jmk - make/com/sun/corba/minclude/com_sun_corba_se_internal_LegacyFiles.jmk - make/com/sun/corba/minclude/com_sun_corba_se_pept.jmk - make/com/sun/corba/minclude/com_sun_corba_se_spi_activation.jmk - make/com/sun/corba/minclude/com_sun_corba_se_spi_copyobject.jmk - make/com/sun/corba/minclude/com_sun_corba_se_spi_encoding.jmk - make/com/sun/corba/minclude/com_sun_corba_se_spi_extension.jmk - make/com/sun/corba/minclude/com_sun_corba_se_spi_ior.jmk - make/com/sun/corba/minclude/com_sun_corba_se_spi_legacy_connection.jmk - make/com/sun/corba/minclude/com_sun_corba_se_spi_legacy_interceptor.jmk - make/com/sun/corba/minclude/com_sun_corba_se_spi_logging.jmk - make/com/sun/corba/minclude/com_sun_corba_se_spi_monitoring.jmk - make/com/sun/corba/minclude/com_sun_corba_se_spi_oa.jmk - make/com/sun/corba/minclude/com_sun_corba_se_spi_orb.jmk - make/com/sun/corba/minclude/com_sun_corba_se_spi_orbutil.jmk - make/com/sun/corba/minclude/com_sun_corba_se_spi_presentation_rmi.jmk - make/com/sun/corba/minclude/com_sun_corba_se_spi_protocol.jmk - make/com/sun/corba/minclude/com_sun_corba_se_spi_resolver.jmk - make/com/sun/corba/minclude/com_sun_corba_se_spi_servicecontext.jmk - make/com/sun/corba/minclude/com_sun_corba_se_spi_transport.jmk - make/com/sun/corba/minclude/com_sun_tools_corba_se_idl_toJavaPortable.jmk - make/com/sun/corba/minclude/javax_activity.jmk - make/com/sun/corba/minclude/javax_rmi.jmk - make/com/sun/corba/minclude/javax_rmi_CORBA.jmk - make/com/sun/corba/minclude/javax_transaction.jmk - make/com/sun/corba/minclude/org_omg_CORBA.jmk - make/com/sun/corba/minclude/org_omg_CORBAX.jmk - make/com/sun/corba/minclude/org_omg_CORBA_2_3.jmk - make/com/sun/corba/minclude/org_omg_CosNaming.jmk - make/com/sun/corba/minclude/org_omg_DynamicAny.jmk - make/com/sun/corba/minclude/org_omg_IOP.jmk - make/com/sun/corba/minclude/org_omg_Messaging.jmk - make/com/sun/corba/minclude/org_omg_PortableInterceptor.jmk - make/com/sun/corba/minclude/org_omg_PortableServer.jmk - make/com/sun/corba/minclude/org_omg_SendingContext.jmk - make/com/sun/corba/minclude/sun_corba.jmk - make/com/sun/corba/se/Makefile - make/com/sun/corba/se/PortableActivationIDL/Makefile - make/com/sun/corba/se/connection/FILES_java.gmk - make/com/sun/corba/se/connection/Makefile - make/com/sun/corba/se/core/Makefile - make/com/sun/corba/se/corespi/Makefile - make/com/sun/corba/se/impl/Makefile - make/com/sun/corba/se/impl/activation/Makefile - make/com/sun/corba/se/impl/activation/orbd/Makefile - make/com/sun/corba/se/impl/activation/servertool/Makefile - make/com/sun/corba/se/impl/interceptors/Makefile - make/com/sun/corba/se/impl/logging/Makefile - make/com/sun/corba/se/impl/monitoring/Makefile - make/com/sun/corba/se/impl/naming/Makefile - make/com/sun/corba/se/impl/naming/cosnaming/Makefile - make/com/sun/corba/se/impl/naming/namingutil/Makefile - make/com/sun/corba/se/impl/naming/pcosnaming/Makefile - make/com/sun/corba/se/impl/oa/Makefile - make/com/sun/corba/se/impl/oa/poa/Makefile - make/com/sun/corba/se/impl/oa/toa/Makefile - make/com/sun/corba/se/interceptor/FILES_java.gmk - make/com/sun/corba/se/interceptor/Makefile - make/com/sun/corba/se/pept/Makefile - make/com/sun/corba/se/rmi/Makefile - make/com/sun/corba/se/rmi/rmic/Makefile - make/com/sun/corba/se/rmi/rmic/SUN_RMI_RMIC_IIOP_java.gmk - make/com/sun/corba/se/sources/Makefile - make/com/sun/corba/se/spi/Makefile - make/com/sun/corba/se/spi/activation/Makefile - make/com/sun/corba/se/spi/copyobject/Makefile - make/com/sun/corba/se/spi/encoding/Makefile - make/com/sun/corba/se/spi/extension/Makefile - make/com/sun/corba/se/spi/legacy/Makefile - make/com/sun/corba/se/spi/legacy/connection/Makefile - make/com/sun/corba/se/spi/legacy/interceptor/Makefile - make/com/sun/corba/se/spi/logging/Makefile - make/com/sun/corba/se/spi/monitoring/Makefile - make/common/BuildToolJar.gmk - make/common/CancelImplicits.gmk - make/common/Classes.gmk - make/common/Defs-bsd.gmk - make/common/Defs-linux.gmk - make/common/Defs-solaris.gmk - make/common/Defs-windows.gmk - make/common/Defs.gmk - make/common/Rules.gmk - make/common/internal/Resources.gmk - make/common/shared/Defs-bsd.gmk - make/common/shared/Defs-java.gmk - make/common/shared/Defs-linux.gmk - make/common/shared/Defs-solaris.gmk - make/common/shared/Defs-utils.gmk - make/common/shared/Defs-windows.gmk - make/common/shared/Defs.gmk - make/common/shared/Platform.gmk - make/javax/Makefile - make/javax/xa/Makefile - make/jprt.properties - make/org/Makefile - make/org/omg/CORBA/Makefile - make/org/omg/CORBAX_java.gmk - make/org/omg/CosNaming/Makefile - make/org/omg/DynamicAny/Makefile - make/org/omg/Makefile - make/org/omg/PortableInterceptor/Makefile - make/org/omg/PortableServer/Makefile - make/org/omg/idl/FILES_java.gmk - make/org/omg/idl/Makefile - make/org/omg/sources/Makefile - make/sun/Makefile - make/sun/corba/Makefile - make/sun/corba/core/Makefile - make/sun/corba/org/Makefile - make/sun/corba/org/omg/FILES_java.gmk - make/sun/corba/org/omg/Makefile - make/sun/rmi/Makefile - make/sun/rmi/corbalogcompile/Makefile - make/sun/rmi/corbalogsources/Makefile - make/sun/rmi/rmic/FILES.gmk - make/sun/rmi/rmic/Makefile - make/tools/Makefile - make/tools/idlj/Makefile - make/tools/logutil/Makefile - make/tools/strip_properties/Makefile - makefiles/BuildCorba.gmk - makefiles/Makefile Changeset: dae8ee5b71d9 Author: kizune Date: 2013-12-13 22:13 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/dae8ee5b71d9 Merge Changeset: 0354055127f5 Author: asaha Date: 2013-12-20 07:40 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/0354055127f5 Merge Changeset: 7ec1c16f6fb8 Author: asaha Date: 2014-01-02 15:18 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/7ec1c16f6fb8 Merge ! src/share/classes/com/sun/corba/se/impl/io/IIOPInputStream.java ! src/share/classes/com/sun/corba/se/impl/io/InputStreamHook.java ! src/share/classes/com/sun/corba/se/impl/ior/EncapsulationUtility.java Changeset: 1ecd4619f60c Author: katleman Date: 2014-01-03 11:54 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/1ecd4619f60c Added tag jdk8-b122 for changeset 0cd687347540 ! .hgtags Changeset: 9240e4c6b107 Author: asaha Date: 2014-01-03 15:57 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/9240e4c6b107 Merge From alexander.zuev at oracle.com Tue Jan 14 11:25:32 2014 From: alexander.zuev at oracle.com (alexander.zuev at oracle.com) Date: Tue, 14 Jan 2014 19:25:32 +0000 Subject: hg: jdk8/tl/hotspot: 21 new changesets Message-ID: <20140114192621.73DC36242F@hg.openjdk.java.net> Changeset: 7ccce1a6fa4d Author: coleenp Date: 2013-09-05 10:29 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7ccce1a6fa4d 8021266: Better life cycle for objects Summary: Improve life cycle for objects Reviewed-by: art, hseigel Contributed-by: gerard.ziemski at oracle.com ! src/share/vm/runtime/os.cpp Changeset: 2a907fd129cb Author: chegar Date: 2013-09-06 09:55 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2a907fd129cb Merge ! src/share/vm/runtime/os.cpp - test/runtime/7051189/Xchecksig.sh Changeset: 9b4ce069642e Author: chegar Date: 2013-09-14 20:40 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9b4ce069642e Merge ! src/share/vm/classfile/classFileParser.cpp - src/share/vm/classfile/genericSignatures.cpp - src/share/vm/classfile/genericSignatures.hpp ! src/share/vm/runtime/os.cpp Changeset: 6fa574bfd32a Author: chegar Date: 2013-10-03 19:13 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6fa574bfd32a Merge ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/runtime/os.cpp - test/gc/metaspace/ClassMetaspaceSizeInJmapHeap.java - test/runtime/6878713/Test6878713.sh - test/runtime/6878713/testcase.jar - test/runtime/7020373/Test7020373.sh - test/runtime/7020373/testcase.jar Changeset: 6795fcebbf42 Author: chegar Date: 2013-10-21 14:08 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6795fcebbf42 Merge ! src/share/vm/classfile/classFileParser.cpp - test/testlibrary/AssertsTest.java - test/testlibrary/OutputAnalyzerReportingTest.java - test/testlibrary/OutputAnalyzerTest.java Changeset: c31f0cbe6d9e Author: chegar Date: 2013-11-03 07:50 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c31f0cbe6d9e Merge - src/share/vm/memory/metablock.cpp - src/share/vm/memory/metablock.hpp - test/compiler/8013496/Test8013496.sh - test/compiler/intrinsics/mathexact/CondTest.java - test/compiler/intrinsics/mathexact/ConstantTest.java - test/compiler/intrinsics/mathexact/LoadTest.java - test/compiler/intrinsics/mathexact/LoopDependentTest.java - test/compiler/intrinsics/mathexact/NonConstantTest.java - test/gc/7168848/HumongousAlloc.java Changeset: 0611ce949aaa Author: kizune Date: 2013-12-03 14:13 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0611ce949aaa Merge ! src/share/vm/classfile/classFileParser.cpp Changeset: e254e5940c19 Author: kizune Date: 2013-12-05 16:37 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e254e5940c19 Merge ! src/share/vm/classfile/classFileParser.cpp - test/compiler/jsr292/methodHandleExceptions/C.java - test/compiler/jsr292/methodHandleExceptions/I.java Changeset: 9063bd8808a7 Author: jrose Date: 2013-12-05 00:36 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9063bd8808a7 8029507: Enhance JVM method processing Summary: update MemberName.clazz correctly in MemberName.resolve; also pass lookupClass to MethodHandles::resolve_MemberName Reviewed-by: acorn, vlivanov ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/prims/methodHandles.hpp Changeset: 1b46c3672650 Author: kizune Date: 2013-12-13 22:13 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1b46c3672650 Merge Changeset: 8dbd61445631 Author: asaha Date: 2013-12-17 15:46 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8dbd61445631 Merge Changeset: ddff10b13587 Author: asaha Date: 2013-12-20 07:41 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ddff10b13587 Merge Changeset: 0b9c7eb6658b Author: amurillo Date: 2013-12-20 08:48 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0b9c7eb6658b 8030752: new hotspot build - hs25-b65 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 5832cdaf89c6 Author: hseigel Date: 2013-12-16 08:24 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5832cdaf89c6 8027804: JCK resolveMethod test fails expecting AbstractMethodError Summary: Create AME overpass methods and fix method search logic Reviewed-by: kamg, acorn, lfoltan, coleenp ! src/share/vm/classfile/defaultMethods.cpp ! src/share/vm/interpreter/linkResolver.cpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/klassVtable.cpp Changeset: 62e87648a4be Author: coleenp Date: 2013-12-19 20:28 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/62e87648a4be 8030633: nsk/jvmti/RedefineClasses/StressRedefine failed invalid method ordering length on Solaris Summary: A method with no declared methods was getting an AME overpass method with the latest change. The method_ordering array was not updated for the new methods. Reviewed-by: dcubed, acorn, dsamersoff, lfoltan, hseigel ! src/share/vm/classfile/defaultMethods.cpp Changeset: be840d0078bc Author: coleenp Date: 2013-12-20 14:03 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/be840d0078bc Merge Changeset: 55fb97c4c58d Author: mikael Date: 2013-12-24 11:48 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/55fb97c4c58d 8029233: Update copyright year to match last edit in jdk8 hotspot repository for 2013 Summary: Copyright year updated for files modified during 2013 Reviewed-by: twisti, iveresov ! agent/make/Makefile ! agent/src/os/linux/libproc.h ! agent/src/os/linux/salibelf.c ! agent/src/os/linux/symtab.c ! agent/src/os/solaris/proc/saproc.cpp ! agent/src/os/win32/windbg/sawindbg.cpp ! agent/src/share/classes/sun/jvm/hotspot/CLHSDB.java ! agent/src/share/classes/sun/jvm/hotspot/CommandProcessor.java ! agent/src/share/classes/sun/jvm/hotspot/HSDB.java ! agent/src/share/classes/sun/jvm/hotspot/LinuxVtblAccess.java ! agent/src/share/classes/sun/jvm/hotspot/asm/Disassembler.java ! agent/src/share/classes/sun/jvm/hotspot/ci/ciEnv.java ! agent/src/share/classes/sun/jvm/hotspot/ci/ciMethod.java ! agent/src/share/classes/sun/jvm/hotspot/code/NMethod.java ! agent/src/share/classes/sun/jvm/hotspot/compiler/CompileTask.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdAddress.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebugger.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/linux/LinuxAddress.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/linux/LinuxDebuggerLocal.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/linux/LinuxOopHandle.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/linux/amd64/LinuxAMD64CFrame.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/linux/x86/LinuxX86CFrame.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/windbg/WindbgCDebugger.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/windbg/WindbgDebuggerLocal.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/windows/amd64/WindowsAMD64CFrame.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/windows/x86/WindowsX86CFrame.java ! agent/src/share/classes/sun/jvm/hotspot/jdi/JVMTIThreadState.java ! agent/src/share/classes/sun/jvm/hotspot/memory/CMSCollector.java ! agent/src/share/classes/sun/jvm/hotspot/memory/DictionaryEntry.java ! agent/src/share/classes/sun/jvm/hotspot/memory/SymbolTable.java ! agent/src/share/classes/sun/jvm/hotspot/oops/ArrayKlass.java ! agent/src/share/classes/sun/jvm/hotspot/oops/InstanceKlass.java ! agent/src/share/classes/sun/jvm/hotspot/oops/Klass.java ! agent/src/share/classes/sun/jvm/hotspot/oops/MethodCounters.java ! agent/src/share/classes/sun/jvm/hotspot/oops/MethodData.java ! agent/src/share/classes/sun/jvm/hotspot/oops/ObjectHeap.java ! agent/src/share/classes/sun/jvm/hotspot/opto/PhaseCFG.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/ThreadLocalAllocBuffer.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/bsd_amd64/BsdAMD64JavaThreadPDAccess.java ! agent/src/share/classes/sun/jvm/hotspot/tools/FinalizerInfo.java ! agent/src/share/classes/sun/jvm/hotspot/tools/FlagDumper.java ! agent/src/share/classes/sun/jvm/hotspot/tools/HeapDumper.java ! agent/src/share/classes/sun/jvm/hotspot/tools/HeapSummary.java ! agent/src/share/classes/sun/jvm/hotspot/tools/JInfo.java ! agent/src/share/classes/sun/jvm/hotspot/tools/JSnap.java ! agent/src/share/classes/sun/jvm/hotspot/tools/JStack.java ! agent/src/share/classes/sun/jvm/hotspot/tools/ObjectHistogram.java ! agent/src/share/classes/sun/jvm/hotspot/tools/PMap.java ! agent/src/share/classes/sun/jvm/hotspot/tools/StackTrace.java ! agent/src/share/classes/sun/jvm/hotspot/tools/SysPropsDumper.java ! agent/src/share/classes/sun/jvm/hotspot/tools/Tool.java ! agent/src/share/classes/sun/jvm/hotspot/tools/soql/JSDB.java ! agent/src/share/classes/sun/jvm/hotspot/tools/soql/SOQL.java ! agent/src/share/classes/sun/jvm/hotspot/types/basic/BasicTypeDataBase.java ! agent/src/share/classes/sun/jvm/hotspot/ui/SAPanel.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/AbstractHeapGraphWriter.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/HeapGXLWriter.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/HeapHprofBinWriter.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/soql/JSJavaInstanceKlass.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/soql/sa.js ! make/bsd/makefiles/adlc.make ! make/bsd/makefiles/minimal1.make ! make/hotspot.script ! make/linux/makefiles/adlc.make ! make/linux/makefiles/jsig.make ! make/linux/makefiles/minimal1.make ! make/linux/makefiles/saproc.make ! make/sa.files ! make/solaris/makefiles/adlc.make ! make/solaris/makefiles/gcc.make ! make/windows/build_vm_def.sh ! make/windows/makefiles/adlc.make ! make/windows/makefiles/debug.make ! make/windows/makefiles/product.make ! make/windows/makefiles/rules.make ! make/windows/makefiles/sa.make ! src/cpu/sparc/vm/assembler_sparc.hpp ! src/cpu/sparc/vm/assembler_sparc.inline.hpp ! src/cpu/sparc/vm/c1_CodeStubs_sparc.cpp ! src/cpu/sparc/vm/c1_FrameMap_sparc.cpp ! src/cpu/sparc/vm/c1_MacroAssembler_sparc.cpp ! src/cpu/sparc/vm/c1_Runtime1_sparc.cpp ! src/cpu/sparc/vm/c1_globals_sparc.hpp ! src/cpu/sparc/vm/c2_globals_sparc.hpp ! src/cpu/sparc/vm/c2_init_sparc.cpp ! src/cpu/sparc/vm/disassembler_sparc.hpp ! src/cpu/sparc/vm/frame_sparc.inline.hpp ! src/cpu/sparc/vm/globalDefinitions_sparc.hpp ! src/cpu/sparc/vm/globals_sparc.hpp ! src/cpu/sparc/vm/jni_sparc.h ! src/cpu/sparc/vm/nativeInst_sparc.hpp ! src/cpu/sparc/vm/register_sparc.hpp ! src/cpu/sparc/vm/sharedRuntime_sparc.cpp ! src/cpu/sparc/vm/stubGenerator_sparc.cpp ! src/cpu/sparc/vm/stubRoutines_sparc.cpp ! src/cpu/sparc/vm/stubRoutines_sparc.hpp ! src/cpu/sparc/vm/vmStructs_sparc.hpp ! src/cpu/sparc/vm/vm_version_sparc.cpp ! src/cpu/sparc/vm/vm_version_sparc.hpp ! src/cpu/x86/vm/bytecodeInterpreter_x86.cpp ! src/cpu/x86/vm/c1_CodeStubs_x86.cpp ! src/cpu/x86/vm/c1_FrameMap_x86.cpp ! src/cpu/x86/vm/c1_FrameMap_x86.hpp ! src/cpu/x86/vm/c1_LinearScan_x86.cpp ! src/cpu/x86/vm/c1_MacroAssembler_x86.cpp ! src/cpu/x86/vm/c1_Runtime1_x86.cpp ! src/cpu/x86/vm/c1_globals_x86.hpp ! src/cpu/x86/vm/c2_globals_x86.hpp ! src/cpu/x86/vm/frame_x86.hpp ! src/cpu/x86/vm/frame_x86.inline.hpp ! src/cpu/x86/vm/globalDefinitions_x86.hpp ! src/cpu/x86/vm/register_definitions_x86.cpp ! src/cpu/x86/vm/sharedRuntime_x86_32.cpp ! src/cpu/x86/vm/sharedRuntime_x86_64.cpp ! src/cpu/x86/vm/templateInterpreter_x86.hpp ! src/cpu/x86/vm/vmStructs_x86.hpp ! src/cpu/x86/vm/vtableStubs_x86_32.cpp ! src/cpu/x86/vm/vtableStubs_x86_64.cpp ! src/cpu/zero/vm/assembler_zero.cpp ! src/cpu/zero/vm/cppInterpreter_zero.cpp ! src/cpu/zero/vm/entryFrame_zero.hpp ! src/cpu/zero/vm/frame_zero.cpp ! src/cpu/zero/vm/frame_zero.inline.hpp ! src/cpu/zero/vm/globals_zero.hpp ! src/cpu/zero/vm/icBuffer_zero.cpp ! src/cpu/zero/vm/interp_masm_zero.hpp ! src/cpu/zero/vm/interpreter_zero.cpp ! src/cpu/zero/vm/jni_zero.h ! src/cpu/zero/vm/nativeInst_zero.hpp ! src/cpu/zero/vm/register_zero.cpp ! src/cpu/zero/vm/relocInfo_zero.cpp ! src/cpu/zero/vm/sharedRuntime_zero.cpp ! src/cpu/zero/vm/sharkFrame_zero.hpp ! src/cpu/zero/vm/stubGenerator_zero.cpp ! src/cpu/zero/vm/vmStructs_zero.hpp ! src/cpu/zero/vm/vtableStubs_zero.cpp ! src/os/bsd/dtrace/jvm_dtrace.c ! src/os/posix/vm/os_posix.hpp ! src/os/solaris/dtrace/jvm_dtrace.c ! src/os/solaris/vm/globals_solaris.hpp ! src/os/windows/vm/decoder_windows.hpp ! src/os_cpu/bsd_x86/vm/bsd_x86_32.s ! src/os_cpu/bsd_x86/vm/bsd_x86_64.s ! src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp ! src/os_cpu/bsd_x86/vm/vmStructs_bsd_x86.hpp ! src/os_cpu/bsd_zero/vm/globals_bsd_zero.hpp ! src/os_cpu/bsd_zero/vm/os_bsd_zero.cpp ! src/os_cpu/bsd_zero/vm/thread_bsd_zero.hpp ! src/os_cpu/bsd_zero/vm/vmStructs_bsd_zero.hpp ! src/os_cpu/linux_sparc/vm/globals_linux_sparc.hpp ! src/os_cpu/linux_sparc/vm/linux_sparc.s ! src/os_cpu/linux_sparc/vm/os_linux_sparc.cpp ! src/os_cpu/linux_sparc/vm/vmStructs_linux_sparc.hpp ! src/os_cpu/linux_x86/vm/globals_linux_x86.hpp ! src/os_cpu/linux_x86/vm/linux_x86_32.s ! src/os_cpu/linux_x86/vm/linux_x86_64.s ! src/os_cpu/linux_x86/vm/os_linux_x86.cpp ! src/os_cpu/linux_x86/vm/os_linux_x86.hpp ! src/os_cpu/linux_x86/vm/vmStructs_linux_x86.hpp ! src/os_cpu/linux_zero/vm/globals_linux_zero.hpp ! src/os_cpu/linux_zero/vm/os_linux_zero.cpp ! src/os_cpu/linux_zero/vm/vmStructs_linux_zero.hpp ! src/os_cpu/solaris_sparc/vm/globals_solaris_sparc.hpp ! src/os_cpu/solaris_sparc/vm/solaris_sparc.il ! src/os_cpu/solaris_sparc/vm/solaris_sparc.s ! src/os_cpu/solaris_sparc/vm/vmStructs_solaris_sparc.hpp ! src/os_cpu/solaris_x86/vm/globals_solaris_x86.hpp ! src/os_cpu/solaris_x86/vm/solaris_x86_32.s ! src/os_cpu/solaris_x86/vm/solaris_x86_64.s ! src/os_cpu/solaris_x86/vm/vmStructs_solaris_x86.hpp ! src/os_cpu/windows_x86/vm/globals_windows_x86.hpp ! src/os_cpu/windows_x86/vm/os_windows_x86.cpp ! src/os_cpu/windows_x86/vm/os_windows_x86.hpp ! src/os_cpu/windows_x86/vm/vmStructs_windows_x86.hpp ! src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/CallSite.java ! src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogParser.java ! src/share/tools/ProjectCreator/WinGammaPlatformVC7.java ! src/share/tools/hsdis/hsdis.c ! src/share/vm/adlc/adlparse.cpp ! src/share/vm/adlc/archDesc.cpp ! src/share/vm/adlc/dfa.cpp ! src/share/vm/adlc/dict2.cpp ! src/share/vm/adlc/formssel.cpp ! src/share/vm/adlc/formssel.hpp ! src/share/vm/adlc/output_c.cpp ! src/share/vm/adlc/output_h.cpp ! src/share/vm/asm/assembler.cpp ! src/share/vm/asm/assembler.hpp ! src/share/vm/asm/codeBuffer.cpp ! src/share/vm/asm/macroAssembler.hpp ! src/share/vm/asm/macroAssembler.inline.hpp ! src/share/vm/c1/c1_Canonicalizer.cpp ! src/share/vm/c1/c1_Canonicalizer.hpp ! src/share/vm/c1/c1_CodeStubs.hpp ! src/share/vm/c1/c1_Compilation.cpp ! src/share/vm/c1/c1_Compiler.cpp ! src/share/vm/c1/c1_Compiler.hpp ! src/share/vm/c1/c1_FrameMap.cpp ! src/share/vm/c1/c1_FrameMap.hpp ! src/share/vm/c1/c1_GraphBuilder.hpp ! src/share/vm/c1/c1_IR.cpp ! src/share/vm/c1/c1_IR.hpp ! src/share/vm/c1/c1_Instruction.cpp ! src/share/vm/c1/c1_InstructionPrinter.hpp ! src/share/vm/c1/c1_LIRAssembler.cpp ! src/share/vm/c1/c1_LinearScan.cpp ! src/share/vm/c1/c1_Optimizer.cpp ! src/share/vm/c1/c1_RangeCheckElimination.cpp ! src/share/vm/c1/c1_RangeCheckElimination.hpp ! src/share/vm/c1/c1_Runtime1.hpp ! src/share/vm/c1/c1_ValueMap.cpp ! src/share/vm/c1/c1_ValueMap.hpp ! src/share/vm/c1/c1_globals.cpp ! src/share/vm/c1/c1_globals.hpp ! src/share/vm/ci/bcEscapeAnalyzer.cpp ! src/share/vm/ci/bcEscapeAnalyzer.hpp ! src/share/vm/ci/ciArray.cpp ! src/share/vm/ci/ciArray.hpp ! src/share/vm/ci/ciClassList.hpp ! src/share/vm/ci/ciConstant.hpp ! src/share/vm/ci/ciEnv.hpp ! src/share/vm/ci/ciFlags.hpp ! src/share/vm/ci/ciInstance.cpp ! src/share/vm/ci/ciInstanceKlass.hpp ! src/share/vm/ci/ciKlass.cpp ! src/share/vm/ci/ciKlass.hpp ! src/share/vm/ci/ciMethodData.cpp ! src/share/vm/ci/ciMethodData.hpp ! src/share/vm/ci/ciObjArrayKlass.cpp ! src/share/vm/ci/ciObjArrayKlass.hpp ! src/share/vm/ci/ciObjectFactory.cpp ! src/share/vm/ci/ciObjectFactory.hpp ! src/share/vm/ci/ciStreams.hpp ! src/share/vm/ci/ciType.cpp ! src/share/vm/ci/ciType.hpp ! src/share/vm/ci/ciTypeArray.cpp ! src/share/vm/ci/ciTypeArrayKlass.hpp ! src/share/vm/ci/ciTypeFlow.cpp ! src/share/vm/ci/ciUtilities.hpp ! src/share/vm/classfile/bytecodeAssembler.cpp ! src/share/vm/classfile/classFileStream.cpp ! src/share/vm/classfile/classFileStream.hpp ! src/share/vm/classfile/classLoaderData.inline.hpp ! src/share/vm/classfile/vmSymbols.cpp ! src/share/vm/code/compiledIC.hpp ! src/share/vm/code/compressedStream.cpp ! src/share/vm/code/debugInfo.hpp ! src/share/vm/code/icBuffer.hpp ! src/share/vm/code/relocInfo.cpp ! src/share/vm/code/stubs.cpp ! src/share/vm/code/stubs.hpp ! src/share/vm/compiler/abstractCompiler.cpp ! src/share/vm/compiler/abstractCompiler.hpp ! src/share/vm/compiler/compileLog.cpp ! src/share/vm/compiler/compileLog.hpp ! src/share/vm/compiler/compilerOracle.cpp ! src/share/vm/compiler/disassembler.cpp ! src/share/vm/compiler/disassembler.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/adaptiveFreeList.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/adaptiveFreeList.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsCollectorPolicy.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsOopClosures.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepThread.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepThread.hpp ! src/share/vm/gc_implementation/g1/collectionSetChooser.cpp ! src/share/vm/gc_implementation/g1/collectionSetChooser.hpp ! src/share/vm/gc_implementation/g1/g1AllocRegion.hpp ! src/share/vm/gc_implementation/g1/g1BlockOffsetTable.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.inline.hpp ! src/share/vm/gc_implementation/g1/g1EvacFailure.hpp ! src/share/vm/gc_implementation/g1/g1MonitoringSupport.cpp ! src/share/vm/gc_implementation/g1/g1SATBCardTableModRefBS.hpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.hpp ! src/share/vm/gc_implementation/g1/heapRegionSeq.cpp ! src/share/vm/gc_implementation/g1/heapRegionSeq.hpp ! src/share/vm/gc_implementation/g1/heapRegionSeq.inline.hpp ! src/share/vm/gc_implementation/g1/ptrQueue.cpp ! src/share/vm/gc_implementation/g1/ptrQueue.hpp ! src/share/vm/gc_implementation/g1/sparsePRT.cpp ! src/share/vm/gc_implementation/g1/sparsePRT.hpp ! src/share/vm/gc_implementation/g1/vmStructs_g1.hpp ! src/share/vm/gc_implementation/parNew/parCardTableModRefBS.cpp ! src/share/vm/gc_implementation/parallelScavenge/adjoiningGenerations.cpp ! src/share/vm/gc_implementation/parallelScavenge/adjoiningGenerations.hpp ! src/share/vm/gc_implementation/parallelScavenge/asPSOldGen.cpp ! src/share/vm/gc_implementation/parallelScavenge/asPSOldGen.hpp ! src/share/vm/gc_implementation/parallelScavenge/asPSYoungGen.cpp ! src/share/vm/gc_implementation/parallelScavenge/gcTaskThread.cpp ! src/share/vm/gc_implementation/parallelScavenge/objectStartArray.cpp ! src/share/vm/gc_implementation/parallelScavenge/pcTasks.hpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.hpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweepDecorator.cpp ! src/share/vm/gc_implementation/parallelScavenge/psOldGen.cpp ! src/share/vm/gc_implementation/parallelScavenge/psOldGen.hpp ! src/share/vm/gc_implementation/parallelScavenge/psTasks.cpp ! src/share/vm/gc_implementation/parallelScavenge/psTasks.hpp ! src/share/vm/gc_implementation/parallelScavenge/psYoungGen.cpp ! src/share/vm/gc_implementation/shared/allocationStats.cpp ! src/share/vm/gc_implementation/shared/concurrentGCThread.hpp ! src/share/vm/gc_implementation/shared/gSpaceCounters.cpp ! src/share/vm/gc_implementation/shared/gSpaceCounters.hpp ! src/share/vm/gc_implementation/shared/gcAdaptivePolicyCounters.hpp ! src/share/vm/gc_implementation/shared/immutableSpace.cpp ! src/share/vm/gc_implementation/shared/isGCActiveMark.hpp ! src/share/vm/gc_implementation/shared/markSweep.inline.hpp ! src/share/vm/gc_implementation/shared/mutableNUMASpace.cpp ! src/share/vm/gc_implementation/shared/mutableNUMASpace.hpp ! src/share/vm/gc_implementation/shared/mutableSpace.cpp ! src/share/vm/gc_implementation/shared/parGCAllocBuffer.hpp ! src/share/vm/gc_implementation/shared/spaceCounters.cpp ! src/share/vm/gc_implementation/shared/spaceCounters.hpp ! src/share/vm/gc_interface/collectedHeap.inline.hpp ! src/share/vm/gc_interface/gcCause.cpp ! src/share/vm/gc_interface/gcCause.hpp ! src/share/vm/interpreter/bytecodeInterpreter.cpp ! src/share/vm/interpreter/cppInterpreter.hpp ! src/share/vm/interpreter/interpreter.hpp ! src/share/vm/interpreter/templateInterpreter.hpp ! src/share/vm/interpreter/templateInterpreterGenerator.hpp ! src/share/vm/interpreter/templateTable.hpp ! src/share/vm/memory/binaryTreeDictionary.hpp ! src/share/vm/memory/blockOffsetTable.cpp ! src/share/vm/memory/freeBlockDictionary.cpp ! src/share/vm/memory/freeList.cpp ! src/share/vm/memory/freeList.hpp ! src/share/vm/memory/gcLocker.cpp ! src/share/vm/memory/gcLocker.hpp ! src/share/vm/memory/genRemSet.cpp ! src/share/vm/memory/genRemSet.hpp ! src/share/vm/memory/generation.hpp ! src/share/vm/memory/generationSpec.cpp ! src/share/vm/memory/heap.hpp ! src/share/vm/memory/iterator.cpp ! src/share/vm/memory/iterator.hpp ! src/share/vm/memory/metaspaceCounters.cpp ! src/share/vm/memory/metaspaceCounters.hpp ! src/share/vm/memory/sharedHeap.hpp ! src/share/vm/memory/space.cpp ! src/share/vm/memory/space.hpp ! src/share/vm/memory/specialized_oop_closures.hpp ! src/share/vm/memory/tenuredGeneration.cpp ! src/share/vm/memory/tenuredGeneration.hpp ! src/share/vm/oops/arrayKlass.cpp ! src/share/vm/oops/arrayOop.hpp ! src/share/vm/oops/compiledICHolder.cpp ! src/share/vm/oops/fieldInfo.hpp ! src/share/vm/oops/instanceClassLoaderKlass.cpp ! src/share/vm/oops/instanceClassLoaderKlass.hpp ! src/share/vm/oops/instanceMirrorKlass.cpp ! src/share/vm/oops/instanceOop.hpp ! src/share/vm/oops/instanceRefKlass.hpp ! src/share/vm/oops/klassPS.hpp ! src/share/vm/oops/objArrayKlass.cpp ! src/share/vm/oops/objArrayKlass.hpp ! src/share/vm/oops/objArrayKlass.inline.hpp ! src/share/vm/oops/oop.pcgc.inline.hpp ! src/share/vm/oops/oop.psgc.inline.hpp ! src/share/vm/oops/typeArrayKlass.cpp ! src/share/vm/oops/typeArrayKlass.hpp ! src/share/vm/opto/block.cpp ! src/share/vm/opto/block.hpp ! src/share/vm/opto/buildOopMap.cpp ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/opto/c2compiler.cpp ! src/share/vm/opto/c2compiler.hpp ! src/share/vm/opto/callGenerator.cpp ! src/share/vm/opto/callnode.cpp ! src/share/vm/opto/chaitin.hpp ! src/share/vm/opto/classes.cpp ! src/share/vm/opto/classes.hpp ! src/share/vm/opto/coalesce.hpp ! src/share/vm/opto/connode.cpp ! src/share/vm/opto/doCall.cpp ! src/share/vm/opto/domgraph.cpp ! src/share/vm/opto/gcm.cpp ! src/share/vm/opto/generateOptoStub.cpp ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/graphKit.hpp ! src/share/vm/opto/idealKit.cpp ! src/share/vm/opto/idealKit.hpp ! src/share/vm/opto/ifg.cpp ! src/share/vm/opto/ifnode.cpp ! src/share/vm/opto/lcm.cpp ! src/share/vm/opto/live.cpp ! src/share/vm/opto/live.hpp ! src/share/vm/opto/loopPredicate.cpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/loopnode.hpp ! src/share/vm/opto/loopopts.cpp ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/macro.hpp ! src/share/vm/opto/matcher.hpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/memnode.hpp ! src/share/vm/opto/multnode.cpp ! src/share/vm/opto/multnode.hpp ! src/share/vm/opto/node.cpp ! src/share/vm/opto/optoreg.hpp ! src/share/vm/opto/output.cpp ! src/share/vm/opto/output.hpp ! src/share/vm/opto/parse.hpp ! src/share/vm/opto/parse1.cpp ! src/share/vm/opto/parse2.cpp ! src/share/vm/opto/phase.cpp ! src/share/vm/opto/phase.hpp ! src/share/vm/opto/phaseX.cpp ! src/share/vm/opto/phaseX.hpp ! src/share/vm/opto/postaloc.cpp ! src/share/vm/opto/reg_split.cpp ! src/share/vm/opto/regalloc.cpp ! src/share/vm/opto/regalloc.hpp ! src/share/vm/opto/subnode.cpp ! src/share/vm/opto/subnode.hpp ! src/share/vm/opto/superword.cpp ! src/share/vm/opto/superword.hpp ! src/share/vm/precompiled/precompiled.hpp ! src/share/vm/prims/forte.cpp ! src/share/vm/prims/jniCheck.cpp ! src/share/vm/prims/jvm_misc.hpp ! src/share/vm/prims/jvmtiClassFileReconstituter.cpp ! src/share/vm/prims/jvmtiClassFileReconstituter.hpp ! src/share/vm/prims/jvmtiEnter.xsl ! src/share/vm/prims/jvmtiEnvBase.hpp ! src/share/vm/prims/jvmtiEnvThreadState.cpp ! src/share/vm/prims/jvmtiEventController.cpp ! src/share/vm/prims/jvmtiExport.hpp ! src/share/vm/prims/jvmtiGetLoadedClasses.cpp ! src/share/vm/prims/jvmtiTrace.hpp ! src/share/vm/prims/nativeLookup.cpp ! src/share/vm/prims/perf.cpp ! src/share/vm/prims/wbtestmethods/parserTests.hpp ! src/share/vm/prims/whitebox.hpp ! src/share/vm/runtime/advancedThresholdPolicy.hpp ! src/share/vm/runtime/atomic.cpp ! src/share/vm/runtime/atomic.hpp ! src/share/vm/runtime/compilationPolicy.hpp ! src/share/vm/runtime/fprofiler.hpp ! src/share/vm/runtime/globals_extension.hpp ! src/share/vm/runtime/handles.inline.hpp ! src/share/vm/runtime/javaCalls.hpp ! src/share/vm/runtime/jniHandles.cpp ! src/share/vm/runtime/mutex.cpp ! src/share/vm/runtime/perfData.hpp ! src/share/vm/runtime/reflection.hpp ! src/share/vm/runtime/sharedRuntime.hpp ! src/share/vm/runtime/signature.cpp ! src/share/vm/runtime/signature.hpp ! src/share/vm/runtime/stubCodeGenerator.cpp ! src/share/vm/runtime/synchronizer.hpp ! src/share/vm/runtime/unhandledOops.hpp ! src/share/vm/runtime/vframe.cpp ! src/share/vm/runtime/vframe.hpp ! src/share/vm/runtime/vframeArray.hpp ! src/share/vm/runtime/virtualspace.hpp ! src/share/vm/runtime/vm_version.hpp ! src/share/vm/services/classLoadingService.hpp ! src/share/vm/services/dtraceAttacher.cpp ! src/share/vm/services/g1MemoryPool.hpp ! src/share/vm/services/memReporter.cpp ! src/share/vm/services/memReporter.hpp ! src/share/vm/services/memSnapshot.hpp ! src/share/vm/services/memoryManager.hpp ! src/share/vm/services/memoryPool.hpp ! src/share/vm/services/memoryService.cpp ! src/share/vm/services/memoryService.hpp ! src/share/vm/services/memoryUsage.hpp ! src/share/vm/services/psMemoryPool.hpp ! src/share/vm/services/threadService.hpp ! src/share/vm/shark/sharkBlock.cpp ! src/share/vm/shark/sharkBuilder.cpp ! src/share/vm/shark/sharkCompiler.cpp ! src/share/vm/shark/sharkCompiler.hpp ! src/share/vm/shark/sharkConstant.cpp ! src/share/vm/shark/sharkFunction.cpp ! src/share/vm/shark/sharkInliner.cpp ! src/share/vm/shark/sharkInvariants.hpp ! src/share/vm/shark/sharkTopLevelBlock.cpp ! src/share/vm/utilities/bitMap.cpp ! src/share/vm/utilities/bitMap.hpp ! src/share/vm/utilities/bitMap.inline.hpp ! src/share/vm/utilities/decoder.cpp ! src/share/vm/utilities/decoder.hpp ! src/share/vm/utilities/elfFile.cpp ! src/share/vm/utilities/elfFile.hpp ! src/share/vm/utilities/exceptions.cpp ! src/share/vm/utilities/globalDefinitions.cpp ! src/share/vm/utilities/globalDefinitions_visCPP.hpp ! src/share/vm/utilities/growableArray.hpp ! src/share/vm/utilities/hashtable.hpp ! src/share/vm/utilities/macros.hpp ! src/share/vm/utilities/numberSeq.cpp ! src/share/vm/utilities/ostream.hpp ! src/share/vm/utilities/top.hpp ! src/share/vm/utilities/yieldingWorkgroup.cpp ! test/Makefile ! test/TEST.ROOT ! test/compiler/5091921/Test7005594.sh ! test/compiler/6431242/Test.java ! test/compiler/6589834/Test_ia32.java ! test/compiler/6636138/Test1.java ! test/compiler/6636138/Test2.java ! test/compiler/6795161/Test.java ! test/compiler/6857159/Test6857159.sh ! test/compiler/7068051/Test7068051.sh ! test/compiler/7070134/Test7070134.sh ! test/compiler/7200264/Test7200264.sh ! test/compiler/8000805/Test8000805.java ! test/compiler/8005419/Test8005419.java ! test/gc/6941923/Test6941923.java ! test/gc/g1/TestHumongousAllocInitialMark.java ! test/runtime/6626217/Test6626217.sh ! test/runtime/7110720/Test7110720.sh ! test/runtime/7162488/Test7162488.sh ! test/runtime/RedefineObject/Agent.java ! test/runtime/RedefineObject/TestRedefineObject.java Changeset: d3521d8e562a Author: amurillo Date: 2013-12-27 07:32 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d3521d8e562a Added tag hs25-b65 for changeset 55fb97c4c58d ! .hgtags Changeset: a902f789ea1f Author: asaha Date: 2014-01-02 15:19 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a902f789ea1f Merge Changeset: 591135a7d6f9 Author: katleman Date: 2014-01-03 11:54 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/591135a7d6f9 Added tag jdk8-b122 for changeset d3521d8e562a ! .hgtags Changeset: 3b69a859e3f9 Author: asaha Date: 2014-01-03 15:58 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3b69a859e3f9 Merge From alexander.zuev at oracle.com Tue Jan 14 11:30:13 2014 From: alexander.zuev at oracle.com (alexander.zuev at oracle.com) Date: Tue, 14 Jan 2014 19:30:13 +0000 Subject: hg: jdk8/tl/jaxp: 18 new changesets Message-ID: <20140114193052.B889062431@hg.openjdk.java.net> Changeset: 51bbdd517b93 Author: joehw Date: 2013-08-26 21:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/51bbdd517b93 8022935: Enhance Apache resolver classes Reviewed-by: alanb, mchung, skoivu ! src/com/sun/org/apache/xml/internal/resolver/CatalogManager.java ! src/com/sun/org/apache/xml/internal/resolver/readers/DOMCatalogReader.java ! src/com/sun/org/apache/xml/internal/resolver/readers/SAXCatalogReader.java Changeset: d6d8302ecf8f Author: chegar Date: 2013-08-30 10:15 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/d6d8302ecf8f Merge ! src/com/sun/org/apache/xerces/internal/parsers/DTDConfiguration.java ! src/com/sun/org/apache/xerces/internal/parsers/NonValidatingConfiguration.java ! src/com/sun/org/apache/xerces/internal/parsers/SAXParser.java Changeset: aef8ae2fcec4 Author: chegar Date: 2013-09-06 09:55 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/aef8ae2fcec4 Merge Changeset: 0ce80229af71 Author: chegar Date: 2013-09-14 20:43 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/0ce80229af71 Merge Changeset: 5e6bf44f3b7d Author: chegar Date: 2013-10-03 19:18 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/5e6bf44f3b7d Merge Changeset: 54a0dd196acd Author: chegar Date: 2013-10-21 14:27 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/54a0dd196acd Merge Changeset: 10b3a127b1fc Author: joehw Date: 2013-10-22 13:15 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/10b3a127b1fc 8025018: Enhance JAX-P set up Reviewed-by: alanb, dfuchs, lancea, ahgross ! src/com/sun/org/apache/xalan/internal/lib/ExsltStrings.java ! src/com/sun/org/apache/xalan/internal/lib/Extensions.java Changeset: ef71f2353352 Author: chegar Date: 2013-10-25 09:32 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/ef71f2353352 Merge Changeset: e68f3e585d7d Author: chegar Date: 2013-11-03 07:32 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/e68f3e585d7d Merge Changeset: fb51ed270f53 Author: joehw Date: 2013-11-14 10:18 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/fb51ed270f53 8027201: Enhance JAX-P set up Reviewed-by: alanb, dfuchs, lancea, hawtin ! src/com/sun/org/apache/xalan/internal/lib/ExsltStrings.java ! src/com/sun/org/apache/xalan/internal/lib/Extensions.java Changeset: 932684ede1c6 Author: joehw Date: 2013-11-27 14:28 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/932684ede1c6 8028111: XML readers share the same entity expansion counter Reviewed-by: alanb, lancea, dfuchs, ahgross ! src/com/sun/org/apache/xalan/internal/XalanConstants.java ! src/com/sun/org/apache/xalan/internal/utils/XMLSecurityManager.java ! src/com/sun/org/apache/xerces/internal/impl/Constants.java ! src/com/sun/org/apache/xerces/internal/impl/XMLDTDScannerImpl.java ! src/com/sun/org/apache/xerces/internal/impl/XMLDocumentFragmentScannerImpl.java ! src/com/sun/org/apache/xerces/internal/impl/XMLDocumentScannerImpl.java ! src/com/sun/org/apache/xerces/internal/impl/XMLEntityManager.java ! src/com/sun/org/apache/xerces/internal/impl/XMLNSDocumentScannerImpl.java ! src/com/sun/org/apache/xerces/internal/utils/XMLLimitAnalyzer.java ! src/com/sun/org/apache/xerces/internal/utils/XMLSecurityManager.java ! src/com/sun/org/apache/xerces/internal/xni/parser/XMLDTDScanner.java Changeset: 2a8fce63503a Author: kizune Date: 2013-12-03 14:13 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/2a8fce63503a Merge ! src/com/sun/org/apache/xerces/internal/impl/XMLDocumentFragmentScannerImpl.java Changeset: 5be9182ceb48 Author: kizune Date: 2013-12-05 16:37 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/5be9182ceb48 Merge - make/jprt.properties - make/scripts/update_src.sh - makefiles/BuildJaxp.gmk - makefiles/Makefile Changeset: 41068d69fe3e Author: kizune Date: 2013-12-13 22:13 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/41068d69fe3e Merge Changeset: f2c9c0f64280 Author: asaha Date: 2013-12-20 07:42 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/f2c9c0f64280 Merge Changeset: 01b611e0c341 Author: asaha Date: 2014-01-02 15:20 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/01b611e0c341 Merge ! src/com/sun/org/apache/xalan/internal/XalanConstants.java ! src/com/sun/org/apache/xerces/internal/impl/Constants.java ! src/com/sun/org/apache/xerces/internal/impl/XMLDTDScannerImpl.java ! src/com/sun/org/apache/xerces/internal/impl/XMLDocumentFragmentScannerImpl.java ! src/com/sun/org/apache/xerces/internal/impl/XMLDocumentScannerImpl.java Changeset: 4e35b5b6d2e5 Author: katleman Date: 2014-01-03 11:54 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/4e35b5b6d2e5 Added tag jdk8-b122 for changeset 93bf25903af0 ! .hgtags Changeset: 985376a77c4c Author: asaha Date: 2014-01-03 15:58 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/985376a77c4c Merge From alexander.zuev at oracle.com Tue Jan 14 11:31:06 2014 From: alexander.zuev at oracle.com (alexander.zuev at oracle.com) Date: Tue, 14 Jan 2014 19:31:06 +0000 Subject: hg: jdk8/tl/jaxws: 8 new changesets Message-ID: <20140114193123.8797F62432@hg.openjdk.java.net> Changeset: b0c2840e2513 Author: mkos Date: 2013-11-22 21:11 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/b0c2840e2513 8010935: Better XML handling 8027378: Two closed/javax/xml/8005432 fails with jdk7u51b04 8028382: Two javax/xml/8005433 tests still fail after the fix JDK-8028147 Summary: base fix + fixes for test regressions; fix also reviewed by Maxim Soloviev, Alexander Fomin Reviewed-by: mchung, mgrebac, mullan ! src/share/jaxws_classes/com/sun/tools/internal/jxc/model/nav/ApNavigator.java ! src/share/jaxws_classes/com/sun/tools/internal/xjc/model/nav/EagerNType.java ! src/share/jaxws_classes/com/sun/tools/internal/xjc/model/nav/NavigatorImpl.java + src/share/jaxws_classes/com/sun/tools/internal/xjc/model/nav/Utils.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/api/JAXBRIContext.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/api/TypeReference.java + src/share/jaxws_classes/com/sun/xml/internal/bind/api/Utils.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/impl/ModelBuilder.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/impl/RuntimeAnyTypeImpl.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/impl/RuntimeBuiltinLeafInfoImpl.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/impl/RuntimeElementInfoImpl.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/impl/RuntimeModelBuilder.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/impl/RuntimeTypeInfoSetImpl.java + src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/impl/Utils.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/nav/Navigator.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/nav/ReflectionNavigator.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/runtime/RuntimeTypeInfoSet.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/ClassBeanInfoImpl.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/ElementBeanInfoImpl.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/JAXBContextImpl.java + src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/Utils.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/property/ArrayProperty.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/property/SingleMapNodeProperty.java + src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/property/Utils.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/reflect/Accessor.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/reflect/Lister.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/reflect/TransducedAccessor.java + src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/reflect/Utils.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/fault/SOAPFaultBuilder.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/model/RuntimeModeler.java + src/share/jaxws_classes/com/sun/xml/internal/ws/model/Utils.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/model/WrapperBeanGenerator.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/spi/db/BindingHelper.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/spi/db/TypeInfo.java + src/share/jaxws_classes/com/sun/xml/internal/ws/spi/db/Utils.java Changeset: f80c37c168f7 Author: kizune Date: 2013-12-03 14:13 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/f80c37c168f7 Merge Changeset: c99140027351 Author: kizune Date: 2013-12-05 16:37 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/c99140027351 Merge - make/jprt.properties - make/scripts/update_src.sh - makefiles/BuildJaxws.gmk - makefiles/Makefile Changeset: ca6bb6b558a6 Author: kizune Date: 2013-12-13 22:13 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/ca6bb6b558a6 Merge Changeset: d4b785ac4079 Author: asaha Date: 2013-12-20 07:42 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/d4b785ac4079 Merge Changeset: 91f5c542ccad Author: katleman Date: 2014-01-03 11:54 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/91f5c542ccad Added tag jdk8-b122 for changeset bc622ba563f9 ! .hgtags Changeset: c07fc967624b Author: asaha Date: 2014-01-03 15:59 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/c07fc967624b Merge Changeset: 6547da5c3277 Author: kizune Date: 2014-01-14 23:10 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/6547da5c3277 Merge From alexander.zuev at oracle.com Tue Jan 14 11:35:25 2014 From: alexander.zuev at oracle.com (alexander.zuev at oracle.com) Date: Tue, 14 Jan 2014 19:35:25 +0000 Subject: hg: jdk8/tl/jdk: 53 new changesets Message-ID: <20140114194639.1F1C362434@hg.openjdk.java.net> Changeset: 75142ce752da Author: malenkov Date: 2013-12-23 16:24 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/75142ce752da 8030118: Document listeners fired outside document lock Reviewed-by: art, serb ! src/share/classes/javax/swing/text/AbstractDocument.java - test/javax/swing/text/AbstractDocument/7146146/bug7146146.java + test/javax/swing/text/AbstractDocument/8030118/Test8030118.java Changeset: 8b5985f1a0b5 Author: lana Date: 2013-12-25 11:14 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8b5985f1a0b5 Merge - src/share/classes/sun/util/resources/pt/LocaleNames_pt_BR.properties - test/sun/security/ssl/javax/net/ssl/SSLContextVersion.java Changeset: e1499442453b Author: lana Date: 2013-12-26 22:39 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e1499442453b Merge ! src/share/classes/javax/swing/text/AbstractDocument.java Changeset: 7e10ee00fe41 Author: katleman Date: 2014-01-03 11:54 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7e10ee00fe41 Added tag jdk8-b122 for changeset e1499442453b ! .hgtags Changeset: 484e16c0a040 Author: nikgor Date: 2014-01-07 12:17 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/484e16c0a040 8004562: Better support for crossdomain.xml Reviewed-by: herrick, ngthomas, chegar ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java Changeset: 0dfcc99c6f5d Author: weijun Date: 2013-08-16 17:57 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0dfcc99c6f5d 8022945: Enhance JNDI implementation classes Reviewed-by: xuelei, ahgross, skoivu ! src/share/lib/security/java.security-linux ! src/share/lib/security/java.security-macosx ! src/share/lib/security/java.security-solaris ! src/share/lib/security/java.security-windows ! test/java/lang/SecurityManager/CheckPackageAccess.java Changeset: 46c8720ef36f Author: lancea Date: 2013-08-21 11:05 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/46c8720ef36f 8022904: Enhance JDBC Parsers Reviewed-by: alanb, skoivu ! src/share/classes/com/sun/rowset/internal/XmlReaderContentHandler.java ! src/share/classes/javax/sql/rowset/spi/SyncFactory.java Changeset: 428288ee9c99 Author: valeriep Date: 2013-08-21 11:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/428288ee9c99 8022927: Input validation for byte/endian conversions Summary: Add additional boundary checks Reviewed-by: ascarpino ! src/share/classes/sun/security/provider/ByteArrayAccess.java Changeset: 24a7024bd86b Author: bae Date: 2013-08-23 12:41 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/24a7024bd86b 8021394: Better color profiles Reviewed-by: prr, vadim, mschoene ! src/share/native/sun/java2d/cmm/lcms/cmsintrp.c Changeset: ff2792868d89 Author: chegar Date: 2013-08-23 12:32 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ff2792868d89 Merge Changeset: 036ad7864d35 Author: chegar Date: 2013-08-30 09:38 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/036ad7864d35 Merge ! src/share/lib/security/java.security-linux ! src/share/lib/security/java.security-macosx ! src/share/lib/security/java.security-solaris ! src/share/lib/security/java.security-windows Changeset: 2ae5cf0805de Author: malenkov Date: 2013-09-02 11:41 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2ae5cf0805de 8023245: Enhance Beans decoding Reviewed-by: art, skoivu, alanb ! src/share/classes/com/sun/beans/decoder/DocumentHandler.java Changeset: 9bc1411d0223 Author: coleenp Date: 2013-09-05 10:29 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9bc1411d0223 8021266: Better life cycle for objects Summary: Improve life cycle for objects Reviewed-by: art, hseigel Contributed-by: gerard.ziemski at oracle.com ! make/common/Release.gmk ! make/java/Makefile ! makefiles/CompileJavaClasses.gmk ! makefiles/CompileNativeLibraries.gmk ! makefiles/CreateJars.gmk ! makefiles/GenerateJavaSources.gmk ! makefiles/Images.gmk ! makefiles/Profiles.gmk Changeset: 46e86a9402ab Author: chegar Date: 2013-09-06 13:36 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/46e86a9402ab Merge ! makefiles/Profiles.gmk ! src/share/lib/security/java.security-linux ! src/share/lib/security/java.security-macosx ! src/share/lib/security/java.security-solaris ! src/share/lib/security/java.security-windows ! test/java/lang/SecurityManager/CheckPackageAccess.java Changeset: 4cab5eb93124 Author: xuelei Date: 2013-09-07 20:27 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4cab5eb93124 8023069: Enhance TLS connections Summary: Also reviewed by Alexander Fomin and Andrew Gross Reviewed-by: wetmore ! src/share/classes/com/sun/crypto/provider/TlsRsaPremasterSecretGenerator.java ! src/share/classes/sun/security/internal/spec/TlsRsaPremasterSecretParameterSpec.java ! src/share/classes/sun/security/pkcs11/P11RSACipher.java ! src/share/classes/sun/security/pkcs11/P11TlsRsaPremasterSecretGenerator.java ! src/share/classes/sun/security/rsa/RSAPadding.java ! src/share/classes/sun/security/ssl/Handshaker.java ! src/share/classes/sun/security/ssl/RSAClientKeyExchange.java Changeset: ac3e7b3c1a00 Author: weijun Date: 2013-09-13 15:37 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ac3e7b3c1a00 8024306: Enhance Subject consistency Summary: Also reviewed by Alexander Fomin Reviewed-by: mullan, ahgross ! src/share/classes/javax/security/auth/Subject.java Changeset: 4b74f9ad3dd7 Author: weijun Date: 2013-09-13 15:37 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4b74f9ad3dd7 8023672: Enhance jar file validation Summary: Also reviewed by Chris Ries and Alexander Fomin Reviewed-by: mullan, sherman ! src/share/classes/java/util/jar/JarVerifier.java Changeset: 432c348e15bc Author: vadim Date: 2013-09-13 13:17 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/432c348e15bc 8023057: Enhance start up image display Reviewed-by: anthony, serb, mschoene ! src/macosx/native/sun/awt/splashscreen/splashscreen_sys.m ! src/share/native/sun/awt/splashscreen/splashscreen_impl.c ! src/solaris/native/sun/awt/splashscreen/splashscreen_sys.c Changeset: ca700a3c1708 Author: chegar Date: 2013-09-14 19:23 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ca700a3c1708 Merge Changeset: d931b672bfa9 Author: prr Date: 2013-09-19 08:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d931b672bfa9 8025034: Improve layout lookups Reviewed-by: mschoene, vadim, srl ! src/share/native/sun/font/layout/LookupProcessor.cpp Changeset: a90e9b3c99b8 Author: weijun Date: 2013-09-19 10:40 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a90e9b3c99b8 8024302: Clarify jar verifications 8023338: Update jarsigner to encourage timestamping Reviewed-by: mullan, ahgross ! src/share/classes/sun/security/tools/jarsigner/Main.java ! src/share/classes/sun/security/tools/jarsigner/Resources.java ! test/sun/security/tools/jarsigner/TimestampCheck.java ! test/sun/security/tools/jarsigner/concise_jarsigner.sh ! test/sun/security/tools/jarsigner/ts.sh + test/sun/security/tools/jarsigner/warnings.sh Changeset: f996a185e9a1 Author: weijun Date: 2013-09-19 10:41 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f996a185e9a1 8024659: Clarify JarFile API Reviewed-by: mullan, ahgross ! src/share/classes/java/util/jar/JarFile.java Changeset: f8b097b01270 Author: chegar Date: 2013-10-03 19:07 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f8b097b01270 Merge ! makefiles/CompileJavaClasses.gmk ! makefiles/CompileNativeLibraries.gmk ! makefiles/CreateJars.gmk ! makefiles/Images.gmk ! src/share/classes/javax/security/auth/Subject.java ! src/share/classes/sun/security/ssl/Handshaker.java Changeset: 1e3216123667 Author: chegar Date: 2013-10-04 14:51 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1e3216123667 Merge Changeset: 282c5e92d9a0 Author: malenkov Date: 2013-10-04 19:23 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/282c5e92d9a0 8025448: Enhance listening events Reviewed-by: art, skoivu ! src/share/classes/javax/swing/event/EventListenerList.java Changeset: 146dd44703f7 Author: chegar Date: 2013-10-07 11:32 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/146dd44703f7 Merge Changeset: 3cd01bc784b2 Author: dfuchs Date: 2013-10-07 12:09 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3cd01bc784b2 8024867: Enhance logging start up Reviewed-by: mchung, hawtin ! src/share/classes/java/util/logging/LogManager.java Changeset: d0a5383a63ad Author: weijun Date: 2013-10-09 18:58 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d0a5383a63ad 8026037: [TESTBUG] sun/security/tools/jarsigner/warnings.sh test fails on Solaris Reviewed-by: chegar Contributed-by: Artem Smotrakov ! test/sun/security/tools/jarsigner/warnings.sh Changeset: b90047350153 Author: jfranck Date: 2013-10-11 13:14 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b90047350153 8023301: Enhance generic classes Reviewed-by: mchung, hawtin ! src/share/classes/sun/reflect/generics/reflectiveObjects/TypeVariableImpl.java ! src/share/classes/sun/reflect/misc/ReflectUtil.java Changeset: eafa41f4e9fd Author: weijun Date: 2013-10-12 10:22 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/eafa41f4e9fd 8026304: jarsigner output bad grammar Reviewed-by: chegar, coffeys Contributed-by: Artem Smotrakov ! src/share/classes/sun/security/tools/jarsigner/Resources.java Changeset: 62a8a26dca09 Author: xuelei Date: 2013-10-12 20:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/62a8a26dca09 8025026: Enhance canonicalization Summary: Don't use cached null xmlns definition. Also reviewed by Alexander Fomin Reviewed-by: mullan, hawtin ! src/share/classes/com/sun/org/apache/xml/internal/security/c14n/implementations/Canonicalizer11.java ! src/share/classes/com/sun/org/apache/xml/internal/security/c14n/implementations/Canonicalizer20010315.java ! src/share/classes/com/sun/org/apache/xml/internal/security/c14n/implementations/Canonicalizer20010315Excl.java ! src/share/classes/com/sun/org/apache/xml/internal/security/c14n/implementations/CanonicalizerBase.java Changeset: c1f6ed408492 Author: prr Date: 2013-10-14 16:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c1f6ed408492 8026176: Enhance document printing Reviewed-by: bae, jgodinez ! src/share/classes/javax/print/SimpleDoc.java Changeset: 5cb70d52ae61 Author: xuelei Date: 2013-10-15 18:15 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5cb70d52ae61 8026204: Enhance auth login contexts Summary: Enforce package access control with current context. Also reviewed by Alexander Fomin Reviewed-by: weijun, ahgross ! src/share/classes/javax/security/auth/login/LoginContext.java Changeset: 48dc2eacb0e5 Author: malenkov Date: 2013-10-16 13:26 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/48dc2eacb0e5 8026172: Enhance UI Management Reviewed-by: art, skoivu ! src/share/classes/javax/swing/SwingUtilities.java Changeset: 76262685781c Author: xuelei Date: 2013-10-16 18:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/76262685781c 8025758: Enhance Naming management Summary: Enforce package access control with current context. Also reviewed by Alexander Fomin Reviewed-by: weijun, ahgross ! src/share/classes/com/sun/naming/internal/FactoryEnumeration.java ! src/share/classes/com/sun/naming/internal/VersionHelper12.java Changeset: d4f4a9915357 Author: prr Date: 2013-10-17 09:23 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d4f4a9915357 8024530: Enhance font process resilience Reviewed-by: mschoene, bae, srl, prr ! src/share/native/sun/font/layout/AlternateSubstSubtables.cpp ! src/share/native/sun/font/layout/AnchorTables.cpp ! src/share/native/sun/font/layout/AnchorTables.h ! src/share/native/sun/font/layout/ArabicLayoutEngine.cpp ! src/share/native/sun/font/layout/ArabicShaping.cpp ! src/share/native/sun/font/layout/CanonShaping.cpp ! src/share/native/sun/font/layout/CharSubstitutionFilter.h ! src/share/native/sun/font/layout/ClassDefinitionTables.h ! src/share/native/sun/font/layout/ContextualSubstSubtables.cpp ! src/share/native/sun/font/layout/ContextualSubstSubtables.h ! src/share/native/sun/font/layout/CoverageTables.cpp ! src/share/native/sun/font/layout/CoverageTables.h ! src/share/native/sun/font/layout/CursiveAttachmentSubtables.cpp ! src/share/native/sun/font/layout/DeviceTables.cpp ! src/share/native/sun/font/layout/DeviceTables.h ! src/share/native/sun/font/layout/ExtensionSubtables.cpp ! src/share/native/sun/font/layout/ExtensionSubtables.h ! src/share/native/sun/font/layout/GDEFMarkFilter.cpp ! src/share/native/sun/font/layout/GDEFMarkFilter.h ! src/share/native/sun/font/layout/GlyphIterator.cpp ! src/share/native/sun/font/layout/GlyphIterator.h ! src/share/native/sun/font/layout/GlyphPosnLookupProc.cpp ! src/share/native/sun/font/layout/GlyphSubstLookupProc.cpp ! src/share/native/sun/font/layout/IndicLayoutEngine.cpp ! src/share/native/sun/font/layout/IndicReordering.cpp ! src/share/native/sun/font/layout/KernTable.cpp ! src/share/native/sun/font/layout/LEFontInstance.h ! src/share/native/sun/font/layout/LEGlyphFilter.h ! src/share/native/sun/font/layout/LEGlyphStorage.cpp ! src/share/native/sun/font/layout/LEGlyphStorage.h ! src/share/native/sun/font/layout/LEScripts.h ! src/share/native/sun/font/layout/LEStandalone.h ! src/share/native/sun/font/layout/LETableReference.h ! src/share/native/sun/font/layout/LETypes.h ! src/share/native/sun/font/layout/LayoutEngine.cpp ! src/share/native/sun/font/layout/LayoutEngine.h ! src/share/native/sun/font/layout/LigatureSubstProc2.cpp ! src/share/native/sun/font/layout/LigatureSubstSubtables.cpp ! src/share/native/sun/font/layout/LookupProcessor.cpp ! src/share/native/sun/font/layout/Lookups.cpp ! src/share/native/sun/font/layout/MarkArrays.cpp ! src/share/native/sun/font/layout/MarkArrays.h ! src/share/native/sun/font/layout/MarkToBasePosnSubtables.cpp ! src/share/native/sun/font/layout/MarkToLigaturePosnSubtables.cpp ! src/share/native/sun/font/layout/MarkToMarkPosnSubtables.cpp ! src/share/native/sun/font/layout/MultipleSubstSubtables.cpp ! src/share/native/sun/font/layout/OpenTypeLayoutEngine.cpp ! src/share/native/sun/font/layout/OpenTypeUtilities.h ! src/share/native/sun/font/layout/PairPositioningSubtables.cpp ! src/share/native/sun/font/layout/PairPositioningSubtables.h ! src/share/native/sun/font/layout/ScriptAndLanguage.cpp ! src/share/native/sun/font/layout/ScriptAndLanguageTags.cpp ! src/share/native/sun/font/layout/ScriptAndLanguageTags.h ! src/share/native/sun/font/layout/SegmentArrayProcessor2.cpp ! src/share/native/sun/font/layout/SinglePositioningSubtables.cpp ! src/share/native/sun/font/layout/SingleSubstitutionSubtables.cpp ! src/share/native/sun/font/layout/TibetanReordering.h ! src/share/native/sun/font/layout/ValueRecords.cpp ! src/share/native/sun/font/layout/ValueRecords.h Changeset: b8008a2bf4fe Author: sjiang Date: 2013-10-21 09:56 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b8008a2bf4fe 7068126: Enhance SNMP statuses Reviewed-by: dfuchs, hawtin ! src/share/classes/com/sun/jmx/snmp/agent/SnmpMibEntry.java ! src/share/classes/com/sun/jmx/snmp/agent/SnmpMibGroup.java ! src/share/classes/com/sun/jmx/snmp/agent/SnmpMibNode.java ! src/share/classes/com/sun/jmx/snmp/agent/SnmpMibOid.java ! src/share/classes/com/sun/jmx/snmp/agent/SnmpMibTable.java ! src/share/classes/com/sun/jmx/snmp/daemon/SnmpRequestHandler.java Changeset: d7ef65d3ee57 Author: chegar Date: 2013-10-21 15:00 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d7ef65d3ee57 Merge ! makefiles/CompileJavaClasses.gmk ! makefiles/CompileNativeLibraries.gmk ! makefiles/CreateJars.gmk - makefiles/GendataBreakIterator.gmk - makefiles/GendataFontConfig.gmk - makefiles/GendataHtml32dtd.gmk - makefiles/GendataTZDB.gmk - makefiles/GendataTimeZone.gmk - makefiles/GenerateJavaSources.gmk + makefiles/GenerateSources.gmk - makefiles/GensrcBuffer.gmk - makefiles/GensrcCLDR.gmk - makefiles/GensrcCharacterData.gmk - makefiles/GensrcCharsetCoder.gmk - makefiles/GensrcCharsetMapping.gmk - makefiles/GensrcExceptions.gmk - makefiles/GensrcIcons.gmk - makefiles/GensrcJDWP.gmk - makefiles/GensrcJObjC.gmk - makefiles/GensrcLocaleDataMetaInfo.gmk - makefiles/GensrcMisc.gmk - makefiles/GensrcProperties.gmk - makefiles/GensrcSwing.gmk - makefiles/GensrcX11Wrappers.gmk ! makefiles/Images.gmk ! makefiles/Profiles.gmk - src/share/classes/com/sun/jdi/connect/package.html - src/share/classes/com/sun/jdi/connect/spi/package.html - src/share/classes/com/sun/jdi/event/package.html - src/share/classes/com/sun/jdi/package.html - src/share/classes/com/sun/jdi/request/package.html - src/share/classes/com/sun/management/package.html - src/share/classes/com/sun/tools/attach/package.html - src/share/classes/com/sun/tools/attach/spi/package.html - src/share/classes/com/sun/tools/jconsole/package.html - src/share/classes/java/lang/invoke/InvokeGeneric.java - src/share/classes/java/lang/invoke/MagicLambdaImpl.java - src/share/classes/java/net/HttpURLPermission.java - src/share/classes/java/time/chrono/ChronoDateImpl.java ! src/share/classes/java/util/logging/LogManager.java ! src/share/classes/javax/sql/rowset/spi/SyncFactory.java ! src/share/classes/javax/swing/SwingUtilities.java ! src/share/classes/javax/swing/event/EventListenerList.java ! src/share/classes/sun/security/ssl/Handshaker.java ! src/share/classes/sun/security/tools/jarsigner/Main.java ! src/share/lib/security/java.security-macosx ! src/share/lib/security/java.security-windows - src/solaris/doc/sun/man/man1/ja/javaws.1 - src/solaris/doc/sun/man/man1/javaws.1 - test/com/oracle/security/ucrypto/TestAES.java - test/com/oracle/security/ucrypto/TestDigest.java - test/com/oracle/security/ucrypto/TestRSA.java - test/com/oracle/security/ucrypto/UcryptoTest.java ! test/java/lang/SecurityManager/CheckPackageAccess.java - test/java/net/HttpURLPermission/HttpURLPermissionTest.java - test/java/net/HttpURLPermission/URLTest.java - test/java/net/HttpURLPermission/policy.1 - test/java/net/HttpURLPermission/policy.2 - test/java/net/HttpURLPermission/policy.3 - test/java/time/tck/java/time/chrono/TCKChronologySerialization.java Changeset: 1c85f50e2622 Author: chegar Date: 2013-10-22 12:33 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1c85f50e2622 Merge ! src/share/classes/sun/reflect/generics/reflectiveObjects/TypeVariableImpl.java ! src/share/lib/security/java.security-linux ! src/share/lib/security/java.security-macosx ! src/share/lib/security/java.security-solaris ! src/share/lib/security/java.security-windows ! test/java/lang/SecurityManager/CheckPackageAccess.java Changeset: ad808fe39337 Author: weijun Date: 2013-10-17 09:58 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ad808fe39337 8025014: Enhance Security Policy 6727821: Enhance JAAS Configuration Reviewed-by: xuelei, hawtin ! src/share/classes/javax/security/auth/Policy.java ! src/share/classes/javax/security/auth/login/Configuration.java Changeset: f87d59557049 Author: chegar Date: 2013-10-22 14:55 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f87d59557049 Merge Changeset: d92379723173 Author: asaha Date: 2013-12-07 16:15 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d92379723173 Merge ! make/CompileJavaClasses.gmk ! make/CompileNativeLibraries.gmk ! make/CreateJars.gmk ! make/CreateSecurityJars.gmk ! make/GenerateSources.gmk ! make/Images.gmk ! make/Profiles.gmk ! make/lib/Awt2dLibraries.gmk ! make/lib/CoreLibraries.gmk ! make/lib/NetworkingLibraries.gmk ! make/lib/NioLibraries.gmk ! make/lib/PlatformLibraries.gmk ! make/lib/SecurityLibraries.gmk ! make/lib/ServiceabilityLibraries.gmk ! make/lib/SoundLibraries.gmk ! src/share/classes/com/sun/jmx/snmp/agent/SnmpMibGroup.java ! src/share/classes/com/sun/jmx/snmp/agent/SnmpMibTable.java ! src/share/classes/com/sun/jmx/snmp/daemon/SnmpRequestHandler.java ! src/share/classes/javax/sql/rowset/spi/SyncFactory.java ! src/share/classes/javax/swing/SwingUtilities.java ! src/share/classes/sun/reflect/misc/ReflectUtil.java ! src/share/classes/sun/security/ssl/Handshaker.java ! src/share/classes/sun/security/tools/jarsigner/Main.java ! test/sun/security/tools/jarsigner/TimestampCheck.java ! test/sun/security/tools/jarsigner/ts.sh Changeset: ef2352bf3dfe Author: xuelei Date: 2013-10-23 21:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ef2352bf3dfe 8026417: Enhance XML canonicalization Summary: Copy before use mutable byte arrays. Also reviewed by Alexander Fomin Reviewed-by: mullan, hawtin, ahgross ! src/share/classes/com/sun/org/apache/xml/internal/security/c14n/implementations/CanonicalizerBase.java Changeset: fe1707a836b4 Author: xuelei Date: 2013-10-24 10:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fe1707a836b4 8027204: Revise the update of 8026204 and 8025758 Summary: Rivise the update to use system class loader with null TCCL. Also reviewed by Alexander Fomin Reviewed-by: mchung, ahgross ! src/share/classes/com/sun/naming/internal/FactoryEnumeration.java ! src/share/classes/com/sun/naming/internal/VersionHelper12.java ! src/share/classes/javax/security/auth/login/LoginContext.java Changeset: a147b2084bc3 Author: michaelm Date: 2013-10-24 20:39 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a147b2084bc3 8011786: Better applet networking Reviewed-by: alanb, chegar ! src/share/classes/com/sun/nio/sctp/SctpChannel.java ! src/share/classes/java/lang/SecurityManager.java ! src/share/classes/java/net/Socket.java ! src/share/classes/java/net/SocketPermission.java ! src/share/classes/java/nio/channels/AsynchronousSocketChannel.java ! src/share/classes/java/nio/channels/SocketChannel.java ! src/share/classes/sun/nio/ch/AsynchronousSocketChannelImpl.java ! src/share/classes/sun/nio/ch/SocketChannelImpl.java ! src/share/classes/sun/rmi/registry/RegistryImpl.java ! src/share/classes/sun/security/util/SecurityConstants.java ! src/share/lib/security/java.policy ! src/share/lib/security/java.security-linux ! src/share/lib/security/java.security-macosx ! src/share/lib/security/java.security-solaris ! src/share/lib/security/java.security-windows ! src/solaris/classes/sun/nio/ch/sctp/SctpChannelImpl.java Changeset: a0b6e5895464 Author: michaelm Date: 2013-11-20 23:33 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a0b6e5895464 8028453: AsynchronousSocketChannel.connect() requires SocketPermission due to bind to local address (win) Reviewed-by: alanb, chegar ! src/windows/classes/sun/nio/ch/WindowsAsynchronousSocketChannelImpl.java Changeset: d5107c804de5 Author: michaelm Date: 2013-11-26 10:06 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d5107c804de5 8028293: Check local configuration for actual ephemeral port range Reviewed-by: alanb, chegar, smarks ! make/lib/NetworkingLibraries.gmk ! make/mapfiles/libnet/mapfile-vers ! src/share/classes/java/net/SocketPermission.java ! src/share/classes/sun/rmi/registry/RegistryImpl.java ! src/share/lib/security/java.security-linux ! src/share/lib/security/java.security-macosx ! src/share/lib/security/java.security-solaris ! src/share/lib/security/java.security-windows + src/solaris/classes/sun/net/PortConfig.java ! src/solaris/native/java/net/net_util_md.c ! src/solaris/native/java/net/net_util_md.h + src/solaris/native/sun/net/portconfig.c + src/windows/classes/sun/net/PortConfig.java + src/windows/native/sun/net/portconfig.c ! test/java/rmi/activation/rmidViaInheritedChannel/RmidViaInheritedChannel.java ! test/java/rmi/registry/readTest/readTest.sh ! test/java/rmi/testlibrary/TestLibrary.java Changeset: ac1c8e892877 Author: kizune Date: 2013-12-13 22:13 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ac1c8e892877 Merge ! make/CreateSecurityJars.gmk - make/data/cryptopolicy/limited/LIMITED - make/data/cryptopolicy/unlimited/UNLIMITED ! src/share/classes/java/util/logging/LogManager.java ! src/share/classes/javax/security/auth/login/LoginContext.java - test/com/sun/jmx/snmp/NoInfoLeakTest.java - test/com/sun/tools/attach/AgentSetup.sh - test/com/sun/tools/attach/ApplicationSetup.sh - test/com/sun/tools/attach/BasicTests.sh - test/com/sun/tools/attach/CommonSetup.sh - test/com/sun/tools/attach/PermissionTests.sh - test/com/sun/tools/attach/ProviderTests.sh - test/java/lang/management/MemoryMXBean/CollectionUsageThresholdConcMarkSweepGC.sh - test/java/lang/management/MemoryMXBean/CollectionUsageThresholdParallelGC.sh - test/java/lang/management/MemoryMXBean/CollectionUsageThresholdSerialGC.sh - test/java/rmi/reliability/benchmark/runRmiBench.sh - test/java/rmi/reliability/benchmark/runSerialBench.sh Changeset: db6e25fee0f7 Author: asaha Date: 2014-01-08 12:01 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/db6e25fee0f7 Merge ! make/CompileJavaClasses.gmk ! make/mapfiles/libnet/mapfile-vers ! src/macosx/native/sun/awt/splashscreen/splashscreen_sys.m ! src/share/classes/com/sun/jmx/snmp/agent/SnmpMibGroup.java ! src/share/classes/com/sun/jmx/snmp/agent/SnmpMibOid.java ! src/share/classes/com/sun/jmx/snmp/agent/SnmpMibTable.java ! src/share/classes/com/sun/jmx/snmp/daemon/SnmpRequestHandler.java ! src/share/classes/com/sun/nio/sctp/SctpChannel.java ! src/share/classes/java/lang/SecurityManager.java ! src/share/classes/java/nio/channels/AsynchronousSocketChannel.java ! src/share/classes/java/nio/channels/SocketChannel.java ! src/share/classes/java/util/jar/JarVerifier.java ! src/share/classes/javax/swing/SwingUtilities.java ! src/share/classes/javax/swing/event/EventListenerList.java ! src/share/classes/sun/nio/ch/AsynchronousSocketChannelImpl.java ! src/share/classes/sun/nio/ch/SocketChannelImpl.java ! src/share/classes/sun/security/tools/jarsigner/Main.java ! src/share/classes/sun/security/tools/jarsigner/Resources.java ! src/share/classes/sun/security/util/SecurityConstants.java - src/share/classes/sun/util/resources/pt/LocaleNames_pt_BR.properties ! src/solaris/classes/sun/nio/ch/sctp/SctpChannelImpl.java ! src/solaris/native/java/net/net_util_md.c ! src/solaris/native/sun/awt/splashscreen/splashscreen_sys.c ! src/windows/classes/sun/nio/ch/WindowsAsynchronousSocketChannelImpl.java ! test/java/rmi/registry/readTest/readTest.sh - test/javax/swing/text/AbstractDocument/7146146/bug7146146.java - test/sun/security/ssl/javax/net/ssl/SSLContextVersion.java ! test/sun/security/tools/jarsigner/TimestampCheck.java ! test/sun/security/tools/jarsigner/concise_jarsigner.sh ! test/sun/security/tools/jarsigner/ts.sh Changeset: f251cb144366 Author: erikj Date: 2014-01-08 13:25 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f251cb144366 8029254: Build error when javadoc generates beaninfo for javax.swing.beans Reviewed-by: alanb, ihse, michaelm ! make/gensrc/GensrcSwing.gmk Changeset: 13b28cffa140 Author: katleman Date: 2014-01-10 08:32 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/13b28cffa140 Added tag jdk8-b123 for changeset 484e16c0a040 ! .hgtags Changeset: e4c9787cae89 Author: asaha Date: 2014-01-10 09:11 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e4c9787cae89 Merge Changeset: a110ff64efa0 Author: kizune Date: 2014-01-14 23:10 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a110ff64efa0 Merge ! make/Images.gmk - src/bsd/doc/man/ja/kinit.1 - src/bsd/doc/man/ja/klist.1 - src/bsd/doc/man/ja/ktab.1 ! src/share/classes/java/util/logging/LogManager.java From alex.buckley at oracle.com Tue Jan 14 12:04:46 2014 From: alex.buckley at oracle.com (Alex Buckley) Date: Tue, 14 Jan 2014 12:04:46 -0800 Subject: Containing annotation type with TYPE_USE target In-Reply-To: <528EB4AB.7090704@oracle.com> References: <528EB4AB.7090704@oracle.com> Message-ID: <52D5985E.5010703@oracle.com> On 11/21/2013 5:34 PM, Alex Buckley wrote: > Here is the relevant text for JLS8 9.6.3 "Repeatable Annotation Types" > which is aware of the TYPE_USE construct from JSR 308: > > --- > T is applicable to at least the same kinds of program element as TC > (?9.6.4.1). Specifically, if the kinds of program element where T is > applicable are denoted by the set m1, and the kinds of program element > where TC is applicable are denoted by the set m2, then each kind in m2 > must occur in m1, except that: > > - If the kind in m2 is java.lang.annotation.ElementType.ANNOTATION_TYPE, > then at least > one of java.lang.annotation.ElementType.ANNOTATION_TYPE or > java.lang.annotation.ElementType.TYPE or > java.lang.annotation.ElementType.TYPE_USE must occur in m1. > > - If the kind in m2 is java.lang.annotation.ElementType.TYPE, > then at least one of java.lang.annotation.ElementType.TYPE or > java.lang.annotation.ElementType.TYPE_USE must occur in m1. > --- Joel points out that a third bullet is needed, because the type parameter context is logically included in the type use context: - If the kind in m2 is java.lang.annotation.ElementType.TYPE_PARAMETER, then at least one of java.lang.annotation.ElementType.TYPE_PARAMETER or java.lang.annotation.ElementType.TYPE_USE must occur in m1. Since the bug (JDK-8029017) targets an update release of JDK8, I will add the bullet in time for JLS8. No point delaying it until JLS9. Alex From alexander.zuev at oracle.com Tue Jan 14 11:58:03 2014 From: alexander.zuev at oracle.com (alexander.zuev at oracle.com) Date: Tue, 14 Jan 2014 19:58:03 +0000 Subject: hg: jdk8/tl/nashorn: 10 new changesets Message-ID: <20140114195813.D4DC562437@hg.openjdk.java.net> Changeset: b9fdc55a6e28 Author: chegar Date: 2013-11-03 07:33 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/b9fdc55a6e28 Merge Changeset: c1049f63d4f5 Author: kizune Date: 2013-12-03 14:13 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/c1049f63d4f5 Merge Changeset: 39a3e5a4d6d4 Author: kizune Date: 2013-12-05 16:37 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/39a3e5a4d6d4 Merge - makefiles/BuildNashorn.gmk - makefiles/Makefile Changeset: dd59e60accdd Author: kizune Date: 2013-12-13 22:13 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/dd59e60accdd Merge Changeset: 89f838ccd186 Author: asaha Date: 2013-12-20 07:44 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/89f838ccd186 Merge Changeset: a9d41a8055ca Author: asaha Date: 2014-01-02 15:31 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/a9d41a8055ca Merge Changeset: 688f4167f921 Author: katleman Date: 2014-01-03 11:55 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/688f4167f921 Added tag jdk8-b122 for changeset 9d112a0e7df7 ! .hgtags Changeset: 98e7379a4345 Author: asaha Date: 2014-01-03 16:01 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/98e7379a4345 Merge Changeset: 0b4301c79225 Author: katleman Date: 2014-01-10 08:32 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/0b4301c79225 Added tag jdk8-b123 for changeset 688f4167f921 ! .hgtags Changeset: 2334772d5292 Author: asaha Date: 2014-01-10 17:06 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/2334772d5292 Merge From alexander.zuev at oracle.com Tue Jan 14 11:57:23 2014 From: alexander.zuev at oracle.com (alexander.zuev at oracle.com) Date: Tue, 14 Jan 2014 19:57:23 +0000 Subject: hg: jdk8/tl/langtools: 9 new changesets Message-ID: <20140114195751.0CCF762435@hg.openjdk.java.net> Changeset: 53dd31d3c5d7 Author: chegar Date: 2013-11-03 07:33 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/53dd31d3c5d7 Merge Changeset: aaea3a69fa6c Author: kizune Date: 2013-12-03 14:13 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/aaea3a69fa6c Merge - test/tools/javac/ArraysInIntersections.java - test/tools/javac/ExtDirs/ext1/pkg1.jar - test/tools/javac/ExtDirs/ext2/pkg2.jar - test/tools/javac/ExtDirs/ext3/pkg1.jar - test/tools/javac/ExtDirs/ext3/pkg2.jar - test/tools/javac/InferArraysInIntersections.java - test/tools/javac/diags/examples/InterfaceOrArrayExpected.java Changeset: 48367e6de872 Author: kizune Date: 2013-12-05 16:37 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/48367e6de872 Merge - make/jprt.properties - makefiles/BuildLangtools.gmk - makefiles/Makefile Changeset: f06c0dcf251f Author: kizune Date: 2013-12-13 22:13 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f06c0dcf251f Merge Changeset: b07b8c077482 Author: asaha Date: 2013-12-20 07:44 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b07b8c077482 Merge Changeset: efc18829e3a6 Author: asaha Date: 2014-01-02 15:31 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/efc18829e3a6 Merge - src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/activetitlebar.gif - src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/activetitlebar_end.gif - src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/background.gif - src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/tab.gif - src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/titlebar.gif - src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/titlebar_end.gif Changeset: a345cf28faca Author: katleman Date: 2014-01-03 11:55 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a345cf28faca Added tag jdk8-b122 for changeset 232b9cf6303a ! .hgtags Changeset: 8712cc6441db Author: asaha Date: 2014-01-03 16:01 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8712cc6441db Merge Changeset: 1f135528db7c Author: kizune Date: 2014-01-14 23:10 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1f135528db7c Merge From joe.darcy at oracle.com Tue Jan 14 17:01:05 2014 From: joe.darcy at oracle.com (Joe Darcy) Date: Tue, 14 Jan 2014 17:01:05 -0800 Subject: JDK 9 RFR of JDK-8031745: Remove unneeded/obsolete -source/-target options in javac tests, part 1 Message-ID: <52D5DDD1.60400@oracle.com> Hello, Please review my fix for JDK-8031745 : Remove unneeded/obsolete -source/-target options in javac tests, part 1 http://cr.openjdk.java.net/~darcy/8031745.0/ This covers about half of the relevant javac test files; I'm making progress on the other half. With these changes, all langtools regression tests still pass. Full patch below. Thanks, -Joe --- old/test/tools/apt/Basics/CheckAptIsRemovedTest.java 2014-01-14 16:50:13.000000000 -0800 +++ new/test/tools/apt/Basics/CheckAptIsRemovedTest.java 2014-01-14 16:50:13.000000000 -0800 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2013, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2013, 2014, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -87,7 +87,7 @@ Path classpath = Paths.get(testJDK, "lib", "tools.jar"); ToolBox.JavaToolArgs javacArgs = new ToolBox.JavaToolArgs(ToolBox.Expect.FAIL) - .setOptions("-source", "1.5", "-sourcepath", ".", + .setOptions("-sourcepath", ".", "-classpath", classpath.toString()) .setSources(NullAPFSrc); ToolBox.javac(javacArgs); --- old/test/tools/javac/6341866/T6341866.java 2014-01-14 16:50:14.000000000 -0800 +++ new/test/tools/javac/6341866/T6341866.java 2014-01-14 16:50:13.000000000 -0800 @@ -97,7 +97,7 @@ processorServices.delete(); List opts = new ArrayList(); - opts.addAll(Arrays.asList("-d", ".", "-sourcepath", testSrc, "-classpath", testClasses, "-source", "1.6", "-Xlint:-options")); + opts.addAll(Arrays.asList("-d", ".", "-sourcepath", testSrc, "-classpath", testClasses, "-Xlint:-options")); if (implicitType.opt != null) opts.add(implicitType.opt); --- old/test/tools/javac/ClassFileModifiers/MemberModifiers.java 2014-01-14 16:50:14.000000000 -0800 +++ new/test/tools/javac/ClassFileModifiers/MemberModifiers.java 2014-01-14 16:50:14.000000000 -0800 @@ -26,7 +26,7 @@ * @bug 4249112 4785453 * @summary Verify that implicit member modifiers are set correctly. * - * @compile/ref=MemberModifiers.out -source 1.4 -target 1.5 -Xlint:-options -XDdumpmodifiers=cfm MemberModifiers.java + * @compile/ref=MemberModifiers.out -XDdumpmodifiers=cfm MemberModifiers.java */ // Currently, we check only that members of final classes are not final. --- old/test/tools/javac/ConditionalArgTypes_1.java 2014-01-14 16:50:14.000000000 -0800 +++ new/test/tools/javac/ConditionalArgTypes_1.java 2014-01-14 16:50:14.000000000 -0800 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2000, 2003, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2000, 2014, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -27,7 +27,6 @@ * @summary Verify that both branches of a conditional expression must agree in type. * @author maddox * - * @compile/fail -source 1.4 ConditionalArgTypes_1.java * @compile ConditionalArgTypes_1.java */ --- old/test/tools/javac/T6394563.java 2014-01-14 16:50:15.000000000 -0800 +++ new/test/tools/javac/T6394563.java 2014-01-14 16:50:15.000000000 -0800 @@ -4,12 +4,7 @@ * @summary javac ignores -nowarn switch in 1.5.0_06 for deprecation warnings * * @compile/ref=T6394563.note.out -XDrawDiagnostics -nowarn T6394563.java - * @compile/ref=T6394563.note.out -XDrawDiagnostics -nowarn -source 1.5 T6394563.java - * @compile/ref=T6394563.empty.out -XDrawDiagnostics -nowarn -source 1.4 T6394563.java - * - * @compile/ref=T6394563.warn.out -XDrawDiagnostics -Xlint -nowarn T6394563.java - * @compile/ref=T6394563.warn.out -XDrawDiagnostics -Xlint -nowarn -source 1.5 T6394563.java - * @compile/ref=T6394563.empty.out -XDrawDiagnostics -Xlint -nowarn -source 1.4 T6394563.java + * @compile/ref=T6394563.warn.out -XDrawDiagnostics -Xlint -nowarn T6394563.java */ class T6394563 { --- old/test/tools/javac/T6394563.warn.out 2014-01-14 16:50:15.000000000 -0800 +++ new/test/tools/javac/T6394563.warn.out 2014-01-14 16:50:15.000000000 -0800 @@ -1,2 +1,2 @@ -T6394563.java:17:19: compiler.warn.has.been.deprecated: foo(), deprecated +T6394563.java:12:19: compiler.warn.has.been.deprecated: foo(), deprecated 1 warning --- old/test/tools/javac/api/T6306137.java 2014-01-14 16:50:15.000000000 -0800 +++ new/test/tools/javac/api/T6306137.java 2014-01-14 16:50:15.000000000 -0800 @@ -76,7 +76,7 @@ } void test(String encoding, boolean good) { error = false; - Iterable args = Arrays.asList("-source", "6", "-encoding", encoding, "-d", "."); + Iterable args = Arrays.asList("-encoding", encoding, "-d", "."); compiler.getTask(null, fm, dl, args, null, files).call(); if (error == good) { if (error) { --- old/test/tools/javac/api/TestGetElementReference.java 2014-01-14 16:50:16.000000000 -0800 +++ new/test/tools/javac/api/TestGetElementReference.java 2014-01-14 16:50:16.000000000 -0800 @@ -52,7 +52,7 @@ File source = new File(System.getProperty("test.src", "."), "TestGetElementReferenceData.java").getAbsoluteFile(); StandardJavaFileManager fm = ToolProvider.getSystemJavaCompiler().getStandardFileManager(null, null, null); DiagnosticCollector diagnostics = new DiagnosticCollector<>(); - JavacTask ct = (JavacTask) ToolProvider.getSystemJavaCompiler().getTask(null, null, diagnostics, Arrays.asList("-Xjcov", "-source", "1.8"), null, fm.getJavaFileObjects(source)); + JavacTask ct = (JavacTask) ToolProvider.getSystemJavaCompiler().getTask(null, null, diagnostics, Arrays.asList("-Xjcov"), null, fm.getJavaFileObjects(source)); Trees trees = Trees.instance(ct); CompilationUnitTree cut = ct.parse().iterator().next(); --- old/test/tools/javac/lambda/ByteCodeTest.java 2014-01-14 16:50:17.000000000 -0800 +++ new/test/tools/javac/lambda/ByteCodeTest.java 2014-01-14 16:50:17.000000000 -0800 @@ -122,7 +122,7 @@ static File compile(File f) { int rc = com.sun.tools.javac.Main.compile(new String[] { - "-source", "1.8", "-g", f.getPath() }); + "-g", f.getPath() }); if (rc != 0) throw new Error("compilation failed. rc=" + rc); String path = f.getPath(); --- old/test/tools/javac/processing/environment/TestSourceVersion.java 2014-01-14 16:50:17.000000000 -0800 +++ new/test/tools/javac/processing/environment/TestSourceVersion.java 2014-01-14 16:50:17.000000000 -0800 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2006, 2010, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2006, 2014, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -23,21 +23,20 @@ /* * @test - * @bug 6402506 + * @bug 6402506 8028545 8028543 * @summary Test that getSourceVersion works properly * @author Joseph D. Darcy * @library /tools/javac/lib * @build JavacTestingAbstractProcessor * @compile TestSourceVersion.java - * @compile -processor TestSourceVersion -proc:only -source 1.2 -AExpectedVersion=RELEASE_2 HelloWorld.java - * @compile -processor TestSourceVersion -proc:only -source 1.3 -AExpectedVersion=RELEASE_3 HelloWorld.java - * @compile -processor TestSourceVersion -proc:only -source 1.4 -AExpectedVersion=RELEASE_4 HelloWorld.java - * @compile -processor TestSourceVersion -proc:only -source 1.5 -AExpectedVersion=RELEASE_5 HelloWorld.java - * @compile -processor TestSourceVersion -proc:only -source 5 -AExpectedVersion=RELEASE_5 HelloWorld.java * @compile -processor TestSourceVersion -proc:only -source 1.6 -AExpectedVersion=RELEASE_6 HelloWorld.java * @compile -processor TestSourceVersion -proc:only -source 6 -AExpectedVersion=RELEASE_6 HelloWorld.java * @compile -processor TestSourceVersion -proc:only -source 1.7 -AExpectedVersion=RELEASE_7 HelloWorld.java * @compile -processor TestSourceVersion -proc:only -source 7 -AExpectedVersion=RELEASE_7 HelloWorld.java + * @compile -processor TestSourceVersion -proc:only -source 1.8 -AExpectedVersion=RELEASE_8 HelloWorld.java + * @compile -processor TestSourceVersion -proc:only -source 8 -AExpectedVersion=RELEASE_8 HelloWorld.java + * @compile -processor TestSourceVersion -proc:only -source 1.9 -AExpectedVersion=RELEASE_9 HelloWorld.java + * @compile -processor TestSourceVersion -proc:only -source 9 -AExpectedVersion=RELEASE_9 HelloWorld.java */ import java.util.Set; --- old/test/tools/javac/processing/warnings/TestSourceVersionWarnings.java 2014-01-14 16:50:17.000000000 -0800 +++ new/test/tools/javac/processing/warnings/TestSourceVersionWarnings.java 2014-01-14 16:50:17.000000000 -0800 @@ -27,11 +27,7 @@ * @summary Test that warnings about source versions are output as expected. * @author Joseph D. Darcy * @compile TestSourceVersionWarnings.java - * @compile/ref=gold_0.out -XDrawDiagnostics -processor TestSourceVersionWarnings -proc:only -source 1.5 -Xlint:-options HelloWorld.java - * @compile/ref=gold_sv_warn_0_2.out -XDrawDiagnostics -processor TestSourceVersionWarnings -proc:only -ASourceVersion=RELEASE_0 -source 1.2 -Xlint:-options HelloWorld.java - * @compile/ref=gold_sv_none.out -XDrawDiagnostics -processor TestSourceVersionWarnings -proc:only -ASourceVersion=RELEASE_2 -source 1.2 -Xlint:-options HelloWorld.java - * @compile/ref=gold_sv_warn_2_3.out -XDrawDiagnostics -processor TestSourceVersionWarnings -proc:only -ASourceVersion=RELEASE_2 -source 1.3 -Xlint:-options HelloWorld.java - * @compile/ref=gold_sv_none.out -XDrawDiagnostics -processor TestSourceVersionWarnings -proc:only -ASourceVersion=RELEASE_5 -source 1.5 -Xlint:-options HelloWorld.java + * @compile/ref=gold_0.out -XDrawDiagnostics -processor TestSourceVersionWarnings -proc:only -source 1.6 -Xlint:-options HelloWorld.java * @compile/ref=gold_sv_warn_5_6.out -XDrawDiagnostics -processor TestSourceVersionWarnings -proc:only -ASourceVersion=RELEASE_5 -source 1.6 -Xlint:-options HelloWorld.java * @compile/ref=gold_sv_none.out -XDrawDiagnostics -processor TestSourceVersionWarnings -proc:only -ASourceVersion=RELEASE_6 -source 1.6 -Xlint:-options HelloWorld.java * @compile/ref=gold_unsp_warn.out -XDrawDiagnostics -processor TestSourceVersionWarnings -proc:only -ASourceVersion=RELEASE_6 -source 1.6 -Xlint:-options -Aunsupported HelloWorld.java --- old/test/tools/javac/stackmap/StackMapTest.java 2014-01-14 16:50:18.000000000 -0800 +++ new/test/tools/javac/stackmap/StackMapTest.java 2014-01-14 16:50:18.000000000 -0800 @@ -27,7 +27,7 @@ * @summary The "method0" StackMap attribute should have two entries instead of three * @library /tools/javac/lib * @build ToolBox - * @run compile -source 6 -target 6 StackMapTest.java + * @run compile StackMapTest.java * @run main StackMapTest */ @@ -48,7 +48,7 @@ } public static void main(String args[]) throws Exception { -// "${TESTJAVA}${FS}bin${FS}javac" ${TESTTOOLVMOPTS} -source 6 -target 6 T4955930.java +// "${TESTJAVA}${FS}bin${FS}javac" ${TESTTOOLVMOPTS} T4955930.java // "${TESTJAVA}${FS}bin${FS}javap" ${TESTTOOLVMOPTS} -verbose T4955930 > ${TMP1} Path pathToClass = Paths.get(System.getProperty("test.classes"), --- old/test/tools/javac/unicode/Unmappable.java 2014-01-14 16:50:18.000000000 -0800 +++ new/test/tools/javac/unicode/Unmappable.java 2014-01-14 16:50:18.000000000 -0800 @@ -27,8 +27,6 @@ * @summary diagnose encoding errors in Java source files * @author gafter * - * @compile -encoding ascii -source 1.5 Unmappable.java - * @compile/fail -Werror -encoding ascii -source 1.5 Unmappable.java * @compile/fail -encoding ascii Unmappable.java */ --- old/test/tools/javap/output/Tester.java 2014-01-14 16:50:19.000000000 -0800 +++ new/test/tools/javap/output/Tester.java 2014-01-14 16:50:19.000000000 -0800 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2013, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2013, 2014, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -271,7 +271,7 @@ */ protected void compileTestFile() { String path = javaFile.getPath(); - String params[] = { "-source", "1.8", "-g", path }; + String params[] = {"-g", path }; int rc = com.sun.tools.javac.Main.compile(params); if (rc != 0) throw new Error("compilation failed. rc=" + rc); --- old/test/tools/javap/typeAnnotations/JSR175Annotations.java 2014-01-14 16:50:19.000000000 -0800 +++ new/test/tools/javap/typeAnnotations/JSR175Annotations.java 2014-01-14 16:50:19.000000000 -0800 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2008, 2013, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2008, 2014, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -114,7 +114,7 @@ } File compileTestFile(File f) { - int rc = com.sun.tools.javac.Main.compile(new String[] { "-source", "1.8", "-g", f.getPath() }); + int rc = com.sun.tools.javac.Main.compile(new String[] {"-g", f.getPath() }); if (rc != 0) throw new Error("compilation failed. rc=" + rc); String path = f.getPath(); --- old/test/tools/javap/typeAnnotations/NewArray.java 2014-01-14 16:50:19.000000000 -0800 +++ new/test/tools/javap/typeAnnotations/NewArray.java 2014-01-14 16:50:19.000000000 -0800 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2008, 2013, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2008, 2014, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -102,7 +102,7 @@ } File compileTestFile(File f) { - int rc = com.sun.tools.javac.Main.compile(new String[] { "-source", "1.8", "-g", f.getPath() }); + int rc = com.sun.tools.javac.Main.compile(new String[] {"-g", f.getPath() }); if (rc != 0) throw new Error("compilation failed. rc=" + rc); String path = f.getPath(); --- old/test/tools/javap/typeAnnotations/Presence.java 2014-01-14 16:50:20.000000000 -0800 +++ new/test/tools/javap/typeAnnotations/Presence.java 2014-01-14 16:50:20.000000000 -0800 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2008, 2013, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2008, 2014, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -180,7 +180,7 @@ } File compileTestFile(File f) { - int rc = com.sun.tools.javac.Main.compile(new String[] { "-source", "1.8", "-g", f.getPath() }); + int rc = com.sun.tools.javac.Main.compile(new String[] {"-g", f.getPath() }); if (rc != 0) throw new Error("compilation failed. rc=" + rc); String path = f.getPath(); --- old/test/tools/javap/typeAnnotations/PresenceInner.java 2014-01-14 16:50:20.000000000 -0800 +++ new/test/tools/javap/typeAnnotations/PresenceInner.java 2014-01-14 16:50:20.000000000 -0800 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2009, 2013, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2009, 2014, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -149,7 +149,7 @@ } File compileTestFile(File f) { - int rc = com.sun.tools.javac.Main.compile(new String[] { "-source", "1.8", "-g", f.getPath() }); + int rc = com.sun.tools.javac.Main.compile(new String[] {"-g", f.getPath() }); if (rc != 0) throw new Error("compilation failed. rc=" + rc); String path = f.getPath(); --- old/test/tools/javap/typeAnnotations/TypeCasts.java 2014-01-14 16:50:20.000000000 -0800 +++ new/test/tools/javap/typeAnnotations/TypeCasts.java 2014-01-14 16:50:20.000000000 -0800 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2009, 2013, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2009, 2014, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -117,7 +117,7 @@ } File compileTestFile(File f) { - int rc = com.sun.tools.javac.Main.compile(new String[] { "-source", "1.8", "-g", f.getPath() }); + int rc = com.sun.tools.javac.Main.compile(new String[] {"-g", f.getPath() }); if (rc != 0) throw new Error("compilation failed. rc=" + rc); String path = f.getPath(); --- old/test/tools/javap/typeAnnotations/Visibility.java 2014-01-14 16:50:21.000000000 -0800 +++ new/test/tools/javap/typeAnnotations/Visibility.java 2014-01-14 16:50:21.000000000 -0800 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2008, 2013, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2008, 2014, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -108,7 +108,7 @@ } File compileTestFile(File f) { - int rc = com.sun.tools.javac.Main.compile(new String[] { "-source", "1.8", "-g", f.getPath() }); + int rc = com.sun.tools.javac.Main.compile(new String[] {"-g", f.getPath() }); if (rc != 0) throw new Error("compilation failed. rc=" + rc); String path = f.getPath(); --- old/test/tools/javap/typeAnnotations/Wildcards.java 2014-01-14 16:50:22.000000000 -0800 +++ new/test/tools/javap/typeAnnotations/Wildcards.java 2014-01-14 16:50:22.000000000 -0800 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2009, 2013, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2009, 2014, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -139,7 +139,7 @@ } File compileTestFile(File f) { - int rc = com.sun.tools.javac.Main.compile(new String[] { "-source", "1.8", "-g", f.getPath() }); + int rc = com.sun.tools.javac.Main.compile(new String[] {"-g", f.getPath() }); if (rc != 0) throw new Error("compilation failed. rc=" + rc); String path = f.getPath(); --- old/test/tools/javac/Capture.java 2014-01-14 16:50:22.000000000 -0800 +++ /dev/null 2014-01-13 10:19:39.230183767 -0800 @@ -1,46 +0,0 @@ -/* - * Copyright (c) 2002, 2004, Oracle and/or its affiliates. All rights reserved. - * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. - * - * This code is free software; you can redistribute it and/or modify it - * under the terms of the GNU General Public License version 2 only, as - * published by the Free Software Foundation. - * - * This code is distributed in the hope that it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License - * version 2 for more details (a copy is included in the LICENSE file that - * accompanied this code). - * - * You should have received a copy of the GNU General Public License version - * 2 along with this work; if not, write to the Free Software Foundation, - * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. - * - * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA - * or visit www.oracle.com if you need additional information or have any - * questions. - */ - -/* - * @test - * @bug 4441338 4994508 - * @summary Captured variable synthetic parameters should be passed before explicit params. - * @author gafter - * - * @compile -source 1.4 -target 1.4 Capture.java - * @run main Capture - */ - -public class Capture { - final int k; - Capture(int n) { - k = n; - } - public static void main(String args[]) { - final int j; - int k1 = new Capture(2 + (j=3)){ - int get () {return k+j;} - }.get(); - if (k1 != 8) throw new Error("k1 = " + k1); - } -} --- old/test/tools/javac/Source5.java 2014-01-14 16:50:23.000000000 -0800 +++ /dev/null 2014-01-13 10:19:39.230183767 -0800 @@ -1,39 +0,0 @@ -/* - * Copyright (c) 2004, Oracle and/or its affiliates. All rights reserved. - * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. - * - * This code is free software; you can redistribute it and/or modify it - * under the terms of the GNU General Public License version 2 only, as - * published by the Free Software Foundation. - * - * This code is distributed in the hope that it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License - * version 2 for more details (a copy is included in the LICENSE file that - * accompanied this code). - * - * You should have received a copy of the GNU General Public License version - * 2 along with this work; if not, write to the Free Software Foundation, - * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. - * - * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA - * or visit www.oracle.com if you need additional information or have any - * questions. - */ - -/* - * @test - * @bug 5044157 - * @summary please accept -source 5 and -target 5 - * @author Peter von der Ah? - * - * @compile -source 5 -target 5 -encoding iso-8859-1 Source5.java - * @run main Source5 - */ - -public enum Source5 { - JDK5; - public static void main(String[] args) { - System.out.println("Hello, world!"); - } -} --- old/test/tools/javac/processing/warnings/gold_sv_warn_0_2.out 2014-01-14 16:50:23.000000000 -0800 +++ /dev/null 2014-01-13 10:19:39.230183767 -0800 @@ -1,2 +0,0 @@ -- compiler.warn.proc.processor.incompatible.source.version: RELEASE_0, TestSourceVersionWarnings, 1.2 -1 warning --- old/test/tools/javac/processing/warnings/gold_sv_warn_2_3.out 2014-01-14 16:50:23.000000000 -0800 +++ /dev/null 2014-01-13 10:19:39.230183767 -0800 @@ -1,2 +0,0 @@ -- compiler.warn.proc.processor.incompatible.source.version: RELEASE_2, TestSourceVersionWarnings, 1.3 -1 warning --- old/test/tools/javac/varargs/warning/Warn1.java 2014-01-14 16:50:23.000000000 -0800 +++ /dev/null 2014-01-13 10:19:39.230183767 -0800 @@ -1,42 +0,0 @@ -/* - * Copyright (c) 2004, 2010, Oracle and/or its affiliates. All rights reserved. - * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. - * - * This code is free software; you can redistribute it and/or modify it - * under the terms of the GNU General Public License version 2 only, as - * published by the Free Software Foundation. - * - * This code is distributed in the hope that it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License - * version 2 for more details (a copy is included in the LICENSE file that - * accompanied this code). - * - * You should have received a copy of the GNU General Public License version - * 2 along with this work; if not, write to the Free Software Foundation, - * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. - * - * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA - * or visit www.oracle.com if you need additional information or have any - * questions. - */ - -/* - * @test - * @bug 5035307 - * @summary fixed-arity warning given too often - * @author gafter - * - * @compile -Werror -source 1.4 -Xlint:-options Warn1.java - */ - -package varargs.warning.warn1; - -import java.util.List; -import java.util.Arrays; - -class Warn1 { - void f(String[] args) { - List l = java.util.Arrays.asList(args); - } -} From eric.mccorkle at oracle.com Wed Jan 15 09:47:32 2014 From: eric.mccorkle at oracle.com (eric.mccorkle at oracle.com) Date: Wed, 15 Jan 2014 17:47:32 +0000 Subject: hg: jdk8/tl/jdk: 8031502: JSR292: IncompatibleClassChangeError in LambdaForm for CharSequence.toString() method handle type converter Message-ID: <20140115174752.A89E762486@hg.openjdk.java.net> Changeset: 9e91793fd516 Author: vlivanov Date: 2014-01-15 20:48 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9e91793fd516 8031502: JSR292: IncompatibleClassChangeError in LambdaForm for CharSequence.toString() method handle type converter Reviewed-by: sundar, lagergren, drchase ! src/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java + test/java/lang/invoke/ObjectMethodInInterfaceTest.java From joe.darcy at oracle.com Wed Jan 15 20:49:37 2014 From: joe.darcy at oracle.com (Joe Darcy) Date: Wed, 15 Jan 2014 20:49:37 -0800 Subject: JDK 9 RFR of JDK-8031745: Remove unneeded/obsolete -source/-target options in javac tests, part 1 In-Reply-To: <52D5DDD1.60400@oracle.com> References: <52D5DDD1.60400@oracle.com> Message-ID: <52D764E1.5010003@oracle.com> PS To provide a little more context around this, our overall policy is now to retire sufficiently old -source and -target options: Policy for Retiring javac -source and -target Options http://openjdk.java.net/jeps/182 In JDK 9, source/target options {6/1.6, 7/1.7, 8/1.8, 9/1.9} will be supported. One of the benefits is allowing simplifications in javac. The types used for source and target modeling in javac define a number of predicates, "allowFoo", whose contents tend to be one-line version checks "return version >= VERSION_INTRODUCING_FEATURE;". A trivial way to implement the predicates is to make them unconditionally return true or false, as appropriate, after the old source/target values are dropped. However, it is of course more interesting if these newly-constant results get constant propagated into the javac code base so that now effectively-dead code in javac can be deleted. We had a little of this effect in JDK 8 when several never-documented targets were removed: JDK-8010179: Remove transitional target values from javac http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a4913ea9bb62 However, the code deletion in javac can be expected to be much bigger when generics can assumed to be present. As a secondary effect, some messages reported by the compiler will no longer be reported so there will be fewer messages to localize and maintain. Comments? Thanks, -Joe On 1/14/2014 5:01 PM, Joe Darcy wrote: > Hello, > > Please review my fix for > > JDK-8031745 : Remove unneeded/obsolete -source/-target options in > javac tests, part 1 > http://cr.openjdk.java.net/~darcy/8031745.0/ > > This covers about half of the relevant javac test files; I'm making > progress on the other half. With these changes, all langtools > regression tests still pass. > > Full patch below. > > Thanks, > > -Joe > > --- old/test/tools/apt/Basics/CheckAptIsRemovedTest.java 2014-01-14 > 16:50:13.000000000 -0800 > +++ new/test/tools/apt/Basics/CheckAptIsRemovedTest.java 2014-01-14 > 16:50:13.000000000 -0800 > @@ -1,5 +1,5 @@ > /* > - * Copyright (c) 2013, Oracle and/or its affiliates. All rights > reserved. > + * Copyright (c) 2013, 2014, Oracle and/or its affiliates. All rights > reserved. > * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > * > * This code is free software; you can redistribute it and/or modify it > @@ -87,7 +87,7 @@ > Path classpath = Paths.get(testJDK, "lib", "tools.jar"); > ToolBox.JavaToolArgs javacArgs = > new ToolBox.JavaToolArgs(ToolBox.Expect.FAIL) > - .setOptions("-source", "1.5", "-sourcepath", ".", > + .setOptions("-sourcepath", ".", > "-classpath", classpath.toString()) > .setSources(NullAPFSrc); > ToolBox.javac(javacArgs); > --- old/test/tools/javac/6341866/T6341866.java 2014-01-14 > 16:50:14.000000000 -0800 > +++ new/test/tools/javac/6341866/T6341866.java 2014-01-14 > 16:50:13.000000000 -0800 > @@ -97,7 +97,7 @@ > processorServices.delete(); > > List opts = new ArrayList(); > - opts.addAll(Arrays.asList("-d", ".", "-sourcepath", testSrc, > "-classpath", testClasses, "-source", "1.6", "-Xlint:-options")); > + opts.addAll(Arrays.asList("-d", ".", "-sourcepath", testSrc, > "-classpath", testClasses, "-Xlint:-options")); > if (implicitType.opt != null) > opts.add(implicitType.opt); > > --- old/test/tools/javac/ClassFileModifiers/MemberModifiers.java > 2014-01-14 16:50:14.000000000 -0800 > +++ new/test/tools/javac/ClassFileModifiers/MemberModifiers.java > 2014-01-14 16:50:14.000000000 -0800 > @@ -26,7 +26,7 @@ > * @bug 4249112 4785453 > * @summary Verify that implicit member modifiers are set correctly. > * > - * @compile/ref=MemberModifiers.out -source 1.4 -target 1.5 > -Xlint:-options -XDdumpmodifiers=cfm MemberModifiers.java > + * @compile/ref=MemberModifiers.out -XDdumpmodifiers=cfm > MemberModifiers.java > */ > > // Currently, we check only that members of final classes are not final. > --- old/test/tools/javac/ConditionalArgTypes_1.java 2014-01-14 > 16:50:14.000000000 -0800 > +++ new/test/tools/javac/ConditionalArgTypes_1.java 2014-01-14 > 16:50:14.000000000 -0800 > @@ -1,5 +1,5 @@ > /* > - * Copyright (c) 2000, 2003, Oracle and/or its affiliates. All rights > reserved. > + * Copyright (c) 2000, 2014, Oracle and/or its affiliates. All rights > reserved. > * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > * > * This code is free software; you can redistribute it and/or modify it > @@ -27,7 +27,6 @@ > * @summary Verify that both branches of a conditional expression > must agree in type. > * @author maddox > * > - * @compile/fail -source 1.4 ConditionalArgTypes_1.java > * @compile ConditionalArgTypes_1.java > */ > > --- old/test/tools/javac/T6394563.java 2014-01-14 > 16:50:15.000000000 -0800 > +++ new/test/tools/javac/T6394563.java 2014-01-14 > 16:50:15.000000000 -0800 > @@ -4,12 +4,7 @@ > * @summary javac ignores -nowarn switch in 1.5.0_06 for deprecation > warnings > * > * @compile/ref=T6394563.note.out -XDrawDiagnostics > -nowarn T6394563.java > - * @compile/ref=T6394563.note.out -XDrawDiagnostics -nowarn -source > 1.5 T6394563.java > - * @compile/ref=T6394563.empty.out -XDrawDiagnostics -nowarn -source > 1.4 T6394563.java > - * > - * @compile/ref=T6394563.warn.out -XDrawDiagnostics -Xlint > -nowarn T6394563.java > - * @compile/ref=T6394563.warn.out -XDrawDiagnostics -Xlint -nowarn > -source 1.5 T6394563.java > - * @compile/ref=T6394563.empty.out -XDrawDiagnostics -Xlint -nowarn > -source 1.4 T6394563.java > + * @compile/ref=T6394563.warn.out -XDrawDiagnostics -Xlint > -nowarn T6394563.java > */ > > class T6394563 { > --- old/test/tools/javac/T6394563.warn.out 2014-01-14 > 16:50:15.000000000 -0800 > +++ new/test/tools/javac/T6394563.warn.out 2014-01-14 > 16:50:15.000000000 -0800 > @@ -1,2 +1,2 @@ > -T6394563.java:17:19: compiler.warn.has.been.deprecated: foo(), > deprecated > +T6394563.java:12:19: compiler.warn.has.been.deprecated: foo(), > deprecated > 1 warning > --- old/test/tools/javac/api/T6306137.java 2014-01-14 > 16:50:15.000000000 -0800 > +++ new/test/tools/javac/api/T6306137.java 2014-01-14 > 16:50:15.000000000 -0800 > @@ -76,7 +76,7 @@ > } > void test(String encoding, boolean good) { > error = false; > - Iterable args = Arrays.asList("-source", "6", > "-encoding", encoding, "-d", "."); > + Iterable args = Arrays.asList("-encoding", encoding, > "-d", "."); > compiler.getTask(null, fm, dl, args, null, files).call(); > if (error == good) { > if (error) { > --- old/test/tools/javac/api/TestGetElementReference.java 2014-01-14 > 16:50:16.000000000 -0800 > +++ new/test/tools/javac/api/TestGetElementReference.java 2014-01-14 > 16:50:16.000000000 -0800 > @@ -52,7 +52,7 @@ > File source = new File(System.getProperty("test.src", "."), > "TestGetElementReferenceData.java").getAbsoluteFile(); > StandardJavaFileManager fm = > ToolProvider.getSystemJavaCompiler().getStandardFileManager(null, > null, null); > DiagnosticCollector diagnostics = new > DiagnosticCollector<>(); > - JavacTask ct = (JavacTask) > ToolProvider.getSystemJavaCompiler().getTask(null, null, diagnostics, > Arrays.asList("-Xjcov", "-source", "1.8"), null, > fm.getJavaFileObjects(source)); > + JavacTask ct = (JavacTask) > ToolProvider.getSystemJavaCompiler().getTask(null, null, diagnostics, > Arrays.asList("-Xjcov"), null, fm.getJavaFileObjects(source)); > Trees trees = Trees.instance(ct); > CompilationUnitTree cut = ct.parse().iterator().next(); > > --- old/test/tools/javac/lambda/ByteCodeTest.java 2014-01-14 > 16:50:17.000000000 -0800 > +++ new/test/tools/javac/lambda/ByteCodeTest.java 2014-01-14 > 16:50:17.000000000 -0800 > @@ -122,7 +122,7 @@ > > static File compile(File f) { > int rc = com.sun.tools.javac.Main.compile(new String[] { > - "-source", "1.8", "-g", f.getPath() }); > + "-g", f.getPath() }); > if (rc != 0) > throw new Error("compilation failed. rc=" + rc); > String path = f.getPath(); > --- old/test/tools/javac/processing/environment/TestSourceVersion.java > 2014-01-14 16:50:17.000000000 -0800 > +++ new/test/tools/javac/processing/environment/TestSourceVersion.java > 2014-01-14 16:50:17.000000000 -0800 > @@ -1,5 +1,5 @@ > /* > - * Copyright (c) 2006, 2010, Oracle and/or its affiliates. All rights > reserved. > + * Copyright (c) 2006, 2014, Oracle and/or its affiliates. All rights > reserved. > * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > * > * This code is free software; you can redistribute it and/or modify it > @@ -23,21 +23,20 @@ > > /* > * @test > - * @bug 6402506 > + * @bug 6402506 8028545 8028543 > * @summary Test that getSourceVersion works properly > * @author Joseph D. Darcy > * @library /tools/javac/lib > * @build JavacTestingAbstractProcessor > * @compile TestSourceVersion.java > - * @compile -processor TestSourceVersion -proc:only -source 1.2 > -AExpectedVersion=RELEASE_2 HelloWorld.java > - * @compile -processor TestSourceVersion -proc:only -source 1.3 > -AExpectedVersion=RELEASE_3 HelloWorld.java > - * @compile -processor TestSourceVersion -proc:only -source 1.4 > -AExpectedVersion=RELEASE_4 HelloWorld.java > - * @compile -processor TestSourceVersion -proc:only -source 1.5 > -AExpectedVersion=RELEASE_5 HelloWorld.java > - * @compile -processor TestSourceVersion -proc:only -source 5 > -AExpectedVersion=RELEASE_5 HelloWorld.java > * @compile -processor TestSourceVersion -proc:only -source 1.6 > -AExpectedVersion=RELEASE_6 HelloWorld.java > * @compile -processor TestSourceVersion -proc:only -source 6 > -AExpectedVersion=RELEASE_6 HelloWorld.java > * @compile -processor TestSourceVersion -proc:only -source 1.7 > -AExpectedVersion=RELEASE_7 HelloWorld.java > * @compile -processor TestSourceVersion -proc:only -source 7 > -AExpectedVersion=RELEASE_7 HelloWorld.java > + * @compile -processor TestSourceVersion -proc:only -source 1.8 > -AExpectedVersion=RELEASE_8 HelloWorld.java > + * @compile -processor TestSourceVersion -proc:only -source 8 > -AExpectedVersion=RELEASE_8 HelloWorld.java > + * @compile -processor TestSourceVersion -proc:only -source 1.9 > -AExpectedVersion=RELEASE_9 HelloWorld.java > + * @compile -processor TestSourceVersion -proc:only -source 9 > -AExpectedVersion=RELEASE_9 HelloWorld.java > */ > > import java.util.Set; > --- > old/test/tools/javac/processing/warnings/TestSourceVersionWarnings.java 2014-01-14 > 16:50:17.000000000 -0800 > +++ > new/test/tools/javac/processing/warnings/TestSourceVersionWarnings.java 2014-01-14 > 16:50:17.000000000 -0800 > @@ -27,11 +27,7 @@ > * @summary Test that warnings about source versions are output as > expected. > * @author Joseph D. Darcy > * @compile TestSourceVersionWarnings.java > - * @compile/ref=gold_0.out -XDrawDiagnostics -processor > TestSourceVersionWarnings -proc:only -source 1.5 -Xlint:-options > HelloWorld.java > - * @compile/ref=gold_sv_warn_0_2.out -XDrawDiagnostics -processor > TestSourceVersionWarnings -proc:only -ASourceVersion=RELEASE_0 -source > 1.2 -Xlint:-options HelloWorld.java > - * @compile/ref=gold_sv_none.out -XDrawDiagnostics -processor > TestSourceVersionWarnings -proc:only -ASourceVersion=RELEASE_2 -source > 1.2 -Xlint:-options HelloWorld.java > - * @compile/ref=gold_sv_warn_2_3.out -XDrawDiagnostics -processor > TestSourceVersionWarnings -proc:only -ASourceVersion=RELEASE_2 -source > 1.3 -Xlint:-options HelloWorld.java > - * @compile/ref=gold_sv_none.out -XDrawDiagnostics -processor > TestSourceVersionWarnings -proc:only -ASourceVersion=RELEASE_5 -source > 1.5 -Xlint:-options HelloWorld.java > + * @compile/ref=gold_0.out -XDrawDiagnostics -processor > TestSourceVersionWarnings -proc:only -source 1.6 -Xlint:-options > HelloWorld.java > * @compile/ref=gold_sv_warn_5_6.out -XDrawDiagnostics -processor > TestSourceVersionWarnings -proc:only -ASourceVersion=RELEASE_5 -source > 1.6 -Xlint:-options HelloWorld.java > * @compile/ref=gold_sv_none.out -XDrawDiagnostics -processor > TestSourceVersionWarnings -proc:only -ASourceVersion=RELEASE_6 -source > 1.6 -Xlint:-options HelloWorld.java > * @compile/ref=gold_unsp_warn.out -XDrawDiagnostics -processor > TestSourceVersionWarnings -proc:only -ASourceVersion=RELEASE_6 -source > 1.6 -Xlint:-options -Aunsupported HelloWorld.java > --- old/test/tools/javac/stackmap/StackMapTest.java 2014-01-14 > 16:50:18.000000000 -0800 > +++ new/test/tools/javac/stackmap/StackMapTest.java 2014-01-14 > 16:50:18.000000000 -0800 > @@ -27,7 +27,7 @@ > * @summary The "method0" StackMap attribute should have two entries > instead of three > * @library /tools/javac/lib > * @build ToolBox > - * @run compile -source 6 -target 6 StackMapTest.java > + * @run compile StackMapTest.java > * @run main StackMapTest > */ > > @@ -48,7 +48,7 @@ > } > > public static void main(String args[]) throws Exception { > -// "${TESTJAVA}${FS}bin${FS}javac" ${TESTTOOLVMOPTS} -source 6 > -target 6 T4955930.java > +// "${TESTJAVA}${FS}bin${FS}javac" ${TESTTOOLVMOPTS} T4955930.java > > // "${TESTJAVA}${FS}bin${FS}javap" ${TESTTOOLVMOPTS} -verbose > T4955930 > ${TMP1} > Path pathToClass = Paths.get(System.getProperty("test.classes"), > --- old/test/tools/javac/unicode/Unmappable.java 2014-01-14 > 16:50:18.000000000 -0800 > +++ new/test/tools/javac/unicode/Unmappable.java 2014-01-14 > 16:50:18.000000000 -0800 > @@ -27,8 +27,6 @@ > * @summary diagnose encoding errors in Java source files > * @author gafter > * > - * @compile -encoding ascii -source 1.5 Unmappable.java > - * @compile/fail -Werror -encoding ascii -source 1.5 Unmappable.java > * @compile/fail -encoding ascii Unmappable.java > */ > > --- old/test/tools/javap/output/Tester.java 2014-01-14 > 16:50:19.000000000 -0800 > +++ new/test/tools/javap/output/Tester.java 2014-01-14 > 16:50:19.000000000 -0800 > @@ -1,5 +1,5 @@ > /* > - * Copyright (c) 2013, Oracle and/or its affiliates. All rights > reserved. > + * Copyright (c) 2013, 2014, Oracle and/or its affiliates. All rights > reserved. > * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > * > * This code is free software; you can redistribute it and/or modify it > @@ -271,7 +271,7 @@ > */ > protected void compileTestFile() { > String path = javaFile.getPath(); > - String params[] = { "-source", "1.8", "-g", path }; > + String params[] = {"-g", path }; > int rc = com.sun.tools.javac.Main.compile(params); > if (rc != 0) > throw new Error("compilation failed. rc=" + rc); > --- old/test/tools/javap/typeAnnotations/JSR175Annotations.java > 2014-01-14 16:50:19.000000000 -0800 > +++ new/test/tools/javap/typeAnnotations/JSR175Annotations.java > 2014-01-14 16:50:19.000000000 -0800 > @@ -1,5 +1,5 @@ > /* > - * Copyright (c) 2008, 2013, Oracle and/or its affiliates. All rights > reserved. > + * Copyright (c) 2008, 2014, Oracle and/or its affiliates. All rights > reserved. > * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > * > * This code is free software; you can redistribute it and/or modify it > @@ -114,7 +114,7 @@ > } > > File compileTestFile(File f) { > - int rc = com.sun.tools.javac.Main.compile(new String[] { > "-source", "1.8", "-g", f.getPath() }); > + int rc = com.sun.tools.javac.Main.compile(new String[] {"-g", > f.getPath() }); > if (rc != 0) > throw new Error("compilation failed. rc=" + rc); > String path = f.getPath(); > --- old/test/tools/javap/typeAnnotations/NewArray.java 2014-01-14 > 16:50:19.000000000 -0800 > +++ new/test/tools/javap/typeAnnotations/NewArray.java 2014-01-14 > 16:50:19.000000000 -0800 > @@ -1,5 +1,5 @@ > /* > - * Copyright (c) 2008, 2013, Oracle and/or its affiliates. All rights > reserved. > + * Copyright (c) 2008, 2014, Oracle and/or its affiliates. All rights > reserved. > * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > * > * This code is free software; you can redistribute it and/or modify it > @@ -102,7 +102,7 @@ > } > > File compileTestFile(File f) { > - int rc = com.sun.tools.javac.Main.compile(new String[] { > "-source", "1.8", "-g", f.getPath() }); > + int rc = com.sun.tools.javac.Main.compile(new String[] {"-g", > f.getPath() }); > if (rc != 0) > throw new Error("compilation failed. rc=" + rc); > String path = f.getPath(); > --- old/test/tools/javap/typeAnnotations/Presence.java 2014-01-14 > 16:50:20.000000000 -0800 > +++ new/test/tools/javap/typeAnnotations/Presence.java 2014-01-14 > 16:50:20.000000000 -0800 > @@ -1,5 +1,5 @@ > /* > - * Copyright (c) 2008, 2013, Oracle and/or its affiliates. All rights > reserved. > + * Copyright (c) 2008, 2014, Oracle and/or its affiliates. All rights > reserved. > * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > * > * This code is free software; you can redistribute it and/or modify it > @@ -180,7 +180,7 @@ > } > > File compileTestFile(File f) { > - int rc = com.sun.tools.javac.Main.compile(new String[] { > "-source", "1.8", "-g", f.getPath() }); > + int rc = com.sun.tools.javac.Main.compile(new String[] {"-g", > f.getPath() }); > if (rc != 0) > throw new Error("compilation failed. rc=" + rc); > String path = f.getPath(); > --- old/test/tools/javap/typeAnnotations/PresenceInner.java 2014-01-14 > 16:50:20.000000000 -0800 > +++ new/test/tools/javap/typeAnnotations/PresenceInner.java 2014-01-14 > 16:50:20.000000000 -0800 > @@ -1,5 +1,5 @@ > /* > - * Copyright (c) 2009, 2013, Oracle and/or its affiliates. All rights > reserved. > + * Copyright (c) 2009, 2014, Oracle and/or its affiliates. All rights > reserved. > * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > * > * This code is free software; you can redistribute it and/or modify it > @@ -149,7 +149,7 @@ > } > > File compileTestFile(File f) { > - int rc = com.sun.tools.javac.Main.compile(new String[] { > "-source", "1.8", "-g", f.getPath() }); > + int rc = com.sun.tools.javac.Main.compile(new String[] {"-g", > f.getPath() }); > if (rc != 0) > throw new Error("compilation failed. rc=" + rc); > String path = f.getPath(); > --- old/test/tools/javap/typeAnnotations/TypeCasts.java 2014-01-14 > 16:50:20.000000000 -0800 > +++ new/test/tools/javap/typeAnnotations/TypeCasts.java 2014-01-14 > 16:50:20.000000000 -0800 > @@ -1,5 +1,5 @@ > /* > - * Copyright (c) 2009, 2013, Oracle and/or its affiliates. All rights > reserved. > + * Copyright (c) 2009, 2014, Oracle and/or its affiliates. All rights > reserved. > * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > * > * This code is free software; you can redistribute it and/or modify it > @@ -117,7 +117,7 @@ > } > > File compileTestFile(File f) { > - int rc = com.sun.tools.javac.Main.compile(new String[] { > "-source", "1.8", "-g", f.getPath() }); > + int rc = com.sun.tools.javac.Main.compile(new String[] {"-g", > f.getPath() }); > if (rc != 0) > throw new Error("compilation failed. rc=" + rc); > String path = f.getPath(); > --- old/test/tools/javap/typeAnnotations/Visibility.java 2014-01-14 > 16:50:21.000000000 -0800 > +++ new/test/tools/javap/typeAnnotations/Visibility.java 2014-01-14 > 16:50:21.000000000 -0800 > @@ -1,5 +1,5 @@ > /* > - * Copyright (c) 2008, 2013, Oracle and/or its affiliates. All rights > reserved. > + * Copyright (c) 2008, 2014, Oracle and/or its affiliates. All rights > reserved. > * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > * > * This code is free software; you can redistribute it and/or modify it > @@ -108,7 +108,7 @@ > } > > File compileTestFile(File f) { > - int rc = com.sun.tools.javac.Main.compile(new String[] { > "-source", "1.8", "-g", f.getPath() }); > + int rc = com.sun.tools.javac.Main.compile(new String[] {"-g", > f.getPath() }); > if (rc != 0) > throw new Error("compilation failed. rc=" + rc); > String path = f.getPath(); > --- old/test/tools/javap/typeAnnotations/Wildcards.java 2014-01-14 > 16:50:22.000000000 -0800 > +++ new/test/tools/javap/typeAnnotations/Wildcards.java 2014-01-14 > 16:50:22.000000000 -0800 > @@ -1,5 +1,5 @@ > /* > - * Copyright (c) 2009, 2013, Oracle and/or its affiliates. All rights > reserved. > + * Copyright (c) 2009, 2014, Oracle and/or its affiliates. All rights > reserved. > * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > * > * This code is free software; you can redistribute it and/or modify it > @@ -139,7 +139,7 @@ > } > > File compileTestFile(File f) { > - int rc = com.sun.tools.javac.Main.compile(new String[] { > "-source", "1.8", "-g", f.getPath() }); > + int rc = com.sun.tools.javac.Main.compile(new String[] {"-g", > f.getPath() }); > if (rc != 0) > throw new Error("compilation failed. rc=" + rc); > String path = f.getPath(); > --- old/test/tools/javac/Capture.java 2014-01-14 16:50:22.000000000 > -0800 > +++ /dev/null 2014-01-13 10:19:39.230183767 -0800 > @@ -1,46 +0,0 @@ > -/* > - * Copyright (c) 2002, 2004, Oracle and/or its affiliates. All rights > reserved. > - * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > - * > - * This code is free software; you can redistribute it and/or modify it > - * under the terms of the GNU General Public License version 2 only, as > - * published by the Free Software Foundation. > - * > - * This code is distributed in the hope that it will be useful, but > WITHOUT > - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or > - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License > - * version 2 for more details (a copy is included in the LICENSE file > that > - * accompanied this code). > - * > - * You should have received a copy of the GNU General Public License > version > - * 2 along with this work; if not, write to the Free Software > Foundation, > - * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. > - * > - * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA > 94065 USA > - * or visit www.oracle.com if you need additional information or have > any > - * questions. > - */ > - > -/* > - * @test > - * @bug 4441338 4994508 > - * @summary Captured variable synthetic parameters should be passed > before explicit params. > - * @author gafter > - * > - * @compile -source 1.4 -target 1.4 Capture.java > - * @run main Capture > - */ > - > -public class Capture { > - final int k; > - Capture(int n) { > - k = n; > - } > - public static void main(String args[]) { > - final int j; > - int k1 = new Capture(2 + (j=3)){ > - int get () {return k+j;} > - }.get(); > - if (k1 != 8) throw new Error("k1 = " + k1); > - } > -} > --- old/test/tools/javac/Source5.java 2014-01-14 16:50:23.000000000 > -0800 > +++ /dev/null 2014-01-13 10:19:39.230183767 -0800 > @@ -1,39 +0,0 @@ > -/* > - * Copyright (c) 2004, Oracle and/or its affiliates. All rights > reserved. > - * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > - * > - * This code is free software; you can redistribute it and/or modify it > - * under the terms of the GNU General Public License version 2 only, as > - * published by the Free Software Foundation. > - * > - * This code is distributed in the hope that it will be useful, but > WITHOUT > - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or > - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License > - * version 2 for more details (a copy is included in the LICENSE file > that > - * accompanied this code). > - * > - * You should have received a copy of the GNU General Public License > version > - * 2 along with this work; if not, write to the Free Software > Foundation, > - * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. > - * > - * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA > 94065 USA > - * or visit www.oracle.com if you need additional information or have > any > - * questions. > - */ > - > -/* > - * @test > - * @bug 5044157 > - * @summary please accept -source 5 and -target 5 > - * @author Peter von der Ah? > - * > - * @compile -source 5 -target 5 -encoding iso-8859-1 Source5.java > - * @run main Source5 > - */ > - > -public enum Source5 { > - JDK5; > - public static void main(String[] args) { > - System.out.println("Hello, world!"); > - } > -} > --- old/test/tools/javac/processing/warnings/gold_sv_warn_0_2.out > 2014-01-14 16:50:23.000000000 -0800 > +++ /dev/null 2014-01-13 10:19:39.230183767 -0800 > @@ -1,2 +0,0 @@ > -- compiler.warn.proc.processor.incompatible.source.version: > RELEASE_0, TestSourceVersionWarnings, 1.2 > -1 warning > --- old/test/tools/javac/processing/warnings/gold_sv_warn_2_3.out > 2014-01-14 16:50:23.000000000 -0800 > +++ /dev/null 2014-01-13 10:19:39.230183767 -0800 > @@ -1,2 +0,0 @@ > -- compiler.warn.proc.processor.incompatible.source.version: > RELEASE_2, TestSourceVersionWarnings, 1.3 > -1 warning > --- old/test/tools/javac/varargs/warning/Warn1.java 2014-01-14 > 16:50:23.000000000 -0800 > +++ /dev/null 2014-01-13 10:19:39.230183767 -0800 > @@ -1,42 +0,0 @@ > -/* > - * Copyright (c) 2004, 2010, Oracle and/or its affiliates. All rights > reserved. > - * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > - * > - * This code is free software; you can redistribute it and/or modify it > - * under the terms of the GNU General Public License version 2 only, as > - * published by the Free Software Foundation. > - * > - * This code is distributed in the hope that it will be useful, but > WITHOUT > - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or > - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License > - * version 2 for more details (a copy is included in the LICENSE file > that > - * accompanied this code). > - * > - * You should have received a copy of the GNU General Public License > version > - * 2 along with this work; if not, write to the Free Software > Foundation, > - * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. > - * > - * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA > 94065 USA > - * or visit www.oracle.com if you need additional information or have > any > - * questions. > - */ > - > -/* > - * @test > - * @bug 5035307 > - * @summary fixed-arity warning given too often > - * @author gafter > - * > - * @compile -Werror -source 1.4 -Xlint:-options Warn1.java > - */ > - > -package varargs.warning.warn1; > - > -import java.util.List; > -import java.util.Arrays; > - > -class Warn1 { > - void f(String[] args) { > - List l = java.util.Arrays.asList(args); > - } > -} > From joel.franck at oracle.com Thu Jan 16 07:02:05 2014 From: joel.franck at oracle.com (=?iso-8859-1?Q?Joel_Borggr=E9n-Franck?=) Date: Thu, 16 Jan 2014 16:02:05 +0100 Subject: JDK9 RFR: JDK-8029017: ElementType.TYPE_USE should be a logical superset of ElementType.TYPE and ANNOTATION_TYPE Message-ID: Hi, Please review this fix intended for 9 and 8u. https://bugs.openjdk.java.net/browse/JDK-8029017 http://cr.openjdk.java.net/~jfranck/8029017/ We got the rules wrong for TYPE_USE with respect to repeating annotation and their containers. TYPE_USE should be a superset of TYPE, ANNOTATION_TYPE, and TYPE_PARAMETER. cheers /Joel From brian.goetz at oracle.com Thu Jan 16 08:57:44 2014 From: brian.goetz at oracle.com (Brian Goetz) Date: Thu, 16 Jan 2014 11:57:44 -0500 Subject: JDK 9 RFR of JDK-8031745: Remove unneeded/obsolete -source/-target options in javac tests, part 1 In-Reply-To: <52D764E1.5010003@oracle.com> References: <52D5DDD1.60400@oracle.com> <52D764E1.5010003@oracle.com> Message-ID: <52D80F88.40102@oracle.com> Overall, I'm in favor of simplifications like these; fully constant-propagating these means simpler code paths and fewer opportunities for bad assumptions. And simplifications often beget further simplifications. The only reason I can think of to hesitate is if we think we're going to bring back some of these specific options in the future; then the historical context might be lost. Maybe a block of comments in Source/Target outlining some of the historical anomalies might help preserve the history without infecting the code. On 1/15/2014 11:49 PM, Joe Darcy wrote: > PS To provide a little more context around this, our overall policy is > now to retire sufficiently old -source and -target options: > > Policy for Retiring javac -source and -target Options > http://openjdk.java.net/jeps/182 > > In JDK 9, source/target options {6/1.6, 7/1.7, 8/1.8, 9/1.9} will be > supported. One of the benefits is allowing simplifications in javac. The > types used for source and target modeling in javac define a number of > predicates, "allowFoo", whose contents tend to be one-line version > checks "return version >= VERSION_INTRODUCING_FEATURE;". A trivial way > to implement the predicates is to make them unconditionally return true > or false, as appropriate, after the old source/target values are dropped. > > However, it is of course more interesting if these newly-constant > results get constant propagated into the javac code base so that now > effectively-dead code in javac can be deleted. We had a little of this > effect in JDK 8 when several never-documented targets were removed: > > JDK-8010179: Remove transitional target values from javac > http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a4913ea9bb62 > > However, the code deletion in javac can be expected to be much bigger > when generics can assumed to be present. > > As a secondary effect, some messages reported by the compiler will no > longer be reported so there will be fewer messages to localize and > maintain. > > Comments? > > Thanks, > > -Joe > > On 1/14/2014 5:01 PM, Joe Darcy wrote: >> Hello, >> >> Please review my fix for >> >> JDK-8031745 : Remove unneeded/obsolete -source/-target options in >> javac tests, part 1 >> http://cr.openjdk.java.net/~darcy/8031745.0/ >> >> This covers about half of the relevant javac test files; I'm making >> progress on the other half. With these changes, all langtools >> regression tests still pass. >> >> Full patch below. >> >> Thanks, >> >> -Joe >> >> --- old/test/tools/apt/Basics/CheckAptIsRemovedTest.java 2014-01-14 >> 16:50:13.000000000 -0800 >> +++ new/test/tools/apt/Basics/CheckAptIsRemovedTest.java 2014-01-14 >> 16:50:13.000000000 -0800 >> @@ -1,5 +1,5 @@ >> /* >> - * Copyright (c) 2013, Oracle and/or its affiliates. All rights >> reserved. >> + * Copyright (c) 2013, 2014, Oracle and/or its affiliates. All rights >> reserved. >> * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. >> * >> * This code is free software; you can redistribute it and/or modify it >> @@ -87,7 +87,7 @@ >> Path classpath = Paths.get(testJDK, "lib", "tools.jar"); >> ToolBox.JavaToolArgs javacArgs = >> new ToolBox.JavaToolArgs(ToolBox.Expect.FAIL) >> - .setOptions("-source", "1.5", "-sourcepath", ".", >> + .setOptions("-sourcepath", ".", >> "-classpath", classpath.toString()) >> .setSources(NullAPFSrc); >> ToolBox.javac(javacArgs); >> --- old/test/tools/javac/6341866/T6341866.java 2014-01-14 >> 16:50:14.000000000 -0800 >> +++ new/test/tools/javac/6341866/T6341866.java 2014-01-14 >> 16:50:13.000000000 -0800 >> @@ -97,7 +97,7 @@ >> processorServices.delete(); >> >> List opts = new ArrayList(); >> - opts.addAll(Arrays.asList("-d", ".", "-sourcepath", testSrc, >> "-classpath", testClasses, "-source", "1.6", "-Xlint:-options")); >> + opts.addAll(Arrays.asList("-d", ".", "-sourcepath", testSrc, >> "-classpath", testClasses, "-Xlint:-options")); >> if (implicitType.opt != null) >> opts.add(implicitType.opt); >> >> --- old/test/tools/javac/ClassFileModifiers/MemberModifiers.java >> 2014-01-14 16:50:14.000000000 -0800 >> +++ new/test/tools/javac/ClassFileModifiers/MemberModifiers.java >> 2014-01-14 16:50:14.000000000 -0800 >> @@ -26,7 +26,7 @@ >> * @bug 4249112 4785453 >> * @summary Verify that implicit member modifiers are set correctly. >> * >> - * @compile/ref=MemberModifiers.out -source 1.4 -target 1.5 >> -Xlint:-options -XDdumpmodifiers=cfm MemberModifiers.java >> + * @compile/ref=MemberModifiers.out -XDdumpmodifiers=cfm >> MemberModifiers.java >> */ >> >> // Currently, we check only that members of final classes are not final. >> --- old/test/tools/javac/ConditionalArgTypes_1.java 2014-01-14 >> 16:50:14.000000000 -0800 >> +++ new/test/tools/javac/ConditionalArgTypes_1.java 2014-01-14 >> 16:50:14.000000000 -0800 >> @@ -1,5 +1,5 @@ >> /* >> - * Copyright (c) 2000, 2003, Oracle and/or its affiliates. All rights >> reserved. >> + * Copyright (c) 2000, 2014, Oracle and/or its affiliates. All rights >> reserved. >> * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. >> * >> * This code is free software; you can redistribute it and/or modify it >> @@ -27,7 +27,6 @@ >> * @summary Verify that both branches of a conditional expression >> must agree in type. >> * @author maddox >> * >> - * @compile/fail -source 1.4 ConditionalArgTypes_1.java >> * @compile ConditionalArgTypes_1.java >> */ >> >> --- old/test/tools/javac/T6394563.java 2014-01-14 >> 16:50:15.000000000 -0800 >> +++ new/test/tools/javac/T6394563.java 2014-01-14 >> 16:50:15.000000000 -0800 >> @@ -4,12 +4,7 @@ >> * @summary javac ignores -nowarn switch in 1.5.0_06 for deprecation >> warnings >> * >> * @compile/ref=T6394563.note.out -XDrawDiagnostics >> -nowarn T6394563.java >> - * @compile/ref=T6394563.note.out -XDrawDiagnostics -nowarn -source >> 1.5 T6394563.java >> - * @compile/ref=T6394563.empty.out -XDrawDiagnostics -nowarn -source >> 1.4 T6394563.java >> - * >> - * @compile/ref=T6394563.warn.out -XDrawDiagnostics -Xlint >> -nowarn T6394563.java >> - * @compile/ref=T6394563.warn.out -XDrawDiagnostics -Xlint -nowarn >> -source 1.5 T6394563.java >> - * @compile/ref=T6394563.empty.out -XDrawDiagnostics -Xlint -nowarn >> -source 1.4 T6394563.java >> + * @compile/ref=T6394563.warn.out -XDrawDiagnostics -Xlint >> -nowarn T6394563.java >> */ >> >> class T6394563 { >> --- old/test/tools/javac/T6394563.warn.out 2014-01-14 >> 16:50:15.000000000 -0800 >> +++ new/test/tools/javac/T6394563.warn.out 2014-01-14 >> 16:50:15.000000000 -0800 >> @@ -1,2 +1,2 @@ >> -T6394563.java:17:19: compiler.warn.has.been.deprecated: foo(), >> deprecated >> +T6394563.java:12:19: compiler.warn.has.been.deprecated: foo(), >> deprecated >> 1 warning >> --- old/test/tools/javac/api/T6306137.java 2014-01-14 >> 16:50:15.000000000 -0800 >> +++ new/test/tools/javac/api/T6306137.java 2014-01-14 >> 16:50:15.000000000 -0800 >> @@ -76,7 +76,7 @@ >> } >> void test(String encoding, boolean good) { >> error = false; >> - Iterable args = Arrays.asList("-source", "6", >> "-encoding", encoding, "-d", "."); >> + Iterable args = Arrays.asList("-encoding", encoding, >> "-d", "."); >> compiler.getTask(null, fm, dl, args, null, files).call(); >> if (error == good) { >> if (error) { >> --- old/test/tools/javac/api/TestGetElementReference.java 2014-01-14 >> 16:50:16.000000000 -0800 >> +++ new/test/tools/javac/api/TestGetElementReference.java 2014-01-14 >> 16:50:16.000000000 -0800 >> @@ -52,7 +52,7 @@ >> File source = new File(System.getProperty("test.src", "."), >> "TestGetElementReferenceData.java").getAbsoluteFile(); >> StandardJavaFileManager fm = >> ToolProvider.getSystemJavaCompiler().getStandardFileManager(null, >> null, null); >> DiagnosticCollector diagnostics = new >> DiagnosticCollector<>(); >> - JavacTask ct = (JavacTask) >> ToolProvider.getSystemJavaCompiler().getTask(null, null, diagnostics, >> Arrays.asList("-Xjcov", "-source", "1.8"), null, >> fm.getJavaFileObjects(source)); >> + JavacTask ct = (JavacTask) >> ToolProvider.getSystemJavaCompiler().getTask(null, null, diagnostics, >> Arrays.asList("-Xjcov"), null, fm.getJavaFileObjects(source)); >> Trees trees = Trees.instance(ct); >> CompilationUnitTree cut = ct.parse().iterator().next(); >> >> --- old/test/tools/javac/lambda/ByteCodeTest.java 2014-01-14 >> 16:50:17.000000000 -0800 >> +++ new/test/tools/javac/lambda/ByteCodeTest.java 2014-01-14 >> 16:50:17.000000000 -0800 >> @@ -122,7 +122,7 @@ >> >> static File compile(File f) { >> int rc = com.sun.tools.javac.Main.compile(new String[] { >> - "-source", "1.8", "-g", f.getPath() }); >> + "-g", f.getPath() }); >> if (rc != 0) >> throw new Error("compilation failed. rc=" + rc); >> String path = f.getPath(); >> --- old/test/tools/javac/processing/environment/TestSourceVersion.java >> 2014-01-14 16:50:17.000000000 -0800 >> +++ new/test/tools/javac/processing/environment/TestSourceVersion.java >> 2014-01-14 16:50:17.000000000 -0800 >> @@ -1,5 +1,5 @@ >> /* >> - * Copyright (c) 2006, 2010, Oracle and/or its affiliates. All rights >> reserved. >> + * Copyright (c) 2006, 2014, Oracle and/or its affiliates. All rights >> reserved. >> * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. >> * >> * This code is free software; you can redistribute it and/or modify it >> @@ -23,21 +23,20 @@ >> >> /* >> * @test >> - * @bug 6402506 >> + * @bug 6402506 8028545 8028543 >> * @summary Test that getSourceVersion works properly >> * @author Joseph D. Darcy >> * @library /tools/javac/lib >> * @build JavacTestingAbstractProcessor >> * @compile TestSourceVersion.java >> - * @compile -processor TestSourceVersion -proc:only -source 1.2 >> -AExpectedVersion=RELEASE_2 HelloWorld.java >> - * @compile -processor TestSourceVersion -proc:only -source 1.3 >> -AExpectedVersion=RELEASE_3 HelloWorld.java >> - * @compile -processor TestSourceVersion -proc:only -source 1.4 >> -AExpectedVersion=RELEASE_4 HelloWorld.java >> - * @compile -processor TestSourceVersion -proc:only -source 1.5 >> -AExpectedVersion=RELEASE_5 HelloWorld.java >> - * @compile -processor TestSourceVersion -proc:only -source 5 >> -AExpectedVersion=RELEASE_5 HelloWorld.java >> * @compile -processor TestSourceVersion -proc:only -source 1.6 >> -AExpectedVersion=RELEASE_6 HelloWorld.java >> * @compile -processor TestSourceVersion -proc:only -source 6 >> -AExpectedVersion=RELEASE_6 HelloWorld.java >> * @compile -processor TestSourceVersion -proc:only -source 1.7 >> -AExpectedVersion=RELEASE_7 HelloWorld.java >> * @compile -processor TestSourceVersion -proc:only -source 7 >> -AExpectedVersion=RELEASE_7 HelloWorld.java >> + * @compile -processor TestSourceVersion -proc:only -source 1.8 >> -AExpectedVersion=RELEASE_8 HelloWorld.java >> + * @compile -processor TestSourceVersion -proc:only -source 8 >> -AExpectedVersion=RELEASE_8 HelloWorld.java >> + * @compile -processor TestSourceVersion -proc:only -source 1.9 >> -AExpectedVersion=RELEASE_9 HelloWorld.java >> + * @compile -processor TestSourceVersion -proc:only -source 9 >> -AExpectedVersion=RELEASE_9 HelloWorld.java >> */ >> >> import java.util.Set; >> --- >> old/test/tools/javac/processing/warnings/TestSourceVersionWarnings.java 2014-01-14 >> 16:50:17.000000000 -0800 >> +++ >> new/test/tools/javac/processing/warnings/TestSourceVersionWarnings.java 2014-01-14 >> 16:50:17.000000000 -0800 >> @@ -27,11 +27,7 @@ >> * @summary Test that warnings about source versions are output as >> expected. >> * @author Joseph D. Darcy >> * @compile TestSourceVersionWarnings.java >> - * @compile/ref=gold_0.out -XDrawDiagnostics -processor >> TestSourceVersionWarnings -proc:only -source 1.5 -Xlint:-options >> HelloWorld.java >> - * @compile/ref=gold_sv_warn_0_2.out -XDrawDiagnostics -processor >> TestSourceVersionWarnings -proc:only -ASourceVersion=RELEASE_0 -source >> 1.2 -Xlint:-options HelloWorld.java >> - * @compile/ref=gold_sv_none.out -XDrawDiagnostics -processor >> TestSourceVersionWarnings -proc:only -ASourceVersion=RELEASE_2 -source >> 1.2 -Xlint:-options HelloWorld.java >> - * @compile/ref=gold_sv_warn_2_3.out -XDrawDiagnostics -processor >> TestSourceVersionWarnings -proc:only -ASourceVersion=RELEASE_2 -source >> 1.3 -Xlint:-options HelloWorld.java >> - * @compile/ref=gold_sv_none.out -XDrawDiagnostics -processor >> TestSourceVersionWarnings -proc:only -ASourceVersion=RELEASE_5 -source >> 1.5 -Xlint:-options HelloWorld.java >> + * @compile/ref=gold_0.out -XDrawDiagnostics -processor >> TestSourceVersionWarnings -proc:only -source 1.6 -Xlint:-options >> HelloWorld.java >> * @compile/ref=gold_sv_warn_5_6.out -XDrawDiagnostics -processor >> TestSourceVersionWarnings -proc:only -ASourceVersion=RELEASE_5 -source >> 1.6 -Xlint:-options HelloWorld.java >> * @compile/ref=gold_sv_none.out -XDrawDiagnostics -processor >> TestSourceVersionWarnings -proc:only -ASourceVersion=RELEASE_6 -source >> 1.6 -Xlint:-options HelloWorld.java >> * @compile/ref=gold_unsp_warn.out -XDrawDiagnostics -processor >> TestSourceVersionWarnings -proc:only -ASourceVersion=RELEASE_6 -source >> 1.6 -Xlint:-options -Aunsupported HelloWorld.java >> --- old/test/tools/javac/stackmap/StackMapTest.java 2014-01-14 >> 16:50:18.000000000 -0800 >> +++ new/test/tools/javac/stackmap/StackMapTest.java 2014-01-14 >> 16:50:18.000000000 -0800 >> @@ -27,7 +27,7 @@ >> * @summary The "method0" StackMap attribute should have two entries >> instead of three >> * @library /tools/javac/lib >> * @build ToolBox >> - * @run compile -source 6 -target 6 StackMapTest.java >> + * @run compile StackMapTest.java >> * @run main StackMapTest >> */ >> >> @@ -48,7 +48,7 @@ >> } >> >> public static void main(String args[]) throws Exception { >> -// "${TESTJAVA}${FS}bin${FS}javac" ${TESTTOOLVMOPTS} -source 6 >> -target 6 T4955930.java >> +// "${TESTJAVA}${FS}bin${FS}javac" ${TESTTOOLVMOPTS} T4955930.java >> >> // "${TESTJAVA}${FS}bin${FS}javap" ${TESTTOOLVMOPTS} -verbose >> T4955930 > ${TMP1} >> Path pathToClass = Paths.get(System.getProperty("test.classes"), >> --- old/test/tools/javac/unicode/Unmappable.java 2014-01-14 >> 16:50:18.000000000 -0800 >> +++ new/test/tools/javac/unicode/Unmappable.java 2014-01-14 >> 16:50:18.000000000 -0800 >> @@ -27,8 +27,6 @@ >> * @summary diagnose encoding errors in Java source files >> * @author gafter >> * >> - * @compile -encoding ascii -source 1.5 Unmappable.java >> - * @compile/fail -Werror -encoding ascii -source 1.5 Unmappable.java >> * @compile/fail -encoding ascii Unmappable.java >> */ >> >> --- old/test/tools/javap/output/Tester.java 2014-01-14 >> 16:50:19.000000000 -0800 >> +++ new/test/tools/javap/output/Tester.java 2014-01-14 >> 16:50:19.000000000 -0800 >> @@ -1,5 +1,5 @@ >> /* >> - * Copyright (c) 2013, Oracle and/or its affiliates. All rights >> reserved. >> + * Copyright (c) 2013, 2014, Oracle and/or its affiliates. All rights >> reserved. >> * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. >> * >> * This code is free software; you can redistribute it and/or modify it >> @@ -271,7 +271,7 @@ >> */ >> protected void compileTestFile() { >> String path = javaFile.getPath(); >> - String params[] = { "-source", "1.8", "-g", path }; >> + String params[] = {"-g", path }; >> int rc = com.sun.tools.javac.Main.compile(params); >> if (rc != 0) >> throw new Error("compilation failed. rc=" + rc); >> --- old/test/tools/javap/typeAnnotations/JSR175Annotations.java >> 2014-01-14 16:50:19.000000000 -0800 >> +++ new/test/tools/javap/typeAnnotations/JSR175Annotations.java >> 2014-01-14 16:50:19.000000000 -0800 >> @@ -1,5 +1,5 @@ >> /* >> - * Copyright (c) 2008, 2013, Oracle and/or its affiliates. All rights >> reserved. >> + * Copyright (c) 2008, 2014, Oracle and/or its affiliates. All rights >> reserved. >> * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. >> * >> * This code is free software; you can redistribute it and/or modify it >> @@ -114,7 +114,7 @@ >> } >> >> File compileTestFile(File f) { >> - int rc = com.sun.tools.javac.Main.compile(new String[] { >> "-source", "1.8", "-g", f.getPath() }); >> + int rc = com.sun.tools.javac.Main.compile(new String[] {"-g", >> f.getPath() }); >> if (rc != 0) >> throw new Error("compilation failed. rc=" + rc); >> String path = f.getPath(); >> --- old/test/tools/javap/typeAnnotations/NewArray.java 2014-01-14 >> 16:50:19.000000000 -0800 >> +++ new/test/tools/javap/typeAnnotations/NewArray.java 2014-01-14 >> 16:50:19.000000000 -0800 >> @@ -1,5 +1,5 @@ >> /* >> - * Copyright (c) 2008, 2013, Oracle and/or its affiliates. All rights >> reserved. >> + * Copyright (c) 2008, 2014, Oracle and/or its affiliates. All rights >> reserved. >> * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. >> * >> * This code is free software; you can redistribute it and/or modify it >> @@ -102,7 +102,7 @@ >> } >> >> File compileTestFile(File f) { >> - int rc = com.sun.tools.javac.Main.compile(new String[] { >> "-source", "1.8", "-g", f.getPath() }); >> + int rc = com.sun.tools.javac.Main.compile(new String[] {"-g", >> f.getPath() }); >> if (rc != 0) >> throw new Error("compilation failed. rc=" + rc); >> String path = f.getPath(); >> --- old/test/tools/javap/typeAnnotations/Presence.java 2014-01-14 >> 16:50:20.000000000 -0800 >> +++ new/test/tools/javap/typeAnnotations/Presence.java 2014-01-14 >> 16:50:20.000000000 -0800 >> @@ -1,5 +1,5 @@ >> /* >> - * Copyright (c) 2008, 2013, Oracle and/or its affiliates. All rights >> reserved. >> + * Copyright (c) 2008, 2014, Oracle and/or its affiliates. All rights >> reserved. >> * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. >> * >> * This code is free software; you can redistribute it and/or modify it >> @@ -180,7 +180,7 @@ >> } >> >> File compileTestFile(File f) { >> - int rc = com.sun.tools.javac.Main.compile(new String[] { >> "-source", "1.8", "-g", f.getPath() }); >> + int rc = com.sun.tools.javac.Main.compile(new String[] {"-g", >> f.getPath() }); >> if (rc != 0) >> throw new Error("compilation failed. rc=" + rc); >> String path = f.getPath(); >> --- old/test/tools/javap/typeAnnotations/PresenceInner.java 2014-01-14 >> 16:50:20.000000000 -0800 >> +++ new/test/tools/javap/typeAnnotations/PresenceInner.java 2014-01-14 >> 16:50:20.000000000 -0800 >> @@ -1,5 +1,5 @@ >> /* >> - * Copyright (c) 2009, 2013, Oracle and/or its affiliates. All rights >> reserved. >> + * Copyright (c) 2009, 2014, Oracle and/or its affiliates. All rights >> reserved. >> * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. >> * >> * This code is free software; you can redistribute it and/or modify it >> @@ -149,7 +149,7 @@ >> } >> >> File compileTestFile(File f) { >> - int rc = com.sun.tools.javac.Main.compile(new String[] { >> "-source", "1.8", "-g", f.getPath() }); >> + int rc = com.sun.tools.javac.Main.compile(new String[] {"-g", >> f.getPath() }); >> if (rc != 0) >> throw new Error("compilation failed. rc=" + rc); >> String path = f.getPath(); >> --- old/test/tools/javap/typeAnnotations/TypeCasts.java 2014-01-14 >> 16:50:20.000000000 -0800 >> +++ new/test/tools/javap/typeAnnotations/TypeCasts.java 2014-01-14 >> 16:50:20.000000000 -0800 >> @@ -1,5 +1,5 @@ >> /* >> - * Copyright (c) 2009, 2013, Oracle and/or its affiliates. All rights >> reserved. >> + * Copyright (c) 2009, 2014, Oracle and/or its affiliates. All rights >> reserved. >> * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. >> * >> * This code is free software; you can redistribute it and/or modify it >> @@ -117,7 +117,7 @@ >> } >> >> File compileTestFile(File f) { >> - int rc = com.sun.tools.javac.Main.compile(new String[] { >> "-source", "1.8", "-g", f.getPath() }); >> + int rc = com.sun.tools.javac.Main.compile(new String[] {"-g", >> f.getPath() }); >> if (rc != 0) >> throw new Error("compilation failed. rc=" + rc); >> String path = f.getPath(); >> --- old/test/tools/javap/typeAnnotations/Visibility.java 2014-01-14 >> 16:50:21.000000000 -0800 >> +++ new/test/tools/javap/typeAnnotations/Visibility.java 2014-01-14 >> 16:50:21.000000000 -0800 >> @@ -1,5 +1,5 @@ >> /* >> - * Copyright (c) 2008, 2013, Oracle and/or its affiliates. All rights >> reserved. >> + * Copyright (c) 2008, 2014, Oracle and/or its affiliates. All rights >> reserved. >> * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. >> * >> * This code is free software; you can redistribute it and/or modify it >> @@ -108,7 +108,7 @@ >> } >> >> File compileTestFile(File f) { >> - int rc = com.sun.tools.javac.Main.compile(new String[] { >> "-source", "1.8", "-g", f.getPath() }); >> + int rc = com.sun.tools.javac.Main.compile(new String[] {"-g", >> f.getPath() }); >> if (rc != 0) >> throw new Error("compilation failed. rc=" + rc); >> String path = f.getPath(); >> --- old/test/tools/javap/typeAnnotations/Wildcards.java 2014-01-14 >> 16:50:22.000000000 -0800 >> +++ new/test/tools/javap/typeAnnotations/Wildcards.java 2014-01-14 >> 16:50:22.000000000 -0800 >> @@ -1,5 +1,5 @@ >> /* >> - * Copyright (c) 2009, 2013, Oracle and/or its affiliates. All rights >> reserved. >> + * Copyright (c) 2009, 2014, Oracle and/or its affiliates. All rights >> reserved. >> * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. >> * >> * This code is free software; you can redistribute it and/or modify it >> @@ -139,7 +139,7 @@ >> } >> >> File compileTestFile(File f) { >> - int rc = com.sun.tools.javac.Main.compile(new String[] { >> "-source", "1.8", "-g", f.getPath() }); >> + int rc = com.sun.tools.javac.Main.compile(new String[] {"-g", >> f.getPath() }); >> if (rc != 0) >> throw new Error("compilation failed. rc=" + rc); >> String path = f.getPath(); >> --- old/test/tools/javac/Capture.java 2014-01-14 16:50:22.000000000 >> -0800 >> +++ /dev/null 2014-01-13 10:19:39.230183767 -0800 >> @@ -1,46 +0,0 @@ >> -/* >> - * Copyright (c) 2002, 2004, Oracle and/or its affiliates. All rights >> reserved. >> - * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. >> - * >> - * This code is free software; you can redistribute it and/or modify it >> - * under the terms of the GNU General Public License version 2 only, as >> - * published by the Free Software Foundation. >> - * >> - * This code is distributed in the hope that it will be useful, but >> WITHOUT >> - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or >> - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License >> - * version 2 for more details (a copy is included in the LICENSE file >> that >> - * accompanied this code). >> - * >> - * You should have received a copy of the GNU General Public License >> version >> - * 2 along with this work; if not, write to the Free Software >> Foundation, >> - * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. >> - * >> - * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA >> 94065 USA >> - * or visit www.oracle.com if you need additional information or have >> any >> - * questions. >> - */ >> - >> -/* >> - * @test >> - * @bug 4441338 4994508 >> - * @summary Captured variable synthetic parameters should be passed >> before explicit params. >> - * @author gafter >> - * >> - * @compile -source 1.4 -target 1.4 Capture.java >> - * @run main Capture >> - */ >> - >> -public class Capture { >> - final int k; >> - Capture(int n) { >> - k = n; >> - } >> - public static void main(String args[]) { >> - final int j; >> - int k1 = new Capture(2 + (j=3)){ >> - int get () {return k+j;} >> - }.get(); >> - if (k1 != 8) throw new Error("k1 = " + k1); >> - } >> -} >> --- old/test/tools/javac/Source5.java 2014-01-14 16:50:23.000000000 >> -0800 >> +++ /dev/null 2014-01-13 10:19:39.230183767 -0800 >> @@ -1,39 +0,0 @@ >> -/* >> - * Copyright (c) 2004, Oracle and/or its affiliates. All rights >> reserved. >> - * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. >> - * >> - * This code is free software; you can redistribute it and/or modify it >> - * under the terms of the GNU General Public License version 2 only, as >> - * published by the Free Software Foundation. >> - * >> - * This code is distributed in the hope that it will be useful, but >> WITHOUT >> - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or >> - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License >> - * version 2 for more details (a copy is included in the LICENSE file >> that >> - * accompanied this code). >> - * >> - * You should have received a copy of the GNU General Public License >> version >> - * 2 along with this work; if not, write to the Free Software >> Foundation, >> - * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. >> - * >> - * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA >> 94065 USA >> - * or visit www.oracle.com if you need additional information or have >> any >> - * questions. >> - */ >> - >> -/* >> - * @test >> - * @bug 5044157 >> - * @summary please accept -source 5 and -target 5 >> - * @author Peter von der Ah? >> - * >> - * @compile -source 5 -target 5 -encoding iso-8859-1 Source5.java >> - * @run main Source5 >> - */ >> - >> -public enum Source5 { >> - JDK5; >> - public static void main(String[] args) { >> - System.out.println("Hello, world!"); >> - } >> -} >> --- old/test/tools/javac/processing/warnings/gold_sv_warn_0_2.out >> 2014-01-14 16:50:23.000000000 -0800 >> +++ /dev/null 2014-01-13 10:19:39.230183767 -0800 >> @@ -1,2 +0,0 @@ >> -- compiler.warn.proc.processor.incompatible.source.version: >> RELEASE_0, TestSourceVersionWarnings, 1.2 >> -1 warning >> --- old/test/tools/javac/processing/warnings/gold_sv_warn_2_3.out >> 2014-01-14 16:50:23.000000000 -0800 >> +++ /dev/null 2014-01-13 10:19:39.230183767 -0800 >> @@ -1,2 +0,0 @@ >> -- compiler.warn.proc.processor.incompatible.source.version: >> RELEASE_2, TestSourceVersionWarnings, 1.3 >> -1 warning >> --- old/test/tools/javac/varargs/warning/Warn1.java 2014-01-14 >> 16:50:23.000000000 -0800 >> +++ /dev/null 2014-01-13 10:19:39.230183767 -0800 >> @@ -1,42 +0,0 @@ >> -/* >> - * Copyright (c) 2004, 2010, Oracle and/or its affiliates. All rights >> reserved. >> - * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. >> - * >> - * This code is free software; you can redistribute it and/or modify it >> - * under the terms of the GNU General Public License version 2 only, as >> - * published by the Free Software Foundation. >> - * >> - * This code is distributed in the hope that it will be useful, but >> WITHOUT >> - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or >> - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License >> - * version 2 for more details (a copy is included in the LICENSE file >> that >> - * accompanied this code). >> - * >> - * You should have received a copy of the GNU General Public License >> version >> - * 2 along with this work; if not, write to the Free Software >> Foundation, >> - * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. >> - * >> - * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA >> 94065 USA >> - * or visit www.oracle.com if you need additional information or have >> any >> - * questions. >> - */ >> - >> -/* >> - * @test >> - * @bug 5035307 >> - * @summary fixed-arity warning given too often >> - * @author gafter >> - * >> - * @compile -Werror -source 1.4 -Xlint:-options Warn1.java >> - */ >> - >> -package varargs.warning.warn1; >> - >> -import java.util.List; >> -import java.util.Arrays; >> - >> -class Warn1 { >> - void f(String[] args) { >> - List l = java.util.Arrays.asList(args); >> - } >> -} >> > From jonathan.gibbons at oracle.com Thu Jan 16 16:06:09 2014 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Thu, 16 Jan 2014 16:06:09 -0800 Subject: JDK 9 RFR of JDK-8031745: Remove unneeded/obsolete -source/-target options in javac tests, part 1 In-Reply-To: <52D5DDD1.60400@oracle.com> References: <52D5DDD1.60400@oracle.com> Message-ID: <52D873F1.8030108@oracle.com> OK, but a webrev on cr.openjdk.java.net would have been nicer. Approved. -- Jon On 01/14/2014 05:01 PM, Joe Darcy wrote: > Hello, > > Please review my fix for > > JDK-8031745 : Remove unneeded/obsolete -source/-target options in > javac tests, part 1 > http://cr.openjdk.java.net/~darcy/8031745.0/ > > This covers about half of the relevant javac test files; I'm making > progress on the other half. With these changes, all langtools > regression tests still pass. > > Full patch below. > > Thanks, > > -Joe > > --- old/test/tools/apt/Basics/CheckAptIsRemovedTest.java 2014-01-14 > 16:50:13.000000000 -0800 > +++ new/test/tools/apt/Basics/CheckAptIsRemovedTest.java 2014-01-14 > 16:50:13.000000000 -0800 > @@ -1,5 +1,5 @@ > /* > - * Copyright (c) 2013, Oracle and/or its affiliates. All rights > reserved. > + * Copyright (c) 2013, 2014, Oracle and/or its affiliates. All rights > reserved. > * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > * > * This code is free software; you can redistribute it and/or modify it > @@ -87,7 +87,7 @@ > Path classpath = Paths.get(testJDK, "lib", "tools.jar"); > ToolBox.JavaToolArgs javacArgs = > new ToolBox.JavaToolArgs(ToolBox.Expect.FAIL) > - .setOptions("-source", "1.5", "-sourcepath", ".", > + .setOptions("-sourcepath", ".", > "-classpath", classpath.toString()) > .setSources(NullAPFSrc); > ToolBox.javac(javacArgs); > --- old/test/tools/javac/6341866/T6341866.java 2014-01-14 > 16:50:14.000000000 -0800 > +++ new/test/tools/javac/6341866/T6341866.java 2014-01-14 > 16:50:13.000000000 -0800 > @@ -97,7 +97,7 @@ > processorServices.delete(); > > List opts = new ArrayList(); > - opts.addAll(Arrays.asList("-d", ".", "-sourcepath", testSrc, > "-classpath", testClasses, "-source", "1.6", "-Xlint:-options")); > + opts.addAll(Arrays.asList("-d", ".", "-sourcepath", testSrc, > "-classpath", testClasses, "-Xlint:-options")); > if (implicitType.opt != null) > opts.add(implicitType.opt); > > --- old/test/tools/javac/ClassFileModifiers/MemberModifiers.java > 2014-01-14 16:50:14.000000000 -0800 > +++ new/test/tools/javac/ClassFileModifiers/MemberModifiers.java > 2014-01-14 16:50:14.000000000 -0800 > @@ -26,7 +26,7 @@ > * @bug 4249112 4785453 > * @summary Verify that implicit member modifiers are set correctly. > * > - * @compile/ref=MemberModifiers.out -source 1.4 -target 1.5 > -Xlint:-options -XDdumpmodifiers=cfm MemberModifiers.java > + * @compile/ref=MemberModifiers.out -XDdumpmodifiers=cfm > MemberModifiers.java > */ > > // Currently, we check only that members of final classes are not final. > --- old/test/tools/javac/ConditionalArgTypes_1.java 2014-01-14 > 16:50:14.000000000 -0800 > +++ new/test/tools/javac/ConditionalArgTypes_1.java 2014-01-14 > 16:50:14.000000000 -0800 > @@ -1,5 +1,5 @@ > /* > - * Copyright (c) 2000, 2003, Oracle and/or its affiliates. All rights > reserved. > + * Copyright (c) 2000, 2014, Oracle and/or its affiliates. All rights > reserved. > * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > * > * This code is free software; you can redistribute it and/or modify it > @@ -27,7 +27,6 @@ > * @summary Verify that both branches of a conditional expression > must agree in type. > * @author maddox > * > - * @compile/fail -source 1.4 ConditionalArgTypes_1.java > * @compile ConditionalArgTypes_1.java > */ > > --- old/test/tools/javac/T6394563.java 2014-01-14 > 16:50:15.000000000 -0800 > +++ new/test/tools/javac/T6394563.java 2014-01-14 > 16:50:15.000000000 -0800 > @@ -4,12 +4,7 @@ > * @summary javac ignores -nowarn switch in 1.5.0_06 for deprecation > warnings > * > * @compile/ref=T6394563.note.out -XDrawDiagnostics > -nowarn T6394563.java > - * @compile/ref=T6394563.note.out -XDrawDiagnostics -nowarn -source > 1.5 T6394563.java > - * @compile/ref=T6394563.empty.out -XDrawDiagnostics -nowarn -source > 1.4 T6394563.java > - * > - * @compile/ref=T6394563.warn.out -XDrawDiagnostics -Xlint > -nowarn T6394563.java > - * @compile/ref=T6394563.warn.out -XDrawDiagnostics -Xlint -nowarn > -source 1.5 T6394563.java > - * @compile/ref=T6394563.empty.out -XDrawDiagnostics -Xlint -nowarn > -source 1.4 T6394563.java > + * @compile/ref=T6394563.warn.out -XDrawDiagnostics -Xlint > -nowarn T6394563.java > */ > > class T6394563 { > --- old/test/tools/javac/T6394563.warn.out 2014-01-14 > 16:50:15.000000000 -0800 > +++ new/test/tools/javac/T6394563.warn.out 2014-01-14 > 16:50:15.000000000 -0800 > @@ -1,2 +1,2 @@ > -T6394563.java:17:19: compiler.warn.has.been.deprecated: foo(), > deprecated > +T6394563.java:12:19: compiler.warn.has.been.deprecated: foo(), > deprecated > 1 warning > --- old/test/tools/javac/api/T6306137.java 2014-01-14 > 16:50:15.000000000 -0800 > +++ new/test/tools/javac/api/T6306137.java 2014-01-14 > 16:50:15.000000000 -0800 > @@ -76,7 +76,7 @@ > } > void test(String encoding, boolean good) { > error = false; > - Iterable args = Arrays.asList("-source", "6", > "-encoding", encoding, "-d", "."); > + Iterable args = Arrays.asList("-encoding", encoding, > "-d", "."); > compiler.getTask(null, fm, dl, args, null, files).call(); > if (error == good) { > if (error) { > --- old/test/tools/javac/api/TestGetElementReference.java 2014-01-14 > 16:50:16.000000000 -0800 > +++ new/test/tools/javac/api/TestGetElementReference.java 2014-01-14 > 16:50:16.000000000 -0800 > @@ -52,7 +52,7 @@ > File source = new File(System.getProperty("test.src", "."), > "TestGetElementReferenceData.java").getAbsoluteFile(); > StandardJavaFileManager fm = > ToolProvider.getSystemJavaCompiler().getStandardFileManager(null, > null, null); > DiagnosticCollector diagnostics = new > DiagnosticCollector<>(); > - JavacTask ct = (JavacTask) > ToolProvider.getSystemJavaCompiler().getTask(null, null, diagnostics, > Arrays.asList("-Xjcov", "-source", "1.8"), null, > fm.getJavaFileObjects(source)); > + JavacTask ct = (JavacTask) > ToolProvider.getSystemJavaCompiler().getTask(null, null, diagnostics, > Arrays.asList("-Xjcov"), null, fm.getJavaFileObjects(source)); > Trees trees = Trees.instance(ct); > CompilationUnitTree cut = ct.parse().iterator().next(); > > --- old/test/tools/javac/lambda/ByteCodeTest.java 2014-01-14 > 16:50:17.000000000 -0800 > +++ new/test/tools/javac/lambda/ByteCodeTest.java 2014-01-14 > 16:50:17.000000000 -0800 > @@ -122,7 +122,7 @@ > > static File compile(File f) { > int rc = com.sun.tools.javac.Main.compile(new String[] { > - "-source", "1.8", "-g", f.getPath() }); > + "-g", f.getPath() }); > if (rc != 0) > throw new Error("compilation failed. rc=" + rc); > String path = f.getPath(); > --- old/test/tools/javac/processing/environment/TestSourceVersion.java > 2014-01-14 16:50:17.000000000 -0800 > +++ new/test/tools/javac/processing/environment/TestSourceVersion.java > 2014-01-14 16:50:17.000000000 -0800 > @@ -1,5 +1,5 @@ > /* > - * Copyright (c) 2006, 2010, Oracle and/or its affiliates. All rights > reserved. > + * Copyright (c) 2006, 2014, Oracle and/or its affiliates. All rights > reserved. > * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > * > * This code is free software; you can redistribute it and/or modify it > @@ -23,21 +23,20 @@ > > /* > * @test > - * @bug 6402506 > + * @bug 6402506 8028545 8028543 > * @summary Test that getSourceVersion works properly > * @author Joseph D. Darcy > * @library /tools/javac/lib > * @build JavacTestingAbstractProcessor > * @compile TestSourceVersion.java > - * @compile -processor TestSourceVersion -proc:only -source 1.2 > -AExpectedVersion=RELEASE_2 HelloWorld.java > - * @compile -processor TestSourceVersion -proc:only -source 1.3 > -AExpectedVersion=RELEASE_3 HelloWorld.java > - * @compile -processor TestSourceVersion -proc:only -source 1.4 > -AExpectedVersion=RELEASE_4 HelloWorld.java > - * @compile -processor TestSourceVersion -proc:only -source 1.5 > -AExpectedVersion=RELEASE_5 HelloWorld.java > - * @compile -processor TestSourceVersion -proc:only -source 5 > -AExpectedVersion=RELEASE_5 HelloWorld.java > * @compile -processor TestSourceVersion -proc:only -source 1.6 > -AExpectedVersion=RELEASE_6 HelloWorld.java > * @compile -processor TestSourceVersion -proc:only -source 6 > -AExpectedVersion=RELEASE_6 HelloWorld.java > * @compile -processor TestSourceVersion -proc:only -source 1.7 > -AExpectedVersion=RELEASE_7 HelloWorld.java > * @compile -processor TestSourceVersion -proc:only -source 7 > -AExpectedVersion=RELEASE_7 HelloWorld.java > + * @compile -processor TestSourceVersion -proc:only -source 1.8 > -AExpectedVersion=RELEASE_8 HelloWorld.java > + * @compile -processor TestSourceVersion -proc:only -source 8 > -AExpectedVersion=RELEASE_8 HelloWorld.java > + * @compile -processor TestSourceVersion -proc:only -source 1.9 > -AExpectedVersion=RELEASE_9 HelloWorld.java > + * @compile -processor TestSourceVersion -proc:only -source 9 > -AExpectedVersion=RELEASE_9 HelloWorld.java > */ > > import java.util.Set; > --- > old/test/tools/javac/processing/warnings/TestSourceVersionWarnings.java 2014-01-14 > 16:50:17.000000000 -0800 > +++ > new/test/tools/javac/processing/warnings/TestSourceVersionWarnings.java 2014-01-14 > 16:50:17.000000000 -0800 > @@ -27,11 +27,7 @@ > * @summary Test that warnings about source versions are output as > expected. > * @author Joseph D. Darcy > * @compile TestSourceVersionWarnings.java > - * @compile/ref=gold_0.out -XDrawDiagnostics -processor > TestSourceVersionWarnings -proc:only -source 1.5 -Xlint:-options > HelloWorld.java > - * @compile/ref=gold_sv_warn_0_2.out -XDrawDiagnostics -processor > TestSourceVersionWarnings -proc:only -ASourceVersion=RELEASE_0 -source > 1.2 -Xlint:-options HelloWorld.java > - * @compile/ref=gold_sv_none.out -XDrawDiagnostics -processor > TestSourceVersionWarnings -proc:only -ASourceVersion=RELEASE_2 -source > 1.2 -Xlint:-options HelloWorld.java > - * @compile/ref=gold_sv_warn_2_3.out -XDrawDiagnostics -processor > TestSourceVersionWarnings -proc:only -ASourceVersion=RELEASE_2 -source > 1.3 -Xlint:-options HelloWorld.java > - * @compile/ref=gold_sv_none.out -XDrawDiagnostics -processor > TestSourceVersionWarnings -proc:only -ASourceVersion=RELEASE_5 -source > 1.5 -Xlint:-options HelloWorld.java > + * @compile/ref=gold_0.out -XDrawDiagnostics -processor > TestSourceVersionWarnings -proc:only -source 1.6 -Xlint:-options > HelloWorld.java > * @compile/ref=gold_sv_warn_5_6.out -XDrawDiagnostics -processor > TestSourceVersionWarnings -proc:only -ASourceVersion=RELEASE_5 -source > 1.6 -Xlint:-options HelloWorld.java > * @compile/ref=gold_sv_none.out -XDrawDiagnostics -processor > TestSourceVersionWarnings -proc:only -ASourceVersion=RELEASE_6 -source > 1.6 -Xlint:-options HelloWorld.java > * @compile/ref=gold_unsp_warn.out -XDrawDiagnostics -processor > TestSourceVersionWarnings -proc:only -ASourceVersion=RELEASE_6 -source > 1.6 -Xlint:-options -Aunsupported HelloWorld.java > --- old/test/tools/javac/stackmap/StackMapTest.java 2014-01-14 > 16:50:18.000000000 -0800 > +++ new/test/tools/javac/stackmap/StackMapTest.java 2014-01-14 > 16:50:18.000000000 -0800 > @@ -27,7 +27,7 @@ > * @summary The "method0" StackMap attribute should have two entries > instead of three > * @library /tools/javac/lib > * @build ToolBox > - * @run compile -source 6 -target 6 StackMapTest.java > + * @run compile StackMapTest.java > * @run main StackMapTest > */ > > @@ -48,7 +48,7 @@ > } > > public static void main(String args[]) throws Exception { > -// "${TESTJAVA}${FS}bin${FS}javac" ${TESTTOOLVMOPTS} -source 6 > -target 6 T4955930.java > +// "${TESTJAVA}${FS}bin${FS}javac" ${TESTTOOLVMOPTS} T4955930.java > > // "${TESTJAVA}${FS}bin${FS}javap" ${TESTTOOLVMOPTS} -verbose > T4955930 > ${TMP1} > Path pathToClass = Paths.get(System.getProperty("test.classes"), > --- old/test/tools/javac/unicode/Unmappable.java 2014-01-14 > 16:50:18.000000000 -0800 > +++ new/test/tools/javac/unicode/Unmappable.java 2014-01-14 > 16:50:18.000000000 -0800 > @@ -27,8 +27,6 @@ > * @summary diagnose encoding errors in Java source files > * @author gafter > * > - * @compile -encoding ascii -source 1.5 Unmappable.java > - * @compile/fail -Werror -encoding ascii -source 1.5 Unmappable.java > * @compile/fail -encoding ascii Unmappable.java > */ > > --- old/test/tools/javap/output/Tester.java 2014-01-14 > 16:50:19.000000000 -0800 > +++ new/test/tools/javap/output/Tester.java 2014-01-14 > 16:50:19.000000000 -0800 > @@ -1,5 +1,5 @@ > /* > - * Copyright (c) 2013, Oracle and/or its affiliates. All rights > reserved. > + * Copyright (c) 2013, 2014, Oracle and/or its affiliates. All rights > reserved. > * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > * > * This code is free software; you can redistribute it and/or modify it > @@ -271,7 +271,7 @@ > */ > protected void compileTestFile() { > String path = javaFile.getPath(); > - String params[] = { "-source", "1.8", "-g", path }; > + String params[] = {"-g", path }; > int rc = com.sun.tools.javac.Main.compile(params); > if (rc != 0) > throw new Error("compilation failed. rc=" + rc); > --- old/test/tools/javap/typeAnnotations/JSR175Annotations.java > 2014-01-14 16:50:19.000000000 -0800 > +++ new/test/tools/javap/typeAnnotations/JSR175Annotations.java > 2014-01-14 16:50:19.000000000 -0800 > @@ -1,5 +1,5 @@ > /* > - * Copyright (c) 2008, 2013, Oracle and/or its affiliates. All rights > reserved. > + * Copyright (c) 2008, 2014, Oracle and/or its affiliates. All rights > reserved. > * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > * > * This code is free software; you can redistribute it and/or modify it > @@ -114,7 +114,7 @@ > } > > File compileTestFile(File f) { > - int rc = com.sun.tools.javac.Main.compile(new String[] { > "-source", "1.8", "-g", f.getPath() }); > + int rc = com.sun.tools.javac.Main.compile(new String[] {"-g", > f.getPath() }); > if (rc != 0) > throw new Error("compilation failed. rc=" + rc); > String path = f.getPath(); > --- old/test/tools/javap/typeAnnotations/NewArray.java 2014-01-14 > 16:50:19.000000000 -0800 > +++ new/test/tools/javap/typeAnnotations/NewArray.java 2014-01-14 > 16:50:19.000000000 -0800 > @@ -1,5 +1,5 @@ > /* > - * Copyright (c) 2008, 2013, Oracle and/or its affiliates. All rights > reserved. > + * Copyright (c) 2008, 2014, Oracle and/or its affiliates. All rights > reserved. > * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > * > * This code is free software; you can redistribute it and/or modify it > @@ -102,7 +102,7 @@ > } > > File compileTestFile(File f) { > - int rc = com.sun.tools.javac.Main.compile(new String[] { > "-source", "1.8", "-g", f.getPath() }); > + int rc = com.sun.tools.javac.Main.compile(new String[] {"-g", > f.getPath() }); > if (rc != 0) > throw new Error("compilation failed. rc=" + rc); > String path = f.getPath(); > --- old/test/tools/javap/typeAnnotations/Presence.java 2014-01-14 > 16:50:20.000000000 -0800 > +++ new/test/tools/javap/typeAnnotations/Presence.java 2014-01-14 > 16:50:20.000000000 -0800 > @@ -1,5 +1,5 @@ > /* > - * Copyright (c) 2008, 2013, Oracle and/or its affiliates. All rights > reserved. > + * Copyright (c) 2008, 2014, Oracle and/or its affiliates. All rights > reserved. > * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > * > * This code is free software; you can redistribute it and/or modify it > @@ -180,7 +180,7 @@ > } > > File compileTestFile(File f) { > - int rc = com.sun.tools.javac.Main.compile(new String[] { > "-source", "1.8", "-g", f.getPath() }); > + int rc = com.sun.tools.javac.Main.compile(new String[] {"-g", > f.getPath() }); > if (rc != 0) > throw new Error("compilation failed. rc=" + rc); > String path = f.getPath(); > --- old/test/tools/javap/typeAnnotations/PresenceInner.java 2014-01-14 > 16:50:20.000000000 -0800 > +++ new/test/tools/javap/typeAnnotations/PresenceInner.java 2014-01-14 > 16:50:20.000000000 -0800 > @@ -1,5 +1,5 @@ > /* > - * Copyright (c) 2009, 2013, Oracle and/or its affiliates. All rights > reserved. > + * Copyright (c) 2009, 2014, Oracle and/or its affiliates. All rights > reserved. > * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > * > * This code is free software; you can redistribute it and/or modify it > @@ -149,7 +149,7 @@ > } > > File compileTestFile(File f) { > - int rc = com.sun.tools.javac.Main.compile(new String[] { > "-source", "1.8", "-g", f.getPath() }); > + int rc = com.sun.tools.javac.Main.compile(new String[] {"-g", > f.getPath() }); > if (rc != 0) > throw new Error("compilation failed. rc=" + rc); > String path = f.getPath(); > --- old/test/tools/javap/typeAnnotations/TypeCasts.java 2014-01-14 > 16:50:20.000000000 -0800 > +++ new/test/tools/javap/typeAnnotations/TypeCasts.java 2014-01-14 > 16:50:20.000000000 -0800 > @@ -1,5 +1,5 @@ > /* > - * Copyright (c) 2009, 2013, Oracle and/or its affiliates. All rights > reserved. > + * Copyright (c) 2009, 2014, Oracle and/or its affiliates. All rights > reserved. > * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > * > * This code is free software; you can redistribute it and/or modify it > @@ -117,7 +117,7 @@ > } > > File compileTestFile(File f) { > - int rc = com.sun.tools.javac.Main.compile(new String[] { > "-source", "1.8", "-g", f.getPath() }); > + int rc = com.sun.tools.javac.Main.compile(new String[] {"-g", > f.getPath() }); > if (rc != 0) > throw new Error("compilation failed. rc=" + rc); > String path = f.getPath(); > --- old/test/tools/javap/typeAnnotations/Visibility.java 2014-01-14 > 16:50:21.000000000 -0800 > +++ new/test/tools/javap/typeAnnotations/Visibility.java 2014-01-14 > 16:50:21.000000000 -0800 > @@ -1,5 +1,5 @@ > /* > - * Copyright (c) 2008, 2013, Oracle and/or its affiliates. All rights > reserved. > + * Copyright (c) 2008, 2014, Oracle and/or its affiliates. All rights > reserved. > * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > * > * This code is free software; you can redistribute it and/or modify it > @@ -108,7 +108,7 @@ > } > > File compileTestFile(File f) { > - int rc = com.sun.tools.javac.Main.compile(new String[] { > "-source", "1.8", "-g", f.getPath() }); > + int rc = com.sun.tools.javac.Main.compile(new String[] {"-g", > f.getPath() }); > if (rc != 0) > throw new Error("compilation failed. rc=" + rc); > String path = f.getPath(); > --- old/test/tools/javap/typeAnnotations/Wildcards.java 2014-01-14 > 16:50:22.000000000 -0800 > +++ new/test/tools/javap/typeAnnotations/Wildcards.java 2014-01-14 > 16:50:22.000000000 -0800 > @@ -1,5 +1,5 @@ > /* > - * Copyright (c) 2009, 2013, Oracle and/or its affiliates. All rights > reserved. > + * Copyright (c) 2009, 2014, Oracle and/or its affiliates. All rights > reserved. > * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > * > * This code is free software; you can redistribute it and/or modify it > @@ -139,7 +139,7 @@ > } > > File compileTestFile(File f) { > - int rc = com.sun.tools.javac.Main.compile(new String[] { > "-source", "1.8", "-g", f.getPath() }); > + int rc = com.sun.tools.javac.Main.compile(new String[] {"-g", > f.getPath() }); > if (rc != 0) > throw new Error("compilation failed. rc=" + rc); > String path = f.getPath(); > --- old/test/tools/javac/Capture.java 2014-01-14 16:50:22.000000000 > -0800 > +++ /dev/null 2014-01-13 10:19:39.230183767 -0800 > @@ -1,46 +0,0 @@ > -/* > - * Copyright (c) 2002, 2004, Oracle and/or its affiliates. All rights > reserved. > - * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > - * > - * This code is free software; you can redistribute it and/or modify it > - * under the terms of the GNU General Public License version 2 only, as > - * published by the Free Software Foundation. > - * > - * This code is distributed in the hope that it will be useful, but > WITHOUT > - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or > - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License > - * version 2 for more details (a copy is included in the LICENSE file > that > - * accompanied this code). > - * > - * You should have received a copy of the GNU General Public License > version > - * 2 along with this work; if not, write to the Free Software > Foundation, > - * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. > - * > - * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA > 94065 USA > - * or visit www.oracle.com if you need additional information or have > any > - * questions. > - */ > - > -/* > - * @test > - * @bug 4441338 4994508 > - * @summary Captured variable synthetic parameters should be passed > before explicit params. > - * @author gafter > - * > - * @compile -source 1.4 -target 1.4 Capture.java > - * @run main Capture > - */ > - > -public class Capture { > - final int k; > - Capture(int n) { > - k = n; > - } > - public static void main(String args[]) { > - final int j; > - int k1 = new Capture(2 + (j=3)){ > - int get () {return k+j;} > - }.get(); > - if (k1 != 8) throw new Error("k1 = " + k1); > - } > -} > --- old/test/tools/javac/Source5.java 2014-01-14 16:50:23.000000000 > -0800 > +++ /dev/null 2014-01-13 10:19:39.230183767 -0800 > @@ -1,39 +0,0 @@ > -/* > - * Copyright (c) 2004, Oracle and/or its affiliates. All rights > reserved. > - * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > - * > - * This code is free software; you can redistribute it and/or modify it > - * under the terms of the GNU General Public License version 2 only, as > - * published by the Free Software Foundation. > - * > - * This code is distributed in the hope that it will be useful, but > WITHOUT > - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or > - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License > - * version 2 for more details (a copy is included in the LICENSE file > that > - * accompanied this code). > - * > - * You should have received a copy of the GNU General Public License > version > - * 2 along with this work; if not, write to the Free Software > Foundation, > - * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. > - * > - * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA > 94065 USA > - * or visit www.oracle.com if you need additional information or have > any > - * questions. > - */ > - > -/* > - * @test > - * @bug 5044157 > - * @summary please accept -source 5 and -target 5 > - * @author Peter von der Ah? > - * > - * @compile -source 5 -target 5 -encoding iso-8859-1 Source5.java > - * @run main Source5 > - */ > - > -public enum Source5 { > - JDK5; > - public static void main(String[] args) { > - System.out.println("Hello, world!"); > - } > -} > --- old/test/tools/javac/processing/warnings/gold_sv_warn_0_2.out > 2014-01-14 16:50:23.000000000 -0800 > +++ /dev/null 2014-01-13 10:19:39.230183767 -0800 > @@ -1,2 +0,0 @@ > -- compiler.warn.proc.processor.incompatible.source.version: > RELEASE_0, TestSourceVersionWarnings, 1.2 > -1 warning > --- old/test/tools/javac/processing/warnings/gold_sv_warn_2_3.out > 2014-01-14 16:50:23.000000000 -0800 > +++ /dev/null 2014-01-13 10:19:39.230183767 -0800 > @@ -1,2 +0,0 @@ > -- compiler.warn.proc.processor.incompatible.source.version: > RELEASE_2, TestSourceVersionWarnings, 1.3 > -1 warning > --- old/test/tools/javac/varargs/warning/Warn1.java 2014-01-14 > 16:50:23.000000000 -0800 > +++ /dev/null 2014-01-13 10:19:39.230183767 -0800 > @@ -1,42 +0,0 @@ > -/* > - * Copyright (c) 2004, 2010, Oracle and/or its affiliates. All rights > reserved. > - * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > - * > - * This code is free software; you can redistribute it and/or modify it > - * under the terms of the GNU General Public License version 2 only, as > - * published by the Free Software Foundation. > - * > - * This code is distributed in the hope that it will be useful, but > WITHOUT > - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or > - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License > - * version 2 for more details (a copy is included in the LICENSE file > that > - * accompanied this code). > - * > - * You should have received a copy of the GNU General Public License > version > - * 2 along with this work; if not, write to the Free Software > Foundation, > - * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. > - * > - * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA > 94065 USA > - * or visit www.oracle.com if you need additional information or have > any > - * questions. > - */ > - > -/* > - * @test > - * @bug 5035307 > - * @summary fixed-arity warning given too often > - * @author gafter > - * > - * @compile -Werror -source 1.4 -Xlint:-options Warn1.java > - */ > - > -package varargs.warning.warn1; > - > -import java.util.List; > -import java.util.Arrays; > - > -class Warn1 { > - void f(String[] args) { > - List l = java.util.Arrays.asList(args); > - } > -} > From joel.franck at oracle.com Fri Jan 17 00:39:20 2014 From: joel.franck at oracle.com (Joel Borggren-Franck) Date: Fri, 17 Jan 2014 09:39:20 +0100 Subject: JDK 9 RFR of JDK-8031745: Remove unneeded/obsolete -source/-target options in javac tests, part 1 In-Reply-To: <52D80F88.40102@oracle.com> References: <52D5DDD1.60400@oracle.com> <52D764E1.5010003@oracle.com> <52D80F88.40102@oracle.com> Message-ID: <20140117083920.GE5294@oracle.com> Hi, On 2014-01-16, Brian Goetz wrote: > Overall, I'm in favor of simplifications like these; fully > constant-propagating these means simpler code paths and fewer > opportunities for bad assumptions. And simplifications often beget > further simplifications. The only reason I can think of to hesitate > is if we think we're going to bring back some of these specific > options in the future; then the historical context might be lost. > VCS to the rescue. If something is really odd, I agree a comment could be nice reminding our future selves to look at the history of the code. > Maybe a block of comments in Source/Target outlining some of the > historical anomalies might help preserve the history without > infecting the code. > cheers /Joel From daniel.smith at oracle.com Tue Jan 21 09:35:00 2014 From: daniel.smith at oracle.com (Dan Smith) Date: Tue, 21 Jan 2014 10:35:00 -0700 Subject: Compilation failure on JDK 8 involving inferred generic type In-Reply-To: <52CFF0B3.4080402@oracle.com> References: <52CFF0B3.4080402@oracle.com> Message-ID: <000D7133-A38D-4E40-BC68-D89DB25F774B@oracle.com> This looks like a manifestation of JDK-8026527. We start with a Class. We perform capture -- Class. Now inference concludes that I=CAP, and checks whether CAP is a subtype of Input. It is not -- the raw upper bound 'Input' is not a subtype of any parameterized type. JDK 8 has not addressed JDK-8026527, but when programs depend on this bug, they've entered an ad hoc space where the compiler does whatever it thinks is reasonable. It does not surprise me, with the changes that were made in inference for 8, that something subtle has changed leading to different ad hoc behavior. (I will say it is weird, though, that compilation depends on whether the target type of the assignment is raw or not.) ?Dan On Jan 10, 2014, at 6:08 AM, Vicente-Arturo Romero-Zaldivar wrote: > Hi Gunnar, > > Yes this is the right list, sorry for the late response. I will look at it. > > Thanks, > Vicente > > On 10/01/14 12:42, Gunnar Morling wrote: >> Hi, >> >> Does anyone have an idea whether this is a regression or an intentional change? My apologies, if this is not the right place to ask this question (I'd be happy then about a pointer where to post it instead). >> >> Many thanks, >> >> --Gunnar >> >> >> >> 2014/1/3 Gunnar Morling >> Hi, >> >> I'm investigating a compilation error which I'm seeing when compiling the Bean Validation TCK using JDK 8 (build 121). The following example shows the issue: >> >> public class GenericsTest { >> >> public class Input> {} >> >> public class Output> {} >> >> public class OutputContainer> {} >> >> public , I extends Input> OutputContainer process( >> Class inputType) { >> return null; >> } >> >> public void testProcess() { >> Class inputType = null; >> >> //next line compiles with source level 1.7 but fails with source level 1.8 >> OutputContainer outputContainer = process( inputType ); >> } >> } >> >> This code used to compile with JDK 7 and it also does with JDK 8, when using 1.7 as source level. But it fails with source level 1.8, saying: >> >> "incompatible types: inferred type does not conform to upper bound(s)" >> >> I can make the code compile when declaring the outputContainer variable of the raw type OutputContainer instead of declaring it with the wildcard parameter. >> >> Is this an intentional change in JDK 8 or is it some kind of regression? If it is intentional, maybe the error message should be a bit more descriptive, mentioning the concerned inferred type and the bounds? >> >> Many thanks, >> >> --Gunnar >> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20140121/9e117ac4/attachment.html From martinrb at google.com Tue Jan 21 10:41:25 2014 From: martinrb at google.com (Martin Buchholz) Date: Tue, 21 Jan 2014 10:41:25 -0800 Subject: JLS string concatenation clarification In-Reply-To: References: Message-ID: Can we agree that when String empty = ""; then s + empty should be permitted to be the same object as s. On Tue, Jan 21, 2014 at 9:59 AM, Louis Wasserman wrote: > JLS 15.18.1 states: > >> The String object is newly created (?12.5) >> unless the expression is a compile-time constant expression (?15.28 >> ). > > JLS 12.5 states: > >> Execution of a string concatenation operator (?15.18.1) >> that is not part of a constant expression (?15.28) >> sometimes creates a new String object to represent the result. > > > It's not clear to me, from reading this, whether string concatenation with > + *always* creates a new String object or *sometimes *creates a new > String object. 15.18.1 seems to imply always, but 12.5 says "sometimes." > > My understanding is that String.concat used to be used for string > concatenation, and String.concat currently returns its receiver if its > argument is the empty string. This seems to be evidence for the > "sometimes" interpretation. > > -- > Louis Wasserman > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20140121/5084c269/attachment.html From lana.steuck at oracle.com Tue Jan 21 11:03:11 2014 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Tue, 21 Jan 2014 19:03:11 +0000 Subject: hg: jdk8/tl: 5 new changesets Message-ID: <20140121190312.C650E625FA@hg.openjdk.java.net> Changeset: ca4612164195 Author: lana Date: 2014-01-08 11:36 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/ca4612164195 Merge Changeset: b5e1dad69605 Author: jeff Date: 2014-01-13 14:41 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/b5e1dad69605 7129980: Third Party License Readme update for JDK8 Reviewed-by: lana, tbell ! THIRD_PARTY_README Changeset: 6ac7d4011e8a Author: lana Date: 2014-01-13 22:31 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/6ac7d4011e8a Merge Changeset: 790bbd46b201 Author: lana Date: 2014-01-15 10:45 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/790bbd46b201 Merge Changeset: 0623ae55afff Author: katleman Date: 2014-01-17 15:52 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/0623ae55afff Added tag jdk8-b124 for changeset 790bbd46b201 ! .hgtags From lana.steuck at oracle.com Tue Jan 21 11:03:15 2014 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Tue, 21 Jan 2014 19:03:15 +0000 Subject: hg: jdk8/tl/langtools: 6 new changesets Message-ID: <20140121190344.1A946625FF@hg.openjdk.java.net> Changeset: d5aab8300d3b Author: katleman Date: 2014-01-10 08:32 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d5aab8300d3b Added tag jdk8-b123 for changeset a345cf28faca ! .hgtags Changeset: 4a5e16002234 Author: lana Date: 2014-01-08 11:39 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4a5e16002234 Merge Changeset: e90611913bb1 Author: jeff Date: 2014-01-13 14:44 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e90611913bb1 7129980: Third Party License Readme update for JDK8 Reviewed-by: lana, tbell ! THIRD_PARTY_README Changeset: 91e6cd536c34 Author: lana Date: 2014-01-13 22:33 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/91e6cd536c34 Merge Changeset: 436176151e85 Author: lana Date: 2014-01-15 10:59 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/436176151e85 Merge Changeset: 9e35f82eec22 Author: katleman Date: 2014-01-17 15:53 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9e35f82eec22 Added tag jdk8-b124 for changeset 436176151e85 ! .hgtags From lana.steuck at oracle.com Tue Jan 21 11:03:11 2014 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Tue, 21 Jan 2014 19:03:11 +0000 Subject: hg: jdk8/tl/corba: 5 new changesets Message-ID: <20140121190318.21207625FB@hg.openjdk.java.net> Changeset: afecd2878aee Author: katleman Date: 2014-01-10 08:31 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/afecd2878aee Added tag jdk8-b123 for changeset 1ecd4619f60c ! .hgtags Changeset: b509e2e0fc41 Author: jeff Date: 2014-01-13 14:42 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/b509e2e0fc41 7129980: Third Party License Readme update for JDK8 Reviewed-by: lana, tbell ! THIRD_PARTY_README Changeset: 33e3d3425095 Author: lana Date: 2014-01-13 22:31 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/33e3d3425095 Merge Changeset: 7b45151c7a05 Author: lana Date: 2014-01-15 10:45 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/7b45151c7a05 Merge Changeset: 6b66ffd36885 Author: katleman Date: 2014-01-17 15:52 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/6b66ffd36885 Added tag jdk8-b124 for changeset 7b45151c7a05 ! .hgtags From lana.steuck at oracle.com Tue Jan 21 11:03:11 2014 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Tue, 21 Jan 2014 19:03:11 +0000 Subject: hg: jdk8/tl/nashorn: 4 new changesets Message-ID: <20140121190322.3C85A625FC@hg.openjdk.java.net> Changeset: 3356919b1639 Author: jeff Date: 2014-01-13 14:45 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/3356919b1639 7129980: Third Party License Readme update for JDK8 Reviewed-by: lana, tbell ! THIRD_PARTY_README Changeset: aefba9e5e35c Author: lana Date: 2014-01-13 22:33 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/aefba9e5e35c Merge Changeset: 7346abe2ea03 Author: lana Date: 2014-01-15 10:59 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/7346abe2ea03 Merge Changeset: 40192ec6af87 Author: katleman Date: 2014-01-17 15:53 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/40192ec6af87 Added tag jdk8-b124 for changeset 7346abe2ea03 ! .hgtags From lana.steuck at oracle.com Tue Jan 21 11:03:17 2014 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Tue, 21 Jan 2014 19:03:17 +0000 Subject: hg: jdk8/tl/jaxws: 5 new changesets Message-ID: <20140121190335.DFCF8625FE@hg.openjdk.java.net> Changeset: 241e4effed6d Author: katleman Date: 2014-01-10 08:32 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/241e4effed6d Added tag jdk8-b123 for changeset 91f5c542ccad ! .hgtags Changeset: c71b6b41a2a1 Author: jeff Date: 2014-01-13 14:43 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/c71b6b41a2a1 7129980: Third Party License Readme update for JDK8 Reviewed-by: lana, tbell ! THIRD_PARTY_README Changeset: 9ed8a0577511 Author: lana Date: 2014-01-13 22:31 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/9ed8a0577511 Merge Changeset: ef71ecbcd7bc Author: lana Date: 2014-01-15 10:49 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/ef71ecbcd7bc Merge Changeset: b14885a461b3 Author: katleman Date: 2014-01-17 15:53 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/b14885a461b3 Added tag jdk8-b124 for changeset ef71ecbcd7bc ! .hgtags From lana.steuck at oracle.com Tue Jan 21 11:03:11 2014 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Tue, 21 Jan 2014 19:03:11 +0000 Subject: hg: jdk8/tl/jaxp: 5 new changesets Message-ID: <20140121190335.3FF2F625FD@hg.openjdk.java.net> Changeset: 1a28f773c894 Author: katleman Date: 2014-01-10 08:31 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/1a28f773c894 Added tag jdk8-b123 for changeset 4e35b5b6d2e5 ! .hgtags Changeset: d906d69e24a3 Author: jeff Date: 2014-01-13 14:43 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/d906d69e24a3 7129980: Third Party License Readme update for JDK8 Reviewed-by: lana, tbell ! THIRD_PARTY_README Changeset: a7c0452ab987 Author: lana Date: 2014-01-13 22:31 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/a7c0452ab987 Merge Changeset: 83bb924238f8 Author: lana Date: 2014-01-15 10:49 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/83bb924238f8 Merge Changeset: 5a4e9ef8673d Author: katleman Date: 2014-01-17 15:53 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/5a4e9ef8673d Added tag jdk8-b124 for changeset 83bb924238f8 ! .hgtags From lana.steuck at oracle.com Tue Jan 21 11:03:12 2014 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Tue, 21 Jan 2014 19:03:12 +0000 Subject: hg: jdk8/tl/hotspot: 10 new changesets Message-ID: <20140121190346.1F25862600@hg.openjdk.java.net> Changeset: c89630a122b4 Author: katleman Date: 2014-01-10 08:31 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c89630a122b4 Added tag jdk8-b123 for changeset 591135a7d6f9 ! .hgtags Changeset: f898fdfc08a5 Author: jeff Date: 2014-01-13 14:42 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f898fdfc08a5 7129980: Third Party License Readme update for JDK8 Reviewed-by: lana, tbell ! THIRD_PARTY_README Changeset: b99955ea4b91 Author: lana Date: 2014-01-13 22:31 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b99955ea4b91 Merge Changeset: 9d39e8a8ff61 Author: amurillo Date: 2013-12-27 07:51 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9d39e8a8ff61 8031060: new hotspot build - hs25-b66 Reviewed-by: jcoomes ! make/hotspot_version Changeset: c3f3cfd39184 Author: hseigel Date: 2014-01-10 12:11 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c3f3cfd39184 8031059: invokestatic: ICCE trying to invoke static method when it clashes with an abstract method inherited from an interface Summary: Do not create AME overpass if there is a matching static method Reviewed-by: lfoltan, coleenp, kamg ! src/share/vm/classfile/defaultMethods.cpp Changeset: 9b9816164447 Author: amurillo Date: 2014-01-13 15:52 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9b9816164447 Merge Changeset: ac902fca803b Author: amurillo Date: 2014-01-13 15:52 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ac902fca803b Added tag hs25-b66 for changeset 9b9816164447 ! .hgtags Changeset: 2c3130311ffa Author: amurillo Date: 2014-01-14 11:22 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2c3130311ffa Merge Changeset: df333ee12bba Author: lana Date: 2014-01-15 10:48 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/df333ee12bba Merge Changeset: e2e6ca7e0ea6 Author: katleman Date: 2014-01-17 15:52 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e2e6ca7e0ea6 Added tag jdk8-b124 for changeset df333ee12bba ! .hgtags From lana.steuck at oracle.com Tue Jan 21 11:04:00 2014 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Tue, 21 Jan 2014 19:04:00 +0000 Subject: hg: jdk8/tl/jdk: 8 new changesets Message-ID: <20140121190556.93AC862601@hg.openjdk.java.net> Changeset: 9683419eddef Author: lana Date: 2014-01-08 11:39 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9683419eddef Merge Changeset: 2551e7290450 Author: jeff Date: 2014-01-13 14:44 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2551e7290450 7129980: Third Party License Readme update for JDK8 Reviewed-by: lana, tbell ! THIRD_PARTY_README Changeset: 01a6b4654550 Author: lana Date: 2014-01-13 22:32 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/01a6b4654550 Merge Changeset: 2a3afe1ec514 Author: rgallard Date: 2014-01-09 16:10 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2a3afe1ec514 8026909: Retire Some Rarely Used GC Combintations Summary: Fix only affects java command, nroff page, OpenJDK Reviewed-by: maxelsso ! src/bsd/doc/man/java.1 ! src/linux/doc/man/java.1 ! src/solaris/doc/sun/man/man1/java.1 Changeset: acc59aae7992 Author: katleman Date: 2014-01-14 11:56 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/acc59aae7992 Merge Changeset: f1f3596239a4 Author: lana Date: 2014-01-15 10:57 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f1f3596239a4 Merge - src/bsd/doc/man/ja/kinit.1 - src/bsd/doc/man/ja/klist.1 - src/bsd/doc/man/ja/ktab.1 Changeset: ae303640bc1c Author: lana Date: 2014-01-16 10:16 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ae303640bc1c Merge - src/bsd/doc/man/ja/kinit.1 - src/bsd/doc/man/ja/klist.1 - src/bsd/doc/man/ja/ktab.1 Changeset: 3e9b46280c16 Author: katleman Date: 2014-01-17 15:53 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3e9b46280c16 Added tag jdk8-b124 for changeset ae303640bc1c ! .hgtags From alex.buckley at oracle.com Tue Jan 21 16:45:52 2014 From: alex.buckley at oracle.com (Alex Buckley) Date: Tue, 21 Jan 2014 16:45:52 -0800 Subject: JLS string concatenation clarification In-Reply-To: References: Message-ID: <52DF14C0.1000601@oracle.com> No, we can't. There are three levels to consider: - "Real" constant expressions like 3+"". They can avoid creating a new String object per https://bugs.openjdk.java.net/browse/JDK-4836025. - "Semi" constant expressions like s+"". Concatenating the empty string literal "" with a String expression is mentioned in https://bugs.openjdk.java.net/browse/JDK-4036535. The expectation (per JLS1) that a new String object is always created in this case is misplaced (per the JDK's actual behavior). But, the JLS never clarified this. - "Not" constant expressions: s+empty. Not detectable in general. Always creates a new String object. Alex On 1/21/2014 10:41 AM, Martin Buchholz wrote: > Can we agree that when > String empty = ""; > then > s + empty > should be permitted to be the same object as s. > > > On Tue, Jan 21, 2014 at 9:59 AM, Louis Wasserman > wrote: > > JLS 15.18.1 states: > > The |String| object is newly created (?12.5 > ) > unless the expression is a compile-time constant expression > (?15.28 > ). > > JLS 12.5 states: > > Execution of a string concatenation operator (?15.18.1 > ) > that is not part of a constant expression (?15.28 > ) > sometimes creates a new |String| object to represent the result. > > > It's not clear to me, from reading this, whether string > concatenation with + /always/ creates a new String object or > /sometimes /creates a new String object. 15.18.1 seems to imply > always, but 12.5 says "sometimes." > > My understanding is that String.concat used to be used for string > concatenation, and String.concat currently returns its receiver if > its argument is the empty string. This seems to be evidence for the > "sometimes" interpretation. > > -- > Louis Wasserman > > From forax at univ-mlv.fr Tue Jan 21 17:02:13 2014 From: forax at univ-mlv.fr (Remi Forax) Date: Wed, 22 Jan 2014 02:02:13 +0100 Subject: JLS string concatenation clarification In-Reply-To: <52DF14C0.1000601@oracle.com> References: <52DF14C0.1000601@oracle.com> Message-ID: <52DF1895.3090402@univ-mlv.fr> On 01/22/2014 01:45 AM, Alex Buckley wrote: > No, we can't. There are three levels to consider: > > - "Real" constant expressions like 3+"". They can avoid creating a new > String object per https://bugs.openjdk.java.net/browse/JDK-4836025. > > - "Semi" constant expressions like s+"". Concatenating the empty > string literal "" with a String expression is mentioned in > https://bugs.openjdk.java.net/browse/JDK-4036535. The expectation (per > JLS1) that a new String object is always created in this case is > misplaced (per the JDK's actual behavior). But, the JLS never > clarified this. > > - "Not" constant expressions: s+empty. Not detectable in general. > Always creates a new String object. > and the compiler (javac) emits the instructions to create a new String but the VM may not create the String after the code is JITed is the String doesn't escape. > Alex R?mi > > On 1/21/2014 10:41 AM, Martin Buchholz wrote: >> Can we agree that when >> String empty = ""; >> then >> s + empty >> should be permitted to be the same object as s. >> >> >> On Tue, Jan 21, 2014 at 9:59 AM, Louis Wasserman > > wrote: >> >> JLS 15.18.1 states: >> >> The |String| object is newly created (?12.5 >> ) >> unless the expression is a compile-time constant expression >> (?15.28 >> ). >> >> JLS 12.5 states: >> >> Execution of a string concatenation operator (?15.18.1 >> ) >> that is not part of a constant expression (?15.28 >> ) >> sometimes creates a new |String| object to represent the result. >> >> >> It's not clear to me, from reading this, whether string >> concatenation with + /always/ creates a new String object or >> /sometimes /creates a new String object. 15.18.1 seems to imply >> always, but 12.5 says "sometimes." >> >> My understanding is that String.concat used to be used for string >> concatenation, and String.concat currently returns its receiver if >> its argument is the empty string. This seems to be evidence for the >> "sometimes" interpretation. >> >> -- >> Louis Wasserman >> >> From martinrb at google.com Tue Jan 21 17:09:47 2014 From: martinrb at google.com (Martin Buchholz) Date: Tue, 21 Jan 2014 17:09:47 -0800 Subject: JLS string concatenation clarification In-Reply-To: <52DF14C0.1000601@oracle.com> References: <52DF14C0.1000601@oracle.com> Message-ID: So, the context is that some of us have noticed that compiling x + y where x and y are both Strings, to (x == null ? "null" : x).concat(y) is much more efficient than creating a StringBuilder, and the vast majority of our users would thank us for implementing that optimization in javac. The fact that Strings even have an object identity is essentially a bug. On Tue, Jan 21, 2014 at 4:45 PM, Alex Buckley wrote: > No, we can't. There are three levels to consider: > > - "Real" constant expressions like 3+"". They can avoid creating a new > String object per https://bugs.openjdk.java.net/browse/JDK-4836025. > > - "Semi" constant expressions like s+"". Concatenating the empty string > literal "" with a String expression is mentioned in > https://bugs.openjdk.java.net/browse/JDK-4036535. The expectation (per > JLS1) that a new String object is always created in this case is misplaced > (per the JDK's actual behavior). But, the JLS never clarified this. > > - "Not" constant expressions: s+empty. Not detectable in general. Always > creates a new String object. > > Alex > > > On 1/21/2014 10:41 AM, Martin Buchholz wrote: > >> Can we agree that when >> String empty = ""; >> then >> s + empty >> should be permitted to be the same object as s. >> >> >> On Tue, Jan 21, 2014 at 9:59 AM, Louis Wasserman > > wrote: >> >> JLS 15.18.1 states: >> >> The |String| object is newly created (?12.5 >> > 12.html#jls-12.5>) >> >> unless the expression is a compile-time constant expression >> (?15.28 >> > 15.html#jls-15.28>). >> >> >> JLS 12.5 states: >> >> Execution of a string concatenation operator (?15.18.1 >> > 15.html#jls-15.18.1>) >> >> that is not part of a constant expression (?15.28 >> > 15.html#jls-15.28>) >> >> sometimes creates a new |String| object to represent the result. >> >> >> It's not clear to me, from reading this, whether string >> concatenation with + /always/ creates a new String object or >> /sometimes /creates a new String object. 15.18.1 seems to imply >> >> always, but 12.5 says "sometimes." >> >> My understanding is that String.concat used to be used for string >> concatenation, and String.concat currently returns its receiver if >> its argument is the empty string. This seems to be evidence for the >> "sometimes" interpretation. >> >> -- >> Louis Wasserman >> >> >> -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20140121/898b5b56/attachment.html From vitalyd at gmail.com Tue Jan 21 17:18:13 2014 From: vitalyd at gmail.com (Vitaly Davidovich) Date: Tue, 21 Jan 2014 20:18:13 -0500 Subject: JLS string concatenation clarification In-Reply-To: References: <52DF14C0.1000601@oracle.com> Message-ID: Much more efficient after jit compiles it as well? At least C2 has optos specifically covering scenarios where a StringBuilder is used for intermediate string manipulation. I'd think something as simple as this case would be handled well, although I haven't checked. Sent from my phone On Jan 21, 2014 8:10 PM, "Martin Buchholz" wrote: > So, the context is that some of us have noticed that compiling > x + y > where x and y are both Strings, to > (x == null ? "null" : x).concat(y) > is much more efficient than creating a StringBuilder, and the vast > majority of our users would thank us for implementing that optimization in > javac. The fact that Strings even have an object identity is essentially a > bug. > > > > On Tue, Jan 21, 2014 at 4:45 PM, Alex Buckley wrote: > >> No, we can't. There are three levels to consider: >> >> - "Real" constant expressions like 3+"". They can avoid creating a new >> String object per https://bugs.openjdk.java.net/browse/JDK-4836025. >> >> - "Semi" constant expressions like s+"". Concatenating the empty string >> literal "" with a String expression is mentioned in >> https://bugs.openjdk.java.net/browse/JDK-4036535. The expectation (per >> JLS1) that a new String object is always created in this case is misplaced >> (per the JDK's actual behavior). But, the JLS never clarified this. >> >> - "Not" constant expressions: s+empty. Not detectable in general. Always >> creates a new String object. >> >> Alex >> >> >> On 1/21/2014 10:41 AM, Martin Buchholz wrote: >> >>> Can we agree that when >>> String empty = ""; >>> then >>> s + empty >>> should be permitted to be the same object as s. >>> >>> >>> On Tue, Jan 21, 2014 at 9:59 AM, Louis Wasserman >> > wrote: >>> >>> JLS 15.18.1 states: >>> >>> The |String| object is newly created (?12.5 >>> >> 12.html#jls-12.5>) >>> >>> unless the expression is a compile-time constant expression >>> (?15.28 >>> >> 15.html#jls-15.28>). >>> >>> >>> JLS 12.5 states: >>> >>> Execution of a string concatenation operator (?15.18.1 >>> >> 15.html#jls-15.18.1>) >>> >>> that is not part of a constant expression (?15.28 >>> >> 15.html#jls-15.28>) >>> >>> sometimes creates a new |String| object to represent the result. >>> >>> >>> It's not clear to me, from reading this, whether string >>> concatenation with + /always/ creates a new String object or >>> /sometimes /creates a new String object. 15.18.1 seems to imply >>> >>> always, but 12.5 says "sometimes." >>> >>> My understanding is that String.concat used to be used for string >>> concatenation, and String.concat currently returns its receiver if >>> its argument is the empty string. This seems to be evidence for the >>> "sometimes" interpretation. >>> >>> -- >>> Louis Wasserman >>> >>> >>> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20140121/b0a6d6f4/attachment-0001.html From erik.joelsson at oracle.com Wed Jan 22 03:13:55 2014 From: erik.joelsson at oracle.com (erik.joelsson at oracle.com) Date: Wed, 22 Jan 2014 11:13:55 +0000 Subject: hg: jdk8/tl/jdk: 8032217: failure in man page processing Message-ID: <20140122111510.5171762655@hg.openjdk.java.net> Changeset: ff56039c4870 Author: erikj Date: 2014-01-22 12:13 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ff56039c4870 8032217: failure in man page processing Reviewed-by: dholmes, tbell ! make/Images.gmk From john.r.rose at oracle.com Wed Jan 22 09:28:39 2014 From: john.r.rose at oracle.com (John Rose) Date: Wed, 22 Jan 2014 09:28:39 -0800 Subject: JLS string concatenation clarification In-Reply-To: References: <52DF14C0.1000601@oracle.com> Message-ID: On Jan 21, 2014, at 5:09 PM, Martin Buchholz wrote: > The fact that Strings even have an object identity is essentially a bug. Yes. It is string identity that makes this discussion difficult. In my view, it is possible to work around this by adjusting the spec. This would require great effort, in a phased set of transitions through two or more major releases. We would have to wean Java users away from using identity operations on strings. Then we can loosen the identity requirements on string factories, allowing the factories to reuse existing strings, something like Integer.valueOf. New documentation would refer to concepts like "values" or "value based types" [1]. [1] http://hg.openjdk.java.net/jdk8/jdk8/jdk/file/tip/src/share/classes/java/lang/doc-files/ValueBased.html This transition would be irrelevant to over 99.99% of Java programs. But it would cause occasional breakage where some clever programmer, in an unwise moment, decided to "lean on" the semantics of string identity. I'm talking about malapropisms like x = new String("foo") or atrocities like synchronized ("bar"). They would have to be deprecated and then (perhaps) deleted. I have heard credible tales of people synchronizing on globally shared objects like "foo" or Boolean.FALSE or (Integer)42. It is even possible that we would find it easier to introduce a completely new value-like string type, to co-exist with the old. I think, in other words, that string identity (and its associated problems) is a tight spot that we might break out of but only with some resolute and tricky maneuvering. ? John -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20140122/d45696fc/attachment.html From alex.buckley at oracle.com Wed Jan 22 14:14:26 2014 From: alex.buckley at oracle.com (Alex Buckley) Date: Wed, 22 Jan 2014 14:14:26 -0800 Subject: JLS string concatenation clarification In-Reply-To: <52DF14C0.1000601@oracle.com> References: <52DF14C0.1000601@oracle.com> Message-ID: <52E042C2.6020708@oracle.com> To compiler-dev and others, Since the original question asked when the JLS allows compilers to deviate from "always" creating a new String object, I would like to know more about the following case: On 1/21/2014 4:45 PM, Alex Buckley wrote: > - "Semi" constant expressions like s+"". Concatenating the empty string > literal "" with a String expression is mentioned in > https://bugs.openjdk.java.net/browse/JDK-4036535. The expectation (per > JLS1) that a new String object is always created in this case is > misplaced (per the JDK's actual behavior). But, the JLS never clarified > this. If compiler authors can confirm (on-list or privately) that indeed "concatenation with empty string does not create the new instance of String", then I will clarify the JLS. Alex From sean.mullan at oracle.com Wed Jan 22 16:12:58 2014 From: sean.mullan at oracle.com (sean.mullan at oracle.com) Date: Thu, 23 Jan 2014 00:12:58 +0000 Subject: hg: jdk8/tl/jdk: 8031825: OCSP client can't find responder cert if it uses a different subject key id algorithm than responderID Message-ID: <20140123001311.1048B6269C@hg.openjdk.java.net> Changeset: 57c26829deb6 Author: mullan Date: 2014-01-22 19:06 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/57c26829deb6 8031825: OCSP client can't find responder cert if it uses a different subject key id algorithm than responderID Reviewed-by: vinnie, xuelei ! src/share/classes/sun/security/provider/certpath/OCSPResponse.java From mark.reinhold at oracle.com Wed Jan 22 16:54:34 2014 From: mark.reinhold at oracle.com (mark.reinhold at oracle.com) Date: Wed, 22 Jan 2014 16:54:34 -0800 (PST) Subject: JEP 190: Pluggable Static Analyzers Message-ID: <20140123005434.DE12DF00D@eggemoggin.niobe.net> Posted: http://openjdk.java.net/jeps/190 - Mark From Sergey.Bylokhov at oracle.com Thu Jan 23 00:21:57 2014 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Thu, 23 Jan 2014 12:21:57 +0400 Subject: JEP 190: Pluggable Static Analyzers In-Reply-To: <20140123005434.DE12DF00D@eggemoggin.niobe.net> References: <20140123005434.DE12DF00D@eggemoggin.niobe.net> Message-ID: <52E0D125.30907@oracle.com> Hello, This new jep will replace the jsr 305? On 23.01.2014 4:54, mark.reinhold at oracle.com wrote: > Posted: http://openjdk.java.net/jeps/190 > > - Mark -- Best regards, Sergey. From paul.sandoz at oracle.com Thu Jan 23 02:08:33 2014 From: paul.sandoz at oracle.com (paul.sandoz at oracle.com) Date: Thu, 23 Jan 2014 10:08:33 +0000 Subject: hg: jdk8/tl/jdk: 8032190: Specifications of stream flatMap methods should require mapped streams to be closed Message-ID: <20140123100901.4C12D626BF@hg.openjdk.java.net> Changeset: 68eb0c55a8c0 Author: psandoz Date: 2014-01-21 10:49 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/68eb0c55a8c0 8032190: Specifications of stream flatMap methods should require mapped streams to be closed Reviewed-by: chegar, alanb ! src/share/classes/java/util/stream/DoubleStream.java ! src/share/classes/java/util/stream/IntStream.java ! src/share/classes/java/util/stream/LongStream.java ! src/share/classes/java/util/stream/Stream.java From erik.joelsson at oracle.com Fri Jan 24 01:40:30 2014 From: erik.joelsson at oracle.com (erik.joelsson at oracle.com) Date: Fri, 24 Jan 2014 09:40:30 +0000 Subject: hg: jdk8/tl: 8032632: Wrong version for the first jdk8 fcs build Message-ID: <20140124094031.71A1062744@hg.openjdk.java.net> Changeset: 7238a870ddb7 Author: erikj Date: 2014-01-24 10:39 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/rev/7238a870ddb7 8032632: Wrong version for the first jdk8 fcs build Reviewed-by: katleman ! common/autoconf/spec.gmk.in From vicente.romero at oracle.com Fri Jan 24 06:37:08 2014 From: vicente.romero at oracle.com (Vicente-Arturo Romero-Zaldivar) Date: Fri, 24 Jan 2014 14:37:08 +0000 Subject: JDK9 RFR: JDK-8029017: ElementType.TYPE_USE should be a logical superset of ElementType.TYPE and ANNOTATION_TYPE - approved In-Reply-To: References: Message-ID: <52E27A94.70706@oracle.com> Hi Joel, I'm OK with the proposed patch. Vicente On 16/01/14 15:02, Joel Borggr?n-Franck wrote: > Hi, > > Please review this fix intended for 9 and 8u. > > https://bugs.openjdk.java.net/browse/JDK-8029017 > http://cr.openjdk.java.net/~jfranck/8029017/ > > We got the rules wrong for TYPE_USE with respect to repeating annotation and their containers. TYPE_USE should be a superset of TYPE, ANNOTATION_TYPE, and TYPE_PARAMETER. > > cheers > /Joel From weijun.wang at oracle.com Sat Jan 25 05:32:19 2014 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Sat, 25 Jan 2014 13:32:19 +0000 Subject: hg: jdk8/tl/jdk: 8031572: jarsigner -verify exits with 0 when a jar file is not properly signed Message-ID: <20140125133414.AA45C62795@hg.openjdk.java.net> Changeset: 4d891c8db5c1 Author: weijun Date: 2014-01-21 12:08 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4d891c8db5c1 8031572: jarsigner -verify exits with 0 when a jar file is not properly signed Reviewed-by: mullan ! src/share/classes/java/util/jar/JarFile.java + test/sun/security/tools/jarsigner/EntriesOrder.java From alan.bateman at oracle.com Sat Jan 25 12:05:49 2014 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Sat, 25 Jan 2014 20:05:49 +0000 Subject: hg: jdk8/tl/jdk: 8032456: vm/jni/Miscellaneous/misc001/misc00101m1/misc00101m1.html failing on OS X Message-ID: <20140125200603.4D4F962798@hg.openjdk.java.net> Changeset: b56ff7d30a72 Author: alanb Date: 2014-01-24 11:50 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b56ff7d30a72 8032456: vm/jni/Miscellaneous/misc001/misc00101m1/misc00101m1.html failing on OS X Reviewed-by: sla, chegar, psandoz ! src/solaris/native/common/jni_util_md.c From vicente.romero at oracle.com Mon Jan 27 09:33:48 2014 From: vicente.romero at oracle.com (Vicente-Arturo Romero-Zaldivar) Date: Mon, 27 Jan 2014 17:33:48 +0000 Subject: JLS string concatenation clarification In-Reply-To: <52E042C2.6020708@oracle.com> References: <52DF14C0.1000601@oracle.com> <52E042C2.6020708@oracle.com> Message-ID: <52E6987C.5070104@oracle.com> Hi Alex, Are you interested in the generated code or in the compiler's internal representation? Thanks, Vicente On 22/01/14 22:14, Alex Buckley wrote: > To compiler-dev and others, > > Since the original question asked when the JLS allows compilers to > deviate from "always" creating a new String object, I would like to > know more about the following case: > > On 1/21/2014 4:45 PM, Alex Buckley wrote: >> - "Semi" constant expressions like s+"". Concatenating the empty string >> literal "" with a String expression is mentioned in >> https://bugs.openjdk.java.net/browse/JDK-4036535. The expectation (per >> JLS1) that a new String object is always created in this case is >> misplaced (per the JDK's actual behavior). But, the JLS never clarified >> this. > > If compiler authors can confirm (on-list or privately) that indeed > "concatenation with empty string does not create the new instance of > String", then I will clarify the JLS. > > Alex From alex.buckley at oracle.com Mon Jan 27 11:29:07 2014 From: alex.buckley at oracle.com (Alex Buckley) Date: Mon, 27 Jan 2014 11:29:07 -0800 Subject: JLS string concatenation clarification In-Reply-To: <52E6987C.5070104@oracle.com> References: <52DF14C0.1000601@oracle.com> <52E042C2.6020708@oracle.com> <52E6987C.5070104@oracle.com> Message-ID: <52E6B383.5090904@oracle.com> Hi Vicente, Generated code. Also, I realize that s+"" may generate different code than ""+s - please indicate if that's the case. Alex On 1/27/2014 9:33 AM, Vicente-Arturo Romero-Zaldivar wrote: > Hi Alex, > > Are you interested in the generated code or in the compiler's internal > representation? > > Thanks, > Vicente > > On 22/01/14 22:14, Alex Buckley wrote: >> To compiler-dev and others, >> >> Since the original question asked when the JLS allows compilers to >> deviate from "always" creating a new String object, I would like to >> know more about the following case: >> >> On 1/21/2014 4:45 PM, Alex Buckley wrote: >>> - "Semi" constant expressions like s+"". Concatenating the empty string >>> literal "" with a String expression is mentioned in >>> https://bugs.openjdk.java.net/browse/JDK-4036535. The expectation (per >>> JLS1) that a new String object is always created in this case is >>> misplaced (per the JDK's actual behavior). But, the JLS never clarified >>> this. >> >> If compiler authors can confirm (on-list or privately) that indeed >> "concatenation with empty string does not create the new instance of >> String", then I will clarify the JLS. >> >> Alex > From jonathan.gibbons at oracle.com Mon Jan 27 16:52:28 2014 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Mon, 27 Jan 2014 16:52:28 -0800 Subject: JEP 190: Pluggable Static Analyzers Message-ID: <52E6FF4C.50703@oracle.com> Why is JEP 190 different from the support already in javac for pluggable static analyzers, such as provided by -Xplugin? -- Jon From fweimer at redhat.com Tue Jan 28 00:49:30 2014 From: fweimer at redhat.com (Florian Weimer) Date: Tue, 28 Jan 2014 09:49:30 +0100 Subject: JEP 190: Pluggable Static Analyzers In-Reply-To: <52E6FF4C.50703@oracle.com> References: <52E6FF4C.50703@oracle.com> Message-ID: <52E76F1A.4060809@redhat.com> On 01/28/2014 01:52 AM, Jonathan Gibbons wrote: > Why is JEP 190 different from the support already in javac for pluggable > static analyzers, such as provided by -Xplugin? The JSR 269 interface does not provide access to expressions and method bodies. It happens that through this interface, javac internals which provide this information are available after casting to internal javac classes. However, this is not a supported interface, and the internal javac data structures are not directly suited to implementing analysis passes. -- Florian Weimer / Red Hat Product Security Team From eric.mccorkle at oracle.com Tue Jan 28 05:53:05 2014 From: eric.mccorkle at oracle.com (eric.mccorkle at oracle.com) Date: Tue, 28 Jan 2014 13:53:05 +0000 Subject: hg: jdk8/tl/jdk: 8032585: JSR292: IllegalAccessError when attempting to invoke protected method from different package Message-ID: <20140128135328.E3A1662802@hg.openjdk.java.net> Changeset: 56d05f260123 Author: vlivanov Date: 2014-01-28 13:46 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/56d05f260123 8032585: JSR292: IllegalAccessError when attempting to invoke protected method from different package Reviewed-by: twisti, jrose ! src/share/classes/sun/invoke/util/VerifyAccess.java + test/java/lang/invoke/ProtectedMemberDifferentPackage/Test.java + test/java/lang/invoke/ProtectedMemberDifferentPackage/p1/T2.java + test/java/lang/invoke/ProtectedMemberDifferentPackage/p2/T3.java From jhs at edg.com Tue Jan 28 08:14:13 2014 From: jhs at edg.com (John Spicer) Date: Tue, 28 Jan 2014 11:14:13 -0500 Subject: Final strings in annotations applying to class members Message-ID: <8DA2D9A4-D01D-4418-81A0-5BA29A9B55FF@edg.com> Javac 8 accepts: @interface Annot { String str(); } class Test { final String CONST_STR="something"; @Annot( str = CONST_STR ) class Foo {} @Annot( str = CONST_STR ) void f(){} } It rejects only the second annotation use in the example below (complaining that CONST_STR cannot be referenced from a static context). Given that CONST_STR is a constant expression, I could see allowing both uses. Is there a rationale for allowing only the use on the class? Thanks, John. @interface Annot { String str(); } class Test { final String CONST_STR="something"; @Annot( str = CONST_STR ) static class Foo {} @Annot( str = CONST_STR ) static void f(){} } From eric.mccorkle at oracle.com Tue Jan 28 11:11:32 2014 From: eric.mccorkle at oracle.com (Eric McCorkle) Date: Tue, 28 Jan 2014 14:11:32 -0500 Subject: JEP 190: Pluggable Static Analyzers In-Reply-To: <52E76F1A.4060809@redhat.com> References: <52E6FF4C.50703@oracle.com> <52E76F1A.4060809@redhat.com> Message-ID: <52E800E4.8090603@oracle.com> On 01/28/14 03:49, Florian Weimer wrote: > On 01/28/2014 01:52 AM, Jonathan Gibbons wrote: >> Why is JEP 190 different from the support already in javac for pluggable >> static analyzers, such as provided by -Xplugin? > > The JSR 269 interface does not provide access to expressions and method > bodies. It happens that through this interface, javac internals which > provide this information are available after casting to internal javac > classes. However, this is not a supported interface, and the internal > javac data structures are not directly suited to implementing analysis > passes. > An eventual goal of the system envisioned by JEP 190 is to allow analysis tools to operate on javac's trees as opposed to source or bytecode (as is common now). Of course, there are quite a few intermediate steps that have to be taken to realize that goal. -------------- next part -------------- A non-text attachment was scrubbed... Name: eric_mccorkle.vcf Type: text/x-vcard Size: 303 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20140128/55b06a4a/eric_mccorkle.vcf From jonathan.gibbons at oracle.com Tue Jan 28 11:31:21 2014 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Tue, 28 Jan 2014 11:31:21 -0800 Subject: JEP 190: Pluggable Static Analyzers In-Reply-To: <52E800E4.8090603@oracle.com> References: <52E6FF4C.50703@oracle.com> <52E76F1A.4060809@redhat.com> <52E800E4.8090603@oracle.com> Message-ID: <52E80589.90608@oracle.com> On 01/28/2014 11:11 AM, Eric McCorkle wrote: > On 01/28/14 03:49, Florian Weimer wrote: >> On 01/28/2014 01:52 AM, Jonathan Gibbons wrote: >>> Why is JEP 190 different from the support already in javac for pluggable >>> static analyzers, such as provided by -Xplugin? >> The JSR 269 interface does not provide access to expressions and method >> bodies. It happens that through this interface, javac internals which >> provide this information are available after casting to internal javac >> classes. However, this is not a supported interface, and the internal >> javac data structures are not directly suited to implementing analysis >> passes. >> > An eventual goal of the system envisioned by JEP 190 is to allow > analysis tools to operate on javac's trees as opposed to source or > bytecode (as is common now). Of course, there are quite a few > intermediate steps that have to be taken to realize that goal. You can easily do this in JDK 8 with -Xplugin, using the com.sun.source API. com.sun.source is a public supported API. Are you suggesting that is not enough, and that you want to start investigating a standard javax.* AST API? The one piece that is missing in the -Xplugin world is easy access to the proto-bytecodes from a plugin. -- Jon From alex.buckley at oracle.com Tue Jan 28 12:32:47 2014 From: alex.buckley at oracle.com (Alex Buckley) Date: Tue, 28 Jan 2014 12:32:47 -0800 Subject: Final strings in annotations applying to class members In-Reply-To: <8DA2D9A4-D01D-4418-81A0-5BA29A9B55FF@edg.com> References: <8DA2D9A4-D01D-4418-81A0-5BA29A9B55FF@edg.com> Message-ID: <52E813EF.1090408@oracle.com> Looks like a javac bug. The element value CONST_STR is indeed a constant expression (gives the simple name of a constant variable), and the type of CONST_STR is a String, so JLS 9.7.1 says all your annotations are legal. Alex On 1/28/2014 8:14 AM, John Spicer wrote: > Javac 8 accepts: > > @interface Annot { > String str(); > } > > class Test { > final String CONST_STR="something"; > > @Annot( str = CONST_STR ) > class Foo {} > > @Annot( str = CONST_STR ) > void f(){} > } > > It rejects only the second annotation use in the example below (complaining that CONST_STR cannot be referenced from a static context). > > Given that CONST_STR is a constant expression, I could see allowing both uses. Is there a rationale for allowing only the use on the class? > > Thanks, > > John. > > @interface Annot { > String str(); > } > > class Test { > final String CONST_STR="something"; > > @Annot( str = CONST_STR ) > static class Foo {} > > @Annot( str = CONST_STR ) > static void f(){} > } > > From jeff.dinkins at oracle.com Tue Jan 28 12:40:59 2014 From: jeff.dinkins at oracle.com (jeff.dinkins at oracle.com) Date: Tue, 28 Jan 2014 20:40:59 +0000 Subject: hg: jdk8/tl/hotspot: 8032816: THIRDPARTYREADME LittleCMS preamble missing JRE 8 & JDK 8 Message-ID: <20140128204101.F2B7262824@hg.openjdk.java.net> Changeset: ce0320cdb075 Author: jeff Date: 2014-01-28 20:09 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ce0320cdb075 8032816: THIRDPARTYREADME LittleCMS preamble missing JRE 8 & JDK 8 Reviewed-by: lana ! THIRD_PARTY_README From jeff.dinkins at oracle.com Tue Jan 28 12:40:07 2014 From: jeff.dinkins at oracle.com (jeff.dinkins at oracle.com) Date: Tue, 28 Jan 2014 20:40:07 +0000 Subject: hg: jdk8/tl/corba: 8032816: THIRDPARTYREADME LittleCMS preamble missing JRE 8 & JDK 8 Message-ID: <20140128204007.AA92D62823@hg.openjdk.java.net> Changeset: 6d40c0d49c7a Author: jeff Date: 2014-01-28 20:09 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/6d40c0d49c7a 8032816: THIRDPARTYREADME LittleCMS preamble missing JRE 8 & JDK 8 Reviewed-by: lana ! THIRD_PARTY_README From jeff.dinkins at oracle.com Tue Jan 28 12:41:28 2014 From: jeff.dinkins at oracle.com (jeff.dinkins at oracle.com) Date: Tue, 28 Jan 2014 20:41:28 +0000 Subject: hg: jdk8/tl/jaxp: 8032816: THIRDPARTYREADME LittleCMS preamble missing JRE 8 & JDK 8 Message-ID: <20140128204131.5EC6762825@hg.openjdk.java.net> Changeset: 60c2c003fa11 Author: jeff Date: 2014-01-28 20:09 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/60c2c003fa11 8032816: THIRDPARTYREADME LittleCMS preamble missing JRE 8 & JDK 8 Reviewed-by: lana ! THIRD_PARTY_README From jeff.dinkins at oracle.com Tue Jan 28 12:41:46 2014 From: jeff.dinkins at oracle.com (jeff.dinkins at oracle.com) Date: Tue, 28 Jan 2014 20:41:46 +0000 Subject: hg: jdk8/tl/jaxws: 8032816: THIRDPARTYREADME LittleCMS preamble missing JRE 8 & JDK 8 Message-ID: <20140128204148.F3F7962826@hg.openjdk.java.net> Changeset: 2b44c111e153 Author: jeff Date: 2014-01-28 20:09 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/2b44c111e153 8032816: THIRDPARTYREADME LittleCMS preamble missing JRE 8 & JDK 8 Reviewed-by: lana ! THIRD_PARTY_README From jeff.dinkins at oracle.com Tue Jan 28 12:42:29 2014 From: jeff.dinkins at oracle.com (jeff.dinkins at oracle.com) Date: Tue, 28 Jan 2014 20:42:29 +0000 Subject: hg: jdk8/tl/jdk: 8032816: THIRDPARTYREADME LittleCMS preamble missing JRE 8 & JDK 8 Message-ID: <20140128204248.3844C62827@hg.openjdk.java.net> Changeset: 72d0cc723560 Author: jeff Date: 2014-01-28 20:10 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/72d0cc723560 8032816: THIRDPARTYREADME LittleCMS preamble missing JRE 8 & JDK 8 Reviewed-by: lana ! THIRD_PARTY_README From jeff.dinkins at oracle.com Tue Jan 28 12:44:50 2014 From: jeff.dinkins at oracle.com (jeff.dinkins at oracle.com) Date: Tue, 28 Jan 2014 20:44:50 +0000 Subject: hg: jdk8/tl/langtools: 8032816: THIRDPARTYREADME LittleCMS preamble missing JRE 8 & JDK 8 Message-ID: <20140128204454.0BE4B62828@hg.openjdk.java.net> Changeset: afa91c54ff00 Author: jeff Date: 2014-01-28 20:10 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/afa91c54ff00 8032816: THIRDPARTYREADME LittleCMS preamble missing JRE 8 & JDK 8 Reviewed-by: lana ! THIRD_PARTY_README From jeff.dinkins at oracle.com Tue Jan 28 12:45:07 2014 From: jeff.dinkins at oracle.com (jeff.dinkins at oracle.com) Date: Tue, 28 Jan 2014 20:45:07 +0000 Subject: hg: jdk8/tl/nashorn: 8032816: THIRDPARTYREADME LittleCMS preamble missing JRE 8 & JDK 8 Message-ID: <20140128204508.980F662829@hg.openjdk.java.net> Changeset: d3b293a4d554 Author: jeff Date: 2014-01-28 20:10 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/d3b293a4d554 8032816: THIRDPARTYREADME LittleCMS preamble missing JRE 8 & JDK 8 Reviewed-by: lana ! THIRD_PARTY_README From vicente.romero at oracle.com Tue Jan 28 13:00:13 2014 From: vicente.romero at oracle.com (Vicente-Arturo Romero-Zaldivar) Date: Tue, 28 Jan 2014 21:00:13 +0000 Subject: JLS string concatenation clarification In-Reply-To: <52E6B383.5090904@oracle.com> References: <52DF14C0.1000601@oracle.com> <52E042C2.6020708@oracle.com> <52E6987C.5070104@oracle.com> <52E6B383.5090904@oracle.com> Message-ID: <52E81A5D.5090409@oracle.com> Hi Alex, On 27/01/14 19:29, Alex Buckley wrote: > Hi Vicente, > > Generated code. Also, I realize that s+"" may generate different code > than ""+s - please indicate if that's the case. Yes the generated code is slightly different. But at the end javac only indicates what should be done. A string concatenation implies the creation of a StringBuilder with calls to it's append() method. Later the VM should these instructions only as indications. Vicente > > Alex > > On 1/27/2014 9:33 AM, Vicente-Arturo Romero-Zaldivar wrote: >> Hi Alex, >> >> Are you interested in the generated code or in the compiler's internal >> representation? >> >> Thanks, >> Vicente >> >> On 22/01/14 22:14, Alex Buckley wrote: >>> To compiler-dev and others, >>> >>> Since the original question asked when the JLS allows compilers to >>> deviate from "always" creating a new String object, I would like to >>> know more about the following case: >>> >>> On 1/21/2014 4:45 PM, Alex Buckley wrote: >>>> - "Semi" constant expressions like s+"". Concatenating the empty >>>> string >>>> literal "" with a String expression is mentioned in >>>> https://bugs.openjdk.java.net/browse/JDK-4036535. The expectation (per >>>> JLS1) that a new String object is always created in this case is >>>> misplaced (per the JDK's actual behavior). But, the JLS never >>>> clarified >>>> this. >>> >>> If compiler authors can confirm (on-list or privately) that indeed >>> "concatenation with empty string does not create the new instance of >>> String", then I will clarify the JLS. >>> >>> Alex >> From jeremymanson at google.com Tue Jan 28 13:01:23 2014 From: jeremymanson at google.com (Jeremy Manson) Date: Tue, 28 Jan 2014 13:01:23 -0800 Subject: JEP 190: Pluggable Static Analyzers In-Reply-To: <52E80589.90608@oracle.com> References: <52E6FF4C.50703@oracle.com> <52E76F1A.4060809@redhat.com> <52E800E4.8090603@oracle.com> <52E80589.90608@oracle.com> Message-ID: Our experience is that the various tree APIs aren't quite enough for a couple of reasons: - Because of actions that are taken during parsing, the AST can't easily be used to map back to the original code. Limitations range from things as simple as concatenating strings during parsing to problems as serious as having no access to the original source / comments. This makes it hard to do things like write formatters. - The tree API is relatively stable, but some of the ancillary APIs change from revision to revision. We've had to use reflection to access, for example, the logging API, as it changes from version to version (if we want to support more than one version at a time). ISTR having a problem with the file manager API in the javac6->7 transition, too (although I can't remember the details). In the few years we've been writing tools on top of javac, we've found that a steady stream of missing features and changed APIs have made our lives slightly, but consistently, more complicated (or simply prevented us from implementing various features). Most of the issues we've seen are pretty fixable, though. Jeremy On Tue, Jan 28, 2014 at 11:31 AM, Jonathan Gibbons < jonathan.gibbons at oracle.com> wrote: > On 01/28/2014 11:11 AM, Eric McCorkle wrote: > >> On 01/28/14 03:49, Florian Weimer wrote: >> >>> On 01/28/2014 01:52 AM, Jonathan Gibbons wrote: >>> >>>> Why is JEP 190 different from the support already in javac for pluggable >>>> static analyzers, such as provided by -Xplugin? >>>> >>> The JSR 269 interface does not provide access to expressions and method >>> bodies. It happens that through this interface, javac internals which >>> provide this information are available after casting to internal javac >>> classes. However, this is not a supported interface, and the internal >>> javac data structures are not directly suited to implementing analysis >>> passes. >>> >>> An eventual goal of the system envisioned by JEP 190 is to allow >> analysis tools to operate on javac's trees as opposed to source or >> bytecode (as is common now). Of course, there are quite a few >> intermediate steps that have to be taken to realize that goal. >> > > You can easily do this in JDK 8 with -Xplugin, using the com.sun.source > API. com.sun.source is a public supported API. Are you suggesting that is > not enough, and that you want to start investigating a standard javax.* AST > API? > > The one piece that is missing in the -Xplugin world is easy access to the > proto-bytecodes from a plugin. > > -- Jon > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20140128/344c3443/attachment-0001.html From robert.field at oracle.com Tue Jan 28 13:03:07 2014 From: robert.field at oracle.com (robert.field at oracle.com) Date: Tue, 28 Jan 2014 21:03:07 +0000 Subject: hg: jdk8/tl/jdk: 8032711: Issue with Lambda in handling; ... Message-ID: <20140128210319.AFAB66282B@hg.openjdk.java.net> Changeset: c8d9cdc6445c Author: rfield Date: 2014-01-28 13:02 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c8d9cdc6445c 8032711: Issue with Lambda in handling 8032704: Issues with lib perm in Lambda Reviewed-by: jrose, ahgross, briangoetz ! src/share/classes/java/lang/invoke/AbstractValidatingLambdaMetafactory.java + test/java/lang/invoke/lambda/T8032704.java + test/java/lang/invoke/lambda/T8032711.java From jeff.dinkins at oracle.com Tue Jan 28 12:39:31 2014 From: jeff.dinkins at oracle.com (jeff.dinkins at oracle.com) Date: Tue, 28 Jan 2014 20:39:31 +0000 Subject: hg: jdk8/tl: 8032816: THIRDPARTYREADME LittleCMS preamble missing JRE 8 & JDK 8 Message-ID: <20140128203931.DC82E62821@hg.openjdk.java.net> Changeset: 4f590c2cec75 Author: jeff Date: 2014-01-28 20:09 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/rev/4f590c2cec75 8032816: THIRDPARTYREADME LittleCMS preamble missing JRE 8 & JDK 8 Reviewed-by: lana ! THIRD_PARTY_README From jonathan.gibbons at oracle.com Tue Jan 28 13:59:24 2014 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Tue, 28 Jan 2014 13:59:24 -0800 Subject: JEP 190: Pluggable Static Analyzers In-Reply-To: References: <52E6FF4C.50703@oracle.com> <52E76F1A.4060809@redhat.com> <52E800E4.8090603@oracle.com> <52E80589.90608@oracle.com> Message-ID: <52E8283C.20704@oracle.com> On 01/28/2014 01:01 PM, Jeremy Manson wrote: > Our experience is that the various tree APIs aren't quite enough for a > couple of reasons: > > - Because of actions that are taken during parsing, the AST can't > easily be used to map back to the original code. Limitations range > from things as simple as concatenating strings during parsing to > problems as serious as having no access to the original source / > comments. This makes it hard to do things like write formatters. We are aware of issues where the source tree does not directly correspond to the elements in the source code. The obvious main example is enum member declarations, which are desugared right in the parser. uugh. We are working to address those issues. Comments are more tricky. I doubt we would ever want to see comments faithfully rendered in the AST (it is a syntax tree after all) -- and the recommendation for utilities like formatters is to use the source positions (which are intended to be accurate) to map back to the original source text so that you can re-examine the text in the vicinity. > > - The tree API is relatively stable, but some of the ancillary APIs > change from revision to revision. We've had to use reflection to > access, for example, the logging API, as it changes from version to > version (if we want to support more than one version at a time). ISTR > having a problem with the file manager API in the javac6->7 > transition, too (although I can't remember the details). There were some changes in the processing Filer API needed to fix incorrect behavior that I remember. > > In the few years we've been writing tools on top of javac, we've found > that a steady stream of missing features and changed APIs have made > our lives slightly, but consistently, more complicated (or simply > prevented us from implementing various features). Most of the issues > we've seen are pretty fixable, though. I would hope that while there may be some issues that made your life more complicated, you still found it less complicated overall to use javac instead of any other solution. And you are right, many of the issues are fixable: it just comes down to time and resources. -- Jon > > Jeremy > > > On Tue, Jan 28, 2014 at 11:31 AM, Jonathan Gibbons > > wrote: > > On 01/28/2014 11:11 AM, Eric McCorkle wrote: > > On 01/28/14 03:49, Florian Weimer wrote: > > On 01/28/2014 01:52 AM, Jonathan Gibbons wrote: > > Why is JEP 190 different from the support already in > javac for pluggable > static analyzers, such as provided by -Xplugin? > > The JSR 269 interface does not provide access to > expressions and method > bodies. It happens that through this interface, javac > internals which > provide this information are available after casting to > internal javac > classes. However, this is not a supported interface, and > the internal > javac data structures are not directly suited to > implementing analysis > passes. > > An eventual goal of the system envisioned by JEP 190 is to allow > analysis tools to operate on javac's trees as opposed to source or > bytecode (as is common now). Of course, there are quite a few > intermediate steps that have to be taken to realize that goal. > > > You can easily do this in JDK 8 with -Xplugin, using the > com.sun.source API. com.sun.source is a public supported API. > Are you suggesting that is not enough, and that you want to start > investigating a standard javax.* AST API? > > The one piece that is missing in the -Xplugin world is easy access > to the proto-bytecodes from a plugin. > > -- Jon > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20140128/c623e2d0/attachment.html From lowasser at google.com Tue Jan 21 09:59:36 2014 From: lowasser at google.com (Louis Wasserman) Date: Tue, 21 Jan 2014 09:59:36 -0800 Subject: JLS string concatenation clarification Message-ID: JLS 15.18.1 states: > The String object is newly created (?12.5) > unless the expression is a compile-time constant expression (?15.28 > ). JLS 12.5 states: > Execution of a string concatenation operator (?15.18.1) > that is not part of a constant expression (?15.28) > sometimes creates a new String object to represent the result. It's not clear to me, from reading this, whether string concatenation with + *always* creates a new String object or *sometimes *creates a new String object. 15.18.1 seems to imply always, but 12.5 says "sometimes." My understanding is that String.concat used to be used for string concatenation, and String.concat currently returns its receiver if its argument is the empty string. This seems to be evidence for the "sometimes" interpretation. -- Louis Wasserman -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20140121/24476c0f/attachment.html From romanivanovjr at gmail.com Tue Jan 28 14:01:43 2014 From: romanivanovjr at gmail.com (Roman Ivanov) Date: Tue, 28 Jan 2014 14:01:43 -0800 Subject: request to share java grammar Message-ID: Hello compiler-dev team, I am lead developer of Checkstyle project(http://checkstyle.sourceforge.net/ ). To add new java8 features support in our projects we need to update our Java grammar to support new syntax features (like lambda). Our grammar is based on ANTRL library. Do you have any publicly available resources/sources that could help us to upgrade to Java8 syntax ? any resources could help. Thanks, Roman Ivanov. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20140128/89a799c7/attachment.html From alex.buckley at oracle.com Tue Jan 28 15:13:45 2014 From: alex.buckley at oracle.com (Alex Buckley) Date: Tue, 28 Jan 2014 15:13:45 -0800 Subject: request to share java grammar In-Reply-To: References: Message-ID: <52E839A9.60803@oracle.com> Hi Roman, Visit the Java SE 8 Platform Spec at http://cr.openjdk.java.net/~mr/se/8/java-se-8-fr-spec-01/ and follow the link to Annex 3. There, you will find a preview of JLS8, and chapter 19 gives the grammar. It is a automatic concatenation of all the productions in the earlier chapters; clicking a nonterminal will take you to the original production. Unfortunately, I am not able to share the source files from which the PDF is generated. Alex On 1/28/2014 2:01 PM, Roman Ivanov wrote: > Hello compiler-dev team, > > I am lead developer of Checkstyle > project(http://checkstyle.sourceforge.net/). > > To add new java8 features support in our projects we need to update our > Java grammar to support new syntax features (like lambda). > > Our grammar is based on ANTRL library. > > Do you have any publicly available resources/sources that could help us > to upgrade to Java8 syntax ? > any resources could help. > > Thanks, > Roman Ivanov. > From robert.field at oracle.com Tue Jan 28 17:25:00 2014 From: robert.field at oracle.com (robert.field at oracle.com) Date: Wed, 29 Jan 2014 01:25:00 +0000 Subject: hg: jdk8/tl/jdk: 8032697: Issues with Lambda Message-ID: <20140129012512.8FE0E62837@hg.openjdk.java.net> Changeset: e385bd6f7338 Author: rfield Date: 2014-01-28 17:23 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e385bd6f7338 8032697: Issues with Lambda Reviewed-by: ahgross, briangoetz, dlsmith, rfield Contributed-by: daniel.smith at oracle.com ! src/share/classes/java/lang/invoke/AbstractValidatingLambdaMetafactory.java + test/java/lang/invoke/lambda/T8032697.java + test/java/lang/invoke/lambda/T8032697_anotherpkg/T8032697_A.java From jeremymanson at google.com Tue Jan 28 23:59:44 2014 From: jeremymanson at google.com (Jeremy Manson) Date: Tue, 28 Jan 2014 23:59:44 -0800 Subject: JEP 190: Pluggable Static Analyzers In-Reply-To: <52E8283C.20704@oracle.com> References: <52E6FF4C.50703@oracle.com> <52E76F1A.4060809@redhat.com> <52E800E4.8090603@oracle.com> <52E80589.90608@oracle.com> <52E8283C.20704@oracle.com> Message-ID: On Tue, Jan 28, 2014 at 1:59 PM, Jonathan Gibbons < jonathan.gibbons at oracle.com> wrote: > > On 01/28/2014 01:01 PM, Jeremy Manson wrote: > > Our experience is that the various tree APIs aren't quite enough for a > couple of reasons: > > - Because of actions that are taken during parsing, the AST can't easily > be used to map back to the original code. Limitations range from things as > simple as concatenating strings during parsing to problems as serious as > having no access to the original source / comments. This makes it hard to > do things like write formatters. > > > We are aware of issues where the source tree does not directly correspond > to the elements in the source code. The obvious main example is enum member > declarations, which are desugared right in the parser. uugh. We are > working to address those issues. Comments are more tricky. I doubt we > would ever want to see comments faithfully rendered in the AST (it is a > syntax tree after all) -- and the recommendation for utilities like > formatters is to use the source positions (which are intended to be > accurate) to map back to the original source text so that you can > re-examine the text in the vicinity. > These aren't the only things that aren't supported. For example, for editors, you may want partial compilation. > In the few years we've been writing tools on top of javac, we've found > that a steady stream of missing features and changed APIs have made our > lives slightly, but consistently, more complicated (or simply prevented us > from implementing various features). Most of the issues we've seen are > pretty fixable, though. > > > I would hope that while there may be some issues that made your life more > complicated, you still found it less complicated overall to use javac > instead of any other solution. And you are right, many of the issues are > fixable: it just comes down to time and resources. > The combination of the fact that no one else seems to build significant tooling on it (AFAICT), the fact that we've had to deal with a steady trickle of incompatibilities, and the fact that various desugarings / lowerings happen before the AST is built, have combined to make us think that javac isn't being taken seriously as a tooling API. OTOH, javac has the benefit that it *is* the source of truth, it is easy to integrate analyses with compilation, and we don't have to worry about you guys screwing it up / abandoning it. I would support a JEP that states clearly and decisively, "as of Java 9, we are treating javac seriously as a tooling API, and outstanding issues will be resolved". If someone is committing time and resources to that, that's a good thing. Perhaps I read too much into this JEP. (There was a lot of talk in the JEP about type annotations, but, AFAICT, those aren't a major issue, and tools like the Checker Framework seem to do pretty well with what exists, plus -Xplugin. OTOH, it's reasonably true that someone needs to build a non-researchy way of doing serious data and control flow analyses for Java; Soot is a pile of cruft at this point, and Wala has an immutable CFG, which makes certain kinds of things tricky.) As for other solutions... We are in a position where we would like to have a formatter built into our static tooling in the near term, so we're actively looking at other solutions (for formatting) now. ecj and IntelliJ both have parsers that people use to build substantial amounts of tooling. They even have existing formatters! ecj seems to have a lot of legacy issues, but IntelliJ looks potentially promising. We're looking into it. Jeremy -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20140128/cf8306b3/attachment.html From joel.franck at oracle.com Wed Jan 29 05:34:25 2014 From: joel.franck at oracle.com (Joel Borggren-Franck) Date: Wed, 29 Jan 2014 14:34:25 +0100 Subject: Final strings in annotations applying to class members In-Reply-To: <52E813EF.1090408@oracle.com> References: <8DA2D9A4-D01D-4418-81A0-5BA29A9B55FF@edg.com> <52E813EF.1090408@oracle.com> Message-ID: <20140129133425.GC2786@oracle.com> John, Alex, Thanks for the bug report. I filed: https://bugs.openjdk.java.net/browse/JDK-8033132 cheers /Joel On 2014-01-28, Alex Buckley wrote: > Looks like a javac bug. The element value CONST_STR is indeed a > constant expression (gives the simple name of a constant variable), > and the type of CONST_STR is a String, so JLS 9.7.1 says all your > annotations are legal. > > Alex > > On 1/28/2014 8:14 AM, John Spicer wrote: > >Javac 8 accepts: > > > >@interface Annot { > > String str(); > >} > > > >class Test { > > final String CONST_STR="something"; > > > > @Annot( str = CONST_STR ) > > class Foo {} > > > > @Annot( str = CONST_STR ) > > void f(){} > >} > > > >It rejects only the second annotation use in the example below (complaining that CONST_STR cannot be referenced from a static context). > > > >Given that CONST_STR is a constant expression, I could see allowing both uses. Is there a rationale for allowing only the use on the class? > > > >Thanks, > > > >John. > > > >@interface Annot { > > String str(); > >} > > > >class Test { > > final String CONST_STR="something"; > > > > @Annot( str = CONST_STR ) > > static class Foo {} > > > > @Annot( str = CONST_STR ) > > static void f(){} > >} > > > > From peter.levart at gmail.com Wed Jan 29 06:59:38 2014 From: peter.levart at gmail.com (Peter Levart) Date: Wed, 29 Jan 2014 15:59:38 +0100 Subject: inconsistent generic types behaviour when compiling together vs. separate Message-ID: <52E9175A.1090306@gmail.com> Here's an example: Create an empty directory and copy into it the following two sources: Ref.java: public class Ref { final RefQueue queue = new RefQueue<>(); public static void main(String[] args) { Ref r = new Ref<>(); RefQueue q = r.queue; } } RefQueue.java: public class RefQueue { } Then execute: mkdir out javac -d out Ref.java This compiles fine and produces two class files in out directory: Ref.class RefQueue.class Now do the following: rm RefQueue.java mkdir out2 javac -cp out -d out2 Ref.java Which produces compile-time error: Ref.java:6: error: incompatible types: RefQueue cannot be converted to RefQueue RefQueue q = r.queue; ^ where CAP#1 is a fresh type-variable: CAP#1 extends Object super: Object from capture of ? super Object 1 error It seems that the behaviour is inconsistent. There's also a question whether the compile-time error is a correct behaviour or not. I tried this with JDK 7u51, JDK 8 ea-b121 and recent JDK 9 from dev forest. They all behave the same. Regards, Peter From jonathan.gibbons at oracle.com Wed Jan 29 09:07:25 2014 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Wed, 29 Jan 2014 09:07:25 -0800 Subject: Final strings in annotations applying to class members In-Reply-To: <20140129133425.GC2786@oracle.com> References: <8DA2D9A4-D01D-4418-81A0-5BA29A9B55FF@edg.com> <52E813EF.1090408@oracle.com> <20140129133425.GC2786@oracle.com> Message-ID: <52E9354D.80506@oracle.com> Just checking ... CONSTR_STR is declared "final String", not "static final String" ... -- Jon On 01/29/2014 05:34 AM, Joel Borggren-Franck wrote: > John, Alex, > > Thanks for the bug report. I filed: > > https://bugs.openjdk.java.net/browse/JDK-8033132 > > cheers > /Joel > > On 2014-01-28, Alex Buckley wrote: >> Looks like a javac bug. The element value CONST_STR is indeed a >> constant expression (gives the simple name of a constant variable), >> and the type of CONST_STR is a String, so JLS 9.7.1 says all your >> annotations are legal. >> >> Alex >> >> On 1/28/2014 8:14 AM, John Spicer wrote: >>> Javac 8 accepts: >>> >>> @interface Annot { >>> String str(); >>> } >>> >>> class Test { >>> final String CONST_STR="something"; >>> >>> @Annot( str = CONST_STR ) >>> class Foo {} >>> >>> @Annot( str = CONST_STR ) >>> void f(){} >>> } >>> >>> It rejects only the second annotation use in the example below (complaining that CONST_STR cannot be referenced from a static context). >>> >>> Given that CONST_STR is a constant expression, I could see allowing both uses. Is there a rationale for allowing only the use on the class? >>> >>> Thanks, >>> >>> John. >>> >>> @interface Annot { >>> String str(); >>> } >>> >>> class Test { >>> final String CONST_STR="something"; >>> >>> @Annot( str = CONST_STR ) >>> static class Foo {} >>> >>> @Annot( str = CONST_STR ) >>> static void f(){} >>> } >>> >>> From joel.franck at oracle.com Wed Jan 29 09:57:55 2014 From: joel.franck at oracle.com (=?windows-1252?Q?Joel_Borggr=E9n-Franck?=) Date: Wed, 29 Jan 2014 18:57:55 +0100 Subject: Final strings in annotations applying to class members In-Reply-To: <52E9354D.80506@oracle.com> References: <8DA2D9A4-D01D-4418-81A0-5BA29A9B55FF@edg.com> <52E813EF.1090408@oracle.com> <20140129133425.GC2786@oracle.com> <52E9354D.80506@oracle.com> Message-ID: <3FB04370-72E4-4AC8-B67B-ACA6AE0698DA@oracle.com> True, But doesn?t that mean there is stil a bug here, just not the one we think? cheers /Joel On 29 Jan 2014, at 18:07, Jonathan Gibbons wrote: > Just checking ... > > CONSTR_STR is declared "final String", not "static final String" ... > > -- Jon > > > On 01/29/2014 05:34 AM, Joel Borggren-Franck wrote: >> John, Alex, >> >> Thanks for the bug report. I filed: >> >> https://bugs.openjdk.java.net/browse/JDK-8033132 >> >> cheers >> /Joel >> >> On 2014-01-28, Alex Buckley wrote: >>> Looks like a javac bug. The element value CONST_STR is indeed a >>> constant expression (gives the simple name of a constant variable), >>> and the type of CONST_STR is a String, so JLS 9.7.1 says all your >>> annotations are legal. >>> >>> Alex >>> >>> On 1/28/2014 8:14 AM, John Spicer wrote: >>>> Javac 8 accepts: >>>> >>>> @interface Annot { >>>> String str(); >>>> } >>>> >>>> class Test { >>>> final String CONST_STR="something"; >>>> >>>> @Annot( str = CONST_STR ) >>>> class Foo {} >>>> >>>> @Annot( str = CONST_STR ) >>>> void f(){} >>>> } >>>> >>>> It rejects only the second annotation use in the example below (complaining that CONST_STR cannot be referenced from a static context). >>>> >>>> Given that CONST_STR is a constant expression, I could see allowing both uses. Is there a rationale for allowing only the use on the class? >>>> >>>> Thanks, >>>> >>>> John. >>>> >>>> @interface Annot { >>>> String str(); >>>> } >>>> >>>> class Test { >>>> final String CONST_STR="something"; >>>> >>>> @Annot( str = CONST_STR ) >>>> static class Foo {} >>>> >>>> @Annot( str = CONST_STR ) >>>> static void f(){} >>>> } >>>> >>>> > From alex.buckley at oracle.com Wed Jan 29 10:59:30 2014 From: alex.buckley at oracle.com (Alex Buckley) Date: Wed, 29 Jan 2014 10:59:30 -0800 Subject: Final strings in annotations applying to class members In-Reply-To: <52E9354D.80506@oracle.com> References: <8DA2D9A4-D01D-4418-81A0-5BA29A9B55FF@edg.com> <52E813EF.1090408@oracle.com> <20140129133425.GC2786@oracle.com> <52E9354D.80506@oracle.com> Message-ID: <52E94F92.8060907@oracle.com> I admit that the definition of "constant variable" in JLS 4.12.4 is always worth double-checking: "A variable of primitive type or type String, that is final and initialized with a compile-time constant expression (?15.28), is called a constant variable." The point being that a compiler can statically determine the value of the constant variable CONST_STR for the purpose of emitting an annotation attribute in a class file - even though the variable declaration is not 'static'. Alex On 1/29/2014 9:07 AM, Jonathan Gibbons wrote: > Just checking ... > > CONSTR_STR is declared "final String", not "static final String" ... > > -- Jon > > > On 01/29/2014 05:34 AM, Joel Borggren-Franck wrote: >> John, Alex, >> >> Thanks for the bug report. I filed: >> >> https://bugs.openjdk.java.net/browse/JDK-8033132 >> >> cheers >> /Joel >> >> On 2014-01-28, Alex Buckley wrote: >>> Looks like a javac bug. The element value CONST_STR is indeed a >>> constant expression (gives the simple name of a constant variable), >>> and the type of CONST_STR is a String, so JLS 9.7.1 says all your >>> annotations are legal. >>> >>> Alex >>> >>> On 1/28/2014 8:14 AM, John Spicer wrote: >>>> Javac 8 accepts: >>>> >>>> @interface Annot { >>>> String str(); >>>> } >>>> >>>> class Test { >>>> final String CONST_STR="something"; >>>> >>>> @Annot( str = CONST_STR ) >>>> class Foo {} >>>> >>>> @Annot( str = CONST_STR ) >>>> void f(){} >>>> } >>>> >>>> It rejects only the second annotation use in the example below >>>> (complaining that CONST_STR cannot be referenced from a static >>>> context). >>>> >>>> Given that CONST_STR is a constant expression, I could see allowing >>>> both uses. Is there a rationale for allowing only the use on the >>>> class? >>>> >>>> Thanks, >>>> >>>> John. >>>> >>>> @interface Annot { >>>> String str(); >>>> } >>>> >>>> class Test { >>>> final String CONST_STR="something"; >>>> >>>> @Annot( str = CONST_STR ) >>>> static class Foo {} >>>> >>>> @Annot( str = CONST_STR ) >>>> static void f(){} >>>> } >>>> >>>> > From forax at univ-mlv.fr Wed Jan 29 11:08:19 2014 From: forax at univ-mlv.fr (Remi Forax) Date: Wed, 29 Jan 2014 20:08:19 +0100 Subject: Final strings in annotations applying to class members In-Reply-To: <52E94F92.8060907@oracle.com> References: <8DA2D9A4-D01D-4418-81A0-5BA29A9B55FF@edg.com> <52E813EF.1090408@oracle.com> <20140129133425.GC2786@oracle.com> <52E9354D.80506@oracle.com> <52E94F92.8060907@oracle.com> Message-ID: <52E951A3.4010808@univ-mlv.fr> On 01/29/2014 07:59 PM, Alex Buckley wrote: > I admit that the definition of "constant variable" in JLS 4.12.4 is > always worth double-checking: "A variable of primitive type or type > String, that is final and initialized with a compile-time constant > expression (?15.28), is called a constant variable." > > The point being that a compiler can statically determine the value of > the constant variable CONST_STR for the purpose of emitting an > annotation attribute in a class file - even though the variable > declaration is not 'static'. > > Alex > yes. at least this is how it works now. R?mi > On 1/29/2014 9:07 AM, Jonathan Gibbons wrote: >> Just checking ... >> >> CONSTR_STR is declared "final String", not "static final String" ... >> >> -- Jon >> >> >> On 01/29/2014 05:34 AM, Joel Borggren-Franck wrote: >>> John, Alex, >>> >>> Thanks for the bug report. I filed: >>> >>> https://bugs.openjdk.java.net/browse/JDK-8033132 >>> >>> cheers >>> /Joel >>> >>> On 2014-01-28, Alex Buckley wrote: >>>> Looks like a javac bug. The element value CONST_STR is indeed a >>>> constant expression (gives the simple name of a constant variable), >>>> and the type of CONST_STR is a String, so JLS 9.7.1 says all your >>>> annotations are legal. >>>> >>>> Alex >>>> >>>> On 1/28/2014 8:14 AM, John Spicer wrote: >>>>> Javac 8 accepts: >>>>> >>>>> @interface Annot { >>>>> String str(); >>>>> } >>>>> >>>>> class Test { >>>>> final String CONST_STR="something"; >>>>> >>>>> @Annot( str = CONST_STR ) >>>>> class Foo {} >>>>> >>>>> @Annot( str = CONST_STR ) >>>>> void f(){} >>>>> } >>>>> >>>>> It rejects only the second annotation use in the example below >>>>> (complaining that CONST_STR cannot be referenced from a static >>>>> context). >>>>> >>>>> Given that CONST_STR is a constant expression, I could see allowing >>>>> both uses. Is there a rationale for allowing only the use on the >>>>> class? >>>>> >>>>> Thanks, >>>>> >>>>> John. >>>>> >>>>> @interface Annot { >>>>> String str(); >>>>> } >>>>> >>>>> class Test { >>>>> final String CONST_STR="something"; >>>>> >>>>> @Annot( str = CONST_STR ) >>>>> static class Foo {} >>>>> >>>>> @Annot( str = CONST_STR ) >>>>> static void f(){} >>>>> } >>>>> >>>>> >> From jonathan.gibbons at oracle.com Wed Jan 29 13:21:32 2014 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Wed, 29 Jan 2014 13:21:32 -0800 Subject: Final strings in annotations applying to class members In-Reply-To: <52E94F92.8060907@oracle.com> References: <8DA2D9A4-D01D-4418-81A0-5BA29A9B55FF@edg.com> <52E813EF.1090408@oracle.com> <20140129133425.GC2786@oracle.com> <52E9354D.80506@oracle.com> <52E94F92.8060907@oracle.com> Message-ID: <52E970DC.3080803@oracle.com> Thanks. -- Jon On 01/29/2014 10:59 AM, Alex Buckley wrote: > I admit that the definition of "constant variable" in JLS 4.12.4 is > always worth double-checking: "A variable of primitive type or type > String, that is final and initialized with a compile-time constant > expression (?15.28), is called a constant variable." > > The point being that a compiler can statically determine the value of > the constant variable CONST_STR for the purpose of emitting an > annotation attribute in a class file - even though the variable > declaration is not 'static'. > > Alex > > On 1/29/2014 9:07 AM, Jonathan Gibbons wrote: >> Just checking ... >> >> CONSTR_STR is declared "final String", not "static final String" ... >> >> -- Jon >> >> >> On 01/29/2014 05:34 AM, Joel Borggren-Franck wrote: >>> John, Alex, >>> >>> Thanks for the bug report. I filed: >>> >>> https://bugs.openjdk.java.net/browse/JDK-8033132 >>> >>> cheers >>> /Joel >>> >>> On 2014-01-28, Alex Buckley wrote: >>>> Looks like a javac bug. The element value CONST_STR is indeed a >>>> constant expression (gives the simple name of a constant variable), >>>> and the type of CONST_STR is a String, so JLS 9.7.1 says all your >>>> annotations are legal. >>>> >>>> Alex >>>> >>>> On 1/28/2014 8:14 AM, John Spicer wrote: >>>>> Javac 8 accepts: >>>>> >>>>> @interface Annot { >>>>> String str(); >>>>> } >>>>> >>>>> class Test { >>>>> final String CONST_STR="something"; >>>>> >>>>> @Annot( str = CONST_STR ) >>>>> class Foo {} >>>>> >>>>> @Annot( str = CONST_STR ) >>>>> void f(){} >>>>> } >>>>> >>>>> It rejects only the second annotation use in the example below >>>>> (complaining that CONST_STR cannot be referenced from a static >>>>> context). >>>>> >>>>> Given that CONST_STR is a constant expression, I could see allowing >>>>> both uses. Is there a rationale for allowing only the use on the >>>>> class? >>>>> >>>>> Thanks, >>>>> >>>>> John. >>>>> >>>>> @interface Annot { >>>>> String str(); >>>>> } >>>>> >>>>> class Test { >>>>> final String CONST_STR="something"; >>>>> >>>>> @Annot( str = CONST_STR ) >>>>> static class Foo {} >>>>> >>>>> @Annot( str = CONST_STR ) >>>>> static void f(){} >>>>> } >>>>> >>>>> >> From sundararajan.athijegannathan at oracle.com Thu Jan 30 05:04:53 2014 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Thu, 30 Jan 2014 13:04:53 +0000 Subject: hg: jdk8/tl/nashorn: 8032944: Improve reflection in Nashorn Message-ID: <20140130130504.4BA5D628AC@hg.openjdk.java.net> Changeset: a43c125b03dc Author: sundar Date: 2014-01-30 18:34 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/a43c125b03dc 8032944: Improve reflection in Nashorn Reviewed-by: jlaskey, attila, ahgross ! src/jdk/nashorn/internal/objects/NativeObject.java + test/script/sandbox/classbind.js From sundararajan.athijegannathan at oracle.com Thu Jan 30 05:34:14 2014 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Thu, 30 Jan 2014 13:34:14 +0000 Subject: hg: jdk8/tl/nashorn: 8032954: Nashorn: extend Java.extend Message-ID: <20140130133415.A25F4628B0@hg.openjdk.java.net> Changeset: eca774d33fa4 Author: sundar Date: 2014-01-30 19:04 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/eca774d33fa4 8032954: Nashorn: extend Java.extend Reviewed-by: attila, jlaskey, ahgross ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java ! test/script/sandbox/classbind.js ! test/script/sandbox/classloader.js ! test/script/sandbox/classloader.js.EXPECTED From sundararajan.athijegannathan at oracle.com Thu Jan 30 06:15:53 2014 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Thu, 30 Jan 2014 14:15:53 +0000 Subject: hg: jdk8/tl/nashorn: 8032949: Nashorn linkages awry Message-ID: <20140130141554.BFDAE628B3@hg.openjdk.java.net> Changeset: c59fb10cb0b5 Author: sundar Date: 2014-01-30 19:45 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/c59fb10cb0b5 8032949: Nashorn linkages awry Reviewed-by: jlaskey, attila, ahgross ! src/jdk/nashorn/internal/objects/NativeObject.java ! src/jdk/nashorn/internal/runtime/linker/Bootstrap.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java ! src/jdk/nashorn/internal/runtime/linker/NashornStaticClassLinker.java ! src/jdk/nashorn/internal/runtime/linker/ReflectionCheckLinker.java ! test/src/jdk/nashorn/api/scripting/ScriptEngineSecurityTest.java ! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java From eric.mccorkle at oracle.com Thu Jan 30 11:28:02 2014 From: eric.mccorkle at oracle.com (eric.mccorkle at oracle.com) Date: Thu, 30 Jan 2014 19:28:02 +0000 Subject: hg: jdk8/tl/nashorn: 8032681: Issues with Nashorn Message-ID: <20140130192804.0C5A1628D4@hg.openjdk.java.net> Changeset: 11b83c913cca Author: attila Date: 2014-01-30 20:14 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/11b83c913cca 8032681: Issues with Nashorn Reviewed-by: ahgross, jlaskey, sundar + src/jdk/internal/dynalink/linker/GuardedTypeConversion.java ! src/jdk/internal/dynalink/linker/GuardingTypeConverterFactory.java ! src/jdk/internal/dynalink/support/LinkerServicesImpl.java ! src/jdk/internal/dynalink/support/TypeConverterFactory.java ! src/jdk/nashorn/api/scripting/NashornScriptEngine.java ! src/jdk/nashorn/internal/objects/NativeJava.java ! src/jdk/nashorn/internal/objects/NativeJavaImporter.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/NativeJavaPackage.java ! src/jdk/nashorn/internal/runtime/ScriptFunction.java ! src/jdk/nashorn/internal/runtime/linker/AdaptationResult.java ! src/jdk/nashorn/internal/runtime/linker/JSObjectLinker.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterBytecodeGenerator.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterClassLoader.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterServices.java ! src/jdk/nashorn/internal/runtime/linker/NashornBottomLinker.java ! src/jdk/nashorn/internal/runtime/linker/NashornLinker.java ! src/jdk/nashorn/internal/runtime/linker/NashornPrimitiveLinker.java ! src/jdk/nashorn/internal/runtime/linker/NashornStaticClassLinker.java ! src/jdk/nashorn/internal/runtime/resources/Messages.properties ! test/script/basic/JDK-8014647.js ! test/script/basic/JDK-8014647.js.EXPECTED ! test/script/basic/javaclassoverrides.js ! test/script/basic/javaclassoverrides.js.EXPECTED ! test/script/sandbox/javaextend.js ! test/script/sandbox/javaextend.js.EXPECTED ! test/src/jdk/nashorn/api/scripting/ScriptEngineSecurityTest.java + test/src/jdk/nashorn/test/models/ClassWithFinalFinalizer.java + test/src/jdk/nashorn/test/models/ClassWithInheritedFinalFinalizer.java From jonathan.gibbons at oracle.com Thu Jan 30 14:03:41 2014 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Thu, 30 Jan 2014 14:03:41 -0800 Subject: javac: ending positions generation and DiagnosticListener In-Reply-To: <52A51ED0.90607@oracle.com> References: <52A204A8.8070401@intellij.com> <52A209C0.8090209@oracle.com> <52A2447F.8040403@oracle.com> <52A25229.8080703@oracle.com> <52A32B65.9030502@intellij.com> <52A51ED0.90607@oracle.com> Message-ID: <52EACC3D.4040301@oracle.com> On 12/08/2013 05:37 PM, Jonathan Gibbons wrote: > On 12/07/2013 06:06 AM, Eugene Zhuravlev wrote: >> Great, >> Thanks a lot for clarifications. >> Could we hope to see these optimizations in JDK 8? Would it be also >> possible to backport them to JDK 7? >> >> Best regards, >> Eugene Zhuravlev > > We are trying to stabilize JDK 8 at this point, so it is not > appropriate for this change to go into the initial 8 release. > > It could go into an 8 update. > > -- Jon > > Issue now recorded at https://bugs.openjdk.java.net/browse/JDK-8033287 -- Jon From paul.sandoz at oracle.com Fri Jan 31 03:24:09 2014 From: paul.sandoz at oracle.com (paul.sandoz at oracle.com) Date: Fri, 31 Jan 2014 11:24:09 +0000 Subject: hg: jdk8/tl/jdk: 4 new changesets Message-ID: <20140131112700.AFEF362911@hg.openjdk.java.net> Changeset: 9f098aed44c0 Author: anazarov Date: 2014-01-31 12:01 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9f098aed44c0 8032025: Update repeating annotations demo Reviewed-by: jfranck + src/share/sample/annotations/DependencyChecker/PluginChecker/src/checker/Device.java + src/share/sample/annotations/DependencyChecker/PluginChecker/src/checker/Kettle.xml + src/share/sample/annotations/DependencyChecker/PluginChecker/src/checker/Module.java + src/share/sample/annotations/DependencyChecker/PluginChecker/src/checker/PluginChecker.java + src/share/sample/annotations/DependencyChecker/PluginChecker/src/checker/Require.java + src/share/sample/annotations/DependencyChecker/PluginChecker/src/checker/RequireContainer.java + src/share/sample/annotations/DependencyChecker/Plugins/src/plugins/BoilerPlugin.java + src/share/sample/annotations/DependencyChecker/Plugins/src/plugins/ExtendedBoilerPlugin.java + src/share/sample/annotations/DependencyChecker/Plugins/src/plugins/TimerPlugin.java + src/share/sample/annotations/Validator/src/PositiveIntegerSupplier.java + src/share/sample/annotations/Validator/src/SupplierValidator.java + src/share/sample/annotations/Validator/src/Validate.java + src/share/sample/annotations/Validator/src/Validator.java + src/share/sample/annotations/index.html Changeset: f72a8df6a2ed Author: anazarov Date: 2014-01-31 12:01 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f72a8df6a2ed 8031650: Update bulk operation demo Reviewed-by: psandoz, mduigou + src/share/sample/lambda/BulkDataOperations/index.html + src/share/sample/lambda/BulkDataOperations/src/CSVProcessor.java + src/share/sample/lambda/BulkDataOperations/src/Grep.java + src/share/sample/lambda/BulkDataOperations/src/PasswordGenerator.java + src/share/sample/lambda/BulkDataOperations/src/WC.java Changeset: 4574011c1689 Author: anazarov Date: 2014-01-31 12:01 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4574011c1689 8032020: Update try-with-resources demo Reviewed-by: darcy, alanb, smarks + src/share/sample/try-with-resources/index.html + src/share/sample/try-with-resources/src/CustomAutoCloseableSample.java + src/share/sample/try-with-resources/src/Unzip.java + src/share/sample/try-with-resources/src/ZipCat.java Changeset: a4f68fc5f353 Author: psandoz Date: 2014-01-31 12:01 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a4f68fc5f353 8032056: Create demo to illustrate new practices of the default methods usage Reviewed-by: briangoetz, rfield, psandoz Contributed-by: taras.ledkov at oracle.com + src/share/sample/lambda/DefaultMethods/ArrayIterator.java + src/share/sample/lambda/DefaultMethods/DiamondInheritance.java + src/share/sample/lambda/DefaultMethods/Inheritance.java + src/share/sample/lambda/DefaultMethods/MixIn.java + src/share/sample/lambda/DefaultMethods/Reflection.java + src/share/sample/lambda/DefaultMethods/SimplestUsage.java From eric.mccorkle at oracle.com Fri Jan 31 08:21:37 2014 From: eric.mccorkle at oracle.com (Eric McCorkle) Date: Fri, 31 Jan 2014 11:21:37 -0500 Subject: Updated type annotations roadmap Message-ID: <52EBCD91.40704@oracle.com> In previous list discussions, I have outlined a general roadmap for improving the quality of the type annotations code in javac. I am now very actively pursuing these steps; however, as I've gotten into the development, I've revised my approach a bit. Therefore, I'm composing this in order to describe how the plans have evolved, and also to give advanced notice of the changes I'm going to be implementing. == Deficiencies of the Current Implementation == The current implementation has (or had) the following deficiencies that need to be addressed: 1) Improper handling of errors (mostly fixed as of now): There were several places where the implementation handled error conditions with silent failures, no-ops, or other incorrect behavior. These have been largely addressed, but there could be more still in the code. 2) Two separate codepaths for attaching an annotation to a symbol: Annotations attached to the declaration itself (ie. those without type paths) are attached through separateAnnotationsKinds; annotations attached to arguments, arrays, type parameters, etc. are attached through the findPosition/resolveFrame codepath. These are executed at different points in the compiler pipeline. 3) Unable to generate multiple bytecode annotations from a single source annotation: The current implementation is designed around the assumption of a one-to-one relation between source and bytecode annotations. This is not always the case. 4) Type annotations positions are generated too late, and type annotations are attached to symbols too late: Presently, the resolveFrame codepath executes rather late in the pipeline (after repeating annotations). This was a source of bugs, as repeating annotations copied positions that had not yet been updated correctly (and is presently a source of a rather awkward workaround fix, which I'd like to get rid of). This is also a problem for annotation processing and javadoc, as many annotations aren't attached and given positions when annotation processing (and therefore, javadoc) runs. 5) Parts of the implementation don't follow javac development guidelines. == Revised Type Annotations Pipeline == I plan to address the above deficiencies by changing the overall type annotations pipeline to the following (the exact details are still being designed): 1) Type paths (and possibly complete TypeAnnotationPosition's) are constructed during memberEnter, and carried forward by Annotate.Worker's 2) All type annotations are attached by a single codepath, adapted from separateAnnotationsKinds. The type path information is already available, as it was generated in memberEnter. 3) Repeating annotations then does its processing, and will correctly copy the positions from any type annotations. 4) All type annotations should then be attached and have correct positions when annotation processing runs. I am currently undecided about where to actually generate the TypeCompound attributes, though I am leaning towards generating them at the same point where they are attached to symbols, this eliminates the need to carry them forward as metadata on the Tree, and will probably be a cleaner solution in the end. == Development Roadmap == I am implementing these changes using the following roadmap: 1) Remove silent failures or turn them into assertions failures: I have already removed four silent failures, though there could be more 2) Make some data in TypeAnnotationPosition immutable, clean up instantiations of TypeAnnotationPosition (patch out for review) 3) Implement logic for building type paths and possibly whole TypeAnnotationPositions in memberEnter, add fields/arguments necessary to carry that information forward to the point where annotations are attached. 4) Implement a unified codepath for (possibly generating and) attaching annotations to symbols, likely by adapting code from separateAnnotationsKinds. Remove findPosition/resolveFrame codepath. 5) Remove miscellaneous dead/useless code (getPosition in attributes, etc) 6) Fix any remaining issues preventing currently @ignore'd tests from running, implement a comprehensive combo test. There are some residual issues that are not part of this effort, but should be addressed: * It might be preferable to make TypeAnnotationPosition an abstract superclass with a number of subclasses. * Currently, Gen modifies parts of TypeAnnotationPosition, which precludes making the entire structure immutable (this can be seen in ClassReader as of my latest patch) == Current Status == As of now, I have completed the first and second stages on this roadmap. I have already pushed four patches that remove silent failures, and I have a patch that makes a good portion of TypeAnnotationPosition immutable. However, the roadmap I've outlined involves rather significant changes to the current implementation. Therefore, I propose the following: * I will indicate whenever I post a webrev for a major change, to allow the checkers framework tests and other test to be run, thereby ensuring that these patches don't introduce any errors. (It is, of course, our standard practice to require that the langtools jtreg suite run without errors before any patch is approved.) * There should be a final merge of the type annotations repository with the jdk9 langtools repository. Following that, I propose discontinuing the type annotations repo. Any changes to type annotations after that point should be done as patches to jdk9/dev/langtools. -------------- next part -------------- A non-text attachment was scrubbed... Name: eric_mccorkle.vcf Type: text/x-vcard Size: 303 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20140131/91a33f53/eric_mccorkle.vcf From eric.mccorkle at oracle.com Fri Jan 31 08:29:25 2014 From: eric.mccorkle at oracle.com (Eric McCorkle) Date: Fri, 31 Jan 2014 11:29:25 -0500 Subject: JEP 190: Pluggable Static Analyzers In-Reply-To: <52E80589.90608@oracle.com> References: <52E6FF4C.50703@oracle.com> <52E76F1A.4060809@redhat.com> <52E800E4.8090603@oracle.com> <52E80589.90608@oracle.com> Message-ID: <52EBCF65.5050108@oracle.com> On 01/28/14 14:31, Jonathan Gibbons wrote: > On 01/28/2014 11:11 AM, Eric McCorkle wrote: >> On 01/28/14 03:49, Florian Weimer wrote: >>> On 01/28/2014 01:52 AM, Jonathan Gibbons wrote: >>>> Why is JEP 190 different from the support already in javac for >>>> pluggable >>>> static analyzers, such as provided by -Xplugin? >>> The JSR 269 interface does not provide access to expressions and method >>> bodies. It happens that through this interface, javac internals which >>> provide this information are available after casting to internal javac >>> classes. However, this is not a supported interface, and the internal >>> javac data structures are not directly suited to implementing analysis >>> passes. >>> >> An eventual goal of the system envisioned by JEP 190 is to allow >> analysis tools to operate on javac's trees as opposed to source or >> bytecode (as is common now). Of course, there are quite a few >> intermediate steps that have to be taken to realize that goal. > > You can easily do this in JDK 8 with -Xplugin, using the com.sun.source > API. com.sun.source is a public supported API. Are you suggesting that > is not enough, and that you want to start investigating a standard > javax.* AST API? > > The one piece that is missing in the -Xplugin world is easy access to > the proto-bytecodes from a plugin. > > -- Jon Standardizing a javax AST API is a definite possibility. Obviously, there needs to be a great deal of care taken in the design of such an API. However, I stress that this is a *research* JEP, not a feature JEP; therefore, its purpose is solely to investigate questions like "would it be useful to add a javax AST, or a proto-bytecode API". It is *not* a goal of this JEP to produce such an API. -------------- next part -------------- A non-text attachment was scrubbed... Name: eric_mccorkle.vcf Type: text/x-vcard Size: 314 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20140131/1d7184dc/eric_mccorkle.vcf From eric.mccorkle at oracle.com Fri Jan 31 09:05:18 2014 From: eric.mccorkle at oracle.com (Eric McCorkle) Date: Fri, 31 Jan 2014 12:05:18 -0500 Subject: JEP 190: Pluggable Static Analyzers In-Reply-To: References: <52E6FF4C.50703@oracle.com> <52E76F1A.4060809@redhat.com> <52E800E4.8090603@oracle.com> <52E80589.90608@oracle.com> <52E8283C.20704@oracle.com> Message-ID: <52EBD7CE.8020103@oracle.com> On 01/29/14 02:59, Jeremy Manson wrote: > The combination of the fact that no one else seems to build significant > tooling on it (AFAICT), the fact that we've had to deal with a steady > trickle of incompatibilities, and the fact that various desugarings / > lowerings happen before the AST is built, have combined to make us think > that javac isn't being taken seriously as a tooling API. OTOH, javac > has the benefit that it *is* the source of truth, it is easy to > integrate analyses with compilation, and we don't have to worry about > you guys screwing it up / abandoning it. Given that this is a research JEP, I would prefer to think more in terms of "what API's/features/etc would be useful to have", rather than the current oddities of javac. There is already a sizable amount of refactoring being undertaken, so I think it would be more productive if we don't focus on those aspects here. > I would support a JEP that states clearly and decisively, "as of Java 9, > we are treating javac seriously as a tooling API, and outstanding issues > will be resolved". If someone is committing time and resources to that, > that's a good thing. Perhaps I read too much into this JEP. That sort of statement is way beyond the scope of this JEP. This is a *research* JEP intended to investigate a number of possible directions for exposing javac internals. It is not a goal of this JEP to implement an new feature, or an update to any existing feature. > (There was a lot of talk in the JEP about type annotations, but, AFAICT, > those aren't a major issue, and tools like the Checker Framework seem to > do pretty well with what exists, plus -Xplugin. OTOH, it's reasonably > true that someone needs to build a non-researchy way of doing serious > data and control flow analyses for Java; Soot is a pile of cruft at this > point, and Wala has an immutable CFG, which makes certain kinds of > things tricky.) Type annotations provides a very flexible system for attaching additional information to types. One possible use of this might be to provide a mechanism for extending the type system (though this is just a possibility, and such a mechanism needs to be designed very carefully). > > As for other solutions... We are in a position where we would like to > have a formatter built into our static tooling in the near term, so > we're actively looking at other solutions (for formatting) now. ecj and > IntelliJ both have parsers that people use to build substantial amounts > of tooling. They even have existing formatters! ecj seems to have a > lot of legacy issues, but IntelliJ looks potentially promising. We're > looking into it. I think these requests, while worth considering, aren't within the focus of this JEP. This JEP focuses on the middle stages of the compilation pipeline, while these goals seem more focused on parsing. > > Jeremy -------------- next part -------------- A non-text attachment was scrubbed... Name: eric_mccorkle.vcf Type: text/x-vcard Size: 314 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20140131/ae5d07ae/eric_mccorkle.vcf From eric.mccorkle at oracle.com Fri Jan 31 09:13:33 2014 From: eric.mccorkle at oracle.com (eric.mccorkle at oracle.com) Date: Fri, 31 Jan 2014 17:13:33 +0000 Subject: hg: jdk8/tl/jdk: 8033278: Missed access checks for Lookup.unreflect* after 8032585 Message-ID: <20140131171358.56F0A62926@hg.openjdk.java.net> Changeset: f684c9773858 Author: vlivanov Date: 2014-01-31 21:07 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f684c9773858 8033278: Missed access checks for Lookup.unreflect* after 8032585 Reviewed-by: jrose, twisti ! src/share/classes/sun/invoke/util/VerifyAccess.java ! test/java/lang/invoke/ProtectedMemberDifferentPackage/Test.java ! test/java/lang/invoke/ProtectedMemberDifferentPackage/p1/T2.java ! test/java/lang/invoke/ProtectedMemberDifferentPackage/p2/T3.java From eric.mccorkle at oracle.com Fri Jan 31 09:44:11 2014 From: eric.mccorkle at oracle.com (Eric McCorkle) Date: Fri, 31 Jan 2014 12:44:11 -0500 Subject: Webrev for making parts of TypeAnnotationPosition immutable Message-ID: <52EBE0EB.1000703@oracle.com> The following webrev implements a number of changes to TypeAnnotationPosition. It makes most of the core data immutable, and changes the way that TypeAnnotationPositions are created. As opposed to the zero-argument constructor with mutable fields, TypeAnnotationPositions are now created using static methods. This patch also marks some field and methods as deprecated (in comments), as I plan to remove them in forthcoming patches. One possibility that came up in review was making TypeAnnotationPosition an abstract superclass, and having subclasses for each of the different variants. I also could not make some of the fields final (type_index, exception_index, offset), as they are modified by Gen. This is most visible in the updated ClassReader. I will be investigating ways to deal with this in forthcoming patches. The webrev is here: http://cr.openjdk.java.net/~emc/8033004/webrev/ This patch has already been reviewed by the javac team; however, I would like to give a chance for any tools (such as checkers), that currently use type annotations to run tests before I integrate it. Please look over the patch, and run any tests that should be run. Thanks, Eric -------------- next part -------------- A non-text attachment was scrubbed... Name: eric_mccorkle.vcf Type: text/x-vcard Size: 303 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20140131/e5456211/eric_mccorkle.vcf From eric.mccorkle at oracle.com Fri Jan 31 09:47:46 2014 From: eric.mccorkle at oracle.com (Eric McCorkle) Date: Fri, 31 Jan 2014 12:47:46 -0500 Subject: Updated type annotations roadmap In-Reply-To: <52EBCD91.40704@oracle.com> References: <52EBCD91.40704@oracle.com> Message-ID: <52EBE1C2.3000209@oracle.com> On 01/31/14 11:21, Eric McCorkle wrote: > Any changes to type annotations after that > point should be done as patches to jdk9/dev/langtools. > Clarifying here: any changes to *the javac portion of* type annotations should be done as patches to jdk9/dev/langtools. Changes to the jdk portion should be done as patches to jdk9/dev/jdk, and changes to the hotspot runtime should be done as patches to jdk9/hs-rt/hotspot/ -------------- next part -------------- A non-text attachment was scrubbed... Name: eric_mccorkle.vcf Type: text/x-vcard Size: 303 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20140131/bc6d7ae4/eric_mccorkle.vcf