JDK 9 RFR of JDK-8031360: Update langtools code base to use RELEASE_9

Jonathan Gibbons jonathan.gibbons at oracle.com
Tue Jan 7 12:54:31 PST 2014


Looks good to me.

-- Jon


On 01/07/2014 12:00 PM, Joe Darcy wrote:
> Hello,
>
> Please review the patch below for
>
>     JDK-8031360: Update langtools code base to use RELEASE_9
>
> which further updates the langtools code base to use the 
> SourceVersion.RELEASE_9 constant.
>
> Thanks,
>
> -Joe
>
>  /*
> - * Copyright (c) 2002, 2013, Oracle and/or its affiliates. All rights 
> reserved.
> + * Copyright (c) 2002, 2014, Oracle and/or its affiliates. All rights 
> reserved.
>   * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>   *
>   * This code is free software; you can redistribute it and/or modify it
> @@ -251,7 +251,7 @@
>          case JDK1_8:
>              return RELEASE_8;
>          case JDK1_9:
> -            return RELEASE_8; // Adjust once RELEASE_9 exists
> +            return RELEASE_9;
>          default:
>              return null;
>          }
> diff -r 0d0ca880c22e 
> src/share/classes/com/sun/tools/javac/processing/PrintingProcessor.java
> --- 
> a/src/share/classes/com/sun/tools/javac/processing/PrintingProcessor.java 
> Tue Jan 07 11:43:56 2014 -0800
> +++ 
> b/src/share/classes/com/sun/tools/javac/processing/PrintingProcessor.java 
> Tue Jan 07 12:00:32 2014 -0800
> @@ -49,7 +49,7 @@
>   * deletion without notice.</b>
>   */
>  @SupportedAnnotationTypes("*")
> - at SupportedSourceVersion(SourceVersion.RELEASE_8)
> + at SupportedSourceVersion(SourceVersion.RELEASE_9)
>  public class PrintingProcessor extends AbstractProcessor {
>      PrintWriter writer;
>
> diff -r 0d0ca880c22e 
> test/tools/javac/lib/JavacTestingAbstractProcessor.java
> --- a/test/tools/javac/lib/JavacTestingAbstractProcessor.java Tue Jan 
> 07 11:43:56 2014 -0800
> +++ b/test/tools/javac/lib/JavacTestingAbstractProcessor.java Tue Jan 
> 07 12:00:32 2014 -0800
> @@ -1,5 +1,5 @@
>  /*
> - * Copyright (c) 2010, 2011, Oracle and/or its affiliates. All rights 
> reserved.
> + * Copyright (c) 2010, 2014, Oracle and/or its affiliates. All rights 
> reserved.
>   * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>   *
>   * This code is free software; you can redistribute it and/or modify it
> @@ -102,7 +102,7 @@
>       * corresponding platform visitor type.
>       */
>
> -    @SupportedSourceVersion(RELEASE_8)
> +    @SupportedSourceVersion(RELEASE_9)
>      public static abstract class AbstractAnnotationValueVisitor<R, P> 
> extends AbstractAnnotationValueVisitor8<R, P> {
>
>          /**
> @@ -113,7 +113,7 @@
>          }
>      }
>
> -    @SupportedSourceVersion(RELEASE_8)
> +    @SupportedSourceVersion(RELEASE_9)
>      public static abstract class AbstractElementVisitor<R, P> extends 
> AbstractElementVisitor8<R, P> {
>          /**
>           * Constructor for concrete subclasses to call.
> @@ -123,7 +123,7 @@
>          }
>      }
>
> -    @SupportedSourceVersion(RELEASE_8)
> +    @SupportedSourceVersion(RELEASE_9)
>      public static abstract class AbstractTypeVisitor<R, P> extends 
> AbstractTypeVisitor8<R, P> {
>          /**
>           * Constructor for concrete subclasses to call.
> @@ -133,7 +133,7 @@
>          }
>      }
>
> -    @SupportedSourceVersion(RELEASE_8)
> +    @SupportedSourceVersion(RELEASE_9)
>      public static class ElementKindVisitor<R, P> extends 
> ElementKindVisitor8<R, P> {
>          /**
>           * Constructor for concrete subclasses; uses {@code null} for 
> the
> @@ -154,7 +154,7 @@
>          }
>      }
>
> -    @SupportedSourceVersion(RELEASE_8)
> +    @SupportedSourceVersion(RELEASE_9)
>      public static class ElementScanner<R, P> extends 
> ElementScanner8<R, P> {
>          /**
>           * Constructor for concrete subclasses; uses {@code null} for 
> the
> @@ -173,7 +173,7 @@
>          }
>      }
>
> -    @SupportedSourceVersion(RELEASE_8)
> +    @SupportedSourceVersion(RELEASE_9)
>      public static class SimpleAnnotationValueVisitor<R, P> extends 
> SimpleAnnotationValueVisitor8<R, P> {
>          /**
>           * Constructor for concrete subclasses; uses {@code null} for 
> the
> @@ -194,7 +194,7 @@
>          }
>      }
>
> -    @SupportedSourceVersion(RELEASE_8)
> +    @SupportedSourceVersion(RELEASE_9)
>      public static class SimpleElementVisitor<R, P> extends 
> SimpleElementVisitor8<R, P> {
>          /**
>           * Constructor for concrete subclasses; uses {@code null} for 
> the
> @@ -215,7 +215,7 @@
>          }
>      }
>
> -    @SupportedSourceVersion(RELEASE_8)
> +    @SupportedSourceVersion(RELEASE_9)
>      public static class SimpleTypeVisitor<R, P> extends 
> SimpleTypeVisitor8<R, P> {
>          /**
>           * Constructor for concrete subclasses; uses {@code null} for 
> the
> @@ -236,7 +236,7 @@
>          }
>      }
>
> -    @SupportedSourceVersion(RELEASE_8)
> +    @SupportedSourceVersion(RELEASE_9)
>      public static class TypeKindVisitor<R, P> extends 
> TypeKindVisitor8<R, P> {
>          /**
>           * Constructor for concrete subclasses to call; uses {@code 
> null}
>



More information about the compiler-dev mailing list