Fwd: Re: Review Request - 2 : JDK-8031670: remove unneeded -source option from javadoc tests

[Neil Toda]

-------- Original Message --------
Subject: 	Re: Review Request - 2 : JDK-8031670: remove unneeded -source 
option from javadoc tests
Date: 	Mon, 03 Mar 2014 09:08:26 -0800
From: 	Neil Toda <neil.toda at oracle.com>
Organization: 	Oracle Corporation
To: 	Vicente-Arturo Romero-Zaldivar <vicente.romero at oracle.com>




I'll fix that.  Thanks Vicente.

-neil

On 3/1/2014 1:02 PM, Vicente-Arturo Romero-Zaldivar wrote:
> On 27/02/14 16:13, Neil Toda wrote:
>> This is a Review Request resubmission with reviewer-based changes.
>>
>> Original Description:
>>
>>     A small set of javadoc tests contain the -source parameter.  In
>>     most cases, the parameter is
>>     not required for the test.  In several cases, the -source
>>     parameter is being explicitly tested,
>>     but relies on a JDK version that will be removed from JDK9.
>>
>>     This changeset removes unnecessary -source specification when not
>>     needed, or changes the
>>     test/source-version requested to one that will work in JDK9
>>
>>
>> The revised changeset-webrev can be found here:
>>
>> http://cr.openjdk.java.net/~darcy/neiltoda/8031670.1/
>
> Hi,
>
> The change is OK for me, there is a typo in a test note of test: 
> test/tools/javadoc/sourceOption/SourceOption.java
>
> "With JDK9, _this this_ test has been transformed into a NEGATIVE test."
>
> You don't need another review round for this.
>
> Thanks,
> Vicente.
>
>>
>>
>> Changes from first submittal:
>>
>>   * in ./test/com/sun/javadoc/testLambdaFeature/TestLambdaFeature.java
>>     * correct spelling error : amy -> may
>>     * remove comment on test from jtreg tag block
>>   * to validate -source option operation
>>     * reinstate ./sourceOption test
>>     * in ./test/tools/javadoc/sourceOption/SourceOption.java
>>       * changed to a negative test to make sure javac lambda 
>> construct is not in 1.7
>>       * add information about updating test periodically
>>       * add a fixVersion bug [ set to 1.10 for current targeted feature ]
>>     * added ./test/tools/javadoc/sourceOption/p/LambdaConstructTest.java
>>       * valid for 1.8, but not for 1.7. "-source 1.7" is checked with 
>> this code.
>>     * added ./test/tools/javadoc/sourceOption2/SourceOption2.java
>>       * This test is a positive test to make sure that the lambda 
>> construct provided for ./sourceOption is valid for 8.
>>       * This test is actually examining 
>> ./sourceOption/p/LambdaConstructTest.java
>>
>> Thanks
>>
>> -neil
>>
>



-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20140303/2dd0d3a8/attachment.html