JDK 9 RFR of JDK-8036842: Remove unneeded/obsolete -source/-target	options in javac tests, part 2
    Sonali Goel 
    sonali.goel at oracle.com
       
    Fri Mar  7 10:06:50 UTC 2014
    
    
  
Hello,
The changes look fine. A couple of questions/comments:
- test/tools/javac/meth/InvokeMH.java - Why did you remove -source 7 
-target 7 from the code?
- test/tools/javac/api/T6265137.java - Why is -source 9 needed?
- test/tools/javac/ClassLit.java - trivial comment - no need to add 
@compile line
Thanks,
Sonali
On 3/6/2014 11:40 PM, Joe Darcy wrote:
> Hello,
>
> Please review the webrev of changes for
>
>     JDK-8036842: Remove unneeded/obsolete -source/-target options in 
> javac tests, part 2
>     http://cr.openjdk.java.net/~darcy/8036842.0/
>
> The langtools regression tests suite still passes with these changes 
> in place.
>
> Thanks,
>
> -Joe
    
    
More information about the compiler-dev
mailing list