RFR: 8035063: Option handling in sjavac needs to be rewritten

[Andreas Lundblad]

Do you mean it should filter out directories with, say dashes, automatically?

My feeling is that that's a brittle approach. If someone renames a directory from something that doesn't happen to be a valid package identifier into something that happens to be a valid package identifier, it could break the build. (Despite there were no trace of the original package name in the build files.)

Having to explicitly exclude all directories that shouldn't be part of the build (not just the ones that happen to have valid package names) seems more robust to me.

-- Andreas


----- Original Message -----
From: jonathan.gibbons at oracle.com
To: compiler-dev at openjdk.java.net
Sent: Wednesday, March 19, 2014 5:20:10 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna
Subject: Re: RFR: 8035063: Option handling in sjavac needs to be rewritten

I think sjavac should filter out all directories which could not 
correspond to package names.

-- Jon