RFR: 8042441: sjavac does not properly track dependencies in two cases.

Fredrik Öhrström oehrstroem at gmail.com
Tue May 6 22:17:46 UTC 2014

Hi compiler-dev,

Please review this fix for JDK-8042441 which fixes two dependency tracking
failures in sjavac.

A fully qualified identifier for example "alfa.A a;" is not tracked,
but "import alfa.A; ... A a;" is tracked. The fix tracks the fully
qualified identifier by instrumenting Attr.java with a reportDependence in
the same way that Resolve.java is already instrumented. Thanks Jan Lahoda
for the help on where to instrument.

Also, the previous change from . to / in the arguments accidentally broke
the dependencies inside the javac_state file. A trivial fix is supplied for
this, however the tests did not catch this, since the tests did not use
packages with more than one level, ie no dots...thus the tests are improved
to actually detect this kind of error.

Link to webrev:

Link to bug report:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20140507/e82c7310/attachment-0001.html>

More information about the compiler-dev mailing list