RFR: 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way

[Fredrik Öhrström]

Very nice cleanup!


2014-05-07 16:51 GMT+02:00 Andreas Lundblad <andreas.lundblad at oracle.com>:

> On Mon, May 05, 2014 at 01:18:03PM +0200, Fredrik Öhrström wrote:
> > The output from stdout and stderr from the background must always be
> logged
> > into a file. The default name for that file is portfile+".stdouterr"
> > Thus you could replace stdouterrfile == null with
> >
> > assert(stdouterrfile != null && stdouterrfile.length() >= 1)
> >
> > And get rid of /dev/null etc.
>
> Fixed. (I went for IllegalArgumentException to avoid nasty exceptions when
> running without -ea.)
>
> See new revision here:
>
> http://cr.openjdk.java.net/~alundblad/8042088/webrev.01/
>
> -- Andreas
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20140507/f47c5456/attachment-0001.html>