RFR: 8042441: sjavac does not properly track dependencies in two cases.

Jonathan Gibbons jonathan.gibbons at oracle.com
Wed May 7 21:38:41 UTC 2014


The test needs the bug number 8042441 in the @bug line for the test, but 
other than that, you're good to go.

-- Jon
]
On 05/07/2014 02:34 PM, Fredrik Öhrström wrote:
> And I shrunk the size of the webrev in place, please reload and reread.
>
>
> 2014-05-07 8:05 GMT+02:00 Fredrik Öhrström <oehrstroem at gmail.com 
> <mailto:oehrstroem at gmail.com>>:
>
>     2014-05-07 0:57 GMT+02:00 Jonathan Gibbons
>     <jonathan.gibbons at oracle.com <mailto:jonathan.gibbons at oracle.com>>:
>
>
>         Also, in Attr.java, you have "broken" a javac convention of
>         placing private utility methods nearby their usage, introduced
>         by a "// where" comment. By placing the new method where you
>         have, you have separated visitSelect from the "// where"
>         method that follows it.
>
>
>      I see. Fixed. Uploaded the fixed webrev in place. Please reload.
>
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20140507/90838ed4/attachment.html>


More information about the compiler-dev mailing list