RFR: 8058445 | was Re: [PATCH]8058445: Javac throws exception when displaying info

[Jonathan Gibbons]

Vicente points out that I misread the original patch, so yes, Shinya, 
you did propose the correct patch :-)   But it is still good to have a 
test as well.

-- Jon

On 11/14/2014 05:01 PM, Jonathan Gibbons wrote:
> Shinya,
>
> Thanks for looking at this issue and submitting your patch.
>
> The intent of GrumpyHelper is that by default it *should* throw 
> exceptions, and so it is not desirable to suppress that behavior in 
> general.  A better fix is to override the method in the anonymous 
> class that is used when no args are given.
>
> In addition, changes should generally come with regression tests, 
> unless there is a good reason not to.
>
> With those two points in mind, I have posted a revised patch for the 
> consideration and review by javac Reviewers:
> webrev: http://cr.openjdk.java.net/~jjg/8058445/webrev.00
>
> -- Jon
>
>
>
> On 11/14/2014 10:30 AM, Martin Buchholz wrote:
>> Shinya's message may not have been noticed; adding compiler-dev.
>>
>> On Thu, Nov 13, 2014 at 8:05 AM, bitter_fox <bitterfoxc at gmail.com> 
>> wrote:
>>> Hi,
>>> I have a patch for "8058445: Javac throws exception when displaying 
>>> info."
>>> Could you review and merge my patch?
>>> (Please ignore my patch when someone is already working for this issue)
>>>
>>> The cause is OptionHelper.GrumpyHelper#put throws IAE and it has not 
>>> been
>>> overrided.
>>> So I override it and do not anything.
>>>
>>> webrev: http://cr.openjdk.java.net/~shinyafox/8058445/webrev.00/
>>> issue: https://bugs.openjdk.java.net/browse/JDK-8058445
>>>
>>> Regards,
>>> Shinya Yoshida(@bitter_fox)
>