RFR: 8058445 | was Re: [PATCH]8058445: Javac throws exception when displaying info

[Jonathan Gibbons]

Thanks.

-- Jon

On 11/17/2014 01:46 PM, Joel Borggrén-Franck wrote:
> Hi,
>
>> On 15 Nov 2014, at 02:01, Jonathan Gibbons <jonathan.gibbons at oracle.com> wrote:
>>
>> Shinya,
>>
>> Thanks for looking at this issue and submitting your patch.
>>
>> The intent of GrumpyHelper is that by default it *should* throw exceptions, and so it is not desirable to suppress that behavior in general.  A better fix is to override the method in the anonymous class that is used when no args are given.
>>
>> In addition, changes should generally come with regression tests, unless there is a good reason not to.
>>
>> With those two points in mind, I have posted a revised patch for the consideration and review by javac Reviewers:
>> webrev: http://cr.openjdk.java.net/~jjg/8058445/webrev.00
>>
> Looks good Jon.
>
> cheers
> /Joel
>