<Langtools> [7u] Review Request: JDK-8064454 Fix type in langtools for tools/javac/innerClassFile/Driver.sh

[pooja chopra]

Hi Maurizio ,

There is already a bug JDK-8057527 
<https://bugs.openjdk.java.net/browse/JDK-8057527>: 
tools/javac/innerClassFile/Driver.sh fails to cleanup files after it 
because of which ' rm -rf src  ' piece of code was added so if we remove 
this then again bug JDK-8057527 
<https://bugs.openjdk.java.net/browse/JDK-8057527> will occur.

Regards,
Pooja
On 1/22/2015 11:13 PM, pooja chopra wrote:
> Hi Maurizio,
>
> In JDK 8  as I saw ' rm -rf src  '  line of code has been simply 
> removed from the code  but  "src"  folder was temporarily created 
> using 'mkdir src' in the Driver.sh code so I believe it should be 
> removed if its created after use. Please suggest further .
>
> Regards,
> Pooja
> On 1/22/2015 7:05 PM, Maurizio Cimadamore wrote:
>> It seems like the problematic rm in the last line has been removed 
>> i.e. in JDK 8?
>>
>> http://hg.openjdk.java.net/jdk8u/jdk8u-dev/langtools/file/2d2b2be57c78/test/tools/javac/innerClassFile/Driver.sh 
>>
>>
>> Perhaps, instead of tweaking permission, we should just do things the 
>> JDK 8 way?
>>
>> Maurizio
>>
>> On 12/01/15 07:04, pooja chopra wrote:
>>> Hi All,
>>> Please review below fix .
>>>
>>> 8064454 [TEST_BUG] Test tools/javac/innerClassFile/Driver.sh fails 
>>> with exit code 1
>>> Test bug fix.
>>> https://bugs.openjdk.java.net/browse/JDK-8064454
>>> The webrev is: http://cr.openjdk.java.net/~kshefov/8064454/webrev.00/
>>>
>>> Regards,
>>> Pooja
>>> On 12/5/2014 11:09 AM, pooja chopra wrote:
>>>> Hi All,
>>>> Gentle Reminder . Please review below fix .
>>>>
>>>> 8064454 [TEST_BUG] Test tools/javac/innerClassFile/Driver.sh fails 
>>>> with exit code 1
>>>> Test bug fix.
>>>> https://bugs.openjdk.java.net/browse/JDK-8064454
>>>> The webrev is: http://cr.openjdk.java.net/~kshefov/8064454/webrev.00/
>>>>
>>>> Regards,
>>>> Pooja
>>>> On 11/10/2014 10:29 PM, pooja chopra wrote:
>>>>>
>>>>> Hello,
>>>>> Please review a fix for the issue:
>>>>> 8064454 [TEST_BUG] Test tools/javac/innerClassFile/Driver.sh fails 
>>>>> with exit code 1
>>>>> Test bug fix.
>>>>> https://bugs.openjdk.java.net/browse/JDK-8064454
>>>>> The webrev is: http://cr.openjdk.java.net/~kshefov/8064454/webrev.00/
>>>>>
>>>>> Thanks
>>>>> Pooja
>>>>
>>>
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20150122/cb6f1607/attachment.html>