RFR [9] 8080880: some docs cleanup for langtools

Jonathan Gibbons jonathan.gibbons at oracle.com
Fri Jul 10 23:51:39 UTC 2015


Looks OK to me.

-- Jon


On 05/22/2015 03:14 AM, alexander stepanov wrote:
> Hello Jonathan,
>
> Thanks.
>
> > It is not appropriate to do partial bulk update to the "not a 
> supported API"
>
> The responding changes were reverted, please see
> http://cr.openjdk.java.net/~avstepan/8080880/webrev.01/
>
> Regards,
> Alexander
>
> On 21.05.2015 21:56, Jonathan Gibbons wrote:
>>
>> On 05/21/2015 09:12 AM, alexander stepanov wrote:
>>> Hello,
>>>
>>> Could you please review the following fix
>>> http://cr.openjdk.java.net/~avstepan/8080880/webrev.00/
>>> for
>>> https://bugs.openjdk.java.net/browse/JDK-8080880
>>>
>>> Just some minor fix for docs, no other code touched.
>>>
>>> The affected packages should (probably) not be visible in the new 
>>> modular system, but nevertheless...
>>>
>>> Thanks,
>>> Alexander
>>
>> Alexander,
>>
>> It is not appropriate to do partial bulk update to the "not a 
>> supported API"
>> comment at the head of the internal files. It is strongly preferred 
>> that this
>> part of the comment remain consistent across all source files, so 
>> that it is
>> amenable to bulk updates, should we wish to do so.
>>
>> I would suggest you separate the otherwise useful work to fix individual
>> minor doc issues from any work involving the standard "not a supported
>> API" comment at the head of each file.
>>
>> -- Jon
>



More information about the compiler-dev mailing list