Code (Pre-)Review for JEP 280: Indify String Concat

[Aleksey Shipilev]

Hi Andrej,

Thanks for the review, I'll send the updated webrevs once I address
Maurizio's review comments.

On 11/26/2015 11:42 AM, Andrej Golovnin wrote:
>>  http://cr.openjdk.java.net/~shade/8085796/webrev.jdk.02/
> 
> src/java.base/share/classes/java/lang/Integer.java
> src/java.base/share/classes/java/lang/Long.java
> 
> I miss JavaDocs for the returned value of the methods #getChars(int,
> int, byte[]) and #getCharsUTF16(int, int, byte[]). And it would be
> nice to have JavaDocs for the parameters too.

Added, thanks!

> src/java.base/share/classes/java/lang/StringConcatHelper.java
> src/java.base/share/classes/java/lang/invoke/StringConcatException.java
> test/java/lang/String/concat/ImplicitStringConcatShapesTestGen.java
> test/java/lang/String/concat/update-tests.sh
> 
> The files do not have a copyright header.

Oops, good catch, added.

Thanks,
-Aleksey


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20151126/bbd754a5/signature.asc>