RFR: 8134759: jdb: Incorrect stepping inside finally block

[Andreas Eriksson]

LineNumberTestBase.java couldn't handle this particular test case, so 
I'll go ahead and push change with the original test.

Thanks,
Andreas

On 2015-10-22 16:48, Andreas Eriksson wrote:
> Thanks for looking at this.
> Andrey Nazarov asked that I change the standalone test to be a part of 
> test/tools/javac/classfiles/attributes/LineNumberTable/LineNumberTestBase.java 
> instead.
> I'll send out a new review once that's done.
>
> - Andreas
>
> On 2015-10-22 15:34, Maurizio Cimadamore wrote:
>> Looks good - thanks!
>>
>> Maurizio
>>
>> On 22/10/15 10:41, Andreas Eriksson wrote:
>>> Hi,
>>>
>>> Please review this change to javac, which fixes line number mappings 
>>> for non-void returns inside a try-finally.
>>> The pending line number was already saved and restored for void 
>>> returns, but not for methods where the return had a value.
>>> This change adds the save and restore of the line number for 
>>> non-void returns as well.
>>>
>>> Bug: 8134759 <https://bugs.openjdk.java.net/browse/JDK-8134759>: 
>>> jdb: Incorrect stepping inside finally block
>>> Webrev: http://cr.openjdk.java.net/~aeriksso/8134759/webrev.00/
>>>
>>> Regards,
>>> Andreas
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20151023/6b898a9a/attachment.html>