RFR 8149757:Implement Multi-Release jar aware JavacFileManager for javac

Jonathan Gibbons jonathan.gibbons at oracle.com
Wed Apr 6 23:17:17 UTC 2016

OK, good enough; at least the use of .ordinal is confined within the 
enum itself.

To be accurate, you are not making "the StandardJavaFileManager" 
multi-release jar aware.   StandardJavaFileManager is an interface that 
may have many different implementations.  You are making one particular 
implementation, the one provided by javac, multi-release aware.

-- Jon

On 04/06/2016 04:00 PM, Steve Drach wrote:
> Hi,
> I’ve updated the webrev to include a new method on Target as suggested.
> Steve
>> On Apr 5, 2016, at 2:02 PM, Steve Drach <steve.drach at oracle.com 
>> <mailto:steve.drach at oracle.com>> wrote:
>> Hi,
>> Please review the changes required to make javac and the 
>> StandardJavaFileManager multi-release jar aware.  For javac, the 
>> version of the classes in a multi-release.jar is selected by the 
>> -release (or -target) command line option, or if the option is not 
>> present, javac’s default policy is used to select the version — 
>> typically the runtime version (i.e. version 9 is selected for JDK 9). 
>>  For the StandardJavaFileManager, the version is selected with the 
>> handleOption method.  See the tests for more detail.
>> issue: https://bugs.openjdk.java.net/browse/JDK-8149757
>> webrev: http://cr.openjdk.java.net/~sdrach/8149757/webrev/index.html 
>> <http://cr.openjdk.java.net/%7Esdrach/8149757/webrev/index.html>
>> Thank you,
>> Steve

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20160406/4d60cc14/attachment.html>

More information about the compiler-dev mailing list