MethodSymbol.implementedIn

Liam Miller-Cushon cushon at google.com
Thu Apr 21 15:57:57 UTC 2016


Hi, I have a question about MethodSymbol.implementedIn:
http://hg.openjdk.java.net/jdk9/dev/langtools/file/9b37d0f28609/src/jdk.compiler/share/classes/com/sun/tools/javac/code/Symbol.java#l1620

I think the FIXME about using subst() is incorrect, Types.memberType takes
care of that.

But testing that the return types are the same still looks wrong, because
it doesn't handle implementations with covariant return types.

I'm not sure why implementedIn is testing return types at all: it calls
MethodSymbol.overrides, which checks return types.

So perhaps the call to isSameType in implementedIn can just be removed?
Deleting it doesn't break any tests.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20160421/857f4178/attachment.html>


More information about the compiler-dev mailing list