RFR JDK-8164836: fix jdeprscan violations of tools/all/RunCodingRules.java

Kumar Srinivasan kumar.x.srinivasan at oracle.com
Fri Aug 26 19:53:09 UTC 2016


Hi Jan,

We should also excluded jdk.javadoc from this check, I don't see the
value of the @DefinedBy for this.

Thanks
Kumar

On 8/26/2016 5:00 AM, Jan Lahoda wrote:
> Hi,
>
> The RunCodingRules test is broken after 871b60b0c091, and has been 
> disabled. My proposal to fix this is to disable the DefinedByAnalyzer 
> for classes from the jdk.jdeps module. This module is not AFAIK 
> implementing the APIs, and so is not a primary target of the 
> analyzer/@DefinedBy annotation. One notable alternative would be to 
> disable the crules completely for jdk.jdeps, but I opted rather for a 
> more limited change. (Another alternative would be to add the 
> @DefinedBy annotations to classes jdk.jdeps, but that does not seem 
> quite right to me.)
>
> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8164836
> Webrev:
> http://cr.openjdk.java.net/~jlahoda/8164836/webrev.00/
>
> Jan



More information about the compiler-dev mailing list