Review Request: JDK-8165109: langtools/test switches to use new CLI options

[Amy Lu]

Great, so the only one failure left got resolved now by the additional diff.

All looks fine.(though I'm not official reviewer)

Thank you for the quick fix!


Thanks,
Amy

On 8/31/16 11:31 AM, Mandy Chung wrote:
> diff --git a/test/tools/javac/diags/examples/ProcessorPathNoProcessorModulePath/ProcessorPathNoProcessorModulePath.java b/test/tools/javac/diags/examples/ProcessorPathNoProcessorModulePath/ProcessorPathNoProcessorModulePath.java
> --- a/test/tools/javac/diags/examples/ProcessorPathNoProcessorModulePath/ProcessorPathNoProcessorModulePath.java
> +++ b/test/tools/javac/diags/examples/ProcessorPathNoProcessorModulePath/ProcessorPathNoProcessorModulePath.java
> @@ -22,6 +22,6 @@
>    */
>   
>   // key: compiler.err.processorpath.no.processormodulepath
> -// options: -processormodulepath mods -processorpath mods
> +// options: --processor-module-path mods -processorpath mods
>   
>   class ProcessorPathNoProcessorModulePath {}
>
>> On Aug 30, 2016, at 8:30 PM, Jonathan Gibbons <jonathan.gibbons at oracle.com> wrote:
>>
>> Fix is in the comments in the new bug.
>>
>> -- Jon
>>
>> On 08/30/2016 08:07 PM, Mandy Chung wrote:
>>> Hi Amy,
>>>
>>> Can you file a new JBS issue for CheckExamples.java test?  This probably would need Jon or Jan to help.
>>>
>>> thanks
>>> Mandy
>>>
>>>> On Aug 30, 2016, at 7:57 PM, Amy Lu <amy.lu at oracle.com> wrote:
>>>>
>>>> Hi, Mandy
>>>>
>>>> Thank you for the quick fix!
>>>>
>>>> I just noticed that this patch does not include the fix for test tools/javac/diags/CheckExamples.java, which starts failing after removal of old module-related options. Will it fix in another bugid?
>>>>
>>>> Thanks,
>>>> Amy
>>>>
>>>> On 8/31/16 10:41 AM, Mandy Chung wrote:
>>>>> Some langtools tests are stil using -release and -mp that are removed in [1].
>>>>>
>>>>> Webrev:
>>>>>    http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8165109/webrev.00/
>>>>>
>>>>> thanks
>>>>> Mandy
>>>>> [1] http://hg.openjdk.java.net/jdk9/dev/langtools/rev/047d4d42b466